com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.
gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engi
+1
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
> On Mar 12, 2019, at 8:06 AM, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a
> On Mar 11, 2019, at 3:15 PM, Joe Wang wrote:
>
>
>
> On 3/11/19, 11:54 AM, Lance Andersen wrote:
>>
>> Hi Joe,
>>
>>> On Mar 11, 2019, at 2:41 PM, Joe Wang >> <mailto:huizhe.w...@oracle.com>> wrote:
>>>
>>&g
ersion: actual: 4.0, expected: 4.0
> indent: actual: yes, expected: yes
> media-type: actual: text/html, expected: text/html
>
> Best,
> Joe
>
> On 3/11/19, 11:31 AM, Lance Andersen wrote:
>>
>> Hi Joe
>>
>> I think this is fine. I might consider beefi
acle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Netw
Suppressed exceptions not
> recorded
> return;
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
nese locales between JDK and CLDR, in terms of
> Simplified/Traditional scripts.
>
> Naoto
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.
e.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
p://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
racle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
gn/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
> is a test case
>> testJARManifestClassPathAttribute/testClassPathAttribute which I have
>> no clue how this should really work. As far as I can tell the test is
>> and was wrong but nevertheless passes.
>>
>> Is there a chance to find a sponsor for fixing this?
>>
>>
t; Regards,
> Philipp
>
>
> On Fri, 2019-02-15 at 18:10 -0500, Lance Andersen wrote:
>> Hi Philipp
>>
>> This probably makes sense to update.
>>
>> Can you also update the ToolProviderTest.java to add a test for the changes
>>
>> Thank
/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
acle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
t; I'd be surprised if there is a JCK test expecting NPE. Will see.
>> I suggest to update @param record to say "a LogRecord or null"
>> to be explicit.
>> Mandy
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/
Hi Daniel,
> On Feb 14, 2019, at 2:22 PM, Daniel Fuchs wrote:
>
> Hi Lance,
>
> On 14/02/2019 20:18, Lance Andersen wrote:
>> Documenting the current behavior as it has been makes the most sense to me
>> as well
>> Have you created a CSR yet? if so I will
;
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
see http://openjdk.java.net/jtreg/tag-spec.html for the system
properties. I do not see test.dir there.
—
I would just do:
—
Path foo = Path.of("test.zip");
System.out.println("test.zip path=" + foo.toAbsolutePath());
--
which results in the
quot;zip:permissions" and we'll document this. If a user of zipfs wants
>> to see full PosixFileAttributeView support with default values, then we
>> should allow for a creation attribute for the zipfs that can control this.
>> Maybe
>> we can even allow specifying default values for user, group and permissions
>> via zipfs attributes.
>>
>> I'll work to develop the patch into this direction unless you tell me that
>> this
>> idea is bogus (if so, then I hope it be soon )
>>
>> Thanks
>> Christoph
>>
>>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
p://cr.openjdk.java.net/~joehw/jdk13/8187697/webrev/
>
> Thanks,
> Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://
/oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff |
stoph
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Thank you for the feedback. Please see below
> On Feb 5, 2019, at 3:31 AM, Alan Bateman wrote:
>
> A few comments
>
> On 04/02/2019 19:36, Lance Andersen wrote:
>> :
>>
>> + * The Zip file system provider treats a Zip or JAR file as a file system
>>
t;http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Techn
-
> On Feb 4, 2019, at 1:50 PM, Roger Riggs wrote:
>
> Hi Lance,
>
> That looks ok; editorial suggestions below:
>
>
> On 02/04/2019 12:40 PM, Lance Andersen wrote:
>> Hi all
>>
>> Please review the fix for https://bugs.openjdk.java.net/browse
~joehw/jdk13/8206132/webrev/
>>>
>>> Thanks,
>>> Joe
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
gt;
> Naoto
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Princi
stemProvider
* @moduleGraph
* @since 9
$
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle
Thanks,
> Joe
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal M
AlgorithmChecker,
> * and DisabledAlgorithmConstraints.
> */
> public class ConstraintsParameters {
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig
t; - * OK/CANCEL confirmation confirmation option.
> + * OK/CANCEL confirmation option.
> *
> * An underlying security service specifies this as the
> * {@code optionType} to a {@code ConfirmationCallback}
> Index: src/java.base/share/classes/jdk/internal/
JBS: https://bugs.openjdk.java.net/browse/JDK-8216408
>>> webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8216408/webrev/
>>>
>>> Thanks,
>>> Joe
>>>
>>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/
represent the same mappings.
*
* @param o the Object to be compared
* @return true if the specified Object is equal to this Map
-
> On Jan 25, 2019, at 2:53 PM, Lance Andersen wrote:
>
> Hi Joe
>
> yes I checked it in my local build and it does
> On 1/25/2019 11:44 AM, Lance Andersen wrote:
>> Thank you Joe.
>>
>> So the change is (see bolded change):
>>
>> $ hg diff
>> diff -r 6130409b923e
>> src/java.base/share/classes/java/util/jar/Attributes.java
>> --- a/src/java.base/share/cl
:24 AM, Roger Riggs wrote:
>> Looks fine, Lance
>>
>> Roger
>>
>> On 01/25/2019 02:22 PM, Lance Andersen wrote:
>>> The CSR review suggested a slight update to the proposed wording:
>>>
>>> ———
>>> $ hg diff
>>>
* @return true if the specified Object is equal to this Map
*/
—
Best
Lance
> On Jan 22, 2019, at 7:47 PM, Lance Andersen wrote:
>
>>
>> On Jan 22, 2019, at 12:02 PM, Alan Bateman wrote:
>>
>> On 19/01/2019 12:46, Lance Andersen wrote:
>
/~joehw/jdk13/8216408/webrev/
>
> Thanks,
> Joe
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-
> On Jan 25, 2019, at 3:55 AM, Alan Bateman wrote:
>
>
>
> On 25/01/2019 00:11, Lance Andersen wrote:
>>> On Jan 24, 2019, at 6:20 PM, Mandy Chung wrote:
>>>
>>>
>>>
>>> On 1/24/19 1:55 PM,
> On Jan 24, 2019, at 6:20 PM, Mandy Chung wrote:
>
>
>
> On 1/24/19 1:55 PM, Lance Andersen wrote:
>>
>>> Alternatively you can simply do:
>>> PrivilegedExceptionAction pea = () ->
>>> tempPath.toRealPath();
>&
Hi Mandy,
> On Jan 24, 2019, at 4:50 PM, Mandy Chung wrote:
>
>
>
> On 1/24/19 12:48 PM, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the following patch which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8210469
>> <https:/
empPath.toRealPath()
> 327 , null,
> 328 new java.util.PropertyPermission("user.dir", "read"));
>
thanks for catching that, I agree, it should not be there, I think I just saw
what I wanted to see. :-)
I updated the webrev in place as there is no other change
Best
La
-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
00.
> (webrev updated in place).
> http://cr.openjdk.java.net/~dfuchs/webrev_8217353/webrev.00/
>
> Hopefully that will reduce the frequency of failures.
> Re testing in progress...
>
> best regards,
>
> -- daniel
>
> On 24/01/2019 12:14, Lance Andersen wrote:
>&
il-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
> On Jan 22, 2019, at 12:02 PM, Alan Bateman wrote:
>
> On 19/01/2019 12:46, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the fix for JDK-8217393 which updates the javadocs for
>> Attriibutes::equals to clarify its behavior to match its implementatio
e
>> attached patch.
>>
>> Regards,
>> Philipp
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.
-value mappings.
*
* @param o the Object to be compared
* @return true if the specified Object is equal to this Map
———
Best,
Lance
> On Jan 17, 2019, at 6:50 PM, Lance Andersen wrote:
>
> Hi Philipp,
>
> I suspect the behavior dates back to the original
l-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
if>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
tp://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Tec
> On Jan 15, 2019, at 3:55 PM, Alan Bateman wrote:
>
>
>
> On 15/01/2019 18:59, Lance Andersen wrote:
>>
>> OK thank you. I made a ‘minor update to the comments and removed “4"
> Looks good. I also skimmed the update test and it looks okay too except s
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Lance
>
> Best regards
> Christoph
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324
> On Jan 15, 2019, at 4:07 AM, Alan Bateman wrote:
>
> On 15/01/2019 00:13, Lance Andersen wrote:
>> :
>>
>> Thank you Alan pointing out this example which the previous fix also did not
>> address. I updated the change which addresses the above example
> On Jan 14, 2019, at 2:05 PM, Alan Bateman wrote:
>
> On 12/01/2019 20:13, Lance Andersen wrote:
>> Hi all,
>>
>> The following patch addresses the issue where the stream of paths where not
>> relative to the specified directory as needed.
>>
&g
net/~rriggs/webrev-destroytest-8080569-2/
>>>
>>> Thanks, Roger
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8080569
>>> [2] https://bugs.openjdk.java.net/browse/JDK-8216990
>>>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
anks, Roger
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8080569
> [2] https://bugs.openjdk.java.net/browse/JDK-8216990
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracl
rather be: if (ds.iterator().hasNext()) throw…
The check is fine as it is but I changed it to make it clearer similar to
DirectoryStream/Basic.java
Again, thank you for your feedback.
Updated webrev is here
http://cr.openjdk.java.net/~lancea/8211919/webrev.01/index.html
Best
Lan
://cr.openjdk.java.net/~lancea/8211919/webrev.00/
Best
Lance
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-1983
ave to resort to
>>>> throwing an IOE?
>>>>
>>> Maybe although it would be a bit awkward to deal with. The issues around
>>> this remind me a bit about mounting fat32 file systems on Linux or Unix
>>> systems where the fields in the stat structure are populated with
>>> default values. PosixFileAttributeView::readAttributes is essentially
>>> the equivalent of a stat call. This might be something to look at for
>>> the file owner at least.
>>>
>>> -Alan
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
did not know it would be worthwhile. I would think do none or do
> all.
>
> Thanks,
>
> Brian
>
>> On Jan 10, 2019, at 2:20 PM, Lance Andersen > <mailto:lance.ander...@oracle.com>> wrote:
>>
>> Looks fine Brian.
>>
>> One question would
sInvalid()) {
> return false;
> }
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/ora
he end of the string
> on line 321 to be consistent with the other messages.
I will fix before I push
>
>
> On Wed, 2019-01-09 at 15:42 -0500, Lance Andersen wrote:
>> Here is the webrev for the changes:
>>
>> http://cr.openjdk.java.net/~lancea/8216362/webrev.
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
esystem.
>>
>> --Sean
> <8216362.patch>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/desig
else to create one and I don't have the
> slightest idea how to get such a privilege. Could you give me a hint how to
> proceed?
>
> Philipp
>
> On Mon, 2019-01-07 at 18:05 -0500, Lance Andersen wrote:
>> Hi Philipp,
>>
>> I would like to suggest a ne
m/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burling
s, its
>>>>* {@link SecurityManager#checkPermission checkPermission}
>>>>* method is called with a
>>>> - * {@code {@link RuntimePermission}("getenv.*")} permission.
>>>> + * {@link RuntimePermission Runtime
urityException} being thrown.
> *
> * When passing information to a Java subprocess,
>
>
> Thanks, Roger
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-e
primitive subtype
> specializations.
> *
>
> Thanks, Roger
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracl
324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
er
>* marker in the SQL statement
>*
>* @throws SQLFeatureNotSupportedException if the JDBC driver does not
> support this method
>
>
looks fine otherwise
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/o
ating line 1867 in ClassLoader.java to avoid that
> single long line sticking out would be good.
>
> Mandy
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-19832
does not yet have access to cr.openjdk.java.net.
>
> $.02, Roger
>
> On 12/20/2018 09:17 AM, Lance Andersen wrote:
>> Hi Philipp,
>>
>> The tests look better. Any chance you can post the webrev in the future vs
>> the patch as it makes it easer to review.
>>
>
8 -0800, Martin Buchholz wrote:
>> On Tue, Dec 18, 2018 at 1:13 PM Lance Andersen > <mailto:lance.ander...@oracle.com>>
>> wrote:
>>
>>>
>>>
>>>
>>> Is there a reason you did not use
>>>
>>> @Test(
work.
>>>
>>>
>>> In the test ValueUtf8Coding, just a mention of a method to create a string
>>> with repeats.
>>> "-".repeat(80);
>>>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://
e.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
ream ds = newDirectoryStream(dir, filter)) {
$
--
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/
-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
e.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
8324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
agement.agent
>>>>jdk.naming.dns
>>>>jdk.rmic
>>>>
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~rriggs/webrev-string-isempty-8214971-1/
>>>>
>>>> Issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8214971
>>>>
>>>> Thanks, Roger
>>>
>>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
s, Roger
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Pri
browse/JDK-8214498
>
> Thanks, Roger
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198
m/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
t.
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Princ
* is required.
> - *
> * @param input the input data bytes
> * @see Deflater#needsInput
> */
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/orac
.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
/oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
24.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
is patch assumes a previous patch cleaning up property
> initialization (4947890)
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://o
r jdk 12 handle a case where we can update an
> existing entry in jar with "/" (absolute path). As in case of jdk 8 we
> cannot update the existing zipentry as doing so we get
> "FileAlreadyExistsException". Therefore, fix for jdk 8u does not consider
> this case.
>
oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
lic static long getPid() {
> +return ManagementFactory.getRuntimeMXBean().getPid();
> +}
> +}
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-19
the same.
>
> Thanks,
>
> Brian
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gi
801 - 900 of 1866 matches
Mail list logo
