On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
> `test/jdk/java/util/LinkedHashMap/Basic.java`
On Wed, 8 Jun 2022 17:49:38 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> clean up Calendar
Running tests and awaiting review from security team. Our internal test system
is backlogged
Vote: yes
On 6/7/22 10:43 AM, Stuart Marks wrote:
I hereby nominate Roger Riggs [1] to membership in the Core Libraries Group [2].
Roger has been a member of the Oracle Core Libraries team since 2014. He has made
significant contributions in the areas of java.time, Legacy Serialization
Vote: yes
On 6/6/22 5:52 PM, Stuart Marks wrote:
I hereby nominate Naoto Sato [1] to membership in the Core Libraries Group [2].
Naoto Sato has been on the Core Libraries team for over a decade and has contributed
hundreds of changes to the JDK project [3]. His most significant recent
I hereby nominate Roger Riggs [1] to membership in the Core Libraries Group [2].
Roger has been a member of the Oracle Core Libraries team since 2014. He has made
significant contributions in the areas of java.time, Legacy Serialization and
Serialization Filtering, Processes, and many others.
Hi Jai,
The error
java.lang.OutOfMemoryError: Java heap space
indicates that the VM really has run out of memory. Presumably if you increased the
heap size, it would actually be able to allocate that memory. You might have to add
the /othervm test directive and add JVM options to require
I hereby nominate Naoto Sato [1] to membership in the Core Libraries Group [2].
Naoto Sato has been on the Core Libraries team for over a decade and has contributed
hundreds of changes to the JDK project [3]. His most significant recent contribution
is JEP 400: UTF-8 by Default [4]. Naoto is
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Reviewers for i18n, net, nio, and security, please review call site changes in
your areas.
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
test/jdk/java/util/HashMap/WhiteBoxResizeTest.java line 441:
> 439: }
> 440: }
On Fri, 27 May 2022 06:09:59 GMT, XenoAmess wrote:
>> Thanks for the updates. I've made a couple minor changes to the specs;
>> please merge the latest commit from this branch:
>>
>> https://github.com/stuart-marks/jdk/tree/pull/8302
>>
>> I've created a
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Reviewers, could I get a review for CSR
specs; please
merge the latest commit from this branch:
https://github.com/stuart-marks/jdk/tree/pull/8302
I've created a CSR and have included these changes in it. Please review:
[JDK-8287419](https://bugs.openjdk.java.net/browse/JDK-8287419)
I'll look at the test changes later. I wanted to get t
On Wed, 25 May 2022 03:02:45 GMT, ExE Boss wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add test for newHashSet and newLinkedHashSet
>
> test/jdk/java/util/HashMap/WhiteBoxResizeTest.java line 360:
>
>> 358:
On Tue, 24 May 2022 21:37:52 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add test for newHashSet and newLinkedHashSet
I looked at all the use sites and they look fine. Some look like
On Wed, 20 Apr 2022 16:14:42 GMT, XenoAmess wrote:
>> Need to add apiNote documentation section to capacity-based constructors
>> like for maps.
>
>> Need to add apiNote documentation section to capacity-based constructors
>> like for maps.
>
> @liach done.
@XenoAmess oops, sorry for the
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the
ntityHashMap`. Unfortunately it seems
> difficult to merge this with the existing, comprehensive Collections tests
> (e.g., MOAT.java) because those tests implicity rely on `equals()`-based
> contract instead of the special-purpose `==`-based contract used by
> `IdentityHashMap`.
Stuart Ma
On Fri, 6 May 2022 16:59:16 GMT, Lance Andersen wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add some assertions for entrySet.equals and keySet.equals
>
> I think you have d
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done,
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done,
On Wed, 4 May 2022 18:46:20 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done,
ntityHashMap`. Unfortunately it seems
> difficult to merge this with the existing, comprehensive Collections tests
> (e.g., MOAT.java) because those tests implicity rely on `equals()`-based
> contract instead of the special-purpose `==`-based contract used by
> `IdentityHashMap`.
Stuart Ma
On Wed, 4 May 2022 14:55:25 GMT, Jaikiran Pai wrote:
>> Stuart Marks has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assertions over return values. Some refinement of equals() testing.
>> - Add co
On Wed, 4 May 2022 15:02:43 GMT, liach wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 500:
>>
>>> 498: Box newKey = new Box(k1a);
>>> 499: Box newVal = new Box(v1a);
>>> 500: Box r = map.computeIfAbsent(newKey, k -> { called[0] = true;
>>> return newVal;
ntityHashMap`. Unfortunately it seems
> difficult to merge this with the existing, comprehensive Collections tests
> (e.g., MOAT.java) because those tests implicity rely on `equals()`-based
> contract instead of the special-purpose `==`-based contract used by
> `IdentityHashMap`.
Stuart Ma
On Sun, 1 May 2022 17:48:39 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Sun, 1 May 2022 17:48:39 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Fri, 29 Apr 2022 03:00:40 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done,
ntityHashMap`. Unfortunately it seems
> difficult to merge this with the existing, comprehensive Collections tests
> (e.g., MOAT.java) because those tests implicity rely on `equals()`-based
> contract instead of the special-purpose `==`-based contract used by
> `IdentityHashMap`.
Stuart Ma
On Thu, 28 Apr 2022 13:17:59 GMT, Jaikiran Pai wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>>
On Thu, 28 Apr 2022 13:22:34 GMT, Jaikiran Pai wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>>
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 23:04:47 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/util/AbstractMap.java line 601:
>>
>>> 599: * {@code Map.entrySet().toArray}.
>>> 600: *
>>> 601: * @param the type of keys maintained
>>
>> Please update to match java.util.Map, which says
On Thu, 21 Apr 2022 03:48:21 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Wed, 27 Apr 2022 03:11:58 GMT, liach wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> cover
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the
Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch in
the bug report that breaks `IdentityHashMap` now causes several cases in this
new test to fail. There's more that could be done, but the new tests cover most
of the core functions of `IdentityHashMap`. Unfortunately
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in
Yes, this has been proposed before. See
https://bugs.openjdk.java.net/browse/JDK-8241056
It's not obviously a bad idea, but there are a bunch of costs that seem to
counterbalance the benefits.
I think the biggest problem is that adding a bunch of default methods to a
widely-implemented
There's a small bug tail from JDK-8186958, which added a few methods to create
pre-sized HashMap and related instances.
* JDK-8285386 WhiteBoxResizeTest.java fails in tier7 after JDK-8186958
Some of our test configurations failed with OOME. Since they're internal systems,
I've handled this
On Thu, 21 Apr 2022 22:08:00 GMT, Stuart Marks wrote:
> Adds `othervm` and `-Xmx2g` options to this test, because the default heap of
> 768m isn't enough.
This pull request has now been integrated.
Changeset: 58155a72
Author:Stuart Marks
URL:
https://git.openjdk.java.n
> Adds `othervm` and `-Xmx2g` options to this test, because the default heap of
> 768m isn't enough.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Add bug id.
-
Changes:
- all: https://git.openjdk.java.net/jd
Adds `othervm` and `-Xmx2g` options to this test, because the default heap of
768m isn't enough.
-
Commit messages:
- Add -Xmx2g to ensure JVM has enough heap.
Changes: https://git.openjdk.java.net/jdk/pull/8352/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8352=00
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
>
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
>
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
>
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Tue, 19 Apr 2022 18:12:04 GMT, Stuart Marks wrote:
> The test `java/lang/Enum/ConstantDirectoryOptimalCapacity.java` was
> problem-listed by
> [JDK-8281631](https://bugs.openjdk.java.net/browse/JDK-8281631) and
> essentially superseded by
> [JDK-8186958](https://bugs.o
The test `java/lang/Enum/ConstantDirectoryOptimalCapacity.java` was
problem-listed by
[JDK-8281631](https://bugs.openjdk.java.net/browse/JDK-8281631) and essentially
superseded by [JDK-8186958](https://bugs.openjdk.java.net/browse/JDK-8186958).
Given this, the test should simply be removed.
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> java.xml.crypto's usage downgrade grammar to 1.8
I've also written a
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> java.xml.crypto's usage downgrade grammar to 1.8
Marked as reviewed by
On Thu, 14 Apr 2022 20:16:38 GMT, Sean Mullan wrote:
>>> Are the changes necessary for this part?
>>
>> @seanjmullan no, they are just performance refinement.
>>
>> If you really that wanna 100% sync ,
>>
>> I can use the old 1.8 api to migrate that part, and make a mirror pr to that
>> part
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote:
>> Added the test case, and eliminated the immediate hashmap value, replaced
>> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the
On Thu, 14 Apr 2022 19:53:45 GMT, Bradford Wetmore wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add `@LastModified: Apr 2022` to DocumentCache
>
> I learned something new about HashMap today...
>
> I looked at
On Wed, 13 Apr 2022 20:06:34 GMT, Naoto Sato wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes in:
>> src/java.desktop
>> src/java.management
>> src/jdk.internal.vm.ci
>> src/jdk.jfr
>>
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.base/share/classes/java/lang/Character.java
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in:
> src/java.desktop
> src/java.management
>
ed constructors to link to the new
factory methods. Note that even though these are javadoc changes, the API notes
are non-normative and don't require an update to the CSR. See the last few
commits on this branch:
https://github.com/stuart-marks/jdk/commits/JDK-8186958-presized-HashMap
If you think they
On Wed, 6 Apr 2022 16:02:31 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use (double) DEFAULT_LOAD_FACTOR instead of 0.75
Regarding the scope of
On Mon, 4 Apr 2022 06:55:10 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which now marks `CollectionView` as
> a `sealed` class with only `EntrySetView`, `KeySetView` and `ValuesView` as
> the sub-classes? This change corresponds to
>
On Mon, 4 Apr 2022 06:55:10 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which now marks `CollectionView` as
> a `sealed` class with only `EntrySetView`, `KeySetView` and `ValuesView` as
> the sub-classes? This change corresponds to
>
On Sat, 2 Apr 2022 22:46:19 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in jdk.compile
On Tue, 5 Apr 2022 23:16:57 GMT, liach wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes in jdk.compile
>
> src/java.base/share/classes/java/util/LinkedHashMap.java line 804:
>
>> 802: * @since 19
On Sat, 2 Apr 2022 22:46:19 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in jdk.compile
I've drafted a CSR for this. Please review:
On Sat, 2 Apr 2022 22:46:19 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in jdk.compile
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
This pull request has now been integrated.
Changeset: ae57258b
Author: Stuart Marks
URL:
https://git.openjdk.java.net/jdk/commit/ae57258b46b8b6953148cd8cf71faf75eef118da
Stats: 10 lines i
On Wed, 30 Mar 2022 00:43:57 GMT, Jaikiran Pai wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
>
> Hello Stua
> Pretty much just what it says.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8009/files
- new: https://git.openjdk.java.net/jdk/p
On Thu, 24 Mar 2022 17:43:31 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update jmh
> - refine javadoc; refine implement when expectedSize < 0
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust nonfinal CSMs and rework error reporting in Che
> Pretty much just what it says.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
Please review CSR request
[JDK-8283811](https://bugs.openjdk.java.net/browse/JDK-8283811).
-
PR: https://git.openjdk.java.net/jdk/pull/8009
Pretty much just what it says.
-
Commit messages:
- Make ObjectStreamClass final.
Changes: https://git.openjdk.java.net/jdk/pull/8009/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8009=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8283715
Stats: 1 line in 1
On Thu, 24 Mar 2022 17:43:31 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update jmh
> - refine javadoc; refine implement when expectedSize < 0
On Fri, 25 Mar 2022 13:32:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which marks the `ThreadLocalRandom`
> class as `final`? Related JBS issue
> https://bugs.openjdk.java.net/browse/JDK-8283683.
>
> A CSR has been filed too
On Thu, 24 Mar 2022 22:01:30 GMT, Naoto Sato wrote:
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote:
>> Fixing the out-of-date number of entries in
>> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
>> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
>> correctly has the `map.size()` value.
>
>
On Tue, 22 Mar 2022 21:58:27 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/Character.java line 740:
>>
>>> 738: public static final class UnicodeBlock extends Subset {
>>> 739: /**
>>> 740: * 737 - the expected number of entities
>>
>> Just a quibble
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Thanks
p-default
>> - fix whitespace
>
> @stuart-marks Could you help me with this?
>
> In my JMH benchmark runs, I often find that ambient differences (from the jdk
> processes, the random test data generated, etc.) hide the actual performance
> difference caused by the patc
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Sat, 12 Mar 2022 01:35:23 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
There's already a bug for this:
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Sat, 12 Mar 2022 01:35:23 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
No, you don't need to do any rebasing;
On Tue, 15 Mar 2022 23:18:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Sat, 12 Mar 2022 01:35:23 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
> what I worried is, the boundary this is
On Tue, 15 Mar 2022 23:18:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Sat, 12 Mar 2022 01:26:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Tue, 15 Mar 2022 01:36:14 GMT, Joe Darcy wrote:
> Depending on the range of the number line, a double value has between 15 and
> 17 digits of decimal precision. The literals used to initialize Math.PI and
> Math.E have several digits more precision than that maximum.
>
> That is
On Sat, 12 Mar 2022 01:26:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Sat, 12 Mar 2022 09:48:14 GMT, xpbob wrote:
> * Constructs an empty list with an initial capacity of ten
>
> =>
>
> * Constructs an empty list with default sized empty instances.
>
>
> private static final Object[] DEFAULTCAPACITY_EMPTY_ELEMENTDATA = {};
>
>
On Fri, 11 Mar 2022 01:25:28 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Fri, 11 Mar 2022 15:56:26 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - change KeyStructure to String
> - fix test
1 - 100 of 1347 matches
Mail list logo
