On 02/04/2019 13:54, Baesken, Matthias wrote:
Hi Alan, here is a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.3/webrev/
re-formatted the comment in java_md.cto avoid VERY LONG lines
adjusted test/jdk/tools/launcher/Arrrghs.java
Best regards, Matthias
Using
Hello, is the latest revision fine with you ?
May I add you as a reviewer ?
Thanks, Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 2. April 2019 14:55
> To: 'Alan Bateman'
> Cc: core-libs-dev@openjdk.java.net
> Subject: RE: RFR: 8218547: Simplify JLI_Open on
Hi Alan, here is a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.3/webrev/
re-formatted the comment in java_md.cto avoid VERY LONG lines
adjusted test/jdk/tools/launcher/Arrrghs.java
Best regards, Matthias
> -Original Message-
> From: Alan Bateman
>
On 29/03/2019 12:36, Baesken, Matthias wrote:
Thanks. Alan, are you fine with the current webrev, if yes may I add you as
reviewer ?
The update to java_md.c looks okay, I probably would re-format the
comment to void the line longs but it is otherwise okay.
I think the new test needs a of
Thanks. Alan, are you fine with the current webrev, if yes may I add you as
reviewer ?
Best regards, Matthias
> -Original Message-
> From: Langer, Christoph
> Sent: Donnerstag, 28. März 2019 12:41
> To: Baesken, Matthias
> Cc: core-libs-dev@openjdk.java.net; Alan Bateman
>
>
Hi Matthias,
this looks good to me now. Let's wait for another review then.
Best regards
Christoph
> -Original Message-
> From: Baesken, Matthias
> Sent: Donnerstag, 28. März 2019 12:39
> To: Langer, Christoph
> Cc: core-libs-dev@openjdk.java.net; Alan Bateman
>
> Subject: RE: RFR:
Hello here is another webrev , I adjusted
test/jdk/tools/launcher/Arrrghs.java a bit taking your suggestions into
account .
Can I have a second review please ?
http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.2/webrev/
> As for the test, I think you could also check a jar in a
Hi Matthias,
the change to src/java.base/windows/native/libjli/java_md.c looks good to me
now.
As for the test, I think you could also check a jar in a short path to exercise
both cases in JLI_Open.
And a few nits:
Line 506: better do:
Path pelp = pcreated.resolve(elp.jar);
Line 507:
2
Hello could you please look into it ?
Best regards, Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Montag, 25. März 2019 18:05
> To: Langer, Christoph
> Cc: 'core-libs-dev@openjdk.java.net' ;
> 'Alan Bateman'
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows
Hello here is an updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.1/webrev/
> > In JLI_Open(const char* name, int flags), you should remove ret and only
> > use fd, I think.
I removed ret and adjusted some comments.
Additionally I added a test that uses (on
Hi Christoph / Alan, thanks for the reviews.
Btw what do you think about the longPathAware setting in the manifest ?
https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file
https://blogs.msdn.microsoft.com/jeremykuhne/2016/07/30/net-4-6-2-and-long-paths-on-windows-10/
Hi Matthias,
yes, I think this is generally a good way to go.
In JLI_Open(const char* name, int flags), you should remove ret and only use
fd, I think. (Currently it would return 0 in the _wopen case).
Furthermore, I think it would be a good time to introduce a test now that
exercises paths
On 22/03/2019 14:37, Baesken, Matthias wrote:
Hello, here is the new webrev .
I took over and adjusted coding from os::open + create_unc_path
functions in os_windows.cpp in hotspot :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.0/webrev/
This looks quite good. For
Hello, here is the new webrev .
I took over and adjusted coding from os::open + create_unc_path
functions in os_windows.cpp in hotspot :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.0/webrev/
Best regards, Matthias
> -Original Message-
> From: Baesken,
Hi Alan + Christoph, coming back to
https://bugs.openjdk.java.net/browse/JDK-8218547 .
We wanted to check for the whole flow (in JLI_Open on Windows ) , e.g.
checking whether only CreateFileW can be used instead of open.
I think there is already a similar solution available in the
15 matches
Mail list logo
