Re: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-04-04 Thread Alan Bateman
On 02/04/2019 13:54, Baesken, Matthias wrote: Hi Alan, here is a new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.3/webrev/ re-formatted the comment in java_md.cto avoid VERY LONG lines adjusted test/jdk/tools/launcher/Arrrghs.java Best regards, Matthias Using

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-04-04 Thread Baesken, Matthias
Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > Hi Alan, here is a new webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.3/webrev/ > > re-formatted the comm

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-04-02 Thread Baesken, Matthias
ateman > Sent: Samstag, 30. März 2019 10:04 > To: Baesken, Matthias > Cc: core-libs-dev@openjdk.java.net > Subject: Re: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows

Re: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-30 Thread Alan Bateman
On 29/03/2019 12:36, Baesken, Matthias wrote: Thanks. Alan, are you fine with the current webrev, if yes may I add you as reviewer ? The update to java_md.c looks okay, I probably would re-format the comment to void the line longs but it is otherwise okay. I think the new test needs a of

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-29 Thread Baesken, Matthias
t; Alan Bateman > > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > Hi Matthias, > > this looks good to me now. Let's wait for another rev

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-28 Thread Langer, Christoph
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > Hello here is another webrev , I adjusted > test/jdk/tools/launcher/Arrrghs.java a bit taking your

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-28 Thread Baesken, Matthias
59 > To: Baesken, Matthias > Cc: core-libs-dev@openjdk.java.net; Alan Bateman > > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > Hi Matthias

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-28 Thread Langer, Christoph
Matthias > Sent: Mittwoch, 27. März 2019 18:05 > To: Langer, Christoph > Cc: core-libs-dev@openjdk.java.net; Alan Bateman > > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifes

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-27 Thread Baesken, Matthias
y JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > Hello here is an updated webrev : > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.1/webrev/ > > > > >

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-25 Thread Baesken, Matthias
, 25. März 2019 10:48 > To: Langer, Christoph > Cc: core-libs-dev@openjdk.java.net; Alan Bateman > > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > Hi Ch

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-25 Thread Baesken, Matthias
nntag, 24. März 2019 07:14 > To: Baesken, Matthias > Cc: core-libs-dev@openjdk.java.net; Alan Bateman > > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows &g

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-24 Thread Langer, Christoph
FR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > On 22/03/2019 14:37, Baesken, Matthias wrote: > > Hello, here is the new webrev . > > > > I

Re: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-22 Thread Alan Bateman
On 22/03/2019 14:37, Baesken, Matthias wrote: Hello, here is the new webrev . I took over and adjusted coding from os::open + create_unc_path functions in os_windows.cpp in hotspot : http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.0/webrev/ This looks quite good. For