On Thu, 10 Dec 2020 10:47:48 GMT, Andrew Haley wrote:
>> Should we have a separate RegSet type for FloatRegisters to avoid mixing
>> them up?
>
> Absolutely. I'd make an AbstractRegSet and use it as a base type
> for both RegSet and FloatRegSet, then we can get rid of the casts
> altogether.
On Thu, 10 Dec 2020 13:45:21 GMT, Jorn Vernee wrote:
>> Nick Gasson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 3104:
>
>> 3102:
> This is more-or-less a straight port of the x86 code to AArch64.
> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
> to generate a blob that jumps to the native function entry point. This
> simply switches the thread state from Java to native and handles the
> safepoint
On Mon, 7 Dec 2020 05:01:27 GMT, Yumin Qi wrote:
> Hi, Please review
> Windows mapping for file into memory could not happen to reserved memory.
> In mapping CDS archive we first reserve enough memory then before mapping,
> release them. For cds archive and using class space, need split the
On Tue, 8 Dec 2020 06:12:36 GMT, Yumin Qi wrote:
>> Changes requested by iklam (Reviewer).
>
> Please check 03. 02 is generated when merge with most current and remote head
> not updated correctly. After set remote head correct, 03 is regenerated and
> is correct one for review. Thanks
This
On Fri, 11 Dec 2020 05:02:25 GMT, Vicente Romero wrote:
> Please review this patch which modifies the spec for method
> java.lang.Record::equals. It states that the implementation of this method
> should use the record fields for the comparison instead of the accessors.
>
> TIA,
> Vicente
> Hi, Please review
> Windows mapping for file into memory could not happen to reserved memory.
> In mapping CDS archive we first reserve enough memory then before mapping,
> release them. For cds archive and using class space, need split the whole
> space into two, that is, release the whole
On Fri, 11 Dec 2020 02:07:50 GMT, Vicente Romero wrote:
> Please review this patch which modifies the spec for method
> java.lang.Record::equals. It states that the implementation of this method
> should use the record fields for the comparison instead of the accessors.
>
> TIA,
> Vicente
>
Please review this patch which modifies the spec for method
java.lang.Record::equals. It states that the implementation of this method
should use the record fields for the comparison instead of the accessors.
TIA,
Vicente
-
Commit messages:
- 8257598: Clarify what component
On Fri, 11 Dec 2020 02:07:50 GMT, Vicente Romero wrote:
> Please review this patch which modifies the spec for method
> java.lang.Record::equals. It states that the implementation of this method
> should use the record fields for the comparison instead of the accessors.
>
> TIA,
> Vicente
If this is meant for JDK 16, it is easier overall if PR is done against
the JDK 16 repo.
-Joe
On 12/10/2020 6:13 PM, Vicente Romero wrote:
Please review this patch which modifies the spec for method
java.lang.Record::equals. It states that the implementation of this method
should use the
Please review this patch which modifies the spec for method
java.lang.Record::equals. It states that the implementation of this method
should use the record fields for the comparison instead of the accessors.
TIA,
Vicente
-
Commit messages:
- Merge branch 'master' into
On Fri, 11 Dec 2020 01:25:48 GMT, Naoto Sato wrote:
>> src/java.base/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
>> line 78:
>>
>>> 76: // CalendarData value types
>>> 77: private static final int CD_FIRSTDAYOFWEEK = 0;
>>> 78: private static final
On Fri, 11 Dec 2020 00:15:49 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment for LOCALE_IFIRSTWEEKOFYEAR Windows return values
>
>
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added comment for
On Sat, 17 Oct 2020 02:50:28 GMT, John Lin
wrote:
> This is from the mailing list:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html
>
> -
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> -
On Thu, 10 Dec 2020 21:12:29 GMT, Naoto Sato wrote:
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
Looks good to me. Some minor comments below.
On Thu, 10 Dec 2020 17:59:03 GMT, Martin Buchholz wrote:
>> John Lin has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains one commit:
>>
>> 8247402: Documentation for Map::compute contains confusing implementation
>> requirements
>
> Please review this small verbiage change to specify clearly the behavior of
> `Reader::read(char[] cbuf)` when the length of `cbuf` is zero, and that of
> `Reader::read(char[] cbuf, int off, int len)` when `len` is zero.
Brian Burkhalter has updated the pull request incrementally with one
On Thu, 10 Dec 2020 23:12:57 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
> Please review this small verbiage change to specify clearly the behavior of
> `Reader::read(char[] cbuf)` when the length of `cbuf` is zero, and that of
> `Reader::read(char[] cbuf, int off, int len)` when `len` is zero.
Brian Burkhalter has updated the pull request with a new target base due
On Thu, 10 Dec 2020 17:22:06 GMT, Brian Burkhalter wrote:
> Please review this small verbiage change to specify clearly the behavior of
> `Reader::read(char[] cbuf)` when the length of `cbuf` is zero, and that of
> `Reader::read(char[] cbuf, int off, int len)` when `len` is zero.
Looks good
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Thu, 10 Dec 2020 22:56:34 GMT, Mandy Chung wrote:
>> Marked as reviewed by chegar (Reviewer).
>
> Hi Remi,
>
>> For me, it's backout JDK-8247444, as i said on the amber-spec-expert, i
>> prefer VM to be oblivious about java.lang.Record.
>> And in the future, the real fix is to change the
On Thu, 10 Dec 2020 14:13:27 GMT, Chris Hegarty wrote:
>> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
>> classes with `RecordComponents` attributes. That introduces a regression in
>> `InstanceKlass::is_record` that returns true on a non-record class which has
Hello,
Please review the changes to the subject issue. getMinimalDaysInFirstWeek() for
Windows has been implemented to suffice the bug claim.
-
Commit messages:
- JDK-8257964
Changes: https://git.openjdk.java.net/jdk/pull/1741/files
Webrev:
Awesome, Pavel, thanks!
Brian
> On Dec 10, 2020, at 1:02 PM, Pavel Rappo wrote:
>
> I found this relevant issue created 17 years ago:
> https://bugs.openjdk.java.net/browse/JDK-4926314
>
>> […]
>>
>> Do you have the ability to file an issue? If not, I can do so.
I found this relevant issue created 17 years ago:
https://bugs.openjdk.java.net/browse/JDK-4926314
> On 10 Dec 2020, at 20:23, Brian Burkhalter
> wrote:
>
> Hi Philippe,
>
>> On Dec 10, 2020, at 12:03 PM, Philippe Marschall
>> wrote:
>>
>> I recently came across Reader#read(CharBuffer)
Hi Philippe,
> On Dec 10, 2020, at 12:03 PM, Philippe Marschall
> wrote:
>
> I recently came across Reader#read(CharBuffer) and noticed it was
> missing an optimization for heap buffers. […]
These seem like good suggestions.
> Sorry if this is the wrong mailing list and should go to
On Wed, 2 Dec 2020 19:27:25 GMT, Phil Race wrote:
>> Please review a small change that replaces use of objc_msgSend_stret in
>> macOS platform code with pure ObjC code. It's also a prerequisite for
>> macOS/AArch64 support, where objc_msgSend_stret is not available.
>
> Surely these days you
On Thu, 10 Dec 2020 18:28:54 GMT, Lance Andersen wrote:
>> Please review this small verbiage change to specify clearly the behavior of
>> `Reader::read(char[] cbuf)` when the length of `cbuf` is zero, and that of
>> `Reader::read(char[] cbuf, int off, int len)` when `len` is zero.
>
> Hi
On Thu, 10 Dec 2020 17:22:06 GMT, Brian Burkhalter wrote:
> Please review this small verbiage change to specify clearly the behavior of
> `Reader::read(char[] cbuf)` when the length of `cbuf` is zero, and that of
> `Reader::read(char[] cbuf, int off, int len)` when `len` is zero.
Hi Brian,
On Thu, 10 Dec 2020 09:15:47 GMT, Nick Gasson wrote:
>> This is more-or-less a straight port of the x86 code to AArch64.
>> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
>> to generate a blob that jumps to the native function entry point. This
>> simply switches the
On Sat, 28 Nov 2020 08:35:20 GMT, John Lin
wrote:
>> This is from the mailing list:
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html
>>
>> -
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an
Please review this small verbiage change to specify clearly the behavior of
`Reader::read(char[] cbuf)` when the length of `cbuf` is zero, and that of
`Reader::read(char[] cbuf, int off, int len)` when `len` is zero.
-
Commit messages:
- 8248383: Clarify
On Mon, 7 Dec 2020 17:48:01 GMT, Severin Gehwolf wrote:
> This has been implemented for cgroups v1 with
> [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) but was
> lacking some tooling support for cgroups v2. With podman 2.2.0 release this
> could now be implemented (and
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote:
> Start of JDK 17 updates.
This pull request has now been integrated.
Changeset: 6be1f567
Author:Joe Darcy
URL: https://git.openjdk.java.net/jdk/commit/6be1f567
Stats: 7607 lines in 77 files changed: 7548 ins; 0 del; 59 mod
On Thu, 10 Dec 2020 16:28:59 GMT, Harold Seigel wrote:
> The changes look good. Thanks for doing this.
Thanks for the review!
-
PR: https://git.openjdk.java.net/jdk/pull/1672
On Sat, 28 Nov 2020 08:35:20 GMT, John Lin
wrote:
>> This is from the mailing list:
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html
>>
>> -
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an
On Mon, 7 Dec 2020 17:48:01 GMT, Severin Gehwolf wrote:
> This has been implemented for cgroups v1 with
> [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) but was
> lacking some tooling support for cgroups v2. With podman 2.2.0 release this
> could now be implemented (and
On Thu, 10 Dec 2020 13:55:25 GMT, Jorn Vernee wrote:
> Thanks for the amazing work!
>
> FWIW, on x86 RBP was being passed as debug info (see last line in
> MachCallNode::in_RegMask), so the solution Vlad I proposed would be to
> override MachCallNativeNode::in_RegMask to not include it IIRC.
On Thu, 10 Dec 2020 13:15:41 GMT, Maurizio Cimadamore
wrote:
> As a result of the recent integration of the foreign memory access API, some
> of the buffer implementations now use `ScopedMemoryAccess` instead of
> `Unsafe`. While this works generally well, there are situations where profile
On Thu, 10 Dec 2020 13:15:41 GMT, Maurizio Cimadamore
wrote:
> As a result of the recent integration of the foreign memory access API, some
> of the buffer implementations now use `ScopedMemoryAccess` instead of
> `Unsafe`. While this works generally well, there are situations where profile
On Thu, 10 Dec 2020 13:15:41 GMT, Maurizio Cimadamore
wrote:
> As a result of the recent integration of the foreign memory access API, some
> of the buffer implementations now use `ScopedMemoryAccess` instead of
> `Unsafe`. While this works generally well, there are situations where profile
On Thu, 10 Dec 2020 13:15:41 GMT, Maurizio Cimadamore
wrote:
> As a result of the recent integration of the foreign memory access API, some
> of the buffer implementations now use `ScopedMemoryAccess` instead of
> `Unsafe`. While this works generally well, there are situations where profile
Hello,
I am not sure if this is the right list for such kind of discussions but
there is also
https://openwebstart.com/
Hope this helps,
-- Daniel
On Thu, Dec 10, 2020 at 3:24 PM Bernd Eckenfels
wrote:
> Hello,
>
> We ported a big JWS gui app to stand-alone swing with a home made
>
- Mail original -
> De: "Mandy Chung"
> À: "core-libs-dev" , "hotspot-runtime-dev"
>
> Envoyé: Mercredi 9 Décembre 2020 01:43:34
> Objet: Re: RFR: 8257596: Clarify trusted final fields for record classes
> On Tue, 8 Dec 2020 22:52:37 GMT, Mandy Chung wrote:
>
>> This is a follow-up
Hello,
We ported a big JWS gui app to stand-alone swing with a home made
installer/update mechanism. This was very easy to do (it had a main method for
debugging anyway). The installer is not the most comfortable, but we can live
with it since the whole application will be replaced by an web
On Tue, 8 Dec 2020 22:52:37 GMT, Mandy Chung wrote:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with `RecordComponents` attributes. That introduces a regression in
> `InstanceKlass::is_record` that returns true on a non-record class which has
>
On Thu, 10 Dec 2020 09:46:07 GMT, Chris Hegarty wrote:
>> Marked as reviewed by bpb (Reviewer).
>
> While the updated set of scenarios covered by this benchmark is
> reasonably (and vastly improves coverage), I find myself reluctant to
> add the last remaining buffer property - read-only views.
On Tue, 8 Dec 2020 22:52:37 GMT, Mandy Chung wrote:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with `RecordComponents` attributes. That introduces a regression in
> `InstanceKlass::is_record` that returns true on a non-record class which has
>
On Thu, 10 Dec 2020 09:15:47 GMT, Nick Gasson wrote:
>> This is more-or-less a straight port of the x86 code to AArch64.
>> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
>> to generate a blob that jumps to the native function entry point. This
>> simply switches the
On Tue, 8 Dec 2020 22:52:37 GMT, Mandy Chung wrote:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with `RecordComponents` attributes. That introduces a regression in
> `InstanceKlass::is_record` that returns true on a non-record class which has
>
As a result of the recent integration of the foreign memory access API, some of
the buffer implementations now use `ScopedMemoryAccess` instead of `Unsafe`.
While this works generally well, there are situations where profile pollution
arises, which result in a considerable slowdown. The profile
I'm using JNLP, how should I go on?
--
Network Inventory Software
IBM-Partner, RedHat- und SUSE-Partner, Oracle Technet Member
www.network-inventory.de
Tel. 030-79782510
Fax 030-79782512
E-Mail: thomas.vat...@network-inventory.de
On Tue, 8 Dec 2020 17:30:11 GMT, Mandy Chung wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Thu, 10 Dec 2020 10:25:33 GMT, Nick Gasson wrote:
>> push_fp() doesn't make much sense if the RegSet is a set of Registers, which
>> are by definition not FloatRegisters. That casting of Register to
>> FloatRegister in gc/z is evil.
>
> Should we have a separate RegSet type for
On Tue, 8 Dec 2020 09:52:51 GMT, Kim Barrett wrote:
> Please review this change that eliminates the use of Reference.isEnqueued by
> tests. There were three tests using it:
>
> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
> vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.java
>
> Please review this change that eliminates the use of Reference.isEnqueued by
> tests. There were three tests using it:
>
> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
> vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.java
> jdk/java/lang/ref/ReferenceEnqueue.java
>
> In each of
On Thu, 10 Dec 2020 10:21:09 GMT, Andrew Haley wrote:
>> Er... no. But not because of the cast. The `push(fp_spills)` below should be
>> `push_fp(fp_spills)`. I'll add a FloatRegister constructor to RegSet so it
>> doesn't need that any more. There's one other place that does it in
>>
On Thu, 10 Dec 2020 10:01:49 GMT, Nick Gasson wrote:
>> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 3192:
>>
>>> 3190: spills += RegSet::of(output->as_Register());
>>> 3191: } else if (output->is_FloatRegister()) {
>>> 3192: fp_spills +=
On Thu, 10 Dec 2020 09:36:44 GMT, Andrew Haley wrote:
>> Nick Gasson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 3192:
>
>> 3190: spills +=
On Mon, 30 Nov 2020 20:54:09 GMT, Brian Burkhalter wrote:
>> Chris Hegarty has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add explicitly allocated heap carrier buffer tests
>> - Replace Single with Loop
>
> Marked as reviewed by bpb
On Thu, 10 Dec 2020 09:15:47 GMT, Nick Gasson wrote:
>> This is more-or-less a straight port of the x86 code to AArch64.
>> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
>> to generate a blob that jumps to the native function entry point. This
>> simply switches the
On Thu, 10 Dec 2020 08:56:25 GMT, Kim Barrett wrote:
>> I understand that the test code previously just forwarded the
>> `InterruptedException` if it happened in the `Thread.sleep()` call too. So
>> this may only be an exiting issue and please ignore this comment.
>> Not catching
On Thu, 10 Dec 2020 09:01:54 GMT, Kim Barrett wrote:
>> Please review this change that eliminates the use of Reference.isEnqueued by
>> tests. There were three tests using it:
>>
>> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
>>
On Wed, 9 Dec 2020 09:58:26 GMT, Andrew Haley wrote:
>> Nick Gasson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> src/hotspot/cpu/aarch64/aarch64.ad line 16057:
>
>> 16055:
>> 16056: format %{ "CALL, native
On Wed, 9 Dec 2020 08:20:38 GMT, Nick Gasson wrote:
> This is more-or-less a straight port of the x86 code to AArch64.
> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
> to generate a blob that jumps to the native function entry point. This
> simply switches the thread
> This is more-or-less a straight port of the x86 code to AArch64.
> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
> to generate a blob that jumps to the native function entry point. This
> simply switches the thread state from Java to native and handles the
> safepoint
> Please review this change that eliminates the use of Reference.isEnqueued by
> tests. There were three tests using it:
>
> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
> vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.java
> jdk/java/lang/ref/ReferenceEnqueue.java
>
> In each of
On Wed, 9 Dec 2020 13:59:09 GMT, Thomas Schatzl wrote:
>> test/jdk/java/lang/ref/ReferenceEnqueue.java line 58:
>>
>>> 56: for (int i = 0; i < iterations; i++) {
>>> 57: System.gc();
>>> 58: enqueued = (queue.remove(100) == ref);
>>
>> The code does
On Wed, 9 Dec 2020 13:26:04 GMT, Thomas Schatzl wrote:
>> Please review this change that eliminates the use of Reference.isEnqueued by
>> tests. There were three tests using it:
>>
>> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
>>
On Wed, 9 Dec 2020 13:28:44 GMT, Thomas Schatzl wrote:
>> Please review this change that eliminates the use of Reference.isEnqueued by
>> tests. There were three tests using it:
>>
>> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
>>
> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 18 additional commits since the
last revision:
- Merge branch
74 matches
Mail list logo
