Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Dr Andrew John Hughes
On 6 October 2010 21:56, Dr Andrew John Hughes gnu_and...@member.fsf.org wrote: On 6 October 2010 21:37, Alan Bateman alan.bate...@oracle.com wrote: This batch eliminates a bunch of compiler warnings from the native code:  http://cr.openjdk.java.net/~alanb/6989466/webrev/ It also fixes

Re: Improved Java Collection APIs

2010-11-19 Thread Dr Andrew John Hughes
On 19 November 2010 15:49, John Platts john_pla...@hotmail.com wrote: Here are improvements that I really want to see to Java Collection APIs: - Addition of an equality comparator interface. - An wrapper that wraps a java.util.Comparator as a equality comparator. - Map and set classes that

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2010-12-16 Thread Dr Andrew John Hughes
On 16 December 2010 16:39, Neil Richards neil.richa...@ngmr.net wrote: On 13 December 2010 20:04, Neil Richards neil.richa...@ngmr.net wrote: On 13 December 2010 18:46, Alan Bateman alan.bate...@oracle.com wrote: I haven't looked at your patch in detail yet but I suspect there may be similar

Re: Fix for JDK Double.parseDouble infinite loop

2011-02-07 Thread Dr Andrew John Hughes
On 7 February 2011 21:48, Mark Wielaard m...@klomp.org wrote: On Wed, February 2, 2011 17:16, Andrew Haley wrote: The post on http://www.exploringbinary.com/java-hangs-when-converting-2-2250738585072012e-308/ This is hitting more and more media. e.g.

Re: sun.cpu.isalist

2011-02-14 Thread Dr Andrew John Hughes
2011/2/14 Dmytro Sheyko dmytro_she...@hotmail.com: Hi, I can see that such system property as sun.cpu.isalist is not set on Linux, but it is set on Solaris and Windows. What is the purpose of this property and shouldn't it be set on Linux as well? Thanks, Dmytro On Solaris, it includes

Re: Zlib level in JDK7

2011-02-22 Thread Dr Andrew John Hughes
On 22 February 2011 17:26, Phil Race philip.r...@oracle.com wrote: On 2/20/2011 9:39 AM, Dr Andrew John Hughes wrote: On 15 February 2011 20:23, Phil Racephilip.r...@oracle.com  wrote: On 2/15/2011 6:07 AM, Dr Andrew John Hughes wrote: Yes, IcedTea uses system libraries for everything bar

Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-03-02 Thread Dr Andrew John Hughes
On 2 March 2011 19:48, Alan Bateman alan.bate...@oracle.com wrote: Kelly O'Hair wrote: Need reviewer for change in jaxp source drop bundle 7023289: jaxp 1.4.5 development jdk7 2nd integration http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp-145dev1/webrev/ Joe or someone from the

Re: Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread Dr Andrew John Hughes
On 30 March 2011 08:09, David Holmes david.hol...@oracle.com wrote: http://cr.openjdk.java.net/~dholmes/7032364/webrev/ More pieces to support SE Embedded. David When are these files installed? Will they interfere with Zero/Shark installs on ARM PPC? Thanks, -- Andrew :-) Free Java

Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-04-07 Thread Dr Andrew John Hughes
On 07/04/2011, Dalibor Topic dalibor.to...@oracle.com wrote: On 3/3/11 3:01 AM, Dr Andrew John Hughes wrote: How do we know what the actual changes are between these tarballs? Is there some JAXP repository somewhere these are derived from, with appropriate tagging? Afaik, the JAXP API

Re: Reviewer needed - fix for regression test LastErrorString

2011-05-06 Thread Dr Andrew John Hughes
On 5 May 2011 20:45, Alan Bateman alan.bate...@oracle.com wrote: Pavel Tisnovsky wrote: Hi all, I'd like to push fix for regression test java/io/IOException/LastErrorString.java to OpenJDK7 and OpenJDK6. This fix ensures that no system-important files can be erased and/or rewritten by this

Re: Heads up, new jaxp source drop

2011-05-19 Thread Dr Andrew John Hughes
On 17:53 Thu 19 May , Kelly O'Hair wrote: Heads up. The jdk7/tl forest has a new jaxp source drop dependency. 7044493: Incorrectly formated GPL headers in JDK7 JAXP source drop http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bdf77cbd9958 The new source drop bundle is called:

Re: Heads up, new jaxp source drop

2011-05-20 Thread Dr Andrew John Hughes
On 07:26 Fri 20 May , Kelly O'Hair wrote: As soon as we figure out how to restrict changes to particular source files and protect them from intentional or accidental edits. I just have not had the time to deal with this kind of change. I thought that's what our existing review

Re: JDK 8 code review request for 7007535: (reflect) Please generalize Constructor and Method

2011-07-14 Thread Dr Andrew John Hughes
On 19:21 Wed 13 Jul , joe.da...@oracle.com wrote: Hello. Please code review my JDK 8 changes for 7007535: (reflect) Please generalize Constructor and Method http://cr.openjdk.java.net/~darcy/7007535.3 To summarize the changes, a new superclass is defined to capture the

Re: JDK 8 code review request for 7007535: (reflect) Please generalize Constructor and Method

2011-07-19 Thread Dr Andrew John Hughes
On 12:49 Tue 19 Jul , Joe Darcy wrote: Agreed; I've posted a BlenderRev corresponding to the current patch at: http://cr.openjdk.java.net/~darcy/7007535.4/BR-7007535.html What is BlenderRev? Google finds others posted by Oracle employees but not how to generate them. Thanks,

Re: Regression in OpenJDK8 Makefiles

2011-07-27 Thread Dr Andrew John Hughes
On 17:12 Wed 27 Jul , Kelly O'Hair wrote: On Jul 27, 2011, at 4:28 PM, Dr Andrew John Hughes wrote: On 11:58 Wed 27 Jul , Kelly O'Hair wrote: On Jul 27, 2011, at 11:04 AM, Dr Andrew John Hughes wrote: Hi, Can someone please tell me why: http://hg.openjdk.java.net

Re: hg: jdk8/tl/jdk: 7068616: NIO libraries do not build with javac -Xlint:all, -deprecation -Werror

2011-07-28 Thread Dr Andrew John Hughes
On 21:44 Thu 28 Jul , jonathan.gibb...@oracle.com wrote: Changeset: 7525866a4046 Author:jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7525866a4046 7068616: NIO libraries do not build with javac -Xlint:all,-deprecation -Werror

Re: hg: jdk8/tl/jdk: 7068616: NIO libraries do not build with javac -Xlint:all, -deprecation -Werror

2011-07-28 Thread Dr Andrew John Hughes
On 16:47 Thu 28 Jul , Alexandre Boulgakov wrote: On 7/28/2011 4:43 PM, Dr Andrew John Hughes wrote: On 21:44 Thu 28 Jul , jonathan.gibb...@oracle.com wrote: Changeset: 7525866a4046 Author:jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-03 Thread Dr Andrew John Hughes
On 09:24 Wed 03 Aug , Joe Darcy wrote: On 8/3/2011 12:42 AM, David Holmes wrote: Alexandre Boulgakov said the following on 08/03/11 04:44: On 8/2/2011 2:19 AM, Xuelei Fan wrote: 3017 VectorObject temp = (Vector)extractURLs(res.errorMessage); You may not need the conversion any

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-16 Thread Dr Andrew John Hughes
On 17:11 Tue 02 Aug , Alan Bateman wrote: Xuelei Fan wrote: : 1. I noticed the copyright date of a few files are unchanged, please update them before you push the changes. This has come up a few times but I don't think it is strictly required. Kelly or one of the release

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread Dr Andrew John Hughes
On 07:01 Thu 18 Aug , Sebastian Sickelmann wrote: Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as the patches

Re: hg: jdk8/tl/jdk: 7082727: VirtualMachineError should declare its serialVersionUID

2011-08-25 Thread Dr Andrew John Hughes
On 16:43 Thu 25 Aug , joe.da...@oracle.com wrote: Changeset: 624cc18a6cf9 Author:darcy Date: 2011-08-25 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624cc18a6cf9 7082727: VirtualMachineError should declare its serialVersionUID Reviewed-by: alanb !

Re: Enhance toString() to return structured info, for certificate and probably more

2011-08-25 Thread Dr Andrew John Hughes
On 10:41 Thu 25 Aug , Weijun Wang wrote: Hi All I was talking with Xuelei on how to better display certificate info. There are 3 cases we can currently think of: 1. debug output 2. keytool/jarsigner output 3. Java plugin display The 1st one is the most primitive one and can be a

Re: Request for review: More cause-chaining for InternalError

2011-08-27 Thread Dr Andrew John Hughes
On 14:16 Tue 23 Aug , Sebastian Sickelmann wrote: Am 22.08.2011 21:19, schrieb Joe Darcy: Sebastian Sickelmann wrote: Am 17.08.2011 03:11, schrieb joe.da...@oracle.com: Hello. On 8/14/2011 11:17 PM, Sebastian Sickelmann wrote: Hi, some time ago, i wrote[5] with Joe and David

Re: Swing Dev Add LookFeel support for AIX platform

2011-12-13 Thread Dr Andrew John Hughes
On 14:45 Tue 13 Dec , Neil Richards wrote: On Tue, 2011-12-13 at 14:42 +, Neil Richards wrote: On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote: On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards neil.richa...@ngmr.net wrote: On Tue, 2011-12-06 at 11:14 +0800, Sean Chou

Re: jvm load too many classes

2010-08-01 Thread Dr Andrew John Hughes
On 31 July 2010 21:31, Rémi Forax fo...@univ-mlv.fr wrote: Le 30/07/2010 21:59, Mandy Chung a écrit : Osvaldo Doederlein wrote: I wonder if these numbers have some variation per platform? Yes, there are some platform-dependent classes and so some loaded classes are different on different