Re: [External] : Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-08 Thread Michael Hall
> On Jun 7, 2022, at 9:21 PM, Alexander Matveev > wrote: > > Hi Michael, > > Yes, this is correct. It is a three step process as you outlined it below. > Alexander, Could you post an example of the three invocations, without needing to include any post-processing, to 1) create app-image

Re: [External] : Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-07 Thread Alexander Matveev
Hi Michael, Yes, this is correct. It is a three step process as you outlined it below. Thanks, Alexander On Jun 7, 2022, at 12:00 AM, Michael Hall mailto:mik3h...@gmail.com>> wrote: Alexander, I had an existing local GitHub repo for the jdk I updated that appeared to accept the parameters

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-07 Thread Michael Hall
Alexander, I had an existing local GitHub repo for the jdk I updated that appeared to accept the parameters you indicated. It generated a jdk 19. If you are saying I’m not getting the main branch or the update for some reason has dependencies I’m not getting I would have to determine how to

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-06 Thread Alexander Matveev
Hi Michael, See below. On Jun 5, 2022, at 5:58 PM, Michael Hall mailto:mik3h...@gmail.com>> wrote: ./build/*/images/jdk/bin/jpackage --app-image ~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app --mac-sign --mac-signing-key-user-name "Developer ID Application: Michael Hall (5X6BXQB3Q7)"

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-06 Thread Alexander Matveev
Hi Michael, Printing "Warning: Using unsigned app-image to build signed dmg.” with signed application should be fixed with JDK-8286850. Did you reproduce it on build containing JDK-8286850? Thanks, Alexander > On Jun 5, 2022, at 3:06 PM, Michael Hall wrote: > > > >> On Jun 5, 2022, at

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-05 Thread Michael Hall
> > ./build/*/images/jdk/bin/jpackage --app-image > ~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app --mac-sign > --mac-signing-key-user-name "Developer ID Application: Michael Hall > (5X6BXQB3Q7)" > Bundler Mac DMG Package skipped because of a configuration problem: When > using an external

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-05 Thread Michael Hall
> On Jun 5, 2022, at 8:56 AM, Michael Hall wrote: > > > Fwiw, I was going to take a look at this but my build failed. > > === Output from failing command(s) repeated here === > * For target support_native_java.desktop_liblcms_cmstypes.o: >

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-05 Thread Michael Hall
Fwiw, I was going to take a look at this but my build failed. === Output from failing command(s) repeated here === * For target support_native_java.desktop_liblcms_cmstypes.o: /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:3441:132: error: parameter

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-02 Thread Alexander Matveev
On Fri, 3 Jun 2022 01:56:01 GMT, Alexander Matveev wrote: >> - Added support for signing predefined application image. >> - Following command can be used to sign predefined application images: >> jpackage --type app-image --app-image Test.app --mac-sign [additional >> signing options] >> -

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-02 Thread Alexander Matveev
> - Added support for signing predefined application image. > - Following command can be used to sign predefined application images: > jpackage --type app-image --app-image Test.app --mac-sign [additional signing > options] > - Main class and if --mac-app-store was specified will be saved in