michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253318691
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319407
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319564
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319511
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319564
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319407
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319407
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319407
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319407
##
File path:
onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should
close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-459972986
@michaelandrepearce I have addressed the comments your sent a pr to my
branch. Change the
CNNJYB opened a new pull request #2533: ARTEMIS-2244 checkDepage method placed
outside CRITICAL_DELIVER avoid critical analyzer timeout
URL: https://github.com/apache/activemq-artemis/pull/2533
We found server crash becauseof critical analyzer timeout, thread dump can
be seen in
TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate
after shared store is reconnected
URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-459300835
Fixed missing license.
This is an
onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should
close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-459215060
@michaelandrepearce @franz1981 This PR has updated.
Because of core modules should not know about
gaohoward opened a new pull request #2534: ARTEMIS-1058 Jars in web tmp dir
locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2534
This is the second commit. It improves the windows service
configuration file so that the service can be shutdown
gracefully (clean
TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate
after shared store is reconnected
URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-458960651
I see, it surprised me that checkstyle is off by default. Sent a fix.
clebertsuconic commented on issue #2534: ARTEMIS-1058 Jars in web tmp dir
locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2534#issuecomment-459394318
The problem is only on windows service?
On this case, we could revert ae00423034b6905564f6729f681dc8e29c86422e
clebertsuconic commented on a change in pull request #2534: ARTEMIS-1058 Jars
in web tmp dir locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2534#discussion_r252722752
##
File path:
jbertram opened a new pull request #2535: NO-JIRA update docs for gitbox
URL: https://github.com/apache/activemq-artemis/pull/2535
This is an automated message from the Apache Git Service.
To respond to the message, please
clebertsuconic commented on a change in pull request #2538: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2538#discussion_r253669464
##
File path:
clebertsuconic commented on a change in pull request #2538: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2538#discussion_r253671399
##
File path:
clebertsuconic commented on a change in pull request #2538: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2538#discussion_r253671205
##
File path:
clebertsuconic commented on a change in pull request #2538: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2538#discussion_r253671205
##
File path:
clebertsuconic commented on a change in pull request #2538: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2538#discussion_r253669464
##
File path:
asfgit merged pull request #2538: NO-JIRA fix race condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2538
This is an automated message from the Apache Git Service.
To respond to the message,
clebertsuconic commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460459951
on a second though.. having the docker as part of the binary distribution is
not such a good idea.
I have updated the PR
clebertsuconic commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460479713
An even better idea would be as an example. Updated my PR to your branch.
(notice those are meant as ideas and to be
michaelandrepearce edited a comment on issue #2536: ARTEMIS-2245 Implement
Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460530360
I quite like the idea of a ready to run docker image that we distribute will
make users life much much easier
michaelandrepearce commented on issue #2536: ARTEMIS-2245 Implement Docker
images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460530360
I quite like the idea of a ready to run docker image that we distribute.
Much more than an example
michaelandrepearce edited a comment on issue #2536: ARTEMIS-2245 Implement
Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460530360
I quite like the idea of a ready to run docker image that we distribute will
make users life much much easier
franz1981 commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460581318
Let me take some time to think about the best approach here: I see that the
current PR is very dev-friendly (given that a compiled
franz1981 edited a comment on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460581318
Let me take some time to think about the best approach here: I see that the
current PR is very dev-friendly (given that a
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253880048
##
File path:
michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-460672007
As ive already said you have two options either make mqtt to ensure plugin
is enabled
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253882381
##
File path:
michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-460672007
As ive already said you have two options either make mqtt to ensure plugin
js enabled or
michaelandrepearce commented on issue #2536: ARTEMIS-2245 Implement Docker
images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460677515
For me the ultimate would be an image in docker hub, just as we push java
artifacts to maven central. Its about making things
michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-460672007
As ive already said you have two options either make mqtt to ensure plugin
is enabled
clebertsuconic commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460681547
That part is a bit more complex as Apache infra is still in early days for
this.
What we are trying to do here is to
onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should
close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-460691058
@michaelandrepearce As described in my comment.Even if use a plugin, we
can't use notifications in the
onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should
close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-460693569
Now let's solve it step by step. First, we need to determine whether to use
the existing notification
onlyMIT edited a comment on issue #2528: ARTEMIS-2226 last consumer connection
should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-460693569
Now let's solve it step by step. First, we need to determine whether to use
the existing
clebertsuconic commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460694427
Even if we decided to deploy it as part of apache account, we still need the
docker files.. which is this step here.
onlyMIT opened a new pull request #2528: ARTEMIS-2226 last consumer connection
should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528
If use MQTT protocol, multiple consumers using the same clientId in the
cluster, the last consumer connection should
onlyMIT commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection
caused the queue to not be cle…
URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-458488858
I used to think that the issue with [ARTEMIS-2226
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls
to retrieve I/O events
URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-458487385
@michaelandrepearce @clebertsuconic I have verified that no HW fences are
needed so now worries about 32/64
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238
Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656
##
File path:
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238
Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182839
##
File path:
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238
Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656
##
File path:
michaelandrepearce edited a comment on issue #2520: ARTEMIS-2238 Enhancement to
queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457790372
+1 please feel free to merge
This is an
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238
Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182904
##
File path:
michaelandrepearce commented on issue #2520: ARTEMIS-2238 Enhancement to
queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457790372
+1
This is an automated message from the
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238
Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182904
##
File path:
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238
Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182864
##
File path:
michaelandrepearce commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce
sys-calls to retrieve I/O events
URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457790883
@franz1981 whats the compatibility of using the c++ c11 features, e.g. this
change with centOS6 /
michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can
reduce sys-calls to retrieve I/O events
URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457790883
@franz1981 whats the compatibility of using the c++ c11 features, e.g. this
change with
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250700525
##
File path:
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250702023
##
File path:
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250701848
##
File path:
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250701848
##
File path:
michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192
fix listener for LegacyLDAPSecuritySettingPlugin
URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250706777
##
File path:
michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192
fix listener for LegacyLDAPSecuritySettingPlugin
URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250707350
##
File path:
michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192
fix listener for LegacyLDAPSecuritySettingPlugin
URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250706777
##
File path:
michaelandrepearce commented on issue #2517: [ARTEMIS-2171]: ThreadPoolExecutor
leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#issuecomment-457289566
This **really** needs a test case, to a) validate the fix, and b) ensure no
michaelandrepearce removed a comment on issue #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#issuecomment-457289566
This **really** needs a test case, to a) validate the fix, and b) ensure
michaelandrepearce commented on issue #2517: [ARTEMIS-2171]: ThreadPoolExecutor
leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#issuecomment-457290572
This really needs a test case
A) validate the fix (and validate any
jbertram commented on a change in pull request #2516: ARTEMIS-2192 fix listener
for LegacyLDAPSecuritySettingPlugin
URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250717165
##
File path:
jbertram opened a new pull request #2516: ARTEMIS-2192 fix listener for
LegacyLDAPSecuritySettingPlugin
URL: https://github.com/apache/activemq-artemis/pull/2516
This is an automated message from the Apache Git Service.
To
ehsavoie opened a new pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor
leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517
* Ensuring that all threadPoolFactories are created under a privileged
block so the threads created are
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250700525
##
File path:
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250701848
##
File path:
jbertram opened a new pull request #2518: NO-JIRA fix race condition in
QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2518
This is an automated message from the Apache Git Service.
To respond to the
clebertsuconic opened a new pull request #2519: ARTEMIS-2238 Fixing QueueQuery
on every single send on topics
URL: https://github.com/apache/activemq-artemis/pull/2519
This is an automated message from the Apache Git
clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250731204
##
File path:
clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250731249
##
File path:
clebertsuconic commented on a change in pull request #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250732153
##
File path:
jbertram commented on a change in pull request #2518: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250733623
##
File path:
jbertram commented on a change in pull request #2518: NO-JIRA fix race
condition in QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250736801
##
File path:
orpiske edited a comment on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460370503
This looks very cool @franz1981!
A few suggestions:
1. I'd probably arrange the ARTEMIS_VERSION so that it can be both a
orpiske commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460370503
This looks very cool @franz1981!
A few suggestions:
1. I'd probably arrange the ARTEMIS_VERSION so that it can be both a
franz1981 commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460280409
I will sent a doc commit today :+1: thanks for the review mate!
This is
clebertsuconic commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460279912
this looks good, but I think we should add docs.
This is an
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253492310
##
File path:
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253492310
##
File path:
franz1981 opened a new pull request #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536
It provides both CentOS and Ubuntu Docker images for the Artemis broker.
This is an
clebertsuconic commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460394329
Do we need that label? Can't we just remove it?
This is an
clebertsuconic opened a new pull request #2537: ARTEMIS-1058 Improving web
temporary cleanup
URL: https://github.com/apache/activemq-artemis/pull/2537
* Using SpawnedVMSupport (used to be on testsuite, moving it to Utils)
* Building the classpath for ./lib, similar to what happens on
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253543767
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253543767
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253543767
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253543767
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253543767
##
File path:
clebertsuconic commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460415066
What if we moved the whole docker under the binary distribution? it would be
a lot cleaner instead of requiring a new distribution
orpiske commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460415113
> Do we need that label? Can't we just remove it?
Yes, you could remove it altogether. There's no harm in having it there,
though.
jbertram opened a new pull request #2538: NO-JIRA fix race condition in
QueueQueryTest
URL: https://github.com/apache/activemq-artemis/pull/2538
My previous commit to fix this was amended which nullified the fix.
This is an
michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-460700605
First of all mqtt connect = create session in core.
I dont want to introduce
michaelandrepearce edited a comment on issue #2533: ARTEMIS-2244 checkDepage
method placed outside CRITICAL_DELIVER avoid critical analyzer timeout
URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-460706195
-1 (and im sorry, feature was added for a very specific
michaelandrepearce edited a comment on issue #2536: ARTEMIS-2245 Implement
Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460711935
Another option then maybe like what occurs for some other apache projects
(e.g. tomcat and httpd,
), is host it
michaelandrepearce edited a comment on issue #2536: ARTEMIS-2245 Implement
Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460711935
Another option then maybe like what occurs for some other apache projects
(e.g. tomcat and httpd,
), is host it
michaelandrepearce commented on issue #2536: ARTEMIS-2245 Implement Docker
images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460711935
Another option then maybe like what occurs for some other apache projects
(e.g. tomcat and httpd,
), is host it under
michaelandrepearce edited a comment on issue #2533: ARTEMIS-2244 checkDepage
method placed outside CRITICAL_DELIVER avoid critical analyzer timeout
URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-460706195
-1 (and im sorry, feature was added for a very specific
1101 - 1200 of 1218 matches
Mail list logo
