[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r184601120
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2713,11 @@ private Message makeCopy(final MessageReference ref,
final boolean expiry) throw
private Message makeCopy(final MessageReference ref,
final boolean expiry,
final boolean copyOriginalHeaders) throws
Exception {
+ if (ref == null) {
+ ActiveMQServerLogger.LOGGER.nullRefMessage();
+ throw new ActiveMQNullRefException("Reference to message is
null");
--- End diff --
ActiveMQNullRefException calls super(ActiveMQExceptionType.NULL_REF), which
as I understand invokes NULL_REF.createException.
---
[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r184600627
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2714,11 @@ private Message makeCopy(final MessageReference ref,
final boolean expiry) throw
private Message makeCopy(final MessageReference ref,
final boolean expiry,
final boolean copyOriginalHeaders) throws
Exception {
+ if (ref == null) {
+ ActiveMQServerLogger.LOGGER.nullRefMessage();
+ NULL_REF.createException("Reference to message is null");
--- End diff --
Yeah, i forgot to throw that. I am throwing ActiveMQNullRefException, which
under the hood does super(ActiveMQExceptionType.NULL_REF). Is that ok?
---
[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2040#discussion_r183632055
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java
---
@@ -323,7 +323,7 @@ public static double parseDouble(final Node elem) {
public static void validate(final Node node, final String schemaFile)
throws Exception {
SchemaFactory factory =
SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
- Schema schema = factory.newSchema(findResource(schemaFile));
+ Schema schema = factory.newSchema(new
URL(findResource(schemaFile).toURI().toASCIIString()));
--- End diff --
I have updated this test. I hope it is ok to have all special characters on
the sigle line.
---
[GitHub] activemq-artemis issue #2010: ARTEMIS-1801 removing null-unchecked dereferen...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2010 @clebertsuconic polished :) ---
[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2013 @gaohoward Done. ---
[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/2040 ARTEMIS-1824 running broker from path with non-ascii chars You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1824 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2040.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2040 commit 5407f674d536e294dbc1b8925c964682863189da Author: Stanislav Knot <sknot@...> Date: 2018-04-23T13:12:01Z ARTEMIS-1824 running broker from path with non-ascii chars ---
[GitHub] activemq-artemis issue #2020: ARTEMIS-1812 fix for missing (core) messages a...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2020 Aha, thanks for explanation! ---
[GitHub] activemq-artemis issue #2020: ARTEMIS-1812 fix for missing (core) messages a...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2020 While sending AMQP message, addReceiver() is called, which causes creating a queue. While sending openwire message, addConsumer() is called, which also causes creating a queue. But core message is directly sent to queue. It may happen this queue does not exist and message is lost. ---
[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2013 @gaohoward Done. ---
[GitHub] activemq-artemis pull request #2020: ARTEMIS-1812 fix for missing (core) mes...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/2020 ARTEMIS-1812 fix for missing (core) messages after master kill (HA) When I try to send some core messages to slave broker (master is dead), messages are lost. Debug console says "Couldn't find any bindings for address=TEST.foo". By digging into code, I think this is the spot, which is responsible for this bug: https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java#L832 I have tried to create queue with default values here. It fixes the bug, but i am afraid it can create much more new bugs. Git blame says @clebertsuconic and @jbertram could know more about this. Can you guys please approve/disprove this fix? If it is ok, please do not merge, I would like to bring some test for this and delete comments. Thank you. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1812 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2020.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2020 commit 688397ea74897d5ad49d4694a74c14849148b8de Author: Stanislav Knot <sknot@...> Date: 2018-04-16T13:46:22Z ARTEMIS-1812 fix for missing (core) messages after master kill (HA) ---
[GitHub] activemq-artemis pull request #2013: ARTEMIS-1805 fix for broker operations ...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/2013 ARTEMIS-1805 fix for broker operations in hawtio There are two operations, which causes an error while selected in hawtio console under broker/operations. Adding @Operation annotation to these methods fixes an error, but methods are exposed and I am not 100% sure that is correct. I also unified capitalized first letter of methods description. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1805 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2013.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2013 commit 59f91f4c2e79777e40e5b220c0fad8faf63437e5 Author: Stanislav Knot <sknot@...> Date: 2018-04-13T09:20:20Z ARTEMIS-1805 fix for broker operations in hawtio ---
[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180976916
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2727,7 +2731,7 @@ private Message makeCopy(final MessageReference ref,
Message copy = message.copy(newID);
if (copyOriginalHeaders) {
- copy.referenceOriginalMessage(message, ref != null ?
ref.getQueue().getName().toString() : null);
+ copy.referenceOriginalMessage(message,
ref.getQueue().getName().toString());
--- End diff --
@clebertsuconic thank you :) Can you please check again? Especially null
reference logging.
---
[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180971622
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
---
@@ -511,22 +511,24 @@ public void close() {
public void transferConnection(final CoreRemotingConnection
newConnection) {
// Needs to synchronize on the connection to make sure no packets
from
// the old connection get processed after transfer has occurred
- synchronized (connection.getTransferLock()) {
- connection.removeChannel(id);
+ if (connection != null) {
--- End diff --
Well, it is null-checked few lines bellow so it confued me.
---
[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2010#discussion_r180654379 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2769,7 +2769,7 @@ public Queue createQueue(final AddressInfo addrInfo, throw ActiveMQMessageBundle.BUNDLE.invalidRoutingTypeForAddress(rt, info.getName().toString(), info.getRoutingTypes()); } - final QueueConfig queueConfig = queueConfigBuilder.filter(filter).pagingManager(pagingManager).user(user).durable(durable).temporary(temporary).autoCreated(autoCreated).routingType(addrInfo.getRoutingType()).maxConsumers(maxConsumers).purgeOnNoConsumers(purgeOnNoConsumers).exclusive(exclusive).lastValue(lastValue).build(); + final QueueConfig queueConfig = queueConfigBuilder.filter(filter).pagingManager(pagingManager).user(user).durable(durable).temporary(temporary).autoCreated(autoCreated).routingType(addrInfo == null ? RoutingType.ANYCAST :addrInfo.getRoutingType()).maxConsumers(maxConsumers).purgeOnNoConsumers(purgeOnNoConsumers).exclusive(exclusive).lastValue(lastValue).build(); --- End diff -- @jdanekrh Good catch! ---
[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2010#discussion_r180649567 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2769,7 +2769,7 @@ public Queue createQueue(final AddressInfo addrInfo, throw ActiveMQMessageBundle.BUNDLE.invalidRoutingTypeForAddress(rt, info.getName().toString(), info.getRoutingTypes()); } - final QueueConfig queueConfig = queueConfigBuilder.filter(filter).pagingManager(pagingManager).user(user).durable(durable).temporary(temporary).autoCreated(autoCreated).routingType(addrInfo.getRoutingType()).maxConsumers(maxConsumers).purgeOnNoConsumers(purgeOnNoConsumers).exclusive(exclusive).lastValue(lastValue).build(); + final QueueConfig queueConfig = queueConfigBuilder.filter(filter).pagingManager(pagingManager).user(user).durable(durable).temporary(temporary).autoCreated(autoCreated).routingType(addrInfo == null ? RoutingType.ANYCAST :addrInfo.getRoutingType()).maxConsumers(maxConsumers).purgeOnNoConsumers(purgeOnNoConsumers).exclusive(exclusive).lastValue(lastValue).build(); --- End diff -- What should be default routing type? ---
[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/2010 ARTEMIS-1801 removing null-unchecked dereferences There were some cases where value was checked for null and later directly dereferenced without check. I added checks. I am not sure about "default behaviour" tho. Can anybody check? You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1801 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2010.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2010 commit 8f393828473c75321b28a4fe63f5f08fb7006bbe Author: Stanislav Knot <sknot@...> Date: 2018-04-11T06:43:07Z ARTEMIS-1801 removing null-unchecked dereferences ---
[GitHub] activemq-artemis issue #2006: ARTEMIS-1798 DEBUG message bad write method ar...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2006 @clebertsuconic Renamed. ---
[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180413588
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
---
@@ -511,6 +511,45 @@ public final boolean isUsingProtocolHandling() {
return true;
}
+ @Override
+ public boolean isSameTarget(TransportConfiguration... configs) {
+ boolean yes = false;
--- End diff --
hehehe
---
[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/2006 ARTEMIS-1798 DEBUG message bad write method arg count - fix When the logging level was set up to DEBUG, FluentPropertyBeanIntrospectorWithIgnores threw an exception at org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager#setUpInactivityParams because it was not really setting up any property. I have added this method to FluentPropertyBeanIntrospectorWithIgnores's ignored method, which means this method is not checked anymore. That causes there is not error message in DEBUG output any longer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E638 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2006.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2006 commit 7f3962c0776fcfdda9c1dab2cc5260228a2edfc1 Author: Stanislav Knot <sknot@...> Date: 2018-04-10T13:01:55Z ARTEMIS-1798 DEBUG message bad write method arg count - fix ---
[GitHub] activemq-artemis issue #1994: ARTEMIS-1787 Openwire message should not conta...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1994 This PR is partly reverting https://github.com/apache/activemq-artemis/pull/1734 AFAIK including some internal properties break JMS API specification. ---
[GitHub] activemq-artemis pull request #1994: ARTEMIS-1787 Openwire message should no...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1994 ARTEMIS-1787 Openwire message should not contain internal property You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1787 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1994.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1994 commit 0210fee3bc3731e3173f012987bfd9d9f2965958 Author: Stanislav Knot <sknot@...> Date: 2018-04-05T16:01:41Z ARTEMIS-1787 Openwire message should not contain internal property ---
[GitHub] activemq-artemis pull request #1988: ARTEMIS-1782 fix for displaying hawtio ...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1988 ARTEMIS-1782 fix for displaying hawtio console sub-level tabs You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E1166 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1988.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1988 commit 46d1be6f6293c86cc11abfc10b3eee5246bcb200 Author: Stanislav Knot <sknot@...> Date: 2018-04-03T13:23:08Z ARTEMIS-1782 fix for displaying hawtio console sub-level tabs ---
[GitHub] activemq-artemis pull request #1974: NO-JIRA browsing messages do not change...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1974 NO-JIRA browsing messages do not change items per page This is fix of this fix :) https://github.com/apache/activemq-artemis/pull/1749 (ARTEMIS-1579) You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis fixReloading Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1974.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1974 commit 095fb7ff4c79703dedb04b4e9ab10aa937c32b01 Author: Stanislav Knot <sknot@...> Date: 2018-03-26T15:15:55Z NO-JIRA browsing messages do not change items per page ---
[GitHub] activemq-artemis pull request #1952: ARTEMIS-1743 fix NPE in server log when...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1952#discussion_r174094053
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -644,8 +644,11 @@ public Message setLastValueProperty(SimpleString
lastValueName) {
@Override
public int getEncodeSize() {
+ if (buffer == null) {
+ return -1;
+ }
checkEncode();
--- End diff --
checkEncode is using buffer therefore it is good to do null check before
---
[GitHub] activemq-artemis pull request #1952: ARTEMIS-1743 fix NPE in server log when...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1952 ARTEMIS-1743 fix NPE in server log when Artemis trace logging is enabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1743 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1952.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1952 commit 555dd31f60bacbfaf15cb559c8991c1e50618367 Author: Stanislav Knot <sknot@...> Date: 2018-03-13T11:19:01Z ARTEMIS-1743 fix NPE in server log when Artemis trace logging is enabled ---
[GitHub] activemq-artemis pull request #1951: ARTEMIS-1744 fix removing addresses and...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1951 ARTEMIS-1744 fix removing addresses and queues with '*' or '?' in their names via hawtio console You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E1027 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1951.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1951 commit 913320fa631931dfc911ec8e78f0893940147b68 Author: Stanislav Knot <sknot@...> Date: 2018-03-12T16:21:58Z ARTEMIS-1744 fix removing addresses and queues with '*' or '?' in their names via hawtio console ---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1940 Ah, I see. Yeah, it seem to be changed in [ARTEMIS-1440](https://issues.apache.org/jira/browse/ARTEMIS-1440). @clebertsuconic can you take a look? ---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1940 Yes, it is. I used this conf: https://pastebin.com/2G0c341X If I am not wrong, restaring logic is implemented as [this](https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java#L194). I am not sure if it would be ok to iterate all ExternalComponents here and if it is web one, just start it again. What do you think? ---
[GitHub] activemq-artemis pull request #1940: ARTEMIS-1737 fix for inaccessible slave...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1940 ARTEMIS-1737 fix for inaccessible slave console after failover Can anybody review this? I will try to write some tests meanwhile. Thank you. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E1018 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1940.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1940 commit 81d6328850b77b3d314aa64ea61a24bbb1baf055 Author: Stanislav Knot <sknot@...> Date: 2018-03-08T10:03:37Z ARTEMIS-1737 fix for inaccessible slave console after failover ---
[GitHub] activemq-artemis pull request #1936: NO-JIRA invalid xmls in docs
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1936 NO-JIRA invalid xmls in docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis doctypo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1936.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1936 commit d06c8a9a73cf8968ba862e37a42d140675f4bdff Author: Stanislav Knot <sknot@...> Date: 2018-03-07T15:14:40Z NO-JIRA invalid xmls in docs ---
[GitHub] activemq-artemis issue #1913: ARTEMIS-1715 Disable to remove a divert from h...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1913 @clebertsuconic Done ---
[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1913#discussion_r172447340
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS) {
.when('/artemis/deleteAddress', {
templateUrl: ARTEMIS.templatePath + 'deleteAddress.html'
})
+ .when('/artemis/deleteDivert', {
--- End diff --
Well, it shows page without such button. But I agree it would be better to
hide this button in "toolbar". I will take a look at this.
---
[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1913#discussion_r172446094
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS) {
.when('/artemis/deleteAddress', {
templateUrl: ARTEMIS.templatePath + 'deleteAddress.html'
})
+ .when('/artemis/deleteDivert', {
--- End diff --
Current behaviour is this: user has divert selected and wants to remove it.
So he click on Delete. But hawtio console does not recognize divert and tries
to remove address at which the divert is created.
---
[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172115995 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/deleteDivert.html --- @@ -0,0 +1,24 @@ + + --- End diff -- Hi Michael. After discussion with @andytaylor we decided that divert should not be deletable from web console, so there is no need to have pop-up. ---
[GitHub] activemq-artemis pull request #1921: ARTEMIS-1725 fix browsing non-listing t...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1921 ARTEMIS-1725 fix browsing non-listing tabs under JMX You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1725 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1921.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1921 commit 34d9daa809b8948dd8957598796da98301ecbd75 Author: Stanislav Knot <sknot@...> Date: 2018-03-02T13:18:19Z ARTEMIS-1725 fix browsing non-listing tabs under JMX ---
[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1913 ARTEMIS-1715 Disable to remove a divert from hawtio console You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1715 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1913.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1913 commit 0809b7794e16cd8981209f30f7ec3adf6ce0a114 Author: Stanislav Knot <sknot@...> Date: 2018-03-01T14:29:22Z ARTEMIS-1715 Disable to remove a divert from hawtio console ---
[GitHub] activemq-artemis issue #1837: ARTEMIS-1603 fixed browsing tables under JMX t...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1837 AFAIK there is some effort to create some Selenium tests. I am not sure when it could get into upstream. ---
[GitHub] activemq-artemis pull request #1898: ARTREMIS-1703 disable listing in web co...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1898 ARTREMIS-1703 disable listing in web console You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1703 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1898.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1898 commit 47ff11e3b437a489810349a90d93965418f550a0 Author: Stanislav Knot <sknot@...> Date: 2018-02-26T16:49:25Z ARTREMIS-1703 disable listing in web console ---
[GitHub] activemq-artemis pull request #1884: NO-JIRA typo in jmx-ssl example pom fil...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1884 NO-JIRA typo in jmx-ssl example pom file + code format You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis pomtypo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1884.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1884 commit 0f433ec7e03d5c45c470059a939a6f492f6c0552 Author: Stanislav Knot <sknot@...> Date: 2018-02-22T13:37:41Z NO-JIRA typo in jmx-ssl example pom file ---
[GitHub] activemq-artemis pull request #1877: ARTEMIS-1692 fixed filtering consumers ...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1877 ARTEMIS-1692 fixed filtering consumers in hawtio console You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E1032 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1877.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1877 commit fae5d78816c9954d9cbe65aa39ee89ee20ed07a5 Author: Stanislav Knot <sknot@...> Date: 2018-02-19T15:38:48Z ARTEMIS-1692 fixed filtering consumers in hawtio console ---
[GitHub] activemq-artemis pull request #1870: ARTEMIS-1681 fix hawtio console securit...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1870 ARTEMIS-1681 fix hawtio console security issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E1016 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1870.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1870 commit ef5080e344f4c58c1c8666d926fbc748fa073ed7 Author: Stanislav Knot <sknot@...> Date: 2018-02-14T11:48:19Z ARTEMIS-1681 fix hawtio console security issue ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 Done, let's wait for result :) Is there any else way how to kick off build? ---
[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...
Github user stanlyDoge closed the pull request at: https://github.com/apache/activemq-artemis/pull/1775 ---
[GitHub] activemq-artemis pull request #1837: ARTEMIS-1603 fixed browsing tables unde...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1837 ARTEMIS-1603 fixed browsing tables under JMX tab I hope it is not spaghetti code. First exp with angular. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1603 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1837.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1837 commit 03e932d04915ddbb2874d3021c00912ddfff9043 Author: Stanislav Knot <sknot@...> Date: 2018-02-01T15:18:11Z ARTEMIS-1603 fixed browsing tables under JMX tab ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 @michaelandrepearce Good point. Pushing changes & test in few minutes. ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 I do not think failed test has any in common with these changes. > Failed tests: NetworkHealthTest.testCheckUsingHTTP:213 null ---
[GitHub] activemq-artemis pull request #1828: ARTEMIS-1646 fix for browsing messages ...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1828 ARTEMIS-1646 fix for browsing messages sent via JS client You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E973 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1828.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1828 commit 50d92ca7d574315971b1b36cbcef07520d29300e Author: Stanislav Knot <sknot@...> Date: 2018-01-31T08:37:31Z ARTEMIS-1646 fix for browsing messages sent via JS client ---
[GitHub] activemq-artemis issue #1775: ARTEMIS-1587 Add setting to control the queue ...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1775 Can I close this PR? ---
[GitHub] activemq-artemis pull request #1799: ARTEMIS-1625 fix moving messages
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1799 ARTEMIS-1625 fix moving messages You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E986 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1799.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1799 commit 4c347fa49a2ee07b01b2d9571e82c3767ff913bf Author: Stanislav Knot <sknot@...> Date: 2018-01-22T12:33:30Z ARTEMIS-1625 fix moving messages ---
[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1775#discussion_r162343251 --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd --- @@ -2790,6 +2790,14 @@ + --- End diff -- Please, would you be so patient and explain me, how to do this? I have implemented enum (in latest commit), but I don't think so it is what you intended. ---
[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1775 ARTEMIS-1587 Add setting to control the queue durable property for au⦠â¦to-created addresses You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1587 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1775.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1775 commit 5873e5b8d7d506c50f978b846f4f11520431ae99 Author: Stanislav Knot <sknot@...> Date: 2018-01-09T10:47:10Z ARTEMIS-1587 Add setting to control the queue durable property for auto-created addresses ---
[GitHub] activemq-artemis pull request #1762: ARTEMIS-1580 Browsing in hawtio console...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1762 ARTEMIS-1580 Browsing in hawtio console does not allow to show empty ⦠â¦pages You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1580 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1762.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1762 commit c649bc5b64b57c3541125e0ddd38b479bf9d07ac Author: Stanislav Knot <sknot@...> Date: 2018-01-09T16:17:49Z ARTEMIS-1580 Browsing in hawtio console does not allow to show empty pages ---
[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160340487
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
---
@@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws
Exception {
server.stop();
}
+
+ @Test
+ public void testHandshakeTimeoutWithValueSet() throws Exception {
+ JMSServerManager jmsServer;
--- End diff --
Aha. Thank you :)
---
[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160086429
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
---
@@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws
Exception {
server.stop();
}
+
+ @Test
+ public void testHandshakeTimeoutWithValueSet() throws Exception {
+ JMSServerManager jmsServer;
--- End diff --
Good point with JMSServerManager, thanks.
The issue is about unability to set timeout value using conf file so using
it is intentional. Setting this value programmatically is done
[here](https://github.com/apache/activemq-artemis/pull/1534/files#diff-70ef2b6fc0b6f5e37ea6023acce65b8c).
Or did you think anything else?
---
[GitHub] activemq-artemis issue #1750: ARTEMIS-1581 fix handshake-timeout property co...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1750 @michaelandrepearce Done @jbertram ahh, that explains my another conflict. Thanks. ---
[GitHub] activemq-artemis issue #1697: ARTEMIS-1341 fix getBytes
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1697 Oops with squashing. Should be ok now, let's wait for check. ---
[GitHub] activemq-artemis issue #1697: ARTEMIS-1341 fix getBytes
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1697 @michaelandrepearce Yes, it should be ready. ---
[GitHub] activemq-artemis pull request #1688: ARTEMIS-1537 broker was less strict whi...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1688#discussion_r156064778
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -253,9 +253,12 @@ public Configuration parseMainConfig(final InputStream
input) throws Exception {
String xml = XMLUtil.readerToString(reader);
xml = XMLUtil.replaceSystemProps(xml);
Element e = XMLUtil.stringToElement(xml);
-
+ NodeList children = e.getElementsByTagName("core");
--- End diff --
Ah, didn't know about this, sorry. Should be ok now.
---
[GitHub] activemq-artemis pull request #1688: ARTEMIS-1537 broker was less strict whi...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1688#discussion_r156024601
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -253,9 +253,12 @@ public Configuration parseMainConfig(final InputStream
input) throws Exception {
String xml = XMLUtil.readerToString(reader);
xml = XMLUtil.replaceSystemProps(xml);
Element e = XMLUtil.stringToElement(xml);
-
+ NodeList children = e.getElementsByTagName("core");
--- End diff --
Hmm, after another investigation I am not sure if this is possible with
current XSD schema. It does not contain 'configuration' element, so it cannot
be checked this way. There are two solutions - modify XSD schema to contain
missing element or use my solution, where I am getting first child of
'configuration', which is 'core'.
---
[GitHub] activemq-artemis issue #1697: ARTEMIS-1341 fix test for getBytes
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1697 This is just test fix. There are some issues with clients. I'll get back to it later. ---
[GitHub] activemq-artemis pull request #:
Github user stanlyDoge commented on the pull request: https://github.com/apache/activemq-artemis/commit/26752a7aafa5651e41abf23ac550c6c09bb08287#commitcomment-26140681 In tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java: In tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java on line 237: @michaelandrepearce Are you sure this line should be 'createCoreConnection'? For me it would make sense if it was 'createOpenWireConnection'. It is suspisious that 'createOpenWireConnection' method is implemented (overloaded) but never used. ---
[GitHub] activemq-artemis issue #1697: ARTEMIS-1341 fix test for getBytes
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1697 > Behaviour should be the same True, there was little misunderstanding. I am working at fix. ---
[GitHub] activemq-artemis pull request #1697: ARTEMIS-1341 fix test for getBytes
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1697 ARTEMIS-1341 fix test for getBytes https://issues.apache.org/jira/browse/ARTEMIS-1341 You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1341 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1697.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1697 commit 5f07d9e93a98ebb112cac46b1bfae352b1747541 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-12-08T09:34:07Z ARTEMIS-1341 fix test for getBytes ---
[GitHub] activemq-artemis pull request #1688: ARTEMIS-1537 broker was less strict whi...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1688#discussion_r155719121
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -253,9 +253,12 @@ public Configuration parseMainConfig(final InputStream
input) throws Exception {
String xml = XMLUtil.readerToString(reader);
xml = XMLUtil.replaceSystemProps(xml);
Element e = XMLUtil.stringToElement(xml);
-
+ NodeList children = e.getElementsByTagName("core");
--- End diff --
Yes, that seems better than my solution. I wanted to use the same process
while reloading conf. as parsing conf. when starting broker
(https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/FileDeploymentManager.java#L85).
---
[GitHub] activemq-artemis issue #1688: ARTEMIS-1537 broker was less strict while relo...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1688 Thanks for your comment @jdanekrh ---
[GitHub] activemq-artemis pull request #1688: ARTEMIS-1537 broker was less strict whi...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1688 ARTEMIS-1537 broker was less strict while reloading configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 E689 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1688.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1688 commit 653b995e3dcda0b026dce4dcf4155d317950faf1 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-12-05T16:01:20Z ARTEMIS-1537 broker was less strict while reloading configuration ---
[GitHub] activemq-artemis issue #1644: ARTEMIS-1503 Added ng-grid plugin
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1644 Yes, there is described reproducer by reporter of this issue. > > you try to browse the queue to check the messages and you have more than 40 messages ( depends on your screen size ), at the end not just 1 or 2 messages but a lot. > In case you have more than 200 message than you cannot paginate but for that there is another jira. > Thanks But for me it seems this has been fixed before. I can't see any white space at the bottom of the page. ---
[GitHub] activemq-artemis pull request #1680: ARTEMIS-1530 Fix expiry statistics
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1680 ARTEMIS-1530 Fix expiry statistics You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ENTMQBR-919 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1680.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1680 commit fd097a50863964f0e68fab6ef40c97da6cbd756e Author: Stanislav Knot <sk...@redhat.com> Date: 2017-11-29T09:56:42Z ARTEMIS-1530 Fix expiry statistics ---
[GitHub] activemq-artemis pull request #1667: ARTEMIS-1420 updated docs
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1667 ARTEMIS-1420 updated docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1420doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1667.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1667 commit b44db21f8fb2492cc2edddf1a1fe533404939611 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-11-24T13:15:20Z ARTEMIS-1420 updated docs ---
[GitHub] activemq-artemis pull request #1644: ARTEMIS-1503 Added ng-grid plugin
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1644 ARTEMIS-1503 Added ng-grid plugin The ng-grid needs the following plugin to automatically resize a table to accomodate a varying number of rows. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1503 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1644.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1644 commit 5ac7bc4e4ad0e41d59e2e9b96ede306e8c07d76c Author: Stanislav Knot <sk...@redhat.com> Date: 2017-11-06T09:10:30Z ARTEMIS-1503 Added ng-grid plugin ---
[GitHub] activemq-artemis pull request #1635: ARTEMIS-1486 Clean up client disconnect...
Github user stanlyDoge closed the pull request at: https://github.com/apache/activemq-artemis/pull/1635 ---
[GitHub] activemq-artemis pull request #1636: ARTEMIS-1486 clean up and added JMS cli...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1636 ARTEMIS-1486 clean up and added JMS client test You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 1486-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1636.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1636 commit 6309b4a2cf6309c6337f0a0558c3ee614c16b592 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-11-02T17:11:29Z ARTEMIS-1486 added JMS client test ---
[GitHub] activemq-artemis pull request #1635: ARTEMIS-1486 Clean up client disconnect...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1635 ARTEMIS-1486 Clean up client disconnecting tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 chngs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1635.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1635 commit e8bc60ee003213dd90369cf6786190ae1dc24326 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-10-31T13:08:23Z ARTEMIS-1486 Core client should be notified if consumer is closed on broker side commit c0ac1836dc8f851c293a41838db2555946dc5047 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-11-02T17:11:29Z ARTEMIS-1486 added JMS client test ---
[GitHub] activemq-artemis pull request #1629: ARTEMIS-1486 Core client should be noti...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1629#discussion_r148531299
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
---
@@ -1978,6 +1980,36 @@ public void testConnectorServiceManagement() throws
Exception {
Assert.assertEquals("myconn2",
managementControl.getConnectorServices()[0]);
}
+ @Test
+ public void testCloseConsumer() throws Exception {
+ SimpleString address = RandomUtil.randomSimpleString();
+ SimpleString name = RandomUtil.randomSimpleString();
+ boolean durable = true;
+
+ ActiveMQServerControl serverControl = createManagementControl();
+
+
checkNoResource(ObjectNameBuilder.DEFAULT.getQueueObjectName(address, name,
RoutingType.ANYCAST));
+ serverControl.createAddress(address.toString(), "ANYCAST");
+ serverControl.createQueue(address.toString(), "ANYCAST",
name.toString(), null, durable, -1, false, false);
+
+ ServerLocator receiveLocator = createInVMNonHALocator();
+ ClientSessionFactory receiveCsf =
createSessionFactory(receiveLocator);
+ ClientSession receiveClientSession = receiveCsf.createSession(true,
false, false);
+ final ClientConsumer consumer =
receiveClientSession.createConsumer(name);
+ final ClientProducer producer =
receiveClientSession.createProducer(name);
+
+ ServerSession ss = server.getSessions().iterator().next();
+ ServerConsumer sc = ss.getServerConsumers().iterator().next();
+
+ producer.send(receiveClientSession.createMessage(true));
+ consumer.receive(1000);
+
+ Assert.assertFalse(consumer.isClosed());
+
serverControl.closeConsumerWithID(((ClientSessionImpl)receiveClientSession).getName(),
Long.toString(sc.sequentialID()));
+ Wait.waitFor(() -> consumer.isClosed(), 1000, 100);
--- End diff --
ah, thanks
---
[GitHub] activemq-artemis pull request #1629: ARTEMIS-1486 Core client should be noti...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1629 ARTEMIS-1486 Core client should be notified if consumer is closed on ⦠â¦broker side If consumer is closed on broker using e.g. Hawtio console, client connected as that consumer (representation of broker resource) should be notified about that fact and react to that. It doesn't seem to react. If consumer is closed, as a result of not being notified, client hangs in the air and cannot receive messages. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1486 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1629.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1629 commit e8bc60ee003213dd90369cf6786190ae1dc24326 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-10-31T13:08:23Z ARTEMIS-1486 Core client should be notified if consumer is closed on broker side ---
[GitHub] activemq-artemis issue #1534: ARTEMIS-1420 limit non-ssl connection hangs up...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1534 @mtaylor Thanks, changed. ---
[GitHub] activemq-artemis pull request #1594: ARTEMIS-1467 example showing the recomm...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1594 ARTEMIS-1467 example showing the recommended approach for migrating example showing the recommended approach for migrating messages from ActiveMQ to Artemis You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1467 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1594 commit 685de050aedaf567e88da9140d87d0d2ecd7c2c1 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-10-18T08:47:59Z ARTEMIS-1467 example showing the recommended approach for migrating messages ---
[GitHub] activemq-artemis issue #1534: ARTEMIS-1420 limit non-ssl connection hangs up...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1534 I've already pushed removing ReadTimeoutHandler [here](https://github.com/apache/activemq-artemis/pull/1534/commits/10c9495370d3bcaf2644296e1240973441c7213e#diff-7b6326b533c4bbb0db4e315e781d8cbcR734) but i am not sure if it is enough. Also i have to adapt test as you say. ---
[GitHub] activemq-artemis pull request #1534: ARTEMIS-1420 limit non-ssl connection h...
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1534#discussion_r139663458 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpClientTestSupport.java --- @@ -185,6 +187,7 @@ protected TransportConfiguration addAcceptorConfiguration(ActiveMQServer server, HashMap<String, Object> params = new HashMap<>(); params.put(TransportConstants.PORT_PROP_NAME, String.valueOf(port)); params.put(TransportConstants.PROTOCOLS_PROP_NAME, getConfiguredProtocols()); + params.put(TransportConstants.NETTY_READ_TIMEOUT, readTimeout); --- End diff -- Actually it is 3 seconds. It is just typo in property string. I've tried to make test as you say. Check it in new commit. And thanks for reviewing! :) ---
[GitHub] activemq-artemis pull request #1534: ARTEMIS-1420 limit non-ssl connection h...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1534 ARTEMIS-1420 limit non-ssl connection hangs up exceeding client(s) You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1420 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1534.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1534 commit 518e5c5491aa7261b6864b81617434aadd6e34c1 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-09-13T14:50:42Z ARTEMIS-1420 ---
[GitHub] activemq-artemis issue #1511: ARTEMIS-1385 appendix
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1511 retest this please ---
[GitHub] activemq-artemis pull request #1511: ARTEMIS-1385 appendix
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1511 ARTEMIS-1385 appendix I have missed some files (probably grepped at wrong branch) You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1385-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1511 commit a27f40dd426910c15e33f2f3686f7e7e5c7354a9 Author: Stanislav Knot <sk...@redhat.com> Date: 2017-09-06T07:26:00Z ARTEMIS-1385 appendix ---
[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136987322 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt --- @@ -1,6 +1,6 @@
[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1509 ARTEMIS-1385 fixed uncomplete comment and typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1385 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1509.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1509 commit a6c0789e4da2b2f4b5854db8b3e67bb770d86c2f Author: Stanislav Knot <sk...@eredhat.com> Date: 2017-09-05T07:09:01Z ARTEMIS-1385 fixed uncomplete comment and typo ---
