Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r184601120
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2713,11 @@ private Message
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r184600627
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2714,11 @@ private Message
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2040#discussion_r183632055
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java
---
@@ -323,7 +323,7 @@ public static double
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/2010
@clebertsuconic polished :)
---
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/2013
@gaohoward Done.
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/2040
ARTEMIS-1824 running broker from path with non-ascii chars
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/2020
Aha, thanks for explanation!
---
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/2020
While sending AMQP message, addReceiver() is called, which causes creating
a queue.
While sending openwire message, addConsumer() is called, which also causes
creating a queue
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/2013
@gaohoward Done.
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/2020
ARTEMIS-1812 fix for missing (core) messages after master kill (HA)
When I try to send some core messages to slave broker (master is dead),
messages are lost. Debug console says
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/2013
ARTEMIS-1805 fix for broker operations in hawtio
There are two operations, which causes an error while selected in hawtio
console under broker/operations. Adding @Operation annotation
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180976916
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2727,7 +2731,7 @@ private Message
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180971622
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
---
@@ -511,22 +511,24
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180654379
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -2769,7 +2769,7 @@ public
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180649567
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -2769,7 +2769,7 @@ public
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/2010
ARTEMIS-1801 removing null-unchecked dereferences
There were some cases where value was checked for null and later directly
dereferenced without check. I added checks. I am not sure
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/2006
@clebertsuconic Renamed.
---
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180413588
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
---
@@ -511,6 +511,45
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/2006
ARTEMIS-1798 DEBUG message bad write method arg count - fix
When the logging level was set up to DEBUG,
FluentPropertyBeanIntrospectorWithIgnores threw an exception
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1994
This PR is partly reverting
https://github.com/apache/activemq-artemis/pull/1734
AFAIK including some internal properties break JMS API specification.
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1994
ARTEMIS-1787 Openwire message should not contain internal property
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1988
ARTEMIS-1782 fix for displaying hawtio console sub-level tabs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1974
NO-JIRA browsing messages do not change items per page
This is fix of this fix :)
https://github.com/apache/activemq-artemis/pull/1749 (ARTEMIS-1579)
You can merge this pull
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1952#discussion_r174094053
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -644,8 +644,11 @@ public
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1952
ARTEMIS-1743 fix NPE in server log when Artemis trace logging is enabled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1951
ARTEMIS-1744 fix removing addresses and queues with '*' or '?' in their
names via hawtio console
You can merge this pull request into a Git repository by running:
$ git pull
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
Ah, I see. Yeah, it seem to be changed in
[ARTEMIS-1440](https://issues.apache.org/jira/browse/ARTEMIS-1440).
@clebertsuconic can you take a look?
---
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
Yes, it is. I used this conf: https://pastebin.com/2G0c341X
If I am not wrong, restaring logic is implemented as
[this](https://github.com/apache/activemq-artemis/blob/master
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1940
ARTEMIS-1737 fix for inaccessible slave console after failover
Can anybody review this? I will try to write some tests meanwhile. Thank
you.
You can merge this pull request
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1936
NO-JIRA invalid xmls in docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis doctypo
Alternatively
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1913
@clebertsuconic Done
---
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1913#discussion_r172447340
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1913#discussion_r172446094
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1913#discussion_r172115995
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/deleteDivert.html ---
@@ -0,0 +1,24 @@
+
+
--- End diff
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1921
ARTEMIS-1725 fix browsing non-listing tabs under JMX
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1913
ARTEMIS-1715 Disable to remove a divert from hawtio console
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1837
AFAIK there is some effort to create some Selenium tests. I am not sure
when it could get into upstream.
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1898
ARTREMIS-1703 disable listing in web console
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1884
NO-JIRA typo in jmx-ssl example pom file
+ code format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1877
ARTEMIS-1692 fixed filtering consumers in hawtio console
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1870
ARTEMIS-1681 fix hawtio console security issue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis E1016
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1828
Done, let's wait for result :) Is there any else way how to kick off build?
---
Github user stanlyDoge closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1775
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1837
ARTEMIS-1603 fixed browsing tables under JMX tab
I hope it is not spaghetti code. First exp with angular.
You can merge this pull request into a Git repository by running:
$ git
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1828
@michaelandrepearce Good point. Pushing changes & test in few minutes.
---
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1828
I do not think failed test has any in common with these changes.
> Failed tests:
NetworkHealthTest.testCheckUsingHTTP:213 null
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1828
ARTEMIS-1646 fix for browsing messages sent via JS client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1775
Can I close this PR?
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1799
ARTEMIS-1625 fix moving messages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis E986
Alternatively
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1775#discussion_r162343251
--- Diff:
artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
@@ -2790,6 +2790,14
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1775
ARTEMIS-1587 Add setting to control the queue durable property for auâ¦
â¦to-created addresses
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1762
ARTEMIS-1580 Browsing in hawtio console does not allow to show empty â¦
â¦pages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160340487
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160086429
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1750
@michaelandrepearce Done
@jbertram ahh, that explains my another conflict. Thanks.
---
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1697
Oops with squashing. Should be ok now, let's wait for check.
---
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1697
@michaelandrepearce Yes, it should be ready.
---
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1688#discussion_r156064778
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -253,9 +253,12
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1688#discussion_r156024601
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -253,9 +253,12
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1697
This is just test fix. There are some issues with clients. I'll get back to
it later.
---
Github user stanlyDoge commented on the pull request:
https://github.com/apache/activemq-artemis/commit/26752a7aafa5651e41abf23ac550c6c09bb08287#commitcomment-26140681
In
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1697
> Behaviour should be the same
True, there was little misunderstanding. I am working at fix.
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1697
ARTEMIS-1341 fix test for getBytes
https://issues.apache.org/jira/browse/ARTEMIS-1341
You can merge this pull request into a Git repository by running:
$ git pull https
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1688#discussion_r155719121
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -253,9 +253,12
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1688
Thanks for your comment @jdanekrh
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1688
ARTEMIS-1537 broker was less strict while reloading configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1644
Yes, there is described reproducer by reporter of this issue.
> > you try to browse the queue to check the messages and you have more
than 40 messages ( depends on your
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1680
ARTEMIS-1530 Fix expiry statistics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis-1 ENTMQBR-919
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1667
ARTEMIS-1420 updated docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1420doc
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1644
ARTEMIS-1503 Added ng-grid plugin
The ng-grid needs the following plugin to automatically resize a table to
accomodate a varying number of rows.
You can merge this pull request
Github user stanlyDoge closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1635
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1636
ARTEMIS-1486 clean up and added JMS client test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis-1
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1635
ARTEMIS-1486 Clean up client disconnecting tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis-1
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1629#discussion_r148531299
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1629
ARTEMIS-1486 Core client should be notified if consumer is closed on â¦
â¦broker side
If consumer is closed on broker using e.g. Hawtio console, client connected
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
@mtaylor Thanks, changed.
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1594
ARTEMIS-1467 example showing the recommended approach for migrating
example showing the recommended approach for migrating messages from
ActiveMQ to Artemis
You can merge this pull
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
I've already pushed removing ReadTimeoutHandler
[here](https://github.com/apache/activemq-artemis/pull/1534/commits/10c9495370d3bcaf2644296e1240973441c7213e#diff
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1534#discussion_r139663458
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpClientTestSupport.java
---
@@ -185,6
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1534
ARTEMIS-1420 limit non-ssl connection hangs up exceeding client(s)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1511
retest this please
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1511
ARTEMIS-1385 appendix
I have missed some files (probably grepped at wrong branch)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1509#discussion_r136987322
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt
---
@@ -1,6 +1,6 @@
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1509
ARTEMIS-1385 fixed uncomplete comment and typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis-1
84 matches
Mail list logo
