Review Request 27319: Alerts: Convert Script-Style Flume Alerts From Nagios

2014-10-28 Thread Jonathan Hurley
, stopped flume service/agents and ran a configure to ensure that existing functionality still works. Updated existing flume tests Total run:679 Total errors:0 Total failures:0 OK Thanks, Jonathan Hurley

Review Request 27331: Show all properties for source subresource in alert_definitions API response

2014-10-29 Thread Jonathan Hurley
://reviews.apache.org/r/27331/diff/ Testing --- New tests added to cover: - Ensuring that the source subproperties are present when the source is present - Ensuring that the source subproperties are not present when the source is not present Thanks, Jonathan Hurley

Nagios Alert Ambari 2.0

2014-10-29 Thread Jonathan Hurley
Hi Committers Contributors, With Ambari 2.0, a new alerts framework has been implemented with the intent to replace Nagios. If you would like to learn more about this feature, the design documents can be found in the Jira epic at https://issues.apache.org/jira/browse/AMBARI-6354. The work

Re: Nagios Alert Ambari 2.0

2014-10-29 Thread Jonathan Hurley
instance? That we remove the service from Ambari still leaves a dangling service. Thanks, Nate On Oct 29, 2014, at 2:47 PM, Jonathan Hurley jhur...@hortonworks.com wrote: Hi Committers Contributors, With Ambari 2.0, a new alerts framework has been implemented with the intent

Review Request 27372: Alerts: Creating WEB Alert Definitions via REST API Drops URI

2014-10-29 Thread Jonathan Hurley
to reflect the changes and to further exercise the uri and reporting structures. Thanks, Jonathan Hurley

Review Request 27394: Alerts: Convert HDP 1.x Nagios Alerts

2014-10-30 Thread Jonathan Hurley
with HDP 1.3, verified that all alerts were working correctly. Toggled services, verified alerts were also changing state properly. Thanks, Jonathan Hurley

Re: Review Request 27435: Views: 400 error on redeploy

2014-10-31 Thread Jonathan Hurley
collection instead of calling getSubResourceDefinitions? - Jonathan Hurley On Oct. 31, 2014, 2:29 p.m., Tom Beerbower wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27435

Re: Review Request 27435: Views: 400 error on redeploy

2014-10-31 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27435/#review59383 --- Ship it! Thanks for the explanation. - Jonathan Hurley On Oct

Re: Nagios Alert Ambari 2.0

2014-10-31 Thread Jonathan Hurley
mechanism. Thanks, Newton On Wed, Oct 29, 2014 at 2:01 PM, Jonathan Hurley jhur...@hortonworks.com wrote: Great question! Yes, the upgrade will remove the Nagios service from Ambari, leaving a dangling Nagios instance that needs to be manually decommissioned from running Ambari

Re: Review Request 27396: Pushing component logs to HDFS from ambari-agent

2014-10-31 Thread Jonathan Hurley
. - Jonathan Hurley On Oct. 31, 2014, 7:50 p.m., Cabir Zounaidou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27396

Re: Review Request 27454: Flume: Change default env variables for HCAT and HIVE for cluster version

2014-11-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27454/#review59471 --- Ship it! Ship It! - Jonathan Hurley On Nov. 1, 2014, 1:06 p.m

Review Request 27485: Add alerts for ZKFC down

2014-11-01 Thread Jonathan Hurley
: 11.033 s [INFO] Finished at: 2014-11-01T15:16:32-04:00 [INFO] Final Memory: 10M/81M [INFO] Thanks, Jonathan Hurley

Re: Review Request 27530: HostComponent requests that include Nagios are not performant

2014-11-03 Thread Jonathan Hurley
handles this for 1.7.0 - Jonathan Hurley On Nov. 3, 2014, 12:32 p.m., Nate Cole wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27530

Re: Review Request 26726: Broken Dashboard page after upgrade to ambari-1.7.0 version

2014-11-04 Thread Jonathan Hurley
On Oct. 15, 2014, 9:12 a.m., Jonathan Hurley wrote: Ship It! Has this been commmitted? If so, can you close it out? - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26726

Re: Review Request 27532: Correct Issues Pointed Out In Git 32187893edabcfc29f1cfb4961146566c2215433

2014-11-04 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27532/#review59765 --- Ship it! Ship It! - Jonathan Hurley On Nov. 3, 2014, 2:27 p.m

Review Request 27582: Alerts: NameNode Health HA Alert Check

2014-11-04 Thread Jonathan Hurley
.ambari.apache.org:50070'] state : OK, text : Active['c6402.ambari.apache.org:50070'], Standby['c6401.ambari.apache.org:50070'], Unknown[] New tests added as well... Thanks, Jonathan Hurley

Re: Review Request 27582: Alerts: NameNode Health HA Alert Check

2014-11-04 Thread Jonathan Hurley
['c6401.ambari.apache.org:50070'] state : OK, text : Active['c6402.ambari.apache.org:50070'], Standby['c6401.ambari.apache.org:50070'], Unknown[] New tests added as well... Thanks, Jonathan Hurley

Re: Review Request 27590: Upgrade Execute: Create API endpoint for upgrades and upgrade items

2014-11-04 Thread Jonathan Hurley
? - Jonathan Hurley On Nov. 4, 2014, 4:55 p.m., Nate Cole wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27590/ --- (Updated Nov

Re: Review Request 27590: Upgrade Execute: Create API endpoint for upgrades and upgrade items

2014-11-04 Thread Jonathan Hurley
On Nov. 4, 2014, 6:22 p.m., Jonathan Hurley wrote: ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java, line 106 https://reviews.apache.org/r/27590/diff/1/?file=749671#file749671line106 Hungarian anyone? Alejandro Fernandez

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-05 Thread Jonathan Hurley
-DDL-MySQL-CREATE.sql https://reviews.apache.org/r/27607/#comment101270 When starting the sequence at 1, the initial value for cluster_version and host_version will be 2. I always disliked that. - Jonathan Hurley On Nov. 4, 2014, 11:30 p.m., Alejandro Fernandez wrote

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-06 Thread Jonathan Hurley
SQL says this is NOT NULL - Jonathan Hurley On Nov. 5, 2014, 5:02 p.m., Alejandro Fernandez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27607

Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Jonathan Hurley
BT stack alert implementation. Installed a BT 0.8 cluster with all services, verified alerts are working correctly. Thanks, Jonathan Hurley

Re: Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Jonathan Hurley
--- Added test cases found for issues during BT stack alert implementation. Installed a BT 0.8 cluster with all services, verified alerts are working correctly. Thanks, Jonathan Hurley

Re: Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27688/#review60257 --- On Nov. 6, 2014, 12:48 p.m., Jonathan Hurley wrote

Re: Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Jonathan Hurley
correctly. Thanks, Jonathan Hurley

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-06 Thread Jonathan Hurley
to be readable for all of the other tables? :) ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java https://reviews.apache.org/r/27607/#comment101644 Formatting is off here. - Jonathan Hurley On Nov. 6, 2014, 5:03 p.m., Alejandro Fernandez wrote

Re: Review Request 27726: Views: Instance Data API doesn't work in threads

2014-11-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27726/#review60348 --- Ship it! Ship It! - Jonathan Hurley On Nov. 7, 2014, 12:43 p.m

Re: Review Request 27740: ambari cluster HS2 health check causing errors in logs

2014-11-07 Thread Jonathan Hurley
for trunk, then alert_hive_thrift_port.py uses the hive_check function. You should also verify that your changes also work on the new alerts framework. You can verify this alert by executing http://localhost:8080/api/v1/clusters/c1/alerts?Alert/name=hive_server_process - Jonathan Hurley On Nov

Re: Review Request 27740: ambari cluster HS2 health check causing errors in logs

2014-11-07 Thread Jonathan Hurley
=security_enabled) If this code change is for trunk, you'll need to update the new alert scripts as well. If it's not for trunk, then you can close the issue. - Jonathan Hurley On Nov. 7, 2014, 3:04 p.m., Andrew Onischuk wrote

Review Request 27790: Alerts: Provide Summary Structure On Alerts Endpoint

2014-11-09 Thread Jonathan Hurley
: https://reviews.apache.org/r/27790/diff/ Testing --- New tests added to ensure the renderer converts the flattened alert data correctly. Thanks, Jonathan Hurley

Re: Review Request 27802: Rest api's for host component logs.

2014-11-10 Thread Jonathan Hurley
and Views does this. ambari-server/src/main/resources/properties.json https://reviews.apache.org/r/27802/#comment101970 Same for above, the direction has been to have the provider define these and not this file. - Jonathan Hurley On Nov. 10, 2014, 4:04 a.m., Cabir Zounaidou wrote

Re: Review Request 27790: Alerts: Provide Summary Structure On Alerts Endpoint

2014-11-10 Thread Jonathan Hurley
., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27790/ --- (Updated Nov. 9, 2014, 9:14 a.m.) Review

Re: Review Request 27810: Alerts: SNMP Target for Notifications

2014-11-10 Thread Jonathan Hurley
://reviews.apache.org/r/27810/#comment101981 SNMPv2 PDU types are not supported by this. Should this be a determination based on the supplied properties? - Jonathan Hurley On Nov. 10, 2014, 10:49 a.m., Yurii Shylov wrote

Re: Review Request 27841: Ambari DB DDL create script doesn't properly create table cluster_version

2014-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27841/#review60714 --- Ship it! Ship It! - Jonathan Hurley On Nov. 10, 2014, 6:14 p.m

Review Request 27870: Alerts: Remove Nagios Service From The Stack

2014-11-11 Thread Jonathan Hurley
] [INFO] Total time: 25:19 min [INFO] Finished at: 2014-11-11T10:32:33-05:00 [INFO] Final Memory: 29M/195M [INFO] Thanks, Jonathan Hurley

Review Request 27884: Alerts: Provide Grouped Summary Structure On Alerts Endpoint

2014-11-11 Thread Jonathan Hurley
/AlertResourceProviderTest.java 2bac86a Diff: https://reviews.apache.org/r/27884/diff/ Testing --- New test added to cover the new renderer. Thanks, Jonathan Hurley

Re: Review Request 27884: Alerts: Provide Grouped Summary Structure On Alerts Endpoint

2014-11-11 Thread Jonathan Hurley
/AlertResourceProviderTest.java 2bac86a Diff: https://reviews.apache.org/r/27884/diff/ Testing --- New test added to cover the new renderer. Thanks, Jonathan Hurley

Re: Review Request 27901: Format DDL scripts CREATE TABLE statements

2014-11-11 Thread Jonathan Hurley
easier to read! Where's my +2 button? - Jonathan Hurley On Nov. 11, 2014, 9:09 p.m., Alejandro Fernandez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27901

Re: Review Request 27810: Alerts: SNMP Target for Notifications

2014-11-12 Thread Jonathan Hurley
On Nov. 10, 2014, 11:09 a.m., Jonathan Hurley wrote: ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, line 30 https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30 Public fields should be capitalized. Yurii Shylov

Re: Review Request 27913: Views: support validation

2014-11-12 Thread Jonathan Hurley
/apache/ambari/server/view/validation/InstanceValidationResultImpl.java https://reviews.apache.org/r/27913/#comment102435 Gson is thread-safe to reuse, but costly to instantiate. I would say make this static and just reuse the Gson instance that's built once. - Jonathan Hurley On Nov. 12, 2014

Re: Review Request 27913: Views: support validation

2014-11-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27913/#review60999 --- Ship it! Ship It! - Jonathan Hurley On Nov. 12, 2014, 11:38 a.m

Review Request 27929: Alerts: Remove Nagios Remnants From Ambari Server Code

2014-11-12 Thread Jonathan Hurley
/BaseBlueprintProcessorTest.java 7eb28df ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 48b9077 Diff: https://reviews.apache.org/r/27929/diff/ Testing --- Updated tests to reflect the removed code. Thanks, Jonathan Hurley

Re: Review Request 27810: Alerts: SNMP Target for Notifications

2014-11-12 Thread Jonathan Hurley
On Nov. 10, 2014, 11:09 a.m., Jonathan Hurley wrote: ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, line 30 https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30 Public fields should be capitalized. Yurii Shylov

Re: Review Request 27929: Alerts: Remove Nagios Remnants From Ambari Server Code

2014-11-12 Thread Jonathan Hurley
[INFO] Thanks, Jonathan Hurley

Re: Review Request 27396: Pushing component logs to HDFS from ambari-agent

2014-11-13 Thread Jonathan Hurley
On Nov. 3, 2014, 3:53 p.m., Jonathan Hurley wrote: What happens when this agent code is installed in a cluster that's not running HDFS (GlusterFS for example)? Cabir Zounaidou wrote: Presently, the command will fail and will not push the log files to HDFS. For log to work, we

Re: Review Request 27802: Rest api's for host component logs.

2014-11-13 Thread Jonathan Hurley
https://reviews.apache.org/r/27802/#comment102779 It seems like you might need this to handle the incoming config commands. Why did you remove it? - Jonathan Hurley On Nov. 12, 2014, 8:01 p.m., Cabir Zounaidou wrote

Review Request 27993: Alerts: Remove All Nagios References From Agent Code

2014-11-13 Thread Jonathan Hurley
] Thanks, Jonathan Hurley

Review Request 27999: Remove Nagios SSL Configuration From Ambari Scripts

2014-11-13 Thread Jonathan Hurley
the credential store: Enter choice, (1-4): 4 Setting up Ambari kerberos JAAS configuration to access secured Hadoop daemons... Enter ambari server's kerberos principal name (amb...@example.com): Enter choice, (1-4): 5 Invalid choice ``` Thanks, Jonathan Hurley

Re: Review Request 28031: API: null value in request results in null string value on resource

2014-11-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28031/#review61442 --- Ship it! Ship It! - Jonathan Hurley On Nov. 14, 2014, 6:15 a.m

Review Request 28105: Alerts: Remove Flume Alerts From Host Components

2014-11-16 Thread Jonathan Hurley
and hdfs file sync). Verifed that start/stopping/killing the agent processes was correctly reflected in the UI. mvn clean test as well. Thanks, Jonathan Hurley

Re: Review Request 28095: Add Kerberos State to Ambari database

2014-11-17 Thread Jonathan Hurley
across the various hosts become ENABLED as well? ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql https://reviews.apache.org/r/28095/#comment103570 The MySQL script defaults this value to `OFF`, should this script as well? - Jonathan Hurley On Nov. 17, 2014, 9:45 a.m

Re: Review Request 28095: Add Kerberos State to Ambari database

2014-11-17 Thread Jonathan Hurley
On Nov. 17, 2014, 10:04 a.m., Jonathan Hurley wrote: ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 106 https://reviews.apache.org/r/28095/diff/1/?file=765059#file765059line106 The MySQL script defaults this value to `OFF`, should this script as well

Review Request 28123: Alert Groups REST Endpoint Should Support Associated Definitions

2014-11-17 Thread Jonathan Hurley
/r/28123/diff/ Testing --- New tests added; mvn clean test Thanks, Jonathan Hurley

Re: Review Request 28123: Alert Groups REST Endpoint Should Support Associated Definitions

2014-11-17 Thread Jonathan Hurley
/AlertGroupResourceProviderTest.java 1c85aeb Diff: https://reviews.apache.org/r/28123/diff/ Testing --- New tests added; mvn clean test Thanks, Jonathan Hurley

Re: Review Request 28123: Alert Groups REST Endpoint Should Support Associated Definitions

2014-11-17 Thread Jonathan Hurley
of the definitions ... http://localhost:8080/api/v1/clusters/c1/alert_groups/1/alert_definitions?fields=AlertDefinition/label With a property you have to get all or none. Jonathan Hurley wrote: I did consider making this a sub resource, but I don't think it's necessary since

Review Request 28159: Alerts: Targets Should Support A Severity Level

2014-11-17 Thread Jonathan Hurley
/UpgradeCatalog200Test.java be97222 Diff: https://reviews.apache.org/r/28159/diff/ Testing --- mvn clean test and manual testing to ensure that the alert targets are skipped and no notices are created. Thanks, Jonathan Hurley

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

2014-11-18 Thread Jonathan Hurley
, 2014, 12:34 a.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/ --- (Updated Nov. 18, 2014, 12:34 a.m

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

2014-11-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/#review61915 --- On Nov. 18, 2014, 12:34 a.m., Jonathan Hurley wrote

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

2014-11-18 Thread Jonathan Hurley
/#review61920 --- On Nov. 18, 2014, 12:34 a.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

2014-11-18 Thread Jonathan Hurley
that the alert targets are skipped and no notices are created. Thanks, Jonathan Hurley

Review Request 28181: AlertGroup REST Endpoint Should Return Alert Definition Source Type

2014-11-18 Thread Jonathan Hurley
/server/controller/internal/AlertGroupResourceProviderTest.java 422c6f2 Diff: https://reviews.apache.org/r/28181/diff/ Testing --- mvn clean test Thanks, Jonathan Hurley

Review Request 28194: Alerts UI: Alert Definition API should provide a 'description' field

2014-11-18 Thread Jonathan Hurley
] [INFO] Total time: 12:54 min [INFO] Finished at: 2014-11-18T09:04:37-05:00 [INFO] Final Memory: 30M/606M [INFO] Thanks, Jonathan Hurley

Re: Review Request 28194: Alerts UI: Alert Definition API should provide a 'description' field

2014-11-19 Thread Jonathan Hurley
] BUILD SUCCESS [INFO] [INFO] Total time: 12:54 min [INFO] Finished at: 2014-11-18T09:04:37-05:00 [INFO] Final Memory: 30M/606M [INFO] Thanks, Jonathan

Review Request 28291: Alerts: Template Engine for Dispatching

2014-11-20 Thread Jonathan Hurley
/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28291/diff/ Testing --- New tests written to cover dispatch service. mvn clean test Thanks, Jonathan Hurley

Re: Review Request 28291: Alerts: Template Engine for Dispatching

2014-11-20 Thread Jonathan Hurley
] Thanks, Jonathan Hurley

Re: Review Request 28291: Alerts: Template Engine for Dispatching

2014-11-20 Thread Jonathan Hurley
/r/28291/#review62517 --- On Nov. 20, 2014, 2:16 p.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28291

Re: Review Request 28095: Add Kerberos State to Ambari database

2014-11-20 Thread Jonathan Hurley
pointed out. ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql https://reviews.apache.org/r/28095/#comment104556 Oracle's syntax requires the DEFAULT statement to appear before the NOT NULL. - Jonathan Hurley On Nov. 20, 2014, 4:21 p.m., Robert Levas wrote

Re: Review Request 28291: Alerts: Template Engine for Dispatching

2014-11-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28291/#review62536 --- On Nov. 20, 2014, 2:16 p.m., Jonathan Hurley wrote

Re: Review Request 28095: Add Kerberos State to Ambari database

2014-11-21 Thread Jonathan Hurley
On Nov. 20, 2014, 11:35 p.m., Jonathan Hurley wrote: ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 106 https://reviews.apache.org/r/28095/diff/2/?file=766531#file766531line106 Oracle's syntax requires the DEFAULT statement to appear before the NOT NULL

Re: [VOTE] Ambari 1.7.0 release

2014-11-22 Thread Jonathan Hurley
+1 for 1.7.0 On Nov 22, 2014 1:54 AM, Jaimin Jetly jai...@hortonworks.com wrote: +1 for the 1.7.0 release candidate. Thanks Jaimin Jetly On Fri, Nov 21, 2014 at 10:11 PM, jun aoki ja...@apache.org wrote: +1 Great work! On Fri, Nov 21, 2014 at 6:07 PM, Ravi Mutyala

Re: Review Request 28336: Provide stage resource information via REST API

2014-11-24 Thread Jonathan Hurley
the page/sorting info. Maybe I just missed it. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity_.java https://reviews.apache.org/r/28336/#comment104847 Copy/paste error? - Jonathan Hurley On Nov. 22, 2014, 9:18 a.m., Tom Beerbower wrote

Re: Review Request 28336: Provide stage resource information via REST API

2014-11-24 Thread Jonathan Hurley
On Nov. 24, 2014, 8:31 a.m., Jonathan Hurley wrote: ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java, line 186 https://reviews.apache.org/r/28336/diff/4/?file=773593#file773593line186 How does this request inform

Re: Review Request 28336: Provide stage resource information via REST API

2014-11-24 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28336/#review62801 --- Ship it! Ship It! - Jonathan Hurley On Nov. 24, 2014, 11:21 a.m

Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Jonathan Hurley
, Jonathan Hurley

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Jonathan Hurley
://reviews.apache.org/r/28394/#review62891 --- On Nov. 24, 2014, 1:33 p.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Jonathan Hurley
for the service and the default group. Thanks, Jonathan Hurley

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28394/#review62886 --- On Nov. 25, 2014, 12:33 a.m., Jonathan Hurley wrote

Review Request 28453: Alerts: Remove Deprecated NagiosPropertyProvider Stub

2014-11-25 Thread Jonathan Hurley
] [INFO] Total time: 25:37 min [INFO] Finished at: 2014-11-25T15:08:24-05:00 [INFO] Final Memory: 30M/226M Thanks, Jonathan Hurley

Review Request 28480: Alerts: AlertDefinition and AlertGroup Automatic Creation On Startup

2014-11-26 Thread Jonathan Hurley
a 2.0.0 startup for the first time. Thanks, Jonathan Hurley

Re: Review Request 28480: Alerts: AlertDefinition and AlertGroup Automatic Creation On Startup

2014-11-26 Thread Jonathan Hurley
--- On Nov. 26, 2014, 3:36 p.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28480

Re: Review Request 27810: Alerts: SNMP Target for Notifications

2014-12-01 Thread Jonathan Hurley
/ambari/server/notifications/dispatchers/SNMPDispatcher.java https://reviews.apache.org/r/27810/#comment105602 This method is not needed. - Jonathan Hurley On Nov. 26, 2014, 12:19 p.m., Yurii Shylov wrote

Review Request 28592: Alerts: Upgrade Should Remove Nagios If Installed

2014-12-01 Thread Jonathan Hurley
that Nagio has been removed from the host, and as a service from the cluster. New tests added to verify removal of Nagios during 2.0.0 DML update. Thanks, Jonathan Hurley

Re: Easy way to debug ambari-server API code

2014-12-02 Thread Jonathan Hurley
Hi Pankaj, It looks like you have not built the entire project from the root at least once. This will actually build the dependent modules, like ambari-views.jar (which is what you’re missing). Since ambari-server depends on ambari-views, you’ll need to build ambari-views and install the

Re: Review Request 28624: Views: Add new view parameter fields.

2014-12-02 Thread Jonathan Hurley
with an explicit name. I like using an explicit name since you change the field without repurcussions. - Jonathan Hurley On Dec. 2, 2014, 9:33 p.m., Tom Beerbower wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 28615: Alerts: Create A Global Alert Target For All Alert Groups

2014-12-03 Thread Jonathan Hurley
--- On Dec. 2, 2014, 6:38 p.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28615

Re: Review Request 28646: ambari cluster HS2 health check causing errors in logs

2014-12-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28646/#review63674 --- Ship it! Ship It! - Jonathan Hurley On Dec. 3, 2014, 9:52 a.m

Re: Review Request 28615: Alerts: Create A Global Alert Target For All Alert Groups

2014-12-04 Thread Jonathan Hurley
and verified that it automatically received notifications. Thanks, Jonathan Hurley

Re: Review Request 28644: Alerts: Nagios Target for Notifications

2014-12-04 Thread Jonathan Hurley
here as we're creating a Nagios template for the alert command with the username and password in plaintext as arguments. We need to obfuscate this on some level so someone looking at the file can't just figure out what it is. - Jonathan Hurley On Dec. 3, 2014, 7:34 a.m., Yurii Shylov wrote

Review Request 28765: Alert JSON Files Need Descriptions

2014-12-05 Thread Jonathan Hurley
[INFO] Thanks, Jonathan Hurley

Re: Review Request 28765: Alert JSON Files Need Descriptions

2014-12-05 Thread Jonathan Hurley
' ? - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28765/#review64064 --- On Dec. 5, 2014, 2:37 p.m., Jonathan Hurley wrote

Re: Review Request 28765: Alert JSON Files Need Descriptions

2014-12-05 Thread Jonathan Hurley
] [INFO] Total time: 6.969 s [INFO] Finished at: 2014-12-05T10:44:03-05:00 [INFO] Final Memory: 8M/81M [INFO] Thanks, Jonathan Hurley

Review Request 28823: AlertTargets Should Allow AlertGroup Associations To Be Modified From POST

2014-12-08 Thread Jonathan Hurley
://reviews.apache.org/r/28823/diff/ Testing --- Manually tested creation and updating groups via the alert target. New unit tests written to cover new methods and functionality. Thanks, Jonathan Hurley

Re: Review Request 28823: AlertTargets Should Allow AlertGroup Associations To Be Modified From POST

2014-12-09 Thread Jonathan Hurley
. To reply, visit: https://reviews.apache.org/r/28823/#review64324 --- On Dec. 8, 2014, 4:57 p.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 28644: Alerts: Nagios Target for Notifications

2014-12-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28644/#review64372 --- Ship it! Ship It! - Jonathan Hurley On Dec. 8, 2014, 12:34 p.m

Re: Review Request 27810: Alerts: SNMP Target for Notifications

2014-12-09 Thread Jonathan Hurley
Missing documentation. ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java https://reviews.apache.org/r/27810/#comment107157 Missing documentation. - Jonathan Hurley On Dec. 8, 2014, 7:53 a.m., Yurii Shylov wrote

Review Request 28874: Alert Host Count Summary Exposed Via Cluster Endpoint

2014-12-09 Thread Jonathan Hurley
/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 6876877 Diff: https://reviews.apache.org/r/28874/diff/ Testing --- New tests added to cover new summary. Thanks, Jonathan Hurley

Re: Review Request 28874: Alert Host Count Summary Exposed Via Cluster Endpoint

2014-12-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28874/#review64462 --- On Dec. 9, 2014, 5:24 p.m., Jonathan Hurley wrote

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

2014-12-11 Thread Jonathan Hurley
. 10, 2014, 11:59 p.m.) Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower. Bugs: AMBARI-8449 https://issues.apache.org/jira/browse/AMBARI-8449 Repository: ambari Description --- The requirement for Upgrade Pack definition

Re: Review Request 28519: Components should indicate Security State (via ambari-agent)

2014-12-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28519/#review64837 --- Ship it! Ship It! - Jonathan Hurley On Dec. 10, 2014, 7:11 a.m

Review Request 29011: Upgrade Pack definition for Core Slaves Components

2014-12-12 Thread Jonathan Hurley
-- Total run:682 Total errors:0 Total failures:0 OK Thanks, Jonathan Hurley

  1   2   3   4   5   6   7   8   9   10   >