://reviews.apache.org/r/29769/diff/
Testing
---
OK
--
Total run:572
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29769/#review67464
---
On Jan. 9, 2015, 1:08 p.m., Jonathan Hurley wrote:
>
>
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29769/#review67470
---
On Jan. 9, 2015, 1:08 p.m., Jonathan Hurley wrote:
>
> ---
--
Total run:572
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/#review67648
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 9, 2015, 8:19 p.m
/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/29814/#comment111738>
Maybe something more human readable; "Updating Hive Configuration" or
"Updating Datanode Configuration"
- Jonathan Hurley
On Jan. 12, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29547/#review67880
---
Committed; please close this review.
- Jonathan Hurley
On Jan. 9
pgrade_test.xml
aee1fcf
Diff: https://reviews.apache.org/r/29858/diff/
Testing
---
New tests written, full tests pending...
Thanks,
Jonathan Hurley
esources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml
aee1fcf
Diff: https://reviews.apache.org/r/29858/diff/
Testing (updated)
---
New tests written
Tests run: 2526, Failures: 0, Errors: 0, Skipped: 15
Thanks,
Jonathan Hurley
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29858/#review67920
---
On Jan. 13, 2015, 2:39 p.m., Jonathan Hurley wrote:
>
> ---
> Th
his ahead of time and store it?
Thoughts?
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29858/#review67921
-----
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29851/#review67936
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 13, 2015, 3:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29886/#review68059
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 14, 2015, 11:23 a.m
r something similar?
- Jonathan Hurley
On Jan. 14, 2015, 2:08 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
Ambari's log; we don't
want Velocity putting too much garbage in there and making it hard to read.
- Jonathan Hurley
On Jan. 14, 2015, 2:08 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-ma
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 739780c
Diff: https://reviews.apache.org/r/29894/diff/
Testing
---
Manual upgrade run, tests updated with expected values
--
Total run:583
Total err
I am sync’d to head currently and I do see the
[exec] TypeError: 'undefined' is not an object (evaluating
'this.get('controller.content.clientComponents').rejectProperty’)
error, so it’s not just you.
https://builds.apache.org/view/All/job/Ambari-trunk-Commit/1486/consoleFull
b.a.o also
ent112292>
Same issue as above with hdfs; this should probably not be hadoop-client.
There is another Jira that changes the "Clients" group to execute
"hdp-select set clients" at the end of the upgrade.
- Jonathan Hurley
On Jan. 14,
> On Jan. 14, 2015, 5:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py,
> > line 31
> > <https://reviews.apache.org/r/29790/diff/6/?file=821672#file821672line31>
> >
> >
running on machines
where other components/clients have not actually been updated yet. However, I
don't see a way around this exception to just do all of the work at the end in
the clients grouping. That Jira has already been filed.
- Jonathan Hurley
On Jan. 14, 2015, 4:45 p.m., Alej
not
be null.
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
<https://reviews.apache.org/r/29897/#comment112354>
Documentation
- Jonathan Hurley
On Jan. 14, 2015, 6:58 p.m., Nate Cole wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29897/#review68243
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 15, 2015, 8:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29923/#review68263
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 15, 2015, 8:49 a.m
> On Jan. 15, 2015, 11:19 a.m., Jonathan Hurley wrote:
> > Ship It!
Committed; the review can be closed.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29923/#re
9928/#comment112445>
Missing `break` statements on both.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/29928/#comment112446>
Add `break` for sanity
- Jonathan Hurley
On Jan. 15, 2015, 11
> On Jan. 7, 2015, 8:26 a.m., Jonathan Hurley wrote:
> > Ship It!
>
> Jonathan Hurley wrote:
> I agree that we should open a new Jira to track the framework change.
> I'll do that. Submitting this.
>
> Jonathan Hurley wrote:
> I think this issu
,
Jonathan Hurley
--------
On Jan. 15, 2015, 4:58 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29946/
> -
name, and the `nn` identifier. Such
as:
dfs.namenode.http-address.c1ha.nn2
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py
<https://reviews.apache.org/r/29950/#comment112550>
kinit needed here?
- Jonathan Hurley
On
> On Jan. 15, 2015, 7:07 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py,
> > lines 55-56
> > <https://reviews.apache.org/r/29950/diff/1/?file=823094#file823094line55>
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29957/#review68425
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 15, 2015, 10:38 p.m
? Some components also need
the conf directory as well.
- Jonathan Hurley
On Jan. 15, 2015, 11:10 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29928/#review68433
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 16, 2015, 10:34 a.m
r/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/29968/#comment112684>
forDowngrade or forceDowngrade?
- Jonathan Hurley
On Jan. 16, 2015, 1:29 p.m., Nate Cole wrote:
>
> ---
> This is an automatical
cripts/install_packages.py
<https://reviews.apache.org/r/29978/#comment112748>
differentl -> differently
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py
<https://reviews.apache.org/r/29978/#comment112749>
the -> there are
- Jonathan Hurley
On Jan. 16,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29978/#review68482
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 16, 2015, 3:07 p.m
y said they always have to run, so it was
easier to make it `true`.
- Jonathan Hurley
On Jan. 17, 2015, 8:52 a.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30031/#review68656
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 19, 2015, 10:01 a.m
---
Manual testing, new tests written to cover alert parsing case.
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29928/#review68723
---
Submitted to Git; please close the review.
- Jonathan Hurley
On
g/r/30077/#comment113108>
You removed `validate_topology` but it never gets added to
`createDirectives`; how does this directive get used now?
- Jonathan Hurley
On Jan. 20, 2015, 10:41 a.m., Tom Beerbower wrote:
>
> ---
> Thi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30077/#review68732
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 20, 2015, 10:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30101/#review68971
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 21, 2015, 1:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30135/#review69003
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 21, 2015, 3:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30138/#review69169
---
Ship it!
- Jonathan Hurley
On Jan. 22, 2015, 6:10 a.m., Tom
> On Jan. 7, 2015, 8:26 a.m., Jonathan Hurley wrote:
> > Ship It!
>
> Jonathan Hurley wrote:
> I agree that we should open a new Jira to track the framework change.
> I'll do that. Submitting this.
>
> Jonathan Hurley wrote:
> I think this issu
per keytab, the URL request would
hit a 401 Unauthorized error.
Do we use this pattern a lot? I'd think it would fail all over the place.
- Jonathan Hurley
On Jan. 22, 2015, 9:13 p.m., Alejandro Fernandez wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30216/#review69406
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 23, 2015, 11:39 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30214/#review69407
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 23, 2015, 11:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30222/#review69441
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 23, 2015, 1:50 p.m
> On Jan. 23, 2015, 9:05 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py,
> > line 84
> > <https://reviews.apache.org/r/30202/diff/2/?file=831417#file831417line84>
> >
> >
.
--
Total run:583
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
> On Jan. 23, 2015, 12:05 p.m., Jonathan Hurley wrote:
> > Ship It!
This patch was committed; the review can be closed.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
> On Jan. 23, 2015, 12:05 p.m., Jonathan Hurley wrote:
> > Ship It!
>
> Jonathan Hurley wrote:
> This patch was committed; the review can be closed.
Ping. This review can be closed.
- Jonathan
---
This i
> On Nov. 13, 2014, 9:57 a.m., Jonathan Hurley wrote:
> >
Ping. Can we close this review? It's 2 months old.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2780
t114598>
Shouldn't the upgrade logic take care of this?
- Jonathan Hurley
On Jan. 26, 2015, 11:10 p.m., Alejandro Fernandez wrote:
>
> ---
> This is an automatically gen
> On Jan. 27, 2015, 10:02 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java,
> > lines 491-494
> > <https://reviews.apache.org/r/30306/diff/1/?file=836148#file836148line491>
> >
> > Manua
/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/30306/#comment114720>
No reason you can't also pass in the cluster here to the constructor of the
HostComponentVersionEvent so that the event doesn't need to do the lookup.
- Jonathan Hurley
On Jan. 27, 2015, 3:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30306/#review69916
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 27, 2015, 5:33 p.m
/dao/HostComponentStateDAO.java
<https://reviews.apache.org/r/30343/#comment114932>
Why not used a named query here so that we can better catch JPQL errors at
startup time.
- Jonathan Hurley
On Jan. 27, 2015, 8:15 p.m., Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30332/#review70005
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 27, 2015, 5:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30356/#review70006
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 28, 2015, 7:46 a.m
BUILD SUCCESS
[INFO]
[INFO] Total time: 29:21 min
[INFO] Finished at: 2015-01-28T01:36:06-05:00
[INFO] Final Memory: 36M/443M
[INFO]
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30391/#review70205
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 28, 2015, 9:57 p.m
se.py c19bdb3
Diff: https://reviews.apache.org/r/30425/diff/
Testing
---
Executed RU...
---
Total run:587
Total errors:2
Total failures:0
ERROR
2 Errors in Knox unrelated to my changes
Thanks,
Jonathan Hurley
ed RU...
---
Total run:587
Total errors:2
Total failures:0
ERROR
2 Errors in Knox unrelated to my changes
Thanks,
Jonathan Hurley
erImpl.java
<https://reviews.apache.org/r/30451/#comment115478>
You can short circuit the loop at this point by just checking to see if
requestConfigProperties is null; no reason to do any extra work like getting
the clusterConfig if there's nothing in the request.
- Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30343/#review70463
---
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 30, 2015, 6:54 p.m
2.1.1/upgrades/upgrade_test.xml
37f8cc0
Diff: https://reviews.apache.org/r/30488/diff/
Testing
---
Performed an upgrade to verify that the configure task works correctly; new
test case added to cover conditional functionality.
mvn clean test
Thanks,
Jonathan Hurley
> On Jan. 30, 2015, 10:24 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
> > lines 1232-1257
> > <https://reviews.apache.org/r/30451/diff/1/?file=841753#file841753line1232>
> &g
.
- Jonathan Hurley
On Feb. 2, 2015, 10:55 a.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
pal_name
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py
<https://reviews.apache.org/r/30202/#comment115975>
Does `{params.foo}` work here? The pattern that's used through the codebase
is simply `{foo}`
- Jonathan Hurley
> On Jan. 23, 2015, 9:05 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py,
> > line 84
> > <https://reviews.apache.org/r/30202/diff/2/?file=831417#file831417line84>
> >
> >
> On Feb. 2, 2015, 7:28 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py,
> > line 82
> > <https://reviews.apache.org/r/30202/diff/4/?file=844619#file844619line82>
> >
> >
ind of builder method which will ensure that
`setIgnoreMaintenance(true)` is set.
- Jonathan Hurley
On Feb. 3, 2015, 10 a.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70789
---
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 3, 2015, 1:19 p.m
> On Feb. 3, 2015, 1:42 p.m., Jonathan Hurley wrote:
> > Ship It!
The only issue was the on Nate pointed out with Hive; it should go back into
HIVE and I think we still need the 2 different manual tasks.
- Jonathan
---
T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30567/#review70792
---
Ship it!
Not very i18n friendly :)
- Jonathan Hurley
On Feb. 3
/2.1.0.2.0/package/scripts/namenode_upgrade.py
<https://reviews.apache.org/r/30202/#comment116229>
This is still an issue, no? Should be
`Execute(format("{kinit_path_local} -kt {hdfs_user_keytab}
{hdfs_principal_name}"))`
- Jonathan Hurley
On Feb. 2, 2015, 8:15
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30569/#review70823
---
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 3, 2015, 2:22 p.m
s.apache.org/r/30599/diff/
Testing
---
Some new tests written to cover the cases where there are many stages and many
commands.
mvn clean test
Thanks,
Jonathan Hurley
<https://reviews.apache.org/r/30603/#comment116429>
You're defaulting the client_port to None, but then you use it in the
format; will this not cause problems when generating the string?
- Jonathan Hurley
On Feb. 3, 2015, 9:53 p.m., Alejandr
ummary.py
<https://reviews.apache.org/r/30566/#comment116527>
NodeManager
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanagers_summary.py
<https://reviews.apache.org/r/30566/#comment116528>
All NodeManagers are healt
> On Feb. 4, 2015, 8:27 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/service_check.py,
> > lines 42-43
> > <https://reviews.apache.org/r/30603/diff/1/?file=847234#file847234line42>
> &
Builds are passing again after fixing 10197:
https://builds.apache.org/job/Ambari-trunk-Commit/2111
> On Mar 24, 2015, at 11:45 PM, Jayush Luniya wrote:
>
> Done.
>
> https://issues.apache.org/jira/browse/AMBARI-10197
>
> Thanks
> Jayush
>
>
> On 3/24/15,
- Triggering an alert
- Verifying the target received the alert
Thanks,
Jonathan Hurley
] Total time: 36:37 min
[INFO] Finished at: 2015-03-26T09:18:42-04:00
[INFO] Final Memory: 29M/428M
[INFO]
Thanks,
Jonathan Hurley
Ambari Metrics (ambari-metrics) is a new depedency for Ambari Server. It’s
similar in build to Ambari Views in that it’s part of the source hierarchy, but
you need the JAR built and “installed” in maven.
If you’re building at the top level of Ambari, you should be able to do a “mvn
compile pack
> On March 22, 2015, 8:46 a.m., Jonathan Hurley wrote:
> > Ship It!
Ping. This issue seems to be closed, can we close the review?
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apa
rences
over to findById()
- Jonathan Hurley
On March 26, 2015, 9:23 p.m., Alejandro Fernandez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
d84c449
Diff: https://reviews.apache.org/r/32580/diff/
Testing
---
Built RPM to ensure removing an old log4j.properties won't hurt anything.
Verified the log statements.
Thanks,
Jonathan Hurley
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32580/#review78085
---
On March 27, 2015, 1:32 p.m., Jonathan Hurley wrote:
>
> -
+1
> On Mar 26, 2015, at 4:52 AM, Jayush Luniya wrote:
>
> Hi,
>
> I have created an ambari-2.0.0 release candidate (RC2).
>
> GIT source tag:
> https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=log;h=refs/tags/release-2.0.0-rc2
>
> Staging site: http://people.apache.org/~jluniya/ambari
2557/#comment126774>
This might be a problem since the actual DDL hasn't changed yet (that
happens in Upgrade210). You're using relationship classes that assume the
database structure has already changed.
- Jonathan Hurley
On March 27, 2015, 8:45
clean test
Thanks,
Jonathan Hurley
standing how the differences between OS type and OS
family are stored here; but what happens above if `gsonList =
gson.toJsonTree(repos.get(family));` is used to build the JSON. You're still
only comparing `getOsType()` here. Is that a problem?
- Jonathan Hurley
On March 30, 2015, 7:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32710/#review78566
---
Ship it!
Ship It!
- Jonathan Hurley
On March 31, 2015, 10:22
b134c4
Diff: https://reviews.apache.org/r/32741/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32741/#review78572
---
On April 1, 2015, 3:54 p.m., Jonathan Hurley wrote:
>
> ---
/ambari/server/utils/TestStageUtils.java
8b134c4
Diff: https://reviews.apache.org/r/32741/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
301 - 400 of 2398 matches
Mail list logo
