[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-21 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169624837 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-21 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169624475 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

Re: Ant support for users who use JUnit5

2018-02-18 Thread Jaikiran Pai
On 19/02/18 1:37 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest reading the manual

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 @bodewig, Thank you very much for the review. Based on the review comments, I have updated the PR with additional separate commits (for easier reference). I'll be squashing all these commits together

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168983237 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168983118 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

Ivy release this month?

2018-02-18 Thread Jaikiran Pai
that. There are few PRs open, but except for this one https://github.com/apache/ant-ivy/pull/62 I don't plan to merge the rest given the nature of the changes. There's no release instructions that I could find, so I am not sure what's going to be involved in the actual release process. -Jaikiran

Re: Ant support for users who use JUnit5

2018-02-17 Thread Jaikiran Pai
On 17/02/18 12:51 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest reading the manual

[GitHub] ant issue #62: Use char notation to represent a character to improve perform...

2018-02-16 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/62 Hi @reudismam, Is there some reference documentation which states that this construct performs better? My brief check of the JLS just showed a note which states that some implementations _might_

[GitHub] ant issue #62: Use char notation to represent a character to improve perform...

2018-02-16 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/62 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
I just realized that the manual that I linked in my mail isn't accessible to everyone. So here's an alternative link to the same https://home.apache.org/~jaikiran/temp_workspace/manual/Tasks/junitlauncher.html -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done with the initial

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 Thank for you the PR. This is now merged --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
the regressions that we have found in our latest releases. -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
n memory, during the report writing and will be immediately garbage collected once that's done. Please review the PR - mostly the Ant specific constructs and implementation details. [1] https://github.com/apache/ant/pull/60 [2] https://builds.apache.org/job/Ant-Build-Jaikiran/ws/manual/Tasks/jun

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/60 JUnit 5 support - A new junitlauncher task This is the initial working version of a new `junitlauncher` task that support using JUnit 5 framework for testing, within Ant build files. The commit

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
I forgot to add that, as you note, as a result of the change, the new created path will retain all elements from destPath that aren't in dependClassPath, which is unlike the behaviour before the change. -Jaikiran On 14/02/18 9:59 AM, Jaikiran Pai wrote: Hi Stefan, You are right. The change

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
indeed introduces a different behaviour. [1] https://github.com/jaikiran/ant/commit/f57b9d5fbca6e9648695bc9d37a27000c0b4aff2#diff-585ed59cf64ef6930e5148094adc322aR21 -Jaikiran On 13/02/18 11:20 PM, Stefan Bodewig wrote: Hi all I'm currently reviewing the big change that introduced

Include user mailing list for RC release?

2018-02-09 Thread Jaikiran Pai
the RC, so that issues like these can hopefully be caught before we actually do a release. [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=62086 -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Thanks everyone for the inputs. Based on those, I have now updated the test to not expect a build failure exception and also have updated our release notes to mention this change in behaviour. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Sure Stefan. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm currently running tests on the 1.9.x branch where I fix a bunch a FileNameMapper implementations that wouldn't handle null sourceFileNames (which could happen for resources

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-09 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 @adamretter, this is now merged and we have added your name (Adam Retter) to our contributors list. If you want us to a use different name or not include the name at all, please do let us know

Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
://bz.apache.org/bugzilla/show_bug.cgi?id=39960 [6] https://builds.apache.org/job/Ant-Build-Matrix-1.9.x-Linux/OS=xenial,jdk=JDK%201.5%20(latest)/lastCompletedBuild/testReport/src.tests.antunit.taskdefs/copy-test_xml/testResourceWithoutName/ -Jaikiran

[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...

2018-02-08 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r167136873 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource

[GitHub] ant-ivy issue #68: Why no new Ivy version yet?

2018-02-08 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/68 There will be one soon. There's a discussion going on, in the mailing list to work towards a release soon. --- - To unsubscribe

[GitHub] ant-ivy issue #66: IVY-1545 Detect circular dependencies in POMs

2018-02-08 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/66 @javabrett, thank you reporting as well as providing the fix for this. This is now merged. --- - To unsubscribe, e-mail: dev

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-08 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 Looks good to me. If @bodewig doesn't have any concerns with this change, I'll go ahead and merge this, this week

[GitHub] ant issue #59: Fix NPE in ChainedMapper.

2018-02-08 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/59 Thanks for the PR @jpountz. Can we add you to our contributors file, crediting you for this fix? If yes, what would you like your name to be mentioned

Re: github PR builds

2018-02-08 Thread Jaikiran Pai
On 06/02/18 10:10 PM, Stefan Bodewig wrote: On 2018-02-06, Jaikiran Pai wrote: The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things

Re: Ivy-2.5.0

2018-02-08 Thread Jaikiran Pai
amount of bug fixes that have been done since 2.4.0 and I think we should start looking at what it takes to do the release formalities. -Jaikiran On 09/01/18 12:29 PM, Jaikiran Pai wrote: Hi Jan, My efforts to resolve IVY-1485 have taken longer than I expected, mainly due to not finding enough

Re: Ivy-2.5.0

2018-02-07 Thread Jaikiran Pai
and see if it solves the issue? -Jaikiran On 09/01/18 5:53 PM, Maarten Coene wrote: The change to the URLHandler class (TimoutConstraint) is also backwards incompatible.The IvyIdea plugin (IntelliJ) breaks on this which contains an extension of AbstractURLHandler. I didn't look into it yet

Re: Release Notes for 1.10.2 and 1.9.10

2018-02-06 Thread Jaikiran Pai
Maybe the new task is worth highlighting. But other than that I don't have anything specific. -Jaikiran On 06/02/18 11:18 PM, Stefan Bodewig wrote: Hi all as you can witness in https://svn.apache.org/viewvc/ant/site/ant/sources/antnews.xml?r1=1823368=1823367=1823368 I don't really know

[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...

2018-02-06 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r166282397 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
So it looks like, although I did send a mail about this PR integration a while back[1], I did not include the details about this plugin which was used for the integration. Sorry about that. [1] https://www.mail-archive.com/dev@ant.apache.org/msg46284.html -Jaikiran On 06/02/18 5:12 PM

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
g about github users who belong to the apache organization. P.S: There are a few other keywords that the plugin recognizes and is documented at [1]. [1] https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin -Jaikiran On 06/02/18 4:59 PM, Stefan Bodewig wrote:

[GitHub] ant-ivy issue #65: IVY-1485 Ensure dependency is applicable to all configura...

2018-02-06 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/65 These changes don't solve the real issue. The details of this issue are part of the discussion in ant dev mailing list, where I explained what the real issue is. I do have a completely different

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-06 Thread Jaikiran Pai
Just to be clear, my -1 was meant for both this commit as well as a subsequent commit where some specific jars have been tagged as JPMS modules. I think adding this automatic module names just for the sake of it isn't a good thing. -Jaikiran On 06/02/18 9:38 AM, Jaikiran Pai wrote: I agree

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-05 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 @adamretter The test failure https://builds.apache.org/job/Ant%20Github-PR-Windows/37/testReport/junit/org.apache.tools.ant.taskdefs.optional.junit/XMLResultAggregatorTest/testFrames/ looks related

[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...

2018-02-05 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/58 Overall, IMO, this can't be a general find/replace change and instead needs to be checked for individuals places where the `StringBuffer` is used and whether the change to `StringBuilder` will impact

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183671 --- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java --- @@ -377,7 +377,7 @@ public synchronized void run() { } // now

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183611 --- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java --- @@ -102,7 +102,7 @@ private static final String DEFAULT_MIME_TYPE = "text/

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Jaikiran Pai
I agree. -1. On a related note, I don't think we should be doing any of these commits especially when there's a RC out which we plan to release. IMO, only blocker issues need to be addressed when the RC is out. -Jaikiran On 06/02/18 1:41 AM, Stefan Bodewig wrote: Generate manifest files

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz and installed locally. Setup ANT_HOME to this new version. - Ran some existing projects against this new version - Checked some documentation in the manual. Tested the projects using this version of Ant against both Java 8 and Java 9. -Jaikiran On 03/02/18

Re: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-04 Thread Jaikiran Pai
. Checked the presence of source files. All above tests done on Java 8 setup. -Jaikiran On 03/02/18 10:02 PM, Stefan Bodewig wrote: Hi all I've created a release candidate for 1.9.10: git tag: ANT_1_9_10_RC1 on commit: 528c94e tarballs: https://dist.apache.org/repos/dist/dev/ant

Re: ant-ivy git commit: IVY-1569 Avoid reflection warnings (or worse) in Java 9+

2018-02-04 Thread Jaikiran Pai
I think we should use java.specification.version system property instead which is the recommended one as per the JEP http://openjdk.java.net/jeps/223. We use this property in Ant too to determine the Java version. -Jaikiran - To u

[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/56 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

Re: Cutting new releases?

2018-01-26 Thread Jaikiran Pai
I just remembered - we probably have to investigate that image task test failure on Java 9 and see if its some setup issue or whether that task is genuinely broken against that runtime. I haven't yet found the time to dig deeper on that one. -Jaikiran On Friday, January 26, 2018, Stefan Bodewig

Re: Ant support for users who use JUnit5

2018-01-26 Thread Jaikiran Pai
One minor but important detail - this feature/task will only be available in the 1.10.x releases (whichever release we decide to include this in) and won't be available in 1.9.x releases of Ant. -Jaikiran On 27/01/18 8:40 AM, Jaikiran Pai wrote: Here's an update on where this effort now

Re: Ant support for users who use JUnit5

2018-01-26 Thread Jaikiran Pai
eedback reports) For those of you curious to see what the task usage is going to look like, here's an example[2] build file which shows its many usages. That file will be cleaned up a bit, before I send a PR for review/merge. [1] https://github.com/apache/ant/compare/master...jaikiran:junit5

Re: Cutting new releases?

2018-01-26 Thread Jaikiran Pai
that it can be used for the basic minimal functionality and then keep adding anything more that we want in this task in future releases. More details about this are in the other thread. [1] https://github.com/apache/ant/compare/master...jaikir

Re: [PATCH]

2018-01-24 Thread Jaikiran Pai
are using and the exception stacktrace that you got) and attach the proposed patch there? -Jaikiran On 24/01/18 4:57 PM, Adam Retter wrote: If you previously used the Saxon XSLT Processor within you would get an error as the XSLT stylesheets provided with Ant do not work with Saxon, they in fact

[GitHub] ant issue #55: Use valueOf method instead of constructor since valueOf has h...

2018-01-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/55 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

Re: Java 9 test failures

2018-01-23 Thread Jaikiran Pai
. -Jaikiran On 22/01/18 10:21 AM, Stefan Bodewig wrote: On 2018-01-21, Gintautas Grigelionis wrote: I see three failures in ImageTest testSimpleScale (did not create largeimage.jpg) testSimpleScaleWithMapper (did not create largeimage-scaled.jpg) testOverwriteTrue (negative time) Could

Re: Ant Release Process

2018-01-19 Thread Jaikiran Pai
to add especially since the steps themselves are clear enough and this only just affects the people who do the releases. -Jaikiran On 28/12/17 10:02 PM, Stefan Bodewig wrote: Hi over in https://github.com/apache/ant/pull/54 Gintas is proposing to automate some of the steps needed to cut

Re: Ivy-2.5.0

2018-01-09 Thread Jaikiran Pai
Thanks Maarten, I'll look this. -Jaikiran On 09/01/18 5:53 PM, Maarten Coene wrote: The change to the URLHandler class (TimoutConstraint) is also backwards incompatible.The IvyIdea plugin (IntelliJ) breaks on this which contains an extension of AbstractURLHandler. I didn't look into it yet

[GitHub] ant pull request #52: [master] Fix BZ-58451 BZ-58833

2018-01-03 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/52 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2018-01-03 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 This is now commit to both master and 1.9.x branches https://github.com/apache/ant/commit/6c860e0036a8742f4cc35e3e6a8e595e42804c89

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2018-01-03 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 Thanks Stefan (@bodewig) for the review. The tests (existing and a new one in this PR) are passing on both *nix and Windows. Given that this change does address the issues noted in the referenced

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2017-12-20 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 @bodewig, do you think this change is OK? Any thoughts/concerns? I understand that this is one of the central classes, so don't want to push this if there's any concerns with this change

Re: delete task with a wildcard "file"

2017-12-20 Thread Jaikiran Pai
On 21/12/17 10:42 AM, Stefan Bodewig wrote: On 2017-12-21, Jaikiran Pai wrote: I committed this change below, to use a resource collection to allow the build to pass, which had started failing on Windows, after I did a recent change to the delete task to use Java 7 java.nio.file.Files API

delete task with a wildcard "file"

2017-12-20 Thread Jaikiran Pai
s expected that it should work even with file="*.something" then let me know, I'll undo this change and see how I can fix the regression. -Jaikiran On 21/12/17 10:21 AM, jaiki...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 1a2c33fd0 -> ca91b859f Fix a

Re: [GitHub] ant pull request #:

2017-12-20 Thread Jaikiran Pai
No specific reason, just that I'm more used to using the javadoc variant of @deprecated since it allows explaining what's deprecated and why. I have now added the @Deprecated annotation too and pushed a commit. -Jaikiran On 20/12/17 11:08 PM, twogee wrote: Github user twogee commented

Re: ant git commit: disable a bunch of caches, just so we've tried that as well

2017-12-19 Thread Jaikiran Pai
On 19/12/17 5:13 PM, Jaikiran Pai wrote: Looking at the JDK code, I still am not sure which exact code path triggers this stale/invalid cache in this specific case, but apparently it does. Now that we know the canonical path cache is playing a role, I think the only way this issue makes

Re: ant git commit: disable a bunch of caches, just so we've tried that as well

2017-12-19 Thread Jaikiran Pai
[exec] [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.276 sec -Jaikiran On 19/12/17 5:02 PM, bode...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master c2c821a38 -> 3dad11d41 disable a bunch of caches, just so we've tried that as w

Re: ant git commit: logs say "link has been created", is it a timing issue?

2017-12-19 Thread Jaikiran Pai
which check that file1 exists. Furthermore, given that this is manifesting for all the links in that properties file, it looks a very generic issue and not just to this specific "link1" symlink. To make it much more weird, if I run this exact same state of "master" branch, by jus

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2017-12-16 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 Have updated the PR to fix the test case so that it runs the correct command on Windows, during the tests. --- - To unsubscribe, e

[GitHub] ant pull request #52: [master] Fix BZ-58451 BZ-58833

2017-12-16 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/52 [master] Fix BZ-58451 BZ-58833 The commit here fixes the issues reported in: https://bz.apache.org/bugzilla/show_bug.cgi?id=58833 https://bz.apache.org/bugzilla/show_bug.cgi?id=58451

Re: Ant support for users who use JUnit5

2017-12-15 Thread Jaikiran Pai
Thank you. I'm moving ahead with the new proposed task. Hopefully I should be able to have something functional in a few days. -Jaikiran On 14/12/17 5:14 PM, Stefan Bodewig wrote: On 2017-12-14, Jaikiran Pai wrote: With that context, I would like to explain what I have attempted so far

Re: Ant support for users who use JUnit5

2017-12-14 Thread Jaikiran Pai
by changing the internal implementation detail of this task (and maybe removing support for certain attributes). Either way, I would still like to hear others thoughts on this. -Jaikiran On 14/12/17 3:39 PM, Jaikiran Pai wrote: I've started some experiments in adding support for the recently

Ant support for users who use JUnit5

2017-12-14 Thread Jaikiran Pai
  [1] http://junit.org/junit5/ [2] https://bz.apache.org/bugzilla/show_bug.cgi?id=61796 [3] https://github.com/jaikiran/ant/commit/42c7f221a8cd0848df0a2d6cac2897c07d446bda -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...

Re: Build failed in Jenkins: Ant-Build-Matrix-1.9.x-Linux » JDK 1.6 (latest) #134

2017-12-13 Thread Jaikiran Pai
It's back to normal [1], so the crash seems to be specific to certain nodes on Jenkins, for Java 6. I don't plan to look more into this. [1] https://builds.apache.org/job/Ant-Build-Matrix-1.9.x-Linux/jdk=JDK%201.6%20(latest)/135/ -Jaikiran On 13/12/17 8:40 PM, Jaikiran Pai wrote: So we

Re: Github ant repo now integrated with Jenkins for pull request testing

2017-12-13 Thread Jaikiran Pai
On 12/12/17 8:05 PM, Jaikiran Pai wrote: The next few days, I'll probably try and see if I can get a Linux based job to run alongside this Windows job for PRs. We now have a Linux one too for the PRs https://builds.apache.org/job/Ant%20Github-PR-Linux/. It has the same characteristics

Re: Build failed in Jenkins: Ant-Build-Matrix-1.9.x-Linux » JDK 1.6 (latest) #134

2017-12-13 Thread Jaikiran Pai
most likely _not_ a coincidence. But given this a JVM crash (in Java 6), it most likely is a JVM issue. I'll see if I can find something on this, before we decide if at all we need to rollback that commit. [1] https://github.com/apache/ant/commit/0fd2a86369aab41db316b1064a559bae08afae0f -Jaikiran

[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 Thanks for reviewing. Merged to master branch. Will backport it to 1.9.x too. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 >> an alternative would be to only wrap the stream inside of zipFile if mark wasn't supported. @bodewig, I actually liked your idea. So I did an additional change in this commit (PR ha

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-12 Thread Jaikiran Pai
Do let me know if there's anything I can do to help investigate this. I'm curious myself to see what's causing this. -Jaikiran On 13/12/17 2:56 AM, Stefan Bodewig wrote: On 2017-12-12, Stefan Bodewig wrote: On 2017-12-12, Jaikiran Pai wrote: So the one final test that's still failing

Re: Please ignore the github emails for the next hour or so

2017-12-12 Thread Jaikiran Pai
My experiments have completed [1] and any new mails from github/jenkins jobs are genuine mails. Hopefully, the next time I try something around this, it won't take these many spurious mails. [1] https://www.mail-archive.com/dev@ant.apache.org/msg46284.html -Jaikiran On 12/12/17 7:05 PM

Github ant repo now integrated with Jenkins for pull request testing

2017-12-12 Thread Jaikiran Pai
/ -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

Please ignore the github emails for the next hour or so

2017-12-12 Thread Jaikiran Pai
Sorry about the continuous mails from github/ant repo. I'm (yet again) trying to get the Jenkins job integrated with Ant github repo. I don't have a way to disable these mails while I experiment with it to get it right. Hopefully, it should be sorted out in the next hour or so. -Jaikiran

[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying

[GitHub] ant pull request #38: Do not merge

2017-12-12 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/38 Do not merge Testing Jenkins integration. Do not merge this PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant dummy Alternatively

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying `InputStream

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-12 Thread Jaikiran Pai
/org.apache.tools.ant.taskdefs.optional.unix/SymlinkTest/testRecreate/ -Jaikiran On 10/12/17 3:13 PM, Stefan Bodewig wrote: On 2017-12-10, Stefan Bodewig wrote: testCreateDoubleHanging is related to https://bz.apache.org/bugzilla/show_bug.cgi?id=38199 judging from the history. Here the link points to a non-existent file

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-11 Thread Jaikiran Pai
. Done. The documentation of symlink task is now updated https://github.com/apache/ant/commit/485b92fe7494c5473e019329cbf7a33e556acad6 -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-11 Thread Jaikiran Pai
of changes, I am willing to undo them and go back to the original state that was before I started these changes. [1] https://github.com/apache/ant/commit/b3c7d5dc451960986a94d24785a2c1d24b0b0d6a -Jaikiran On 10/12/17 5:15 PM, Stefan Bodewig wrote: [@Steve I'm trying to drag you

Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-10 Thread Jaikiran Pai
On 10/12/17 3:09 PM, Stefan Bodewig wrote: On 2017-12-10, Jaikiran Pai wrote: I'll investigate why this is failing (local tests pass for me) and fix it. Target testCreateOverFile in the antunit test explicitly tries to replace a file with a link, doing exactly what the bugzilla report says

<    1   2   3   4   5   6   7   8   >