[jira] [Commented] (ATLAS-1555) Move classification endpoint from Entities API to Entity API and remove Entities API

2017-02-14 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865399#comment-15865399 ] Madhan Neethiraj commented on ATLAS-1555: - +1 for the patch. Thanks [~svimal

[jira] [Commented] (ATLAS-1548) Create entity : Change PUT and POST object structure based on new API Changes

2017-02-14 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865383#comment-15865383 ] Madhan Neethiraj commented on ATLAS-1548: - +1 for the patch. Thanks [~kevalb

Re: Review Request 56535: Add tests for DeleteHandlerV1

2017-02-13 Thread Madhan Neethiraj
raph/v1/DeleteHandlerV1.java (line 412) <https://reviews.apache.org/r/56535/#comment237324> AtlasType attrType = attributeInfo.getTypeName(); - Madhan Neethiraj On Feb. 14, 2017, 5:33 a.m., Suma Shivaprasad wrote: > > ---

Re: Review Request 56535: Add tests for DeleteHandlerV1

2017-02-13 Thread Madhan Neethiraj
sion. This constraint does not look right no Manager.subordinates. - Madhan Neethiraj On Feb. 14, 2017, 5:33 a.m., Suma Shivaprasad wrote: > > --- > This is an automatically generated e-mail.

[jira] [Commented] (ATLAS-1522) Entity V2 API changes to accept only AtlasObjectId for child references

2017-02-13 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865145#comment-15865145 ] Madhan Neethiraj commented on ATLAS-1522: - Committed to master: - http:/

[jira] [Updated] (ATLAS-1522) Entity V2 API changes to accept only AtlasObjectId for child references

2017-02-13 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1522: Affects Version/s: 0.8-incubating Request participants: (was: ) Fix

[jira] [Updated] (ATLAS-1522) Entity V2 API changes to accept only AtlasObjectId for child references

2017-02-13 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1522: Attachment: ATLAS-1522.5.patch Review board URL: https://reviews.apache.org/r/56634

Review Request 56634: ATLAS-1522: entity typed attributes (like hive_table.sd, hive_table.columns) should use AtlasObjectId as value instead of entire entity contents

2017-02-13 Thread Madhan Neethiraj
/AtlasFormatConverters.java 7c3f536 webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java e87956f Diff: https://reviews.apache.org/r/56634/diff/ Testing --- Verified that all unit tests pass Thanks, Madhan Neethiraj

[jira] [Commented] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-13 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864686#comment-15864686 ] Madhan Neethiraj commented on ATLAS-1546: - [~gss2002] - thanks for investiga

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

2017-02-13 Thread Madhan Neethiraj
Diff: https://reviews.apache.org/r/56585/diff/ Testing --- all unit tests pass Thanks, Madhan Neethiraj

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

2017-02-13 Thread Madhan Neethiraj
nclude the deleted edges as well. - Madhan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56585/#review165375 ------- On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj wrote: > > --

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

2017-02-13 Thread Madhan Neethiraj
enerated e-mail. To reply, visit: https://reviews.apache.org/r/56585/#review165370 --- On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj wrote: > > --- > This is an automati

[jira] [Commented] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-13 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863932#comment-15863932 ] Madhan Neethiraj commented on ATLAS-1546: - bq. I tried running HiveServer2

[jira] [Commented] (ATLAS-1436) Atlas Metrics endpoint

2017-02-13 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863311#comment-15863311 ] Madhan Neethiraj commented on ATLAS-1436: - Committed to master: - http://git

[jira] [Updated] (ATLAS-1436) Atlas Metrics endpoint

2017-02-13 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1436: Attachment: ATLAS-1436.v3.patch Patch from [~apoorvnaik] is attached. > Atlas Metr

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

2017-02-12 Thread Madhan Neethiraj
64593b7 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 9f03718 Diff: https://reviews.apache.org/r/56585/diff/ Testing --- all unit tests pass Thanks, Madhan Neethiraj

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

2017-02-12 Thread Madhan Neethiraj
64593b7 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 9f03718 Diff: https://reviews.apache.org/r/56585/diff/ Testing --- all unit tests pass Thanks, Madhan Neethiraj

[jira] [Updated] (ATLAS-1544) Implement REST endpoint for entity Create/Update using AtlasEntitiesWithExtInfo

2017-02-12 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1544: Attachment: ATLAS-1544.5.patch Review board URL: https://reviews.apache.org/r/56585

Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

2017-02-12 Thread Madhan Neethiraj
/test/java/org/apache/atlas/web/adapters/TestEntityREST.java fd110cd webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 9f03718 Diff: https://reviews.apache.org/r/56585/diff/ Testing --- all unit tests pass Thanks, Madhan Neethiraj

[jira] [Assigned] (ATLAS-1544) Implement REST endpoint for entity Create/Update using AtlasEntitiesWithExtInfo

2017-02-12 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj reassigned ATLAS-1544: --- Assignee: Madhan Neethiraj (was: Sarath Subramanian) > Implement REST endpoint

Re: Review Request 56463: ATLAS-1539 Attempt to load policy store and user credential files as classloader resource if configured file path does not exist, in the same manner that the atlas-applicatio

2017-02-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56463/#review165271 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 12, 2017, 7:48

Re: Review Request 56463: ATLAS-1539 Attempt to load policy store and user credential files as classloader resource if configured file path does not exist, in the same manner that the atlas-applicatio

2017-02-12 Thread Madhan Neethiraj
erDao.loadFileLoginsDetails() as well. - Madhan Neethiraj On Feb. 12, 2017, 5:47 p.m., David Kantor wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

[jira] [Commented] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862223#comment-15862223 ] Madhan Neethiraj commented on ATLAS-1546: - [~gss2002] - by any chance was k

[jira] [Updated] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1546: Attachment: ATLAS-1546.1.patch > Hive hook should choose appropriate JAAS config if h

[jira] [Commented] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862155#comment-15862155 ] Madhan Neethiraj commented on ATLAS-1546: - {quote} {noformat} { KafkaCl

[jira] [Commented] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862077#comment-15862077 ] Madhan Neethiraj commented on ATLAS-1546: - [~gss2002] - can you enable debu

[jira] [Commented] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862014#comment-15862014 ] Madhan Neethiraj commented on ATLAS-1546: - [~gss2002] doAs=true - you are tr

[jira] [Commented] (ATLAS-1549) Remove unwanted API call for Lineage

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861970#comment-15861970 ] Madhan Neethiraj commented on ATLAS-1549: - 1+ for the patch. > Remove u

Re: Review Request 47658: ATLAS-499: Update reverse references

2017-02-10 Thread Madhan Neethiraj
e.columns needs to be updated. Perhaps this is already handled in the current implementation. If so, please ignore this comment. - Madhan Neethiraj On June 17, 2016, 2:44 a.m., David Kantor wrote: > > --- > This is an auto

[jira] [Commented] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861733#comment-15861733 ] Madhan Neethiraj commented on ATLAS-1546: - +1 for the patch. [~gss2002] -

Re: Review Request 56543: ATLAS-1546 : Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-10 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56543/#review165151 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 10, 2017, 2:26

[jira] [Commented] (ATLAS-1532) Audit API reponse details attribute is in incorrect JSON format

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861716#comment-15861716 ] Madhan Neethiraj commented on ATLAS-1532: - [~kevalbhatt] - the JSON in 

[jira] [Resolved] (ATLAS-1441) Release 0.7.1-incubating release

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj resolved ATLAS-1441. - Resolution: Fixed Fix Version/s: 0.7.1-incubating Apache Atlas 0.7.1 (incubating

[jira] [Commented] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861708#comment-15861708 ] Madhan Neethiraj commented on ATLAS-1526: - [~dkantor] - the patch was commi

[jira] [Updated] (ATLAS-1550) Build failure in testDuplicateTypenames

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1550: Attachment: ATLAS-1550.patch Review board URL: https://reviews.apache.org/r/56553/ > Bu

Review Request 56553: ATLAS-1550: for unit test failure in TypeSystemTest.testDuplicateTypenames()

2017-02-10 Thread Madhan Neethiraj
/TypeSystem.java 119a8d5 typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 175ba7e Diff: https://reviews.apache.org/r/56553/diff/ Testing --- verified that unit tests pass Thanks, Madhan Neethiraj

[jira] [Commented] (ATLAS-1550) Build failure in testDuplicateTypenames

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861544#comment-15861544 ] Madhan Neethiraj commented on ATLAS-1550: - [~jonesn] - yes, this was cause

[jira] [Assigned] (ATLAS-1550) Build failure in testDuplicateTypenames

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj reassigned ATLAS-1550: --- Assignee: Madhan Neethiraj > Build failure in testDuplicateTypena

[jira] [Commented] (ATLAS-1545) UI to make common REST call for classificationdef and entitydef.

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860979#comment-15860979 ] Madhan Neethiraj commented on ATLAS-1545: - +1 for the patch. Thanks [~kevalb

[jira] [Commented] (ATLAS-1524) Improvements on Create / Edit Entity UI

2017-02-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860978#comment-15860978 ] Madhan Neethiraj commented on ATLAS-1524: - +1 for the patch. > Improvem

[jira] [Created] (ATLAS-1546) Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache

2017-02-09 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1546: --- Summary: Hive hook should choose appropriate JAAS config if host uses kerberos ticket-cache Key: ATLAS-1546 URL: https://issues.apache.org/jira/browse/ATLAS-1546

Re: Review Request 56471: ATLAS-1534: TypesREST clean up for simpler REST interface

2017-02-09 Thread Madhan Neethiraj
/web/rest/TypesREST.java (line 230) <https://reviews.apache.org/r/56471/#comment236907> "getBaseTypedefByName" ==> "getTypedefByName" "getBaseTypedefByGuid" ==> "getTypedefByGuid" - Madhan Neethi

Re: Review Request 56518: Export REST API

2017-02-09 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56518/#review165053 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 10, 2017, 2:19

Re: Review Request 56518: Export REST API

2017-02-09 Thread Madhan Neethiraj
le. webapp/src/main/java/org/apache/atlas/web/resources/ZipSink.java (line 78) <https://reviews.apache.org/r/56518/#comment236877> Consider renaming dispose() with close() - as byteArrayOutputStream is accessed after this call, to write the contents to the stream. - Madh

Re: Review Request 56471: ATLAS-1534: TypesREST clean up for simpler REST interface

2017-02-09 Thread Madhan Neethiraj
r reads - it will be more efficient than reading from typeDefStore. - Madhan Neethiraj On Feb. 9, 2017, 5:03 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

[jira] [Commented] (ATLAS-1542) Atlas server fails to start if duplicate types are found during Typesystem bootstrap

2017-02-09 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859856#comment-15859856 ] Madhan Neethiraj commented on ATLAS-1542: - +1 for the patch. Please consider

[jira] [Comment Edited] (ATLAS-1542) Atlas server fails to start if duplicate types are found during Typesystem bootstrap

2017-02-09 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859856#comment-15859856 ] Madhan Neethiraj edited comment on ATLAS-1542 at 2/9/17 5:3

[jira] [Commented] (ATLAS-1542) Atlas server fails to start if duplicate types are found during Typesystem bootstrap

2017-02-09 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859828#comment-15859828 ] Madhan Neethiraj commented on ATLAS-1542: - [~ayubkhan] ATLAS-1472 is for

Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef constraints and brought back legacy flags isComposite/reverseAttributeName using constraints owner/inverseRef(attribute=attr1)

2017-02-08 Thread Madhan Neethiraj
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56380/#review164598 --- On Feb. 7, 2017, 10:55 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated

[jira] [Updated] (ATLAS-1541) Update GraphEntityMapper to support entity retrieval from a vertex

2017-02-08 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1541: Attachment: ATLAS-1541.patch Review board URL: https://reviews.apache.org/r/56464

Review Request 56464: ATLAS-1541: updated EntityGraphRetriever with methods to retrieve an entity from the given vertex

2017-02-08 Thread Madhan Neethiraj
/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java a0d8940 repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 197e46a Diff: https://reviews.apache.org/r/56464/diff/ Testing --- - verified that unit tests succeed Thanks, Madhan

[jira] [Assigned] (ATLAS-1541) Update GraphEntityMapper to support entity retrieval from a vertex

2017-02-08 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj reassigned ATLAS-1541: --- Assignee: Madhan Neethiraj > Update GraphEntityMapper to support entity retrie

[jira] [Created] (ATLAS-1541) Update GraphEntityMapper to support entity retrieval from a vertex

2017-02-08 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1541: --- Summary: Update GraphEntityMapper to support entity retrieval from a vertex Key: ATLAS-1541 URL: https://issues.apache.org/jira/browse/ATLAS-1541 Project

Re: Review Request 56455: ATLAS-1540: fixed unit test failures in TestEntityREST

2017-02-08 Thread Madhan Neethiraj
/TestEntityREST.java (line 164) <https://reviews.apache.org/r/56455/#comment236497> This test does not change this.dbEntity; hence didn't call createTestEntity() - which might impact other tests. - Madhan Neethiraj On Feb. 8, 2017, 6:16 p.m., Madhan Neet

Review Request 56455: ATLAS-1540: fixed unit test failures in TestEntityREST

2017-02-08 Thread Madhan Neethiraj
://reviews.apache.org/r/56455/diff/ Testing --- - verified that the unit tests pass successfully Thanks, Madhan Neethiraj

[jira] [Updated] (ATLAS-1540) Unit test failure in TestEntityREST - NPE

2017-02-08 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1540: Attachment: ATLAS-1540.patch > Unit test failure in TestEntityREST -

[jira] [Created] (ATLAS-1540) Unit test failure in TestEntityREST - NPE

2017-02-08 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1540: --- Summary: Unit test failure in TestEntityREST - NPE Key: ATLAS-1540 URL: https://issues.apache.org/jira/browse/ATLAS-1540 Project: Atlas Issue Type

[jira] [Commented] (ATLAS-1521) Update UI to eliminate REST calls to obtain schema data

2017-02-07 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857559#comment-15857559 ] Madhan Neethiraj commented on ATLAS-1521: - +1 for ATLAS-1512.2.patch - w

Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid and unique attributes in V2 Entity API using AtlasObjectID

2017-02-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56260/#review164626 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 8, 2017, 3:40

[jira] [Updated] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-07 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1526: Attachment: ATLAS-1526.4.patch Patch after merge with latest master and updates to address

Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef constraints and brought back legacy flags isComposite/reverseAttributeName using constraints owner/inverseRef(attribute=attr1)

2017-02-07 Thread Madhan Neethiraj
existing unit tests pass Thanks, Madhan Neethiraj

Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef constraints and brought back legacy flags isComposite/reverseAttributeName using constraints owner/inverseRef(attribute=attr1)

2017-02-07 Thread Madhan Neethiraj
thod, to avoid code duplicate. I will address this in the next patch update. - Madhan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56380/#review164492 ---------

[jira] [Commented] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-07 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856460#comment-15856460 ] Madhan Neethiraj commented on ATLAS-1526: - [~jnhagelb] - sure. I was abl

[jira] [Updated] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-07 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1526: Attachment: ATLAS-1526.3.patch Review board URL for the patch: https://reviews.apache.org/r

Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef constraints and brought back legacy flags isComposite/reverseAttributeName using constraints owner/inverseRef(attribute=attr1)

2017-02-07 Thread Madhan Neethiraj
xamples/QuickStartV2.java 1559eb9 webapp/src/main/java/org/apache/atlas/util/RestUtils.java cecf636 Diff: https://reviews.apache.org/r/56380/diff/ Testing --- updated unit tests and verified that existing unit tests pass Thanks, Madhan Neethiraj

[jira] [Reopened] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-07 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj reopened ATLAS-1526: - > update AtlasAttribute with methods to derive legacy flags > isComposite/reverseAtt

[jira] [Commented] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-06 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855304#comment-15855304 ] Madhan Neethiraj commented on ATLAS-1526: - [~jnhagelb] - thanks for the det

[jira] [Commented] (ATLAS-1528) reverseReferenceName lost during type conversion

2017-02-06 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854478#comment-15854478 ] Madhan Neethiraj commented on ATLAS-1528: - [~jnhagelb] T

[jira] [Updated] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-06 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1526: Attachment: Atlas-legacy-to-new-ModelMapping.pdf Adding details of mapping between

Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid and unique attributes in V2 Entity API using AtlasObjectID

2017-02-05 Thread Madhan Neethiraj
atest master? addons/models/0030-hive_model.json (line 216) <https://reviews.apache.org/r/56260/#comment236011> "typeName": "hive_storagedesc" ==> "typeName": "." - this doesn't look right. please review. - Madhan Neeth

Re: Review Request 56312: ATLAS-1526: updated AtlasAttribute with helper methods to derive isComposite/reverseAttribute flags

2017-02-05 Thread Madhan Neethiraj
/AtlasStructFormatConverter.java f486cda webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java c45096f Diff: https://reviews.apache.org/r/56312/diff/ Testing --- unit tests pass successfully Thanks, Madhan Neethiraj

[jira] [Updated] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-04 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1526: Attachment: ATLAS-1526.patch Patch is available at the review board here: https

Review Request 56312: ATLAS-1526: updated AtlasAttribute with helper methods to derive isComposite/reverseAttribute flags

2017-02-04 Thread Madhan Neethiraj
/AtlasStructFormatConverter.java f486cda webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java c45096f Diff: https://reviews.apache.org/r/56312/diff/ Testing --- unit tests pass successfully Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute

2017-02-04 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1526: --- Summary: update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute Key: ATLAS-1526 URL: https://issues.apache.org/jira/browse/ATLAS-1526

[jira] [Updated] (ATLAS-1522) Entity V2 API changes to accept only AtlasObjectId for child references

2017-02-03 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1522: Attachment: ATLAS-1522.4.patch [~suma.shivaprasad] - attached patch has few improvements in

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

2017-02-03 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56206/#review164209 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 4, 2017, 12:09

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

2017-02-03 Thread Madhan Neethiraj
olver.java (line 129) <https://reviews.apache.org/r/56206/#comment235686> if vertex is not found by typeName, shouldn't we search for vertices that have typeName as a superType? - Madhan Neethiraj On Feb. 3, 2017, 7:26 a.m., Suma Shivaprasad wrote: > > -

Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid and unique attributes in V2 Entity API using AtlasObjectID

2017-02-02 Thread Madhan Neethiraj
te. webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java (line 163) <https://reviews.apache.org/r/56260/#comment235637> "typeName" should be pathParam. Similar to getByUniqueAttribute(). It will be useful to be able specify multiple at

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

2017-02-02 Thread Madhan Neethiraj
/UniqAttrBasedEntityResolver.java (line 144) <https://reviews.apache.org/r/56206/#comment235617> Instead of iterating on all attributes, it might be quicker to iterate on entityId.getUniqueAttributes(). - Madhan Neethiraj

[jira] [Created] (ATLAS-1521) Update UI to eliminate REST calls to obtain schema data

2017-02-01 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1521: --- Summary: Update UI to eliminate REST calls to obtain schema data Key: ATLAS-1521 URL: https://issues.apache.org/jira/browse/ATLAS-1521 Project: Atlas

Apache Atlas 0.8 (incubating) release preparations

2017-02-01 Thread Madhan Neethiraj
Atlas team, It has been about 7 months since we released Apache Atlas 0.7 (incubating) version. We added several features/fixes in master branch during this time, including: 1. a new REST API with structured/well-defined input and output data structures. This would make it easier for app

[jira] [Commented] (ATLAS-1517) Update hive_model to include schema related attributes

2017-02-01 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849347#comment-15849347 ] Madhan Neethiraj commented on ATLAS-1517: - +1 for the patch > Update hiv

UT failure: caused by guava version update in ATLAS-1369?

2017-02-01 Thread Madhan Neethiraj
Jeff, I notice failure in following unit tests, which are most likely caused by change to guava version (from 18.0 => 19.0) in ATLAS-1369. Can you please look into this and address this failure? Thanks, Madhan Failed tests: HBaseBasedAuditRepositoryTest.setup:40 ยป Runtime Master not initiali

Re: [5/5] incubator-atlas git commit: ATLAS-1369 - Optimize gremlin queries generated by DSL translator

2017-02-01 Thread Madhan Neethiraj
Jeff, Does this patch require JDK8? Compiling with JDK7 fails with the failures like: [ERROR] /Users/mneethiraj/Apache/git/incubator-atlas/repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpressionFinder.java:20: error: package java.util.function does not exist [ERROR] import

[jira] [Commented] (ATLAS-1509) Fix issues with deletion of edges, owned vertices during update

2017-02-01 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848975#comment-15848975 ] Madhan Neethiraj commented on ATLAS-1509: - Patch committed to master: http:/

[jira] [Commented] (ATLAS-1509) Fix issues with deletion of edges, owned vertices during update

2017-02-01 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848974#comment-15848974 ] Madhan Neethiraj commented on ATLAS-1509: - Patch is available at the review b

Re: Review Request 56113: Fixed issues with deletion during updates

2017-02-01 Thread Madhan Neethiraj
. I will commit this patch shortly. Thanks! - Madhan Neethiraj On Feb. 1, 2017, midnight, Suma Shivaprasad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

[jira] [Commented] (ATLAS-1516) fix unit test failure in DefaultMetadataServiceTest.testSpecialCharacters

2017-02-01 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848829#comment-15848829 ] Madhan Neethiraj commented on ATLAS-1516: - Committed to master: http://git

Review Request 56182: ATLAS-1516: fix unit test failure in DefaultMetadataServiceTest.testSpecialCharacters()

2017-02-01 Thread Madhan Neethiraj
/DefaultMetadataServiceTest.java aa1cdaa typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 401df5f Diff: https://reviews.apache.org/r/56182/diff/ Testing --- - ran the updated unit test a number of times and verified that it passes Thanks, Madhan Neethiraj

[jira] [Updated] (ATLAS-1516) fix unit test failure in DefaultMetadataServiceTest.testSpecialCharacters

2017-02-01 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1516: Attachment: ATLAS-1516.patch Patch is available at the review board here: https

[jira] [Created] (ATLAS-1516) fix unit test failure in DefaultMetadataServiceTest.testSpecialCharacters

2017-02-01 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1516: --- Summary: fix unit test failure in DefaultMetadataServiceTest.testSpecialCharacters Key: ATLAS-1516 URL: https://issues.apache.org/jira/browse/ATLAS-1516

[jira] [Commented] (ATLAS-1513) Update AtlasEntityType with a method to get foreign-key references

2017-02-01 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848223#comment-15848223 ] Madhan Neethiraj commented on ATLAS-1513: - Patch is available in the review b

[jira] [Updated] (ATLAS-1513) Update AtlasEntityType with a method to get foreign-key references

2017-02-01 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1513: Attachment: ATLAS-1513.patch > Update AtlasEntityType with a method to get foreign-

Review Request 56161: ATLAS-1513: updated AtlasEntityType with methods to get foreignKey references to a type; added helper methods in AtlasAttribute

2017-02-01 Thread Madhan Neethiraj
://reviews.apache.org/r/56161/diff/ Testing --- - added unit tests - performed sanity tests with Atlas web application, like: - hive notification processing - search - lineage - delete entities Thanks, Madhan Neethiraj

[jira] [Commented] (ATLAS-1502) UI to create/update entities - configuration to restrict entity-types editable via UI

2017-01-31 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847892#comment-15847892 ] Madhan Neethiraj commented on ATLAS-1502: - patch committed to master: http:/

[jira] [Created] (ATLAS-1513) Update AtlasEntityType with a method to get foreign-key references

2017-01-31 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1513: --- Summary: Update AtlasEntityType with a method to get foreign-key references Key: ATLAS-1513 URL: https://issues.apache.org/jira/browse/ATLAS-1513 Project

[jira] (ATLAS-1502) UI to create/update entities - configuration to restrict entity-types editable via UI

2017-01-31 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847453#comment-15847453 ] Madhan Neethiraj commented on ATLAS-1502: - Property

Re: Review Request 56119: ATLAS-1502 : UI to create/update entities - configuration to restrict entity-types editable via UI

2017-01-31 Thread Madhan Neethiraj
#comment235172> If the list has only one entry, UI does not enable entity create/edit. Please review the following and update: "entityTypeList.length > 1" ==> "entityTypeList.length > 0" - Madhan

Re: Review Request 56113: Fixed issues with deletion during updates

2017-01-30 Thread Madhan Neethiraj
/v1/AtlasEntityStoreV1Test.java (line 591) <https://reviews.apache.org/r/56113/#comment235110> (actualList != null || ((actualList != null && actualList.size() > 0)) ==> CollectionUtils.isNotEmpty(actualList) - Madhan Neethiraj On Jan. 31, 2017, 6:47 a.m., Su

Re: Loops in V2 API

2017-01-30 Thread Madhan Neethiraj
ng Professor, Department of Computer Science, University of Sheffield Email: mandy_chess...@uk.ibm.com LinkedIn: http://www.linkedin.com/pub/mandy-chessell/22/897/a49 Assistant: Janet Brooks - jsbrook...@uk.ibm.com

<    1   2   3   4   5   6   7   8   9   10   >