Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/310#discussion_r166417032
--- Diff: build.gradle ---
@@ -425,6 +425,24 @@ task "bigtop-slaves"(type:Exec,
commandLine command
}
+task "docker-pac
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/325
Ah, got it. Cool, thanks for fixing this! LGTM!
---
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/328
Thanks for the contribution!
Could you please make sure that the name of the PR is matching the synopsis
of the JIRA ticket so all updates from here can be automatically propagated to
the Apache
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/325
Wow, quite a bit of work has gone into this one! On one side, I am bit
worries about the number of the patches for an upstream project. On the other
hand, perhaps Hive isn't yet ready to work
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/310#discussion_r157172119
--- Diff: build.gradle ---
@@ -425,6 +425,24 @@ task "bigtop-slaves"(type:Exec,
commandLine command
}
+task "docker-pac
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/300
BTW, the synopsis of the PR (and the commit ticket) **should** be the same
as the JIRA ticket, because the latter is The Source of truth.
I have fixed it in this particular case, but please take
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/300
While it looks like a good solution in the interim, could we open an
upstream ticket for the Ignite to fix this issue?
```sed -i '/asm-all/{n;s/4.2/5.0.2/}' modules/hadoop/pom.xml```
---
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/310#discussion_r154011483
--- Diff: build.gradle ---
@@ -425,6 +425,24 @@ task "bigtop-slaves"(type:Exec,
commandLine command
}
+task "docker-pac
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/310#discussion_r153704226
--- Diff: build.gradle ---
@@ -425,6 +425,24 @@ task "bigtop-slaves"(type:Exec,
commandLine command
}
+task "docker-pac
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/310#discussion_r153702692
--- Diff: build.gradle ---
@@ -425,6 +425,24 @@ task "bigtop-slaves"(type:Exec,
commandLine command
}
+task "docker-pac
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/266
I am looking at the diff and I see a few issue with it.
First, it adds two new file to the top level directory of the bigtop
(TestMethods.java, HiveJdbcGeneralTest.java) - I don't think
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/266
Ah, I see. You can do what Olaf recommended. Alternatively, you can copy
correct file into your workspace and then amend your existing commit.
```
% git co origin/master -- build.gradle
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/266
Not sure what are you asking... Are you saying the patch doesn't apply
anymore? If so, you need to rebase and resolve the conflicts between the
current HEAD and your local copy.
---
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/304
+1
Would be great to have automatic RAT check!
---
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/283#discussion_r146066242
--- Diff: bigtop-packages/src/common/pig/patch1-PIG-4676.diff ---
@@ -1,93 +0,0 @@
-diff -ur pig-0.15.0-src_/ivy/libraries.properties
pig-0.15.0-src/ivy
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/283#discussion_r146063765
--- Diff: bigtop.bom ---
@@ -165,7 +165,7 @@ bigtop {
'hbase' {
name= 'hbase'
relNotes = 'Apache HBase'
- version
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/283#discussion_r146065850
--- Diff:
bigtop-packages/src/common/hbase/patch2-0002-Backport-HBASE-17893-to-1.3.diff
---
@@ -0,0 +1,278 @@
+From
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/283#discussion_r146066137
--- Diff:
bigtop-packages/src/common/pig/patch0-PIG-5304-Fix-build-issue-with-Hadoop-2.8.diff
---
@@ -0,0 +1,30 @@
+From
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/283#discussion_r146065450
--- Diff: bigtop.bom ---
@@ -177,7 +177,7 @@ bigtop {
name= 'pig'
pkg = 'pig'
relNotes = 'Apache Pig'
- version
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/283#discussion_r146065760
--- Diff:
bigtop-packages/src/common/hbase/patch1-0001-Partial-backport-HBASE-16712-to-1.3.1.diff
---
@@ -0,0 +1,60 @@
+From
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/283#discussion_r146066348
--- Diff: bigtop-packages/src/common/pig/patch2-PIG-4728.diff ---
@@ -1,36 +0,0 @@
-diff --git a/ivy.xml b/ivy.xml
--- End diff --
Being removed
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/273
I have pushed the fix in, thanks! Please close this PR manually - as I have
skipped the magic words in the commit message ;)
---
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/273
Hello. Any comments on the passing of the tests with this new version of
the patch? Thanks!
---
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/282#discussion_r137376595
--- Diff: packages.gradle ---
@@ -185,7 +185,7 @@ def genTasks = { target ->
def final GIT_USER_NAME = config.bigtop.components[target].git.u
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/273
+1 assuming the tests are working now (I haven't tested it myself though)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/273#discussion_r131966194
--- Diff: bigtop-tests/smoke-tests/hbase/build.gradle ---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/273#discussion_r131965104
--- Diff:
bigtop-tests/test-artifacts/hbase/src/main/groovy/org/apache/bigtop/itest/hbase/smoke/TestImportTsv.groovy
---
@@ -89,7 +92,8 @@ public class
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/268
I will squash the commits to a single one before pushing to the master
branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/268#discussion_r130446888
--- Diff: bigtop-tests/smoke-tests/spark/TestSpark.groovy ---
@@ -40,6 +40,8 @@ class TestSpark {
static Shell sh = new Shell("/bin/ba
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/268#discussion_r130447063
--- Diff: bigtop-tests/smoke-tests/spark/TestSpark.groovy ---
@@ -73,7 +75,7 @@ class TestSpark {
// 'yarn-client' mode
String masterMode
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/274
That must break the test everywhere, ie independent of a platform. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512767
--- Diff: bigtop-tests/smoke-tests/hive/TestMethods.java ---
@@ -0,0 +1,194 @@
+
+//Author: Bharat Modi
+// A masterclass containing methods which
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512670
--- Diff: bigtop-tests/smoke-tests/hive/TestMethods.java ---
@@ -0,0 +1,194 @@
+
+//Author: Bharat Modi
+// A masterclass containing methods which
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512721
--- Diff: bigtop-tests/smoke-tests/hive/TestMethods.java ---
@@ -0,0 +1,194 @@
+
+//Author: Bharat Modi
+// A masterclass containing methods which
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512687
--- Diff: bigtop-tests/smoke-tests/hive/TestMethods.java ---
@@ -0,0 +1,194 @@
+
+//Author: Bharat Modi
+// A masterclass containing methods which
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512551
--- Diff: bigtop-tests/smoke-tests/hive/HiveJdbcGeneralTest.java ---
@@ -0,0 +1,87 @@
+
+
+import static org.junit.Assert.assertEquals
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512628
--- Diff: bigtop-tests/smoke-tests/hive/HiveJdbcGeneralTest.java ---
@@ -0,0 +1,87 @@
+
+
+import static org.junit.Assert.assertEquals
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512537
--- Diff: bigtop-tests/smoke-tests/hive/HiveJdbcGeneralTest.java ---
@@ -0,0 +1,87 @@
+
+
+import static org.junit.Assert.assertEquals
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512522
--- Diff: bigtop-tests/smoke-tests/hive/HiveJdbcGeneralTest.java ---
@@ -0,0 +1,87 @@
+
--- End diff --
The first two lines are blank - no need
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512677
--- Diff: bigtop-tests/smoke-tests/hive/TestMethods.java ---
@@ -0,0 +1,194 @@
+
+//Author: Bharat Modi
+// A masterclass containing methods which
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/272
So, I assume the one from Hadoop will be used instead, right?
Looks reasonable, I will commit this shortly.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/265
+1, committing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/264
While I am not sure we are going to have the official support for Debian 9
- well, I just don't remember if we have discussed it yet ;) - the patch looks
good and I am committing this. Thanks
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/263
+1, will commit in a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/271
I assume the tests are ok after the change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/271
If you rename the PR to match the JIRA number/name, ASF's Infra bot would
be able to pull the comments from here into JIRA directly.
---
If your project is set up for it, you can reply to this email
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/267
Thanks for checking! And a good find - I will commit it shortly!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/267
Is this the case in DEB as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/262
+1, committing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/261
+1 Will commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/260
That looks good. I will commit this shortly. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/259
That makes sense! @evans-ye, is it ok with you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/255
That seems to be bringing the AArch64 docker file inline with x86 one.
Looks about right, but I haven't run any tests.
Will commit this a we'll see if this fixes the situation with the docker
image
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/258
Well, the change still reads
" +repo:
"http://bigtop-repos.s3.amazonaws.com/releases/1.2.0/centos/7/x86_64; "
---
If your project is set up for it, you can reply to this email and
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/258
Are you intentionally pointing this to
` repo:
"http://bigtop-repos.s3.amazonaws.com/releases/1.2.0/centos/7/x86_64; `
I was under the impression this is for AArch64, no?
---
If your pr
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/256
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/253
+1
I will commit it shortly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/252
wow, an interesting approach indeed. Looks legit, though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/251
Looks logical and elegant. +1 (w/o any testing_
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/245
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/245
We aren't supporting Debian-9 yet, right? Shall we worry about this once we
are dealing with the new version?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/215
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/199
Seems LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/188#discussion_r107769130
--- Diff: bigtop-packages/src/common/apex/do-component-build ---
@@ -28,6 +28,9 @@ command -v mvn > /dev/null 2>&1 || {
# Build apex
mvn cle
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/187
If it is all working and look good for other Juju's team guys - please go
and commit this, perhaps after squashing them together. Thanks!
---
If your project is set up for it, you can reply
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/188#discussion_r107272696
--- Diff: bigtop-packages/src/common/apex/do-component-build ---
@@ -28,6 +28,9 @@ command -v mvn > /dev/null 2>&1 || {
# Build apex
mvn cle
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/164
Can the author reply to
[this](https://issues.apache.org/jira/browse/BIGTOP-2526?focusedCommentId=15727134=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15727134)
comment
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/146
it has been committed - you can close the PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/146#discussion_r79902357
--- Diff: bigtop-deploy/vm/vagrant-puppet-vm/README.md ---
@@ -56,13 +56,18 @@ num_instances: 5
5) Test on local built packages is available
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/143
Well, looks like I can not build the RPM while running build as a
non-privileged user (which is what we do always). I am getting this:
```
make[1]: Entering directory `/ws/build/gpdb/rpm
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r79451565
--- Diff: bigtop-deploy/puppet/modules/gpdb/README.md ---
@@ -0,0 +1,19 @@
+Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r79451840
--- Diff: bigtop-deploy/puppet/modules/gpdb/templates/init-db.sh ---
@@ -0,0 +1,4 @@
+#!/bin/sh
+if [ ! -d $1 ]; then
+export LD_LIBRARY_PATH
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r79450456
--- Diff: bigtop-packages/src/rpm/gpdb/SPECS/gpdb.spec ---
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/142
Committed, please close the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/142
The changes look good, but I feel they will break the BIGTOP-2524 patch and
it'd needed to get rebased. I will be pushing this one shortly unless I hear
otherwise.
---
If your project is set up
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77923498
--- Diff: bigtop-packages/src/rpm/gpdb/SPECS/gpdb.spec ---
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77923188
--- Diff: bigtop-packages/src/deb/gpdb/control ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77868402
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77868322
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77868216
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77868168
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77867992
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77867595
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77867183
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77866981
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77866936
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77866848
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/143#discussion_r77866807
--- Diff: bigtop-deploy/puppet/modules/gpdb/manifests/init.pp ---
@@ -0,0 +1,440 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/145
Seems to be legit (without testing).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/104
Can the author close this PR? Has been committed a long time ago. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/141
I have committed the fix. Thanks for your help guys, please close the PR as
you see fit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/141
I am confused. Who's the author of the patch? The commit shows
```
From: Artur Papikyan <artur_papik...@epam.com>
Date: Fri, 26 Aug 2016 16:12:42 +0300
```
Is this c
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/140
seems like a good first code review for @kwmonroe ? ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/141#discussion_r7684
--- Diff: bigtop_toolchain/bin/puppetize.sh ---
@@ -54,8 +54,13 @@ case ${ID}-${VERSION_ID} in
apt-get -y install curl sudo unzip wget puppet
software
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/137#discussion_r74286278
--- Diff: bigtop-packages/src/charm/zeppelin/layer-zeppelin/LICENSE ---
@@ -0,0 +1,177 @@
+
--- End diff --
You don't need to include LICENSE
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/44
I guess...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/12
It doesn't apply anymore, it seems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/116
That seems about right, but I don't know Ruby so well to tell if this is
the best practices. Can anyone else chime in?
---
If your project is set up for it, you can reply to this email and have your
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/115
Please don't mix formatting changes with the real fix - in extreme cases it
makes reading quite hard
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/114
oh yeah, makes sense! +1 will commit it in a bit. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 141 matches
Mail list logo
