[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94975515 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -28,51 +32,188 @@ import

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94960067 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94962954 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94962175 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94961965 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94980522 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -28,51 +32,188 @@ import

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94968550 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94785113 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterUnwrappingTest.java --- @@ -146,8 +151,9 @@ public

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94787693 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterUnwrappingTest.java --- @@ -309,7 +298,7 @@ public

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94927466 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/EntityManagementUtils.java --- @@ -255,8 +255,9 @@ private static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94777251 --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java --- @@ -147,27 +147,28 @@ public SpecT

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94981371 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -28,51 +32,188 @@ import

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94973110 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java --- @@ -457,6 +457,8 @@ public boolean equals(Object obj) {

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94961073 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94984001 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -82,9 +223,17 @@ public InheritanceMode

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94924294 --- Diff: api/src/main/java/org/apache/brooklyn/api/objs/Configurable.java --- @@ -98,6 +99,14 @@ */ T set(HasConfigKey

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94985326 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -170,12 +324,103 @@ public String

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94952205 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -227,13 +234,30 @@ public String toString() {

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94785585 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterUnwrappingTest.java --- @@ -169,19 +175,23 @@

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94962666 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94985394 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -170,12 +324,103 @@ public String

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94782620 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterUnwrappingTest.java --- @@ -146,8 +151,9 @@ public

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r94780176 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java --- @@ -403,8

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94984349 --- Diff: karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/ClasspathOsgiConfigLoader.java --- @@ -0,0 +1,70 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94982693 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingJcloudsRenamesProvider.java --- @@ -0,0 +1,43 @@ +/* + *

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94983917 --- Diff: karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/ClasspathOsgiConfigLoader.java --- @@ -0,0 +1,70 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94983722 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/PropertiesConfigLoader.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94982414 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingJcloudsRenamesProvider.java --- @@ -0,0 +1,43 @@ +/* + *

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94983344 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/JcloudsProviderRenameConfigLoader.java --- @@ -0,0 +1,30 @@ +/* + *

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94984056 --- Diff: karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/JcloudsProviderRenameOsgiConfigLoader.java --- @@ -0,0 +1,57 @@ +/* +

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94983575 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingProvider.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94981908 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java --- @@ -43,49 +37,30 @@ * See

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94984944 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsProviderAndApiLoaderTest.java --- @@ -68,6 +69,35 @@ public

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94983260 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/ClasspathConfigLoader.java --- @@ -18,55 +18,17 @@ */ package

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/508#discussion_r94982612 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java --- @@ -43,49 +37,30 @@ * See

[GitHub] brooklyn-server issue #508: Alternate names for JcloudsProviders

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/508 @drigodwin can you kick off the jenkins build again please (e.g. by making a change to the commit id by running `git commit --ammend; git push -f`). The jenkins test failure looks

[GitHub] brooklyn-server issue #362: bump httpcomponents versions

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/362 Trying to test this (including the cxf upgrade to 3.1.9), it is failing when starting karaf with: ``` 2017-01-06 15:29:40,191 ERROR 11 o.a.k.f.i.s.BootFeaturesInstaller

[GitHub] brooklyn-server issue #507: Make the default catalog location configurable

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/507 Tested, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (BROOKLYN-422) Using AWS availability zone as location region causes IllegalStateException during deployment

[ https://issues.apache.org/jira/browse/BROOKLYN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804801#comment-15804801 ] Sam Corbett commented on BROOKLYN-422: -- This was fixed in

[jira] [Updated] (BROOKLYN-422) Using AWS availability zone as location region causes IllegalStateException during deployment

[ https://issues.apache.org/jira/browse/BROOKLYN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Corbett updated BROOKLYN-422: - Description: A regression in 0.10.0 causes deployments that use specific AWS availability

[jira] [Created] (BROOKLYN-422) Using AWS availability zone as location region causes IllegalStateException during deployment

Sam Corbett created BROOKLYN-422: Summary: Using AWS availability zone as location region causes IllegalStateException during deployment Key: BROOKLYN-422 URL: https://issues.apache.org/jira/browse/BROOKLYN-422

[GitHub] brooklyn-dist issue #74: PR merge automation

Github user richardcloudsoft commented on the issue: https://github.com/apache/brooklyn-dist/pull/74 Nice! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] brooklyn-dist pull request #65: Update release scripts for Apache Brooklyn 0...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders

GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-server/pull/508 Alternate names for JcloudsProviders This adds the ability to have alternate names for JcloudsProviders stored a property file

Jenkins build is back to normal : brooklyn-master-build #685

See

[GitHub] brooklyn-server pull request #507: Makes the default catalog location config...

GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-server/pull/507 Makes the default catalog location configurable default catalog location can now be configured using the below PID `org.apache.brooklyn.osgilauncher/default.catalog.location`

[GitHub] brooklyn-dist pull request #76: Makes the default catalog location configura...

GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-dist/pull/76 Makes the default catalog location configurable default catalog location can now be configured using the below PID `org.apache.brooklyn.osgilauncher/default.catalog.location`

[GitHub] brooklyn-dist pull request #74: PR merge automation

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-dist issue #75: Use new brooklyn-server-config feature

Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-dist/pull/75 I think we need to have these files in place before boot for discoverability I would go with the `maven-dependency-plugin` to add them to the etc directory at the correct phase

[GitHub] brooklyn-dist pull request #74: PR merge automation

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/74#discussion_r94949151 --- Diff: scripts/am --- @@ -0,0 +1,97 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] brooklyn-dist pull request #74: PR merge automation

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/74#discussion_r94949096 --- Diff: scripts/am --- @@ -0,0 +1,97 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] brooklyn-dist issue #72: Allow a user to add or override deserialize configu...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/72 @aledsage This can be merged now. Also, I created 2 PRs to follow up, based on @m4rkmckenna and @neykov's comments 1. https://github.com/apache/brooklyn-server/pull/504 2.

[GitHub] brooklyn-server pull request #362: bump httpcomponents versions

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/362#discussion_r94937432 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -51,8 +51,8 @@ mvn:commons-codec/commons-codec/${commons-codec.version}

[GitHub] brooklyn-dist pull request #67: Replace expired ubuntu default

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (BROOKLYN-404) ConcurrentModificationException on rebind to persisted state (in BrooklynProperties)

[ https://issues.apache.org/jira/browse/BROOKLYN-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804275#comment-15804275 ] ASF GitHub Bot commented on BROOKLYN-404: - GitHub user aledsage opened a pull request:

Build failed in Jenkins: brooklyn-server-master #406

See Changes: [aled.sage] BROOKLYN-421: add tests for catalog library loading -- [...truncated 30786 lines...] Simulated driver exception: TestException: Simulated driver exception

[GitHub] brooklyn-server pull request #502: BROOKLYN-421: add tests for catalog libra...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-dist pull request #74: PR merge automation

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/74#discussion_r94921861 --- Diff: scripts/am --- @@ -0,0 +1,97 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] brooklyn-dist pull request #74: PR merge automation

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/74#discussion_r94919688 --- Diff: scripts/am --- @@ -0,0 +1,97 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] brooklyn-dist pull request #74: PR merge automation

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/74#discussion_r94921205 --- Diff: scripts/am --- @@ -0,0 +1,97 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor