Re: [DISCUSS] Towards Calcite 1.17.0

Sorry, missed timezone: 14 Jun, 6:00 AM UTC Kind regards, Volodymyr Vysotskyi пт, 13 лип. 2018 о 17:03 Volodymyr Vysotskyi пише: > Hi all, > > I think the next Monday (Jun, 16) is a good time for publishing > the RC for Apache Calcite, therefore if there any PRs > which should be included in

Re: [DISCUSS] Towards Calcite 1.17.0

Hi all, I think the next Monday (Jun, 16) is a good time for publishing the RC for Apache Calcite, therefore if there any PRs which should be included in this release, please merge them before 14 Jun, 6:00 AM to reserve some time for additional checks and testing. I'll take care of CALCITE-2409

Re: [DISCUSS] Towards Calcite 1.17.0

Hi Volodymyr, I hope to be done with https://issues.apache.org/jira/browse/CALCITE-2404 before the end of next week. Personally, I don't mind if it does not make it to this release since for my use-case I can patch the code directly. Best, Stamatis 2018-07-11 17:13 GMT+02:00 Julian Hyde : > I

Re: [DISCUSS] Towards Calcite 1.17.0

I think this release train has waited long enough. We should wait for issues that people are fixing themselves, within the next 24 hours. And review PRs that have already been submitted. We release regularly, so there will be another train in a couple of months. Julian > On Jul 11, 2018, at

Re: [DISCUSS] Towards Calcite 1.17.0

It would be good if someone else could also have a look at the PR below for CALCITE-2331 as it's basically ready to merge pending a decision on a behaviour change. https://github.com/apache/calcite/pull/755 -- Michael Mior mm...@uwaterloo.ca Le mer. 11 juil. 2018 à 06:30, Stamatis Zampetakis a

Re: [DISCUSS] Towards Calcite 1.17.0

Hello Stamatis, Do you have ETA for the fix for this Jira? If it will be solved in the next couple of days, we can include it to 1.17. Kind regards, Volodymyr Vysotskyi ср, 11 лип. 2018 о 13:30 Stamatis Zampetakis пише: > Hello, > > I would like to bring your attention towards a new issue

Re: [DISCUSS] Towards Calcite 1.17.0

Hello, I would like to bring your attention towards a new issue namely https://issues.apache.org/jira/browse/CALCITE-2404 concerning access on structured types. Basically, any query involving fields of Record type cannot be executed by the runtime (in Enumerable/Bindable convention). At least

Re: [DISCUSS] Towards Calcite 1.17.0

I have created PR-753 for CALCITE-2331. Please note it fixes only ES adapter (mongo is also affected). On Thu, Jun 28, 2018 at 1:54 PM Michael Mior wrote: > I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is > working on a PR and

Re: [DISCUSS] Towards Calcite 1.17.0

Hello, I made the feature toggle a private method - so its only accessible from within RexSimplify; I've also added a reference to what needs to be fixed in the longterm using the Bug class. cheers, Zoltan On 4 July 2018 03:32:16 CEST, Julian Hyde wrote: >I saw you introduced a config

Re: [DISCUSS] Towards Calcite 1.17.0

I saw you introduced a config parameter to disable previous behavior. That’s fine, but let’s do it in such a way that the parameter can disappear in a (near) future release. I hate config parameters. Julian > On Jul 3, 2018, at 1:26 AM, Zoltan Haindrich wrote: > > Hello, > > I plan to

Re: [DISCUSS] Towards Calcite 1.17.0

Hello, I plan to submit a patch to restore earlier performance today - I think I've came up with a plan to make a more complete fix; but that will definetly take more time than a few days...and of course there is a risk that I'm wrong :) cheers, Zoltan On 07/02/2018 09:13 PM, Volodymyr

Re: [DISCUSS] Towards Calcite 1.17.0

I think I can finish CALCITE-2392 on Wed or Thursday. Kind regards, Volodymyr Vysotskyi пн, 2 лип. 2018 о 21:22 Julian Hyde пише: > OK, so 2384 and 2392 are the critical path. > > Zoltan, when do you think you can finish 2392? > > Volodymr, when do you think you can finish 2384? > > When we

Re: [DISCUSS] Towards Calcite 1.17.0

OK, so 2384 and 2392 are the critical path. Zoltan, when do you think you can finish 2392? Volodymr, when do you think you can finish 2384? When we have these answers we can set a target date for the RC. Julian > On Jul 2, 2018, at 11:13 AM, Volodymyr Vysotskyi wrote: > > Hi, > > Here is

Re: [DISCUSS] Towards Calcite 1.17.0

Hi, Here is the list of the Jiras, which in my opinions should be fixed before the release: - https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue - https://issues.apache.org/jira/browse/CALCITE-2392 Regression appeared after 1.16 (not sure about blocker status for this Jira) -

Re: [DISCUSS] Towards Calcite 1.17.0

> On Jun 29, 2018, at 7:29 PM, Francis Chuang wrote: > > Can someone please confirm that the following PRs can be closed? > https://github.com/apache/calcite/pull/180 > > https://github.com/apache/calcite/pull/17 >

Re: [DISCUSS] Towards Calcite 1.17.0

I asked INFRA and they can only close issues on request. They can't grant permissions. -- Michael Mior mm...@apache.org Le lun. 2 juil. 2018 à 08:17, Enrico Olivelli a écrit : > Il giorno lun 2 lug 2018 alle ore 14:12 Michael Mior ha > scritto: > > > It's not really that I think closing

Re: [DISCUSS] Towards Calcite 1.17.0

It's not really that I think closing stale PRs warrants an entry in the commit log, it's that I don't like the idea of polluting other commits. But it's not really that big of a deal so if others prefer that route, fine by me. As far as Enrico's suggestion, I've always had my Apache ID associated

Re: [DISCUSS] Towards Calcite 1.17.0

Il lun 2 lug 2018, 06:33 Julian Hyde ha scritto: > I disagree with Michael. Closing rejected PRs is not important enough to > warrant making an entry in the commit log. > I agree with Julian > Regarding Enrico’s comments. I would be nice if there was a way for > committers to close PRs, and

Re: [DISCUSS] Towards Calcite 1.17.0

I disagree with Michael. Closing rejected PRs is not important enough to warrant making an entry in the commit log. Regarding Enrico’s comments. I would be nice if there was a way for committers to close PRs, and there probably is. I don’t have the time and energy to find out, but I won’t

Re: [DISCUSS] Towards Calcite 1.17.0

Jumping on this train In theory committers should be able to close prs using thethe button. Ask infra to have this permission, at least the Pmc Enrico Il sab 30 giu 2018, 16:07 Michael Mior ha scritto: > I'd suggest just using the --allow-empty flag to git commit to create a > commit with

Re: [DISCUSS] Towards Calcite 1.17.0

I'd suggest just using the --allow-empty flag to git commit to create a commit with no changes so at least we have a distinct entry in the commit log to record closing the PRs. I'd say close 17 and 180 given how old they are. If anything that old is important, it can always be reopened or a new

Re: [DISCUSS] Towards Calcite 1.17.0

When we decide to close these, rather than bothering INFRA, I’ll just add “close apache/calcite#nnn” to the next commit that I merge to master. Julian > On Jun 29, 2018, at 7:29 PM, Francis Chuang wrote: > > Thanks Julian + Sergey! > > Can someone please confirm that the following PRs can

Re: [DISCUSS] Towards Calcite 1.17.0

Thanks Julian + Sergey! Can someone please confirm that the following PRs can be closed? https://github.com/apache/calcite/pull/180 https://github.com/apache/calcite/pull/17 https://github.com/apache/calcite/pull/422 If so, I'll open a case with INFRA to close them. Francis On 30/06/2018 7:14

Re: [DISCUSS] Towards Calcite 1.17.0

Thanks for bringing this up, Francis. Note that sometimes there are comments on the JIRA case (and so sometimes the ball might be in the contributor's court). But yes, let's either review all of these or close them as stale. As it happens, I picked up a half-finished patch

Re: [DISCUSS] Towards Calcite 1.17.0

>>[CALCITE-1866] adapted existing changes to current master + added tests On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang wrote: > I would love to see if we can close out/merge some of the really stale PRs > on Github. > > Here are a few that I think we should resolve before the release: > >

Re: [DISCUSS] Towards Calcite 1.17.0

I would love to see if we can close out/merge some of the really stale PRs on Github. Here are a few that I think we should resolve before the release: [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in Avatica: https://github.com/apache/calcite/pull/180 (JIRA is marked as

Re: [DISCUSS] Towards Calcite 1.17.0

I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is working on a PR and this would be a good bug to have fixed. * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of predicate (A or B) and C is failing for some adapters -- Michael Mior mm...@apache.org Le jeu.

Re: [DISCUSS] Towards Calcite 1.17.0

To answer Michael's question: I don't think we should delay the report, nor should we hurry the release. It's fair to say that 1.17 is in its final stages. There was a lot of activity on avatica-1.12 from a lot of individuals, and the community is in great shape. Here are the cases listed by

Re: [DISCUSS] Towards Calcite 1.17.0

Hi Michael, There are several Jiras, which I think are blockers for the release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303. Also, there is a list of the Jiras, which would be good to include to 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339. So I think we need at

Re: [DISCUSS] Towards Calcite 1.17.0

It also would be great to have at least a BETA version of Babel parser Enrico Il gio 28 giu 2018, 18:48 Michael Mior ha scritto: > Just wanted to check in with how we're doing with progress towards a > release. It's not a rush at all, but I'm preparing the board report for > July and wondering

Re: [DISCUSS] Towards Calcite 1.17.0

Just wanted to check in with how we're doing with progress towards a release. It's not a rush at all, but I'm preparing the board report for July and wondering if I should wait to include the 1.17.0 release. It sounds like there are a few other things that still need to be wrapped up, so I'm fine

Re: [DISCUSS] Towards Calcite 1.17.0

I’d appreciate if Kevin could finish https://issues.apache.org/jira/browse/CALCITE-2259 but I can’t ask you to hold the release because Kevin owns his own time. > On May 30, 2018, at 5:20 AM, Volodymyr Vysotskyi wrote: > > Sorry, for some

Re: [DISCUSS] Towards Calcite 1.17.0

Sorry, for some reason was sent a letter without the last changes. Link to the Jira to track Calcite release: [2] https://issues.apache.org/jira/browse/CALCITE-2337 Kind regards, Volodymyr Vysotskyi ср, 30 трав. 2018 о 14:44 Volodymyr Vysotskyi пише: > Calcite 1.16.0 was released on March 19

[DISCUSS] Towards Calcite 1.17.0

Calcite 1.16.0 was released on March 19 (more than two months ago). We have solved over 48 issues[1] since then, therefore we should start discussing about releasing Calcite 1.17.0. I have created [2] to track the release. We will start a release process after the Avatica 1.12 is released. I