Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218367932
I reran the tests that failed and they succeeded the second time, so CI is
in a good place on this one. I need one more code review on this one.
@marcaurele can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218367555
### CI RESULTS
```
Tests Run: 94
Skipped: 0
Failed: 2
Errors: 0
Duration: 7h 45m 13s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-218367282
@anshul1886 can you please review and address the comments in this PR?
Thanks...
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-218367016
#1515 has now been merged (sorry for the delay). Once you have a chance to
fix the merge conflicts, I can get this merged. Thx...
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1455#issuecomment-218366880
Bump... @sanju1010 can you please follow up on @DaanHoogland's comments.
This one is ready to go otherwise, so it would be great if you could follow up
with us on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-218366572
@sudhansu7 can you force push again to kick off Jenkins and Travis again?
Thx...
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218366133
@DaanHoogland can you force push this one again so we can kick off Jenkins
again. It has been stuck in this state for a week. Thx...
---
If your project is set up
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-218365520
I am going to merge this one. I am confident with the change and I have
verification from @remibergsma, so I think we are good to go on this one.
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-218365435
@jburwell can I get your final review on this one? I think that is the
only thing we are missing on this one. Thx...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218365323
@remibergsma just a reminder to squash and re-push so we can get jenkins
green. Thx...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-218365187
@NuxRo can you close and reopen this PR to force Jenkins to kick off a run.
It has been hung in this state for days. I know you can't easily `amend` and
force
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-218362729
Can someone with a VMware environment validate this PR is functional? I
don't think running CI is going to give us anything on this one since I only
have KVM and
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-218362347
Rebased and pushed it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62790898
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62790877
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218359137
Thank you. I am really trying to avoid that, but lets see what happens. :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218358868
@swill done, though if it fails again we may ignore that as long as travis
is green
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218358102
thank you sir. can you repush right away again. jenkins already failed
and I like to make sure everything is green before i merge stuff. thx...
---
If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218357625
@swill I've fixed the issues, here are the changes:
[changes.diff.txt](https://github.com/apache/cloudstack/files/258551/changes.diff.txt)
The conflicts
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-218356820
These connectivity issues are unrelated to this PR. I will merge this
now...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-218356736
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 3
Errors: 0
Duration: 6h 24m 57s
```
**Summary of the
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218356331
Sorry to do this to you @rhtyd, but I just merged like 10 PRs and we now
have merge conflicts. Can you resolve the merge conflicts and re-push. When
you resolve
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-218355774
@abhinandanprateek Reading through the code, it seems like there could be
benefit from the following value objects:
* IpAddress interface whose
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1054
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788791
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDRFactory.java ---
@@ -0,0 +1,79 @@
+//
+// Licensed to the Apache Software Foundation
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1428
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788718
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDRFactory.java ---
@@ -0,0 +1,79 @@
+//
+// Licensed to the Apache Software Foundation
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1497
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1496
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788636
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR6.java ---
@@ -0,0 +1,95 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788572
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788491
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218354565
Can you re-push to try to get Jenkins green. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788397
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788312
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788201
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788152
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787923
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787904
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787677
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787612
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787530
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787493
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787426
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787416
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787378
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787136
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787151
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787129
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787143
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787123
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787065
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787032
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786873
--- Diff:
utils/src/main/java/com/cloud/utils/net/cidr/BadCIDRException.java ---
@@ -0,0 +1,33 @@
+//
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786802
--- Diff:
utils/src/main/java/com/cloud/utils/net/cidr/BadCIDRException.java ---
@@ -0,0 +1,33 @@
+//
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786731
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
cidr) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786638
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
cidr) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786538
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1135,6 +1142,21 @@ public static boolean isSameIpRange(final String
cidrA,
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786497
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -903,6 +906,10 @@ static boolean areCidrsNotEmpty(String cidrA, String
cidrB) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786345
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786260
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786232
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786148
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786093
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786006
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785940
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785864
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785806
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785711
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785662
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785576
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785361
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785317
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783518
--- Diff:
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java ---
@@ -316,4 +317,9 @@ public boolean visit(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783468
--- Diff:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
---
@@ -212,4 +214,20 @@ public boolean visit(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783380
--- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java ---
@@ -1236,18 +1218,34 @@ public void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783052
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -809,15 +945,22 @@ public Vpc createVpc(final long zoneId, final long
vpcOffId,
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783039
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -809,15 +945,22 @@ public Vpc createVpc(final long zoneId, final long
vpcOffId,
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782933
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782870
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782819
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782681
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782579
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782496
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782438
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId) {
}
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782392
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId) {
}
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782162
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -529,14 +545,14 @@ private boolean findCapabilityForService(final Map
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782148
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -501,7 +517,7 @@ private void
validateConnectivtyServiceCapabilities(final Set
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782035
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781813
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781709
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -455,16 +471,26 @@ protected void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781651
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -455,16 +471,26 @@ protected void
1 - 100 of 190 matches
Mail list logo
