Re: new contributor guide

2019-03-22 Thread Marc-Aurèle Brothier
Hi Pierre-Luc, You can have a look at those links for the install and development setup: - https://github.com/apache/cloudstack/blob/master/INSTALL.md - https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Those should get you started. If those aren’t enough and/or you get stuck,

Re: CII best practices & cncf

2019-03-21 Thread Marc-Aurèle Brothier
d, and you should please notify the sender immediately and > then delete it (including any attachments) from your system. Thank you. >> Am 21.03.2019 um 13:14 schrieb Marc-Aurèle Brothier : >> >> Hi all, >> >> I found recently the core infrastructure website and

CII best practices & cncf

2019-03-21 Thread Marc-Aurèle Brothier
Hi all, I found recently the core infrastructure website and saw other projects listed there, but not Cloudstack. So I thought it would be a good thing to add this visibility. I’m in the process to fill up the form which you can find here:

Re: [DISCUSS] Move to jdk11 and use jlink

2019-03-20 Thread Marc-Aurèle Brothier
Hi Rohit, I think it’s a good move. After some recent testing I found some incompatibility between the jdk11 and older version of spring. I don’t have at hands the links but you have to upgrade to some specific version to make it work. Marco > On 20 Mar 2019, at 05:59, Rohit Yadav wrote: >

Re: SSL offload in the VR

2018-11-20 Thread Marc-Aurèle Brothier
Hi Paul, What made you think so? I haven’t pushed any change related to the VR. At Exoscale, we removed the VR entirely instead and moved the services down at the HV level. Kind regards, Marc-Aurèle > On 20 Nov 2018, at 09:04, Paul Angus wrote: > > Hi Marc-Aurèle, > > As far as I can

API rate limiting

2018-11-01 Thread Marc-Aurèle Brothier
Hi, Are people using the API rate limiting feature ? I'm working on removing the ehcache and was wondering if I need to find an alternate solution for that plugin or if it could be removed too. Marc-Aurèle signature.asc Description: Message signed with OpenPGP using GPGMail

Re: Caching / Ehcache

2018-11-01 Thread Marc-Aurèle Brothier
un, Oct 28, 2018 at 2:17 PM Daan Hoogland > wrote: > >> Sorry to hear you are reducing your activity on CloudStack, Marc-Aurele. >> Hope you fare well. >> >> On Sat, Oct 27, 2018 at 10:10 PM Marc-Aurèle Brothier >> wrote: >> >>> Hi everyone, >

Caching / Ehcache

2018-10-27 Thread Marc-Aurèle Brothier
Hi everyone, (Again as the email formatting has been removed and was hard to read - I hope it will be better this time). While trying to lower the DB load for CloudStack I did some long testing and here are my outcomes for the current cache mechanism in CloudStack. I would be interested to hear

Caching - Ehcache

2018-10-23 Thread Marc-Aurèle Brothier
Hi everyone, Will trying to lower the DB load for CloudStack I did some long testing and here are my outcomes for the current cache mechanism in CloudStack. I would be interested to hear from people who try to customize the ehcache configuration in CS. A PR

Re: Github Issues

2018-07-17 Thread Marc-Aurèle Brothier
Hi Paul, My 2 cents on the topic. people are commenting on issues when it should by the PR and vice-versa > I think this is simply due to the fact that with one login you can do both, versus before you had to have a JIRA login which people might have tried to avoid, preferring using github

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-16 Thread Marc-Aurèle Brothier
> From: Suresh Kumar Anaparti <sureshkumar.anapa...@gmail.com> > > Sent: Tuesday, May 15, 2018 12:06:14 AM > > To: dev@cloudstack.apache.org > > Subject: Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt > > server) disconnection? > > >

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-14 Thread Marc-Aurèle Brothier
working on a zookeeper based rolling shutdown/restart? > Did that handle some of the failure cases? > > > - Rohit > > <https://cloudstack.apache.org> > > > > > From: Marc-Aurèle Brothier <ma...@exoscale.ch> > Sent: Monday, May

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-14 Thread Marc-Aurèle Brothier
Hi, I'm also for a bigger change but this PR already moves forward to a better agent <-> management connection hanlding. @rhtyd did you test your PR manually by, for example, requesting a long snapshot operation and disconnecting the agent. I have one concern here: when an async job is taken

Re: John Kinsella and Wido den Hollander now ASF members

2018-05-03 Thread Marc-Aurèle Brothier
Congratulations to both of you! On Thu, May 3, 2018 at 10:08 AM, Rohit Yadav wrote: > Congratulations John and Wido. > > > > - Rohit > > > > > > > From: David Nalley > Sent: Wednesday,

Re: Default API response type: XML -> JSON

2018-04-24 Thread Marc-Aurèle Brothier
be XML to maintain backward > compatibility. Then, it is up to the root admin to define this behavior. > > > On Mon, Apr 23, 2018 at 10:34 AM, Marc-Aurèle Brothier <ma...@exoscale.ch> > wrote: > > > Hi everyone, > > > > I thought it would be good to mov

Default API response type: XML -> JSON

2018-04-23 Thread Marc-Aurèle Brothier
Hi everyone, I thought it would be good to move from XML to JSON by default in the response of the API if no response type is sent to the server along with the request. I'm wondering that's the opinion of people on the mailing list. Moreover, if anyone knows a tool working with the API in XML

Re: [DISCUSS] CloudStack graceful shutdown

2018-04-18 Thread Marc-Aurèle Brothier
gt; >>> > > >>> > I can tell you when you have CEPH/NFS (CEPH even "worse" case, > >>> since > >>> slower > >>> > read durign qemu-img convert process...) of 500GB, then imagine > >>> snapsho

Re: [DISCUSS] CloudStack graceful shutdown

2018-04-05 Thread Marc-Aurèle Brothier
Hi all, Good point ilya but as stated by Sergey there's more thing to consider before being able to do a proper shutdown. I augmented my script I gave you originally and changed code in CS. What we're doing for our environment is as follow: 1. the MGMT looks for a change in the file

Re: Welcoming Mike as the new Apache CloudStack VP

2018-03-26 Thread Marc-Aurèle Brothier
Thanks for the work Wido, and congrats Mike On Tue, Mar 27, 2018 at 6:31 AM, Jayapal Uradi wrote: > Congratulations, Milke! > > -Jayapal > > > On Mar 27, 2018, at 2:38 AM, Nitin Kumar Maharana accelerite.com> wrote: > > > > Congratulations,

Re: [VOTE] Move to Github issues

2018-03-26 Thread Marc-Aurèle Brothier
+1 On Mon, Mar 26, 2018 at 3:05 PM, Will Stevens wrote: > +1 > > On Mon, Mar 26, 2018, 5:51 AM Nicolas Vazquez, < > nicolas.vazq...@shapeblue.com> wrote: > > > +1 > > > > > > From: Dag Sonstebo > > Sent:

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

2018-03-13 Thread Marc-Aurèle Brothier
> > > > and facilitate the management. On the other side of the spectrum, we > > have > > > > things such as removing dead/unused code, opening a new version > > (creating > > > > the upgrade path that we still use for the DB), fix a description in >

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

2018-03-13 Thread Marc-Aurèle Brothier
That's a good idea, because people are more and more used to only create PR on github, and it would be helpful to be more explanatory on the way we work to push changes. I still think we should encourage the use of the github milestone as Rohit did with the 4.11.0 (

Re: I'd like to introduce you to Khosrow

2018-02-23 Thread Marc-Aurèle Brothier
Welcome Khosrow! On Fri, Feb 23, 2018 at 3:21 AM, Syed Ahmed wrote: > Welcome khusrow > On Thu, Feb 22, 2018 at 8:09 PM Simon Weller > wrote: > > > Welcome Khosrow. > > > > Simon Weller/615-312-6068 > > > > -Original Message- > > From:

Re: SystemVM documentation

2018-02-16 Thread Marc-Aurèle Brothier
There's a readme in the directory for the systemVM: https://github.com/apache/cloudstack/tree/master/tools/appliance On Fri, Feb 16, 2018 at 2:11 PM, Raja Pullela wrote: > Hi Rohit, > > Can you please point to the documentation you may have for creating the > 4.11

Re: Experimental - Direct download for templates

2018-02-07 Thread Marc-Aurèle Brothier
That's a great feature I think, thanks Nicolas for pushing it! Marc-Aurèle On Wed, Feb 7, 2018 at 3:19 PM, Nicolas Vazquez < nicolas.vazq...@shapeblue.com> wrote: > Hi all, > > > A feature has been introduced on 4.11.0 allowing to register templates > bypassing secondary storage using a new

Maven standard: PR to rebase & where is gone the file history?

2018-01-22 Thread Marc-Aurèle Brothier
Hi everyone, PR which moved all the files to follow the maven standard for the file structure has been merged on master, therefore all files are now located at: - src/main/java for the java code - src/main/resources for the resources - src/main/webapp for the webapp - src/main/scripts for an

[cloud-init] change on how DHCP leases are scanned to fetch VR address

2018-01-16 Thread Marc-Aurèle Brothier
Hi all, I pushed a PR for cloud-init to change the way the DHCP leases are scanned to retrieve the VR ip address. Currently it does scan the lease files in reverse time order (newest file first) to get the VR address and if that address does not work, it falls back on the default gateway address.

Re: [NOTICE] Master can accept PRs now

2018-01-15 Thread Marc-Aurèle Brothier
Hi! Ok, as my PR for the maven standard structure does a lot of file moves, I'm putting it as a first PR to accept if people agree to: https://github.com/apache/cloudstack/pull/2283 I still have to rebase and fix the conflict, which will be done shortly. On Mon, Jan 15, 2018 at 1:19 PM, Rohit

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Marc-Aurèle Brothier
Hello, Marc-Aurele, thank you for the snippet, but it looks like the sum > > usage everywhere in the codebase. It's aggregation over single field. > What > > I need is to pass multuplication of two fields (cores x speed) inside the > > sum, but I don't understand how to do

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Marc-Aurèle Brothier
hat > I need is to pass multuplication of two fields (cores x speed) inside the > sum, but I don't understand how to do it with dao... Thank you. > > 10 янв. 2018 г. 19:12 пользователь "Marc-Aurèle Brothier" < > ma...@exoscale.ch> > написал: > > > Have a l

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Marc-Aurèle Brothier
Have a look here: https://github.com/apache/cloudstack/blob/master/engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347 Or you can search other example in the code base with this string "Func.SUM": thttps://

Re: [DISCUSS] new way of github working

2018-01-08 Thread Marc-Aurèle Brothier
Same opinion as Rafael described. On Mon, Jan 8, 2018 at 11:30 AM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > I did not fully understand what you meant. > > Are you talking about the merge commit that can be created when a PR is > merged? Or, are you talking about a merge commit

Re: [VOTE] Clean up old and obsolete branches.

2018-01-03 Thread Marc-Aurèle Brothier
+1 On Wed, Jan 3, 2018 at 9:56 AM, Wido den Hollander wrote: > +1 > > > Op 3 jan. 2018 om 09:02 heeft Rohit Yadav > het volgende geschreven: > > > > +0 > > > > > > - Rohit > > > > > > > > > > > >

Known trillian test failures

2017-12-20 Thread Marc-Aurèle Brothier
@rhtyd Could something be done to avoid confusing people pushing PR to have trillian test failures, which apparently are know to fail all the time or often? I know it's hard to keep the tests in good shape and make them run smoothly but I find it very disturbing and therefore I have to admit I'm

Re: [DISCUSS] Management server (pre-)shutdown to avoid killing jobs

2017-12-18 Thread Marc-Aurèle Brothier
t that a management server becomes > unavailable. > > > > > > > > Kind regards, > > > > Paul Angus > > > > paul.an...@shapeblue.com > > www.shapeblue.com > > 53 Chandos Place, Covent Garden, London WC2N 4HSUK > > @shapeblue > > > &g

[DISCUSS] Management server (pre-)shutdown to avoid killing jobs

2017-12-18 Thread Marc-Aurèle Brothier
Hi everyone, Another point, another thread. Currently when shutting down a management server, despite all the "stop()" method not being called as far as I know, the server could be in the middle of processing an async job task. It will lead to a failed job since the response won't be delivered to

Re: Clean up old and obsolete branches

2017-12-18 Thread Marc-Aurèle Brothier
+1 for me On the point 5, since you can have people working together on forks, I would simply state that no other branches except the official ones can be in the project repository, removing: "If one uses the official repository, the branch used must be cleaned right after merging;" On Mon, Dec

Re: [Discuss] Management cluster / Zookeeper holding locks

2017-12-18 Thread Marc-Aurèle Brothier
art...@gmail.com> wrote: > So, we would need to change every piece of code that opens and uses > connections and transactions to change to ZK model? I mean, to direct the > flow to ZK. > > On Mon, Dec 18, 2017 at 8:55 AM, Marc-Aurèle Brothier <ma...@exoscale.ch> > wrote:

Re: [Discuss] Management cluster / Zookeeper holding locks

2017-12-18 Thread Marc-Aurèle Brothier
code base. > Just simple annotation usage or transaction pattern in Spring XML files. > > [1] > https://github.com/rafaelweingartner/daily-tasks/ > blob/master/src/main/java/br/com/supero/desafio/services/TaskService.java > > On Mon, Dec 18, 2017 at 8:32 AM, Marc-Aurèle Brothier

Re: [Discuss] Management cluster / Zookeeper holding locks

2017-12-18 Thread Marc-Aurèle Brothier
gt; headaches with transactions (it is not MySQL locks fault entirely, but our > code structure). > > On Mon, Dec 18, 2017 at 7:47 AM, Marc-Aurèle Brothier <ma...@exoscale.ch> > wrote: > > > We added ZK lock for fix this issue but we will remove all current locks > in &

Re: [Discuss] Management cluster / Zookeeper holding locks

2017-12-18 Thread Marc-Aurèle Brothier
ution like Zookeeper. The performance > > of > > > 3node ZK ensemble should be enough to hold up to 1000-2000 locks per > > second > > > and it helps to move to truly clustered MySQL like galera without > single > > > master server. > > > > &

[Discuss] Management cluster / Zookeeper holding locks

2017-12-18 Thread Marc-Aurèle Brothier
Hi everyone, I was wondering how many of you are running CloudStack with a cluster of management servers. I would think most of you, but it would be nice to hear everyone voices. And do you get hosts going over their capacity limits? We discovered that during the VM allocation, if you get a lot

Re: [PROPOSE] RM for 4.11

2017-11-29 Thread Marc-Aurèle Brothier - Exoscale
Great Rohit! I see you started to tag the PR with the milestone 4.11 on github, that's great! I wish we use more of the little features on github to help organize the releases and reviews. Marc-Aurèle On Wed, 2017-11-29 at 15:44 +0530, Rohit Yadav wrote: > Hi All, > > I’d like to put myself

Re: CloudStack LTS EOL date?

2017-11-21 Thread Marc-Aurèle Brothier - Exoscale
It makes more sense to me too. On Tue, 2017-11-21 at 12:04 +0100, Rene Moser wrote: > Hi all > > The current LTS release is 4.9 which is EOL in June 2018 according to > https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS > > AFAIK there are no works planed for a new LTS. The release

Re: [FS] Request for comments: Secure VM Live Migration for KVM

2017-11-17 Thread Marc-Aurèle Brothier - Exoscale
Working, thanks! On Fri, 2017-11-17 at 11:27 -0200, Rafael Weingärtner wrote: > Marc I added permission to you; can you test if you can make comments > now? > > On Fri, Nov 17, 2017 at 11:20 AM, Marc-Aurèle Brothier - Exoscale < > ma...@exoscale.ch> wrote: > > >

Re: [FS] Request for comments: Secure VM Live Migration for KVM

2017-11-17 Thread Marc-Aurèle Brothier - Exoscale
I'm not able to post comments on the wiki even when logged in so I post to the mailing list. I guess I'm not in any special wiki group to edit CS pages. Good news you made the live migration working (right?) on master. Is it really something we want to control under CS on the agent installation

Re: New committer: Gabriel Beims Bräscher

2017-11-15 Thread Marc-Aurèle Brothier - Exoscale
Welcome Gabriel & congrats! Marc-Aurèle On Wed, 2017-11-15 at 08:32 -0200, Rafael Weingärtner wrote: > The Project Management Committee (PMC) for Apache CloudStack has > invited > Gabriel Beims Bräscher to become committer and we are pleased to > announce > that he has accepted. > > Gabriel has

Re: Remote debugging not working anymore

2017-11-13 Thread Marc-Aurèle Brothier - Exoscale
@rhtyd - the java-opts file content (+ read in the startup script) should be put back to allow startup customization. On Mon, 2017-11-13 at 15:18 +0100, Sigert GOEMINNE wrote: > Hi all, > > Starting from the changes in PR2226 > , what do i need

Re: [ANNOUNCE] Syed Mushtaq Ahmed has joined the PMC

2017-10-10 Thread Marc-Aurèle Brothier
Congrats Syed  On Mon, Oct 9, 2017 at 7:49 PM, Syed Ahmed wrote: > Thank you all for the kind words. It's been a pleasure working with you > guys. I hope we continue the good work! > > -Syed > > On Mon, Oct 9, 2017 at 12:32 PM, Gabriel Beims Bräscher < >

Re: Checkstyle / code style / reformatting

2017-09-29 Thread Marc-Aurèle Brothier
gt; > On Fri, Sep 29, 2017 at 9:44 AM, Marc-Aurèle Brothier <ma...@exoscale.ch> > wrote: > > > Hi everyone, > > > > Would you think it's worth tightening the checkstyle rules and run a > > reformatting pass on the code base to align everything slowly? I kno

Checkstyle / code style / reformatting

2017-09-29 Thread Marc-Aurèle Brothier
Hi everyone, Would you think it's worth tightening the checkstyle rules and run a reformatting pass on the code base to align everything slowly? I know it will hide changes using the blame functionality, and would force people to edit some PR. Is the trade-off worth it for you? The idea would be

Re: Clean up of unused constants

2017-09-26 Thread Marc-Aurèle Brothier
+1 to sort them too On Tue, Sep 26, 2017 at 4:13 PM, Daan Hoogland wrote: > +1 Sigert, be my guest. We will run integration tests on your changes > anyway, so low risk ;) > > On 2017/09/26 15:55, "Rafael Weingärtner" > wrote: > > IMO,

Re: New committers: Nathan Johnson and Marc-Aurèle Brothier

2017-09-22 Thread Marc-Aurèle Brothier
t Management Committee (PMC) for Apache CloudStack has invited > > Nathan Johnson and Marc-Aurèle Brothier to become committers and we are > > pleased to announce that they have accepted. > > > > They have shown commitment to Apache CloudStack community, contributing >

Re: Need to ask for help again (Migration in cloudstack)

2017-09-05 Thread Marc-Aurèle Brothier
Hi Dimitriy, I wrote the PR for the live migration in cloudstack (PR 1709). We're using an older version than upstream so it's hard for me to fix the integration tests errors. All I can tell you, is that you should first configure libvirt correctly for migration. You can play with it by manually

Re: [DISCUSS] Closing old Pull Requests on Github

2017-07-24 Thread Marc-Aurèle Brothier
Hi Wido, I have one comment on this topic. Some of those PRs are lying there because no one took the time to merge them (I have a couple like that) since they were not very important (I think it's the reason), fixing only a small glitch or improving an output. If we start to close the PRs because

Re: ***Cloudstack EUUG - CFP***

2017-06-27 Thread Marc-Aurèle Brothier
Hi Giles, I could give a talk on live migration with KVM that we have since one year here. That might help to get the feature fixed and merged for CS. Let me know. https://github.com/apache/cloudstack/pull/1709 Marc-Aurèle On Thu, Jun 22, 2017 at 1:41 PM, Wido den Hollander

Re: nvidia tesla grid card implementation (kvm)

2017-05-24 Thread Marc-Aurèle Brothier
Hi Sven, We implemented for KVM a pci manager to give a pass through to any PCI devices. We use that to provision VM with Tesla P100 GPU card, 1 to 4 cards per VM. My code is based on CS 4.4.2 and not the upstream version as we are not following anymore upstream. But I completely got rid of Xen

Re: [DISCUSS] Config Drive: Using the OpenStack format?

2017-05-21 Thread Marc-Aurèle Brothier
>> >> Slides are here : >> https://www.slideshare.net/2000monkeys/apache-cloudstack-collab-miami-user-data-alternatives-to-the-vr >> >> Thanks >> >> - Kris >> >>> On 19 May 2017 at 12:58, Wei ZHOU <ustcweiz...@gmail.com> wrote: >>>

Re: [DISCUSS] Config Drive: Using the OpenStack format?

2017-05-19 Thread Marc-Aurèle Brothier
Hi Widoo, That sounds like a pretty good idea in my opinion. +1 for adding it Marco > On 19 May 2017, at 15:15, Wido den Hollander wrote: > > Hi, > > Yesterday at ApacheCon Kris from Nuage networks gave a great presentation > about alternatives for userdata from the VR:

Re: Very slow Virtual Router provisioning with 4.9.2.0

2017-05-03 Thread Marc-Aurèle Brothier
Hi Wido, Well for us, it's not a version problem, it's simply a design problem. This VR is very problematic during any upgrade of cloudstack (which I perform every week almost on our platform), same goes for the secondary storage VMs which scans all templates. We've planned on our roadmap to get

Re: [VOTE] Apache Cloudstack should join the gitbox experiment.

2017-04-11 Thread Marc-Aurèle Brothier
+1 On Tue, Apr 11, 2017 at 7:38 AM, Wido den Hollander wrote: > +1 > > > Op 10 april 2017 om 18:22 schreef Daan Hoogland >: > > > > > > In the Apache foundation an experiment has been going on to host > > mirrors of Apache project on github with more

Re: Handling of DB migrations on forks

2017-02-21 Thread Marc-Aurèle Brothier
Aurele, you are totally right and people agree with you but no one > > seems to give this priority > > > > daan.hoogl...@shapeblue.com > > www.shapeblue.com > > 53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands > > @shapeblue > > > > > >

Re: Handling of DB migrations on forks

2017-02-21 Thread Marc-Aurèle Brothier
IMO the database changes should be idempotent as much as possible with "CREATE OR REPLACE VIEW..." "DROP IF EXISTS". For other things like altering a table, it's more complicated to achieve that in pure SQL. A good call would be to integrate http://www.liquibase.org/ to manage the schema and

Re: [QUESTION] Upgrade path to JDK8

2017-02-21 Thread Marc-Aurèle Brothier
Is there any issue if we compile code with jdk8 but run it on > jdk7 (systemvm) ? > > -Wei > > 2017-02-21 7:43 GMT+01:00 Marc-Aurèle Brothier <ma...@exoscale.ch>: > > > There's a list of compatibility issues between Java 7 & Java 8 here > > http://www.or

Re: [QUESTION] Upgrade path to JDK8

2017-02-20 Thread Marc-Aurèle Brothier
There's a list of compatibility issues between Java 7 & Java 8 here http://www.oracle.com/technetwork/java/javase/8-compatibility-guide-2156366. html The main problem I would see in two system communicating while running different Java version is the way they handle serialization and

Code base evolution over time of cloudstack

2017-01-12 Thread Marc-Aurèle Brothier
Hi everyone, I thought you might like to have a graphical view of how cloudstack code has evolved over time. I ran the script https://github.com/erikbern/git-of-theseus on the project on December 15th 2016. Cheers, Marc-Aurèle

Jira not showing issues if not logged in

2016-11-10 Thread Marc-Aurèle Brothier
Hi, There seems to be a bug or incorrect settings in the Jira CS project. As public user I can only see 6 open issues and the latest update on an issue is from February 2016 on the project dashboard. If I log in, I have a correct project dashboard with 1800+ open issues.

Re: PR Backlog

2016-10-28 Thread Marc-Aurèle Brothier
I think it's a good idea to use the labels for triage and priority. It will make the PR and issue view much simpler on Github. If it's not used on Github, does it mean that all PR/issue on Github must have a JIRA and the triage/sorting is only done there? Marc-Aurèle On Wed, Oct 26, 2016 at 7:18

Re: Question about JavaScript validators in UI

2016-10-26 Thread Marc-Aurèle Brothier
>From a quick look at the code you've forgotten one "|" for the or condition: $.validator.addMethod("ipv46cidr", function(value, element) { if (!$.validator.methods.ipv4cidr.call(this, value, element) || !$.validator.methods.ipv6cidr.call(this, value, element)) return false;