Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88669613
Thanks, @agrieve ! :clap:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88668426
Merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88634066
@agrieve Good catch - totally missed this one. Fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88620427
(esp. for debug signing keys, it's important that they are used not just
when packaging for release)
---
If your project is set up for it, you can reply to this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88620279
Sorry - just realized one more thing. You'll need to add the new flags to
lib/run.js as well or else they won't work with the "cordova run" command.
---
If your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88589573
@agrieve Fixed last set of issues & rebased! This should be ready for a
merge.
---
If your project is set up for it, you can reply to this email and have your
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27593203
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = fu
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27592776
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = f
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27591881
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = fu
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27590810
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = f
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27590209
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case 'gradle
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27589905
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -360,9 +391,15 @@ function parseOpts(options, resolvedTarget) {
var multiValueArgs = {
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27588457
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case 'gradle
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88295360
Just a couple more comments then we are good to go! Thanks for working
through this with me. Feel free to rebase & squash commits.
---
If your project is set up
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536972
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -360,9 +391,15 @@ function parseOpts(options, resolvedTarget) {
var multiValueArgs = {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536475
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = fu
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536261
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case 'gradleA
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88241394
@agrieve I have resolved all the code review comments. Let me know if this
is ready - I can rebase this to make it ready for merge.
---
If your project is set
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446835
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -372,6 +409,7 @@ function parseOpts(options, resolvedTarget) {
if (multiValueArg
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446698
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +609,54 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch) {
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446661
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn('Bu
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446655
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn('Bu
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446385
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = fu
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446338
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn('Bui
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446318
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -297,6 +320,14 @@ var builders = {
var distributionUrl =
'distributionUrl=h
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446076
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -297,6 +320,14 @@ var builders = {
var distributionUrl =
'distributionUrl=ht
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446058
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn('Bui
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446054
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn('Bui
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446047
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +609,54 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446020
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +609,54 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch) {
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27445900
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case 'gradle
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27445404
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case 'gradleA
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27445351
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -372,6 +409,7 @@ function parseOpts(options, resolvedTarget) {
if (multiValueArgs
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-87853461
@agrieve I have finished addressing your code review feedback. Can you
please take another look?
---
If your project is set up for it, you can reply to this em
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27431999
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = f
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27418136
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +442,29 @@ function parseOpts(options, resolvedTarget) {
console.warn('Bu
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27270342
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = fu
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27267702
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -542,5 +653,12 @@ module.exports.help = function() {
console.log('\'--versionCode=#\
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27267568
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +589,60 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch) {
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27259466
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = f
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704510
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -542,5 +653,12 @@ module.exports.help = function() {
console.log('\'--versionCode=#\'
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704402
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +589,60 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704343
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = fu
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704092
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +442,29 @@ function parseOpts(options, resolvedTarget) {
console.warn('Bui
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/164
CB-8484: Adds support creating signed archives for Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android
46 matches
Mail list logo
