[GitHub] stevedlawrence opened a new pull request #166: Change expression result type coercion to be a warning

2019-01-16 Thread GitBox
stevedlawrence opened a new pull request #166: Change expression result type coercion to be a warning URL: https://github.com/apache/incubator-daffodil/pull/166 Commit a2f56a3f44 modified expression coercion to be strict about the result type of an expression matching the expected type.

[GitHub] ltapilot opened a new pull request #167: Daffodil 2051 tests broken in windows

2019-01-16 Thread GitBox
ltapilot opened a new pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167 Remaining tests now fixed. Should be platform and OS independent. This is an automated m

[GitHub] mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows

2019-01-16 Thread GitBox
mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248490624 ## File path: daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/AG.tdml ## @@ -24

[GitHub] mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows

2019-01-16 Thread GitBox
mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248491876 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml

[GitHub] stevedlawrence commented on a change in pull request #167: Daffodil 2051 tests broken in windows

2019-01-17 Thread GitBox
stevedlawrence commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248674418 ## File path: daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/AG.tdml ## @

[GitHub] stevedlawrence commented on a change in pull request #167: Daffodil 2051 tests broken in windows

2019-01-17 Thread GitBox
stevedlawrence commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248675800 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml

[GitHub] mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows

2019-01-17 Thread GitBox
mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248491876 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml

[GitHub] mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows

2019-01-17 Thread GitBox
mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248681966 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml

[GitHub] mbeckerle commented on issue #167: Daffodil 2051 tests broken in windows

2019-01-17 Thread GitBox
mbeckerle commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455183662 The travis CI build failed due to rat check failure - a file was introduced that needs an apache license banner I believe. ---

[GitHub] stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows

2019-01-17 Thread GitBox
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455184370 That rat failure was introduced in commit 912f7d2b73 and we missed it. It was then fixed as part of the next commit 69bb0a185e, bu

[GitHub] stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows

2019-01-17 Thread GitBox
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455186678 Also, apparently TravisCI now supports windows: https://blog.travis-ci.com/2018-10-11-windows-early-release It might

[GitHub] stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows

2019-01-17 Thread GitBox
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455187436 Actually, it looking more closing, TravisCI does not support java/scala yet, so we'll have to hold off on that. -

[GitHub] stevedlawrence merged pull request #165: Update README to require Java 8+

2019-01-17 Thread GitBox
stevedlawrence merged pull request #165: Update README to require Java 8+ URL: https://github.com/apache/incubator-daffodil/pull/165 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] stevedlawrence merged pull request #166: Change expression result type coercion to be a warning

2019-01-17 Thread GitBox
stevedlawrence merged pull request #166: Change expression result type coercion to be a warning URL: https://github.com/apache/incubator-daffodil/pull/166 This is an automated message from the Apache Git Service. To respond

[GitHub] stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows

2019-01-18 Thread GitBox
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455574596 Looks like the ratCheck is still failing. Can you please look into that? I think you maybe just need to fetch the latest and rebas

[GitHub] stevedlawrence merged pull request #167: Daffodil 2051 tests broken in windows

2019-01-18 Thread GitBox
stevedlawrence merged pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] jadams-tresys opened a new pull request #168: Keep line/column info for Daffodil tests

2019-01-18 Thread GitBox
jadams-tresys opened a new pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168 We had been adding line and column attributes to the schemas we were testing against in order to provide more helpful error messages. These

[GitHub] stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests

2019-01-22 Thread GitBox
stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249778945 ## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ##

[GitHub] stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests

2019-01-22 Thread GitBox
stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249779770 ## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ##

[GitHub] stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests

2019-01-22 Thread GitBox
stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249777949 ## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilConstructingLoader.scala #

[GitHub] stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests

2019-01-22 Thread GitBox
stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249782726 ## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ##

[GitHub] jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests

2019-01-22 Thread GitBox
jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249798609 ## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilConstructingLoader.scala ##

[GitHub] jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests

2019-01-22 Thread GitBox
jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249801959 ## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ##

[GitHub] stevedlawrence opened a new pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers

2019-01-22 Thread GitBox
stevedlawrence opened a new pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers URL: https://github.com/apache/incubator-daffodil/pull/169 - A bug in scala-xml caused line numbers to be reset to zero after parsing CDATA and processing instructions.

[GitHub] jadams-tresys commented on a change in pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers

2019-01-22 Thread GitBox
jadams-tresys commented on a change in pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers URL: https://github.com/apache/incubator-daffodil/pull/169#discussion_r249933776 ## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/Daffodi

[GitHub] stevedlawrence merged pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers

2019-01-23 Thread GitBox
stevedlawrence merged pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers URL: https://github.com/apache/incubator-daffodil/pull/169 This is an automated message from the Apache Git Servi

[GitHub] jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests

2019-01-23 Thread GitBox
jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r250242945 ## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ##

[GitHub] jadams-tresys merged pull request #168: Keep line/column info for Daffodil tests

2019-01-23 Thread GitBox
jadams-tresys merged pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ltapilot opened a new pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-24 Thread GitBox
ltapilot opened a new pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170 DAFFODIL-2058 This is an automated message from the Apache

[GitHub] jadams-tresys opened a new pull request #171: Added additional note to UPA violation errors

2019-01-24 Thread GitBox
jadams-tresys opened a new pull request #171: Added additional note to UPA violation errors URL: https://github.com/apache/incubator-daffodil/pull/171 In cases where choice branches have entirely optional content it wasn't clear why a UPA was occurring. I have added a note to the SDE/SDW

[GitHub] stevedlawrence opened a new pull request #172: Make XML comparisions more memory efficient

2019-01-25 Thread GitBox
stevedlawrence opened a new pull request #172: Make XML comparisions more memory efficient URL: https://github.com/apache/incubator-daffodil/pull/172 Commit a3e15e665f changed the XML comparison to always use the computeDiffOne function, rather than only when differences were found in

[GitHub] mbeckerle commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-25 Thread GitBox
mbeckerle commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251139177 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunab

[GitHub] mbeckerle commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-25 Thread GitBox
mbeckerle commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251139108 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunab

[GitHub] stevedlawrence commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-28 Thread GitBox
stevedlawrence commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251393696 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLI

[GitHub] jadams-tresys merged pull request #171: Added additional note to UPA violation errors

2019-01-28 Thread GitBox
jadams-tresys merged pull request #171: Added additional note to UPA violation errors URL: https://github.com/apache/incubator-daffodil/pull/171 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] stevedlawrence commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-28 Thread GitBox
stevedlawrence commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251411702 ## File path: build.sbt ## @@ -139,6 +139,7 @@ lazy val commonSetti

[GitHub] stevedlawrence merged pull request #172: Make XML comparisions more memory efficient

2019-01-28 Thread GitBox
stevedlawrence merged pull request #172: Make XML comparisions more memory efficient URL: https://github.com/apache/incubator-daffodil/pull/172 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] mbeckerle commented on issue #158: Daffodil 1080 sequences and separators - preliminary review

2019-01-28 Thread GitBox
mbeckerle commented on issue #158: Daffodil 1080 sequences and separators - preliminary review URL: https://github.com/apache/incubator-daffodil/pull/158#issuecomment-458179666 Closing. This was never intended to be merged. It's just to gather comments. --

[GitHub] mbeckerle closed pull request #158: Daffodil 1080 sequences and separators - preliminary review

2019-01-28 Thread GitBox
mbeckerle closed pull request #158: Daffodil 1080 sequences and separators - preliminary review URL: https://github.com/apache/incubator-daffodil/pull/158 This is an automated message from the Apache Git Service. To respond

[GitHub] ltapilot commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-28 Thread GitBox
ltapilot commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251567248 ## File path: build.sbt ## @@ -139,6 +139,7 @@ lazy val commonSettings =

[GitHub] stevedlawrence commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-28 Thread GitBox
stevedlawrence commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251569006 ## File path: build.sbt ## @@ -139,6 +139,7 @@ lazy val commonSetti

[GitHub] ltapilot commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-28 Thread GitBox
ltapilot commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251569241 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunabl

[GitHub] ltapilot commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-28 Thread GitBox
ltapilot commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251569553 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunabl

[GitHub] jadams-tresys opened a new pull request #173: Allow implicit conversion of string to HexBinary

2019-01-28 Thread GitBox
jadams-tresys opened a new pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173 DAFFODIL-2056 This is an automated message from the Apache Git Service.

[GitHub] stevedlawrence commented on a change in pull request #173: Allow implicit conversion of string to HexBinary

2019-01-28 Thread GitBox
stevedlawrence commented on a change in pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173#discussion_r251584674 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/ConverterOps2.scala

[GitHub] jadams-tresys commented on a change in pull request #173: Allow implicit conversion of string to HexBinary

2019-01-28 Thread GitBox
jadams-tresys commented on a change in pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173#discussion_r251588290 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/ConverterOps2.scala

[GitHub] stevedlawrence commented on a change in pull request #173: Allow implicit conversion of string to HexBinary

2019-01-29 Thread GitBox
stevedlawrence commented on a change in pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173#discussion_r251809757 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/ConverterOps2.scala

[GitHub] jadams-tresys commented on a change in pull request #173: Allow implicit conversion of string to HexBinary

2019-01-29 Thread GitBox
jadams-tresys commented on a change in pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173#discussion_r251820038 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/ConverterOps2.scala

[GitHub] stevedlawrence commented on a change in pull request #173: Allow implicit conversion of string to HexBinary

2019-01-29 Thread GitBox
stevedlawrence commented on a change in pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173#discussion_r251822940 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/XSHexBinary.scala #

[GitHub] stevedlawrence opened a new pull request #174: Update copyright to 2019

2019-01-29 Thread GitBox
stevedlawrence opened a new pull request #174: Update copyright to 2019 URL: https://github.com/apache/incubator-daffodil/pull/174 DAFFODIL-2060 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] jadams-tresys commented on a change in pull request #173: Allow implicit conversion of string to HexBinary

2019-01-29 Thread GitBox
jadams-tresys commented on a change in pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173#discussion_r251830323 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/XSHexBinary.scala ##

[GitHub] stevedlawrence merged pull request #174: Update copyright to 2019

2019-01-29 Thread GitBox
stevedlawrence merged pull request #174: Update copyright to 2019 URL: https://github.com/apache/incubator-daffodil/pull/174 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] stevedlawrence merged pull request #170: Fixed CLI integration tests so that they run properly on Windows.

2019-01-29 Thread GitBox
stevedlawrence merged pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170 This is an automated message from the Apache Git Service.

[GitHub] stevedlawrence opened a new pull request #175: Bump version to 2.3.0

2019-01-29 Thread GitBox
stevedlawrence opened a new pull request #175: Bump version to 2.3.0 URL: https://github.com/apache/incubator-daffodil/pull/175 DAFFODIL-2061 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] jadams-tresys merged pull request #173: Allow implicit conversion of string to HexBinary

2019-01-29 Thread GitBox
jadams-tresys merged pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jadams-tresys opened a new pull request #176: Add better error message for '/' vs 'div'

2019-01-29 Thread GitBox
jadams-tresys opened a new pull request #176: Add better error message for '/' vs 'div' URL: https://github.com/apache/incubator-daffodil/pull/176 Suggests using 'div' instead of '/' when this error is detected by the expression parser. DAFFODIL-2042 -

[GitHub] jadams-tresys commented on issue #176: Add better error message for '/' vs 'div'

2019-01-29 Thread GitBox
jadams-tresys commented on issue #176: Add better error message for '/' vs 'div' URL: https://github.com/apache/incubator-daffodil/pull/176#issuecomment-458658631 While it is nice to have a more helpful error message, I imagine that this is just one of several edge cases, not to mention th

[GitHub] stevedlawrence commented on a change in pull request #176: Add better error message for '/' vs 'div'

2019-01-29 Thread GitBox
stevedlawrence commented on a change in pull request #176: Add better error message for '/' vs 'div' URL: https://github.com/apache/incubator-daffodil/pull/176#discussion_r251967995 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/DFDLExpressionParser.scala ###

[GitHub] jadams-tresys commented on a change in pull request #176: Add better error message for '/' vs 'div'

2019-01-29 Thread GitBox
jadams-tresys commented on a change in pull request #176: Add better error message for '/' vs 'div' URL: https://github.com/apache/incubator-daffodil/pull/176#discussion_r251978937 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/DFDLExpressionParser.scala

[GitHub] jadams-tresys commented on a change in pull request #176: Add better error message for '/' vs 'div'

2019-01-29 Thread GitBox
jadams-tresys commented on a change in pull request #176: Add better error message for '/' vs 'div' URL: https://github.com/apache/incubator-daffodil/pull/176#discussion_r251979769 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/DFDLExpressionParser.scala

[GitHub] stevedlawrence commented on a change in pull request #176: Add better error message for '/' vs 'div'

2019-01-29 Thread GitBox
stevedlawrence commented on a change in pull request #176: Add better error message for '/' vs 'div' URL: https://github.com/apache/incubator-daffodil/pull/176#discussion_r251990530 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/DFDLExpressionParser.scala ###

[GitHub] jadams-tresys commented on a change in pull request #176: Add better error message for '/' vs 'div'

2019-01-29 Thread GitBox
jadams-tresys commented on a change in pull request #176: Add better error message for '/' vs 'div' URL: https://github.com/apache/incubator-daffodil/pull/176#discussion_r252010383 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/DFDLExpressionParser.scala

[GitHub] jadams-tresys closed pull request #176: Add better error message for '/' vs 'div'

2019-01-30 Thread GitBox
jadams-tresys closed pull request #176: Add better error message for '/' vs 'div' URL: https://github.com/apache/incubator-daffodil/pull/176 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] jadams-tresys opened a new pull request #177: Added note about why 2 tests fail on IBM

2019-02-06 Thread GitBox
jadams-tresys opened a new pull request #177: Added note about why 2 tests fail on IBM URL: https://github.com/apache/incubator-daffodil/pull/177 DAFFODIL-2017 This is an automated message from the Apache Git Service. To resp

[GitHub] jadams-tresys commented on issue #177: Added note about why 2 tests fail on IBM

2019-02-06 Thread GitBox
jadams-tresys commented on issue #177: Added note about why 2 tests fail on IBM URL: https://github.com/apache/incubator-daffodil/pull/177#issuecomment-461128333 Took me a bit to get the IBMCrossTester up and running and once I did I realized that the tests didn't need to be updated in ord

[GitHub] ltapilot opened a new pull request #178: Created Windows MSI installer package.

2019-02-06 Thread GitBox
ltapilot opened a new pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178 DAFFODIL-2047 This is an automated message from the Apache Git Service. To respond to t

[GitHub] stevedlawrence commented on issue #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on issue #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#issuecomment-461417075 The ratCheck failed. Can you please run that and add apache licenses to new files? -

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254693651 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254712351 ## File path: daffodil-cli/src/windows/Product_en-us.wxl ## @@ -0,0 +1,37 @@ + +http://schemas

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254691980 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254687776 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254697000 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254691802 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254701119 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254685805 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254685240 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254697838 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254698420 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254683792 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254694044 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254690544 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254684523 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254711706 ## File path: daffodil-cli/src/windows/Product_en-us.wxl ## @@ -0,0 +1,37 @@ + +http://schemas

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254683117 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254698989 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254688011 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254681938 ## File path: daffodil-cli/build.sbt ## @@ -26,10 +31,9 @@ enablePlugins(RpmPlugin) executabl

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254692875 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254708950 ## File path: daffodil-cli/src/windows/DisclaimerDlg_DFDL.wxs ## @@ -0,0 +1,32 @@ + +http://sc

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254711100 ## File path: daffodil-cli/src/windows/Product_en-us.wxl ## @@ -0,0 +1,37 @@ + +http://schemas

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254722041 ## File path: daffodil-cli/src/windows/Product.wxs ## @@ -0,0 +1,376 @@ + Review comment:

[GitHub] stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254699303 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Som

[GitHub] stevedlawrence commented on issue #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
stevedlawrence commented on issue #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#issuecomment-461465493 > File daffodil-cli/src/windows/Product.wxs should not have been included in this commit. Please remove. Please delete thi

[GitHub] jadams-tresys opened a new pull request #179: Return xs:decimal when dividing xs:long

2019-02-07 Thread GitBox
jadams-tresys opened a new pull request #179: Return xs:decimal when dividing xs:long URL: https://github.com/apache/incubator-daffodil/pull/179 Originally dividing xs:long was returning a double, but it should have been returning a decimal instead. DAFFODIL-2063

[GitHub] jadams-tresys merged pull request #177: Added note about why 2 tests fail on IBM

2019-02-07 Thread GitBox
jadams-tresys merged pull request #177: Added note about why 2 tests fail on IBM URL: https://github.com/apache/incubator-daffodil/pull/177 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] stevedlawrence commented on a change in pull request #179: Return xs:decimal when dividing xs:long

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #179: Return xs:decimal when dividing xs:long URL: https://github.com/apache/incubator-daffodil/pull/179#discussion_r254756708 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_expressions/expressi

[GitHub] stevedlawrence commented on a change in pull request #179: Return xs:decimal when dividing xs:long

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #179: Return xs:decimal when dividing xs:long URL: https://github.com/apache/incubator-daffodil/pull/179#discussion_r254749200 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/NodeInfoUtils.scala ##

[GitHub] stevedlawrence commented on a change in pull request #179: Return xs:decimal when dividing xs:long

2019-02-07 Thread GitBox
stevedlawrence commented on a change in pull request #179: Return xs:decimal when dividing xs:long URL: https://github.com/apache/incubator-daffodil/pull/179#discussion_r254754214 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/NumericOps.scala ##

[GitHub] ltapilot commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
ltapilot commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254786291 ## File path: daffodil-cli/build.sbt ## @@ -71,3 +78,165 @@ rpmRelease := { rpmLicense := Some(lice

[GitHub] ltapilot commented on a change in pull request #178: Created Windows MSI installer package.

2019-02-07 Thread GitBox
ltapilot commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254786250 ## File path: daffodil-cli/build.sbt ## @@ -26,10 +31,9 @@ enablePlugins(RpmPlugin) executableScrip

  1   2   3   4   5   6   7   8   9   10   >