Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/424#discussion_r55780247
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -547,29 +559,72 @@ public long getRowCount
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/407#issuecomment-195138369
Updated changes LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55779800
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -294,13 +313,41 @@ public UnionAllInput
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55749381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -162,6 +162,25 @@ private IterOutcome
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55561579
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -527,6 +532,52 @@ public void testUnionAllRightEmptyJson() throws
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55561188
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -294,13 +313,41 @@ public UnionAllInput
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r9565
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -491,6 +556,25 @@ private void
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r8287
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -527,6 +532,52 @@ public void testUnionAllRightEmptyJson() throws
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r7460
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -162,6 +162,25 @@ private IterOutcome
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/420
DRILL-4479: Use varchar for default column when all_text_mode is enabâ¦
â¦led.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/416#issuecomment-194042039
Overall, LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/406#issuecomment-193971973
Agree with @jinfengni that the current fix can cause performance regression
for simpler count queries. I will change my review to -1 and let's see how to
ge
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/414#issuecomment-193960370
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 closed the pull request at:
https://github.com/apache/drill/pull/415
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/415#issuecomment-193901238
oops ... sorry, closing this and will reopen against the correct JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/415#issuecomment-193882461
Yes, I can do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/415
DRILL-4474: Use varchar for default column when all_text_mode is enabâ¦
â¦led.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/406#issuecomment-192531157
+1. Yes, seems like the project was not being checked at all and the
nullability check did not work for expressions inside the count aggregate.
---
If your
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/392#issuecomment-192361296
+1.
I understand based on conversation with @adeneche (before he went on
vacation) that he could not easily repro through a unit test. However,
functional
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54690939
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed to the
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54689413
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,38 +94,110 @@ public DrillFunctionRegistry
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54688304
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,38 +94,110 @@ public DrillFunctionRegistry
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/379#issuecomment-185934019
LGTM +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/379#discussion_r53386823
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java
---
@@ -34,6 +34,7 @@
import
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/379#discussion_r53340898
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -87,9 +87,6 @@ public ScanBatch getBatch
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/379#discussion_r53335185
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java
---
@@ -35,6 +35,8 @@
public interface GroupScan extends
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/376#issuecomment-185074140
Simplified the state management in FileSelection. @jacques-n is this close
enough to what you intended ? Also, want to note that this JIRA is motivated
by a
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/376#discussion_r53120105
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -47,6 +49,14 @@
public List files;
public
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/376#issuecomment-184848577
Updated PR after addressing review comment from @jacques-n
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/376#discussion_r53056521
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -529,6 +549,36 @@ public long getRowCount
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/376#discussion_r53047947
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -68,6 +79,7 @@ protected FileSelection(final
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/376#issuecomment-184481180
I have incorporated the review comments and updated the PR. Please take a
look when you get a chance.
---
If your project is set up for it, you can reply to this
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/376#discussion_r52864208
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -45,6 +48,10 @@
public List files;
public
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/376#discussion_r52864039
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -157,7 +159,20 @@ private String
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/345#issuecomment-183933804
Closing this PR in favor of updated one #376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user amansinha100 closed the pull request at:
https://github.com/apache/drill/pull/345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/376
DRILL-4287: During initial DrillTable creation don't read the metadatâ¦
â¦a cache file; instead do it during ParquetGroupScan.
Maintain state in FileSelection to keep track of wh
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/371#issuecomment-183125598
Updated patch looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/340#issuecomment-183070887
+1. I gave a couple of comments; overall LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/340#discussion_r52672160
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
---
@@ -106,6 +106,60 @@ public void
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52563417
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -791,6 +799,43 @@ public FileGroupScan clone
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52558347
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -791,6 +799,43 @@ public FileGroupScan clone
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52557443
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,108
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52557262
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScan.java
---
@@ -128,4 +128,12 @@ public int getOperatorType
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/340#discussion_r52186222
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/WindowPOP.java
---
@@ -33,26 +35,29 @@
private final NamedExpression
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/340#discussion_r52185980
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/FrameSupportTemplate.java
---
@@ -134,44 +142,67 @@ private void
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/345#discussion_r51528494
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -338,8 +354,14 @@ private boolean hasSingleValue
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/345#discussion_r51528367
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -118,13 +133,34 @@ public boolean apply(@Nullable
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/346#issuecomment-17653
+1. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/345
DRILL-4287: During initial DrillTable creation don't read the metadatâ¦
â¦a cache file; instead do it during ParquetGroupScan.
Maintain state in FileSelection to keep track of wh
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/328#issuecomment-174415824
Revised patch looks good to me..other than a few minor comments. +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/328#discussion_r50657159
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -382,5 +381,28 @@ protected
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/328#discussion_r50656611
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -82,11 +101,19 @@ public int
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/328#discussion_r50302251
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -84,9 +99,17 @@ public int
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/328#discussion_r50300305
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -78,71 +94,68 @@ public PruneScanRule
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/322#issuecomment-172619347
Renaming sounds fine to avoid misinterpretation. +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/322#issuecomment-172038682
Overall refactoring looks ok. One thing that needs some clarity: Is the
definition of default frame 'between unbounded preceding and current row' ? If
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/319#issuecomment-171842104
+1 . For functional testing we should try to have a similar scenario with
skew in the data for the build side of the HashJoin such that some minor
fragments get 0
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/319#discussion_r49780505
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerTemplate.java
---
@@ -286,7 +286,7 @@ public void
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/320#issuecomment-170177833
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/318#issuecomment-169842524
+1 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/305#issuecomment-165635050
+1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/301#issuecomment-164649823
+1 for the DRILL-4194 patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/288#discussion_r47124992
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -899,4 +900,35 @@ public void testUnionAllInWith() throws Exception
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/285
DRILL-4146: Concurrent queries hang in planner. Fix is in Calcite (Câ¦
â¦ALCITE-874).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/279
DRILL-4119: Modify hash32 functions to combine the msb and lsb bytes â¦
â¦of a 64-bit hash value (previously, we were casting to integer).
- Use this new set of functions (for all
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/255#discussion_r44988307
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -116,20 +117,32 @@ public DrillSqlWorker
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/255#discussion_r44964325
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -116,20 +117,32 @@ public DrillSqlWorker
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/231#issuecomment-153791070
I had 1 question about the upper limit on the numPartitions but changes
look good overall. +1.
---
If your project is set up for it, you can reply to this
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/231#discussion_r43906151
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java
---
@@ -87,6 +87,9 @@
@JsonProperty("co
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/230#issuecomment-153780284
+1. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/222#issuecomment-153504706
+1. Per previous comments, there is room for improvement in terms of code
organization and reducing the number of passes which I understand will be
covered by
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/222#discussion_r43789532
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFramer.java
---
@@ -38,19 +40,33 @@ void setup(final List
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/230#discussion_r43706257
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -166,16 +174,28 @@ protected void
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/230#discussion_r43706195
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -163,7 +163,9 @@ private ParquetTableMetadata_v1
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/222#issuecomment-152853864
Overall, there are 2 categories of the window functions: one that require
all batches of the partition before they can start processing and second that
can start
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/222#discussion_r43586353
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java
---
@@ -287,6 +318,36 @@ private int
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/222#discussion_r43586273
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java
---
@@ -287,6 +318,36 @@ private int
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/222#discussion_r43586223
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java
---
@@ -287,6 +318,36 @@ private int
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/220
DRILL-3937: Handle the case where min/max columns in metadata cache fâ¦
â¦ile are Maps.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/209#issuecomment-149369397
Gave one minor comment; rest of the changes look good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/209#discussion_r42435960
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
---
@@ -305,6 +313,105 @@ public
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/208#issuecomment-149257300
@zfong, please see my last explanation about why the repro does not occur
at small scale. Hence, adding a unit test won't help ... unless the static
constant
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/208#issuecomment-149123146
@mehant , yes the underlying issue is simple: the null bit vector for the
NullableDateVector is allocated at 4096 bytes (actually, the UInt1Vector is
used for this
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/208
DRILL-3947: Use setSafe() for date, time, timestamp types while populâ¦
â¦ating pruning vector (other types were already using setSafe).
You can merge this pull request into a Git repository
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/196#discussion_r41713896
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -44,6 +45,10 @@
public List files;
public
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/196
DRILL-3918: During expansion save the metadata for future use.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amansinha100/incubator-drill
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/195
DRILL-3917: During file selection expansion, get the metadata for theâ¦
⦠directory by reading the metadata file.
Ensure the selection root format is the same as the format of the
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/186#discussion_r41053297
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -716,6 +726,7 @@ public String toString
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/186#discussion_r41035620
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -716,6 +726,7 @@ public String toString
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/185#issuecomment-144884113
+1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/185#discussion_r40981727
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java
---
@@ -319,16 +319,12 @@ public ScanStats getScanStats
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/179
Refresh metadata bugs 1
This PR is a combination of 3 issues that are directly or indirectly
related to the metadata caching.
You can merge this pull request into a Git repository by running
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/176#discussion_r40715318
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -542,7 +542,9 @@ public void testFilterPushDownOverUnionAll() throws
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/176#discussion_r40715222
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java
---
@@ -133,7 +133,7 @@ public static RuleSet
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/172#issuecomment-143879844
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/172#discussion_r40605696
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
@@ -615,11 +608,18 @@ private
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/128#issuecomment-143563550
+1. This review request somehow slipped through the cracks. Sorry about
that.
---
If your project is set up for it, you can reply to this email and have your
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/169#issuecomment-143380757
+1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40445053
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -26,4 +30,34 @@
public void
401 - 500 of 523 matches
Mail list logo
