Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184218887
--- Diff: pom.xml ---
@@ -1333,6 +1353,12 @@
+
--- End diff --
I meant that it can
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184024460
--- Diff: pom.xml ---
@@ -1164,7 +1164,27 @@
io.dropwizard.metrics
metrics-core
-4.0.2
+4.1.0
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184066086
--- Diff: pom.xml ---
@@ -1333,6 +1353,12 @@
+
--- End diff --
I thought that Drill uses
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1189
@vrozov I have replaced `com.codahale.metrics` with last
`io.dropwizard.metrics`.
Please review.
---
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1226#discussion_r183763991
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
@@ -178,6 +178,12 @@ public RuleSet getRules
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1226#discussion_r183764377
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -238,26 +238,27 @@ protected DrillRel
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183635975
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java
---
@@ -0,0 +1,195
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183558185
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetGroupScan.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183251213
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/RowGroupInfo.java
---
@@ -0,0 +1,95 @@
+/*
+* Licensed to the Apache
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183644277
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScanStatistics.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183646149
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/TestHiveDrillNativeParquetReader.java
---
@@ -0,0 +1,247
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183253923
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeParquetRowGroupScan.java
---
@@ -0,0 +1,130
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183566717
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetGroupScan.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183551693
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetGroupScan.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183250175
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeParquetScan.java
---
@@ -1,114 +1,223
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183647695
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/ConvertHiveParquetScanToDrillParquetScan.java
---
@@ -166,25
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183632379
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
---
@@ -64,16 +68,17 @@ public static
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183633623
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
---
@@ -147,10 +147,12 @@ CloseableRecordBatch
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183644581
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/TestHiveDrillNativeParquetReader.java
---
@@ -0,0 +1,247
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183253252
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRowGroupScan.java
---
@@ -40,31 +36,26 @@
import
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183633688
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java
---
@@ -0,0 +1,195
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183633517
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java ---
@@ -156,43 +157,74 @@ public static boolean isPartitionColumn
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1214#discussion_r183251188
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/RowGroupInfo.java
---
@@ -0,0 +1,95 @@
+/*
+* Licensed to the Apache
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1216#discussion_r183329162
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/logical/TestTransitiveClosure.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1229
@kkhatua These quotation marks are in `drill-java-exec package`.
There are some more italics quotation marks in the project. They are in
`package-info.java`, `TestScripts.java
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/1226
DRILL-3855: Enable FilterSetOpTransposeRule, DrillProjectSetOpTranspoâ¦
â¦seRule
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vdiravka
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/1216
DRILL-6173: Support transitive closure during filter push down and paâ¦
â¦rtition pruning
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1184#discussion_r181472373
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -509,15 +509,15 @@ public long getTwoAsLong(int index) {
public
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1205
@Wizwizard Please follow this guideline while opening PR:
https://drill.apache.org/docs/apache-drill-contribution-guidelines/#step-3:-get-your-code-reviewed-and-committed-to-the-project
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1182#discussion_r178572285
--- Diff: pom.xml ---
@@ -66,6 +66,7 @@
4096
4096
+-Xdoclint:none
--- End diff --
Thanks
---
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1182#discussion_r178561972
--- Diff: pom.xml ---
@@ -66,6 +66,7 @@
4096
4096
+-Xdoclint:none
--- End diff --
Do we need a task (new
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178456935
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -780,17 +780,31 @@ public void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178456861
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -61,6 +60,7 @@
import
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178255699
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -61,6 +60,7 @@
import
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178255942
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -780,17 +780,31 @@ public void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178072549
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -27,6 +27,7 @@
import
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178070635
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -780,17 +783,42 @@ public void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178071020
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -35,6 +36,7 @@
import java.util.Map
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178009588
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -797,6 +797,24 @@ public void
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1190
@pushpendra-jaiswal-90
You already have +1 from Drill committer :)
Your changes will be merged to master branch soon.
---
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1189
@vrozov I understand what you mean: `com.codahale` isn't updated for a long
time
https://mvnrepository.com/artifact/com.codahale.metrics/metrics-core,
but `io.dropwizard.metrics` is updated
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1189
@vrozov Drill doesn't use `io.dropwizard.metrics` at all and it is in
conflict with Drill's `com.codahale.metrics` (misspoke was in PR's
description). Even Hive uses it only for own unit test, so
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r177154051
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -797,6 +797,24 @@ public void
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1166
@rajrahul Unit test from your PR relies on particular timezone similar to
`TestParquetWriter.testImpalaParquetBinaryAsTimeStamp_DictChange`.
Could you please edit test case for working
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1189
@vrozov Could you please review this, since you were the reviewer for
DRILL-5978 (Hive upgrade)
---
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/1189
DRILL-6282: Excluding io.dropwizard.metrics dependencies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vdiravka/drill DRILL-6282
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1185#discussion_r176891810
--- Diff: exec/jdbc-all/pom.xml ---
@@ -559,7 +559,7 @@
This is likely due to you adding new
dependencies to a java-exec
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1186
+1
Thank you for improving the old code
---
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176608901
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
-
+
org.codehaus.mojo
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176178853
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
-
+
org.codehaus.mojo
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176195852
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
-
+
org.codehaus.mojo
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176165870
--- Diff:
common/src/main/java/org/apache/drill/common/scanner/BuildTimeScan.java ---
@@ -118,10 +118,10 @@ private static void save(ScanResult scanResult
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176195052
--- Diff: common/pom.xml ---
@@ -113,20 +113,10 @@
org.codehaus.mojo
exec-maven-plugin
-1.2.1
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1152
+1
---
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1158
@priteshm @priteshm I have created a Jira for above mentioned issue:
[DRILL-6258](https://issues.apache.org/jira/browse/DRILL-6258)
---
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1158#discussion_r174489502
--- Diff: distribution/pom.xml ---
@@ -324,6 +324,14 @@
org.apache.hbase
hbase-protocol
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1166
@parthchandra I have compared meta of files from
`TestParquetWriter.testImpalaParquetBinaryAsTimeStamp_DictChange` and the meta
from Rahul's dataset and found that test case indeed makes a query
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1158#discussion_r174125821
--- Diff: distribution/pom.xml ---
@@ -324,6 +324,14 @@
org.apache.hbase
hbase-protocol
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/1158
DRILL-6145: Implement Hive MapR-DB JSON handler
@sohami, @vrozov Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vdiravka/drill
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1146#discussion_r171912800
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java
---
@@ -174,7 +174,7 @@ public
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1140
@arina-ielchiieva Current implementation of creating schema for Drill Hive
embedded metastore doesn't allow to create transactional tables. That's why I
have created a separate Jira task to update
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1140
@arina-ielchiieva Please review
---
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/1140
DRILL-6195: Quering Hive non-partitioned transactional tables via Drill
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vdiravka/drill DRILL
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/
@vrozov Thank you for CR.
Commits are squashed, Jira and PR are renamed to 2.3.2 version upgrade.
---
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r169397851
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r169397714
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -34,28 +34,47 @@
hive-exec
compile
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r169397544
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
---
@@ -143,7 +143,7 @@ private void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r169397509
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
---
@@ -86,7 +86,7 @@
protected
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r167945192
--- Diff: common/pom.xml ---
@@ -45,6 +45,7 @@
org.apache.calcite
calcite-core
+ ${calcite.version}
--- End
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r167947402
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r167944958
--- Diff: contrib/storage-hive/core/pom.xml ---
@@ -58,6 +58,10 @@
commons-codec
commons-codec
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r167946336
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +512,49 @@ public static boolean
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1108#discussion_r166727342
--- Diff:
contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java
---
@@ -175,9 +175,8 @@ public void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1108#discussion_r166468585
--- Diff:
contrib/storage-kudu/src/main/java/org/apache/drill/exec/store/kudu/KuduSubScan.java
---
@@ -143,7 +133,7 @@ public String getTableName
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166650425
--- Diff: contrib/storage-hive/core/pom.xml ---
@@ -58,6 +58,10 @@
commons-codec
commons-codec
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166651052
--- Diff: common/pom.xml ---
@@ -45,6 +45,7 @@
org.apache.calcite
calcite-core
+ ${calcite.version}
--- End
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r10444
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +510,52 @@ public static boolean
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166651134
--- Diff: contrib/storage-hive/core/pom.xml ---
@@ -101,6 +105,7 @@
org.apache.calcite
calcite-core
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166679633
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166672700
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r19844
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +510,52 @@ public static boolean
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166683550
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r10333
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +510,52 @@ public static boolean
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166246336
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestSqlStdBasedAuthorization.java
---
@@ -100,7 +103,9
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166282137
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveMetadataProvider.java
---
@@ -264,6 +265,10 @@ private HiveStats
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166247024
--- Diff: pom.xml ---
@@ -884,13 +884,33 @@
io.netty
netty-all
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166251399
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +509,51 @@ public static boolean
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/
Upgrade drill-hive libraries to 2.1.1 version.
Updating hive properties for tests and resolving dependencies and API
conflicts:
* Allowing of using Hive's own calcite-core and avatica
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/916
@arina-ielchiieva You are right.
According to SQL spec after resolving
[CALCITE-2055](https://issues.apache.org/jira/browse/CALCITE-2055) and
Drill-Calcite upgrade Drill and Calcite don't
Github user vdiravka closed the pull request at:
https://github.com/apache/drill/pull/916
---
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r165023581
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java ---
@@ -568,6 +570,22 @@ public void nullMixedComparatorEqualJoinHelper(final
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162292084
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java
---
@@ -38,13 +37,16 @@
import
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162292571
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -19,19 +19,17 @@
package
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162293231
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -535,4 +541,8 @@ public void close
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162289830
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/JoinTestBase.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162292685
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -19,20 +19,22 @@
package
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162293578
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java
---
@@ -228,4 +228,20 @@ public WritableBatch
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162294377
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/JoinTestBase.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r161510606
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java
---
@@ -354,9 +354,9 @@ public void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r161510835
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +339,55 @@ public void
1 - 100 of 372 matches
Mail list logo
