[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646237 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BitConnectionConfig.java --- @@ -46,16 +47,40 @@ protected BitConnectionConfig

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646955 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java --- @@ -243,4 +247,43 @@ public SaslMessage

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111647280 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -135,20 +137,33 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111647054 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/SaslProperties.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646424 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnectionConfig.java --- @@ -30,6 +33,14 @@ private final

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111651798 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java --- @@ -224,4 +237,67 @@ public void close

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111676760 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -335,8 +350,27 @@ public BitToUserHandshake getHandshakeResponse

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111651753 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/SaslBackendWrapper.java --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111645872 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BitConnectionConfig.java --- @@ -46,16 +47,40 @@ protected BitConnectionConfig

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r110783153 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r110788792 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/SchemaBuilder.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r110781500 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r110801295 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/DirectRowSet.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111003542 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/DirectRowSet.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r110794477 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetBuilder.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111005446 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/DirectRowSet.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r110783017 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r110783456 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #807: DRILL-5415: Improve Fixture Builder to configure cl...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/807#discussion_r110512304 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/FixtureBuilder.java --- @@ -117,7 +122,27 @@ public FixtureBuilder configProperty(String key

[GitHub] drill pull request #807: DRILL-5415: Improve Fixture Builder to configure cl...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/807#discussion_r110512302 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -203,7 +219,15 @@ private void createConfig(FixtureBuilder builder

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/809 Drill-4335: C++ client changes for supporting encryption using SASL You can merge this pull request into a Git repository by running: $ git pull https://github.com/sohami/drill DRILL-4335-C

[GitHub] drill pull request #807: DRILL-5415: Improve Fixture Builder to configure cl...

GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/807 DRILL-5415: Improve Fixture Builder to configure client properties an… …d keep collection type properties for server You can merge this pull request into a Git repository by running: $ git

[GitHub] drill issue #788: DRILL-5318: Sub-operator test fixture

Github user sohami commented on the issue: https://github.com/apache/drill/pull/788 Thanks for the changes. LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request #788: DRILL-5318: Sub-operator test fixture

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/788#discussion_r109555392 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java --- @@ -271,6 +276,91 @@ public QuerySummary run() throws Exception

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r108758552 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/HyperRowSetImpl.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r108777101 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetPrinter.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r108808598 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/AbstractSingleRowSet.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r108823826 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetWriterImpl.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r108768096 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetUtilities.java --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r108814142 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/DirectRowSet.java --- @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #788: DRILL-5318: Sub-operator test fixture

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/788#discussion_r108563545 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java --- @@ -271,6 +276,91 @@ public QuerySummary run() throws Exception

[GitHub] drill issue #772: DRILL-5316: Check drillbits size before we attempt to acce...

Github user sohami commented on the issue: https://github.com/apache/drill/pull/772 Thanks @superbstreak for the change. LGTM. +1 from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] drill pull request #772: DRILL-5316: Check drillbits size before we attempt ...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/772#discussion_r105286121 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -2143,6 +2146,9 @@ connectionStatus_t PooledDrillClientImpl::connect(const char

[GitHub] drill pull request #772: DRILL-5316: Check drillbitsVector count from zoo_ge...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/772#discussion_r104606833 --- Diff: contrib/native/client/src/clientlib/zookeeperClient.cpp --- @@ -138,6 +138,11 @@ int ZookeeperClient::getAllDrillbits(const std::string& connec

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/773 DRILL-4335: Apache Drill should support network encryption. DRILL-4335: Apache Drill should support network encryption. This pull request add's network encryption capability between Java

[GitHub] drill pull request #768: DRILL-5313: Fix build failure in C++ client

Github user sohami closed the pull request at: https://github.com/apache/drill/pull/768 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill issue #768: DRILL-5313: Fix build failure in C++ client

Github user sohami commented on the issue: https://github.com/apache/drill/pull/768 Thanks for the actual fix. I will close this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request #768: DRILL-5313: Fix build failure in C++ client

GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/768 DRILL-5313: Fix build failure in C++ client You can merge this pull request into a Git repository by running: $ git pull https://github.com/sohami/drill DRILL-5313 Alternatively you can review

[GitHub] drill issue #752: DRILL-5258: Access mock data definition from SQL

Github user sohami commented on the issue: https://github.com/apache/drill/pull/752 Thanks for the change. LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r103052237 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -138,9 +414,208 @@ public long getMetric(int id

[GitHub] drill issue #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on the issue: https://github.com/apache/drill/pull/753 Apart from fixing regex in ProfileParser.java, changes looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r103052249 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -138,9 +414,208 @@ public long getMetric(int id

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102587851 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -99,33 +111,83 @@ // behavior. Production default

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102600191 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ExampleTest.java --- @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102584427 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -295,8 +396,96 @@ public void close() throws Exception

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102613259 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -138,9 +414,208 @@ public long getMetric(int id

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102612813 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -42,44 +48,207 @@ public class ProfileParser

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102581476 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -295,8 +396,96 @@ public void close() throws Exception

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102610181 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -42,44 +48,207 @@ public class ProfileParser

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102603020 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -42,44 +48,207 @@ public class ProfileParser

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102589695 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -99,33 +111,83 @@ // behavior. Production default

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102618884 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -138,9 +414,208 @@ public long getMetric(int id

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102369640 --- Diff: common/src/test/java/org/apache/drill/test/DrillTest.java --- @@ -69,6 +71,25 @@ @Rule public TestName TEST_NAME = new TestName

[GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/753#discussion_r102607033 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -138,9 +414,208 @@ public long getMetric(int id

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102362622 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java --- @@ -109,7 +121,37 @@ public MockSchema(MockStorageEngine

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102336171 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/package-info.java --- @@ -60,14 +62,26 @@ * The mode is one of the supported

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102320948 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java --- @@ -89,14 +85,30 @@ public boolean supportsRead

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102294277 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/BooleanGen.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102298318 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java --- @@ -124,7 +125,7 @@ public void interpreterDateTest

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102360734 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockGroupScanPOP.java --- @@ -75,20 +76,50 @@ */ private boolean

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101175920 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -435,9 +427,14 @@ public synchronized boolean reconnect

[GitHub] drill issue #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on the issue: https://github.com/apache/drill/pull/578 Just one last comment regarding moving BitConnectionConfig file. Apart from that LGTM. +1 from my side. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r100907447 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/BitConnectionConfig.java --- @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99678863 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99257539 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java --- @@ -37,40 +37,28 @@ static final org.slf4j.Logger

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99257914 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionManager.java --- @@ -21,30 +21,28 @@ import

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99247679 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ConnectionManagerRegistry.java --- @@ -32,24 +29,19 @@ private final

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99261692 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -88,22 +129,183 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99257059 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java --- @@ -75,27 +85,106 @@ public MessageLite getResponseDefaultInstance

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99261445 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -88,22 +129,183 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99265626 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99260686 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainServer.java --- @@ -0,0 +1,175 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99256832 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControllerImpl.java --- @@ -39,36 +39,33 @@ static final org.slf4j.Logger

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99256160 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java --- @@ -89,14 +89,42 @@ public MessageLite

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99257662 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/BitConnectionConfigImpl.java --- @@ -0,0 +1,121 @@ +/** + * Licensed

[GitHub] drill issue #710: DRILL-5126: Provide simplified, unified "cluster fixture" ...

Github user sohami commented on the issue: https://github.com/apache/drill/pull/710 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r96785327 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/LogFixture.java --- @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r96785470 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java --- @@ -49,6 +57,107 @@ public class QueryBuilder

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r96785539 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java --- @@ -57,20 +166,36 @@ private final int records; private

[GitHub] drill pull request #708: DRILL-5152: Enhance the mock data source: better da...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/708#discussion_r95068660 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockSubScanPOP.java --- @@ -56,11 +79,11 @@ public MockSubScanPOP(@JsonProperty(&quo

[GitHub] drill pull request #708: DRILL-5152: Enhance the mock data source: better da...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/708#discussion_r95068500 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java --- @@ -125,9 +125,10 @@ public void init() throws

[GitHub] drill pull request #708: DRILL-5152: Enhance the mock data source: better da...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/708#discussion_r95068510 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java --- @@ -346,6 +368,7 @@ public SchemaFactory

[GitHub] drill pull request #708: DRILL-5152: Enhance the mock data source: better da...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/708#discussion_r95051613 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/ColumnDef.java --- @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #708: DRILL-5152: Enhance the mock data source: better da...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/708#discussion_r94893412 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockSubScanPOP.java --- @@ -40,12 +39,12 @@ private final String url

[GitHub] drill pull request #708: DRILL-5152: Enhance the mock data source: better da...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/708#discussion_r95051723 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/ExtendedMockRecordReader.java --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] drill pull request #708: DRILL-5152: Enhance the mock data source: better da...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/708#discussion_r95047869 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockSubScanPOP.java --- @@ -40,12 +39,12 @@ private final String url

[GitHub] drill pull request #708: DRILL-5152: Enhance the mock data source: better da...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/708#discussion_r94893846 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/IntGen.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95044899 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r94505587 --- Diff: exec/java-exec/pom.xml --- @@ -458,6 +458,12 @@ httpdlog-parser 2.4 + --- End diff -- Please fix

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95041561 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java --- @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95045450 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/FieldDef.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95046976 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java --- @@ -22,220 +22,167 @@ import

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95026609 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/FixtureBuilder.java --- @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95047142 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java --- @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95035750 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -0,0 +1,405 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95019120 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/FixtureBuilder.java --- @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/710#discussion_r95032760 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -0,0 +1,405 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r94700671 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserAuthenticationUtil.java --- @@ -0,0 +1,255 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r94862522 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/security/TestSaslExchange.java --- @@ -0,0 +1,63 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r94866946 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptionsAuthEnabled.java --- @@ -17,7 +17,10 @@ */ package

<    1   2   3   4   5   6   >