Re: [Vote] Cleaning Up Old PRs

uot; can take time, and should not be interrupted by automatically removing the PR. Thanks, Dave Oshinsky From: Aman Sinha Sent: Thursday, June 7, 2018 3:14 PM To: dev Subject: Re: [Vote] Cleaning Up Old PRs I haven't looked at Tim's survey yet but just wante

Re: [Vote] Cleaning Up Old PRs

nd a good middle ground that everyone can be happy with. Thanks, Tim ____ From: Dave Oshinsky Sent: Wednesday, June 6, 2018 6:28:39 PM To: dev@drill.apache.org Subject: Re: [Vote] Cleaning Up Old PRs Tim, It's too restrictive, unless something can be done to educate

Re: [Vote] Cleaning Up Old PRs

y flushed, I have my doubts as to whether the story would have ended the same way. Thanks, Dave Oshinsky From: Timothy Farkas Sent: Wednesday, June 6, 2018 7:07 PM To: dev@drill.apache.org Subject: Re: [Vote] Cleaning Up Old PRs Good point Dave. With this au

Re: [Vote] Cleaning Up Old PRs

others would have gotten flushed prematurely with this kind of automatic cleaning regimen. Just my 2.5 cents. Dave Oshinsky From: Timothy Farkas Sent: Wednesday, June 6, 2018 6:12 PM To: dev@drill.apache.org Subject: [Vote] Cleaning Up Old PRs

RE: [HANGOUT] Topics for 11/1/16

.9 release. The current list of > >> pending requests is at [1]. > >> > >> If Arina joins the hangout, I would like to discuss about > >> permissions on the various areas setup for dynamic UDF support. > >> > >> Thank you, > >> Sudheesh >

RE: [HANGOUT] Topics for 11/1/16

Hi Paul, Can we talk a bit about working to improve decimal type support? My related PR is waiting for review: https://issues.apache.org/jira/browse/DRILL-4834 Thanks, Dave Oshinsky -Original Message- From: Paul Rogers [mailto:prog...@maprtech.com] Sent: Monday, October 31, 2016 12:33

RE: question on failed unit test (in protobuf)

Message- From: Dave Oshinsky [mailto:doshin...@commvault.com] Sent: Friday, August 12, 2016 6:27 PM To: dev@drill.apache.org Subject: RE: question on failed unit test (in protobuf) Thanks Jinfeng, you nailed it. I added some incorrect code in GetSetVectorHelper.java for VARDECIMAL Regarding

RE: question on failed unit test (in protobuf)

tor, and a select without where clause (no filtering). That shows ability to put decimal data into the vector, and get it out. It's the filtering that is hosed at the moment. Thanks, Dave Oshinsky -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Friday, Augus

RE: question on failed unit test (in protobuf)

e ? 1 : 0; } out8 = out; } // end of eval portion of equal function. // return (out8 .value == 1); } } public void __DRILL_INIT__() throws SchemaChangeException { } } -Original Message- From: Dave Oshinsky [mailto:doshin

RE: question on failed unit test (in protobuf)

, which is protected, instead of copyFromSafe, which is public. Which piece of code is input to this generated CopierGen1 code? Dave Oshinsky The error: 0: jdbc:drill:zk=local> select employee_id, salary, commission_pct from dfs.`c:/ apache/drill-master/drill/exec/java-exec/src/test/resour

RE: question on failed unit test (in protobuf)

at index -1. Error: Missing function implementation: [equal (VARDECIMAL-REQUIRED, INT-REQUIRED)]. Full expression: --UNKNOWN EXPRESSION--.. Fragment 0:0 [Error Id: 817627e1-aa4a-4791-8dc3-2f94a73bec9f on DaveOshinsky-PC.gp.cv.commvau lt.com:31010] (state=,code=0) 0: jdbc:drill:zk=local> Dave

RE: question on failed unit test (in protobuf)

IntelliJ IDEA)? Dave Oshinsky -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Wednesday, August 10, 2016 8:59 PM To: dev Subject: Re: question on failed unit test (in protobuf) Did you follow the steps specified in this readme.txt [1]? [1] https://github.com

question on failed unit test (in protobuf)

to change something else to avoid this strange Protobuf-related failure? Thanks, Dave Oshinsky Running org.apache.drill.exec.DrillSeparatePlanningTest SLF4J: Failed toString() invocation on an object of type [org.apache.drill.exec.proto.UserProtos$RunQuery] java.lang.ExceptionInInitia

RE: Time for a 1.8 release

Rather than attempt to change that code, I made another change to CastIntDecimal.java which avoids repeated calculation of the precision when it is already provided. Please review. Dave Oshinsky -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Wednesday, Aug

RE: Time for a 1.8 release

be a very small start. Dave Oshinsky -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Wednesday, August 03, 2016 2:49 PM To: dev Subject: Re: Time for a 1.8 release I would like to propose we set Monday 8/8 as the tentative cut-off date for 1.8 release. If people

RE: Drill Hangout Topics for 07/12/2016

Please complete review of DRILL-4704: https://github.com/apache/drill/pull/517 Thanks, Dave Oshinsky -Original Message- From: Jinfeng Ni [mailto:j...@apache.org] Sent: Monday, July 11, 2016 11:49 AM To: dev; user Subject: Drill Hangout Topics for 07/12/2016 Hey, Just a reminder

RE: [GitHub] drill issue #517: DRILL-4704 fix

I ran the Windows TestDecimal unit tests with ExecConstants.java modified as suggested. The failure looks like follows: Operating system: Windows 7 Windows hack for parquet: setting hadoop.home.dir to c:\winutil\ Running org.apache.drill.exec.physical.impl.TestDecimal#testCastFromFloat Query: {

TestDecimal unit test failure on Windows?

seeing does not help to localize the problem. Thanks, Dave Oshinsky ***Legal Disclaimer*** "This communication may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distrib

RE: Time for a 1.7 release

This is a pretty basic bug affecting decimal values, with a simple fix: https://issues.apache.org/jira/browse/DRILL-4704 It would be great if it could be reviewed. -Original Message- From: Aman Sinha [mailto:amansi...@apache.org] Sent: Wednesday, June 15, 2016 3:15 PM To: dev Subject:

how to create a second pull request?

extensive changes can be made to fix it "properly"). What is the recommended course of action here? Can I create a second pull request? I don't see how to do this, without going in under a different github user. Dave Oshinsky ***

RE: generation and compilation of code at runtime?

Thanks Jinfeng, that was helpful. This web page provides ways to look at the generated source under "Debugging": http://unkrig.de/w/Janino Dave Oshinsky -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Tuesday, June 07, 2016 2:46 PM To: dev S

generation and compilation of code at runtime?

od way to debug this problem? Thanks, Dave Oshinsky ***Legal Disclaimer*** "This communication may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distribution by others is strictl

[jira] [Created] (DRILL-4704) select statement behavior is inconsistent for decimal values in parquet

Dave Oshinsky created DRILL-4704: Summary: select statement behavior is inconsistent for decimal values in parquet Key: DRILL-4704 URL: https://issues.apache.org/jira/browse/DRILL-4704 Project

RE: [DISCUSS] Remove required type

, Dave Oshinsky -Original Message- From: Jacques Nadeau [mailto:jacq...@dremio.com] Sent: Monday, March 21, 2016 11:43 PM To: dev Subject: Re: [DISCUSS] Remove required type Definitely in support of this. The required type is a huge maintenance and code complexity nightmare that provides

RE: Time for the 1.6 Release

Hello Drillers, Efficient support of decimal data in parquet files would be a plus for my organization (DRILL-4184). My pull request has been around for a few weeks, waiting for review: https://github.com/apache/drill/pull/372 Thanks, Dave Oshinsky -Original Message- From: Parth

RE: strange build problem with generated sources

m where I'm sitting with a Parquet-centric perspective. And the memory usage would be MUCH lower by treating decimals ALWAYS as variable width. Most actual decimal numbers are way smaller than the precision would indicate, in many of my test cases. Dave Oshinsky $ find . -name "*.jav

RE: strange build problem with generated sources

int value){ // DAO bits.getMutator().setSafe(index, value); } Do I need to copy any other jars? I copied everything that implements or refers to NullableDecimal28SparseVector, or so I thought. -Original Message----- From: Dave Oshinsky [mailto:doshin...@commvault.com] Se

RE: strange build problem with generated sources

erated sources Do you also need to add forceBits to the template FixedValueVectors.java ? Can you copy the line from VarLengthColumnReaders .java where you hit a compile error ? On Fri, Feb 5, 2016 at 9:26 AM, Dave Oshinsky <doshin...@commvault.com> wrote: > Hi Abdel, > Thanks f

[jira] [Created] (DRILL-4184) query selecting on parquet decimal field fails with ClassCastException

Dave Oshinsky created DRILL-4184: Summary: query selecting on parquet decimal field fails with ClassCastException Key: DRILL-4184 URL: https://issues.apache.org/jira/browse/DRILL-4184 Project: Apache