[GitHub] litttlefisher commented on issue #1571: Is there any deadline to release a version?

2018-04-08 Thread GitBox
litttlefisher commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379637515 Which can be used in dubbo-spring-boot This is an

[GitHub] litttlefisher opened a new issue #1571: Is there any deadline to release a version?

2018-04-08 Thread GitBox
litttlefisher opened a new issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571 This is an automated message from the Apache Git Service. To respond to the

[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0?

2018-04-08 Thread GitBox
neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379627722 @suclogger thanks a ton! I'm able to compile now.

[GitHub] proaway commented on issue #1012: Wanted: who's using dubbo

2018-04-08 Thread GitBox
proaway commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379622902 公司:银湖网络科技有限公司 地址:中国北京 This is an automated message from the Apache Git Service.

[GitHub] hank-whu commented on issue #1500: not support java 10

2018-04-08 Thread GitBox
hank-whu commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379622762 ```java >java -jar dubbo-server-round-2-jar-with-dependencies.jar Exception in thread "main" java.lang.NoClassDefFoundError:

[GitHub] suclogger commented on issue #93: Is it incompatible with Spring Boot 2.0?

2018-04-08 Thread GitBox
suclogger commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379621066 @neesonqk Please refer to #96 . This is an

[GitHub] codecov-io commented on issue #1570: [Dubbo-fixed annotation demo fail to start].

2018-04-08 Thread GitBox
codecov-io commented on issue #1570: [Dubbo-fixed annotation demo fail to start]. URL: https://github.com/apache/incubator-dubbo/pull/1570#issuecomment-379618720 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1570?src=pr=h1) Report > Merging

[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0?

2018-04-08 Thread GitBox
neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379615777 @suclogger Unable to compile 0.2.0, see this

[GitHub] zonghaishang opened a new pull request #1570: [Dubbo-fixed annotation demo fail to start].

2018-04-08 Thread GitBox
zonghaishang opened a new pull request #1570: [Dubbo-fixed annotation demo fail to start]. URL: https://github.com/apache/incubator-dubbo/pull/1570 ## What is the purpose of the change Fix annotation demo fails to start. ## Brief changelog update dubbo-test-examples.

[GitHub] xhuiinit commented on issue #1441: how to use dubbo in docker

2018-04-08 Thread GitBox
xhuiinit commented on issue #1441: how to use dubbo in docker URL: https://github.com/apache/incubator-dubbo/issues/1441#issuecomment-379614226 @vangoleo ,I also have worked with Dubbo, Docker and k8s,and have some questions: With docker and k8s, zookeeper is deployed under docker.

[GitHub] carryxyh commented on issue #1568: Extension: Enhanced Thread Pool

2018-04-08 Thread GitBox
carryxyh commented on issue #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379606081 @beiwei30 @zonghaishang CI failure has been resolved. This is an automated

[GitHub] alphatan opened a new issue #100: dubbo status is UNKOWN

2018-04-08 Thread GitBox
alphatan opened a new issue #100: dubbo status is UNKOWN URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/100 # Description After checking the dubbo service working correctly, then added the dependency of `spring-boot-actuator` to enable actuator and checked

[GitHub] zonghaishang commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-08 Thread GitBox
zonghaishang commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-379561997 1. Agree @EnableDubbo not to scan @Component 2. Currently does not support annotation services to delay consumption, @mercyblitz

[GitHub] zonghaishang commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-08 Thread GitBox
zonghaishang commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-379561997 1. Agree @EnableComponent not to scan @Component 2. Currently does not support annotation services to delay consumption,

[GitHub] zonghaishang closed pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-08 Thread GitBox
zonghaishang closed pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] codecov-io commented on issue #1564: update CXF to latest version and add test case for webservice protocol

2018-04-08 Thread GitBox
codecov-io commented on issue #1564: update CXF to latest version and add test case for webservice protocol URL: https://github.com/apache/incubator-dubbo/pull/1564#issuecomment-379484796 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr=h1) Report > Merging

Re: Is Spring Optional?

2018-04-08 Thread John D. Ament
Oh ok, so if I wanted a different one, do I just implement the interface, or are there other requirements? Many other frameworks leverage a META-INF/services ServiceLoader pattern. John On Sun, Apr 8, 2018 at 11:22 AM shang zonghai wrote: > The meaning of the SPI

Re: Is Spring Optional?

2018-04-08 Thread shang zonghai
The meaning of the SPI default use springContainer, allow custom extensions. yiji > 在 2018年4月8日,23:18,John D. Ament 写道: > > Weird, because even that says spring >

Re: Is Spring Optional?

2018-04-08 Thread John D. Ament
Weird, because even that says spring https://github.com/apache/incubator-dubbo/blob/master/dubbo-container/dubbo-container-api/src/main/java/com/alibaba/dubbo/container/Container.java#L24 But it's a step, let me play around with it a bit. John On Sun, Apr 8, 2018 at 10:36 AM shang zonghai

Re: Is Spring Optional?

2018-04-08 Thread shang zonghai
SPI: com.alibaba.dubbo.container.Container Default SpringContainer extends this API,The dubbo-config-spring module supports spring-related functions. Dubbo design goals are highly scalable, allowing custom extensions to support more DI containers. Kind regards, yiji > 在 2018年4月8日,22:27,John

Is Spring Optional?

2018-04-08 Thread John D. Ament
Hi, Looking at dubbo, its very interesting. I was wondering though, is Spring optional in Dubbo, or is it a required part to make Dubbo work? Is there any SPI that could be used in Dubbo that would allow other DI containers to be used? John

[GitHub] codecov-io commented on issue #1568: Extension: Enhanced Thread Pool

2018-04-08 Thread GitBox
codecov-io commented on issue #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379553497 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr=h1) Report > Merging

Re: List volume and issue tracking

2018-04-08 Thread John D. Ament
Just wondering, does anyone care what the new list is called? Does using notifications@ for now make the most sense, and potentially split that even further? FWIW, this isn't the only project I'm seeing this with. We may need to change some of our podling setup processes to account for the

[GitHub] diecui1202 commented on issue #1500: not support java 10

2018-04-08 Thread GitBox
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379550754 @hank-whu What's the detail compatible problem about Dubbo 2.6.1 and maven-assembly-plugin? Could you paste the exception stack trace here?

[GitHub] mercyblitz closed pull request #1569: update travis_wait 30

2018-04-08 Thread GitBox
mercyblitz closed pull request #1569: update travis_wait 30 URL: https://github.com/apache/incubator-dubbo/pull/1569 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] kimmking opened a new pull request #1569: update travis_wait 30

2018-04-08 Thread GitBox
kimmking opened a new pull request #1569: update travis_wait 30 URL: https://github.com/apache/incubator-dubbo/pull/1569 update travis_wait 30min to prevent travis timeout ## What is the purpose of the change X ## Brief changelog XX ## Verifying this

[GitHub] carryxyh commented on issue #1568: Extension: Enhanced Thread Pool

2018-04-08 Thread GitBox
carryxyh commented on issue #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379542301 @zonghaishang thx! This is an automated message from the Apache Git Service.

[GitHub] zonghaishang commented on issue #1568: Extension: Enhanced Thread Pool

2018-04-08 Thread GitBox
zonghaishang commented on issue #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379540325 @carryxyh Please add a license at the beginning of your codes to fix ci failed.

[GitHub] kimmking commented on a change in pull request #1564: update CXF to latest version and add test case for webservice protocol

2018-04-08 Thread GitBox
kimmking commented on a change in pull request #1564: update CXF to latest version and add test case for webservice protocol URL: https://github.com/apache/incubator-dubbo/pull/1564#discussion_r179942805 ## File path: dubbo-rpc/dubbo-rpc-webservice/pom.xml ## @@ -43,10

[GitHub] bearDream closed pull request #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

2018-04-08 Thread GitBox
bearDream closed pull request #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants. URL: https://github.com/apache/incubator-dubbo/pull/1555 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] bearDream commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

2018-04-08 Thread GitBox
bearDream commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants. URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379538125 @ralf0131 Ok This is an

[GitHub] YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

2018-04-08 Thread GitBox
YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179941797 ## File path:

[GitHub] nzomkxia commented on issue #1449: fixes #1089, make ExecutionDispatcher meet dubbo-user-book

2018-04-08 Thread GitBox
nzomkxia commented on issue #1449: fixes #1089, make ExecutionDispatcher meet dubbo-user-book URL: https://github.com/apache/incubator-dubbo/pull/1449#issuecomment-379536515 the modified code meets the behavior described in dubbo admin book

[GitHub] YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

2018-04-08 Thread GitBox
YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179941847 ## File path: dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/MonitorConfig.java

[GitHub] YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

2018-04-08 Thread GitBox
YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179941797 ## File path:

[GitHub] carryxyh commented on issue #1568: Extension: Enhanced Thread Pool

2018-04-08 Thread GitBox
carryxyh commented on issue #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379535099 @beiwei30 clear the pull request and commit the changes with comment in English

[GitHub] carryxyh opened a new pull request #1568: Extension: Enhanced Thread Pool

2018-04-08 Thread GitBox
carryxyh opened a new pull request #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568 A thread pool that can provide faster processing speeds when there are more tasks (of course it consumes more resources) * When the number of tasks exceeds

[GitHub] carryxyh commented on issue #1199: Extension: Enhanced threadPool

2018-04-08 Thread GitBox
carryxyh commented on issue #1199: Extension: Enhanced threadPool URL: https://github.com/apache/incubator-dubbo/pull/1199#issuecomment-379531638 @beiwei30 I will redo it . I will submit a new pull request only with enhanced thread pool and tests. I will also commit the changes with

[GitHub] HouZhiHouJue opened a new issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-08 Thread GitBox
HouZhiHouJue opened a new issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508 when register center lost all provider instance , it's doesn't mean that the consumers are all disconnected from the

[GitHub] beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

2018-04-08 Thread GitBox
beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179933412 ## File path:

[GitHub] beiwei30 closed issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

2018-04-08 Thread GitBox
beiwei30 closed issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite. URL: https://github.com/apache/incubator-dubbo/issues/1565 This is an automated message from the Apache Git

[GitHub] beiwei30 commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

2018-04-08 Thread GitBox
beiwei30 commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite. URL: https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379530226 thanks for ur best wish, let's close this issue for now.

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

2018-04-08 Thread GitBox
ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985 @cvictory if (!isShutdown(es)) { newThreadToCloseExecutor(es); } please confirm this, !isShutdown(es) is always

[GitHub] ralf0131 commented on issue #1547: centos7 start.sh启动 报 Ncat: Connection refused

2018-04-08 Thread GitBox
ralf0131 commented on issue #1547: centos7 start.sh启动 报 Ncat: Connection refused URL: https://github.com/apache/incubator-dubbo/issues/1547#issuecomment-379529405 Hi, welcome! Would you please update the title and description using English? Dubbo is a global community and we would

[GitHub] ralf0131 commented on issue #1542: 无法注册至zookeeper

2018-04-08 Thread GitBox
ralf0131 commented on issue #1542: 无法注册至zookeeper URL: https://github.com/apache/incubator-dubbo/issues/1542#issuecomment-379529224 Hi, welcome! Would you please update the title and description using English? Dubbo is a global community and we would like the issue to be seen by

[GitHub] ralf0131 commented on issue #1539: 使用 mock 时,使用 warn 级别无法打印调用生产者异常堆栈

2018-04-08 Thread GitBox
ralf0131 commented on issue #1539: 使用 mock 时,使用 warn 级别无法打印调用生产者异常堆栈 URL: https://github.com/apache/incubator-dubbo/issues/1539#issuecomment-379529142 Hi, welcome! Would you please update the title and description using English? Dubbo is a global community and we would like the

[GitHub] beiwei30 closed pull request #1511: Add feature:require Reference service dynamically

2018-04-08 Thread GitBox
beiwei30 closed pull request #1511: Add feature:require Reference service dynamically URL: https://github.com/apache/incubator-dubbo/pull/1511 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ralf0131 commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突

2018-04-08 Thread GitBox
ralf0131 commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突 URL: https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379529175 Hi, welcome! Would you please update the title and description using English? Dubbo is a global community and we would

[GitHub] beiwei30 commented on issue #1511: Add feature:require Reference service dynamically

2018-04-08 Thread GitBox
beiwei30 commented on issue #1511: Add feature:require Reference service dynamically URL: https://github.com/apache/incubator-dubbo/pull/1511#issuecomment-379529154 I am afraid I cannot accept this change because the following reasons: 1. From dubbo's user doc, the group is designed

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

2018-04-08 Thread GitBox
ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985 @cvictory No, isShutdown() will always return true when you invoke shutdown() or shutdownNow(). please confirm this,

[GitHub] haiyang1985 opened a new issue #1567: cannot set retry.period for FailbackRegistry

2018-04-08 Thread GitBox
haiyang1985 opened a new issue #1567: cannot set retry.period for FailbackRegistry URL: https://github.com/apache/incubator-dubbo/issues/1567 I want to turn off the FailbackRegistry retry or set a long retry period. From the code, dubbo is able to get retry.period parameter from the

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

2018-04-08 Thread GitBox
ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985 @cvictory No, isShutdown() will always return true when you invoke shutdown() or shutdownNow(). please confirm this, thank you

[GitHub] yosaku01 closed issue #1544: Does dubbo supports netty 4?

2018-04-08 Thread GitBox
yosaku01 closed issue #1544: Does dubbo supports netty 4? URL: https://github.com/apache/incubator-dubbo/issues/1544 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] beiwei30 opened a new issue #1566: more checkstyle rules needed

2018-04-08 Thread GitBox
beiwei30 opened a new issue #1566: more checkstyle rules needed URL: https://github.com/apache/incubator-dubbo/issues/1566 I've merged PR#1513, but we still need to add more rules. This is an automated message from the

[GitHub] beiwei30 closed pull request #1558: [Dubbo-1513] add checkstyle with basic rule

2018-04-08 Thread GitBox
beiwei30 closed pull request #1558: [Dubbo-1513] add checkstyle with basic rule URL: https://github.com/apache/incubator-dubbo/pull/1558 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] beiwei30 commented on issue #1558: [Dubbo-1513] add checkstyle with basic rule

2018-04-08 Thread GitBox
beiwei30 commented on issue #1558: [Dubbo-1513] add checkstyle with basic rule URL: https://github.com/apache/incubator-dubbo/pull/1558#issuecomment-379526785 I think this is a good start. I will accept the change. This is an

[GitHub] beiwei30 closed issue #1513: [Suggestion] Add checkstyle for CI

2018-04-08 Thread GitBox
beiwei30 closed issue #1513: [Suggestion] Add checkstyle for CI URL: https://github.com/apache/incubator-dubbo/issues/1513 This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: List volume and issue tracking

2018-04-08 Thread Minxuan Zhuang
+1 On Sun, Apr 8, 2018 at 3:08 PM, shang zonghai wrote: > +1 > > Kind regards, > yiji >

Re: List volume and issue tracking

2018-04-08 Thread shang zonghai
+1 Kind regards, yiji

Re: List volume and issue tracking

2018-04-08 Thread Mercy
+1. Kind regards, Mercy Ma 在 2018/4/8 下午2:52, wanhuhou 写道: +1 from Alimail Windows--发件人:Wang Xin日 期:2018年04月08日 14:50:53收件人:dev@dubbo.apache.org抄 送:Ian Luo;

Re: List volume and issue tracking

2018-04-08 Thread Ian Luo
+1 It sounds very reasonable. -Ian. > On 8 Apr 2018, at 2:52 PM, wanhuhou wrote: > > > +1 > from Alimail > Windows--发件人:Wang > Xin日 期:2018年04月08日 >

[GitHub] tangdu commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突

2018-04-08 Thread GitBox
tangdu commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突 URL: https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379525709 @8967 dubbo.application.qos.enable=false This is an

Re: Re: List volume and issue tracking

2018-04-08 Thread wanhuhou
+1 from Alimail Windows--发件人:Wang Xin日 期:2018年04月08日 14:50:53收件人:dev@dubbo.apache.org抄 送:Ian Luo; us...@infra.apache.org主 题:Re: List volume

Re: List volume and issue tracking

2018-04-08 Thread Wang Xin
+1,It’s good. dev@ -- the development community's discussions commits@ -- commit emails issues@ -- all emails related to issues (GitHub/Jira) notifications@ -- PR notifications, etc Xin Wang lovep...@hotmail.com 在 2018年4月8日,下午2:40,Yong Zhu

If someaone have a usage question, what should he do?

2018-04-08 Thread shengli cao
Hi everyone: I found some issues in github are usage questions, such as https://github.com/apache/incubator-dubbo/issues/1522 , https://github.com/apache/incubator-dubbo/issues/1523. I have some experience when I have some question about spring boot. If you have some question about

Re: List volume and issue tracking

2018-04-08 Thread shang zonghai
I was also confused by a lot of mixed emails. For this topic, I have the following suggestions: 1. All pull requests are sent to the current dev@dubbo.apache.org. Pr contains final solution to problem solution or feature enhancement capabilities, all users and

Re: List volume and issue tracking

2018-04-08 Thread Huxing Zhang
+1 This breakdown looks good to me. On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein wrote: > Many projects choose this pattern: > > dev@ -- the development community's discussions > commits@ -- commit emails > issues@ -- all emails related to issues (GitHub/Jira) > notifications@

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-08 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936906 ## File path:

Re: List volume and issue tracking

2018-04-08 Thread Greg Stein
Many projects choose this pattern: dev@ -- the development community's discussions commits@ -- commit emails issues@ -- all emails related to issues (GitHub/Jira) notifications@ -- PR notifications, etc All GitHub activity is required to be delivered to an ASF mailing list. It is up to the

[GitHub] codecov-io commented on issue #1380: upgrade libthrift version and add nature thrift support option

2018-04-08 Thread GitBox
codecov-io commented on issue #1380: upgrade libthrift version and add nature thrift support option URL: https://github.com/apache/incubator-dubbo/pull/1380#issuecomment-367338110 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=h1) Report > Merging

[GitHub] diecui1202 commented on issue #1500: not support java 10

2018-04-08 Thread GitBox
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379524152 I run the two test cases under Java 10, they're all ok. And I also build dubbo under Java 10, there is a NullPointerException which is thrown

[GitHub] nzomkxia commented on issue #1507: Mirror improvement for test cases in dubbo-rpc-api module

2018-04-08 Thread GitBox
nzomkxia commented on issue #1507: Mirror improvement for test cases in dubbo-rpc-api module URL: https://github.com/apache/incubator-dubbo/pull/1507#issuecomment-379524103 all tests are passed This is an automated message

[GitHub] ralf0131 commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

2018-04-08 Thread GitBox
ralf0131 commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants. URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379524089 I think this pull request contains two separated enhancement. 1.

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-08 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936710 ## File path:

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-08 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936669 ## File path: