[GitHub] litttlefisher commented on issue #1571: Is there any deadline to release a version?

[GitBox]

litttlefisher commented on issue #1571: Is there any deadline to release a 
version?
URL: 
https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379637515
 
 
   Which can be used in dubbo-spring-boot


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] litttlefisher opened a new issue #1571: Is there any deadline to release a version?

[GitBox]

litttlefisher opened a new issue #1571: Is there any deadline to release a 
version?
URL: https://github.com/apache/incubator-dubbo/issues/1571
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0？

[GitBox]

neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0？
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379627722
 
 
   @suclogger thanks a ton! I'm able to compile now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] proaway commented on issue #1012: Wanted: who's using dubbo

[GitBox]

proaway commented on issue #1012: Wanted: who's using dubbo
URL: 
https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379622902
 
 
   公司：银湖网络科技有限公司
   地址：中国北京


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hank-whu commented on issue #1500: not support java 10

[GitBox]

hank-whu commented on issue #1500: not support java 10
URL: 
https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379622762
 
 
   ```java
   >java -jar dubbo-server-round-2-jar-with-dependencies.jar
   
   Exception in thread "main" java.lang.NoClassDefFoundError: 
org/springframework/context/support/ClassPathXmlApplicationContext
   at benchmark.rpc.Server.main(Server.java:8)
   Caused by: java.lang.ClassNotFoundException: 
org.springframework.context.support.ClassPathXmlApplicationContext
   at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:582)
   at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:190)
   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:499)
   ... 1 more
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] suclogger commented on issue #93: Is it incompatible with Spring Boot 2.0？

[GitBox]

suclogger commented on issue #93: Is it incompatible with Spring Boot 2.0？
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379621066
 
 
   @neesonqk Please refer to #96 .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #1570: [Dubbo-fixed annotation demo fail to start].

[GitBox]

codecov-io commented on issue #1570: [Dubbo-fixed annotation demo fail to 
start].
URL: https://github.com/apache/incubator-dubbo/pull/1570#issuecomment-379618720
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1570?src=pr=h1) 
Report
   > Merging 
[#1570](https://codecov.io/gh/apache/incubator-dubbo/pull/1570?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1570/graphs/tree.svg?height=150=VnEIkiFQT0=pr=650)](https://codecov.io/gh/apache/incubator-dubbo/pull/1570?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1570  +/-   ##
   ==
   + Coverage   32.17%   32.18%   +<.01% 
   ==
 Files 682  682  
 Lines   3297232972  
 Branches 6597 6597  
   ==
   + Hits1060810611   +3 
   + Misses  2046820467   -1 
   + Partials 1896 1894   -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1570?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../dubbo/examples/annotation/AnnotationConsumer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1570/diff?src=pr=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uQ29uc3VtZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[.../dubbo/examples/annotation/AnnotationProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1570/diff?src=pr=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1570/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `77.77% <0%> (-5.56%)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1570/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | 
[...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1570/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==)
 | `59.42% <0%> (+1.44%)` | :arrow_up: |
   | 
[...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1570/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=)
 | `66.25% <0%> (+8.75%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1570?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1570?src=pr=footer).
 Last update 
[497803c...ac6e15a](https://codecov.io/gh/apache/incubator-dubbo/pull/1570?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0？

[GitBox]

neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0？
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379615777
 
 
   @suclogger Unable to compile 0.2.0, see this
   
   
![image](https://user-images.githubusercontent.com/7279067/38477552-d440cde4-3be5-11e8-8d67-c8249063e860.png)
   
   and this,
   
   
![image](https://user-images.githubusercontent.com/7279067/38477561-dd214a10-3be5-11e8-86c9-9aa7b97be0c4.png)
   
   Changing version to 2.5.10 or any other higher version doesn't seem to solve 
this problem, please help!
   
   Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang opened a new pull request #1570: [Dubbo-fixed annotation demo fail to start].

[GitBox]

zonghaishang opened a new pull request #1570: [Dubbo-fixed annotation demo fail 
to start].
URL: https://github.com/apache/incubator-dubbo/pull/1570
 
 
   ## What is the purpose of the change
   
   Fix annotation demo fails to start.
   
   ## Brief changelog
   
   update dubbo-test-examples.
   
   ## Verifying this change
   
   1. start AnnotationProvider
   2. start AnnotationComsumer
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [] Make sure there is a 
[GITHUB_issue](https://github.com/alibaba/dubbo/issues) filed for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [x] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run 
`mvn clean test-compile failsafe:integration-test`  to make sure 
integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xhuiinit commented on issue #1441: how to use dubbo in docker

[GitBox]

xhuiinit commented on issue #1441: how to use dubbo in docker
URL: 
https://github.com/apache/incubator-dubbo/issues/1441#issuecomment-379614226
 
 
   @vangoleo ,I also have worked with Dubbo, Docker and k8s，and have some 
questions：
   With docker and k8s, zookeeper is deployed under docker. After the container 
is restarted, the virtual IP of zookeeper will change.
   Dubbo is configured with the service address of zookeeper, such as: 
zookeeper://zk-headless. Kube-system :2181,
   The parsed virtual IP is still rebooting the previous IP;Then the dubbo 
connection is not connected to zookeeper.
   Do you have any problems like this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carryxyh commented on issue #1568: Extension: Enhanced Thread Pool

[GitBox]

carryxyh commented on issue #1568: Extension: Enhanced Thread Pool
URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379606081
 
 
   @beiwei30 @zonghaishang 
   CI failure has been resolved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] alphatan opened a new issue #100: dubbo status is UNKOWN

[GitBox]

alphatan opened a new issue #100: dubbo status is UNKOWN
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/100
 
 
   # Description
   
   After checking the dubbo service working correctly, then added the 
dependency of `spring-boot-actuator` to enable actuator and checked 
`http://localhost:9091/health`, it shows the status of dubbo is **UNKOWN**.
   
![dubbo_status_unknown](https://user-images.githubusercontent.com/26187550/38474945-cc5f15cc-3bd6-11e8-8eab-c7f3e908482e.png)
   
   Is it normal? a bug? or the configuration is incorrect ?
   
   
   Thanks
   
   
   # Configurations
   
   ## pom.xml
   
   ```xml
   
   
 org.springframework.boot
 spring-boot-starter
   
   
   
 org.springframework.boot
 spring-boot-starter-web
   
   
   
 org.springframework.boot
 spring-boot-actuator
   
   
   
   
 org.projectlombok
 lombok
 provided
   
   
   
 com.at.spring
 dubbo-spring-boot-demo-api
 0.0.1-SNAPSHOT
   
   
   
   
 com.alibaba.boot
 dubbo-spring-boot-starter
 0.1.0
 
   
 org.springframework
 spring-context
   
   
 org.springframework
 spring-beans
   
   
 org.springframework
 spring-web
   
   
 org.springframework
 spring-core
   
   
 org.springframework.boot
 spring-boot-starter
   
   
 log4j
 log4j
   
 
   
   
 com.101tec
 zkclient
 0.10
   
   
   ```
   
   ## application.properties
   
   ```properties
   # Spring boot application
   spring.application.name = dubbo-provider-demo
   server.port = 9090
   management.port = 9091
   
   # Base packages to scan Dubbo Components (e.g., @Service, @Reference)
   dubbo.scan.basePackages  = com.at.spring.service.impl
   
   # Dubbo Config properties
   ## ApplicationConfig Bean
   dubbo.application.id = dubbo-spring-boot-demo-provider
   dubbo.application.name = dubbo-spring-boot-demo-provider
   
   ## ProtocolConfig Bean
   dubbo.protocol.id = dubbo
   dubbo.protocol.name = dubbo
   dubbo.protocol.port = 12345
   
   ## RegistryConfig Bean
   dubbo.registry.id = zookeeper
   dubbo.registry.address = zookeeper://127.0.0.1:2181
   
   
   
   ### actuator
   
   ## management.health.dubbo.status.defaults is a property name for setting 
names
   ## of StatusCheckers , its value is allowed to multiple-value
   #management.health.dubbo.status.defaults = memory,load
   management.health.dubbo.status.defaults = registry,memory,load
   
   ## management.health.dubbo.status.extras is used to override the
   ## management.health.dubbo.status.defaults, the multiple-values is delimited 
by
   ## comma
   #management.health.dubbo.status.extras = load,threadpool
   
   ## Dubbo Spring Boot providers actuator endpoint dubbo , however it is
   ## disable. If you'd like to enable it , please add following property into
   ## externalized configuration
   ## no such property in 0.1.0
   #management.health.dubbo.enabled = true
   
   ## dubbo endpoint
   #endpoints.dubbo.enabled = false
   #endpoints.dubbo.sensitive = true
   ## Spring Security
   #management.security.enabled = true
   endpoints.dubbo.sensitive = false
   management.security.enabled = false
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-379561997
 
 
   1. Agree @EnableDubbo not to scan @Component
   2. Currently does not support annotation services to delay consumption, 
@mercyblitz maybe provider more better choice to solve it.
   
   Close this pr.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-379561997
 
 
   1. Agree @EnableComponent not to scan @Component
   2. Currently does not support annotation services to delay consumption, 
@mercyblitz maybe provider more better choice to solve it.
   
   Close this pr.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang closed pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang closed pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractConfig.java
 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractConfig.java
index caa14a53af..5561feefe6 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractConfig.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractConfig.java
@@ -164,7 +164,7 @@ protected static void appendProperties(AbstractConfig 
config) {
 }
 }
 
-private static String getTagName(Class cls) {
+protected static String getTagName(Class cls) {
 String tag = cls.getSimpleName();
 for (String suffix : SUFFIXES) {
 if (tag.endsWith(suffix)) {
@@ -288,7 +288,7 @@ protected static void appendAttributes(Map 
parameters, Object co
 }
 }
 
-private static boolean isPrimitive(Class type) {
+protected static boolean isPrimitive(Class type) {
 return type.isPrimitive()
 || type == String.class
 || type == Character.class
diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
index 1cb58ae28d..573da510f4 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
@@ -186,10 +186,10 @@ private void init() {
 if (initialized) {
 return;
 }
-initialized = true;
 if (interfaceName == null || interfaceName.length() == 0) {
 throw new IllegalStateException(" interface not allow null!");
 }
+initialized = true;
 // get consumer's global configuration
 checkDefault();
 appendProperties(this);
diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
index 853ece2eaa..a970bcc083 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
@@ -223,10 +223,10 @@ protected synchronized void doExport() {
 if (exported) {
 return;
 }
-exported = true;
 if (interfaceName == null || interfaceName.length() == 0) {
 throw new IllegalStateException(" 
interface not allow null!");
 }
+exported = true;
 checkDefault();
 if (provider != null) {
 if (application == null) {
diff --git 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/ReferenceBean.java
 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/ReferenceBean.java
index f3aa9b0249..7c496db2c7 100644
--- 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/ReferenceBean.java
+++ 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/ReferenceBean.java
@@ -33,6 +33,8 @@
 import org.springframework.context.ApplicationContext;
 import org.springframework.context.ApplicationContextAware;
 
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -177,4 +179,51 @@ public void afterPropertiesSet() throws Exception {
 public void destroy() {
 // do nothing
 }
+
+@Override
+public String toString() {
+try {
+StringBuilder buf = new StringBuilder();
+buf.append("

[GitHub] codecov-io commented on issue #1564: update CXF to latest version and add test case for webservice protocol

[GitBox]

codecov-io commented on issue #1564: update CXF to latest version and add test 
case for webservice protocol
URL: https://github.com/apache/incubator-dubbo/pull/1564#issuecomment-379484796
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr=h1) 
Report
   > Merging 
[#1564](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/graphs/tree.svg?width=650=150=pr=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1564  +/-   ##
   ==
   - Coverage   32.17%   32.13%   -0.04% 
   ==
 Files 682  686   +4 
 Lines   3297233008  +36 
 Branches 6597 6599   +2 
   ==
   - Hits1060810607   -1 
   - Misses  2046820506  +38 
   + Partials 1896 1895   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...bo/rpc/protocol/webservice/WebServiceProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy13ZWJzZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL3dlYnNlcnZpY2UvV2ViU2VydmljZVByb3RvY29sLmphdmE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[.../dubbo/examples/webservice/WebserviceProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvd2Vic2VydmljZS9XZWJzZXJ2aWNlUHJvdmlkZXIuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[.../dubbo/examples/webservice/WebserviceConsumer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvd2Vic2VydmljZS9XZWJzZXJ2aWNlQ29uc3VtZXIuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[...om/alibaba/dubbo/examples/webservice/api/User.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvd2Vic2VydmljZS9hcGkvVXNlci5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[...ubbo/examples/webservice/impl/UserServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvd2Vic2VydmljZS9pbXBsL1VzZXJTZXJ2aWNlSW1wbC5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `55.22% <0%> (-1.5%)` | :arrow_down: |
   | ... and [3 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr=footer).
 Last update 
[497803c...41efd53](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Is Spring Optional?

[John D. Ament]

Oh ok, so if I wanted a different one, do I just implement the interface,
or are there other requirements?  Many other frameworks leverage a
META-INF/services ServiceLoader pattern.

John

On Sun, Apr 8, 2018 at 11:22 AM shang zonghai 
wrote:

> The meaning of the SPI default use springContainer, allow custom
> extensions.
>
> yiji
>
> > 在 2018年4月8日，23:18，John D. Ament  写道：
> >
> > Weird, because even that says spring
> >
> https://github.com/apache/incubator-dubbo/blob/master/dubbo-container/dubbo-container-api/src/main/java/com/alibaba/dubbo/container/Container.java#L24
> >
> > But it's a step, let me play around with it a bit.
> >
> > John
> >
> > On Sun, Apr 8, 2018 at 10:36 AM shang zonghai 
> > wrote:
> >
> >>
> >> SPI: com.alibaba.dubbo.container.Container
> >>
> >> Default SpringContainer extends this API，The dubbo-config-spring module
> >> supports spring-related functions.
> >> Dubbo design goals are highly scalable, allowing custom extensions to
> >> support more DI containers.
> >>
> >> Kind regards,
> >> yiji
> >>
> >>
> >>> 在 2018年4月8日，22:27，John D. Ament  写道：
> >>>
> >>> Hi,
> >>>
> >>> Looking at dubbo, its very interesting.  I was wondering though, is
> >> Spring
> >>> optional in Dubbo, or is it a required part to make Dubbo work?  Is
> there
> >>> any SPI that could be used in Dubbo that would allow other DI
> containers
> >> to
> >>> be used?
> >>>
> >>> John
> >>
> >>
>
>

Re: Is Spring Optional?

[shang zonghai]

The meaning of the SPI default use springContainer, allow custom extensions.

yiji

> 在 2018年4月8日，23:18，John D. Ament  写道：
> 
> Weird, because even that says spring
> https://github.com/apache/incubator-dubbo/blob/master/dubbo-container/dubbo-container-api/src/main/java/com/alibaba/dubbo/container/Container.java#L24
> 
> But it's a step, let me play around with it a bit.
> 
> John
> 
> On Sun, Apr 8, 2018 at 10:36 AM shang zonghai 
> wrote:
> 
>> 
>> SPI: com.alibaba.dubbo.container.Container
>> 
>> Default SpringContainer extends this API，The dubbo-config-spring module
>> supports spring-related functions.
>> Dubbo design goals are highly scalable, allowing custom extensions to
>> support more DI containers.
>> 
>> Kind regards,
>> yiji
>> 
>> 
>>> 在 2018年4月8日，22:27，John D. Ament  写道：
>>> 
>>> Hi,
>>> 
>>> Looking at dubbo, its very interesting.  I was wondering though, is
>> Spring
>>> optional in Dubbo, or is it a required part to make Dubbo work?  Is there
>>> any SPI that could be used in Dubbo that would allow other DI containers
>> to
>>> be used?
>>> 
>>> John
>> 
>> 

Re: Is Spring Optional?

[John D. Ament]

Weird, because even that says spring
https://github.com/apache/incubator-dubbo/blob/master/dubbo-container/dubbo-container-api/src/main/java/com/alibaba/dubbo/container/Container.java#L24

But it's a step, let me play around with it a bit.

John

On Sun, Apr 8, 2018 at 10:36 AM shang zonghai 
wrote:

>
> SPI: com.alibaba.dubbo.container.Container
>
> Default SpringContainer extends this API，The dubbo-config-spring module
> supports spring-related functions.
> Dubbo design goals are highly scalable, allowing custom extensions to
> support more DI containers.
>
> Kind regards,
> yiji
>
>
> > 在 2018年4月8日，22:27，John D. Ament  写道：
> >
> > Hi,
> >
> > Looking at dubbo, its very interesting.  I was wondering though, is
> Spring
> > optional in Dubbo, or is it a required part to make Dubbo work?  Is there
> > any SPI that could be used in Dubbo that would allow other DI containers
> to
> > be used?
> >
> > John
>
>

Re: Is Spring Optional?

[shang zonghai]

SPI: com.alibaba.dubbo.container.Container

Default SpringContainer extends this API，The dubbo-config-spring module 
supports spring-related functions.
Dubbo design goals are highly scalable, allowing custom extensions to support 
more DI containers.

Kind regards,
yiji


> 在 2018年4月8日，22:27，John D. Ament  写道：
> 
> Hi,
> 
> Looking at dubbo, its very interesting.  I was wondering though, is Spring
> optional in Dubbo, or is it a required part to make Dubbo work?  Is there
> any SPI that could be used in Dubbo that would allow other DI containers to
> be used?
> 
> John

Is Spring Optional?

[John D. Ament]

Hi,

Looking at dubbo, its very interesting.  I was wondering though, is Spring
optional in Dubbo, or is it a required part to make Dubbo work?  Is there
any SPI that could be used in Dubbo that would allow other DI containers to
be used?

John

[GitHub] codecov-io commented on issue #1568: Extension: Enhanced Thread Pool

[GitBox]

codecov-io commented on issue #1568: Extension: Enhanced Thread Pool
URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379553497
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr=h1) 
Report
   > Merging 
[#1568](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/9003c125a97280624a1e312ac1f5f22d05a491bf?src=pr=desc)
 will **increase** coverage by `0.15%`.
   > The diff coverage is `68.29%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/graphs/tree.svg?height=150=650=VnEIkiFQT0=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #1568  +/-   ##
   =
   + Coverage   32.14%   32.3%   +0.15% 
   =
 Files 682 685   +3 
 Lines   32972   33013  +41 
 Branches 65976603   +6 
   =
   + Hits10600   10665  +65 
   + Misses  20480   20450  -30 
   - Partials 18921898   +6
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...threadpool/support/enhanced/EnhancedTaskQueue.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lbmhhbmNlZC9FbmhhbmNlZFRhc2tRdWV1ZS5qYXZh)
 | `56.25% <56.25%> (ø)` | |
   | 
[...l/support/enhanced/EnhancedThreadPoolExecutor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lbmhhbmNlZC9FbmhhbmNlZFRocmVhZFBvb2xFeGVjdXRvci5qYXZh)
 | `66.66% <66.66%> (ø)` | |
   | 
[...hreadpool/support/enhanced/EnhancedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lbmhhbmNlZC9FbmhhbmNlZFRocmVhZFBvb2wuamF2YQ==)
 | `90% <90%> (ø)` | |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `55.22% <0%> (-1.5%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | 
[...on/src/main/java/com/alibaba/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL1VSTC5qYXZh)
 | `25.93% <0%> (+0.89%)` | :arrow_up: |
   | 
[...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==)
 | `71.42% <0%> (+3.57%)` | :arrow_up: |
   | ... and [6 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr=footer).
 Last update 
[9003c12...8f10d9e](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: List volume and issue tracking

[John D. Ament]

Just wondering, does anyone care what the new list is called? Does using
notifications@ for now make the most sense, and potentially split that even
further?

FWIW, this isn't the only project I'm seeing this with.  We may need to
change some of our podling setup processes to account for the higher volume
generated by gitbox.

John

On Sun, Apr 8, 2018 at 3:09 AM Minxuan Zhuang  wrote:

> +1
>
> On Sun, Apr 8, 2018 at 3:08 PM, shang zonghai 
> wrote:
>
> > +1
> >
> > Kind regards,
> > yiji
> >
>

[GitHub] diecui1202 commented on issue #1500: not support java 10

[GitBox]

diecui1202 commented on issue #1500: not support java 10
URL: 
https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379550754
 
 
   @hank-whu What's the detail compatible problem about Dubbo 2.6.1 and 
maven-assembly-plugin? Could you paste the exception stack trace here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz closed pull request #1569: update travis_wait 30

[GitBox]

mercyblitz closed pull request #1569: update travis_wait 30
URL: https://github.com/apache/incubator-dubbo/pull/1569
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index e065c32f8f..101cb297a7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -6,8 +6,8 @@ jdk:
 - openjdk7
 
 script:
-- mvn clean package
-- mvn cobertura:cobertura
+- travis_wait 30 mvn clean package
+- travis_wait 30 mvn cobertura:cobertura
 
 after_success:
-  - bash <(curl -s https://codecov.io/bash)
\ No newline at end of file
+  - bash <(curl -s https://codecov.io/bash)


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking opened a new pull request #1569: update travis_wait 30

[GitBox]

kimmking opened a new pull request #1569: update travis_wait 30
URL: https://github.com/apache/incubator-dubbo/pull/1569
 
 
   update travis_wait 30min to prevent travis timeout
   
   ## What is the purpose of the change
   
   X
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a 
[GITHUB_issue](https://github.com/alibaba/dubbo/issues) filed for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run 
`mvn clean test-compile failsafe:integration-test`  to make sure 
integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carryxyh commented on issue #1568: Extension: Enhanced Thread Pool

[GitBox]

carryxyh commented on issue #1568: Extension: Enhanced Thread Pool
URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379542301
 
 
   @zonghaishang thx!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on issue #1568: Extension: Enhanced Thread Pool

[GitBox]

zonghaishang commented on issue #1568: Extension: Enhanced Thread Pool
URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379540325
 
 
   @carryxyh
   
   Please add a license at the beginning of your codes to fix ci failed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on a change in pull request #1564: update CXF to latest version and add test case for webservice protocol

[GitBox]

kimmking commented on a change in pull request #1564: update CXF to latest 
version and add test case for webservice protocol
URL: https://github.com/apache/incubator-dubbo/pull/1564#discussion_r179942805
 
 

 ##
 File path: dubbo-rpc/dubbo-rpc-webservice/pom.xml
 ##
 @@ -43,10 +43,12 @@
 
 org.apache.cxf
 cxf-rt-frontend-simple
+3.2.4
 
 
 org.apache.cxf
 cxf-rt-transports-http
+3.2.4
 
 Review comment:
   that's right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bearDream closed pull request #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

[GitBox]

bearDream closed pull request #1555: SerivceAnnotationBeanPostProcessor bug and 
replace ServiceConfig vars by Constants.
URL: https://github.com/apache/incubator-dubbo/pull/1555
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
index 853ece2eaa..39e00a9269 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
@@ -433,8 +433,8 @@ private void doExportUrlsFor1Protocol(ProtocolConfig 
protocolConfig, List r
 }
 
 if (ProtocolUtils.isGeneric(generic)) {
-map.put("generic", generic);
-map.put("methods", Constants.ANY_VALUE);
+map.put(Constants.GENERIC_KEY, generic);
+map.put(Constants.METHODS_KEY, Constants.ANY_VALUE);
 } else {
 String revision = Version.getVersion(interfaceClass, version);
 if (revision != null && revision.length() > 0) {
@@ -444,19 +444,19 @@ private void doExportUrlsFor1Protocol(ProtocolConfig 
protocolConfig, List r
 String[] methods = 
Wrapper.getWrapper(interfaceClass).getMethodNames();
 if (methods.length == 0) {
 logger.warn("NO method found in service interface " + 
interfaceClass.getName());
-map.put("methods", Constants.ANY_VALUE);
+map.put(Constants.METHODS_KEY, Constants.ANY_VALUE);
 } else {
-map.put("methods", StringUtils.join(new 
HashSet(Arrays.asList(methods)), ","));
+map.put(Constants.METHODS_KEY, StringUtils.join(new 
HashSet(Arrays.asList(methods)), ","));
 }
 }
 if (!ConfigUtils.isEmpty(token)) {
 if (ConfigUtils.isDefault(token)) {
-map.put("token", UUID.randomUUID().toString());
+map.put(Constants.TOKEN_KEY, UUID.randomUUID().toString());
 } else {
-map.put("token", token);
+map.put(Constants.TOKEN_KEY, token);
 }
 }
-if ("injvm".equals(protocolConfig.getName())) {
+if (Constants.LOCAL_PROTOCOL.equals(protocolConfig.getName())) {
 protocolConfig.setRegister(false);
 map.put("notify", "false");
 }
@@ -769,7 +769,7 @@ public String getPath() {
 }
 
 public void setPath(String path) {
-checkPathName("path", path);
+checkPathName(Constants.PATH_KEY, path);
 this.path = path;
 }
 
diff --git 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
index 1d273451bf..850b3c9520 100644
--- 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
+++ 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
@@ -413,7 +413,7 @@ private AbstractBeanDefinition 
buildServiceBeanDefinition(Service service, Class
 
 List protocolRuntimeBeanReferences = 
toRuntimeBeanReferences(protocolConfigBeanNames);
 
-if (!registryRuntimeBeanReferences.isEmpty()) {
+if (!protocolRuntimeBeanReferences.isEmpty()) {
 builder.addPropertyValue("protocols", 
protocolRuntimeBeanReferences);
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bearDream commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

[GitBox]

bearDream commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and 
replace ServiceConfig vars by Constants.
URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379538125
 
 
   @ralf0131 Ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

[GitBox]

YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor 
missing parameters
URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179941797
 
 

 ##
 File path: 
dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
 ##
 @@ -92,6 +93,7 @@ public void send() {
 long maxOutput = numbers[7];
 long maxElapsed = numbers[8];
 long maxConcurrent = numbers[9];
+String version = getUrl().getParameter(Constants.DEFAULT_PROTOCOL);
 
 Review comment:
   `DEFAULT_PROTOCOL` value is `dubbo`, this code is to get dubbo version but 
not protocol name. dubbo now upgrade fast, for a team, different project may 
use different dubbo version(eg 2.5.3, 2.6.0, 2.6.1), IMO, monitor need to know 
each project's dubbo version, so we can decide how to process the monitor data.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nzomkxia commented on issue #1449: fixes #1089, make ExecutionDispatcher meet dubbo-user-book

[GitBox]

nzomkxia commented on issue #1449: fixes #1089, make ExecutionDispatcher meet 
dubbo-user-book
URL: https://github.com/apache/incubator-dubbo/pull/1449#issuecomment-379536515
 
 
   the modified code meets the behavior described in dubbo admin book


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

[GitBox]

YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor 
missing parameters
URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179941847
 
 

 ##
 File path: 
dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/MonitorConfig.java
 ##
 @@ -123,4 +125,12 @@ public void setDefault(Boolean isDefault) {
 this.isDefault = isDefault;
 }
 
+public void setInterval(String interval){
+this.interval = interval;
+}
+
+public String getInterval(){
 
 Review comment:
   no one call `getInterval()` direct, this is used for fastjson serialize, so 
it can be passed to `URL`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

[GitBox]

YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor 
missing parameters
URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179941797
 
 

 ##
 File path: 
dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
 ##
 @@ -92,6 +93,7 @@ public void send() {
 long maxOutput = numbers[7];
 long maxElapsed = numbers[8];
 long maxConcurrent = numbers[9];
+String version = getUrl().getParameter(Constants.DEFAULT_PROTOCOL);
 
 Review comment:
   `DEFAULT_PROTOCOL` value is `dubbo`, this code is to get dubbo version but 
not protocol name. dubbo now upgrade fast, for a team, different project may 
use different dubbo version(eg 2.5.3, 2.6.0, 2.6.1), IMO, monitor need to know 
each project's dubbo version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carryxyh commented on issue #1568: Extension: Enhanced Thread Pool

[GitBox]

carryxyh commented on issue #1568: Extension: Enhanced Thread Pool
URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379535099
 
 
   @beiwei30 
   clear the pull request and commit the changes with comment in English


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carryxyh opened a new pull request #1568: Extension: Enhanced Thread Pool

[GitBox]

carryxyh opened a new pull request #1568: Extension: Enhanced Thread Pool
URL: https://github.com/apache/incubator-dubbo/pull/1568
 
 
   A thread pool that can provide faster processing speeds when there are more 
tasks (of course it consumes more resources)
   * When the number of tasks exceeds the core size, a new thread is first 
started to execute the task instead of putting it into the queue.
   * When the number of tasks is lower than the core size for a long time, the 
core size threads are maintained and redundant threads are recycled.
   * Compared to the fixed pool：When there are more tasks, provide more workers 
to handle the tasks.
   * Compared to the cached pool：The task queue in the cached pool is actually 
a SynchronousQueue and does not have the ability to cache tasks.
   * Whether to fail fail or put into a queue when a thread runs out：Both are 
feasible and need to consider which way should be applied according to the 
business scenario. Delayed scenarios are not allowed. Failfast is more 
reasonable than queues. However, if there is a certain tolerance for delays, 
queues are more reasonable than failfast.
   * Reference: Tomcat's thread pool design
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carryxyh commented on issue #1199: Extension: Enhanced threadPool

[GitBox]

carryxyh commented on issue #1199: Extension: Enhanced threadPool 
URL: https://github.com/apache/incubator-dubbo/pull/1199#issuecomment-379531638
 
 
   @beiwei30 I will redo it .
   I will submit a new pull request only with enhanced thread pool and tests.
   I will also commit the changes with comment in Englisth .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] HouZhiHouJue opened a new issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

HouZhiHouJue opened a new issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: https://github.com/apache/incubator-dubbo/issues/1508
 
 
   when register center lost all provider instance , it's doesn't mean that the 
consumers are all disconnected from the providers,so the method  
refreshInvoker(List invokerUrls) ; in registrydirectory is not so fault 
tolerance.the method code is :
   
   ` private void refreshInvoker(List invokerUrls) {
   
   if (invokerUrls != null && invokerUrls.size() == 1 && 
invokerUrls.get(0) != null
   
   && 
Constants.EMPTY_PROTOCOL.equals(invokerUrls.get(0).getProtocol())) {
   
   this.forbidden = true; // Forbid to access
   
   this.methodInvokerMap = null; // Set the method invoker map to 
null
   
   destroyAllInvokers(); // Close all invokers
   
   } else {
..
   `
   
   here when invokerUrls  is empty ,all the invokers are destryed, but in 
fact,ignore it  will be more fault tolerance.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

[GitBox]

beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo 
monitor missing parameters
URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179933412
 
 

 ##
 File path: 
dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
 ##
 @@ -92,6 +93,7 @@ public void send() {
 long maxOutput = numbers[7];
 long maxElapsed = numbers[8];
 long maxConcurrent = numbers[9];
+String version = getUrl().getParameter(Constants.DEFAULT_PROTOCOL);
 
 Review comment:
   why `DEFAULT_PROTOCOL` is necessary to collect?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

[GitBox]

beiwei30 closed issue #1565: Dubbo best practice case application, fully 
automatic open source framework Emsite.
URL: https://github.com/apache/incubator-dubbo/issues/1565
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

[GitBox]

beiwei30 commented on issue #1565: Dubbo best practice case application, fully 
automatic open source framework Emsite.
URL: 
https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379530226
 
 
   thanks for ur best wish, let's close this issue for now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

[GitBox]

ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985
 
 
   @cvictory 
   if (!isShutdown(es)) {
   newThreadToCloseExecutor(es);
   }
   please confirm this, !isShutdown(es) is always false, 
newThreadToCloseExecutor can't run.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #1547: centos7 start.sh启动 报 Ncat: Connection refused

[GitBox]

ralf0131 commented on issue #1547: centos7 start.sh启动 报 Ncat: Connection refused
URL: 
https://github.com/apache/incubator-dubbo/issues/1547#issuecomment-379529405
 
 
   Hi, welcome!
   
   Would you please update the title and description using English? Dubbo is a 
global community and we would like the issue to be seen by people all over the 
world.
   
   Questions like this are expected to be asked in the mailing list, you can 
[subscribe](https://github.com/apache/incubator-dubbo/issues/1393) and ask 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #1542: 无法注册至zookeeper

[GitBox]

ralf0131 commented on issue #1542: 无法注册至zookeeper
URL: 
https://github.com/apache/incubator-dubbo/issues/1542#issuecomment-379529224
 
 
   Hi, welcome!
   
   Would you please update the title and description using English? Dubbo is a 
global community and we would like the issue to be seen by people all over the 
world.
   
   Questions like this are expected to be asked in the mailing list, you can 
[subscribe](https://github.com/apache/incubator-dubbo/issues/1393) and ask 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #1539: 使用 mock 时，使用 warn 级别无法打印调用生产者异常堆栈

[GitBox]

ralf0131 commented on issue #1539: 使用 mock 时，使用 warn 级别无法打印调用生产者异常堆栈
URL: 
https://github.com/apache/incubator-dubbo/issues/1539#issuecomment-379529142
 
 
   Hi, welcome!
   
   Would you please update the title and description using English? Dubbo is a 
global community and we would like the issue to be seen by people all over the 
world.
   
   Questions like this are expected to be asked in the mailing list, you can 
[subscribe](https://github.com/apache/incubator-dubbo/issues/1393) and ask 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed pull request #1511: Add feature：require Reference service dynamically

[GitBox]

beiwei30 closed pull request #1511: Add feature：require Reference service 
dynamically
URL: https://github.com/apache/incubator-dubbo/pull/1511
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/RefConf.java
 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/RefConf.java
new file mode 100644
index 00..6f78245775
--- /dev/null
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/RefConf.java
@@ -0,0 +1,107 @@
+/*
+ * Copyright 1999-2012 Alibaba Group.
+ *  
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *  
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *  
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.alibaba.dubbo.config;
+
+/**
+ * Reference  注解对应的实体配置类
+ * 
+ * @author zhouzhipeng
+ */
+public class RefConf {
+
+   public Class interfaceClass = void.class;
+
+   public String interfaceName = "";
+
+   public String version = "";
+
+   public String group = "";
+
+   public String url = "";
+
+   public String client = "";
+
+   public boolean generic = false;
+
+   public boolean injvm = false;
+
+   public boolean check = true;
+
+   public boolean init = false;
+
+   public boolean lazy = false;
+
+   public boolean stubevent = false;
+
+   public String reconnect = "";
+
+   public boolean sticky = false;
+
+   public String proxy = "";
+
+   public String stub = "";
+
+   public String cluster = "";
+
+   public int connections = 0;
+
+   public int callbacks = 0;
+
+   public String onconnect = "";
+
+   public String ondisconnect = "";
+
+   public String owner = "";
+
+   public String layer = "";
+
+   public int retries = 0;
+
+   public String loadbalance = "";
+
+   public boolean async = false;
+
+   public int actives = 0;
+
+   public boolean sent = false;
+
+   public String mock = "";
+
+   public String validation = "";
+
+   public int timeout = 0;
+
+   public String cache = "";
+
+   public String[] filter = {};
+
+   public String[] listener = {};
+
+   public String[] parameters = {};
+
+   public String application = "";
+
+   public String module = "";
+
+   public String consumer = "";
+
+   public String monitor = "";
+
+   public String protocol = "";
+
+   public String[] registry = {};
+
+}
diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
index 1cb58ae28d..f0c734763d 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
@@ -21,10 +21,7 @@
 import com.alibaba.dubbo.common.Version;
 import com.alibaba.dubbo.common.bytecode.Wrapper;
 import com.alibaba.dubbo.common.extension.ExtensionLoader;
-import com.alibaba.dubbo.common.utils.ConfigUtils;
-import com.alibaba.dubbo.common.utils.NetUtils;
-import com.alibaba.dubbo.common.utils.ReflectUtils;
-import com.alibaba.dubbo.common.utils.StringUtils;
+import com.alibaba.dubbo.common.utils.*;
 import com.alibaba.dubbo.config.annotation.Reference;
 import com.alibaba.dubbo.config.model.ApplicationModel;
 import com.alibaba.dubbo.config.model.ConsumerModel;
@@ -44,7 +41,9 @@
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.IOException;
+import java.lang.reflect.Field;
 import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -114,6 +113,46 @@ public ReferenceConfig(Reference reference) {
 appendAnnotation(Reference.class, reference);
 }
 
+
+/**
+ * 新增构造函数，支持RefConf配置实体类
+ * @param referenceConf
+ */
+public ReferenceConfig(RefConf referenceConf) {
+Field[] fields = referenceConf.getClass().getFields();
+for (Field field : fields) {
+if (field.getType() != void.class
+&& ! Modifier.isStatic(field.getModifiers())) {
+try {
+String property = field.getName();
+if ("interfaceClass".equals(property) || 
"interfaceName".equals(property)) {
+property = "interface";
+}
+   

[GitHub] ralf0131 commented on issue #1545: 怎样禁用qos-server，因为我是spark项目，一台服务器会启动多个，导致端口冲突

[GitBox]

ralf0131 commented on issue #1545: 怎样禁用qos-server，因为我是spark项目，一台服务器会启动多个，导致端口冲突
URL: 
https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379529175
 
 
   Hi, welcome!
   
   Would you please update the title and description using English? Dubbo is a 
global community and we would like the issue to be seen by people all over the 
world.
   
   Questions like this are expected to be asked in the mailing list, you can 
[subscribe](https://github.com/apache/incubator-dubbo/issues/1393) and ask 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 commented on issue #1511: Add feature：require Reference service dynamically

[GitBox]

beiwei30 commented on issue #1511: Add feature：require Reference service 
dynamically
URL: https://github.com/apache/incubator-dubbo/pull/1511#issuecomment-379529154
 
 
   I am afraid I cannot accept this change because the following reasons:
   
   1. From dubbo's user doc, the group is designed to distinguish the different 
impls as you planned to give the support here, see 
http://dubbo.apache.org/books/dubbo-user-book/demos/service-group.html. That 
is, you could always look up the desired ReferenceBean with the given id, that 
means `DynamicReferenceService` is unnecessary
   
   ```java
   
   
   ``` 
   
   2. I am not convinced that RefConf should be introduced, since it looks very 
familiar with 
com.alibaba.dubbo.config.ReferenceConfig#ReferenceConfig(com.alibaba.dubbo.config.annotation.Reference)
   3. com.alibaba.dubbo.config.spring.AnnotationBean is deprecated, we should 
not add more functionality on this class
   4. some minor issues including:
   * missing license header
   * comments in Chinese
   * author info should be removed
   
   Feel free to reopen and let's discuss further if appropriated.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

[GitBox]

ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985
 
 
   @cvictory 
   No, isShutdown() will always return true when you invoke shutdown() or 
shutdownNow().
   please confirm this, newThreadToCloseExecutor always can't invoke thank you
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] haiyang1985 opened a new issue #1567: cannot set retry.period for FailbackRegistry

[GitBox]

haiyang1985 opened a new issue #1567: cannot set retry.period for 
FailbackRegistry
URL: https://github.com/apache/incubator-dubbo/issues/1567
 
 
   I want to turn off the FailbackRegistry retry or set a long retry period. 
From the code, dubbo is able to get retry.period parameter from the registry 
URL. But, it's not enabled by RegistryConfig or dubbo.xsd(registryType).
   
   public FailbackRegistry(URL url) {
   int retryPeriod = url.getParameter(Constants.REGISTRY_RETRY_PERIOD_KEY, 
Constants.DEFAULT_REGISTRY_RETRY_PERIOD);
   }
   
   By check the RegistryConfig or dubbo.xsd, i cannot find the period 
parameter. So, i am not able to set the retry.period parameter both in xml and 
annotation configuration. Any ability for me to do that?
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

[GitBox]

ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985
 
 
   @cvictory 
   No, isShutdown() will always return true when you invoke shutdown() or 
shutdownNow().
   please confirm this, thank you
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yosaku01 closed issue #1544: Does dubbo supports netty 4?

[GitBox]

yosaku01 closed issue #1544: Does dubbo supports netty 4?
URL: https://github.com/apache/incubator-dubbo/issues/1544
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 opened a new issue #1566: more checkstyle rules needed

[GitBox]

beiwei30 opened a new issue #1566: more checkstyle rules needed
URL: https://github.com/apache/incubator-dubbo/issues/1566
 
 
   I've merged PR#1513, but we still need to add more rules. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed pull request #1558: [Dubbo-1513] add checkstyle with basic rule

[GitBox]

beiwei30 closed pull request #1558: [Dubbo-1513] add checkstyle with basic rule
URL: https://github.com/apache/incubator-dubbo/pull/1558
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/codestyle/checkstyle-header.txt b/codestyle/checkstyle-header.txt
new file mode 100644
index 00..e87628e475
--- /dev/null
+++ b/codestyle/checkstyle-header.txt
@@ -0,0 +1,16 @@
+^\Q/*\E$
+^\Q * Licensed to the Apache Software Foundation (ASF) under one or more\E$
+^\Q * contributor license agreements.  See the NOTICE file distributed with\E$
+^\Q * this work for additional information regarding copyright ownership.\E$
+^\Q * The ASF licenses this file to You under the Apache License, Version 
2.0\E$
+^\Q * (the "License"); you may not use this file except in compliance with\E$
+^\Q * the License.  You may obtain a copy of the License at\E$
+^\Q *\E$
+^\Q * http://www.apache.org/licenses/LICENSE-2.0\E$
+^\Q *\E$
+^\Q * Unless required by applicable law or agreed to in writing, software\E$
+^\Q * distributed under the License is distributed on an "AS IS" BASIS,\E$
+^\Q * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.\E$
+^\Q * See the License for the specific language governing permissions and\E$
+^\Q * limitations under the License.\E$
+^\Q */\E$
\ No newline at end of file
diff --git a/codestyle/checkstyle-suppressions.xml 
b/codestyle/checkstyle-suppressions.xml
new file mode 100644
index 00..1817cf762c
--- /dev/null
+++ b/codestyle/checkstyle-suppressions.xml
@@ -0,0 +1,8 @@
+
+http://www.puppycrawl.com/dtds/suppressions_1_1.dtd;>
+
+
+
+
\ No newline at end of file
diff --git a/codestyle/checkstyle.xml b/codestyle/checkstyle.xml
new file mode 100644
index 00..a8923fa6ac
--- /dev/null
+++ b/codestyle/checkstyle.xml
@@ -0,0 +1,29 @@
+
+http://checkstyle.sourceforge.net/dtds/configuration_1_3.dtd;>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java
 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java
index 93168d0893..f19428cfb9 100644
--- 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java
+++ 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java
@@ -21,7 +21,16 @@
 import com.alibaba.dubbo.common.logger.LoggerFactory;
 import com.alibaba.dubbo.common.utils.ConcurrentHashSet;
 import com.alibaba.dubbo.common.utils.ReflectUtils;
-import com.alibaba.dubbo.config.*;
+import com.alibaba.dubbo.config.AbstractConfig;
+import com.alibaba.dubbo.config.ApplicationConfig;
+import com.alibaba.dubbo.config.ConsumerConfig;
+import com.alibaba.dubbo.config.ModuleConfig;
+import com.alibaba.dubbo.config.MonitorConfig;
+import com.alibaba.dubbo.config.ProtocolConfig;
+import com.alibaba.dubbo.config.ProviderConfig;
+import com.alibaba.dubbo.config.ReferenceConfig;
+import com.alibaba.dubbo.config.RegistryConfig;
+import com.alibaba.dubbo.config.ServiceConfig;
 import com.alibaba.dubbo.config.annotation.Reference;
 import com.alibaba.dubbo.config.annotation.Service;
 import org.springframework.beans.BeansException;
diff --git 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/AbstractAnnotationConfigBeanBuilder.java
 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/AbstractAnnotationConfigBeanBuilder.java
index 629af68fa6..fc8d3f4610 100644
--- 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/AbstractAnnotationConfigBeanBuilder.java
+++ 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/AbstractAnnotationConfigBeanBuilder.java
@@ -16,7 +16,11 @@
  */
 package com.alibaba.dubbo.config.spring.beans.factory.annotation;
 
-import com.alibaba.dubbo.config.*;
+import com.alibaba.dubbo.config.AbstractInterfaceConfig;
+import com.alibaba.dubbo.config.ApplicationConfig;
+import com.alibaba.dubbo.config.ModuleConfig;
+import com.alibaba.dubbo.config.MonitorConfig;
+import com.alibaba.dubbo.config.RegistryConfig;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.springframework.context.ApplicationContext;
diff --git 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/DubboComponentScan.java
 

[GitHub] beiwei30 commented on issue #1558: [Dubbo-1513] add checkstyle with basic rule

[GitBox]

beiwei30 commented on issue #1558: [Dubbo-1513] add checkstyle with basic rule
URL: https://github.com/apache/incubator-dubbo/pull/1558#issuecomment-379526785
 
 
   I think this is a good start. I will accept the change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed issue #1513: [Suggestion] Add checkstyle for CI

[GitBox]

beiwei30 closed issue #1513: [Suggestion] Add checkstyle for CI
URL: https://github.com/apache/incubator-dubbo/issues/1513
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: List volume and issue tracking

[Minxuan Zhuang]

+1

On Sun, Apr 8, 2018 at 3:08 PM, shang zonghai 
wrote:

> +1
>
> Kind regards,
> yiji
>

Re: List volume and issue tracking

[shang zonghai]

+1

Kind regards,
yiji

Re: List volume and issue tracking

[Mercy]

+1.

Kind regards,
Mercy Ma


在 2018/4/8 下午2:52, wanhuhou 写道:

+1
from Alimail Windows--发件人：Wang 
Xin日　期：2018年04月08日 
14:50:53收件人：dev@dubbo.apache.org抄　送：Ian Luo; 
us...@infra.apache.org主　题：Re: List volume and issue tracking+1，It’s good.
dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc



Xin Wang
lovep...@hotmail.com



在 2018年4月8日，下午2:40，Yong Zhu > 
写道：

2018-04-08 14:36 GMT+08:00 Huxing Zhang 
>:

+1

This breakdown looks good to me.


+1, It sounds good.



On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein 
> wrote:
Many projects choose this pattern:

dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc

All GitHub activity is required to be delivered to an ASF mailing list.
It
is up to the (P)PMC to choose which/how. But they cannot be sent to
/dev/null. The above pattern generally provides the right breakdown for
what information people what to monitor.

Cheers,
Greg Stein
Infrastructure Administrator, ASF


On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo 
> wrote:

I think this can be solved by distinguishing github notifications from
regular dev@dubbo.apache.org traffic.  For github 
notifications,
including issue and pull request, the update message should only go to
the
interested parties who are involved in this particular topic, but @dev
should never be the audience.

I guess @dev mail list is configured in 'Settings -> Integrations &
Services -> Email' for 
github.com/apache/inclubator-dubbo* 
projects. I
am
not sure who I should contact therefore I am here cc-ing
us...@infra.apache.org.

I suggest to remove @dev mail list from github subscription list.

Thanks,
-Ian.



On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang 
> wrote:

Hi,

I am +1 on split the traffic of @dev list.

The issue appears after migrating repo to ASF. I use
"label:asf-dubbo-dev -[github]" to filter out them. :(

On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu 
> wrote:
I have the same feeling.

IMO, all the issue emails should be sent to 
iss...@dubbo.apache.org,
all

+1. All issues and the comments should go there.

the PR emails should be sent to 
comm...@dubbo.apache.org. How do you
think?

-1. commit@ are used when code are committed to repo, I don't think
PRs should go there.
Once a PR is accepted, a message will be sent to commit@

My suggestion is PRs and the comments should go to issues@, or we can
create a new list prs@.

and who can help to fix this?

And I think we should use github issues, and move all the Jira
issues to
github.

2018-04-03 16:43 GMT+08:00 Mark Thomas 
>:

All,

I've been away for just over a week and come back to find over 300
unread emails on the dev list.

A large proportion of these messages are comments on pull requests?
Is
dev@ the right list for those?

Another large proportion appear to be comments on issues? Is dev@
the
right list for those?

Generally, the recommendation is to split into multiple lists based
on
audience rather than topic. For some projects it therefore makes
sense
to have all dev related traffic going to a single list. For others,
particularly large projects, it makes sense to split the dev
traffic.

The project appears to be using GitHub issues and Jira. That is
confusing. I'd recommend that you select one issue tracker and stick
to it.

There was discussion[1] on the mailing list and the community has
decided to use github issues.
My understanding is that currently JIRA is only used for GSOC ideas
and track existing issues prior to that decision.
I am +0 on migrating the existing JIRA issues to github issues.


Finally, the github issues seem to be a mix of bugs and support
questions. Is that the way the podling wants to use github issues?

People get used to ask questions by creating an issue before joining
ASF.
The PPMC are trying to tell users to use mailing list to ask questions
by leaving message on the issues, so does the website.
But I think it will take some time.


I have no view on what the 'right' answers to the above questions
are.
I'm asking them to get the podling thinking about the issues. What,
if
anything, to do about any of the above is for the podling to decide.


Mark



[1] 

Re: List volume and issue tracking

[Ian Luo]

+1

It sounds very reasonable.

-Ian.

> On 8 Apr 2018, at 2:52 PM, wanhuhou  wrote:
> 
> 
> +1
> from Alimail 
> Windows--发件人：Wang
>  Xin日　期：2018年04月08日 
> 14:50:53收件人：dev@dubbo.apache.org抄　送：Ian 
> Luo; us...@infra.apache.org主　题：Re: 
> List volume and issue tracking+1，It’s good.
> dev@ -- the development community's discussions
> commits@ -- commit emails
> issues@ -- all emails related to issues (GitHub/Jira)
> notifications@ -- PR notifications, etc
> 
> 
> 
> Xin Wang
> lovep...@hotmail.com
> 
> 
> 
> 在 2018年4月8日，下午2:40，Yong Zhu 
> > 写道：
> 
> 2018-04-08 14:36 GMT+08:00 Huxing Zhang 
> >:
> 
> +1
> 
> This breakdown looks good to me.
> 
> 
> +1, It sounds good.
> 
> 
> 
> On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein 
> > wrote:
> Many projects choose this pattern:
> 
> dev@ -- the development community's discussions
> commits@ -- commit emails
> issues@ -- all emails related to issues (GitHub/Jira)
> notifications@ -- PR notifications, etc
> 
> All GitHub activity is required to be delivered to an ASF mailing list.
> It
> is up to the (P)PMC to choose which/how. But they cannot be sent to
> /dev/null. The above pattern generally provides the right breakdown for
> what information people what to monitor.
> 
> Cheers,
> Greg Stein
> Infrastructure Administrator, ASF
> 
> 
> On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo 
> > wrote:
> 
> I think this can be solved by distinguishing github notifications from
> regular dev@dubbo.apache.org traffic.  For 
> github notifications,
> including issue and pull request, the update message should only go to
> the
> interested parties who are involved in this particular topic, but @dev
> should never be the audience.
> 
> I guess @dev mail list is configured in 'Settings -> Integrations &
> Services -> Email' for 
> github.com/apache/inclubator-dubbo*
>  projects. I
> am
> not sure who I should contact therefore I am here cc-ing
> us...@infra.apache.org.
> 
> I suggest to remove @dev mail list from github subscription list.
> 
> Thanks,
> -Ian.
> 
> 
> 
> On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang 
> > wrote:
> 
> Hi,
> 
> I am +1 on split the traffic of @dev list.
> 
> The issue appears after migrating repo to ASF. I use
> "label:asf-dubbo-dev -[github]" to filter out them. :(
> 
> On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu 
> > wrote:
> I have the same feeling.
> 
> IMO, all the issue emails should be sent to 
> iss...@dubbo.apache.org,
> all
> 
> +1. All issues and the comments should go there.
> 
> the PR emails should be sent to 
> comm...@dubbo.apache.org. How do you
> think?
> 
> -1. commit@ are used when code are committed to repo, I don't think
> PRs should go there.
> Once a PR is accepted, a message will be sent to commit@
> 
> My suggestion is PRs and the comments should go to issues@, or we can
> create a new list prs@.
> 
> and who can help to fix this?
> 
> And I think we should use github issues, and move all the Jira
> issues to
> github.
> 
> 2018-04-03 16:43 GMT+08:00 Mark Thomas 
> >:
> 
> All,
> 
> I've been away for just over a week and come back to find over 300
> unread emails on the dev list.
> 
> A large proportion of these messages are comments on pull requests?
> Is
> dev@ the right list for those?
> 
> Another large proportion appear to be comments on issues? Is dev@
> the
> right list for those?
> 
> Generally, the recommendation is to split into multiple lists based
> on
> audience rather than topic. For some projects it therefore makes
> sense
> to have all dev related traffic going to a single list. For others,
> particularly large projects, it makes sense to split the dev
> traffic.
> 
> The project appears to be using GitHub issues and Jira. That is
> confusing. I'd recommend that you select one issue tracker and stick
> to it.
> 
> There was discussion[1] on the mailing list and the community has
> decided to use github issues.
> My understanding is that currently JIRA is only used for GSOC ideas
> and track existing issues prior to that decision.
> I am +0 on migrating the existing JIRA issues to github issues.
> 
> 
> Finally, the github issues seem to be a mix of bugs and support
> questions. Is that the way the podling wants to use github issues?
> 
> People get used to ask questions by creating an issue before joining
> ASF.
> The PPMC are trying to tell users 

[GitHub] tangdu commented on issue #1545: 怎样禁用qos-server，因为我是spark项目，一台服务器会启动多个，导致端口冲突

[GitBox]

tangdu commented on issue #1545: 怎样禁用qos-server，因为我是spark项目，一台服务器会启动多个，导致端口冲突
URL: 
https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379525709
 
 
   @8967 dubbo.application.qos.enable=false


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Re: List volume and issue tracking

[wanhuhou]

+1
from Alimail 
Windows--发件人：Wang
 Xin日　期：2018年04月08日 
14:50:53收件人：dev@dubbo.apache.org抄　送：Ian 
Luo; us...@infra.apache.org主　题：Re: 
List volume and issue tracking+1，It’s good.
dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc



Xin Wang
lovep...@hotmail.com



在 2018年4月8日，下午2:40，Yong Zhu > 
写道：

2018-04-08 14:36 GMT+08:00 Huxing Zhang 
>:

+1

This breakdown looks good to me.


+1, It sounds good.



On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein 
> wrote:
Many projects choose this pattern:

dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc

All GitHub activity is required to be delivered to an ASF mailing list.
It
is up to the (P)PMC to choose which/how. But they cannot be sent to
/dev/null. The above pattern generally provides the right breakdown for
what information people what to monitor.

Cheers,
Greg Stein
Infrastructure Administrator, ASF


On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo 
> wrote:

I think this can be solved by distinguishing github notifications from
regular dev@dubbo.apache.org traffic.  For github 
notifications,
including issue and pull request, the update message should only go to
the
interested parties who are involved in this particular topic, but @dev
should never be the audience.

I guess @dev mail list is configured in 'Settings -> Integrations &
Services -> Email' for 
github.com/apache/inclubator-dubbo* 
projects. I
am
not sure who I should contact therefore I am here cc-ing
us...@infra.apache.org.

I suggest to remove @dev mail list from github subscription list.

Thanks,
-Ian.



On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang 
> wrote:

Hi,

I am +1 on split the traffic of @dev list.

The issue appears after migrating repo to ASF. I use
"label:asf-dubbo-dev -[github]" to filter out them. :(

On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu 
> wrote:
I have the same feeling.

IMO, all the issue emails should be sent to 
iss...@dubbo.apache.org,
all

+1. All issues and the comments should go there.

the PR emails should be sent to 
comm...@dubbo.apache.org. How do you
think?

-1. commit@ are used when code are committed to repo, I don't think
PRs should go there.
Once a PR is accepted, a message will be sent to commit@

My suggestion is PRs and the comments should go to issues@, or we can
create a new list prs@.

and who can help to fix this?

And I think we should use github issues, and move all the Jira
issues to
github.

2018-04-03 16:43 GMT+08:00 Mark Thomas 
>:

All,

I've been away for just over a week and come back to find over 300
unread emails on the dev list.

A large proportion of these messages are comments on pull requests?
Is
dev@ the right list for those?

Another large proportion appear to be comments on issues? Is dev@
the
right list for those?

Generally, the recommendation is to split into multiple lists based
on
audience rather than topic. For some projects it therefore makes
sense
to have all dev related traffic going to a single list. For others,
particularly large projects, it makes sense to split the dev
traffic.

The project appears to be using GitHub issues and Jira. That is
confusing. I'd recommend that you select one issue tracker and stick
to it.

There was discussion[1] on the mailing list and the community has
decided to use github issues.
My understanding is that currently JIRA is only used for GSOC ideas
and track existing issues prior to that decision.
I am +0 on migrating the existing JIRA issues to github issues.


Finally, the github issues seem to be a mix of bugs and support
questions. Is that the way the podling wants to use github issues?

People get used to ask questions by creating an issue before joining
ASF.
The PPMC are trying to tell users to use mailing list to ask questions
by leaving message on the issues, so does the website.
But I think it will take some time.


I have no view on what the 'right' answers to the above questions
are.
I'm asking them to get the podling thinking about the issues. What,
if
anything, to do about any of the above is for the podling to decide.


Mark



[1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b

Re: List volume and issue tracking

[Wang Xin]

+1，It’s good.
dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc



Xin Wang
lovep...@hotmail.com



在 2018年4月8日，下午2:40，Yong Zhu > 
写道：

2018-04-08 14:36 GMT+08:00 Huxing Zhang 
>:

+1

This breakdown looks good to me.


+1, It sounds good.



On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein 
> wrote:
Many projects choose this pattern:

dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc

All GitHub activity is required to be delivered to an ASF mailing list.
It
is up to the (P)PMC to choose which/how. But they cannot be sent to
/dev/null. The above pattern generally provides the right breakdown for
what information people what to monitor.

Cheers,
Greg Stein
Infrastructure Administrator, ASF


On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo 
> wrote:

I think this can be solved by distinguishing github notifications from
regular dev@dubbo.apache.org traffic.  For github 
notifications,
including issue and pull request, the update message should only go to
the
interested parties who are involved in this particular topic, but @dev
should never be the audience.

I guess @dev mail list is configured in 'Settings -> Integrations &
Services -> Email' for 
github.com/apache/inclubator-dubbo* 
projects. I
am
not sure who I should contact therefore I am here cc-ing
us...@infra.apache.org.

I suggest to remove @dev mail list from github subscription list.

Thanks,
-Ian.



On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang 
> wrote:

Hi,

I am +1 on split the traffic of @dev list.

The issue appears after migrating repo to ASF. I use
"label:asf-dubbo-dev -[github]" to filter out them. :(

On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu 
> wrote:
I have the same feeling.

IMO, all the issue emails should be sent to 
iss...@dubbo.apache.org,
all

+1. All issues and the comments should go there.

the PR emails should be sent to 
comm...@dubbo.apache.org. How do you
think?

-1. commit@ are used when code are committed to repo, I don't think
PRs should go there.
Once a PR is accepted, a message will be sent to commit@

My suggestion is PRs and the comments should go to issues@, or we can
create a new list prs@.

and who can help to fix this?

And I think we should use github issues, and move all the Jira
issues to
github.

2018-04-03 16:43 GMT+08:00 Mark Thomas 
>:

All,

I've been away for just over a week and come back to find over 300
unread emails on the dev list.

A large proportion of these messages are comments on pull requests?
Is
dev@ the right list for those?

Another large proportion appear to be comments on issues? Is dev@
the
right list for those?

Generally, the recommendation is to split into multiple lists based
on
audience rather than topic. For some projects it therefore makes
sense
to have all dev related traffic going to a single list. For others,
particularly large projects, it makes sense to split the dev
traffic.

The project appears to be using GitHub issues and Jira. That is
confusing. I'd recommend that you select one issue tracker and stick
to it.

There was discussion[1] on the mailing list and the community has
decided to use github issues.
My understanding is that currently JIRA is only used for GSOC ideas
and track existing issues prior to that decision.
I am +0 on migrating the existing JIRA issues to github issues.


Finally, the github issues seem to be a mix of bugs and support
questions. Is that the way the podling wants to use github issues?

People get used to ask questions by creating an issue before joining
ASF.
The PPMC are trying to tell users to use mailing list to ask questions
by leaving message on the issues, so does the website.
But I think it will take some time.


I have no view on what the 'right' answers to the above questions
are.
I'm asking them to get the podling thinking about the issues. What,
if
anything, to do about any of the above is for the podling to decide.


Mark



[1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
--
Best Regards！
Huxing






--
Best Regards！
Huxing

If someaone have a usage question, what should he do?

[shengli cao]

Hi everyone:

 I found some issues in github are usage questions, such as
https://github.com/apache/incubator-dubbo/issues/1522 ,
https://github.com/apache/incubator-dubbo/issues/1523.

 I have some experience when I have some question about spring boot.
If you have some question about spring boot, you should :
 1. Ask the question in stackoverflow with tag 'spring-boot'.  Refer
to：
https://github.com/spring-projects/spring-boot/blob/master/CONTRIBUTING.adoc#using-github-issues
 2. Or you can join the gitter :gitter.im/spring-projects/spring-boot ,
then ask the question there.
 If you donot follow this rule and you ask the question in github
issue, your issue will be added label named "for: stackoverflow" and
closed. Such as :
https://github.com/spring-projects/spring-boot/issues/11907.

 As follow, I think we use GitHub issues to track bugs and
enhancements. The dubbo project can also follow this rule:
 1.  If you have a general usage question please ask on  stackoverflow.
 Our developer should  monitor the 'dubbo' tag.
 2. If he want have the answer quickly, he can join out gitter about
dubbo.
 3. We should close the issue in github about question, add a label
named 'stackoverflow' , and guide them to stackoverflow at that they can
ask the question.




-- 

Best Regard!
cvictory

Re: List volume and issue tracking

[shang zonghai]

I was also confused by a lot of mixed emails.

For this topic, I have the following suggestions:

1. All pull requests are sent to the current 
dev@dubbo.apache.org.

Pr contains final solution to problem solution or feature enhancement 
capabilities, all users and developers are more concerned.

2. All issues are only sent to 
is...@dubbo.apache.org.

Issue contains classmates or bug feedback for help, Developers are more 
concerned and give guidance and help.

3. Important content or discussion sent to 
dev@dubbo.apache.org.

For example, issues that need to be discussed when initiating a vote or related 
incubator project, but does not include issues on github.


Thanks,
yiji

Re: List volume and issue tracking

[Huxing Zhang]

+1

This breakdown looks good to me.

On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein  wrote:
> Many projects choose this pattern:
>
> dev@ -- the development community's discussions
> commits@ -- commit emails
> issues@ -- all emails related to issues (GitHub/Jira)
> notifications@ -- PR notifications, etc
>
> All GitHub activity is required to be delivered to an ASF mailing list. It
> is up to the (P)PMC to choose which/how. But they cannot be sent to
> /dev/null. The above pattern generally provides the right breakdown for
> what information people what to monitor.
>
> Cheers,
> Greg Stein
> Infrastructure Administrator, ASF
>
>
> On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo  wrote:
>
>> I think this can be solved by distinguishing github notifications from
>> regular dev@dubbo.apache.org traffic.  For github notifications,
>> including issue and pull request, the update message should only go to the
>> interested parties who are involved in this particular topic, but @dev
>> should never be the audience.
>>
>> I guess @dev mail list is configured in 'Settings -> Integrations &
>> Services -> Email' for github.com/apache/inclubator-dubbo* projects. I am
>> not sure who I should contact therefore I am here cc-ing
>> us...@infra.apache.org.
>>
>> I suggest to remove @dev mail list from github subscription list.
>>
>> Thanks,
>> -Ian.
>>
>>
>>
>> On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang  wrote:
>>
>>> Hi,
>>>
>>> I am +1 on split the traffic of @dev list.
>>>
>>> The issue appears after migrating repo to ASF. I use
>>> "label:asf-dubbo-dev -[github]" to filter out them. :(
>>>
>>> On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu  wrote:
>>> > I have the same feeling.
>>> >
>>> > IMO, all the issue emails should be sent to iss...@dubbo.apache.org,
>>> all
>>>
>>> +1. All issues and the comments should go there.
>>>
>>> > the PR emails should be sent to comm...@dubbo.apache.org. How do you
>>> think?
>>>
>>> -1. commit@ are used when code are committed to repo, I don't think
>>> PRs should go there.
>>> Once a PR is accepted, a message will be sent to commit@
>>>
>>> My suggestion is PRs and the comments should go to issues@, or we can
>>> create a new list prs@.
>>>
>>> > and who can help to fix this?
>>> >
>>> > And I think we should use github issues, and move all the Jira issues to
>>> > github.
>>> >
>>> > 2018-04-03 16:43 GMT+08:00 Mark Thomas :
>>> >
>>> >> All,
>>> >>
>>> >> I've been away for just over a week and come back to find over 300
>>> >> unread emails on the dev list.
>>> >>
>>> >> A large proportion of these messages are comments on pull requests? Is
>>> >> dev@ the right list for those?
>>> >>
>>> >> Another large proportion appear to be comments on issues? Is dev@ the
>>> >> right list for those?
>>> >>
>>> >> Generally, the recommendation is to split into multiple lists based on
>>> >> audience rather than topic. For some projects it therefore makes sense
>>> >> to have all dev related traffic going to a single list. For others,
>>> >> particularly large projects, it makes sense to split the dev traffic.
>>> >>
>>> >> The project appears to be using GitHub issues and Jira. That is
>>> >> confusing. I'd recommend that you select one issue tracker and stick
>>> to it.
>>>
>>> There was discussion[1] on the mailing list and the community has
>>> decided to use github issues.
>>> My understanding is that currently JIRA is only used for GSOC ideas
>>> and track existing issues prior to that decision.
>>> I am +0 on migrating the existing JIRA issues to github issues.
>>>
>>> >>
>>> >> Finally, the github issues seem to be a mix of bugs and support
>>> >> questions. Is that the way the podling wants to use github issues?
>>>
>>> People get used to ask questions by creating an issue before joining ASF.
>>> The PPMC are trying to tell users to use mailing list to ask questions
>>> by leaving message on the issues, so does the website.
>>> But I think it will take some time.
>>>
>>> >>
>>> >> I have no view on what the 'right' answers to the above questions are.
>>> >> I'm asking them to get the podling thinking about the issues. What, if
>>> >> anything, to do about any of the above is for the podling to decide.
>>> >>
>>> >>
>>> >> Mark
>>> >>
>>>
>>>
>>> [1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
>>> ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
>>> --
>>> Best Regards！
>>> Huxing
>>>
>>
>>



-- 
Best Regards！
Huxing

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936906
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java
 ##
 @@ -60,7 +65,7 @@
  */
 public class ReferenceAnnotationBeanPostProcessor extends 
InstantiationAwareBeanPostProcessorAdapter
 implements MergedBeanDefinitionPostProcessor, PriorityOrdered, 
ApplicationContextAware, BeanClassLoaderAware,
-DisposableBean {
+DisposableBean, ApplicationListener {
 
 Review comment:
   I always think that @EnableDubbo (basepackage="com.xxx") since it supports 
packet scanning, should avoid having the user repeatedly configure the same 
@ComponentScan(basepackage="com.xxx").


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: List volume and issue tracking

[Greg Stein]

Many projects choose this pattern:

dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc

All GitHub activity is required to be delivered to an ASF mailing list. It
is up to the (P)PMC to choose which/how. But they cannot be sent to
/dev/null. The above pattern generally provides the right breakdown for
what information people what to monitor.

Cheers,
Greg Stein
Infrastructure Administrator, ASF


On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo  wrote:

> I think this can be solved by distinguishing github notifications from
> regular dev@dubbo.apache.org traffic.  For github notifications,
> including issue and pull request, the update message should only go to the
> interested parties who are involved in this particular topic, but @dev
> should never be the audience.
>
> I guess @dev mail list is configured in 'Settings -> Integrations &
> Services -> Email' for github.com/apache/inclubator-dubbo* projects. I am
> not sure who I should contact therefore I am here cc-ing
> us...@infra.apache.org.
>
> I suggest to remove @dev mail list from github subscription list.
>
> Thanks,
> -Ian.
>
>
>
> On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang  wrote:
>
>> Hi,
>>
>> I am +1 on split the traffic of @dev list.
>>
>> The issue appears after migrating repo to ASF. I use
>> "label:asf-dubbo-dev -[github]" to filter out them. :(
>>
>> On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu  wrote:
>> > I have the same feeling.
>> >
>> > IMO, all the issue emails should be sent to iss...@dubbo.apache.org,
>> all
>>
>> +1. All issues and the comments should go there.
>>
>> > the PR emails should be sent to comm...@dubbo.apache.org. How do you
>> think?
>>
>> -1. commit@ are used when code are committed to repo, I don't think
>> PRs should go there.
>> Once a PR is accepted, a message will be sent to commit@
>>
>> My suggestion is PRs and the comments should go to issues@, or we can
>> create a new list prs@.
>>
>> > and who can help to fix this?
>> >
>> > And I think we should use github issues, and move all the Jira issues to
>> > github.
>> >
>> > 2018-04-03 16:43 GMT+08:00 Mark Thomas :
>> >
>> >> All,
>> >>
>> >> I've been away for just over a week and come back to find over 300
>> >> unread emails on the dev list.
>> >>
>> >> A large proportion of these messages are comments on pull requests? Is
>> >> dev@ the right list for those?
>> >>
>> >> Another large proportion appear to be comments on issues? Is dev@ the
>> >> right list for those?
>> >>
>> >> Generally, the recommendation is to split into multiple lists based on
>> >> audience rather than topic. For some projects it therefore makes sense
>> >> to have all dev related traffic going to a single list. For others,
>> >> particularly large projects, it makes sense to split the dev traffic.
>> >>
>> >> The project appears to be using GitHub issues and Jira. That is
>> >> confusing. I'd recommend that you select one issue tracker and stick
>> to it.
>>
>> There was discussion[1] on the mailing list and the community has
>> decided to use github issues.
>> My understanding is that currently JIRA is only used for GSOC ideas
>> and track existing issues prior to that decision.
>> I am +0 on migrating the existing JIRA issues to github issues.
>>
>> >>
>> >> Finally, the github issues seem to be a mix of bugs and support
>> >> questions. Is that the way the podling wants to use github issues?
>>
>> People get used to ask questions by creating an issue before joining ASF.
>> The PPMC are trying to tell users to use mailing list to ask questions
>> by leaving message on the issues, so does the website.
>> But I think it will take some time.
>>
>> >>
>> >> I have no view on what the 'right' answers to the above questions are.
>> >> I'm asking them to get the podling thinking about the issues. What, if
>> >> anything, to do about any of the above is for the podling to decide.
>> >>
>> >>
>> >> Mark
>> >>
>>
>>
>> [1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
>> ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
>> --
>> Best Regards！
>> Huxing
>>
>
>

[GitHub] codecov-io commented on issue #1380: upgrade libthrift version and add nature thrift support option

[GitBox]

codecov-io commented on issue #1380: upgrade libthrift version and add nature 
thrift support option 
URL: https://github.com/apache/incubator-dubbo/pull/1380#issuecomment-367338110
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=h1) 
Report
   > Merging 
[#1380](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/f4bd1b5f2cd54a7fd4944944f94d38bc5a2b1730?src=pr=desc)
 will **decrease** coverage by `2.61%`.
   > The diff coverage is `4.54%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/graphs/tree.svg?width=650=VnEIkiFQT0=150=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1380  +/-   ##
   ==
   - Coverage   32.16%   29.54%   -2.62% 
   ==
 Files 682  685   +3 
 Lines   3297235910+2938 
 Branches 6597 6990 +393 
   ==
   + Hits1060410610   +6 
   - Misses  2047323406+2933 
   + Partials 1895 1894   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...java/com/alibaba/dubbo/demo/ThriftDemoService.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2RlbW8vVGhyaWZ0RGVtb1NlcnZpY2UuamF2YQ==)
 | `0% <ø> (ø)` | |
   | 
[...om/alibaba/dubbo/demo/provider/ThriftProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9UaHJpZnRQcm92aWRlci5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[...onfig/spring/schema/DubboBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9EdWJib0JlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=)
 | `20.81% <0%> (-0.26%)` | :arrow_down: |
   | 
[...om/alibaba/dubbo/demo/provider/ThriftDemoImpl.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9UaHJpZnREZW1vSW1wbC5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[...alibaba/dubbo/rpc/protocol/thrift/ThriftCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L1RocmlmdENvZGVjLmphdmE=)
 | `3.23% <2.22%> (-0.11%)` | :arrow_down: |
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.53% <50%> (+0.09%)` | :arrow_up: |
   | 
[...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=)
 | `57.5% <0%> (-8.75%)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | ... and [5 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=footer).
 Last update 
[f4bd1b5...3e38f9c](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] diecui1202 commented on issue #1500: not support java 10

[GitBox]

diecui1202 commented on issue #1500: not support java 10
URL: 
https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379524152
 
 
   I run the two test cases under Java 10, they're all ok. 
   
   And I also build dubbo under Java 10, there is a NullPointerException which 
is thrown by maven-javadoc-plugin. More details can be obtained from 
https://stackoverflow.com/questions/49460751/execution-attach-javadocs-of-goal-org-apache-maven-pluginsmaven-javadoc-plugin
   
   After upgrade maven-javadoc-plugin to 3.0.1-SNAPSHOT, the build process and 
all test cases pass. 
   
   @hank-whu So I can't repeat your problem. You can review it again and tell 
us if getting the same problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nzomkxia commented on issue #1507: Mirror improvement for test cases in dubbo-rpc-api module

[GitBox]

nzomkxia commented on issue #1507: Mirror improvement for test cases in 
dubbo-rpc-api module
URL: https://github.com/apache/incubator-dubbo/pull/1507#issuecomment-379524103
 
 
   all tests are passed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

[GitBox]

ralf0131 commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and 
replace ServiceConfig vars by Constants.
URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379524089
 
 
   I think this pull request contains two separated enhancement.
   
   1. SerivceAnnotationBeanPostProcessor bug 
   2. replace ServiceConfig vars by Constants
   
   If they are not related, please separate them into two pull request.
   For the SerivceAnnotationBeanPostProcessor bug fix, please make sure there 
is an issue describing what the bug is and if you can provide a test case to 
reproduce it, that will be better.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936710
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java
 ##
 @@ -60,7 +65,7 @@
  */
 public class ReferenceAnnotationBeanPostProcessor extends 
InstantiationAwareBeanPostProcessorAdapter
 implements MergedBeanDefinitionPostProcessor, PriorityOrdered, 
ApplicationContextAware, BeanClassLoaderAware,
-DisposableBean {
+DisposableBean, ApplicationListener {
 
 Review comment:
   I think the default service delay reference can be solved， the default 
implementation references the service ahead of time, resulting in an NPE


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936669
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
 ##
 @@ -98,13 +110,88 @@ public void 
postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) t
 Set resolvedPackagesToScan = 
resolvePackagesToScan(packagesToScan);
 
 if (!CollectionUtils.isEmpty(resolvedPackagesToScan)) {
+
+// register @Service
 registerServiceBeans(resolvedPackagesToScan, registry);
+
+// register @Component
+registerComponentBeans(resolvedPackagesToScan, registry);
 } else {
 if (logger.isWarnEnabled()) {
 logger.warn("packagesToScan is empty , ServiceBean registry 
will be ignored!");
 }
 }
 
+/**
+ * The solution to consumers early references to unexposed services.
+ */
+deferConfiguationBeans();
+
+}
+
+/**
+ * Registers Beans whose classes was annotated {@link Component}
+ *
+ * @param packagesToScan The base packages to scan
+ * @param registry   {@link BeanDefinitionRegistry}
+ */
+private void registerComponentBeans(Set packagesToScan, 
BeanDefinitionRegistry registry) {
+
+DubboClassPathBeanDefinitionScanner scanner =
+new DubboClassPathBeanDefinitionScanner(registry, environment, 
resourceLoader);
+
+BeanNameGenerator beanNameGenerator = 
resolveBeanNameGenerator(registry);
+
+scanner.setBeanNameGenerator(beanNameGenerator);
+
+scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, 
false));
 
 Review comment:
   Process discovery and @Component under the same service package.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services