Re: [FlexJS] Finding (x,y) position

2017-08-30 Thread Alex Harui
/na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle >x-development.247.n4.nabble.com%2FFlexJS-Layouts-td61120.html%23a61330 >=02%7C01%7C%7C1a363cd8bd364a4e227a08d4efcb16f0%7Cfa7b1b5a7b34438794ae >d2c178decee1%7C0%7C0%7C636397102925232200=ZKnEGJbsPHIJwjtwDy9dkYZcOL &g

Re: Kotlinjs has solved the circular dependency problem. Flexjs, do you have any plans?

2017-08-30 Thread Alex Harui
Lizhi, Are you sure your flash.utils.setTimeout is being referenced by the code? The console output didn't mention a flash.utils.setTimeout. Maybe some other setTimeout is being referenced instead. -Alex On 8/30/17, 2:54 AM, "lizhi" wrote: >0.9 the newest > > > >-

Re: [FlexJS] Finding (x,y) position

2017-08-30 Thread Alex Harui
Hopefully Peter will find a solution based on your input. But I think a problem still exists. The basic problem is how to find the x,y position of a child within its parent. I believe Peter is saying that the x and y getters in UIBase are not reporting correct values in many cases in the

Re: Kotlinjs has solved the circular dependency problem. Flexjs, do you have any plans?

2017-08-30 Thread Alex Harui
Hmm. Somehow the output thinks that setTimeout is not a native function and is looking for a file to match it. How is setTimeout being used in your code? I am done working for today. Will check tomorrow. -Alex On 8/29/17, 10:47 PM, "lizhi" <s...@qq.com> wrote: > >

Re: Kotlinjs has solved the circular dependency problem. Flexjs, do you have any plans?

2017-08-29 Thread Alex Harui
Hi Lizhi, Please post a link to the entire console output from the compile. You can try to use paste.apache.org. Or pastebin.com or other similar service. Thanks, -Alex On 8/29/17, 10:10 PM, "lizhi" <s...@qq.com> wrote: >hi alex harui.which file error? > > >Alex

[DISCUSS} Fork FlexJS from Apache Flex

2017-08-28 Thread Alex Harui
with the compiler code base donated by Adobe nor were they on the initial committers list for Apache Flex other than Alex Harui. Everyone else has earned their way in by contributing and earning merit. Community Many FlexJS users are trying to migrate an existing Apache Flex app off of Adobe Flash

Re: [Flex JS] Flex SDK Installer always get stuck at "Finish uncompressing"

2017-08-28 Thread Alex Harui
Hmm. It isn't obvious to me: 1) if you only have target=JSFlex, why does the compiler care about target-player? 2) Why did -htmlTemplate option not work? Maybe the console output would tell us more, or try putting System.out.println calls into MXMLFlexJSPublisher.java to see why the template

Re: [Flex JS] Flex SDK Installer always get stuck at "Finish uncompressing"

2017-08-28 Thread Alex Harui
Hi Piotr, You might have to change more than that in installer.xml. I think there are other places that fix up flex-sdk-description.xml. Also, try compiling from the command-line to see what the compiler expects vs the IDE. HTH, -Alex On 8/28/17, 12:03 PM, "piotrz"

Re: [Flex JS] Flex SDK Installer always get stuck at "Finish uncompressing"

2017-08-28 Thread Alex Harui
: where java HTH, -Alex On 8/28/17, 8:24 AM, "Alex Harui" <aha...@adobe.com.INVALID> wrote: >I just tried it and it worked for me. > >Do you have any restricted access rights to parts of your file system? I >thought we'd gotten rid of "spaces in path" bugs,

Re: Kotlinjs has solved the circular dependency problem. Flexjs, do you have any plans?

2017-08-28 Thread Alex Harui
Post a link to your console output. That exception often happens when there is no JS file for a class. There should be mention of which file in the console output. -Alex On 8/28/17, 3:50 AM, "lizhi" wrote: >get this error with the option. -remove-circulars > >

Re: [Flex JS] Flex SDK Installer always get stuck at "Finish uncompressing"

2017-08-28 Thread Alex Harui
AIR and Flash are already technically prerequisites, but folks found it so inconvenient compared to the old Adobe distributions that Om and others created the Installer to automate fetching the Flash/AIR bits. Flash Builder, and maybe some other IDEs, expect AIR and Flash files in the SDK folder.

Re: [Flex JS] Flex SDK Installer always get stuck at "Finish uncompressing"

2017-08-28 Thread Alex Harui
I just tried it and it worked for me. Do you have any restricted access rights to parts of your file system? I thought we'd gotten rid of "spaces in path" bugs, but maybe try installing to a folder without spaces in it. Thanks, -Alex On 8/28/17, 4:10 AM, "m_awais" wrote:

Re: [2/2] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35354 - Rename TabsItemRendererFactoryForArrayListData to TabsDynamicItemsRendererFactoryForArrayListData - Update TabsDynamicItemsRendere

2017-08-26 Thread Alex Harui
I'm not sure I understand. Why is this not what's needed? Just because you are trying to get the compiler to not complain? There is a skipFunctionCoercions option that turns off all calls to Language.is. We don't have a directive per occurrence, but I suppose we could. -Alex On 8/26/17, 9:41

Re: FlexJS Issue with multiple assignment

2017-08-26 Thread Alex Harui
setAttribute is not showing up in the spec for me. Is it one of the methods internal to the implementation? If so, can it return the value it receives instead of null? -Alex On 8/26/17, 11:41 AM, "Harbs" wrote: >I just ran into the following issue: > >I have some code

Re: FlexSDK 4.16.0 installer errors

2017-08-24 Thread Alex Harui
There are several workarounds mentioned upthread. To use Ant, get the binary package from [1]. Create a new folder, and unpack the binary package into that folder. Run: ant -f installer.xml -Dair.sdk.version=26 -Dflash.sdk.version=26 The reason we haven't changed the installer is because we

Re: [3/8] git commit: [flex-asjs] [refs/heads/feature/amf] - ClassAliasBead for registering class aliases for AMF

2017-08-22 Thread Alex Harui
=02%7C01%7C% >>7C22c8aa26dc374c22082a08d4e9dcd5ee%7Cfa7b1b5a7b34438794aed2c178decee1%7C0 >>%7C0%7C636390582072240028=uiGQunRnXmygUtU3dLUptCp0lf%2B2kG7TyTeaH9Y >>AUdU%3D=0 >> >> Branch: refs/heads/feature/amf

Re: [Flex/FlexJS] External dependencies (Adobe, Google, ...)

2017-08-22 Thread Alex Harui
For JS output, there shouldn't be any dependencies for FlexJS on anything that isn't open source and with an Apache compatible license. I suppose someone could remove some of the third party files we use from the internet, but I think that's unlikely. FlexJS SWF output should work just fine on

Re: FlexJS Closure warnings

2017-08-22 Thread Alex Harui
We don't do any rewriting right now, but we might be able to rewrite them in the future. One warning I see is from this code: /** * @export * @type {org.apache.flex.core.WrappedHTMLElement} */ positioner: { get: org.apache.flex.core.UIBase.prototype.get__positioner, set:

Re: FlexJS Closure warnings

2017-08-22 Thread Alex Harui
Some are from Closure Library. I haven't really looked into why. I don't think we are on the absolute latest, so we might need to move there. Others are from our code because we are now annotating the Object.defineProperties getter/setters with @type information, but we don't force the inclusion

Re: Work around Chrome bug?

2017-08-21 Thread Alex Harui
rg%2Fp%2Fchromium%2Fissues%2Fdetail%3Fid%3D757196=02%7C01%7C%7C >ffb2d3cdfc694d86db0708d4e867d2c0%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C >0%7C636388979991056998=OsmlLmMJwAtD7xB2tdl1d69eKUp6T3vQZ9BaiDnnyho%3 >D=0 is fixed. > positioner.style.height = "" + Math.ce

Re: FlexJS New errors in Closure Compiler

2017-08-21 Thread Alex Harui
ith this until you have the time. It compiles the code, but >it’s quite large and not minified. > >Harbs > >> On Aug 20, 2017, at 7:03 PM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >> >> A quick look at the GCC code indicates that you are hitting a lim

Re: Work around Chrome bug?

2017-08-20 Thread Alex Harui
I agree that we shouldn't make Math.ceil the default code path. What does the change look like? Could it be post-processed onto the JS output when somebody needs it? I didn't think Opera was one of our target browsers. -Alex On 8/20/17, 1:23 AM, "Harbs" wrote: >I

Re: FlexJS New errors in Closure Compiler

2017-08-20 Thread Alex Harui
A quick look at the GCC code indicates that you are hitting a limit in their control-flow analysis. They had a constant as a gate to detect infinite loops in the control flow. It is possible that there may be a loop in the generated JS or that your app is just too complicated and that constant

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-08-18 Thread Alex Harui
I will have to do more investigation for #1. I don't know if magic properties are the responsibility of the compiler or the IDE's code intelligence. I just pushed a change for #2. It should be using "_id" (with leading underscore) instead of "id". Thanks for catching that, -Alex On 8/17/17,

Re: [FLEXJS] Modules

2017-08-18 Thread Alex Harui
Hi Olaf, Hopefully there is no "magic". I think it works pretty much like regular Flex modules. There is a UIModuleLoader that loads a Mouse compiled and defined from a UIModule. You can defer the downloading and instantiation of the module by controlling when the UIModuleLoader's URL for the

Re: [FlexJS] Failing build for simple example

2017-08-16 Thread Alex Harui
Bummer. There is no way to overwrite the compiler jars? -Alex On 8/16/17, 10:34 AM, "Josh Tynjala" wrote: >Moonshine currently uses the 0.8.0 compiler for code intelligence. Nightly >builds of FlexJS specify a new fxg-base-class compiler option in >flex-config.xml, but

[FLEXJS] Modules

2017-08-15 Thread Alex Harui
Hi, I just pushed a rudimentary version of modules. Regular Flex Modules were separate SWFs of classes that could be compiled separately from the main application and loaded after application startup as well thus helping to manage development time and startup time and download bandwidth. FlexJS

Re: [FlexJS][Docs] Started with some docs using a github repo

2017-08-14 Thread Alex Harui
Note that we can and have given out Apache Flex wiki edit access to non-committers. If the plan is to move this content to Apache someday, it is prudent to make sure contributors have agreed to that before contributing. Having this work contributed directly to the Apache Flex wiki implies that

Re: [FlexJS][AMF] branch feature/amf - Starting the effort!! (Special Thanks to PKumar!)

2017-08-14 Thread Alex Harui
I haven't had time to look into this. Is there an example app that we are trying to make work? Thanks, -Alex On 8/13/17, 3:05 PM, "piotrz" wrote: >Hi, > >I just refreshed with develop branch feature/amf branch if anyone would be >interested in working on AMF

Re: FlexJS

2017-08-13 Thread Alex Harui
: Re: FlexJS InnerHTML could work, but having the ability to use ids and the like is a big advantage. My understanding is that for MXML elements to have children, they need to subclass Group. Is that right? > On Aug 13, 2017, at 4:28 AM, Alex Harui <aha...@adobe.com.INVALID> wrote: > &g

Re: FlexJS

2017-08-12 Thread Alex Harui
> > > > >By “full wrapper” I meant a full set of wrappers. > >> On Aug 13, 2017, at 1:08 AM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >> >> I don't understand your goal

Re: FlexJS

2017-08-12 Thread Alex Harui
I don't understand your goal. What is a "full wrapper"? Many Basic component already wrap HTMLElements. I think there is another set that has the same name as the HTML elements, like Div, A, etc. -Alex On 8/12/17, 2:56 PM, "Harbs" wrote: >Changing the namespace is

Re: [1/2] git commit: [flex-falcon] [refs/heads/develop] - upgrade to Google Closure Compiler 20170626. They deprecated a lot of APIs so lots of changes were required. The primary change is that GCC i

2017-08-12 Thread Alex Harui
If it works you can change it. On 8/12/17, 7:58 AM, "piotrz" wrote: >Another question is we have also google closure library where ant always >download it from master - I see that Maven is taking specific version - >should I switch to the newest one for that also ? >

Re: [1/2] git commit: [flex-falcon] [refs/heads/develop] - upgrade to Google Closure Compiler 20170626. They deprecated a lot of APIs so lots of changes were required. The primary change is that GCC i

2017-08-12 Thread Alex Harui
e1%7 >>C0%7C0%7C636381465087873859=xqFVaScps%2FFRRBvhtx55rejYb3CVBXSNiXjEq >>qVJ0ec%3D=0 >> Diff: >>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u >>s.apache.org%2Frepos%2Fasf%2Fflex-falcon%2Fdiff%2F6331b80d=02%7C01%7 >>C%7C3b0113376a13

Re: Package, Class and Method renaming

2017-08-11 Thread Alex Harui
On 8/10/17, 10:03 AM, "Harbs" <harbs.li...@gmail.com> wrote: >Is there some way we can declare MXML differently so GCC can know that >we’re using properties? Maybe instead of strings we can use object >literals with proper references? > >> On Aug 10,

Re: FlexJS more problematic CSS

2017-08-11 Thread Alex Harui
First thing to try is to provide a namespace for all type selectors. @namespace "http://www.w3.org/1999/xhtml;; Must be used for all native HTML elements. HTH, -Alex On 8/11/17, 6:20 AM, "Harbs" wrote: >The CSS in my tutorial here[1] does not compile inside a

Re: Package, Class and Method renaming

2017-08-10 Thread Alex Harui
lew up. > >If we go this route, we probably need to make MXML output smarter… > >> On Aug 10, 2017, at 12:31 AM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >> >> I've seen GCC not track renames before. The Object.defineProperty is >>just >&g

Re: Package, Class and Method renaming

2017-08-09 Thread Alex Harui
iteral_extensions_G >etter_accessors=02%7C01%7C%7C4c8241c7dc364ada739908d4df76c298%7Cfa7b1 >b5a7b34438794aed2c178decee1%7C0%7C0%7C636379148544302372=zpqBPd3a%2B >56GwuW6DCMl%2FLHuLrdmgK48ZllY%2F0aibY8%3D=0> > > >> On Aug 10, 2017, at 12:31 AM, Alex Harui <aha...@adobe.com.INVA

Re: Package, Class and Method renaming

2017-08-09 Thread Alex Harui
will have to change your CSS. Also, I have not removed the exportSymbol calls on each class yet. I will try that as well. -Alex On 8/9/17, 2:11 PM, "Harbs" <harbs.li...@gmail.com> wrote: > >> On Aug 9, 2017, at 11:56 PM, Alex Harui <aha...@adobe.com.INVALID> >>

Re: Package, Class and Method renaming

2017-08-09 Thread Alex Harui
e only case >we need. I can probably handle any specific cases where that might break >output code by manually inserting @export statements. > >> On Aug 9, 2017, at 10:20 PM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >> >> Hmm. I thought GCC didn't ren

Re: Package, Class and Method renaming

2017-08-09 Thread Alex Harui
gt;> textInput.addEventListener >> becomes: >> this.yw.addEventListener >> >> disableBead.disabled >> becomes >> this.Jm.disabled >> >> etc. >> >> this.yw and this.Jm are both undefined >> >>> On Aug 9, 2017, at 9:10 AM,

Re: Package, Class and Method renaming

2017-08-08 Thread Alex Harui
eral >concatenation expressions with package parts for CLASS_INFO and in the >reflection data. This should end up minifying via closure compiler much >better, I think. >e.g. > >'org.'+'apache.'+'flex.'+'events.'+'Event' > > > > >On Wed, Aug 9, 2017 at 9:01 AM, Ale

Re: Package, Class and Method renaming

2017-08-08 Thread Alex Harui
k. > >> On Aug 9, 2017, at 12:01 AM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >> >> Some things I found were that MXML isn't a problem because the id maps >>to >> a getter/setter which maps to Object.DefineProperty which takes an >>object >> structure where the ids are keys so they don't get renamed. >

Re: Package, Class and Method renaming

2017-08-08 Thread Alex Harui
in the FLEXJS_CLASS_INFO and thus never get minified/renamed. Anyway, try compiling and running your application code with this option set to false and see if it obfuscates things enough or not, and whether the result still runs. Thanks, -Alex On 8/7/17, 9:06 AM, "Alex Harui" <aha...@adob

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
ent than the swf >output. I don’t know if it used to look better. >DataGrid - works, but the images are not visible in swf. > >That’s all I have time for right now. > >Harbs > >> On Aug 8, 2017, at 5:41 PM, Alex Harui <aha...@adobe.com.INVALID> wrote: >> >> We will >> probably need to stop and check all of the examples again. >

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
SWF and js-debug, didn't try js-release. When I click the checkbox, the data is there. Could be that the price is not in the data returned. -Alex On 8/8/17, 1:06 PM, "Harbs" <harbs.li...@gmail.com> wrote: >js-debug, js-release or swf? > >> On Aug 8, 2017,

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
u check again? > >> On Aug 8, 2017, at 5:41 PM, Alex Harui <aha...@adobe.com.INVALID> wrote: >> >> However, I just saw that >> DataBindingExample is broken. The stock price doesn't show up. >

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
Here are my notes from the previous release: https://lists.apache.org/thread.html/c5625d0ac1f8b28ae729cf82b547971ac4faec ede84d0c97b7713246@%3Cdev.flex.apache.org%3E -Alex On 8/8/17, 9:26 AM, "piotrz" wrote: >+1 for the release. > >But have to start from Maven which

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
he door quickly. > >I’ll try and spend some time with the examples. > > >> On Aug 8, 2017, at 5:41 PM, Alex Harui <aha...@adobe.com.INVALID> wrote: >> >> A 0.8.1 release is fine with me. However, I just saw that >> DataBindingExample is broken. The stock

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
A 0.8.1 release is fine with me. However, I just saw that DataBindingExample is broken. The stock price doesn't show up. We will probably need to stop and check all of the examples again. Peter usually helps me do that, but he's on vacation. Other folks will need to step up to be the RM and

Re: FlexJS Bead dilemma

2017-08-08 Thread Alex Harui
blems. > >I’m more trying to figure out the best general resolution to this issue. > >Thanks, >Harbs > >> On Aug 8, 2017, at 9:51 AM, Alex Harui <aha...@adobe.com.INVALID> wrote: >> >> I don't know the details of your scenario. I was thinking that on the >

Re: FlexJS Bead dilemma

2017-08-08 Thread Alex Harui
, "Harbs" <harbs.li...@gmail.com> wrote: >If it doesn’t remove itself, it seems like you’d end up with two layout >beads and it would probably keep injecting more layout beads each time >the component is made visible. > >> On Aug 8, 2017, at 9:30 AM, Alex Haru

Re: FlexJS Bead dilemma

2017-08-08 Thread Alex Harui
which would be added before the layout >bead. It would listen on ‘layoutNeeded’ and stopImmediatePropagation() >unless the host is visible. > >From: Alex Harui<mailto:aha...@adobe.com.INVALID> >Sent: Tuesday, August 8, 2017 8:55 AM >To: dev@flex.apache.org<mailto:dev@flex.ap

Re: FlexJS Bead dilemma

2017-08-07 Thread Alex Harui
pendencies on the >strand assumed by most layouts (and there are probably more in the >concrete classes). > > >Adding a meager LayoutOnShow bead seems cleaner to me. > > >From: Alex Harui <aha...@adobe.com.INVALID> >Sent: Monday, Augus

Re: FlexJS Applying a bead by default

2017-08-07 Thread Alex Harui
’t the compiler use the CSS declarations to add beads to a beads >array in MXML? > >I think it’s an acceptable compromise that injectable beads in CSS would >only work for MXML files. > >> On Aug 8, 2017, at 12:32 AM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >&

Re: FlexJS Applying a bead by default

2017-08-07 Thread Alex Harui
we can abuse CSS a bit more and allow declaring an array of beads >there? > >Either way, I think the code which delays layout of hidden elements blows >up layout in subtle ways. I’m reverting that for now. Sometime when I >have the cycles maybe I’ll look at this again. > &

Re: FlexJS Applying a bead by default

2017-08-07 Thread Alex Harui
I have to create my own Container just to get layout >to happen when it becomes visible. > >> On Aug 7, 2017, at 11:55 PM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >> >> IMO, you should create a different Container (probably a cheap subclass >

Re: FlexJS Applying a bead by default

2017-08-07 Thread Alex Harui
IMO, you should create a different Container (probably a cheap subclass of Container) and apply the bead in the constructor or fetch it from CSS in addedtoParent(). -Alex On 8/7/17, 1:12 PM, "Harbs" wrote: >I would like to apply a bead (LayoutOnShow) to every Container

Re: FlexJS Model beads

2017-08-07 Thread Alex Harui
two model beads are added, the second one will be the >model, and the first one will just sit there (hopefully inactive). > >I’m not sure if this is a problem. > >> On Aug 7, 2017, at 9:55 PM, Alex Harui <aha...@adobe.com.INVALID> wrote: >> >> I would not expect

Re: FlexJS Bead dilemma

2017-08-07 Thread Alex Harui
A bead could have a property which is another bead. Of course, I could be wrong... -Alex On 8/7/17, 11:13 AM, "yishayw" <yishayj...@hotmail.com> wrote: >Alex Harui-2 wrote >> A fancier alternative would be a bead that wraps a layout bead and

Re: FlexJS Model beads

2017-08-07 Thread Alex Harui
I would not expect a need to switch models at runtime, so clean up after removal shouldn't be needed. Honestly, I'd try to prevent any beads from being swapped at runtime unless you are willing to pay for the cost. I've been thinking we should take out the removeBead API. What kind of scenario

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-08-07 Thread Alex Harui
I pushed some code that tries to implement a "localId" property. It seemed to work in a simple test. -Alex On 8/3/17, 10:58 AM, "piotrz" wrote: >Hi All, > >This issue started to be real blocker for my client's application. If we >could ask anyone from compiler sight

Re: FlexJS Random crazy thought

2017-08-07 Thread Alex Harui
Sure, trying to replicate the TS compiler in our code base would be a lot of work especially if we wanted to also get SWF output. But I think for JS-only output there is a possible shortcut where we replace Google Closure Compiler with the TS compiler and essentially pass through the TS code. Of

Re: Package, Class and Method renaming

2017-08-07 Thread Alex Harui
over this output? -Alex On 8/7/17, 8:54 AM, "Harbs" <harbs.li...@gmail.com> wrote: >Cool. > >How difficult would it be to allow this on a class-by-class basis? > >> On Aug 7, 2017, at 6:35 PM, Alex Harui <aha...@adobe.com.INVALID> wrote: >> >>

Re: FlexJS Random crazy thought

2017-08-07 Thread Alex Harui
It is probably technically possible. But would it attract TS folks? Other crazy ideas along these lines are: 1) have FalconJX output TS as well as JS 2) extend AS with some of the popular TS features 3) make sure it is really easy to use TS libraries in FlexJS. My 2 cents, -Alex On 8/7/17,

Re: Package, Class and Method renaming

2017-08-07 Thread Alex Harui
pplication logic more aggressively renamed but not require us to fix code in other SWCs that might use bracket access. HTH, -Alex On 8/7/17, 8:05 AM, "Harbs" <harbs.li...@gmail.com> wrote: > >> On Aug 7, 2017, at 5:52 PM, Alex Harui <aha...@adobe.com.INVALID> wrote: >

Re: Package, Class and Method renaming

2017-08-07 Thread Alex Harui
exports is any property used in MXML. >> >> It seems like the low hanging fruit would be to allow some kind of >>markup to specify classes which don’t need exports. >> >> Rewriting constants to literals is another one which should be pretty >>easy to solve. >

Re: Package, Class and Method renaming

2017-08-07 Thread Alex Harui
e spread out. > >The reasons that stick in my mind was for bracketed access (needed for >binding?) and reflection. Another reason I think that was mentioned was >for modules (which we don't’ yet really have a way to use). > >Is that it? > >> On Aug 7, 2017, at 8:34 AM, Alex H

Re: Package, Class and Method renaming

2017-08-06 Thread Alex Harui
It might be more interesting and fruitful to investigate removing @export annotations. How could we determine which variables are being accessed via foo[someProperty] and only keep @export on those properties? You might be able to use a text replacement tool to remove @export and mess around

Re: FlexJS Bead dilemma

2017-08-06 Thread Alex Harui
olution to this problem. >> >> If I have to weigh a single check for visible vs an entire layout, I’d >>go for the former. >> >> I seem to recall that we did something to prevent non-visible >>components for going throw layout, but I don’t remember any details. >>

Re: FlexJS Bead dilemma

2017-08-03 Thread Alex Harui
fixes the bug, and when I have time, I’ll look into improving the >layouts. > >Another thought: > >If visibility is turned on and off multiple times, this might be less >efficient, but the layout might be able to store a flag to avoid running >the layout if not needed… > >Harbs >

Re: FlexJS Bead dilemma

2017-08-03 Thread Alex Harui
-Alex On 8/3/17, 8:18 AM, "Harbs" <harbs.li...@gmail.com> wrote: >The problem is that visible is set before the bead exists. > >BTW, Some of the layout seem to be reading and setting display multiple >times. That can cause layout thrashing. That should probably be

Re: FlexJS Bead dilemma

2017-08-03 Thread Alex Harui
FWIW, I'm not sure this is the best pattern. It was what we did to get the examples to run. Another option is that layout beads listen for changes to visible and reset the CSS display style when visible changes. Food for thought, -Alex On 8/3/17, 8:00 AM, "Harbs" wrote:

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-03 Thread Alex Harui
y keep using isNaN(). For some types, we may even be able to >assume that isNaN() will always return true. However, we need to be >careful >about edge cases. A Number could be stored in type Object, for instance. > >- Josh > >On Thu, Aug 3, 2017 at 7:22 AM, Alex Harui <aha..

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-03 Thread Alex Harui
Here's an article about isNaN is JS. http://adripofjavascript.com/blog/drips/the-problem-with-testing-for-nan-in -javascript.html Maybe the transpiler should not output isNaN and instead "someNumber !== someNumber" -Alex On 8/3/17, 6:30 AM, "Harbs" wrote: >Cool. > >I

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-02 Thread Alex Harui
I think I have that fixed locally. Now I am having a problem with the integration-tests and Java version. Once I get past that I can compare my results against the CI server's results. -Alex On 8/2/17, 4:22 PM, "piotrz" wrote: >Hi Alex, > >It's failing for me

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Alex Harui
remembered locals and members using the same >emitter. I'll update it elsewhere for members too. > >- Josh > >On Tue, Aug 1, 2017 at 9:34 PM, Alex Harui <aha...@adobe.com.invalid> >wrote: > >> To me, this is all related to PAYG. And also, coding "style" matte

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-02 Thread Alex Harui
Hi Piotr, This Maven build is running the distribution profile. The command line is something like: mvn clean install sonar:sonar -P "build-examples,build-distribution" -Dcom.adobe.systemIdsForWhichTheTermsOfTheAdobeLicenseAgreementAreAccepted= 3872fc1e

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-01 Thread Alex Harui
To me, this is all related to PAYG. And also, coding "style" matters. If we want to allow every possible existing AS statement work as-is, then we must initialize every variable that has a different default in JS. I thought the results of the set of tests I ran was that some of those patterns

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-01 Thread Alex Harui
Ah yes, I like your answer better. -Alex On 8/1/17, 2:36 PM, "piotrz" wrote: >Alex, > >I just pushed fix for this issue, but I would love to see what you did >also. >Take a look into my commit where I'm adding "defines" to pom of TLF >module. > >Harbs, > >I did

Re: Debugger statement

2017-08-01 Thread Alex Harui
38794aed2c178decee1%7C0%7C0%7C636371921136496388=L >EuZYzHxshbJ3PpcNRvy96KC2SF2yOUPUSuHpYZYrvQ%3D=0 > >- Josh > >On Mon, Jul 31, 2017 at 5:46 PM, Alex Harui <aha...@adobe.com.invalid> >wrote: > >> I'm still trying to get the ok to use undocumented APIs without >>violating >

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-01 Thread Alex Harui
Hi Piotr, These flags are only used by TLF, but TLF was building just fine for a while. I agree that the current failures appear unrelated, but I want to get it to build locally in order to compare working vs not-working. AFAICT, you can't specify more than one option in

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-01 Thread Alex Harui
Hi Piotr, Which loaded config had these settings? I was unable to define those flags in the Maven pom without changing the BaseMojo. I have those fixes locally, but I'm trying to understand how this ever worked so we are more sure my proposed changes don't duplicate something or something else

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-07-31 Thread Alex Harui
Does it build locally for you? I can't get TLF to build with Maven, and it isn't clear that it should. -Alex On 7/31/17, 2:42 AM, "piotrz" wrote: >I have no idea what is happen. I just changed machine which building >FlexJS >and it is still not working. I do not

Re: Debugger statement

2017-07-31 Thread Alex Harui
I'm still trying to get the ok to use undocumented APIs without violating the Flash EULA which prohibits reverse-engineering. Could just make it JS-only for now. -Alex On 7/31/17, 3:01 PM, "Josh Tynjala" wrote: >If there are no objections in the next 24 hours, I plan to

Re: FlexJS PAYG and layouts

2017-07-31 Thread Alex Harui
You're welcome to try different approaches to sharing code in the base classes. Often, though, loops over children need to be inlined not only for performance reasons (to cut out one function call in the inner loop), but also for information sharing reasons (local variables accumulating values

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-07-30 Thread Alex Harui
OTbIE%3D=0 >> Diff: >>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u >>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fbdd34d2e=02%7C01%7C% >>7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0 >>%7C0%7C636370058818766511=f8WVJXc

Re: [FlexJS] MouseEvent

2017-07-27 Thread Alex Harui
h events at some point, but >maybe we can write utility functions to prevent all that to be hard-coded >in. > >> On Jul 26, 2017, at 9:52 PM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >> >> Will anyone ever really ship an app that doesn't need wheel supp

Re: [FlexJS] MouseEvent

2017-07-26 Thread Alex Harui
Will anyone ever really ship an app that doesn't need wheel support? Our smaller examples don't need it, so I'm wondering if wheel support should be separated out or not. Thoughts? -Alex On 7/26/17, 9:27 AM, "Harbs" wrote: >While you’re at it, if you could write a test

Re: [FlexJS]TileLayout

2017-07-24 Thread Alex Harui
rbs.li...@gmail.com> wrote: > >>Agreed, but I think the defaults should match Flash between and HTML. >> >>He did not set stretch. Nothing was set. ³stretch² is the default css. >> >>> On Jul 23, 2017, at 12:23 PM, Alex Harui <aha...@adobe.com

Re: [FlexJS] stopImmediatePropagation

2017-07-24 Thread Alex Harui
Fclosure-library%2Fblob%2F608e0eaaa42bb5f041a7f067f254907d47edf7d1%2Fclosure%2Fgoog%2Fevents%2Feventtarget.js%23L371=02%7C01%7C%7C763d326f33864e8a00a008d4d21584b0%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636364437271019556=rAs8Re5hh5fsu1%2B0RrzauKsOeLAxy9eshW%2FRxFr4U2g%3D=0 >>>> >>>

Re: [FlexJS] PAYG and dataGroups

2017-07-23 Thread Alex Harui
Different variants of datagroup listview etc can be smarter about data changes. The listview could also share its index properties with beads that know? how to deal with data changes. Get Outlook for Android From: Harbs

Re: git commit: [flex-asjs] [refs/heads/feature/browser-event] - goog.Event assumes the getter can be called on the event. Default to the super getter if wrappedEvent is not set (yet).

2017-07-23 Thread Alex Harui
It may not be a getter in goog.Event and just a var instead. It might be ok to modify the typedefs to make it a getter. HTH, -Alex On 7/23/17, 1:59 AM, "Harbs" wrote: >This commit should theoretically work, but it looks like there’s a weird >Falcon bug here. > >When

Re: [FlexJS]TileLayout

2017-07-23 Thread Alex Harui
There doesn't have to be one TileLayout. There can be TileLayoutWithFlexStart, TileLayoutWithStretch, and TileLayoutWithAlignContent with a property that allows you to set it. Peter may remember why he chose "stretch". -Alex On 7/23/17, 1:28 AM, "Harbs" wrote: >I just

Re: [FlexJS] findPopupHost issue

2017-07-21 Thread Alex Harui
I think we can use setParentTarget to get bubbling to work reliably with custom events, but as Peter said, I don't think we want to set up parentTarget's just-in-case. Bubbling custom events is not a recommended practice as was mentioned in some other thread recently. Imagine if you had a Panel

Re: [FlexJS] stopImmediatePropagation

2017-07-21 Thread Alex Harui
I think other goog code updates currentTarget as needed. They are the same when no capture or bubbling, IIRC. -Alex On 7/20/17, 11:52 PM, "Harbs" wrote: >Yes. I need to copy the code from BrowserEvent. > >Interestingly, goog.Events does not distinguish between target

Re: [FlexJS] String.match()

2017-07-21 Thread Alex Harui
j2u1GDu0YeKMipu%2FGRHwMWQzRRA0JCTkZc%3D=0".indexOf >("?")); > >outputs: > >null >-1 >29 > >> On Jul 21, 2017, at 12:00 AM, Alex Harui <aha...@adobe.com.INVALID> >>wrote: >> >> I think I'm still confused. My current thinking is that

Re: [FlexJS] String.match()

2017-07-20 Thread Alex Harui
ll not match anything in Flash. In that case, match should always >>return null and search should always return -1. >> >> I do think that warning developers against using strings is a good >>idea. Accepting any value and automatically converting it to RegExp >>seems li

Re: [FlexJS] String.match()

2017-07-20 Thread Alex Harui
I'm confused. Doesn't Yishay's example use syntax that Harbs claimed threw an error? Anyway, I can believe the three steps Harbs listed are correct for JS since step 1 might just happen via implicit type coercion. I suppose someone could test it by seeing if JS handles "new RegExp({})"; But

Re: [FlexJS] String.match()

2017-07-20 Thread Alex Harui
gt;1. It prevents the error from being thrown. >2. It warns the developer to not pass in a string as it’s converted to a >RegExp anyway and is less predictable. > >An alternate (possibly better) way to handle this would be to have the >compiler issue a warning. > >> On Jul 20, 2017,

<    1   2   3   4   5   6   7   8   9   10   >