[GitHub] geode issue #748: GEODE-3472: Remove a great deal of commented-out code.

2017-08-30 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/748 Precheckin green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-29 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #730: GEODE-3472: Remove a great deal of commented-out code.

2017-08-29 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/730 Due to significant changes, this pull request is replaced by #748. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #748: GEODE-3472: Remove a great deal of commented-out co...

2017-08-29 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/748 GEODE-3472: Remove a great deal of commented-out code. This pull request replaces #730. Nontrivial conflicts were introduced after rebasing against GEODE-3436 (`be8a13

[GitHub] geode issue #745: GEODE-3436: Restore reverted GFSH command refactoring

2017-08-29 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/745 Precheckin fully green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode pull request #745: GEODE-3436: Restore reverted GFSH command refactori...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/745 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #745: GEODE-3436: Restore reverted GFSH command refactori...

2017-08-28 Thread PurelyApplied
GitHub user PurelyApplied reopened a pull request: https://github.com/apache/geode/pull/745 GEODE-3436: Restore reverted GFSH command refactoring Given that this would restore multiple tickets worth of commits, it was unclear if this PR should squash all commits or if the history

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-28 Thread PurelyApplied
GitHub user PurelyApplied reopened a pull request: https://github.com/apache/geode/pull/730 GEODE-3472: Remove a great deal of commented-out code. * Correct imports in touched files * Correct several misspellings * Removed redundant modifier and specifiers * Corrected

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-28 Thread PurelyApplied
GitHub user PurelyApplied reopened a pull request: https://github.com/apache/geode/pull/730 GEODE-3472: Remove a great deal of commented-out code. * Correct imports in touched files * Correct several misspellings * Removed redundant modifier and specifiers * Corrected

[GitHub] geode issue #730: GEODE-3472: Remove a great deal of commented-out code.

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/730 Precheckin returned green. Open/Close PR to trigger Travis again. Hopefully they've pulled `develop` recently... --- If your project is set up for it, you can reply to this email

[GitHub] geode issue #730: GEODE-3472: Remove a great deal of commented-out code.

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/730 Travis failures appear related to `f41ca9d7d2fa7c045ec439df9478335233f1d95e`. Is there a way to force Travis to rerun without applying a new commit? --- If your project is set up for it, you

[GitHub] geode pull request #745: GEODE-3436: Restore reverted GFSH command refactori...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/745#discussion_r135641458 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/TestCommand.java --- @@ -171,28 +171,37 @@ private static void init

[GitHub] geode pull request #745: GEODE-3436: Restore reverted GFSH command refactori...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/745#discussion_r135635781 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommand.java --- @@ -794,7 +84,7 @@ public Result

[GitHub] geode pull request #745: GEODE-3436: Restore reverted GFSH command refactori...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/745#discussion_r135632737 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java --- @@ -247,7 +207,7 @@ public Result

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r135626288 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java --- @@ -212,8 +211,7 @@ public static void bytesToFiles(byte

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r135625955 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java --- @@ -158,7 +156,7 @@ private Thread runner

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r135625773 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java --- @@ -415,9 +413,8 @@ public Result

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #745: GEODE-3436: Restore reverted GFSH command refactori...

2017-08-28 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/745#discussion_r135599224 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateDefinedIndexesCommand.java --- @@ -0,0 +1,155

[GitHub] geode pull request #745: GEODE-3436: Restore reverted GFSH command refactori...

2017-08-28 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/745 GEODE-3436: Restore reverted GFSH command refactoring Given that this would restore multiple tickets worth of commits, it was unclear if this PR should squash all commits or if the history

[GitHub] geode issue #734: GEODE-3508: Remove unused internal deprecated classes.

2017-08-24 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/734 Precheckin green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode issue #731: GEODE-2842: Removed redundant default annotation parameter...

2017-08-23 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/731 Precheckin green, with some flakiness observed in `org.apache.geode.internal.cache.ha.Bug48571DUnitTest`. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

2017-08-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/734#discussion_r134881817 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java --- @@ -1,33 +0,0

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

2017-08-23 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/734 GEODE-3508: Remove unused internal deprecated classes. * Update ClusterConfigurationNotAvailableException to extend Exception directly, rather than the deprecated class

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-22 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r134618712 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java --- @@ -147,11 +147,10 @@ public ResultData

[GitHub] geode pull request #731: GEODE-2842: Removed redundant default annotation pa...

2017-08-22 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/731 GEODE-2842: Removed redundant default annotation parameter values. Driven by IntelliJ inspection, I have extended the reach of this ticket to include any annotation, not only `@CliOption

[GitHub] geode issue #730: GEODE-3472: Remove a great deal of commented-out code.

2017-08-22 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/730 Precheckin green after merge with `be4551191a17b9f50169f375798785ab5373e975`. Subsequently rebased again with minor merge conflict resolved. --- If your project is set up for it, you can

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-21 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/730 GEODE-3472: Remove a great deal of commented-out code. * Correct imports in touched files * Correct several misspellings * Removed redundant modifier and specifiers * Corrected

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132307061 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -157,7 +162,7 @@ protected static Properties

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132312668 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -1848,8 +1884,7 @@ public LocatorLauncher build

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132312583 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -502,7 +507,7 @@ protected static Integer identifyPid

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132311304 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java --- @@ -228,9 +230,9 @@ private void disconnect

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132306579 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java --- @@ -31,7 +31,7 @@ import

[GitHub] geode pull request #690: GEODE-3262: Refactoring IndexCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/690#discussion_r131790263 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateIndexCommand.java --- @@ -0,0 +1,197

[GitHub] geode issue #691: GEODE-3260: Refactoring FunctionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/691 +1. A far-from-critical nitpick: there are several places in `ExecuteFunctionCommand` and one in `DestroyFunctionCommand` that are of the form ``` result

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131775864 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java --- @@ -333,9 +247,8 @@ private void

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131776451 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java --- @@ -359,7 +272,7 @@ private

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131783322 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListRegionCommand.java --- @@ -0,0 +1,113

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131775100 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/RegionCommandsController.java --- @@ -26,11 +26,12

[GitHub] geode issue #652: Geode-2971: Introduce ExitCode to resolve inconsistency of...

2017-07-31 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/652 Precheckin came back fully green. PR squashed and rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script

2017-07-28 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/666 Thanks for the quick turn around on this! +0.5, since I don't really know this corner of the code, but it looks good to me! --- If your project is set up for it, you can reply to this email

[GitHub] geode issue #660: GEODE-2924 Revise authorization permissions

2017-07-28 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/660 +1. For future reference, tickets GEODE-2920 through GEODE-2926 were committed under the overarching ticket [GEODE-2919](https://issues.apache.org/jira/browse/GEODE-2919) in commit `451d12e8

[GitHub] geode issue #652: Geode-2971: Introduce ExitCode to resolve inconsistency of...

2017-07-26 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/652 @jaredjstewart I don't know why I didn't think to put my questions here instead of imbedding them in my code, just to be removed later. I clearly wasn't on my A-game. 1. In my

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

2017-07-26 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129656012 --- Diff: geode-core/src/main/java/org/apache/geode/internal/ExitCode.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software

[GitHub] geode pull request #653: GEODE-3290: Removed effectively-dead classes Filter...

2017-07-24 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/653 GEODE-3290: Removed effectively-dead classes FilterChain, et al Removed `FilterChain`, `LocalFilterChain`, and `RemoteFilterChain`. Minor cleanup of touched files. Precheckin

[GitHub] geode issue #652: Geode-2971: Introduce ExitCode to resolve inconsistency of...

2017-07-24 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/652 Precheckin running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

2017-07-24 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/652 Geode-2971: Introduce ExitCode to resolve inconsistency of shell exit values There are a few sections containing `// TODO PSRhomberg`. Most are there to mark a specific request for feedback

[GitHub] geode issue #646: GEODE-3213: Refactor ProtoBuf handler flow

2017-07-21 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/646 If you are using IntelliJ as your IDE, please remember to update your style file to that located in `geode/etc/intellij-java-modified-google-style.xml` to be consistent with Geode's established

[GitHub] geode issue #647: GEODE-3271: Refactor WanCommands

2017-07-21 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/647 +1 as it stands. Unimportant nitpicks, rambling observations, and "it could be even better if...": * `punePort` appears in these tests a lot. I have no idea

[GitHub] geode issue #601: GEODE-3117: fix Gateway authentication with legacy securit...

2017-06-30 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/601 If you are using IntelliJ as your IDE, please remember to update your style file to that located in `geode/etc/intellij-java-modified-google-style.xml` to be consistent with Geode's established

[GitHub] geode issue #603: GEODE-3128: Changed the batch size to 1000 when creating A...

2017-06-30 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/603 If you are using IntelliJ as your IDE and have not already done so, please remember to update your style file to that located in `geode/etc/intellij-java-modified-google-style.xml

[GitHub] geode issue #609: GEODE-2886 : sent IllegalStateException instead of throwin...

2017-06-30 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/609 If you are using IntelliJ as your IDE, please remember to update your style file to that located in `geode/etc/intellij-java-modified-google-style.xml` to be consistent with Geode's established

[GitHub] geode issue #612: GEODE-3121: ensure that the protobuf protocol works over S...

2017-06-30 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/612 If you are using IntelliJ as your IDE, please remember to update your style file to that located in `geode/etc/intellij-java-modified-google-style.xml` to be consistent with Geode's established

[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

2017-06-30 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/613 If you are using IntelliJ as your IDE, please remember to update your style file to that located in `geode/etc/intellij-java-modified-google-style.xml` to be consistent with Geode's established

[GitHub] geode issue #601: GEODE-3117: fix Gateway authentication with legacy securit...

2017-06-27 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/601 +1. Huzzah for more test coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/596 Excepting one flaky test, precheckin is green through `14298a`. Precheckin is currently very unhappy, though, and starting new test runs is not going well. --- If your project is set up

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123832520 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java --- @@ -109,12 +107,10 @@ public Result

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123832527 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java --- @@ -130,31 +125,8 @@ public Result

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123830383 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBean.java --- @@ -148,7 +148,12 @@ public long

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123829882 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java --- @@ -57,7 +56,48 @@ public

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-21 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/596 Precheckin running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-21 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/596 GEODE-2920 - GEODE-2925: Finer Grained Security Due to the size of this commit and for your convenience of review, I have not yet squashed my commits. Do note that I have not individually

[GitHub] geode pull request #576: Geode 2920, 2921, 2922, 2924

2017-06-21 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #576: Geode 2920, 2921, 2922, 2924

2017-06-21 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/576 Closing this PR to reopen the finalized form. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...

2017-06-19 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/591#discussion_r122849064 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java --- @@ -941,17 +940,16 @@ private SelectResults

[GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...

2017-06-19 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/591#discussion_r122848112 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java --- @@ -1415,11 +1413,7 @@ public boolean evaluateCq

[GitHub] geode issue #592: GEODE-2707: Removing TXLockToken

2017-06-19 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/592 After the fix Ken pointed out, `++n;` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode pull request #578: GEODE-1958: Removing/deprecating PasswordUtil

2017-06-13 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/578#discussion_r121799720 --- Diff: geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java --- @@ -1909,10 +1900,7 @@ private static boolean needsSysDir(String cmd

[GitHub] geode pull request #578: GEODE-1958: Removing/deprecating PasswordUtil

2017-06-13 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/578#discussion_r121798399 --- Diff: geode-core/src/main/java/org/apache/geode/internal/util/PasswordUtil.java --- @@ -44,72 +42,29 @@ private static byte[] init = "s

[GitHub] geode pull request #576: Geode 2920, 2921, 2922, 2924

2017-06-12 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/576 Geode 2920, 2921, 2922, 2924 This PR is intended for initial review, not to be actively considered for acceptance. Sufficient testing is still required and `develop` shifted enough today

[GitHub] geode pull request #551: GEODE-2971: consistency in shell exit codes for sta...

2017-06-09 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/551 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #551: GEODE-2971: consistency in shell exit codes for status com...

2017-06-09 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/551 After significant testing redesign, this PR will be closed. The ticket will be resolved after additional `@Rule` resources are added that more accurately represent real `gfsh` usage

[GitHub] geode pull request #569: Resolve Eclipse/IntelliJ import order disagreement

2017-06-08 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/569 Resolve Eclipse/IntelliJ import order disagreement The style guides contained in `etc/` are not consistent. This commit modifies `etc/intellij-java-google-style.xml` to adhere

[GitHub] geode pull request #551: GEODE-2971: consistency in shell exit codes for sta...

2017-05-31 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/551 GEODE-2971: consistency in shell exit codes for status commands. * Replaced all System.exit parameters with ShellExitCode references for extensibility * Added FakeLaunchers to Locator

[GitHub] geode pull request #528: GEODE-1994, revisited: Removed guaranteed failures.

2017-05-30 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/528 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #528: GEODE-1994, revisited: Removed guaranteed failures.

2017-05-24 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/528 Green across the board. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode issue #528: GEODE-1994, revisited: Removed guaranteed failures.

2017-05-23 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/528 Precheckin running... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode pull request #528: GEODE-1994, revisited: Removed guaranteed failures.

2017-05-23 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/528 GEODE-1994, revisited: Removed guaranteed failures. Removed two uses of ServerLauncher.Builder.setMemberName that are guaranteed to throw under the changes introduced by GEODE-1994

[GitHub] geode pull request #522: GEODE-2953: Imports optimized in every file with a ...

2017-05-23 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...

2017-05-23 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/522 Yeah, while I do firmly believe that there is value in good form and adherence to best practices, this PR ended up a lot bigger than I had initially expected. --- If your project is set up

[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...

2017-05-22 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/522 Please review the diff, or run a regex search matching `import .*\*;\n`. This regex hits 1024 occurrences in production and 2205 occurrences in test code. Some of these occurrences

[GitHub] geode pull request #522: GEODE-2953: Imports optimized in every file with a ...

2017-05-19 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/522 GEODE-2953: Imports optimized in every file with a wildcard import. This is a purely semantic change. Imports have been optimized by my IDE. This may have the side-effect of changing some

[GitHub] geode issue #521: GEODE-1994: Overhaul of internal.lang.StringUtils to exten...

2017-05-18 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/521 precheckin has cleared most tests. Waiting on DistributedTest to finish. :geode-core cleared, currently waiting on :geode-wan. I've seen some :geode-wan failures on a fresh develop (a lot

[GitHub] geode pull request #521: GEODE-1994: Overhaul of internal.lang.StringUtils t...

2017-05-18 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/521 GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils * geode.internal.lang.StringUtils has been deprecated. In the interim, it has been

[GitHub] geode issue #500: GEODE-2662: Gfsh displays field value on wrong line ...

2017-05-08 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/500 precheckin returns green across the board. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] geode pull request #500: GEODE-2662: Gfsh displays field value on wrong line...

2017-05-08 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/500 GEODE-2662: Gfsh displays field value on wrong line ... ... when receiving objects with missing fields. DataCommandResult.buildTable refactored to scan for all necessary fields

[GitHub] geode issue #435: GEODE-2738: Corrected spelling of "occured" to occurred

2017-05-05 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/435 Re-rebased and conflict resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode issue #435: GEODE-2738: Corrected spelling of "occured" to occurred

2017-04-24 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/435 Rebased and resoled conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode pull request #454: GEODE-2775: Corrected setting of Pulse SSL Manager ...

2017-04-13 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/454 GEODE-2775: Corrected setting of Pulse SSL Manager flag Flag now set from System properties instead of pulse.properties when running in embedded mode. Precheckin returned fully green

[GitHub] geode issue #438: GEODE-2725: export logs now honors --dir when connected vi...

2017-04-11 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/438 precheckin failed with many errors, most of which seem unrelated. - Three failures in `PartitionedRegionQueryEvaluatorTest` - 94 failures in `GlobalRegionOffHeapDUnitTest`, and of those

[GitHub] geode issue #445: GEODE-2767: Added DUnitTests to validate export log option...

2017-04-11 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/445 Precheckin comes back green across the board, excepting one flaky failure in `MemoryThresholdsOffHeapDUnitTest.testDRLoadRejection` --- If your project is set up for it, you can reply

[GitHub] geode pull request #446: GEODE-1274: Migration from PulseLogWriter to Log4j ...

2017-04-10 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/446 GEODE-1274: Migration from PulseLogWriter to Log4j standard and removal of associated classes. * To avoid dependency on geode-core, the pulse loggers are instantiated directly from LogManager

[GitHub] geode pull request #445: GEODE-2767: Added DUnitTests to validate export log...

2017-04-10 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/445 GEODE-2767: Added DUnitTests to validate export log options --group and --member. Only affects test code. precheckin running. You can merge this pull request into a Git repository

[GitHub] geode pull request #432: GEODE-1274: Migration from PulseLogWriter to Log4j ...

2017-04-10 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #438: GEODE-2725: export logs now honors --dir when connected vi...

2017-04-06 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/438 Full green precheckin completed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode issue #439: GEODE-2716: export logs default behavior changed from filt...

2017-04-06 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/439 Full green precheckin completed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode pull request #439: GEODE-2716: export logs default behavior changed fr...

2017-04-05 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/439 GEODE-2716: export logs default behavior changed from filtering at log level INFO to ALL. Moved location of export default log level constant from LogService to ExportLogCommand. Updated

  1   2   >