Re: Steps to follow after becoming a Geode committer

Hi Juan, Great questions! I agree with what Jinmei said - go ahead and merge if you have: 1) at least one approval 2) No changes requested 3) Checks are passing The "at least one review" part is somewhat subjective, if you feel the PR is complicated and you want more reviews, feel free to ask th

Running tests with a different JVM (eg Java 10)

FYI, you compile geode against one version of java and test using a different version of java with the testJVM flag. For example, this would compile with the default JDK on your machine and run tests with java 9. ./gradlew -PtestJVM=/Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/ te

Re: [VOTE] Apache Geode 1.7.0 RC1

+0 I noticed that someone added some files called "out" to the repo that aren't included in the source distribution: ./ci/resource-types/gce-instances-resource/out ./ci/resource-types/concourse-metadata-resource/files/out These aren't included in the source distribution because we are explicitly

Re: [Discuss] Transitive dependencies and internal .pom changes

If what we are doing is just making sure that each geode module is explicitly declaring all of its first order dependencies (things that directly show up in import statements) in its build.gradle, then this seems good to me. I don't think we want to stop using gradle's ability to pull in all of th

Re: [VOTE] Apache Geode 1.7.0 RC2

+1 Ran geode-release-check. Verified pipeline is green. Looks good! -Dan On Tue, Oct 2, 2018 at 11:50 AM Anthony Baker wrote: > +1 > > - verified sha’s and signatures > - checked source release for binaries > - verified geode source build > - verified geode binary distribution > - verified geo

Re: Spring Data Geode test failing

On a related note, I thought we decided to make dev@geode a "humans only" list. I think these Spring CI emails are the last robo-holdout. Can we move these to the notifications mailing list? -Dan On Wed, Oct 3, 2018 at 9:33 AM Anthony Baker wrote: > Looks like it was a BindException. > > > https

Re: RedisDistDUnitTest failing

Here's a great place to check - https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=267 -Dan On Wed, Oct 3, 2018 at 10:25 AM Kirk Lund wrote: > I'm also seeing lots of failure in RedisDistDUnitTest. Is this a known > flaky test? > > org.apache.geode.redis.RedisDistDUnitTest > testCo

Re: [DISCUSS] Predictable minor release cadence

+1 I definitely like the idea of scheduled releases. I wonder if cutting the release branch a month ahead of time is overkill, but I guess we do seem to keep finding issues after the branch is cut. -Dan On Thu, Oct 4, 2018 at 1:25 PM Alexander Murmann wrote: > Hi everyone, > > I want to propos

Re: proposing reduced default for "membership-port-range"

+1 I think it's better not to have the possibility of a port collision for people using Geode's default settings. Especially if you are using automation to start and restart geode members, having a member fail to come up randomly is problematic. -Dan On Thu, Oct 4, 2018 at 4:06 PM Brian Rowe wr

Re: [DISCUSS] Predictable minor release cadence

lem was that it > > took > > >>>> longer to iron out issue on the release branch than expected. The > > >>> solution > > >>>> to that would be to cut the release even earlier, but 1 month feels > > >> very > > >>>> generous. >

Re: proposing reduced default for "membership-port-range"

On Fri, Oct 5, 2018 at 10:31 AM Jacob Barrett wrote: > Why not change the default behavior to that of port 0, letting the OS > select an open ephemeral port if the user doesn’t specify a specific port? > I think what we'd really like to do is change the cache server port to something other than

Re: proposing reduced default for "membership-port-range"

gt; is ephemeral and free. We don’t have to do any work. No need to define a > range and seek an open port. > > > On Oct 5, 2018, at 10:40 AM, Dan Smith wrote: > > > >> On Fri, Oct 5, 2018 at 10:31 AM Jacob Barrett > wrote: > >> > >> Why not change

Re: [DISCUSS] Predictable minor release cadence

> > @Alexander, I don't believe that we can use the "DISCUSS" thread to have > made a decision that we are going to do something. > We can and we should use DISCUSS threads to make decisions. The only things that actually need votes are releases and new committers/pmc members. Nothing else should

Re: Geode Native & Apache Geode 1.8 Release

That is awesome! Let's get it in! I think there are some details to work out: - Do we need to build any automation for creating the native source release (similar to ./gradlew srcDist on the java side)? - Will we release binaries? Which platforms and how to does the release manager build them?

Re: [DISCUSS] permit-reflect vs --add-opens for Java 11 support

#2 seems like the least hacky way to continue using things like sun.misc.Unsafe. Could we just compile a module-info.java with Java 9 and bundle it? This would also help consumers of geode that want to use Java 9 modules. I'm a little bit sceptical of this permit-reflect libary, seeing as it's bee

[DISCUSS] Java 11 jobs in the pipeline

I feel like it would be better to keep the Java 11 jobs off of the main tab in the pipeline until they are actually working. In the spirit of keeping develop releasable, we should keep the main pipeline clean and only include what is releasable today in the pipeline. Thoughts? -Dan

Re: [DISCUSS] permit-reflect vs --add-opens for Java 11 support

a discussion from Google Guava project about compiling > > > >> module-info.java in Java 9+ and including it in a jar with classes > > > >> compiled > > > >> for Java 8. > > > >> > > > >> https://github.com/google/guava/issue

Re: Running compatibility and upgrade tests using jdk9+

At the current moment I don't think it makes sense to run old versions with anything but JDK 8, since they didn't support JDK 9+ or anything like that. Going forward though it seems like we should start running the backwards compatibility tests between versions that do support JDK 9+, once we have

Re: Geode Native & Apache Geode 1.8 Release

y release of the native client is a > > > good > > > > first step. That lets us focus on verifying that all the tasks > > outlined > > > in > > > > [1] are complete and correct. > > > > > > > > Anthony > > > > &g

Re: [DISCUSS] Java 11 jobs in the pipeline

On Thu, Oct 11, 2018 at 3:36 PM Owen Nichols wrote: > Does same go for Windows jobs? They seem to be reliably green at this > point, yet are not gating. Should they be hidden by default as well for > consistency? > Seems reasonable. I don't know if that means we should hide the windows jobs or

Re: [Discuss] Where should simple classes for tests belong?

What I think is important is that any java code should be in a Java source file that is compiled as part of a build. Don't put java source or bytecode in as resource or as a constant. For testing deploy jar I thought what Helena and I ended up doing in StartServerCommandDUnitTest worked pretty wel

StressNewTest issues

Hi all, It looks like some recent changes caused the StressNewTest job in the PR checks to not use docker to run the tests. This means you may see failures such as a DiskAccessExceptions due to concurrent modification of files, or just "Could not start dunit VMS" until GEODE-5893 is fixed. -Dan

Re: StressNewTest issues

Should be fixed now, if you rebase/merge on the latest develop. -Dan On Wed, Oct 17, 2018 at 3:10 PM Dan Smith wrote: > Hi all, > > It looks like some recent changes caused the StressNewTest job in the PR > checks to not use docker to run the tests. This means you may see failures

Re: Geode Native & Apache Geode 1.8 Release

will help this release go a little smoother. [1] https://travis-ci.org/apache/geode-native/branches [2] https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode On Thu, Oct 11, 2018 at 3:23 PM Dan Smith wrote: > +1 for a source release. Awesome! > > -Dan > > On

Re: [DISCUSS] Standardize use of awaitility to a higher timeout

> wrote: > >> > >> > After further discussion, based on GC variability +1 for what Dan > said. > >> > > >> > Thanks, > >> > Mark > >> > > >> > > On Jul 11, 2018, at 12:53 PM, Jacob Barrett > >> wrote:

Re: Request for Jira permissions

Done, you should have access now. Thanks, -Dan On Fri, Oct 19, 2018 at 10:50 AM Owen Nichols wrote: > I would like to request Jira permissions (in order to mark associated > tickets as resolved that were fixed by my recently-accepted pull request > #2643) > > My Jira username is onichols-pivota

Re: [DISCUSS]: SSL and jdk11

(2) seems like the only reasonable option. We don't want to get stuck not being able to support newer TLS versions! -Dan On Wed, Oct 24, 2018 at 11:23 AM Jinmei Liao wrote: > Most of our SSL tests failed with jdk11 because jdk11 includes an > implementation of TLS1.3 protocol, so if tcpServer i

Geode 1.8 Release Manager

We are coming up on the date where we said we would start the 1.8 release (Nov 1st). Any volunteers to be release manager for this release? -Dan

Re: [PROPOSAL] Add getCache and getLocator to Launchers

Yay for APIs that don't require singletons! -Dan On Wed, Oct 31, 2018 at 2:54 PM Jinmei Liao wrote: > +1. sounds like a good addition and since we already have package level > getters for them anyway. > > On Wed, Oct 31, 2018 at 2:48 PM Kirk Lund wrote: > > > LocatorLauncher provides an API wh

Re: [PROPOSAL] --add-opens for Java 11 support

A couple of questions: 1) Are you proposing changing gfsh start server to automatically add these add-opens, or are you suggesting users will have to do that? 2) Are these add-opens required for running a geode client? -Dan On Thu, Nov 1, 2018 at 9:48 AM Patrick Rhomberg wrote: > In case anyon

Re: [PROPOSAL] --add-opens for Java 11 support

t > jdk11 > > > support is still in beta mode. > > > > > > On Thu, Nov 1, 2018 at 10:33 AM Jinmei Liao wrote: > > > > > > > 1) yes, gfsh script will need to be updated to add these > > configurations. > > > > 2) yes, these ad-opens are re

Re: [PROPOSAL] --add-opens for Java 11 support

AM Jinmei Liao wrote: > Dan, are you saying we do or do not need --add-opens for reflection? The > opens directive is for open up classes in its own modules for reflection. I > don't think we can use that to open up jdk's packages, can we? > > On Fri, Nov 2, 2018 at

Re: Apache Geode Branch Housekeeping

Our release tags should already be protected. We create all of our release tags under rel/ which apache protects by default. [1] Maybe we should just create rel/XXX tags for the heads of the branches Anthony mentioned and delete the branches themselves? https://git-wip-us.apache.org/docs/switchin

[DISCUSS] Disable merge for failing pull requests

Hi all, Kirks emails reminded me - I think we are at the point now with our PR checks where we should not be merging anything to develop that doesn't pass all of the PR checks. I propose we disable the merge button unless a PR is passing all of the checks. If we are in agreement I'll follow up wi

Re: [DISCUSS] Disable merge for failing pull requests

gt; >>> On Mon, Nov 12, 2018 at 8:47 AM Bruce Schuchardt < > bschucha...@pivotal.io > >>> > >>> wrote: > >>> > >>>> I'm in favor of this. > >>>> > >>>> Several times over the years we've made a bi

[DISCUSS] - Create new repository for geode benchmarks

Hi all, We (Naba, Sean, Brian and I) would like to add some benchmarks for geode, with a goal of eventually running them as part of our concourse build and detecting performance changes. We think it makes sense to put these benchmarks in a separate geode-benchmarks repository. That will make them

Re: [DISCUSS] - Create new repository for geode benchmarks

in geode repo (or worse, after a release) > > On Thu, Nov 15, 2018 at 10:47 AM Dan Smith wrote: > > > Hi all, > > > > We (Naba, Sean, Brian and I) would like to add some benchmarks for geode, > > with a goal of eventually running them as part of our concourse build an

Re: Jira write access

What's your jira user name? -Dan On Mon, Nov 19, 2018 at 1:39 PM Robert Houghton wrote: > Hi all. I have a few opened Geode JIRA issues that I would like to be able > to delegate and work on, but I don't have access to the 'assign' or > 'resolve' actions. Can I get access? > > Thank you, > -Rob

Re: Jira write access

Ok, you should have access now. -Dan On Mon, Nov 19, 2018 at 3:03 PM Robert Houghton wrote: > rhoughton > > On Mon, Nov 19, 2018 at 2:54 PM Dan Smith wrote: > > > What's your jira user name? > > > > -Dan > > > > On Mon, Nov 19, 2018 at 1:39 PM

Re: [DISCUSS] - Create new repository for geode benchmarks

Seems like there is enough consensus. I will go ahead and create the repo. Thanks! -Dan On Fri, Nov 16, 2018 at 1:37 PM Kirk Lund wrote: > +1 total agreement then! > > On Fri, Nov 16, 2018 at 10:05 AM Dan Smith wrote: > > > Hi Kirk, > > > > What we're thin

Re: [DISCUSS] Disable merge for failing pull requests

Just to clarify, that flaky EvictionDUnitTest is old flaky. The PR to > > refactor the test passed all checks, even the repeatTest as well. I had a > > closed PR that just touched the "un-refactored" EvictionDUnitTest, it > > wouldn't even pass the repeatTest at al

Re: [DISCUSS] Geode packages mustn't span Jigsaw modules

I think we can actually fix most of these issues without geode-2.0. Most of these are in internal packages, which means we can change the package of these classes without breaking users. The only concerning one is org.apache.geode.cache.util, which is a public package. However, the AutoBalancer is

Travis Karma?

Does anyone have the creds to enable travis on the geode-benchmarks repo? We have it enabled on all of our other geode repos. https://travis-ci.org/apache/geode-benchmarks -Dan

Re: JIRA write access?

Done! -Dan On Mon, Nov 26, 2018 at 11:15 AM Sean Goller wrote: > Hi, In order to start dealing with some JIRA tickets could I get assign and > resolve access? > My apache username is smgoller. > > Thanks! > > -Sean. >

Re: New Geode PMC Chair: Karen Miller

Congratulations Karen! And thanks for all of your hard work, Mark! -Dan On Mon, Nov 26, 2018 at 11:56 AM Mark Bretl wrote: > Hello Geode Community, > > After two years, the Project Management Committee (PMC) agreed to > transition the role of PMC chair from me to another PMC member. I would > l

Re: [DISCUSS] Geode packages mustn't span Jigsaw modules

to move to a real wire-format with a well-defined > protocol but that's probably a separate project in its own right. > > Are you really convinced that we could move internal classes around without > breaking rolling upgrades, client-server backwards compatibility and > diskstore

Re: [VOTE] Apache Geode 1.8.0 RC1

I see a few things with the artifacts that I think should be tweaked 1. No pgp signature for the sources! 2. No zip file for the geode, just .tgz. Older releases on our website have both zip and tgz. See the differences between [1] and [2] 3. pgp signature for the native source is not ascii armored

Re: [VOTE] Apache Geode 1.8.0 RC1

p utilities > gained > > > native support for .tgz archives. If there is still a segment of the > > Geode > > > user community that would suffer hardship due to lack of .zip > packaging, > > we > > > should revisit this decision. > > > > >

Re: [VOTE] Apache Geode 1.8.0 RC1

/master_middleman/source/subnavs -Dan On Mon, Dec 3, 2018 at 1:43 PM Dan Smith wrote: > I see some issues with the native source release that I think are a > problem. > > I looked into the travis for the native code - it looks like travis is > passing, but finding files with missing lice

Re: PowerMock and mock ClassLoader

+1 to removing PowerMock. Any situation that needs PowerMock needs refactoring more. -Dan On Tue, Dec 4, 2018 at 10:27 AM Kirk Lund wrote: > Anyone have any ideas which unit test is using PowerMock and is injecting a > mock ClassLoader? This keeps failing in my precheckin runs. I think we need

Re: [VOTE] Apache Geode 1.8.0 RC2

The native source distribution tarball seems to have a lot of files that aren't in source control. See attached: -Dan On Wed, Dec 5, 2018 at 6:19 PM Alexander Murmann wrote: > Hi Apache Geode community, > > Below you find all the information for the the second release candidate of > Geode 1.8.0

Re: [VOTE] Apache Geode 1.8.0 RC2

-0. Code looks good to me and it passes geode-release-check. But I'd really like to see some people who have worked on the native code sign off on this release. We haven't released the native code before, and I don't know how to validate it other than just to see that it compiles, which doesn't sa

Re: Cluster Manage Service Proposal wiki edit access

Hi Peter, Sure, what's your user name on the apache wiki? -Dan On Tue, Dec 11, 2018 at 1:08 PM Peter Tran wrote: > Hi Geode Devs, > > I was having a look at > > https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_GEODE_Cluster-2BManagement-2BService&d=DwIBa

Re: Cluster Manage Service Proposal wiki edit access

Hi Peter, You should have access now. Thanks! -Dan On Wed, Dec 12, 2018 at 7:04 AM Peter Tran wrote: > Thanks Dan! > > It's ptran > > On Tue, Dec 11, 2018 at 4:16 PM Dan Smith wrote: > > > Hi Peter, > > > > Sure, what's your user name on the ap

Re: geode git commit: GEODE-2421: Adding packer portion of making a VS2015 dev AMI

>>> tar xzf apache-geode-${GEODE_VERSION}.tar.gz && \ > >>> ls / > >>> #rm apache-geode-${GEODE_VERSION.tar}.tar.gz > >>> > >>> ENV GEODE /apache-geode-${GEODE_VERSION} > >>> ENV JAVA_HOME /usr/lib/jvm/java-8-openj

Re: [DISCUSS] Release branch for 1.1.0

+1 for pushing out GEODE-2413. I think what Anthony said makes sense. -Dan On Fri, Feb 3, 2017 at 2:32 PM, Anthony Baker wrote: > > > On Feb 3, 2017, at 2:03 PM, Hitesh Khamesra > wrote: > > > > GEODE-2413 : Implementing a peer-to-peer protocol for mutual auth > require some more investigatio

geode-old-versions subproject?

One thing Hitesh and I noticed is that when you do a build, it creates a directory called geode-old-versions because there is a line in settings.gradle for a geode-old-versions project. Is this leftover cruft, or is it actually supposed to be there? I see a couple of references to geode-old-versio

Re: PR Buckets are created during Get call for non-existing key

Hi Avinash, Any time you try to use a bucket it will get created. It doesn't matter if you are trying to put or get values. -Dan On Sat, Feb 4, 2017 at 9:32 PM, Avinash Dongre wrote: > Hi, > In the following test, I have one PR, No buckets will be created initially. > But when I call get on no

Re: Apache policy on files types allowed in source code

I don't know about apache policy, but I think anything that can't be easily modified is probably a bad thing to have in the source code. If there is a binary jar, but there's no way to update the jar to modify the test that seems like a problem. Since we have a framework to run tests with old vers

Re: geode-old-versions subproject?

t/dunit/ > standalone/VersionManager.java: propFile = new > File("../geode-old-versions/build/geodeOldVersionClasspaths.txt"); > settings.gradle:include 'geode-old-versions' > > I noticed the geode-old-versions showed up in the src release as an empty >

Re: [VOTE] RC1: Apache Geode release - v1.1.0

-1 (binding) I dug into the geode-old-versions project some more. It looks like we may not be running the backwards compatibility tests. I filed this bug, which I think we should fix before shipping: GEODE-2433 - Backwards compatibility tests are not actually running If we're spinning another RC

Re: geode-old-versions subproject?

> For me, the "--tests" option seems to only work with the "test" task (not > "integrationTest" or "distributedTest" which I've brought up before). > It does work with the syntax I sent. For example if you take the BC out of the name of the test and run the command from my last email, it will find

Review Request 56346: GEODE-2432: Disable maven artifacts for geode-benchmarks

Description --- GEODE-2432: Disable maven artifacts for geode-benchmarks Diffs - geode-benchmarks/build.gradle b6f09bcff645aaee7bcc1de8acaf3025d239b978 Diff: https://reviews.apache.org/r/56346/diff/ Testing --- Thanks, Dan Smith

Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

- geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java 7bda9481275d3801e347ae6dfd66520e3f123a3a geode-old-versions/build.gradle a09b2d71c4ae9ab393b2d6e9cd44d94155e760f9 Diff: https://reviews.apache.org/r/56348/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 56355: GEODE-2314: EOF file segment exceptions due to empty file

("", e); throw new FunctionException(e); } - Dan Smith On Feb. 6, 2017, 11:47 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 56355: GEODE-2314: EOF file segment exceptions due to empty file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56355/#review164440 --- Ship it! Ship It! - Dan Smith On Feb. 7, 2017, 12:49 a.m

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

Diff: https://reviews.apache.org/r/56348/diff/ Testing --- Thanks, Dan Smith

Re: Feb 2017 Board Report DRAFT FOR REVIEW (need your input on Tuesday 2/7 if possible)

Looks good! A couple of minor edits: "open dev list" => "dev list" "commmitters" => "committers" -Dan On Mon, Feb 6, 2017 at 5:19 PM, Dave Barnes wrote: > Please review and comment by COB Tuesday, 2/7/2017, as the report is due on > Wednesday. Thanks! > > ## Description: > > - Apache Geode pr

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

rated e-mail. To reply, visit: https://reviews.apache.org/r/56348/#review164448 ------- On Feb. 7, 2017, 12:53 a.m., Dan Smith wrote: > > --- > This is

Re: Review Request 56398: use function to implement waitUntilFlushed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56398/#review164531 --- Ship it! Awesome! - Dan Smith On Feb. 7, 2017, 6:10 p.m

Re: Review Request 56399: GEODE-2403: Number of queries executed stat is incremented before making the lastResult call

treated this way? - Dan Smith On Feb. 7, 2017, 6:31 p.m., nabarun nag wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Fix version should be 1.2 for issues fixed on develop

Just a reminder that since we've already cut the 1.1.0 release branch, anything fixed on develop should be marked with a fix version of 1.2.0, not 1.1.0. -Dan

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

s or > > is 'main' so the tests may use it? > > Dan Smith wrote: > I was thinking that at some point in the future we might want to get this > file from the classpath, rather than what the code is doing now where it's > poking around on the filesystem. >

Re: Nightly build broken

Actually, now that I think about it GEODE-2434 was probably the cause of these backwards compatibility test failures. The build was generating the geodeOldVersionClasspaths file during the configuration phase. What that means is if you run './gradlew clean precheckin', the file gets generated *befo

Re: Contributor Permissions in Jira

Hi Sarge, What's your JIRA username? -Dan On Tue, Feb 7, 2017 at 2:46 PM, Michael William Dodge wrote: > As I'm working on the native code, may I have contributor permission in > Jira so that I may resolve things that I've fixed. Thanks. > > Sarge

Re: Contributor Permissions in Jira

Hmm, you seem to be in there already so either you were added at point in the past or someone just added you. Let me know if you have any access issues. -Dan On Tue, Feb 7, 2017 at 5:19 PM, Michael William Dodge wrote: > PivotalSarge > > > On 7 Feb, 2017, at 14:57, Dan Smith wrote

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

/VersionManager.java (line 148) <https://reviews.apache.org/r/56457/#comment236505> Is this method still needed? - Dan Smith On Feb. 8, 2017, 7:01 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically gener

Re: Review Request 56425: GEODE-2272: do not use a new method to start locator with pulse

> On Feb. 8, 2017, 7:49 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java, > > line 130 > > > > > > I didn't notice use of "gemfire.home" before but

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

riate way to handle failures. Maybe the code that actually uses versions should be what triggers this intialization, and we throw the exception and fail at that point, rather than doing this stuff in a static initializer? - Dan Smith On Feb. 8, 2017, 8:57 p.m., Bruce Schuchardt

Re: Removal of distributed transaction tests

What's wrong with these tests? Are you saying there is coverage elsewhere? -Dan On Thu, Feb 9, 2017 at 12:02 PM, Kirk Lund wrote: > Do we really want our nightly build and precheckin runs to waste time > running these tests? > > DistributedTransactionDUnitTest > DistTXDebugDUnitTest > DistTXOrd

Re: WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest

I think Gester already fixed this one: commit 857cd292e8e5d52e5b7a367682e445552a3de25b Author: zhouxh Date: Wed Feb 8 23:02:51 2017 -0800 GEODE-2400: The WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest should return false for local callable in negative case since there's no m

Re: Nightly geode failure due to DNS

This is a really weird test, using a bunch of arrays pass things around. In this case it looks like the DistributedMember objects were equal, but it fails when because it's essentially validating the toStrings of the member ids. I think maybe we should just remove the validation of the toString me

Re: Review Request 56520: Update dependency versions

direct dependencies. Do we really have a direct dependency on bcel, for example? If not it seems like we shouldn't manually set the bcel version - we should let gradle pull whatever version is required by whatever dependency we have that uses bcel. - Dan Smith On Feb. 10, 2017, 12:07 a.m.,

Re: Propose a new implementation for collections in Geode transaction (GEODE-2392)

+1 - I actually thought these operations didn't include the transaction state - like queries. Will this affect the way that queries operate with transactions? -Dan On Thu, Feb 9, 2017 at 6:03 PM, Anilkumar Gingade wrote: > +1.. > The Geode transaction is built to work efficiently with smaller >

Re: BaseLineAndCompareQueryPerfJUnitTest failure

We do have support for running micro benchmarks with jmh - see the geode-benchmarks project. But we don't have anything to watch and fail the build if the performance gets worse. That may be kinda hard to do since we're running on shared infrastructure. -Dan On Thu, Feb 9, 2017 at 6:13 PM, Anilku

Re: Review Request 56557: GEODE-2459 When node fails while renaming, new primary node resumes and may delete chunks

destination file is deleted? It looks like then the source file would lose its chunks. - Dan Smith On Feb. 10, 2017, 7:42 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: [VOTE] RC2: Apache Geode release - v1.1.0

I don't think we should be too concerned about incubating reference in BUILDING.md or those docker files. The docs are a little more concerning, but I think what's probably more important is fixing the manual that's up on the the website. As far as I know building and updating the manual is a manu

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

ode/internal/hll/Bits.java (line 14) <https://reviews.apache.org/r/56564/#comment237051> Technically, the hyperloglog stuff wasn't introduced for redis. But maybe it's the only component using this stuff now? - Dan Smith On Feb. 10, 2017,

Re: [VOTE] RC2: Apache Geode release - v1.1.0

+1 (binding) IMO I think we don't have to hold up this release for the incubating references in BUILDING, docker, etc. as long as we can make the docs on the website correct. Is someone working on cleaning up the incubating references on develop? Verified: - signatures of artifacts - download a

Re: Review Request 56613: GEODE-2475: Upgrade Lucene version to 6.4.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56613/#review165392 --- Ship it! Ship It! - Dan Smith On Feb. 13, 2017, 9:02 p.m

Re: New Committer And PMC Member: Jared Stewart

Sweet! Welcome! -Dan On Mon, Feb 13, 2017 at 12:23 PM, Kenneth Howe wrote: > Congratulations Jared > > > On Feb 13, 2017, at 12:07 PM, Joey McAllister > wrote: > > > > Nice! Congratulations, Jared! > > > > On Mon, Feb 13, 2017 at 11:59 AM Mark Bretl wrote: > > > >> The Apache Geode Project Ma

Re: GeodeRedisAdapter improvments/feedback

I also had a hard time reading this. It sounds like the tl;dr is that your are proposing storing each redis collection in a single region entry, rather than a a partition region? I guess the question is whether users will have a few very large collections that need to be partitioned, or lots and lo

[DISCUSS] JIRA guidelines

We have this draft of JIRA guidelines sitting on the wiki. I updated it slightly. Can we agree on these guidelines and remove the draft label? Is there more that needs to be here? https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=57311462 -Dan

Re: Build failed in Jenkins: Geode-nightly #749

Galen - I'm guessing you might be trying to click on the link below? I'm not sure jenkins actually keeps that stuff - I think it's just looking for file:/// urls in the console output and translating them to http:// urls. You should be able to find the test results by going to the test result link

Re: GeodeRedisAdapter improvments/feedback

Doing the spill/unspill option could be pretty tricky to implement, so you have to do a lot of fancy logic in the transition period. I think Jason's suggestion of configuring things might make more sense. -Dan On Wed, Feb 15, 2017 at 1:12 PM, Jason Huynh wrote: > With the suggestion from Wes, t

Re: [DISCUSS] JIRA guidelines

Mon-Fri 9:00am to > >>> 5:30pm JST | 1-877-477-2269 > >>> [image: support] <https://support.pivotal.io/> [image: twitter] > >>> <https://twitter.com/pivotal> [image: linkedin] > >>> <https://www.linkedin.com/company/3048967> [imag

Re: Review Request 56719: GEODE-2491: Reduce logging of handled exceptions in LuceneEventListener and LuceneBucketListeners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56719/#review165774 --- Ship it! Ship It! - Dan Smith On Feb. 15, 2017, 8:54 p.m

Re: Voting Process

+1. Good catch! -Dan On Wed, Feb 15, 2017 at 2:49 PM, Michael William Dodge wrote: > +0.9 :) > > > On 15 Feb, 2017, at 14:48, Anthony Baker wrote: > > > >> > >> On Feb 15, 2017, at 2:40 PM, Mark Bretl wrote: > >> > >> Hi, > >> > >> Now that we are a top-level project, we need to make sure vot

Re: GeodeRedisAdapter improvments/feedback

Deltas would help. If the regions are persistent, the whole new value does get written to disk though. I suppose a third option would be to store all collections in the same region, but store each element of the collection as a separate entry. For example for HSET rkey rfield rvalue would create a

Re: Requesting more JIRA permission

Hi Addison, What's your JIRA user id? I can add you. Our policy is to give JIRA permissions to anyone that asks, so there's no need for a vote to give you access. I think we haven't been totally clear on how people can get access to JIRA and the wiki, sorry about that! I did recently add a little

<    1   2   3   4   5   6   7   8   9   10   >