e code.
- Ken Howe
On Feb. 17, 2017, 10:21 p.m., Kevin Duling wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/#review166005
---
Ship it!
Ship It!
- Ken Howe
On Feb. 17, 2017, 11:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/#review166763
---
Ship it!
Ship It!
- Ken Howe
On Feb. 24, 2017, 9:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56668/#review165545
---
Ship it!
Ship It!
- Ken Howe
On Feb. 14, 2017, 5:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56637/#review165559
---
Ship it!
Ship It!
- Ken Howe
On Feb. 14, 2017, 7 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56522/#review165136
---
Ship it!
Ship It!
- Ken Howe
On Feb. 10, 2017, 12:57 a.m
d e-mail. To reply, visit:
https://reviews.apache.org/r/56506/#review165186
-------
On Feb. 11, 2017, midnight, Ken Howe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/565
/cache/Oplog.java 0b98364
geode-core/src/test/java/org/apache/geode/internal/cache/OplogFlushTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/56506/diff/
Testing
---
Started precheckin
Thanks,
Ken Howe
- Ken
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56506/#review164991
---
On Feb. 11, 2017, midnight, Ken Howe wrote:
>
>
/ServerStarterRule.java
(lines 89 - 94)
<https://reviews.apache.org/r/56637/#comment237407>
Looks like a null properties argument will cause an NPE
- Ken Howe
On Feb. 14, 2017, 4:19 p.m., Jinmei Liao
/internal/cache/OplogFlushTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/56506/diff/
Testing
---
Started precheckin
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56516/#review165128
---
Ship it!
Ship It!
- Ken Howe
On Feb. 9, 2017, 8:06 p.m
I’m working on the NetstatDUnitTest failure. GEODE-2541
Ken
> On Feb 28, 2017, at 8:35 AM, Apache Jenkins Server
> wrote:
>
> 2: Task failed with an exception.
> ---
> * What went wrong:
> Execution failed for task ':geode-core:flakyTest'.
>> There were
://reviews.apache.org/r/57221/diff/1-2/
Testing
---
Ran spotlessApply
Precheckin is in progress
Thanks,
Ken Howe
---
Precheckin is running
Thanks,
Ken Howe
>
> (Updated March 30, 2017, 6:17 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe,
> Kirk Lund, and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> ---
>
> exp
ated e-mail. To reply, visit:
> https://reviews.apache.org/r/58050/
> ---
>
> (Updated March 30, 2017, 6:17 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe,
> Kirk Lund, and Swapnil Bawaskar.
>
>
> Repository: geode
>
216)
at
org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146)
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57729/#review169799
---
- Ken Howe
On March 17, 2017, 6:48 p.m., Jinmei Liao wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57729/#review169795
---
- Ken Howe
On March 17, 2017, 6:48 p.m., Jinmei Liao wrote
the change noted above.)
- Ken Howe
On March 28, 2017, 10:34 p.m., Patrick Rhomberg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
216)
at
org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146)
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57729/#review169524
---
Ship it!
Ship It!
- Ken Howe
On March 17, 2017, 6:48 p.m
apping is:
LogWriter.FINE and FINER --> Level.DEBUG
LogWriter.FINEST --> Level.TRACE
The new mapping has
LogWriter.FINE --> Level.DEBUG
LogWriter.FIBNER abnd FINEST --> Level.TRACE
- Ken Howe
On March 17, 2017, 6:48 p.m.,
move the deleted files dir
from the dir.listFiles() rather than arbitarily returning length - 1. Something
like
List listOfFiles = Arrays.asList(dir.listFiles());
listOfFiles.remove(dirOfDeletedFiles.getName());
return listOfFiles.size();
- Ken Howe
On March 13, 2017,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57573/#review169054
---
Ship it!
Ship It!
- Ken Howe
On March 15, 2017, 8:02 p.m
206)
at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:216)
at
org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146)
Re-running precheckin after merging current develop to my branch.
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58319/#review171491
---
Ship it!
Ship It!
- Ken Howe
On April 10, 2017, 9:06 p.m
://reviews.apache.org/r/58325/diff/1/
Testing
---
All Pulse UI tests run locally pass.
Precheckin is running
Thanks,
Ken Howe
y pass.
Precheckin is running
Thanks,
Ken Howe
216)
at
org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146)
Re-running precheckin after merging current develop to my branch.
Thanks,
Ken Howe
ing
Thanks,
Ken Howe
/diff/2-3/
Testing (updated)
---
==> Precheckin was clean other than spotlessCheck. Re-runing the precheckin
after reformatting to correct the failure
All Pulse UI tests run locally pass.
Precheckin is running
Thanks,
Ken Howe
to have been somewhat haphazard up to now.
This commnent applies to all our rules, not just this one.
- Ken Howe
On April 12, 2017, 3:08 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generated e-mail. To rep
ts a boolean
to start (or not) later in the before() method. My interpretation is that it's
an "auto start" flag for each test.
- Ken Howe
On April 12, 2017, 3:08 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatic
> On April 12, 2017, 9:10 p.m., Ken Howe wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
> > Lines 110 (patched)
> > <https://reviews.apache.org/r/58388/diff/2/?file=1690839#file1690839line110>
> >
> > I
st/java/org/apache/geode/internal/cache/control/MemoryMonitorJUnitTest.java
Lines 297-301 (original), 297-301 (patched)
<https://reviews.apache.org/r/58460/#comment245101>
Spotless seems to have made a mess of this and the following comment.
- Ken Howe
On April 14, 2017, 9:
798 (which is a dupilcate of
GEODE-2681.)
Precheckin has been started.
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58435/#review171956
---
Ship it!
Ship It!
- Ken Howe
On April 13, 2017, 10:15 p.m
ithAutoStart() ?
- Ken Howe
On April 12, 2017, 11:32 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172364
---
Ship it!
Ship It!
- Ken Howe
On April 18, 2017, 9:58 p.m
/LocatorServerStartupRule.java
Line 67 (original), 63 (patched)
<https://reviews.apache.org/r/58518/#comment245592>
Javadoc comment is no longer needed
- Ken Howe
On April 19, 2017, 11:22 p.m., Jared Stewart
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58460/#review172121
---
Ship it!
Ship It!
- Ken Howe
On April 17, 2017, 7:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168474
---
Ship it!
Ship It!
- Ken Howe
On March 7, 2017, 7:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57439/#review168468
---
Ship it!
Ship It!
- Ken Howe
On March 9, 2017, 12:44 a.m
to the latest (version 3) without
examining the intermediate changes.
As these changes appear that they won't break nightly builds (your precheckin
passed), it would be great to get this merged so that further refinements to
the export logs command behavior can be dealt with individually.
- Ken Howe
Diff: https://reviews.apache.org/r/57249/diff/2/
Changes: https://reviews.apache.org/r/57249/diff/1-2/
Testing
---
Tested locally on JVMs with small heap to verify there are no OOMEs
Precheckin has been started.
Thanks,
Ken Howe
en started
Thanks,
Ken Howe
Ran spotlessApply
Re-started precheckin
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57431/#review168833
---
Ship it!
Ship It!
- Ken Howe
On March 13, 2017, 6:05 p.m
ent240005>
Is the upper_bound a useable port? If so then the outer loop test should be
'<='. Also in the test condition, the upper_bound should be reduced by the
count to enusre that i + j doesn't exceed the upper_bound.
- Ken Howe
On March 4, 2017, 1:57 a.m.,
atched)
<https://reviews.apache.org/r/57242/#comment239611>
Why use locatorPort from 0 to -1? The test in startServer(Properties
properties, int locatorPort, boolean pdxPersistent) is for >0
- Ken Howe
On March 2, 2017, 3:30 p.m., Ji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167511
---
Ship it!
Ship It!
- Ken Howe
On March 1, 2017, 1:39 a.m
/
Testing
---
Ran spotlessApply
Precheckin is in progress
Thanks,
Ken Howe
/internal/cli/commands/GfshCommandJUnitTest.java
Line 411 (original), 411 (patched)
<https://reviews.apache.org/r/61671/#comment258982>
Why was this test renamed? Not really a problem but on the surface looks
unneeded.
- Ken Howe
On Aug. 15, 2017, 7:29 p.m., Kirk Lund
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61627/#review183037
---
Ship it!
Ship It!
- Ken Howe
On Aug. 14, 2017, 10:40 p.m
independant constructs is always
good. I didn't try this out myself on a Windows machine but the fix looks good.
- Ken Howe
On Aug. 11, 2017, 10:42 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review180683
---
Ship it!
Ship It!
- Ken Howe
On July 17, 2017, 3:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60985/#review181069
---
Ship it!
Ship It!
- Ken Howe
On July 20, 2017, 5:54 p.m
<https://reviews.apache.org/r/60985/#comment256480>
Seems there's opportunity for more tests in here, for instance,
queryWithInvalidRegionName, queryInvalidExceptionThrown, etc.
Have you checked coverage, in particular for the new classes QueryCommand,
and QueryInterceptor
- Ken Ho
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60977/#review180959
---
Ship it!
Ship It!
- Ken Howe
On July 19, 2017, 5:14 p.m
should be marked
as @Deprecated for the upcoming release rather than immediately removing it.
Removing the @Deprecated annotation on the 3-arg method is appropriate as this
is now the preferred method.
- Ken Howe
On July 5, 2017, 7:47 p.m., Jinmei Liao wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58751/#review173213
---
Ship it!
Ship It!
- Ken Howe
On April 26, 2017, 8:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58742/#review173224
---
Ship it!
Ship It!
- Ken Howe
On April 26, 2017, 5:17 p.m
larity to the code. Exceptions would be where the
name might conflict with a keyword, which is not the case here.
- Ken Howe
On April 28, 2017, 6:02 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58848/#review173384
---
Ship it!
Ship It!
- Ken Howe
On April 28, 2017, 7:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61409/#review182227
---
Ship it!
Ship It!
- Ken Howe
On Aug. 3, 2017, 5:12 p.m
/ConfigurationProperties.java
Lines 691 (patched)
<https://reviews.apache.org/r/61417/#comment258115>
Is this declaration needed? It doesn't appear to be used anywhere
- Ken Howe
On Aug. 3, 2017, 9:15 p.m., Jinmei Liao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61196/#review181674
---
Ship it!
Ship It!
- Ken Howe
On July 27, 2017, 10:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61480/#review182443
---
Ship it!
Ship It!
- Ken Howe
On Aug. 8, 2017, 9:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61480/#review182440
---
Ship it!
- Ken Howe
On Aug. 8, 2017, 9:10 p.m., Jinmei Liao
(cache, cacheServer, ...)
- Ken Howe
On Aug. 8, 2017, 12:19 a.m., Kirk Lund wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
unit/rules/GfshShellConnectionRule.java
e7f17ef208a1708f385c7c4041affb70fd309a4c
Diff: https://reviews.apache.org/r/61426/diff/1/
Testing
---
Precheckin ran green
Thanks,
Ken Howe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61627/#review183042
---
Ship it!
Ship It!
- Ken Howe
On Aug. 16, 2017, 5:24 p.m
/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
e7f17ef208a1708f385c7c4041affb70fd309a4c
Diff: https://reviews.apache.org/r/61701/diff/1/
Testing
---
Precheckin is in progress.
Thanks,
Ken Howe
)
---
Precheckin from earlier ran green.
Re-running precheckin with this additional refactoring.
Thanks,
Ken Howe
mand correctly shows the locator is online when given
the correct `--port=...` value.
- Ken
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61701/#review183145
---
On Aug. 16, 2017, 9:21 p.m., Ken Howe wrot
+1 Yes, let’s make the move
> On Aug 22, 2017, at 11:21 AM, Nabarun Nag wrote:
>
> +1
>
> On Tue, Aug 22, 2017 at 11:15 AM Kirk Lund wrote:
>
>> +1 to move all our repos to gitbox
>>
>> On Tue, Aug 22, 2017 at 11:08 AM, Jacob Barrett
(updated)
---
Re-running precheckin
Thanks,
Ken Howe
tps://reviews.apache.org/r/5/#comment246693>
more comment formatting
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
>
> ---
> This is an automat
tps://reviews.apache.org/r/5/#comment246693>
more comment formatting
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
>
> ---
> This is an automat
tps://reviews.apache.org/r/5/#comment246693>
more comment formatting
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
>
> ---
> This is an automat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58682/#review173528
---
Ship it!
Ship It!
- Ken Howe
On April 27, 2017, 6:30 p.m
che/geode/cache/query/internal/QueryUtils.java
Line 1503 (original), 1409 (patched)
<https://reviews.apache.org/r/5/#comment246589>
For consistency, suggest renaming this method to
getConditionedRelationshipIndexResultsExpandedToTopOrCGJLevel
(similar to the renamed getConditionedI
ode/cache/query/internal/index/AbstractIndex.java
Line 1223 (original), 1256 (patched)
<https://reviews.apache.org/r/5/#comment246788>
typo: remove '//' that are left over from the original comment
- Ken Howe
On May
empty inner class we won't get a stack trace at all. So just throw the
new exception and let the default constructor fill in the stack trace and
casue. If the intent was to not have the cause filled in then couldn't we just
throw a new zero-arg CacheException?
- Ken Howe
On May 2, 2017, 12:
views.apache.org/r/5/#comment246856>
typo - correspnds to my note on line 111
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
/InternalLocator.java
Lines 97-98 (original), 96-97 (patched)
<https://reviews.apache.org/r/5/#comment246860>
In the javadoc, missing a closing '}' and a ';' between the first two
statments
- Ken Howe
On May 2, 2017, 12:06 a.m., Kirk Lund
d and
cancelled are considered correct, and we use both of them.
- Ken Howe
On May 3, 2017, 10:10 p.m., Kirk Lund wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
che.org/r/5/#comment246892>
Suggest rewording this comment "For a long time conflict checks were turned
off ..."
- Ken Howe
On May 3, 2017, 10:10 p.m., Kirk Lund wrote:
>
> ---
> This is an automatically ge
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59246/#review175004
---
Ship it!
Ship It!
- Ken Howe
On May 12, 2017, 10:12 p.m
nly DistributedTest still
running
Thanks,
Ken Howe
tps://reviews.apache.org/r/59287/diff/1-2/
Testing
---
Precheckin is in progress - all green so far with only DistributedTest still
running
Thanks,
Ken Howe
che.org/r/59299/#comment248354>
I'd favor a more descriptive test name that won't prompt digging through a
JIRA to figure out what the intent is.
"testGeode2874_nameWithoutExtensionDoesntThrow"?
- Ken Howe
On May 15, 2017, 10:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59299/#review175041
---
Ship it!
Ship It!
- Ken Howe
On May 15, 2017, 10:31 p.m
added org.apache.logging.log4j.Logger as an import
rather than specifying the full class path in the declaration.
- Ken Howe
On May 9, 2017, 3:32 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59210/#review174826
---
Ship it!
Ship It!
- Ken Howe
On May 12, 2017, 6:06 p.m
/dunit/rules/RequiresGeodeHome.java
Lines 28 (patched)
<https://reviews.apache.org/r/59961/#comment251315>
Many of us are in the habit of putting '\n' in message strings, but I think
using LINE_SEPARATOR would be better.
- Ken Howe
On June 9, 2017, 11:35 p.m., Jared Stewart
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60199/#review178272
---
Ship it!
Ship It!
- Ken Howe
On June 19, 2017, 4:09 p.m
ing quotes on the value arg.
-OR-
change those tests to be consistent with adding the quotes here.
- Ken Howe
On June 21, 2017, 10:51 p.m., Jared Stewart wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
1 - 100 of 159 matches
Mail list logo