Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

> On April 25, 2017, 9:10 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DataCommandFunctionWithPDXJUnitTest.java > > Lines 154 (patched) > > <https://reviews.apache.org/r/58682/diff/3/?file=1699792#file1699792line

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

> On April 25, 2017, 9:10 p.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java > > Line 301 (original), 317 (patched) > > <https://reviews.apache.org/r/58682/diff/3/?file=1699789#file1699789lin

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/#review173100 --- Ship it! Ship It! - Kirk Lund On April 26, 2017, 7:48 p.m

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

> On April 25, 2017, 5:43 p.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > > Lines 238 (patched) > > <https://reviews.apache.org/r/58589/diff/3/?file=1698725#file1698725line239> > > > &

Re: ASF review board down?

It's working for me now too. On Wed, Apr 26, 2017 at 1:56 PM, Dan Smith <dsm...@pivotal.io> wrote: > Works for me now. > > -Dan > > On Wed, Apr 26, 2017 at 11:22 AM, Kirk Lund <kl...@apache.org> wrote: > > > I'm unable to submit any review board reviews on &g

Re: Review Request 58742: GEODE-2632: minor fixes from code review

ough). Bruce is the best one to ask about this. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58742/#review173065 ------

Review Request 58751: GEODE-2632: make GemFireCacheImpl.getRegion(String) non-final

/58751/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

ParallelQueueRemovalMessageJUnitTest

FYI, I broke ParallelQueueRemovalMessageJUnitTest with a recent checkin and then I committed a temporary fix. So it should be back to passing. I now have a more complete fix ready to submit for review, but I'm unable to submit new requests on https://reviews.apache.org. Not sure what's wrong

ASF review board down?

I'm unable to submit any review board reviews on https://reviews.apache.org/. I was able to submit a review an hour or so ago, but now I get this cryptic message: "fatal: git cat-file: could not get object info Line undefined: undefined" Is anyone else still able to submit a review? The diff

Review Request 58742: GEODE-2632: minor fixes from code review

geode-core/src/test/java/org/apache/geode/cache/query/internal/index/NewDeclarativeIndexCreationJUnitTest.java e7f5c08cb3451e82dc1d3b23d777665b8fd05884 Diff: https://reviews.apache.org/r/58742/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

f298fae6f1840302bc98668a09e4a9b2ed0c0b5c geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java 0449a45c35569c672af06efdd9a1365283c435c3 Diff: https://reviews.apache.org/r/58712/diff/3/ Testing (updated) --- precheckin passed Thanks, Kirk Lund

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

, Kirk Lund

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

/controllers/CommonCrudController.java 0449a45c35569c672af06efdd9a1365283c435c3 Diff: https://reviews.apache.org/r/58712/diff/3/ Changes: https://reviews.apache.org/r/58712/diff/2-3/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

`Set`. Yep, I started down that route a couple days ago, but ran into some problems. It spills over into the DistributionAdvisor classes and pretty soon it's a huge change set. I'd like to leave DM and DistributionManager for a future refactoring. - Kirk --

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

not have a default pool. Use > > getQueryService(String poolName) instead."); > > } > > return defaultPool.getQueryService(); > > } > > ``` The nested if-else is horrific, so yes, that's a good change! - Kirk --- This is an automatically generated e

Re: apache geode jira edit permissions

You should be able to now! Let me know if you still can't assign/resolve/edit. On Tue, Apr 25, 2017 at 2:25 PM, Lynn Gallinat wrote: > I'm unable to assign or resolve issues in geode jira. > > My username is lgallinat > > > > -- >

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

s Rule only affects the main thread running in JUnit, right? - Kirk Lund On April 25, 2017, 6:20 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java Lines 37 (patched) <https://reviews.apache.org/r/58238/#comment246025> Recommend private on these vars. - Kirk Lund On April 6, 2017, 9:12 p.m., Jinmei Liao

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

UnitTest.java Lines 228 (patched) <https://reviews.apache.org/r/58682/#comment246024> I think this might be a case where it's cleaner to let this method "throws GfJsonException" and then any test that invokes this method can just use "throws Exception" and let that GfJson

[jira] [Created] (GEODE-2827) ClientCacheFactory might ignore a provided PoolFactory

Kirk Lund created GEODE-2827: Summary: ClientCacheFactory might ignore a provided PoolFactory Key: GEODE-2827 URL: https://issues.apache.org/jira/browse/GEODE-2827 Project: Geode Issue Type: Bug

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

ail. To reply, visit: > https://reviews.apache.org/r/58518/ > --- > > (Updated April 21, 2017, 10:34 p.m.) > > > Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund. > > > Repository: geode > > &g

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategyJUnitTest.java Line 87 (original), 69 (patched) <https://reviews.apache.org/r/58589/#comment245975> Wow, that's a long method name :) Remove the "j" from the middle? - Kirk Lund On April 25, 2017, 1:08 a.m., Jinmei Li

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

://reviews.apache.org/r/58712/diff/2/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

/CommonCrudController.java 0449a45c35569c672af06efdd9a1365283c435c3 Diff: https://reviews.apache.org/r/58712/diff/2/ Changes: https://reviews.apache.org/r/58712/diff/1-2/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

ache.org/r/58712/#comment245954> I purposely left this here. I'm going to followup with further changes to this test but I didn't want it to hold up this commit. - Kirk Lund On April 25, 2017, 4:46 p.m., Kirk Lund wrote: > > ---

Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

/QueryMonitorDUnitTest.java f298fae6f1840302bc98668a09e4a9b2ed0c0b5c geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java 0449a45c35569c672af06efdd9a1365283c435c3 Diff: https://reviews.apache.org/r/58712/diff/1/ Testing --- precheckin in progress Thanks, Kirk

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

n want to mention adding guava as a runtime dependency on geode dev to see what others think. I'm ok with adding guava (which was previously a test-only dependency). - Kirk Lund On April 24, 2017, 8:06 p.m., Patrick Rhomberg

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

tLogger help minimize any performance impact. Without it, Geode throughput is decreased substantially by Log4J 2 even at log levels above DEBUG simply by hitting logger.debug statements that are not enabled. - Kirk Lund On April 24, 2017, 8:06 p.m., Patrick Rh

Re: Simple Java Client

A couple things I'd like to see: 1) completely new API that doesn't reuse the old API classes (or at least not the giant classes such as Cache and Region interfaces) 2) separation of API and Impl so that users can compile their code against a dedicated client API jar On Mon, Apr 24, 2017 at 3:03

[jira] [Updated] (GEODE-2820) QueryIndexUsingXMLDUnitTest.testCreateAsyncIndexWhileDoingGIIAndCompareQueryResults is disabled

[ https://issues.apache.org/jira/browse/GEODE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2820: - Description: The test has an @Ignore annotation with value of "TODO: test is disabled because of #

[jira] [Updated] (GEODE-2820) QueryIndexUsingXMLDUnitTest.testCreateAsyncIndexWhileDoingGIIAndCompareQueryResults is disabled

[ https://issues.apache.org/jira/browse/GEODE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2820: - Description: The test has an @Ignore annotation with value of "TODO: test is disabled because of #

AsyncInvocation usage in dunit tests

I'm updating a test and noticed that this test is using an old pattern for AsyncInvocation which made me realize that I may not have mentioned this before... AsyncInvocation has been updated to make it easier to use. Example: AsyncInvocation asyInvk1 =

Re: Review Request 58582: GEODE-2632: 1st pass cleaning up GemFireCacheImpl

$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) Thanks, Kirk Lund

Re: Refactor gfsh parser

These changes look great. Thanks! On Thu, Apr 20, 2017 at 1:37 PM, Jinmei Liao wrote: > In the effort of adding option validation to gfsh commands (GEODE-1597) and > simplifying gfsh parsing, I started this exercise of only using > SpringShell's parser instead of a

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

passed except for FixedPRSinglehopDUnitTest which passes in rerun Thanks, Kirk Lund

Re: Review Request 58582: GEODE-2632: 1st pass cleaning up GemFireCacheImpl

/internal/cache/PRTXJUnitTest.java d2bad641a47f68edb22da0f89a04c462ab48cd33 Diff: https://reviews.apache.org/r/58582/diff/3/ Changes: https://reviews.apache.org/r/58582/diff/2-3/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58582: GEODE-2632: 1st pass cleaning up GemFireCacheImpl

/CacheCreation.java a5f0fc2bc7cf4250565aa8dd139004890b8da07d Diff: https://reviews.apache.org/r/58582/diff/2/ Changes: https://reviews.apache.org/r/58582/diff/1-2/ Testing --- precheckin in progress Thanks, Kirk Lund

Review Request 58582: GEODE-2632: 1st pass cleaning up GemFireCacheImpl

://reviews.apache.org/r/58582/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172523 --- Ship it! Ship It! - Kirk Lund On April 19, 2017, 11:22 p.m

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

://reviews.apache.org/r/58544/diff/2-3/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

ly, visit: https://reviews.apache.org/r/58537/#review172417 --- On April 19, 2017, 11:05 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

/ Testing --- precheckin passed Thanks, Kirk Lund

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

556311214371270259c024d565a6b4f0fa6a2146 Diff: https://reviews.apache.org/r/58544/diff/2/ Changes: https://reviews.apache.org/r/58544/diff/1-2/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

/58537/diff/1-2/ Testing --- precheckin passed Thanks, Kirk Lund

Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

d6068f1ecc88c076c3d1a8dbd3e3bc944766fbaa geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollector.java 66c4c0a298156926793f66eee1ac3efc85b27a14 Diff: https://reviews.apache.org/r/58544/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

/CacheProvider.java PRE-CREATION geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java PRE-CREATION Diff: https://reviews.apache.org/r/58537/diff/1/ Testing (updated) --- precheckin passed Thanks, Kirk Lund

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

> On April 19, 2017, 8:32 p.m., Kirk Lund wrote: > > It looks like LocatorServerStartupRule now always bounces VMs even if the > > test did not change user.dir. I thought you wanted it to bounce only if > > user.dir was altered? Maybe a UserDirRule would be better? This

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

even if the test did not change user.dir. I thought you wanted it to bounce only if user.dir was altered? - Kirk Lund On April 18, 2017, 9:58 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 58519: GEODE-2796: ClassPathLoader does not blow up with null TCCL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58519/#review172400 --- Ship it! Ship It! - Kirk Lund On April 19, 2017, 8:18 p.m

Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java PRE-CREATION Diff: https://reviews.apache.org/r/58537/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

Review Request 58484: GEODE-2632: refactoring part 2

/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java 8aa887b0412ae6446dc725d466bbd9ed6ad33f27 Diff: https://reviews.apache.org/r/58484/diff/1/ Testing --- precheckin in progress full regression testing in progress perf testing Thanks, Kirk Lund

[jira] [Assigned] (GEODE-2791) LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero fails intermittently with AssertionError

[ https://issues.apache.org/jira/browse/GEODE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2791: Assignee: Kirk Lund > LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZ

[jira] [Created] (GEODE-2791) LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero fails intermittently with AssertionError

Kirk Lund created GEODE-2791: Summary: LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero fails intermittently with AssertionError Key: GEODE-2791 URL: https://issues.apache.org/jira/browse

[jira] [Assigned] (GEODE-2790) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen fails intermittently with ComparisonFailure

[ https://issues.apache.org/jira/browse/GEODE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2790: Assignee: Kirk Lund > DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyp

[jira] [Created] (GEODE-2790) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen fails intermittently with ComparisonFailure

Kirk Lund created GEODE-2790: Summary: DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen fails intermittently with ComparisonFailure Key: GEODE-2790 URL: https://issues.apache.org/jira

Re: Review Request 58388: GEODE-2730: refactor rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58388/#review172124 --- Ship it! Ship It! - Kirk Lund On April 13, 2017, 10:13 p.m

Re: Review Request 58460: GEODE-2632: refactoring part 1

have to rewrite AutoBalancerJUnitTest using Mockito) additional testing Thanks, Kirk Lund

Re: Review Request 58460: GEODE-2632: refactoring part 1

-2/ Testing --- precheckin in progress Thanks, Kirk Lund

[jira] [Created] (GEODE-2789) Rewrite AutoBalancerJUnitTest to allow refactoring of GemFireCacheImpl

Kirk Lund created GEODE-2789: Summary: Rewrite AutoBalancerJUnitTest to allow refactoring of GemFireCacheImpl Key: GEODE-2789 URL: https://issues.apache.org/jira/browse/GEODE-2789 Project: Geode

Conditional bug in LocalRegion.concurrencyConfigurationCheck

I can't quite make out what the conditional is actually supposed to be checking in the second half but it definitely looks wrong to me. Anyone familiar with this method or what it's supposed to be doing? private void concurrencyConfigurationCheck(VersionTag tag) { // TODO: double negative in

Re: Review Request 58460: GEODE-2632: refactoring part 1

like GemFireCacheImpl. John created InternalCache to help with mocking and refactoring. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58460/#review172027 ----

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58393/#review172023 --- Ship it! Ship It! - Kirk Lund On April 13, 2017, 11:33 p.m

Review Request 58460: GEODE-2632: refactoring part 1

--- precheckin in progress Thanks, Kirk Lund

[jira] [Resolved] (GEODE-2647) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException

[ https://issues.apache.org/jira/browse/GEODE-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2647. -- Resolution: Fixed Fix Version/s: 1.2.0

[jira] [Resolved] (GEODE-2762) ArrayUtilsTest generates build warnings in geode-core

[ https://issues.apache.org/jira/browse/GEODE-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2762. -- Resolution: Fixed Fix Version/s: 1.2.0 > ArrayUtilsTest generates build warnings in geode-c

Review Request 58436: GEODE-2762: fix varargs warnings

70da91b9c6ab17a1fa8b8e4dc23cb2a96a2c4989 Diff: https://reviews.apache.org/r/58436/diff/1/ Testing --- * ./gradlew clean build -- varargs compilation warnings are gone * ArrayUtilsTest -- test passes * precheckin in progress Thanks, Kirk Lund

Review Request 58435: GEODE-2647: remove unnecessary client puts from ClientHealthStatsDUnitTest

enabled test is gone. Diffs - geode-core/src/test/java/org/apache/geode/management/ClientHealthStatsDUnitTest.java 51425713175b3c8fe41f1064ac8a02178fd45e38 Diff: https://reviews.apache.org/r/58435/diff/1/ Testing --- ClientHealthStatsDUnitTest precheckin in progress Thanks, Kirk

Re: Review Request 58388: GEODE-2730: refactor rules

t/rules/MemberStarterRule.java Lines 110 (patched) <https://reviews.apache.org/r/58388/#comment244967> I really like this change! Or as Ken and you said "withAutoStart" would be ok too. - Kirk Lund On

Re: Review Request 58388: GEODE-2730: refactor rules

> On April 13, 2017, 7:25 p.m., Kirk Lund wrote: > > I'm finding lots of instances where "withRegion" was changed to > > "createRegion" but it's an API or Util class that isn't related to your > > Rule changes. You probably don't want to change a

[jira] [Updated] (GEODE-2647) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException

[ https://issues.apache.org/jira/browse/GEODE-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2647: - Labels: Flaky (was: ) > ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fa

[jira] [Comment Edited] (GEODE-2647) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException

[ https://issues.apache.org/jira/browse/GEODE-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963594#comment-15963594 ] Kirk Lund edited comment on GEODE-2647 at 4/13/17 8:32 PM: --- >From Dar

[jira] [Comment Edited] (GEODE-2775) Pulse is not using certificate to connect to JMX when ssl is turned for jmx connection

[ https://issues.apache.org/jira/browse/GEODE-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966599#comment-15966599 ] Kirk Lund edited comment on GEODE-2775 at 4/13/17 7:46 PM: --- The problem lies

Re: Googling Apache Geode docs results in urls Not Found

ike Stolz > Principal Engineer, GemFire Product Manager > Mobile: +1-631-835-4771 > > On Thu, Apr 13, 2017 at 1:40 PM, Kirk Lund <kl...@apache.org> wrote: > > > If I google for something like "apache geode pulse Log-File-Location" > then > > the top few se

Re: Review Request 58388: GEODE-2730: refactor rules

apache/geode/cache/query/functional/IndexWithSngleFrmAndMultCondQryJUnitTest.java Line 641 (original), 641 (patched) <https://reviews.apache.org/r/58388/#comment244937> Another withRegion API you pro

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

UnitTest(). The superclass @Before method(s) are always executed before the subclass @Before method(s). geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java Lines 199 (patched) <https://reviews.apache.org/r/58393/#comment244922>

Re: flakyTest on Jenkins

Looks great. Thanks! On Thu, Apr 13, 2017 at 9:52 AM, Anthony Baker wrote: > Previously we discussed splitting out the ‘flakyTest’ target into a > separate Jenkins job [1]. You can see the results here [2]. > > Here’s the job configuration: > > - Exec: `docker run --rm -v

Googling Apache Geode docs results in urls Not Found

If I google for something like "apache geode pulse Log-File-Location" then the top few search results are broken. Is this expected or temporary? https://geode.apache.org/docs/guide/configuring/running/running_the_locator.html Not Found The requested URL

[jira] [Resolved] (GEODE-2765) gfsh help should consistently use log4j log levels

[ https://issues.apache.org/jira/browse/GEODE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2765. -- Resolution: Fixed Fix Version/s: 1.2.0 > gfsh help should consistently use log4j log lev

Re: One class loader vs multiple class loaders for deployed jars

There are certainly many projects in the OS community that have solved > this > > same problem. Perhaps we can find a class loader from a project that > would > > suite this need. > > > > Quick search of standalone frameworks comes up with a few popular hits: >

Re: Shareable Filter Permission

There are no settings specific to Filters under Geode administration. I think you have to change this in the settings for Filters and Dashboard Sharing on your own Profile Preferences. You should also be able to hit "Share" while viewing a private Filter and then share it with specific people

[jira] [Commented] (GEODE-2647) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException

[ https://issues.apache.org/jira/browse/GEODE-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963594#comment-15963594 ] Kirk Lund commented on GEODE-2647: -- >From Darrel Schneider <dschnei...@pivotal.io>, Mar 1

Re: Review Request 58325: GEODE-2737: Change Pulse UI tests to use random port for JMX connections

> On April 10, 2017, 10:05 p.m., Kirk Lund wrote: > > geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java > > Lines 47 (patched) > > <https://reviews.apache.org/r/58325/diff/1/?file=1687720#file1687720line48> > > > >

Re: Review Request 58325: GEODE-2737: Change Pulse UI tests to use random port for JMX connections

uppose that LauncherLifecycleCommands#startPulse would already be configuring things but it's rather sparse for configuration. Also, I notice that you're using "jmxPort" for the Pulse port. Shouldn't this be "pulsePort"? The "jmxPort" would theoretically be the RMI server

Re: Review Request 58319: GEODE-2765: change gfsh help to use log4j levels

af6b4bfac982cc5dd69f3d5254c6512264361e2b Diff: https://reviews.apache.org/r/58319/diff/4/ Changes: https://reviews.apache.org/r/58319/diff/3-4/ Testing --- * HelpCommandsIntegrationTest updated and passes * precheckin in progress Thanks, Kirk Lund

Re: Review Request 58319: GEODE-2765: change gfsh help to use log4j levels

/58319/diff/3/ Changes: https://reviews.apache.org/r/58319/diff/2-3/ Testing --- * HelpCommandsIntegrationTest updated and passes * precheckin in progress Thanks, Kirk Lund

Re: Review Request 58319: GEODE-2765: change gfsh help to use log4j levels

gt; > > > One small oddity of this help text is that would seem to imply that > > `start locator --log-level=ALL` is a valid commmand. I think `export logs` > > is a special case in accepting `ALL` as a log level. > > Kirk Lund wrote: > Actually, ALL

Re: Review Request 58319: GEODE-2765: change gfsh help to use log4j levels

t: https://reviews.apache.org/r/58319/#review171465 --- On April 10, 2017, 7:15 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e

Re: One class loader vs multiple class loaders for deployed jars

I think Jared started down this path because we had a custom classloader implementation that he was trying to get rid of -- that impl was pretty limited and forced loading of all classes up-front. Now the code uses fast classpath scanner and that old custom classloader can't be used. The old

Re: Review Request 58319: GEODE-2765: change gfsh help to use log4j levels

/r/58319/diff/1-2/ Testing --- * HelpCommandsIntegrationTest updated and passes * precheckin in progress Thanks, Kirk Lund

[jira] [Updated] (GEODE-2765) gfsh help should consistently use log4j log levels

[ https://issues.apache.org/jira/browse/GEODE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2765: - Summary: gfsh help should consistently use log4j log levels (was: gfsh help should reference log4j2 log

Review Request 58319: GEODE-2267: change gfsh help to use log4j levels

* precheckin in progress Thanks, Kirk Lund

[jira] [Created] (GEODE-2765) gfsh help should reference log4j2 log levels

Kirk Lund created GEODE-2765: Summary: gfsh help should reference log4j2 log levels Key: GEODE-2765 URL: https://issues.apache.org/jira/browse/GEODE-2765 Project: Geode Issue Type: Bug

[jira] [Assigned] (GEODE-2765) gfsh help should reference log4j2 log levels

[ https://issues.apache.org/jira/browse/GEODE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2765: Assignee: Kirk Lund > gfsh help should reference log4j2 log lev

[jira] [Assigned] (GEODE-2762) ArrayUtilsTest generates build warnings in geode-core

[ https://issues.apache.org/jira/browse/GEODE-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2762: Assignee: Kirk Lund > ArrayUtilsTest generates build warnings in geode-c

[jira] [Created] (GEODE-2762) ArrayUtilsTest generates build warnings in geode-core

Kirk Lund created GEODE-2762: Summary: ArrayUtilsTest generates build warnings in geode-core Key: GEODE-2762 URL: https://issues.apache.org/jira/browse/GEODE-2762 Project: Geode Issue Type: Bug

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/#review171229 --- Ship it! Ship It! - Kirk Lund On April 6, 2017, 4:52 p.m

Re: Orphaned Server processes

lt, they > won't. > So, I think we should prevent the server from starting up, but give an > error message to either start a locator or use the --start-locator option. > > On Wed, Apr 5, 2017 at 2:50 PM Kirk Lund <kl...@apache.org> wrote: > > > You can still control

Re: Orphaned Server processes

But you can interact with it... 1) You can issue "stop server --dir=server1" which will stop it 2) You can issue "status server --dir=server1" which will show the status for it 3) You can attach with JConsole and manipulate the MBeans. If the MBeans have operations to create something you can

Re: Orphaned Server processes

You can still control a lone server with GFSH. And if you configure it up front, then you can still have Regions for a Client to use. $ start server --name=server1 --cache-xml-file=mycachefile.xml $ stop server --dir=server1 You could also start a JMX Manager in the server or an embedded

Re: Review Request 58158: GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58158/#review171122 --- On April 3, 2017, 7:57 p.m., Kirk Lund wrote: > > --

<    5   6   7   8   9   10   11   12   13   14   >