Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53784/#review155978 --- Ship it! Ship It! - Kirk Lund On Nov. 15, 2016, 3:06 p.m

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

reply, visit: > https://reviews.apache.org/r/53784/ > --- > > (Updated Nov. 15, 2016, 3:06 p.m.) > > > Review request for geode, Jens Deppe, John Blum, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > -

Re: gfsh start server with the --password option

There should be redaction in gfsh history. Maybe repeating the command is a case that wasn't fully covered? This is a bug we'll need to file and fix. Clear text in process string is probably not a bug. Users should implement a callback to provide the password instead of providing it as a system

DiskSpaceLimitIntegrationTest flakiness

. commit 35f92e074e4b7e24c471e9b37d2f5fe08a0d9cd7 Author: Kirk Lund <kl...@apache.org> Date: Mon Nov 7 15:45:45 2016 -0800 GEODE-2082: rename aboveZeroKeepsAtLeastOneFile to aboveZeroDeletesOldestFile commit 64da18de4fb64f59eab537fb7d01edf8d1117a9b Author: Kirk Lund <kl...@apache.

GMSJoinLeaveJUnitTest format is broken?

* What went wrong: Execution failed for task ':geode-core:spotlessJavaCheck'. > Format violations were found. Run 'gradlew spotlessApply' to fix them. ../../geode/geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java * Try: Run with

Re: Where should geode example code live

e: > > > +1 for both renaming it now and moving it to a separate module going > > forward. > > > > On Thu, Nov 10, 2016 at 10:58 AM, Kirk Lund <kl...@apache.org> wrote: > > > > > We have some example code that's not in geode-exam

Re: Spring Data Geode 1.0.0-INCUBATING-RELEASE available!

Great news and awesome job John! I look forward to buying you a beer to celebrate. -Kirk On Thu, Nov 10, 2016 at 10:15 AM, John Blum wrote: > I am happy to announce the release of *Spring Data* for *Apache Geode* > 1.0.0-incubating, which marks the first, official GA release

Where should geode example code live

We have some example code that's not in geode-examples. geode-core-1.0.0-incubating.jar currently contains this package with examples: org.geode.gemfire.security.templates Given that template means something a bit different from example, I'd like to rename this package to examples. Is this

Re: Review Request 53596: GEODE-1808 Remove broken check for jdk1.7.0_72

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53596/#review155446 --- Ship it! Ship It! - Kirk Lund On Nov. 9, 2016, 5:08 a.m

Review Request 53577: Remove illegal javadoc tag that generates warning

://reviews.apache.org/r/53577/diff/ Testing --- build javadoc Thanks, Kirk Lund

Re: Tweaking the IntelliJ and Eclipse formatters

> > > > // list > > > > // of > > > > // failures > > > > > > On Thu, Oct 27, 2016 at 3:27 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> > > wrote: > > > >> 1) 0

Re: Build failed in Jenkins: Geode-nightly #646

I posted review https://reviews.apache.org/r/53553/ to fix flakiness in DiskSpaceLimitIntegrationTest. -Kirk On Mon, Nov 7, 2016 at 7:57 AM, Jinmei Liao wrote: > I will take care of this. > > On Mon, Nov 7, 2016 at 7:42 AM, Apache Jenkins Server < >

Review Request 53553: GEODE-2082: fix flakiness in sameKeepsOneFile

/internal/statistics/DiskSpaceLimitIntegrationTest.java 2381a538e310467e97ae37003f04f22b149c367e Diff: https://reviews.apache.org/r/53553/diff/ Testing --- DiskSpaceLimitIntegrationTest Thanks, Kirk Lund

Re: Review Request 53402: GEODE-2013: throw IllegalStateException if resource type is missing

2/#review154628 --- On Nov. 2, 2016, 8:07 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53402/ >

Re: Apache policy on files types allowed in source code

;ro...@shaposhnik.org> wrote: > On Wed, Nov 2, 2016 at 1:16 PM, Kirk Lund <kl...@apache.org> wrote: > > I'd like to read up on what's allowed and disallowed regarding file types > > in Apache source code. Does anyone have any links to get me started? > > The only disti

Apache policy on files types allowed in source code

I'd like to read up on what's allowed and disallowed regarding file types in Apache source code. Does anyone have any links to get me started? Thanks, Kirk

Review Request 53402: GEODE-2013: throw IllegalStateException if resource type is missing

/53402/diff/ Testing --- StatArchiveWithMissingResourceTypeRegressionTest precheckin Thanks, Kirk Lund

Re: Review Request 53108: GEODE-2012: always write stat types to archive

e main) org.apache.geode.internal.logging.log4j.LogWriterAppenders (geode-core test) org.apache.geode.internal.logging.TestLogWriterFactory - Kirk Lund On Oct. 31, 2016, 11:54 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 53108: GEODE-2012: always write stat types to archive

/diff/ Testing --- precheckin passed everything! Thanks, Kirk Lund

Re: Review Request 53108: GEODE-2012: always write stat types to archive

eck monitors and notifier. Hopefully this is clearer in the newest changes. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/#review154312 ---

Re: Review Request 53108: GEODE-2012: always write stat types to archive

<https://reviews.apache.org/r/53108/#comment223794> This should be assertTrue geode-core/src/test/java/org/apache/geode/internal/statistics/StatSamplerUtils.java (line 17) <https://reviews.apache.org/r/53108/#comment223796> Delete this class - Kirk Lund On Oct. 31, 2016, 7:

Re: Review Request 53108: GEODE-2012: always write stat types to archive

/geode/internal/statistics/ValueMonitorIntegrationTest.java cef5977bfbc86e956e79e9d50b1a9b99fdab55e6 Diff: https://reviews.apache.org/r/53108/diff/ Testing --- precheckin passed everything! Thanks, Kirk Lund

Re: Review Request 53274: GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest

you're doing or why without studying this code very closely. Everything should be very obvious and simple. GFSH and related code is already obfuscated well enough. - Kirk Lund On Oct. 28, 2016, 9:49 p.m., Jinmei Liao

Re: Review Request 53274: GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest

should keep these as "throws Exception" -- if you're calling something that requires "throws Throwable" then we should change that class/method to "throws Exception" - Kirk Lund On O

broken javadocs

Is there a way to make the build break if we have broken javadocs? I tried to enable this within gradle but gradle then enforces javadocs correctness on all 3rd party libraries as well as our source code. Maybe some sort of 3rd party mechanism (like spotless) might be able to limit itself to just

Revert GEODE-2012

I'm going to revert GEODE-2012 because these tests seem to be intermittently running out of memory. Unfortunately I'm not comfortable leaving the bug fix in without any tests confirming the bug and fix, so the entire commit will be reverted. Thanks, Kirk

Re: Fwd: Build failed in Jenkins: Geode-nightly #636

erestAuthDistributedTest, > PDXGfshPostProcessorOnRemoteServerTest, > IntegratedClientExecuteFunctionAuthDistributedTest, > IntegratedClientDestroyInvalidateAuthDistributedTest] > > > Le 10/28/2016 à 9:15 AM, Kirk Lund a écrit : > > Anyone know why the job output didn't include the test failures li

Fwd: Build failed in Jenkins: Geode-nightly #636

Anyone know why the job output didn't include the test failures like it usually does? -Kirk -- Forwarded message -- From: Apache Jenkins Server Date: Fri, Oct 28, 2016 at 8:54 AM Subject: Build failed in Jenkins: Geode-nightly #636 To:

Tweaking the IntelliJ and Eclipse formatters

I'd like to propose making a few changes to our IntelliJ and Eclipse formatters as well as the Eclipse importorder (all in etc/): 1) increase max line length (100 is way too short) 2) make (hopefully minor) changes to make the two formatters more consistent with each other 3) change Eclipse

Re: CI failures due to JMX client heartbeat thread

polluting others is ConnectToLocatorSSLDUnitTest. I had a failure with > > this suspect string in a test that ran just after it. I added a thread > dump > > in the @After of that test and see that it's leaving one of these threads > > behind along with some Gfsh Laun

Re: CI failures due to JMX client heartbeat thread

uting others is ConnectToLocatorSSLDUnitTest. I had a failure with > this suspect string in a test that ran just after it. I added a thread dump > in the @After of that test and see that it's leaving one of these threads > behind along with some Gfsh Launcher threads. > > > Le 10/27/20

Rebasing pre-spotless feature branches on develop

After bungling this once, I took some detailed notes that I've been following. Here's the steps I'm following to rebase my feature branches on develop after adding spotless and reformatting code. Make sure you're on your branch and you have fetched from origin. 1) rebase to the revision that's

Re: CI failures due to JMX client heartbeat thread

Bruce, can you please point me at the JDK code you think is generating the fatal message? I looked in RMIConnector.java and can't find it in there. Maybe we can fix ordering of tearDown or something else in order to "fix" this message. Thanks, Kirk On Wed, Oct 26, 2016 at 5:00 PM, Dan Smith

Re: IntelliJ error: Plugin with id 'com.diffplug.gradle.spotless' not found

Nevermind. I figured it out. -Kirk On Wed, Oct 26, 2016 at 3:38 PM, Kirk Lund <kl...@pivotal.io> wrote: > I refreshed on the Gradle tab in IntelliJ, but it's failing with: > > Gradle 'closed' project refresh failed > Error: Plugin with id 'com.diffplug.gradle.s

IntelliJ error: Plugin with id 'com.diffplug.gradle.spotless' not found

I refreshed on the Gradle tab in IntelliJ, but it's failing with: Gradle 'closed' project refresh failed Error: Plugin with id 'com.diffplug.gradle.spotless' not found. Anyone know how to fix IntelliJ after you update geode checkout? Thanks, Kirk

Re: Review Request 53108: GEODE-2012: always write stat types to archive

! Thanks, Kirk Lund

Re: Review Request 53168: GEODE-2030: security support for SDG

/IntegratedSecurityServiceTest.java (line 21) <https://reviews.apache.org/r/53168/#comment223441> This should be: import static org.assertj.core.api.Assertions.assertThatThrownBy; Don't use Java6Assertions. - Kirk Lund On Oct. 26, 2016, 9:12 p.m., Jinmei Liao

Re: Review Request 53198: GEODE-17: Fix a logical bug that prevents customers to set both Peer and Client authenticator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53198/#review153943 --- Ship it! Ship It! - Kirk Lund On Oct. 26, 2016, 5:42 p.m

Re: Review Request 53150: GEODE-2024 Deadlock creating a new distributed lock service Grantor while transactions are in progress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53150/#review153940 --- Ship it! Ship It! - Kirk Lund On Oct. 25, 2016, 4:13 p.m

Re: [DISCUSS] Graduation

+1 On Wed, Oct 26, 2016 at 8:59 AM, Bruce Schuchardt wrote: > +1 > > > Le 10/25/2016 à 5:25 PM, Roman Shaposhnik a écrit : > >> Hi! >> >> with the 1.0.0-incubating release officially out (huge kudos >> to the team!) I think it is time we officially start our graduation

Review Request 53108: GEODE-2012: always write stat types to archive

/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/53108/diff/ Testing --- precheckin Thanks, Kirk Lund

Re: Coding practices/standards

ct 21, 2016, at 8:27 AM, Bruce Schuchardt < > >> bschucha...@pivotal.io> > >>>>>> wrote: > >>>>>>> > >>>>>>> +1 > >>>>>>> > >>>>>>> Le 10/20/2016 à

Re: Coding practices/standards

te: > > >>>>> > > >>>>> +1 > > >>>>> > > >>>>> Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit : > > >>>>>> +1 > > >>>>>> > > >>>>>> > > >>

Re: Coding practices/standards

the Google Java Style formatter templates. > > > > On Oct 18, 2016, at 4:32 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > > For reference TRAC #38741 was a bug with the summary "EOFException during > > deserialize on client update with copy-on-read=true&quo

Re: Updating Swagger

+1 Looks good to me! On Thu, Oct 20, 2016 at 12:22 PM, Kevin Duling wrote: > I've updated the page to appear as follows. Any feedback is welcome. > > https://drive.google.com/file/d/0B-lWOyam73gWb0hWT1Jtd1loeFE/ > view?usp=sharing > > On Thu, Oct 20, 2016 at 11:40 AM,

Re: IntelliJ and Eclipse formatters

ons of intellij. Multiple PRs have > been made to update to fix this, but Google has not yet accepted one. I'd > like to compare the options submitted and choose one of those. > > On Oct 19, 2016 3:55 PM, "Kirk Lund" <kl...@apache.org> wrote: > > > Should we be us

Re: Nightly geode build?

, becomes unstable or returns to stable. > > There is another email plugin which has more options, including sending > every job. I can set it up if that is what people want. > > --Mark > > On Wed, Oct 19, 2016 at 3:48 PM, Kirk Lund <kl...@apache.org> wrote: > > > Las

IntelliJ and Eclipse formatters

Should we be using these formatters instead of the formatters under /etc in Geode? Google Java Style Eclipse Formatter... https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml Google Java Style IntelliJ Formatter...

Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52994/#review153314 --- Ship it! Ship It! - Kirk Lund On Oct. 19, 2016, 12:11 a.m

Re: Removal of nonSingleHopCount stat from client

+1 FYI: I know of one customer that uses the old "gemfire stats" command, polling repeatedly for certain stat values written to a gfs file from a native client as a crude form of monitoring, so some folks do make use of client stats (we should give them a better way to monitor clients tho) On

Re: Coding practices/standards

For reference TRAC #38741 was a bug with the summary "EOFException during deserialize on client update with copy-on-read=true" -Kirk On Tue, Oct 18, 2016 at 4:27 PM, Jared Stewart wrote: > To give everyone an update, using the Google Java Style eclipse template > there is

Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified

in interactive mode or script mode. Then if it's in script mode, it should fail instead of prompting. John Blum might be a good person to ask if they know how to check interactive vs script mode. He would be a good reviewer for this changeset in general. - Kirk Lund On Oct. 18, 2016, 11:09

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

+1 On Mon, Oct 17, 2016 at 12:49 PM, Roman Shaposhnik wrote: > On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker wrote: > > Since the geode docs have now been merged to the develop branch, let’s > start > > hosting them on http://geode.apache.org.

Review Request 52956: GEODE-2011: add FlakyTest category to testNonPersistentServerRestartAutoSerializer

Diff: https://reviews.apache.org/r/52956/diff/ Testing --- build PdxClientServerDUnitTest Thanks, Kirk Lund

Review Request 52937: GEODE-2007: fix unchecked warnings

Testing --- build modified tests precheckin in progress Thanks, Kirk Lund

Review Request 52949: GEODE-2009: apply FlakyTest category to testCreateAlterDestroyUpdatesSharedConfig

/CreateAlterDestroyRegionCommandsDUnitTest.java 5fa06d9 Diff: https://reviews.apache.org/r/52949/diff/ Testing --- build, CreateAlterDestroyRegionCommandsDUnitTest Thanks, Kirk Lund

Re: Review Request 52931: GEODE-1993: allow LocatorServerStartupRule to save server's ports as well.

ICATOR, DummyAuthenticator.class.getName()).startLocatorVM(0).build(); JUnit started changing the base Rules to use fluent builder similar to the above. We have some Rules like this as well. - Kirk Lund On Oct. 17, 2016, 3:10 p.m., Jinmei Liao

Review Request 52936: GEODE-2006: add FlakyTest category to testSelectCommand

://reviews.apache.org/r/52936/diff/ Testing --- build, GemfireDataCommandsDUnitTest Thanks, Kirk Lund

Review Request 52935: GEODE-2005: fix javadoc warning

/CommonCrudController.java 2bcb31b Diff: https://reviews.apache.org/r/52935/diff/ Testing --- javadoc Thanks, Kirk Lund

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

+1 I think we should target GEODE-2004 and GEODE-1883 for a point release after 1.0.0 On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao wrote: > +0 > > This candidate does not include the fix for GEODE-2004 and GEODE-1883. It's > not a must fix though. > > On Sun, Oct 16, 2016 at

Re: Coding practices/standards

+1 to a) embracing https://google.github.io/styleguide/javaguide.html 100%, b) adopting the google formatters for IntelliJ and Eclipse, c)using spotless On Fri, Oct 14, 2016 at 6:56 AM, Jacob Barrett wrote: > +1 > > On Thu, Oct 13, 2016 at 10:04 AM Kevin Duling

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

still uses dunit VMs. - Kirk Lund On Oct. 14, 2016, 4:19 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: GEODE-1466: geode.properties

unds. Either fix > > it the way it should be fixed or do nothing at all. > > > > On Thu, Oct 13, 2016 at 2:45 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > > > -1 at this point I'm against making this change for 1.0.0 > > > > > > I'll still

Re: Starting the server, prompt for username/password

I think we should avoid using an exception for normal flow control. I'd provide a link to Ward Cunningham's wiki but his wiki is currently down. There should be a way to determine if the user has credentials before trying to connect. -Kirk On Thu, Oct 13, 2016 at 2:50 PM, Kevin Duling

Re: GEODE-1466: geode.properties

be pushing destabilizing changes into a release >>> branch. If the changes aren’t ready now we always pick them up for the >>> next release. >>> >>> Anthony >>> >>> On Oct 13, 2016, at 1:13 PM, Kirk Lund <kl...@apache.org> wrote: >>

GEODE-1466: geode.properties

I'm currently working with Jared and we have spent a few days working on GEODE-1466. We've been trying to get geode to the point where it can automatically search for, find and use either geode.properties or gemfire.properties (preferring geode.properties if both are found). We were intending to

Re: Review Request 52751: GEODE-1986: correctly set the flag indicating if cluster configuration service is running or not on a locator.

-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java (line 734) <https://reviews.apache.org/r/52751/#comment221327> The style guide is to use curlies even for a single line block: if (locatorString.length()==0) { return; } - Kir

Re: Review Request 52700: Add more tests to flaky category based on recent CI failures

le.xml - Kirk Lund On Oct. 10, 2016, 6:54 p.m., Anthony Baker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52700/ >

Re: Review Request 52655: GEODE-1973: add more tests to cover GMSAuthenticator and SimpleSecurityManager

?) and then Ship It! - Kirk Lund On Oct. 10, 2016, 3:14 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52650: GEODE-1973: having GMSAuthenticator work on a locator with no cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52650/#review151888 --- Ship it! Ship It! - Kirk Lund On Oct. 7, 2016, 10:09 p.m

Re: Review Request 52650: GEM-1032: having GMSAuthenticator work on a locator with no cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52650/#review151887 --- Ship it! Ship It! - Kirk Lund On Oct. 7, 2016, 10:02 p.m

Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get security properties from system properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52621/#review151737 --- Ship it! Ship It! - Kirk Lund On Oct. 6, 2016, 11:03 p.m

Re: Limiting scope for Geode 1.0

k...@pivotal.io> > > wrote: > > > >> +1 > >> > >> On Fri, Sep 30, 2016 at 9:16 AM, Kenneth Howe <kh...@pivotal.io> wrote: > >> > >>> +1 > >>> > >>>> On Sep 29, 2016, at 2:31 PM, Jacob Barrett <jbarr...@pivotal

Re: Log related test failures in GEODE

that's not true. Sorry about that! Thanks, Kirk On Tue, Oct 4, 2016 at 6:26 PM, Kirk Lund <kl...@apache.org> wrote: > There were some logging changes that went in today. Not sure why the regex > is failing to match now but we'll revert the changes tomorrow. > > -Kirk > &g

Re: Log related test failures in GEODE

There were some logging changes that went in today. Not sure why the regex is failing to match now but we'll revert the changes tomorrow. -Kirk On Tuesday, October 4, 2016, Nabarun Nag wrote: >- The following tests are failing on precheck as well as in IntelliJ >Tests

Re: Review Request 52525: GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE

an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52525/#review151390 --- On Oct. 4, 2016, 8:23 p.m., Kirk Lund wrote: > > --- > T

Review Request 52525: GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE

/resources/org/apache/geode/internal/logging/log4j/marker/log4j2-geode_verbose-deny.xml PRE-CREATION Diff: https://reviews.apache.org/r/52525/diff/ Testing --- GeodeVerboseLogMarkerIntegrationTest Thanks, Kirk Lund

Re: CI bugs

Memory configurations were changed to stabilize the test. No > wait.pauses were used. > > Regards > Nabarun > > > On Tue, Oct 4, 2016 at 11:04 AM Swapnil Bawaskar <sbawas...@pivotal.io> > wrote: > > +1 > > On Tue, Oct 4, 2016 at 10:58 AM, John Blum <jb...@piv

Re: buildSrc prevents geode-core:test

stJava UP-TO-DATE :geode-core:processTestResources UP-TO-DATE :geode-core:testClasses UP-TO-DATE > Building 90% > :geode-core:integrationTest > 0 tests completed On Mon, Oct 3, 2016 at 10:23 AM, Kirk Lund <kl...@apache.org> wrote: > The --tests syntax works well for me. Than

Re: CI bugs

Please don't close flaky tickets or remove FlakyTest category unless you know of a specific commit revision that makes some timing changes to the test. Unless you replace all the Thread.sleeps with await() calls it's going to fail again when GC occurs during the test. Just because a test doesn't

Re: buildSrc prevents geode-core:test

t; > Best, > Jared > > > > On Sep 30, 2016, at 4:03 PM, Kirk Lund <kl...@apache.org> wrote: > > > > Does anyone know why "buildSrc:test" executes when I try to execute > > "geode-core:test"? See my output below. Instead of executing >

Re: Review Request 52468: Add FlakyTest category to tests with open bugs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52468/#review151125 --- Ship it! Ship It! - Kirk Lund On Oct. 2, 2016, 12:07 a.m

buildSrc prevents geode-core:test

Does anyone know why "buildSrc:test" executes when I try to execute "geode-core:test"? See my output below. Instead of executing "geode-core:test", gradle executes "buildSrc:test" and fails with "Could not find matching test for pattern" -- I think there's something broken in our gradle files.

Re: [ANNOUNCE] Donation of Geode documentation

Great news! On Thursday, September 29, 2016, Anthony Baker wrote: > I am pleased to announce the donation of Geode documentation to the > Geode community. > > The documentation provides a complete user guide for Geode. This > donation includes the source necessary to build

Re: Limiting scope for Geode 1.0

% > 20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY% > 20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > [2] http://mail-archives.apache.org/mod_mbox/incubator-geode- > dev/201609.mbox/%3cCANZq1gBzMTEM_JHzw2YT_LZeC5g472XkNCfJhma76xah=Yyq6A@ > mail.gmail.com%3e &

Re: Previous versions dtds

I'm actually unfamiliar with statisticsType.dtd: geode-core/src/main/resources/org/apache/geode/statisticsType.dtd I notice it still references GemStone and gemstone.com. Do we have copies of the dtds on geode.apache.org? Where should these dtds live online? Thanks, Kirk On Thu, Sep 29, 2016

Limiting scope for Geode 1.0

What changes are we still waiting on to cut the next RC of Geode 1.0? Is there a way to create a branch for Geode 1.0 develop that allows folks to continue working on post-1.0 features or bug fixes without destabilizing Geode 1.0? This way, only the necessary changes for Geode 1.0 would go to the

JUnit best practices #2

We are using Categories to aid in separating UnitTests, IntegrationTests, etc. A UnitTest is: /** * JUnit Test Category that specifies a test with very narrow and well defined * scope. Any complex dependencies and interactions are stubbed or mocked. * * A {@code UnitTest} should not do any

JUnit best practices #1

Some of the very basic best practices for JUnit: 1) never catch an unexpected exception Yes: public void myTest() throws Exception { doSomething(); validation(); } No: public void myTest() { try { doSomething(); validation(); } catch (Exception e) { fail(e.getMessage()); }

Re: Review Request 52269: GEODE-1659: put security properties in the cluster config and applied to all the members in the cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52269/#review150444 --- Ship it! Ship It! - Kirk Lund On Sept. 26, 2016, 8:32 p.m

Re: jvsd

on the wiki, so the community can > still easily access it. > > On Thu, Sep 22, 2016 at 4:51 PM Kirk Lund <kl...@apache.org <javascript:;>> > wrote: > > > JVSD isn't labeled as Experimental because it isn't even on develop or in > > part of any Geo

Re: jvsd

xtnavpagetreemode > > > > > > > > > On Thu, Sep 22, 2016 at 3:19 PM, Anthony Baker <aba...@pivotal.io > <javascript:;>> > > wrote: > > > > > > > I think that providing documentation for jvsd before it is included > in

Re: jvsd

I would recommend not mentioning jVSD at all in the Geode 1.0 docs. Right now it's just a Jira ticket and feature branch. I think the docs should only cover what's in Geode 1.0. If there's some doc or wiki page about proposed future features or features currently looking for

Re: Review Request 52067: GEODE-1909: add authorization in GMSAuthenticator

m port with AvailablePortHelper? If it does, then that would actually be better. You would then return the locator's final port back through the invoke into an int variable: this.locatorPort = locator.invoke(() -> { ... return port; }); - Kirk Lund On Sept. 20, 2016,

Error loading cluster config serialized prior to repackage

If current develop attempts to read a cluster config that was persisted prior to the repackage, our code now throws ClassNotFoundException. Turns out Cluster Config is implemented by the class org.apache.geode.management.internal.configuration.domain.Configuration which is a DataSerializable.

Re: Review Request 51974: GEODE-1908 DistributedSystem.connect call not configuring p2p server with SSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51974/#review149281 --- Ship it! Ship It! - Kirk Lund On Sept. 16, 2016, 9:26 p.m

Nightly build successful but couldn't publish

Is this another build machine we need to exclude? BUILD SUCCESSFUL Total time: 11 hrs 20 mins 0.714 secs Build step 'Invoke Gradle script' changed build result to SUCCESS Archiving artifacts Compressed 378.76 MB of artifacts by 42.0% relative to #593 Recording test results ERROR: Step ?Publish

Re: Review Request 51849: GEODE-17: consolidate GeodeSecurityUtil and IntegratedSecurityService

- > > (Updated Sept. 13, 2016, 4:45 p.m.) > > > Review request for geode, Kevin Duling and Kirk Lund. > > > Repository: geode > > > Description > --- > > GEODE-17: consolidate GeodeSecurityUtil and IntegratedSecurityService > > > Dif

Re: Review Request 51925: GEODE-1648: revert commits related to security-enabled-components.

hat ok? - Kirk Lund On Sept. 15, 2016, 6:19 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51925/ >

New Eclipse and IntelliJ formatters committed to develop

After you pull in the following commit on develop, please edit your preferences in either Eclipse or IntelliJ to reload etc/eclipseOrganizeImports.importorder in Eclipse or etc/intellijIdeaCodeStyle.xml in IntelliJ. commit 17a4348f786cea900fea6577485374e88dc45b2e Author: Kirk Lund <

  1   2   3   4   5   6   >