Re: Kubernetes vs. Docker Engine protocol

2018-11-17 Thread Mike Jumper
On Sat, Nov 17, 2018 at 2:59 PM Roman Shaposhnik wrote: > Hi! > > I was very pleasantly surprised to discover that Kubernetes > container TTY support is now part of Guacamole. The JIRA, > however, talks about both Docker Engine and Kubernetes. > Looking at the source code I'm not sure I see the

Re: 1.0.0 Release?

2018-11-16 Thread Mike Jumper
Jun 2, 2018 at 15:27 Mike Jumper > wrote: > > > On Sat, Jun 2, 2018 at 12:17 PM, Mike Jumper > > wrote: > > > On Sat, Jun 2, 2018 at 8:07 AM, Nick Couchman > wrote: > > >>> > > >>> No objections, so we'll call this good. We have 75 iss

Re: guacd immediately disconnects when built and run on Alpine 3.7 (musl libc)

2018-11-16 Thread Mike Jumper
On Wed, Nov 14, 2018 at 10:52 PM Roman Shaposhnik wrote: > Hi! > > first of all -- just wanted to say that Guacamole is one > impressive project -- very well done. Thanks! ... > guacd[9]: INFO: User "@6c100210-b28a-46ae-9db7-00b30782b5c2" joined > connection

[GitHub] guacamole-manual pull request #103: GUACAMOLE-220: Document administration o...

2018-11-13 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/103 GUACAMOLE-220: Document administration of user groups. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper/guacamole

[GitHub] guacamole-server pull request #202: GUACAMOLE-638: avcodec_register_all() sh...

2018-11-12 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/202 GUACAMOLE-638: avcodec_register_all() should be used only if not deprecated. `avcodec_register_all()` is deprecated as of libavcodec 58.10.100. From the relevant section

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232741653 --- Diff: src/protocols/ssh/ssh.c --- @@ -256,6 +256,17 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232740653 --- Diff: src/protocols/ssh/ssh.c --- @@ -256,6 +256,17 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232526633 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1264,6 +1281,14 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232525849 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1264,6 +1281,14 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232506936 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232502934 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232502752 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232503178 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502604 --- Diff: src/protocols/ssh/settings.c --- @@ -246,6 +247,15 @@ enum SSH_ARGS_IDX { * variable to be set

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502635 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -356,6 +357,11 @@ enum RDP_ARGS_IDX { */ IDX_PRECONNECTION_BLOB

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502486 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502539 --- Diff: src/protocols/ssh/settings.h --- @@ -253,6 +253,10 @@ typedef struct guac_ssh_settings { * environment variable

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502496 --- Diff: src/protocols/ssh/ssh.c --- @@ -256,6 +256,10 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-server pull request #198: GUACAMOLE-630: Allow color scheme of act...

2018-11-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/198#discussion_r232441000 --- Diff: src/protocols/ssh/argv.c --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #198: GUACAMOLE-630: Allow color scheme of act...

2018-11-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/198#discussion_r232440908 --- Diff: src/protocols/ssh/argv.c --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: Build failed in Jenkins: guacamole-client-docker #15

2018-11-08 Thread Mike Jumper
This failure is due to an update to the "maven:3-jdk-8" build image which includes an updated OpenJDK 8 that includes a bug which is triggered by a bug in the Maven surefire plugin ( https://issues.apache.org/jira/browse/SUREFIRE-1588). Though unrelated to any specific change in the upcoming 1.0.0

[GitHub] guacamole-client pull request #339: GUACAMOLE-656: Explicitly depend on mave...

2018-11-08 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/339 GUACAMOLE-656: Explicitly depend on maven-surefire-plugin 3.0.0-M1 due to SUREFIRE-1588. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] guacamole-client pull request #337: GUACAMOLE-220: Add user group support to...

2018-11-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/337#discussion_r232140182 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleObjectPermissionSet.java --- @@ -37,14 +38,77

[GitHub] guacamole-client pull request #337: GUACAMOLE-220: Add user group support to...

2018-11-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/337#discussion_r232137320 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AbstractUser.java --- @@ -44,4 +51,164 @@ public void setPassword(String

[GitHub] guacamole-client pull request #337: GUACAMOLE-220: Add user group support to...

2018-11-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/337#discussion_r232135489 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java --- @@ -0,0 +1,326

[GitHub] guacamole-server pull request #199: GUACAMOLE-649: Add support for setting L...

2018-11-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/199#discussion_r232133763 --- Diff: src/protocols/ssh/ssh.c --- @@ -320,6 +320,17 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-manual pull request #102: GUACAMOLE-220: Document LDAP support for...

2018-11-04 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/102 GUACAMOLE-220: Document LDAP support for user groups. These changes: * Add documentation covering configuration of Guacamole's LDAP support such that LDAP groups

[GitHub] guacamole-server pull request #199: GUACAMOLE-649: Add support for setting L...

2018-11-04 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/199 GUACAMOLE-649: Add support for setting LANG environment variable via SSH. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike

[GitHub] guacamole-server pull request #198: GUACAMOLE-630: Allow color scheme of act...

2018-11-04 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/198 GUACAMOLE-630: Allow color scheme of active SSH/telnet session to be changed. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] guacamole-client pull request #338: GUACAMOLE-220: Correct translation strin...

2018-11-03 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/338 GUACAMOLE-220: Correct translation strings for user group "disabled" attribute. The "disabled" group attribute provided by the JDBC auth controls whether th

[GitHub] guacamole-client pull request #337: GUACAMOLE-220: Add user group support to...

2018-11-03 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/337 GUACAMOLE-220: Add user group support to LDAP. These changes add support for querying user groups from an LDAP directory, exposing those groups using Guacamole's new user group API

[GitHub] guacamole-manual pull request #101: GUACAMOLE-622: Document login success/fa...

2018-10-31 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/101 GUACAMOLE-622: Document login success/failure regex for telnet. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper

[GitHub] guacamole-manual pull request #100: GUACAMOLE-611: Document "skip-if-unavail...

2018-10-31 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/100 GUACAMOLE-611: Document "skip-if-unavailable" property. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229823288 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229821057 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229824188 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229822193 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229823156 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229825489 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-client pull request #336: GUACAMOLE-641: Add support for populatin...

2018-10-28 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/336 GUACAMOLE-641: Add support for populating arbitrary parameter tokens from key vaults. These changes add a new family of extensions, similar to "guacamole-auth-jdbc", whi

[GitHub] guacamole-manual pull request #99: GUACAMOLE-220: Update database documentat...

2018-10-28 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/99 GUACAMOLE-220: Update database documentation for user groups. These changes: * Reorganize the database auth documentation to include SQL Server among the databases affected

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228670354 --- Diff: src/terminal/terminal_handlers.c --- @@ -1422,7 +1431,7 @@ int guac_terminal_ctrl_func(guac_terminal* term, unsigned char c

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228667920 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228667853 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228672433 --- Diff: src/terminal/terminal_handlers.c --- @@ -469,7 +470,7 @@ static int guac_terminal_parse_xterm256_rgb(int argc, const int* argv

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228668050 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228669193 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228668762 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228669520 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: User mapping from another source (user-mapping.xml)

2018-10-19 Thread Mike Jumper
On Fri, Oct 19, 2018, 06:43 Michael Watne wrote: > Hello, > so I need help with something. Currently, I have Apache Guacamole 0.9.14. > As you are aware, users are allowed access through the user-mapping.xml > file. I am developing a server-side application through bash (ssh) which > also has

Re: guacamole.properties does not get updatd

2018-10-18 Thread Mike Jumper
ich ones will be replacing > the exact two variables I had listed. > On Thursday, October 18, 2018, 2:54:15 AM EDT, Mike Jumper < > mjum...@apache.org> wrote: > > The environment variables available for the Docker image are documented in > the manual: > > http://guaca

Re: guacamole.properties does not get updatd

2018-10-18 Thread Mike Jumper
gt; What would be the equivalent if I were to adapt to the new > variables?mysql-default-max-connections: 1 > mysql-default-max-group-connections: 1 > > Thank you > > On Monday, October 15, 2018, 9:20:48 AM EDT, Mike Jumper < > mjum...@apache.org> wrote: > > On M

[GitHub] guacamole-client pull request #335: GUACAMOLE-524: Correct handling of param...

2018-10-16 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/335 GUACAMOLE-524: Correct handling of parameter tokens within SimpleConnection The changes introduced by #333 do not correctly apply parameter tokens within `SimplyConnection

[GitHub] guacamole-manual pull request #98: GUACAMOLE-570: Bump version numbers withi...

2018-10-15 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/98 GUACAMOLE-570: Bump version numbers within documentation to 1.0.0. These changes update the documentation to point to the 1.0.0 versions of everything, as well as update the example

[GitHub] guacamole-manual pull request #97: GUACAMOLE-38: Correct XML validation erro...

2018-10-15 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/97 GUACAMOLE-38: Correct XML validation errors in guacamole-auth-quickconnect documentation. There are two XML validation errors within the recently-merged adhoc connection docs

Re: Birds-of-a-Feather session at LISA18 (USENIX conference)

2018-10-15 Thread Mike Jumper
On Tue, Sep 25, 2018 at 11:45 AM, Nick Couchman wrote: > On Tue, Sep 25, 2018 at 2:37 PM Mike Jumper wrote: > > > Hello all, > > > > As I'll be attending LISA18 for day job matters, I'm looking into maybe > > also scheduling a community BoF session

Re: guacamole.properties does not get updatd

2018-10-15 Thread Mike Jumper
On Mon, Oct 15, 2018 at 5:49 AM, Tezarin wrote: > > Good morning, > > > I understand the method I was using to fix the issue is deprecated, I > started all this by trying to avoid the error message in the guac user > interface about having too many connections open. In some cases, I was not >

Re: Guacamole X11

2018-10-14 Thread Mike Jumper
On Thu, Oct 11, 2018 at 11:52 AM, Mike Jumper wrote: > On Thu, Oct 11, 2018, 11:23 Vasily wrote: > >> I've first tried with openjdk-9-jdk, then "apt remove"d it after first >> seeing this error and installed 8-jdk instead. >> >> What is the required ve

Re: Guacamole X11

2018-10-11 Thread Mike Jumper
On Thu, Oct 11, 2018 at 9:18 AM, Vasily wrote: > And here's the first issue I faced building the client (disclaimer: I'm no > Java programmer, so I'm not familiar with all this stuff unfortunately). > > I've installed maven and openjdk-8-jdk packages, then ran "mvn package" as > instructions

Re: Guacamole X11

2018-10-11 Thread Mike Jumper
On Thu, Oct 11, 2018 at 9:04 AM, Vasily wrote: > ... > P.S. Mike, I've noticed that you have probably missed one merge conflict > during rebase, here's quick-and-dirty diff I had to make: > $ git diff > diff --git a/Makefile.am b/Makefile.am > index 298e1a5e..a91293cf 100644 > --- a/Makefile.am

[GitHub] guacamole-manual pull request #96: GUACAMOLE-96: Document support for multi-...

2018-10-11 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/96 GUACAMOLE-96: Document support for multi-factor authentication using TOTP. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike

[GitHub] guacamole-client pull request #334: GUACAMOLE-96: Do not require TOTP for us...

2018-10-11 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/334 GUACAMOLE-96: Do not require TOTP for users that cannot enroll. If a user lacks `UPDATE` permission on their own account, it will be impossible for that user to enroll. In this case

[GitHub] guacamole-manual pull request #95: GUACAMOLE-524: Document new format of cus...

2018-10-06 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-manual/pull/95 GUACAMOLE-524: Document new format of custom LDAP parameter tokens. This change updates the LDAP attribute parameter token documentation to note the new `LDAP_` prefix and removes

[GitHub] guacamole-client pull request #333: GUACAMOLE-524: Use decoration API to inj...

2018-10-05 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/333 GUACAMOLE-524: Use decoration API to inject tokens from LDAP attributes. This is probably worth some discussion, but I think it's a cleaner and more future-proof approach to what

[GitHub] guacamole-client pull request #332: GUACAMOLE-220: Ignore missing user or gr...

2018-10-05 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/332 GUACAMOLE-220: Ignore missing user or group when retrieving permissions/memberships. This change addresses a regression in user management due to changes made for user group support

[GitHub] guacamole-client pull request #330: GUACAMOLE-232: Mark key as implicitly pr...

2018-10-03 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/330 GUACAMOLE-232: Mark key as implicitly pressed only when pressed due to another, identifiable key event. On iOS, distinct key events are sent for modifier keys, but these key events

[GitHub] guacamole-client pull request #328: GUACAMOLE-232: Address regressions in ha...

2018-10-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/328#discussion_r222398664 --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js --- @@ -953,37 +1006,58 @@ Guacamole.Keyboard = function Keyboard(element

Re: Build failed in Jenkins: guacamole-server-freerdp » 1.0.1,ubuntu #16

2018-10-03 Thread Mike Jumper
Please see the response to your earlier email: http://mail-archives.apache.org/mod_mbox/guacamole-dev/201810.mbox/%3CCALKeL-NJpBz22KZJe9E7W46h2qaPa%2BtXwGkU6gUzwe_yxzFDzQ%40mail.gmail.com%3E - Mike On Wed, Oct 3, 2018 at 7:29 AM, Ignacio Valdes wrote: > Hi, how do I get removed from this

[GitHub] guacamole-website pull request #62: Include Guacamole.InputSink and listenTo...

2018-10-03 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-website/pull/62 Include Guacamole.InputSink and listenTo() in keyboard test if available. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike

Re: [GitHub] guacamole-server pull request #195: GUACAMOLE-353: Clarify applicability of ...

2018-10-02 Thread Mike Jumper
On Tue, Oct 2, 2018 at 9:04 PM, Ignacio Valdes wrote: > How do I get off this list? It isn't clear how to unsubscribe. Similar to the subscription process, you send an email to dev-unsubscr...@guacamole.apache.org and respond to the confirmation email. Alternatively, if you just don't like

[GitHub] guacamole-server pull request #195: GUACAMOLE-353: Clarify applicability of ...

2018-10-02 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/195 GUACAMOLE-353: Clarify applicability of ASF header when transcluded into generated build files. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] guacamole-client pull request #327: GUACAMOLE-524: Correct AuthenticatedUser...

2018-10-02 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/327 GUACAMOLE-524: Correct AuthenticatedUser implementations of Attributes interface. These changes correct the JDBC and LDAP implementations of `AuthenticatedUser

Re: Build failed in Jenkins: guacamole-client-master » JDK 1.8 (latest) #85

2018-10-01 Thread Mike Jumper
Should be addressed by: https://github.com/apache/guacamole-client/pull/326 On Mon, Oct 1, 2018 at 11:37 AM, Mike Jumper wrote: > A new permission check introduced via GUACAMOLE-360 was (naturally) > written for the version of ActiveConnectionPermissionService that did > not support us

[GitHub] guacamole-client pull request #326: GUACAMOLE-360: Update active connection ...

2018-10-01 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/326 GUACAMOLE-360: Update active connection permission check to support user groups. See build failure: https://lists.apache.org/thread.html

Re: Build failed in Jenkins: guacamole-client-master » JDK 1.8 (latest) #85

2018-10-01 Thread Mike Jumper
Building the staging/1.0.0 branch seems to work fine. Am checking why master is borked. - Mike On Mon, Oct 1, 2018 at 11:09 AM, Apache Jenkins Server wrote: > See > > > Changes: >

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-10-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221501120 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission

[GitHub] guacamole-client pull request #325: GUACAMOLE-437: Remove erroneously-commit...

2018-09-29 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/325 GUACAMOLE-437: Remove erroneously-committed, non-breaking spaces (U+00A0) from source. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221440798 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml --- @@ -109,33 +109,33

[GitHub] guacamole-client pull request #324: GUACAMOLE-635: Require Java 1.8 for all ...

2018-09-29 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/324 GUACAMOLE-635: Require Java 1.8 for all Java components except guacamole-common. As discussed on #319 and on [the dev@ mailing list](https://lists.apache.org/thread.html

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221139180 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml --- @@ -109,33 +109,33

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221131852 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/schema/upgrade/upgrade-pre-1.0.0.sql --- @@ -17,6 +17,319

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221131025 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221130813 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221129356 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission

[GitHub] guacamole-server pull request #193: GUACAMOLE-623: Start terminal once Kuber...

2018-09-27 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/193 GUACAMOLE-623: Start terminal once Kubernetes connection is ready. The recent merge of [GUACAMOLE-622](https://issues.apache.org/jira/browse/GUACAMOLE-622) via #187 requires

[GitHub] guacamole-server pull request #191: GUACAMOLE-623: Include Kubernetes plugin...

2018-09-26 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/191 GUACAMOLE-623: Include Kubernetes plugin in dist directories. The `src/protocols/kubernetes` directory needs to be present in `DIST_SUBDIRS` for the source of the Kubernetes plugin

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r220426560 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml --- @@ -109,33 +109,33

[GitHub] guacamole-server pull request #186: GUACAMOLE-623: Add support for attaching...

2018-09-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/186#discussion_r220423721 --- Diff: src/protocols/kubernetes/settings.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #186: GUACAMOLE-623: Add support for attaching...

2018-09-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/186#discussion_r220423526 --- Diff: src/protocols/kubernetes/settings.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #190: GUACAMOLE-632: Dynamically scale JPEG/We...

2018-09-25 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/190 GUACAMOLE-632: Dynamically scale JPEG/WebP quality depending on measured processing lag. These changes dynamically scale JPEG/WebP quality based on real-time measurements

[GitHub] guacamole-client pull request #323: GUACAMOLE-629: Add support for creating ...

2018-09-25 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/323 GUACAMOLE-629: Add support for creating argument value streams using the "argv" instruction. These changes are the guacamole-common-js API changes which complement those

[GitHub] guacamole-server pull request #189: GUACAMOLE-629: Add support for updating ...

2018-09-25 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/189 GUACAMOLE-629: Add support for updating connection parameters of in-progress connections. This is the non-handshake portion of changes which allow connection parameters to be sent

Birds-of-a-Feather session at LISA18 (USENIX conference)

2018-09-25 Thread Mike Jumper
Hello all, As I'll be attending LISA18 for day job matters, I'm looking into maybe also scheduling a community BoF session (*not* for day job) to promote and discuss Apache Guacamole with any interested people while I'm there: https://www.usenix.org/conference/lisa18/bofs Not that while the

[GitHub] guacamole-client pull request #322: GUACAMOLE-622: Add parameter definitions...

2018-09-21 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/322 GUACAMOLE-622: Add parameter definitions for telnet login success/failure regex. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] guacamole-server pull request #188: GUACAMOLE-628: Correct RDP scancode mapp...

2018-09-21 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/188 GUACAMOLE-628: Correct RDP scancode mapping for right control key. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper

[GitHub] guacamole-server pull request #187: GUACAMOLE-622: Withhold first SSH/telnet...

2018-09-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/187#discussion_r219632398 --- Diff: src/protocols/telnet/settings.c --- @@ -196,12 +198,31 @@ enum TELNET_ARGS_IDX { */ IDX_SCROLLBACK

[GitHub] guacamole-server pull request #187: GUACAMOLE-622: Withhold first SSH/telnet...

2018-09-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/187#discussion_r219632440 --- Diff: src/protocols/telnet/settings.h --- @@ -253,6 +267,16 @@ typedef struct guac_telnet_settings { guac_telnet_settings

[GitHub] guacamole-server pull request #187: GUACAMOLE-622: Withhold first SSH/telnet...

2018-09-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/187#discussion_r219631546 --- Diff: src/protocols/telnet/telnet.c --- @@ -82,57 +83,178 @@ static int __guac_telnet_write_all(int fd, const char* buffer, int size

[GitHub] guacamole-client pull request #321: GUACAMOLE-624: Include user full name an...

2018-09-21 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/321 GUACAMOLE-624: Include user full name and organization in display and filter. This change adds two new columns to the user admin interface, "Full name" and "Organ

[GitHub] guacamole-client pull request #320: Guacamole-626 - Add support for Docker s...

2018-09-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/320#discussion_r219370018 --- Diff: guacamole-docker/bin/start.sh --- @@ -141,16 +141,39 @@ environment variables: MYSQL_DATABASE The name

<    1   2   3   4   5   6   7   8   >