Re: retrieving timestamp from Result

2010-11-15 Thread Ryan Rawson
than one qualifier for a column family, is it reasonable to add Result.getColumnLatest(byte[]) which returns the latest column for given family ? Thanks On Mon, Nov 15, 2010 at 2:12 PM, Ryan Rawson ryano...@gmail.com wrote: The javadoc details what to expect. You can also call

Re: HRegionInfo.createRegionName()

2010-11-15 Thread Ryan Rawson
-Daniel Cryans jdcry...@apache.org wrote: I think it's worth going at greater lengths to document that kind of breakage, maybe a page in the book? Stuff like What's new and Incompatibilities that we can easily link to. J-D On Mon, Nov 15, 2010 at 12:38 PM, Ryan Rawson ryano

Re: HRegionInfo.createRegionName()

2010-11-15 Thread Ryan Rawson
Yu yuzhih...@gmail.com wrote: Ryan: It originated from the following call against 0.20.6: HRegionInfo.createRegionName(tableName, null, ZEROES); On Mon, Nov 15, 2010 at 4:48 PM, Ryan Rawson ryano...@gmail.com wrote: Why are you calling this method? Despite it being 'public', users

Re: Build failed in Hudson: HBase-TRUNK #1650

2010-11-12 Thread Ryan Rawson
The problem was missing 1240, and I pushed out a new hadoop jar built from tip of append-20-branch On Fri, Nov 12, 2010 at 4:40 PM, Jean-Daniel Cryans jdcry...@apache.org wrote: Yeah 1240 is in fact required to be able to be able to start 2 hdfs clusters, and it's supposed to be in there, but

Re: Problem with trunk compilation

2010-11-10 Thread Ryan Rawson
hudson has no problems? are you sure you hava a java6 system? On Wed, Nov 10, 2010 at 1:40 AM, Sebastian Bauer ad...@ugame.net.pl wrote: revision: 1033390 [INFO] --- maven-resources-plugin:2.4:resources (default-resources) @ hbase --- [INFO] Using 'UTF-8' encoding to copy filtered

Re: Problem with trunk compilation

2010-11-10 Thread Ryan Rawson
, Sebastian Bauer pisze: I have gentoo with main java version: # java -version java version 1.6.0_22 Java(TM) SE Runtime Environment (build 1.6.0_22-b04) Java HotSpot(TM) 64-Bit Server VM (build 17.1-b03, mixed mode) W dniu 10.11.2010 09:47, Ryan Rawson pisze: hudson has no problems? are you sure

Re: Review Request: HBASE-3211 Key only filter

2010-11-10 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1208/#review1891 --- trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java

Re: Review Request: HBASE-3211 Key only filter

2010-11-10 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1208/#review1903 --- trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java

Re: Review Request: HBASE-2989 MultiPut makes proper error handling impossible and leads to corrupted data

2010-11-09 Thread Ryan Rawson
http://review.cloudera.org/r/1176/#comment6075 this was called by HTable, but those have shifted to use processBatch() instead. - Ryan On 2010-11-05 01:43:22, Ryan Rawson wrote: --- This is an automatically generated e-mail

Re: Review Request: HBASE-2989 MultiPut makes proper error handling impossible and leads to corrupted data

2010-11-08 Thread Ryan Rawson
SVN! It was including my scratch work :-) - Ryan On 2010-11-05 01:43:22, Ryan Rawson wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1176

Re: Build failed in Hudson: HBase-TRUNK #1633

2010-11-08 Thread Ryan Rawson
Looks like this latest series of failures may be due to this: 2010-11-09 03:37:41,892 FATAL [Master:0;vesta.apache.org:52791] master.HMaster(884): Unhandled exception. Starting shutdown. java.lang.NullPointerException at java.util.TreeMap.getEntry(TreeMap.java:324) at

Re: Build failed in Hudson: HBase-TRUNK #1633

2010-11-08 Thread Ryan Rawson
Looks like this first showed up here: https://hudson.apache.org/hudson/job/HBase-TRUNK/1629/ Which included: https://issues.apache.org/jira/browse/HBASE-2896 I'm guessing 'retainAssignment' was part of the added code path. On Mon, Nov 8, 2010 at 8:16 PM, Ryan Rawson ryano...@gmail.com wrote

Re: Build failed in Hudson: HBase-TRUNK #1633

2010-11-08 Thread Ryan Rawson
!= null) {         assignments.get(server).add(region.getKey());       } else { St.Ack On Mon, Nov 8, 2010 at 8:21 PM, Ryan Rawson ryano...@gmail.com wrote: Looks like this first showed up here: https://hudson.apache.org/hudson/job/HBase-TRUNK/1629/ Which included: https://issues.apache.org

Re: Review Request: HBASE-3048: Unify major/minor compactions

2010-11-07 Thread Ryan Rawson
, stack, Kannan Muthukkaruppan, and Ryan Rawson. Summary --- This is a rebased patch from Amit. This was internally reviewed but we may want some minor modifications for 0.90 with the new InternalScanner, if possible. (suggestion from ryan on jira) This addresses bug HBASE

Review Request: HBASE-2989 MultiPut makes proper error handling impossible and leads to corrupted data

2010-11-05 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1176/ --- Review request for hbase. Summary --- This is a change to batch() that

Re: Review Request: Refactor Corrupt Data Tests in TestHLogSplit

2010-10-29 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1115/#review1712 --- src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

Re: Review Request: Add TimeRange support into Increment to optimize for counters that are partitioned on time

2010-10-29 Thread Ryan Rawson
: --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1132/ --- (Updated 2010-10-29 19:42:21) Review request for hbase, stack, Ryan Rawson, and khemani. Summary

Re: Review Request: Increment multiple columns in a row at once

2010-10-25 Thread Ryan Rawson
On 2010-10-24 20:05:55, Ryan Rawson wrote: trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java, line 495 http://review.cloudera.org/r/1088/diff/2/?file=15909#file15909line495 yeah you cant compare against memstoreTS because if you have this in here you wont

Re: Review Request: Increment multiple columns in a row at once

2010-10-25 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1088/#review1660 ---

Review Request: HBASE-2753 remove sorting from Result

2010-10-25 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1092/ --- Review request for hbase. Summary --- the last hurrah, removing the

Re: Review Request: Increment multiple columns in a row at once

2010-10-24 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1088/#review1641 ---

Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available

2010-10-22 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/ --- (Updated 2010-10-22 15:43:55.487649) Review request for hbase. Changes

Re: Review Request: scan can early exit for incrementColumnValue()

2010-10-22 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1053/#review1626 --- Ship it! - Ryan On 2010-10-20 21:31:17, khemani wrote:

Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available

2010-10-22 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/ --- (Updated 2010-10-22 16:38:10.455573) Review request for hbase. Summary

Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available

2010-10-20 Thread Ryan Rawson
excessive though. - Ryan --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/#review1574 --- On 2010-10-18 19:30:09, Ryan Rawson wrote

Re: Review Request: scan can early exit for incrementColumnValue()

2010-10-20 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1053/#review1596 --- src/main/java/org/apache/hadoop/hbase/regionserver/InternalScan.java

Re: Review Request: [rest] publish endpoint and statistics into ZooKeeper

2010-10-18 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1039/#review1560 --- src/main/java/org/apache/hadoop/hbase/HConstants.java

Re: Review Request: [rest] publish endpoint and statistics into ZooKeeper

2010-10-18 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1039/#review1565 --- Ship it! - Ryan On 2010-10-18 14:46:30, Andrew Purtell wrote:

Re: Review Request: HBASE-2985 multi() no longer calls HRegion.put(list) when possible

2010-10-18 Thread Ryan Rawson
that printf debugging in prod :-) - Ryan --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1038/#review1566 --- On 2010-10-18 13:42:36, Ryan

Re: HBaseAdmin.flush()

2010-10-14 Thread Ryan Rawson
, Oct 14, 2010 at 7:23 PM, Ryan Rawson ryano...@gmail.com wrote: The answer is HDFS-200 and changes to HLog. You should start considering what your 0.90 upgrade plan will be, it is imperative that within 3 months no one is running 0.20.6 or earlier.  Getting the features of 0.90 on 0.20.x

Review Request: HBASE-3073 New APIs for Result, faster implementation for some calls

2010-10-05 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/963/ --- Review request for hbase. Summary --- New APIs for Result, faster

Re: Review Request: HBASE-3073 New APIs for Result, faster implementation for some calls

2010-10-05 Thread Ryan Rawson
://review.cloudera.org/r/963/#comment4980 i removed this in my svn client, it was remnant of my perf testing - Ryan On 2010-10-05 15:39:19, Ryan Rawson wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: HBASE-3073 New APIs for Result, faster implementation for some calls

2010-10-05 Thread Ryan Rawson
://review.cloudera.org/r/963/#comment4989 after https://issues.apache.org/jira/browse/HBASE-2753 is resolved, raw()===sort() and there wont be a difference. - Ryan On 2010-10-05 15:39:19, Ryan Rawson wrote

Re: Review Request: HBASE-3073 New APIs for Result, faster implementation for some calls

2010-10-05 Thread Ryan Rawson
On 2010-10-05 16:25:58, Ryan Rawson wrote: trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java, line 202 http://review.cloudera.org/r/963/diff/1/?file=14002#file14002line202 after https://issues.apache.org/jira/browse/HBASE-2753 is resolved, raw()===sort

Review Request: HBASE-3008 - memstore size can go negative (!) causing data to be unable to be flushed

2010-10-05 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/965/ --- Review request for hbase. Summary --- a problem we observed with HBASE-3008

Re: Review Request: HBASE-3008 - memstore size can go negative (!) causing data to be unable to be flushed

2010-10-05 Thread Ryan Rawson
/TestStore.java http://review.cloudera.org/r/965/#comment5007 yes that is a good point, there is a little bit of crufty comments left here, so i removed them and i also added asserts at the end so the computed and 'computed along' sizes are the same. - Ryan On 2010-10-05 18:15:49, Ryan Rawson wrote

Re: [jira] Updated: (HBASE-3073) New APIs for Result, faster implementation for some calls

2010-10-05 Thread Ryan Rawson
rawson (JIRA) j...@apache.org wrote: From: ryan rawson (JIRA) j...@apache.org Subject: [jira] Updated: (HBASE-3073) New APIs for Result, faster implementation for some calls To: iss...@hbase.apache.org Date: Tuesday, October 5, 2010, 5:45 PM      [ https://issues.apache.org/jira/browse

Re: dynamic RPC and coprocessor changes

2010-10-05 Thread Ryan Rawson
For what it's worth, the Result changes are just a few functions and represent a big bang for the buck in terms of lines of code added. I fixed the build - sorry about that! From what I've seen, the coprocessor stuff interacts but isnt as crazy as other things. I'd say go for it. We only get 1

Re: [VOTE] Release 'development release' HBase 0.89.2010924 rc1?

2010-10-04 Thread Ryan Rawson
I ran ycsb on it for a while and it looked ok... but we really cant ship without the fix to that bug, it has the possibility of causing serious data loss for heavy users of ICV. -ryan On Mon, Oct 4, 2010 at 3:41 PM, Jonathan Gray jg...@facebook.com wrote: +1 I took it for a test drive today

Re: [VOTE] Release 'development release' HBase 0.89.2010924 rc1?

2010-10-04 Thread Ryan Rawson
not use in production, is on there already.  And the bug is in ICVs only, right?  We can release w/ warning that ICVers need to apply the patch, np. Good stuff, St.Ack On Mon, Oct 4, 2010 at 8:40 PM, Ryan Rawson ryano...@gmail.com wrote: we could yes.  with the caveat that no production use

Re: Review Request: [HBASE-2321] [HBASE-2002] Add support for per-region dynamically registered RPC endpoints for coprocessors and allow configurable RPC client/server implementations

2010-10-01 Thread Ryan Rawson
I think it's tricky, because we dont really encourage people to think of regions, but think of rows instead. The fact that regions exist is a bit of an implementation detail, although like indexes in databases a critical and crucial one that we cant really ignore in the end. Requiring people to

Please review HBASE-3073 - API addition!

2010-10-01 Thread Ryan Rawson
I have put up a new API suggestion based on some experience I have had lately regarding the speed of HBase. Please look at it, I am seeking to commit this ASAP. https://issues.apache.org/jira/browse/HBASE-3073 -ryan

Re: Review Request: Reseeking directly to required columns

2010-09-29 Thread Ryan Rawson
On 2010-09-28 18:52:19, Pranav Khaitan wrote: Ryan: Additionally, as part of the commit, you added the optimization for SEEK_NEXT_ROW. Had a question on the getKeyForNextRow() function: + + public KeyValue getKeyForNextRow(KeyValue kv) { +return KeyValue.createLastOnRow(

Re: HBase RPM spec file?

2010-09-24 Thread Ryan Rawson
Hey, There isnt any concerted effort by HBase developers to deliver a RPM. Part of the reason is that we just dont have the bandwidth to repackage and deal with those issues. As a developer who has to support repackaging, i am not super excited about it - since most of the problems tend to be

Re: Review Request: HBASE-2997 performance improvements

2010-09-15 Thread Ryan Rawson
/#comment4191 in a 64 bit jvm you cannot read a partial long, the updates are atomic. this is part of the spec. also single threaded comment above. - Ryan On 2010-09-14 15:41:01, Ryan Rawson wrote: --- This is an automatically

Re: Review Request: HBASE-2941 - multithreaded read for server rpc

2010-09-14 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/752/ --- (Updated 2010-09-14 14:19:53.985785) Review request for hbase. Changes ---

Review Request: HBASE-2997 performance improvements

2010-09-14 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/844/ --- Review request for hbase. Summary --- HBASE-2997 performance improvements

Review Request: HBASE-2941 reader threads for hbase rpc

2010-09-14 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/846/ --- Review request for hbase. Summary --- HBASE-2941 reader threads for hbase

Re: Review Request: HBASE-2997 performance improvements

2010-09-14 Thread Ryan Rawson
/apache/hadoop/hbase/io/hfile/HFile.java http://review.cloudera.org/r/842/#comment4121 perf thing, we do 2 less int decodes - Ryan On 2010-09-14 15:40:35, Ryan Rawson wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: HBASE-2941 reader threads for hbase rpc

2010-09-14 Thread Ryan Rawson
that to another thread to do the reads, so it doesnt have to attempt to keep socket accept() delays down by accepting batches at a time. - Ryan On 2010-09-14 15:43:46, Ryan Rawson wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: Eliminate duplicates, stale versions. Have determined behaviour and storefile ordering

2010-09-07 Thread Ryan Rawson
, Ryan Rawson, Karthik Ranganathan, and Kannan Muthukkaruppan. Summary --- Goodbye duplicates, hello consistent ordering. A way to order multiple cells having same keys. Every StoreFile will have a timestamp associated with it and when any two cells have same keys

Review Request: HBASE-2941 - multithreaded read for server rpc

2010-08-31 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/752/ --- Review request for hbase. Summary --- HBASE-2941 - multithreaded read for

hbase vs bigtable

2010-08-28 Thread Ryan Rawson
bigtable was written for 1 core machines, with ~ 100 regions per box. Thanks to CMS we generally can't run on 4 cores, and at this point 16 core machines (with HTT) is becoming pretty standard. The question is, how do we leverage the ever-increasing sizes of machines and differentiate ourselves

Re: hbase vs bigtable

2010-08-28 Thread Ryan Rawson
are probably mostly latency, doing them in parallel could be a win that was possible from the HBase side. You might have problems with memory churn, though, if you're allocating 10+ buffers per read. On Sat, Aug 28, 2010 at 7:27 PM, Ryan Rawson ryano...@gmail.com wrote: One problem of performance right

Re: Question HFile Insert Key or Update Key

2010-08-28 Thread Ryan Rawson
Hfiles are write once read many. Once written they cannot be modified so there is way to move things around. Hbase deals with this by having a robust write buffer and writing large files. For more architectural details check out the bigtable paper. On Aug 28, 2010 8:32 PM, zhixuan zhu

Re: Review Request: Inexpensive reseek operations (1517) and filter based scanning (2904)

2010-08-13 Thread Ryan Rawson
://review.cloudera.org/r/574/ --- (Updated 2010-08-13 11:35:48) Review request for hbase, stack, Jonathan Gray, Ryan Rawson, Karthik Ranganathan, and Kannan Muthukkaruppan. Summary --- What this patch includes: 1. Reseek framework

Re: Review Request: Inexpensive reseek operations (1517) and filter based scanning (2904)

2010-08-13 Thread Ryan Rawson
2010-08-13 12:33:23) Review request for hbase, stack, Jonathan Gray, Ryan Rawson, Karthik Ranganathan, and Kannan Muthukkaruppan. Summary --- What this patch includes: 1. Reseek framework. The ability to reseek to any position after having seeked to some point in the file

Re: Review Request: Inexpensive reseek operations (1517) and filter based scanning (2904)

2010-08-12 Thread Ryan Rawson
/ --- (Updated 2010-08-10 17:58:43) Review request for hbase, stack, Jonathan Gray, Ryan Rawson, Karthik Ranganathan, and Kannan Muthukkaruppan. Summary --- What this patch includes: 1. Reseek framework. The ability to reseek to any position

Re: Why does FilterList inherit from Filter and not from FilterBase? Any particular reason?

2010-08-10 Thread Ryan Rawson
Filter is a large interface requiring something like 6-7 methods to be defined. Furthermore, nearly all of those methods have a reasonable default for a 'null filter' that would filter nothing. That is what FilterBase does. FilterList overrides every single interface method, thus it doesn't

Re: minor bug in ServerManager.ServerMonitor.chore()

2010-07-31 Thread Ryan Rawson
If its a bonafide bug please file a JIRA outlining the reproduction steps, the expected outcome and impact. On Jul 31, 2010 3:13 PM, Ted Yu yuzhih...@gmail.com wrote: Hi, I see a minor issue in ServerManager.ServerMonitor.chore() where first would always be true. The following line should be

Re: [VOTE] Shall we release hbase-0.20.6 Release Candidate 1 as hbase-0.20.6?

2010-07-30 Thread Ryan Rawson
+1 I ran a 30GB import test and counted it - worked great on 15 nodes. -ryah On Mon, Jul 19, 2010 at 9:15 PM, Stack st...@duboce.net wrote: I've posted an hbase 0.20.6 release candidate 5 here:  http://people.apache.org/~stack/hbase-0.20.6-candidate-1/ There have been 8 fixes since the

Re: RPC statistics from region servers...

2010-07-28 Thread Ryan Rawson
I think those are dynamic metrics... they don't exist until used? On Jul 28, 2010 7:30 PM, Kannan Muthukkaruppan kan...@facebook.com wrote: I was using jconsole to check the stats published by region servers.. Under hadoop.HBase.RPCStatistics-60020.Attributes, I only see: RpcQueueTime*

Re: Branching next 0.89 release tomorrow unless objection

2010-07-24 Thread Ryan Rawson
Do we have to branch? Can you just cut a tag? We don't plan on patching this - just releasing the next from trunk... On Jul 23, 2010 11:12 PM, Stack st...@duboce.net wrote: Its time to cut another 0.89 release. There is good stuff committed since our first 0.89 (replication!). I'll branch

Review Request: HBASE-2863 -- HBASE-2553 removed an important edge case

2010-07-22 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/354/ --- Review request for hbase. Summary --- There are tricky edge cases that were

Re: Review Request: HBASE-2863 -- HBASE-2553 removed an important edge case

2010-07-22 Thread Ryan Rawson
://review.hbase.org/r/354/#review450 --- On 2010-07-22 01:07:55, Ryan Rawson wrote: --- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/354

Re: Review Request: Bloom filter NPE

2010-07-21 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review445 --- trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

Re: Review Request: Bloom filter NPE

2010-07-19 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review425 --- trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java

Review Request: Remove the final remnants of the old Get code - the query matchers and other helper classes

2010-07-16 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/332/ --- Review request for hbase. Summary --- Remove the final remnants of the old Get

Review Request: HBASE-2553 rework IncrementColumnValue

2010-07-15 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/325/ --- Review request for hbase. Summary --- rework ICV by no longer requiring

Re: Build failed in Hudson: HBase-TRUNK #1385

2010-07-15 Thread Ryan Rawson
More hudson flakyness, nothing to see here folks, move along. (only 1 of these tests failed on my own box) On Thu, Jul 15, 2010 at 7:05 PM, Apache Hudson Server hud...@hudson.zones.apache.org wrote: See http://hudson.zones.apache.org/hudson/job/HBase-TRUNK/1385/changes Changes: [rawson]

Re: Review Request: Timestamp based optimization for selecting the StoreFiles to be used in a Scan

2010-07-12 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/257/#review357 --- there are a number of intenting issues, HBase uses a 2 space base and a 4

Re: Review Request: Timestamp based optimization for selecting the StoreFiles to be used in a Scan

2010-07-12 Thread Ryan Rawson
On 2010-07-12 13:09:10, Ryan Rawson wrote: trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, line 425 http://review.hbase.org/r/257/diff/4/?file=2332#file2332line425 is this idiomatic? I dont think I've seen this particular pattern before? Pranav

Re: Review Request: HBASE-2803 remove remaining get code from Store.java etc

2010-07-07 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/278/ --- (Updated 2010-07-07 15:25:32.452386) Review request for hbase. Summary ---

Review Request: HBASE-2803 Remove remaining Get code from Store.java,etc

2010-06-29 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/240/ --- Review request for hbase. Summary --- Remove remaining Get code from

Re: Build failed in Hudson: HBase-TRUNK #1370

2010-06-28 Thread Ryan Rawson
For some reason test merge Meta is flaky... passes multiple times on my computer. On Jun 28, 2010 12:52 AM, Apache Hudson Server hud...@hudson.zones.apache.org wrote: See http://hudson.zones.apache.org/hudson/job/HBase-TRUNK/1370/changes Changes: [rawson] HBASE-2501 Refactor StoreFile Code

Re: Feature branch for master rewrite

2010-06-25 Thread Ryan Rawson
+1 make it happen if it hasnt yet :-) On Thu, Jun 24, 2010 at 8:15 PM, Jonathan Gray jg...@facebook.com wrote: That's the plan.  Thanks guys. -Original Message- From: Todd Lipcon [mailto:t...@cloudera.com] Sent: Thursday, June 24, 2010 5:30 PM To: dev@hbase.apache.org Subject: Re:

Re: [VOTE] Release development release HBase 0.89.20100621 rc0

2010-06-23 Thread Ryan Rawson
We really need: HBASE-2774 without it people could run into really bad performance issues. it works well for both me and stack on different hardware profiles (older intel xeons vs newer i7s) and solves the problem. -ryan On Wed, Jun 23, 2010 at 2:45 PM, Todd Lipcon t...@cloudera.com wrote:

Re: Review Request: HBASE-2670. Memstore should retain multiple versions of a row when memstore TS differs

2010-06-15 Thread Ryan Rawson
: --- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/180/ --- (Updated 2010-06-14 16:30:30) Review request for hbase and Ryan Rawson. Summary --- This changes the memstore comparator, improves

Re: Review Request: Reconstruction log playback has no bounds on memory used

2010-06-14 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/179/#review223 --- generally speaking i like it. The question is, how do we roll it up with

Re: Review Request: HBASE-2400: new connector for Avro RPC access to HBase cluster

2010-06-09 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/128/#review164 --- trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro

Re: Review Request: HBASE-2400: new connector for Avro RPC access to HBase cluster

2010-06-09 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/128/#review171 --- trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.avpr

Re: Review Request: HBASE-2618 Don't inherit from HConstants.

2010-06-07 Thread Ryan Rawson
On 2010-06-06 09:08:19, Jonathan Gray wrote: This patch changes a bunch of tabbing patterns to be different from what is currently done in the codebase. Primarily the full indenting of arguments to align with each other. As far as I know, this format is not used anywhere else in

Re: Review Request: HBASE-2651 allow specifying non-tab separators in ImportTSV

2010-06-03 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/116/#review128 --- Ship it! - Ryan On 2010-06-03 12:39:07, Todd Lipcon wrote:

Re: Review Request: HBASE-1923. Bulk load into existing tables

2010-05-31 Thread Ryan Rawson
Lets not put this in branch... focus on making trunk releasable not extending branch's life. On May 30, 2010 2:13 PM, Todd Lipcon t...@cloudera.com wrote: On 2010-05-28 17:19:22, stack wrote: src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java, line 264

Re: [jira] Created: (HBASE-2624) TestMultiParallelPuts flaky on trunk

2010-05-28 Thread Ryan Rawson
With the move to TLP the official address is: dev@hbase.apache.org thanks! -ryan On Fri, May 28, 2010 at 11:44 AM, Andrew Milkowski andrewmilkow...@gmail.com wrote: permanent mail bounce-back error, what is the correct destination address, need to cut down on some email traffic, not that you

Re: Review Request: HBASE-2468: Improvements to prewarm META cache on clients.

2010-05-28 Thread Ryan Rawson
On 2010-05-28 14:13:14, Benoit Sigoure wrote: src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java, line 306 http://review.hbase.org/r/98/diff/3/?file=741#file741line306 Please use a concurrent collection and remove the synchronized blocks. For guidance, see

Re: Review Request: HBASE-2578

2010-05-27 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/83/#review88 --- src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Review board for all/most JIRAs patches

2010-05-21 Thread Ryan Rawson
Hi all, To make the life of reviewers easier, as well as improving review turn around time, we are requesting all contributors (committers and otherwise) to submit patches to http://review.hbase.org/ in addition to attaching them to JIRAs. Review board has a nice API which allows people to

[jira] Created: (HBASE-2596) test of email gateway

2010-05-21 Thread ryan rawson (JIRA)
test of email gateway - Key: HBASE-2596 URL: https://issues.apache.org/jira/browse/HBASE-2596 Project: Hadoop HBase Issue Type: Test Reporter: ryan rawson just a test -- This message is automatically

<    1   2