[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309488415 ## File path: helix-core/src/test/java/org/apache/helix/controller/stages/TestStateTransitio

[GitHub] [helix] narendly commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#issuecomment-517078763 Some concerns: 1. What would help others see that you aren't breaking any features is to keep existing tests th

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309537593 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309537640 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309537757 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterDataProvider

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309538319 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309538852 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309539477 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309539385 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309539592 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.j

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309544325 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-517151234 @i3wangyi Thanks for the comments. For the general comments, I'm trying to answer here. > You could just have a blank method wit

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309553538 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/AbstractDataCache.j

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309554185 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/CurrentStateCache.j

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309558098 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/CurrentStateSnapsho

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309558774 ## File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.ja

[GitHub] [helix] jiajunwang commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

jiajunwang commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r309560854 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/c

[GitHub] [helix] jiajunwang commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

jiajunwang commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r309562505 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/N

[GitHub] [helix] jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309569490 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309566603 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309565223 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309570823 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

jiajunwang commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309568879 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309807277 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/CurrentStateCache.j

[GitHub] [helix] alirezazamani opened a new issue #370: Unnecessary Touch logic when updating resourceconfig

alirezazamani opened a new issue #370: Unnecessary Touch logic when updating resourceconfig URL: https://github.com/apache/helix/issues/370 Since controller will be notified when resourceconfig, it is not necessary to do touch logic once resourceconfig is updated. Hence some of the places

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309831540 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309839047 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/CurrentStateCache.j

[GitHub] [helix] alirezazamani opened a new pull request #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines

alirezazamani opened a new pull request #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines URL: https://github.com/apache/helix/pull/371 **Issues** In the places that ZooKeeper Resourceconfig is updated, it is not necessary to do touch logic anymore to ru

[GitHub] [helix] alirezazamani closed issue #345: Read failure while reading/accessing a non-existent znode

alirezazamani closed issue #345: Read failure while reading/accessing a non-existent znode URL: https://github.com/apache/helix/issues/345 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] alirezazamani closed issue #351: Removing the TODO log for computeResourceBestPossibleState function

alirezazamani closed issue #351: Removing the TODO log for computeResourceBestPossibleState function URL: https://github.com/apache/helix/issues/351 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309857682 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] narendly commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines

narendly commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines URL: https://github.com/apache/helix/pull/371#issuecomment-517424897 Please follow https://github.com/apache/helix/wiki/Pull-Request-Template -

[GitHub] [helix] narendly commented on issue #369: Add the workaround fix for assigning partitions when instance weight …

narendly commented on issue #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#issuecomment-517424827 Please follow https://github.com/apache/helix/wiki/Pull-Request-Template ---

[GitHub] [helix] alirezazamani commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines

alirezazamani commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines URL: https://github.com/apache/helix/pull/371#issuecomment-517429169 > Please follow https://github.com/apache/helix/wiki/Pull-Request-Template Done :) ---

[GitHub] [helix] narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309874991 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientFactory.java ###

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309879667 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309880233 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309886971 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.jav

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309884897 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309881065 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309877592 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309878422 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309876827 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309880181 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309885782 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.jav

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309886851 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.jav

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309876643 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309878201 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309884200 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309883964 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309878696 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309884085 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309883423 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309898755 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309901561 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309903047 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309904587 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309905879 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309907706 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.j

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309928869 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/IdealStateCache.jav

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309928848 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/ExternalViewCache.j

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309928869 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/IdealStateCache.jav

[GitHub] [helix] pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#issuecomment-517490244 Since this API is not that urgent, we will discuss about it in more details offline and complete it later. --

[GitHub] [helix] pkuwm closed pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm closed pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [helix] pkuwm commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

pkuwm commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r309933493 ## File path: helix-core/src/test/java/org/apache/helix/controller/strategy/crushMapping/Test

[GitHub] [helix] pkuwm commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

pkuwm commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r309932250 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/crushM

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309955047 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] lei-xia commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

lei-xia commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r309978280 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/crus

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309978697 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/AbstractTestClusterMo

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309976442 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309978070 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309978730 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/AbstractTestClusterMo

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309977591 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309978496 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.jav

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309978675 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/AbstractTestClusterMo

[GitHub] [helix] i3wangyi commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

i3wangyi commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309979933 ## File path: helix-core/src/main/java/org/apache/helix/controller/stages/StateTransitionThr

[GitHub] [helix] i3wangyi commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

i3wangyi commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309981100 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThr

[GitHub] [helix] i3wangyi commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

i3wangyi commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309981145 ## File path: helix-core/src/test/java/org/apache/helix/integration/common/ZkStandAloneCMTes

[GitHub] [helix] i3wangyi commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config

i3wangyi commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#issuecomment-517548807 > Some concerns: > > 1. What would help others see that you aren't breaking any features is to keep existing te

[GitHub] [helix] i3wangyi commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

i3wangyi commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r309982285 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/cru

[GitHub] [helix] i3wangyi commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

i3wangyi commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r309983555 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Nod

[GitHub] [helix] narendly commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines

narendly commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines URL: https://github.com/apache/helix/pull/371#issuecomment-517712533 You could do https://github.com/apache/helix/wiki/Pull-Request-Check-In-Steps to get this checked in. As disc

[GitHub] [helix] narendly commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

narendly commented on a change in pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#discussion_r310147891 ## File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310150588 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThr

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310150104 ## File path: helix-core/src/main/java/org/apache/helix/controller/stages/StateTransitionThr

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310153372 ## File path: helix-core/src/main/java/org/apache/helix/controller/stages/StateTransitionThr

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310153372 ## File path: helix-core/src/main/java/org/apache/helix/controller/stages/StateTransitionThr

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310154419 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/cru

[GitHub] [helix] alirezazamani commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines

alirezazamani commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines URL: https://github.com/apache/helix/pull/371#issuecomment-517754114 These changes have been covered by tests. I also check it manually and the pipeline is triggered. --

[GitHub] [helix] alirezazamani commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines

alirezazamani commented on issue #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines URL: https://github.com/apache/helix/pull/371#issuecomment-517754322 This PR is ready to be merged, approved by @jiajunwang and @narendly. ---

[GitHub] [helix] dasahcc merged pull request #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines

dasahcc merged pull request #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines URL: https://github.com/apache/helix/pull/371 This is an automated message from the Apache Git Service. To respon

[GitHub] [helix] alirezazamani closed issue #370: Remove unnecessary touch logic when updating ResourceConfig

alirezazamani closed issue #370: Remove unnecessary touch logic when updating ResourceConfig URL: https://github.com/apache/helix/issues/370 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310215210 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableReplica

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310213021 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/AbstractTestClusterMo

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310215940 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableReplica

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310161710 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java ##

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310218199 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestClusterContext.ja

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310213353 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableNode.ja

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310214018 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableNode.ja

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310162365 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java ##

<    1   2   3   4   5   6   7   8   >