Barna Zsombor Klara created HIVE-14226:
--
Summary: Invalid check on an ASTNode#toStringTree in CalcitePlanner
Key: HIVE-14226
URL: https://issues.apache.org/jira/browse/HIVE-14226
Project: Hive
engine, so a
complex query resulting in more than one task should only count as one as per
my understanding.
Thanks,
Barna Zsombor Klara
/TestNanoTimeUtils.java
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_int96_timestamp.q PRE-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor
/queries/clientpositive/parquet_int96_timestamp.q PRE-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
/src/test/queries/clientpositive/parquet_int96_timestamp.q PRE-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
nt. The timezone adjustment in NanoTimeUtils
should take care of it.
- Barna Zsombor
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56334/#review164481
--
/files/2017/02/03/ea41fd61-d49a-49cd-b31f-4567186cfc16__Query_Lifecycle_Timing_Metrics.png
New metrics showing query success rate
https://reviews.apache.org/media/uploaded/files/2017/02/03/1d613941-5d49-438e-bac9-0b08db190e6b__Query_Success_Rate_Matrics.png
Thanks,
Barna Zsombor Klara
in the error message of the failed test.
Checkout how multiple tests, all with failures, look on the console to make
sure that the results are still readeable/easy to follow.
Thanks,
Barna Zsombor Klara
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55846/#review162795
---
On Jan. 25, 2017, 1:12 p.m., Barna Zsombor Klara wrote:
>
> -
bbc
Diff: https://reviews.apache.org/r/55932/diff/
Testing
---
Ran multiple queries and checked that they are still displayed correctly.
Thanks,
Barna Zsombor Klara
that the results are still readeable/easy to follow.
Thanks,
Barna Zsombor Klara
/parquet_int96_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/parquet_timestamp_conversion.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-16024:
--
Summary: MSCK Repair Requires nonstrict hive.mapred.mode
Key: HIVE-16024
URL: https://issues.apache.org/jira/browse/HIVE-16024
Project: Hive
://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
/parquet_int96_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/parquet_timestamp_conversion.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-15864:
--
Summary: Fix type introduced in HIVE-14754
Key: HIVE-15864
URL: https://issues.apache.org/jira/browse/HIVE-15864
Project: Hive
Issue Type: Sub
uld have already thrown an exception in
ParquetRecordReaderBase. I'm not sure when the timezone can be missing here.
Sergio do you maybe remember?
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.a
/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
t:
https://reviews.apache.org/r/56334/#review164773
-----------
On Feb. 9, 2017, 5:23 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56334/#review164773
---
On Feb. 9, 2017, 5:23 p.m., Barna Zsombor Klara
/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/parquet_timestamp_conversion.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/56334/diff/
Testing
---
qtest and unit tests added.
Thanks,
Barna Zsombor Klara
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56334/#review165133
-------
On Feb. 10, 2017, 1:41 p.m., Barna Zsombor Klara wrote:
>
>
root tasks are incrementing the counter since the original jira was
about counting the number of queries issued against each exeution engine, so a
complex query resulting in more than one task should only count as one as per
my understanding.
Thanks,
Barna Zsombor Klara
e have an instance variable initialized in the constructor
instead of having it rebuilt every time?
- Barna Zsombor Klara
On Aug. 3, 2016, 8:56 p.m., Zoltan Haindrich wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
Barna Zsombor Klara created HIVE-16088:
--
Summary: Fix hive conf property name introduced in HIVE-12767
Key: HIVE-16088
URL: https://issues.apache.org/jira/browse/HIVE-16088
Project: Hive
Barna Zsombor Klara created HIVE-14758:
--
Summary: Metrics for threads/threading
Key: HIVE-14758
URL: https://issues.apache.org/jira/browse/HIVE-14758
Project: Hive
Issue Type: Sub-task
Barna Zsombor Klara created HIVE-14753:
--
Summary: Track the number of open/closed/abandoned sessions in HS2
Key: HIVE-14753
URL: https://issues.apache.org/jira/browse/HIVE-14753
Project: Hive
Barna Zsombor Klara created HIVE-14756:
--
Summary: Metrics for the HS2/HMS interface
Key: HIVE-14756
URL: https://issues.apache.org/jira/browse/HIVE-14756
Project: Hive
Issue Type: Sub
Barna Zsombor Klara created HIVE-14752:
--
Summary: New metrics should be introduced to more easily monitor
the workload of HS2/HMS
Key: HIVE-14752
URL: https://issues.apache.org/jira/browse/HIVE-14752
Barna Zsombor Klara created HIVE-14754:
--
Summary: Track the queries execution lifecycle times
Key: HIVE-14754
URL: https://issues.apache.org/jira/browse/HIVE-14754
Project: Hive
Issue
Barna Zsombor Klara created HIVE-14755:
--
Summary: Track the success/failure rate of queries
Key: HIVE-14755
URL: https://issues.apache.org/jira/browse/HIVE-14755
Project: Hive
Issue
Barna Zsombor Klara created HIVE-14757:
--
Summary: Metrics for Zookeeper locks/locking
Key: HIVE-14757
URL: https://issues.apache.org/jira/browse/HIVE-14757
Project: Hive
Issue Type: Sub
/MapReduceCompiler.java (line 90)
<https://reviews.apache.org/r/51699/#comment216422>
Should we set the original value back once the compilation has finished?
Can it cause any issues if recursive input dirs is set?
- Barna Zsombor Klara
On Sept. 7, 2016, 6:57 p.m., Chaoyu Tang
t method annotated
with @Before?
ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java
(line 148)
<https://reviews.apache.org/r/52283/#comment219103>
nit: Can we have more meaningful test names than
testUpdateCredentialProviders_xx?
- Barna Zsombor Klara
On S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52631/#review151796
---
Ship it!
+1. Thanks for the patch.
- Barna Zsombor Klara
: https://reviews.apache.org/r/52684/diff/
Testing
---
Unit tests added for existing and new metrics in the SQLOperation and
CodahaleMetrics classes.
Unit tests added for the new MetricsQueryLifeTimeHook class.
Manually tested the new metrics by executing queries in HS2.
Thanks,
Barna Zsombor
/operation/Operation.java
90fe76d00e6f833e18d183c290f13c23db9303a1
Diff: https://reviews.apache.org/r/52084/diff/
Testing
---
Tested basic metric gathering with both codahale and legacy metrics class.
Updated and ran unit tests in the common project.
Thanks,
Barna Zsombor Klara
5511c54ff431211f7f72deaa017c915b839dfb2a
Diff: https://reviews.apache.org/r/52029/diff/
Testing
---
Ran the unit tests in the common and the ql subprojects.
Manually verified the metrics using the HS2 webui metric dump.
Thanks,
Barna Zsombor Klara
/service/cli/operation/Operation.java
90fe76d00e6f833e18d183c290f13c23db9303a1
Diff: https://reviews.apache.org/r/52084/diff/
Testing
---
Tested basic metric gathering with both codahale and legacy metrics class.
Updated and ran unit tests in the common project.
Thanks,
Barna Zsombor Klara
like to keep the throws clause for
documentation purposes.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52084/#review149810
-----------
On Sept. 21, 2016, 3:19 p.m., Barna Zsombor Klara wrote:
>
> --
.
Thanks,
Barna Zsombor Klara
icable.
- Barna Zsombor Klara
On Sept. 21, 2016, 3:15 p.m., Peter Vary wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/51895/#comment216575>
Wouldn't lineBuilder.indexOf(String.valueOf('\n')) work as well?
- Barna Zsombor Klara
On Sept. 14, 2016, 4:54 p.m., Gabor Szadovszky wrote:
>
> ---
> This is an automatically generated
> On Sept. 15, 2016, 9:20 a.m., Barna Zsombor Klara wrote:
> > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java,
> > line 708
> > <https://reviews.apache.org/r/51895/diff/1/?file=1498559#file1498559line708>
> >
> > Wouldn't
5511c54ff431211f7f72deaa017c915b839dfb2a
Diff: https://reviews.apache.org/r/52079/diff/
Testing
---
Ran the unit tests in the common and the ql subprojects.
Manually verified the metrics using the HS2 webui metric dump.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-14775:
--
Summary: Investigate IOException usage in Metrics APIs
Key: HIVE-14775
URL: https://issues.apache.org/jira/browse/HIVE-14775
Project: Hive
Issue
e than one task should only count as one as per
my understanding.
Thanks,
Barna Zsombor Klara
apache/hadoop/hive/ql/QTestUtil.java (line 2399)
<https://reviews.apache.org/r/51397/#comment213483>
nit: Catching exceptions is probably enough.
Minor comments, LGTM otherwise.
Thanks for the patch.
- Barna Zsombor Klara
On
Barna Zsombor Klara created HIVE-14601:
--
Summary: Altering table/partition file format with preexisting
data should not be allowed
Key: HIVE-14601
URL: https://issues.apache.org/jira/browse/HIVE-14601
ache/hive/hcatalog/templeton/tool/TempletonUtils.java
(line 488)
<https://reviews.apache.org/r/51435/#comment213553>
nit: Use flow API for the last append call as well.
LGTM.
Thanks for the patch.
- Barna Zsombor Klara
On Aug. 25, 2016, 6:0
-
Thanks,
Barna Zsombor Klara
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51381/#review146886
-----------
On Aug. 26, 2016, 12:12 a.m., Barna Zsombor Klara wrote:
>
>
/TestCompactionTxnHandler.java
f513d0fa791f24da4ce6312df9923db692ef7129
Diff: https://reviews.apache.org/r/51381/diff/
Testing
---
Thanks,
Barna Zsombor Klara
,
Barna Zsombor Klara
,
Barna Zsombor Klara
ock.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52684/#review151968
---
On Oct. 10, 2016, 5:54 p.m
://reviews.apache.org/r/52684/diff/
Testing
---
Unit tests added for existing and new metrics in the SQLOperation and
CodahaleMetrics classes.
Unit tests added for the new MetricsQueryLifeTimeHook class.
Manually tested the new metrics by executing queries in HS2.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-15170:
--
Summary: Flaky test:
TestEmbeddedThriftBinaryCLIService.testTaskStatus
Key: HIVE-15170
URL: https://issues.apache.org/jira/browse/HIVE-15170
Project
Barna Zsombor Klara created HIVE-15169:
--
Summary: Flaky test:
TestMiniLlapLocalCliDriver.testCliDriver.columnstats_part_coltype
Key: HIVE-15169
URL: https://issues.apache.org/jira/browse/HIVE-15169
Barna Zsombor Klara created HIVE-15168:
--
Summary: Flaky test: TestSparkClient.testJobSubmission (still
flaky)
Key: HIVE-15168
URL: https://issues.apache.org/jira/browse/HIVE-15168
Project: Hive
with spark as the execution engine.
Tested that the jobSubmission test is passing if the thread is blocked for 3
seconds in the ClientProtocol#submit.
Thanks,
Barna Zsombor Klara
://reviews.apache.org/r/53570/diff/
Testing
---
Tested that if -Djava.io.tmpdir is set to a relative path we can still connect
using beeline and run queries.
Added and ran unit tests.
Thanks,
Barna Zsombor Klara
ries with spark as the execution engine.
> Tested that the jobSubmission test is passing if the thread is blocked for 3
> seconds in the ClientProtocol#submit.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
/53609/diff/
Testing
---
Ran modified unit tests / tests of the modified classes.
Ran simple queries with spark as the execution engine.
Tested that the jobSubmission test is passing if the thread is blocked for 3
seconds in the ClientProtocol#submit.
Thanks,
Barna Zsombor Klara
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review153051
---
Ship it!
Thanks for the patch. +1
- Barna Zsombor Klara
> On Oct. 17, 2016, 12:47 p.m., Barna Zsombor Klara wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java,
> > line 648
> > <https://reviews.apache.org/r/52923/diff/1/?file=1539174#file1539174line648>
> >
> >
src/main/resources/BeeLine.properties (line 190)
<https://reviews.apache.org/r/52981/#comment222334>
Missing verb in the sentence.
will not be visible around a value? or will not be present around a value?
- Barna Zsombor Klara
On Oct. 18, 2016, 8:11
.
Tested that the replay attack is not triggered when the context root is called.
Added unit test comparing the contents of the html response for a query
requesting the context root and the jsp.
Thanks,
Barna Zsombor Klara
tests in the common and the ql subprojects.
Manually verified the metrics using the HS2 webui metric dump.
Thanks,
Barna Zsombor Klara
spark-client/src/test/java/org/apache/hive/spark/client/TestSparkClient.java
b95cd7a05d44224b53bf2cef9170146b8b2eb4a8
Diff: https://reviews.apache.org/r/53166/diff/
Testing
---
Unit tests modified and tested.
I also ran a simple query with HoS as the execution engine.
Thanks,
Barna Zsombor
being redirected.
Added unit test for LLAP UI and confirmed that it was failing before and
passing now.
Thanks,
Barna Zsombor Klara
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54066/#review156855
---
Ship it!
LGTM thanks for the patch.
- Barna Zsombor Klara
guess there is no way to write a junit
test to cover it?
- Barna Zsombor Klara
On Nov. 24, 2016, 3:17 p.m., Marta Kuczora wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/client/TestSparkClient.java
b95cd7a05d44224b53bf2cef9170146b8b2eb4a8
Diff: https://reviews.apache.org/r/53166/diff/
Testing
---
Unit tests modified and tested.
I also ran a simple query with HoS as the execution engine.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-15115:
--
Summary: Flaky test:
TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats]
Key: HIVE-15115
URL: https://issues.apache.org/jira/browse/HIVE-15115
Barna Zsombor Klara created HIVE-15116:
--
Summary: Flaky test:
TestMiniLlapLocalCliDriver.testCliDriver.join_acid_non_acid
Key: HIVE-15116
URL: https://issues.apache.org/jira/browse/HIVE-15116
with HoS as the execution engine.
Thanks,
Barna Zsombor Klara
ss necessary.
- Barna Zsombor Klara
On Oct. 28, 2016, 10:08 a.m., Marta Kuczora wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/hive/spark/client/TestSparkClient.java
b95cd7a05d44224b53bf2cef9170146b8b2eb4a8
Diff: https://reviews.apache.org/r/53166/diff/
Testing
---
Unit tests modified and tested.
I also ran a simple query with HoS as the execution engine.
Thanks,
Barna Zsombor Klara
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53261/#review154125
---
Ship it!
LGTM.
Thanks for the patch.
- Barna Zsombor Klara
veLockManager
interface and then leave it to the implementation to see if those are
identified by IP and released per HS2 instance or dealt with otherwise.
- Barna Zsombor Klara
On Oct. 17, 2016, 9:34 a.m., Peter Vary wrote:
>
> ---
> Thi
in the common and the ql subprojects.
Manually verified the metrics using the HS2 webui metric dump.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-15387:
--
Summary: NPE in HiveServer2 webUI Historical SQL Operations section
Key: HIVE-15387
URL: https://issues.apache.org/jira/browse/HIVE-15387
Project: Hive
test should keep working.
- Barna Zsombor Klara
On Jan. 13, 2017, 11:58 a.m., Marta Kuczora wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Barna Zsombor Klara created HIVE-15616:
--
Summary: Improve contents of qfile test output
Key: HIVE-15616
URL: https://issues.apache.org/jira/browse/HIVE-15616
Project: Hive
Issue Type
have one very
minor nitpick. Do we need to add qtest for a public static untility method?
This can be fairly easily covered by normal junit tests which would run
significantly faster and be more resiliant to failures.
- Barna Zsombor Klara
On Nov. 28, 2016, 9:48 p.m., pengcheng xiong wrote
hadoop/hive/ql/hooks/ATSHook.java (line 213)
<https://reviews.apache.org/r/55194/#comment231712>
Same as line 208. Should this be a warning instead?
Thanks for the patch. LGTM, just minor nits.
- Barna Zsombor Klara
On Jan. 5, 2017, 2:28 a.m., Jaso
.
- Barna Zsombor Klara
On Jan. 5, 2017, 6:45 p.m., Jason Dere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-------
On March 21, 2017, 5:28 p.m., Barna Zsombor Klara wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57728/
> --
://reviews.apache.org/r/57728/diff/2/
Changes: https://reviews.apache.org/r/57728/diff/1-2/
Testing
---
Tested loading timestamps from a parquet file written by spark.
Thanks,
Barna Zsombor Klara
5de2c3f1244b8340b97eb0547fe66e52d80fb065
Diff: https://reviews.apache.org/r/57728/diff/3/
Changes: https://reviews.apache.org/r/57728/diff/2-3/
Testing
---
Tested loading timestamps from a parquet file written by spark.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-16312:
--
Summary: Flaky test: TestHCatClient.testTransportFailure
Key: HIVE-16312
URL: https://issues.apache.org/jira/browse/HIVE-16312
Project: Hive
/3-4/
Testing
---
Tested loading timestamps from a parquet file written by spark.
Thanks,
Barna Zsombor Klara
/57503/diff/2/
Changes: https://reviews.apache.org/r/57503/diff/1-2/
Testing
---
Tested locally and added qtests/unit tests.
Thanks,
Barna Zsombor Klara
://reviews.apache.org/r/57728/diff/1/
Testing
---
Tested loading timestamps from a parquet file written by spark.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-16231:
--
Summary: Parquet timestamp may be stored differently since
HIVE-12767
Key: HIVE-16231
URL: https://issues.apache.org/jira/browse/HIVE-16231
Project: Hive
partitions
missing from the HMS.
- Barna Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review169324
-------
On M
3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba
Diff: https://reviews.apache.org/r/57503/diff/3/
Changes: https://reviews.apache.org/r/57503/diff/2-3/
Testing
---
Tested locally and added qtests/unit tests.
Thanks,
Barna Zsombor Klara
Barna Zsombor Klara created HIVE-16256:
--
Summary: Flaky test: TestCliDriver.testCliDriver[comments]
Key: HIVE-16256
URL: https://issues.apache.org/jira/browse/HIVE-16256
Project: Hive
1 - 100 of 195 matches
Mail list logo
