Heh. Lost in the ether (again).
Begin forwarded message:
From: Nick Kew n...@webthing.com
Date: 1 June 2009 21:10:26 BDT
To: modules-dev@httpd.apache.org
Subject: Re: Making HTTP requests
Michael Spiegle wrote:
I'm writing a module where I need the ability to make HTTP
requests to
servers
not mean that user should see BLA_BLA_HTTP_ERROR, when there
are 999 workers in good shape.
How is the balancer supposed to know that one valid HTTP response
is an error while another is correct? A 404 or other error response
doesn't mean there's a problem with the server!
--
Nick Kew
[seems to be lost in the ether]
Begin forwarded message:
From: Nick Kew n...@webthing.com
Date: 23 May 2009 22:12:14 BDT
To: modules-dev@httpd.apache.org
Subject: Re: persistent data : common/best practices
On Sat, 23 May 2009 21:07:05 +0200
Jérôme Renard j...@ez.no wrote:
I thought about
similar).
If noone shouts, I might just hack that. Bug me if I drop it.
--
Nick Kew
it with the
important changes in r771144/771145!
--
Nick Kew
was errors generated by a script and
propagated by the server without reference to ap_send_error_response.
Hence the fix was in util_script.c where it reacts to HTTP
status codes.
That is, assuming the reference is to
http://marc.info/?t=12384462701r=1w=2
--
Nick Kew
On Mon, 18 May 2009 12:23:38 -0700
Roy T. Fielding field...@gbiv.com wrote:
On May 18, 2009, at 11:53 AM, Nick Kew wrote:
The case under discussion was errors generated by a script and
propagated by the server without reference to
ap_send_error_response.
Fix the script.
Roy
So
in core_override_type(), which is
a fixups hook, and unconditionally overrides anything set by
mod_mime or other module. The semantics are ForceType.
Why?
Does something bad happen if we check r-handler for what
some-other-module may have set before overriding it?
--
Nick Kew
and above
what 2.2 (cleanly) provides?
--
Nick Kew
On 27 Apr 2009, at 08:11, Kevac Marko wrote:
Anything new?
What, since http://svn.apache.org/viewvc?view=revrevision=766938 ?
--
Nick Kew
for an operational MPM, there are many
who'll be interested. Good luck!
--
Nick Kew
:
1. You've exposed dbd_cfg_t in mod_dbd.h - why?
2.
+DBD_DECLARE_NONSTD(void) ap_dbd_sql_init(server_rec *s, const char
*query)
That looks like an export for the API, but you haven't exposed it!
Is that an
oversight, or am I missing something?
--
Nick Kew
the test, on the dubious grounds that if pool allocation fails,
then your error handling is pretty-much going to fail for the
same reason so it's pointless.
With apr exploring entirely different allocators, that excuse
looks ever more suspect. So, yes, you're right.
--
Nick Kew
Application Development
cycle,
as with mod_privileges?
--
Nick Kew
that addresses at all.
That's untrusted, privileges-aware code.
Use case: mod_php, whose safe_mode prevents loading such code.
--
Nick Kew
ap_mpm_require(...) for modules,
and the core can then query the MPM and exit with a decent
error report if something is unsatisfied.
--
Nick Kew
be a post_config ... but need
to come earlier. Wouldn't it make sense in this instance just to
migrate everything to post_config?
--
Nick Kew
On 7 Apr 2009, at 00:14, William A. Rowe, Jr. wrote:
Nick Kew wrote:
As a matter of curiosity, why do we have two separate hooks with
identical signatures running consecutively? AFAIK it's not
historic -
it goes right back to 2.0-early-dev in 1999.
The MPMs use open_log to open listeners
can't jump from that to a
deterministic order. For a very brief overview:
http://www.apachetutor.org/dev/request
(Are you chinese? Perhaps I should mention there's a
chinese translation of my book :-)
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
a whole new fix that serves the same purpose?
204 and 304 are already
handled elsewhere (or, if not, they should be handled elsewhere).
That's precisely what PR 40953 is about.
--
Nick Kew
On 26 Mar 2009, at 08:18, Ruediger Pluem wrote:
We should axe
leader
perchild
threadpool
Criterion: those MPMs that pre-date 2.2 but are not included in it
need to be shoved away in a dusty attic.
Looks like the above list.
--
Nick Kew
/jpeg/png, and svg
using xmlns dispatch). A similar approach might apply
more widely to other media.
I can contribute some of this from my existing work,
including relicensing where necessary. That is,
if there's interest in adding some of these things
as standard in 2.4.
--
Nick Kew
. Is this disallowed/discouraged in the spec or an
oversight in the
implementation?
Both. It's an edge case, and a mod_form incompleteness. But it
won't bite you
unless your application uses a POST form with a query_string in the
action.
Or perhaps does similar for non-browser data.
--
Nick Kew
)
Although not necessary, provide ap_get_config_count()
(better name!) to
indicate how many passes of config have completed. (The
interface could be
a global variable, but some third-party module would
inevitably clear it.)
Looks fine, if there is indeed a need for it.
--
Nick
. I had the library,
but
no pcre-config, which was required for build. However, in the Mac case,
installing fink's current pcre fixed it.
--
Nick Kew
pointer
type
Could it be that you have different compiler flags, a stricter
gcc version, or perhaps a different architecture (like 32 vs 64-bit
compile)?
If not, a code sample that demonstrates what you're talking
about would help.
--
Nick Kew
Application Development with Apache - the Apache
that method=post
thing twice? The first call has consumed the post body. The second
will try to read something but the client has already sent all it can.
You'd want something like mod_request or mod_form to parse the data
and make them available to other modules in a convenient form.
--
Nick Kew
On Wed, 18 Mar 2009 08:44:12 -0400
Jim Jagielski j...@jagunet.com wrote:
doesn't mod_proxy_html do it's own substitutions :/
Only in a URL context.
Being markup-aware is what distinguishes it from the various
sed-like filter modules.
--
Nick Kew
Application Development with Apache
at apache.webthing.com.
The use of an ifdef in mod_proxy_html is probably fairly typical
of the sort of thing you might need to do. That is, provided
you don't hit an API that's changed significantly.
--
Nick Kew
even if it's already under the Apache
license,
we don't really want to fork someone else's project in competition with
the original developers. That leads to maintenance nightmares, and
confusion for end-users.
--
Nick Kew
to work around its shortcomings (as I did at the time).
--
Nick Kew
On 13 Mar 2009, at 10:21, Kevac Marko wrote:
https://issues.apache.org/bugzilla/show_bug.cgi?id=46827
Implemented. Patch added.
Comments?
Thanks. I'll test-drive today.
--
Nick Kew
Nick Kew wrote:
Kevac Marko wrote:
Ok, here is sql init statement only patch against trunk:
https://issues.apache.org/bugzilla/show_bug.cgi?id=46827
Thanks for the patch!
Can I throw an alternative suggestion into the ring.
[ ... ]
Thoughts?
A further thought. I had in mind PR#45407
opportunity to rectify all that!
Thoughts?
--
Nick Kew
.
Fixed in r750620.
--
Nick Kew
hacked mod_dumpio.
A function on the fixups hook, for instance.
BTW, this should really be on the modules list rather than here.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Thu, 26 Feb 2009 18:30:03 -0600
David Martínez Albiter dav...@insys-corp.com.mx wrote:
request_rec *r = f-r;
Dumpio is a connection-level filter. There is no request.
(and why do you suppose there'd be a cookie in r-notes?)
--
Nick Kew
Application Development with Apache - the Apache
the wheel. I
couldn't find any that existed. Thanks!
One of these should do the trick:
Alternatively, look in apr_uri. An apache module has access to
everything in apr and apr-util.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
is it?
Even if you fix that, you'll leak anything you allocate from it.
--
Nick Kew
. Likewise setting cfg-hash there is not thread-safe.
Would this be a good time to mention that my book has a Chinese
translation?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
, but it needs some testing before posting.
Sounds OK in principle for trunk. If you want to post a patch
against trunk, I'll try and find the time to review it.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
. You might export hooks, but let's have proper modularity
in the implementation.
The Simple MPM has the ability to do this.
Examples?
--
Nick Kew
release it.
We aren't going to release leader/perchild/threadpool.
If that ever changes, it has to be because at least one
committer is doing real work on it. Including sorting
out issues like dropping privileges.
--
Nick Kew
Paul Querna wrote:
imo, no one uses these mpms, we should delete them.
ISTR having this conversation ahead of 2.2. We deleted
them from 2.2 but left them in trunk for posterity,
and in case anyone felt like picking it up.
They look like obvious candidates for an attic now.
--
Nick Kew
On Wed, 28 Jan 2009 12:21:09 +0100
Nick Gearls nickgea...@gmail.com wrote:
Couldn't we just move the error_override_set error_override to
the proxy_dir_conf struct ?
There's more than that in mod_proxy that would be better on the
dir_conf. Patches welcome.
--
Nick Kew
be affected and misleading?
--
Nick Kew
traw...@gmail.com wrote:
On Jan 15, 2009 11:16am, Nick Kew n...@webthing.com wrote:
How do you propose to deal with configuration? Specifically,
the interaction with enable-exception-hook, which means that
a server built without it breaks the expectation that new
modules can
traw...@gmail.com wrote:
[+1] Accept mod_fcgid into httpd
+1
And Thanks! to the mod_fcgid author and contributors!
+1 to that, too.
--
Nick Kew
?rev=733219view=rev
-2.2.x:
- trunk works
-+1: covener, niq, rpluem
--
Nick Kew
Error. But a script
that generates
garbage is an External Server Error, and a 502 response would be in
order.
It would be no bad thing to point the finger of blame at broken scripts
rather than confuse the authors with internal errors.
--
Nick Kew
the upstream server or application.
r732504
--
Nick Kew
{
char *iov_base;
size_t iov_len;
};
#endif
--
Nick Kew
.
Sorry, yes, Jeff was right. Looking at what gets passed to the
vararg-consuming function, that's apr_size_t.
Jeff, you have my +1 to add r731965 to my backport proposal in STATUS.
--
Nick Kew
or the code is wrong.
Fixed in r731388, which is included in the backport proposal.
Thanks for reviewing.
--
Nick Kew
Ruediger Pluem wrote:
On 01/05/2009 02:16 PM, Nick Kew wrote:
Ruediger Pluem wrote:
Hm. I am slightly confused here. The documentation states that abort
should be
the default behaviour (that is the else branch), but if nothing is set
in the config
onfail defaults to -1 which would cause
for a CLA or software grant.
+1. This is in the same ballpark as third-party patches we routinely
accept, e.g. from reports in bugzilla.
--
Nick Kew
,
then on balance it's a Good Thing.
--
Nick Kew
one in r729438 (I
blame the lurgy - just on the mend). Fixed in r729439.
mod_sed is shaping up to be one of the best new goodies
in 2.4!
--
Nick Kew
modification to
every ChangeLog entry. (If anyone think any change is major, please
let me know)
On a quick skim-through, what looks like the only large patch here
belongs to Nick Kew, who's also an active httpd committer.
Hmmm, I know I've sent feedback to Ryan on mod_fcgid, but I really
didn't
.
- rename mod_wombat to mod_luau
- more documentation :)
Anything else anyone thinks would be good to get in?
Ensure non-*X platforms not only compile, but stand some
chance of running. As noted in
http://marc.info/?l=apache-httpd-devm=122878524712562w=2
--
Nick Kew
actually objects?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Tue, 9 Dec 2008 21:56:43 +
Nick Kew [EMAIL PROTECTED] wrote:
Does anyone have a complete list of people who have made nontrivial
contributions, such that their IP might be affected?
Ignore that - I meant to chop those lines when I read (as opposed
to skimmed) the following paragraphs
,
apr_pool_t *ptemp)
{
win_nt = (osver.dwPlatformId != VER_PLATFORM_WIN32_WINDOWS);
+ap_sys_privileges_handlers(1);
return OK;
}
--
Nick Kew
replacement for mod_unixd.
Seems like they would be good general statically linked defaults.
It needs to know there is *some* system privileges scheme in
operation and isn't running as unprotected root. But that's all.
--
Nick Kew
and
memory - of this proposal? That is, mod_wombat taken together with
lua and any other dependencies like apreq if used.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
it.
--
Nick Kew
:-)
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
] {
log this
type = HTTP_INTERNAL_SERVER_ERROR;
}
else {
return;
}
}
That looks good, too.
But do you see any objection to the (IMHO simpler) fix of
removing error buckets as we detect them?
--
Nick Kew
On 1 Dec 2008, at 08:17, Paul Querna wrote:
I've committed a few new modules to trunk tonight:
Interesting.
Are we expecting docs anytime soon?
--
Nick Kew
);
continue;
}
/*
--
Nick Kew
On 1 Dec 2008, at 10:19, Ruediger Pluem wrote:
if (eb) {
-ap_die(eb-status, r);
+int status;
+
+status = eb-status;
+apr_brigade_cleanup(b);
+ap_die(status, r);
return AP_FILTER_ERROR;
}
Good call. +1 to that.
--
Nick Kew
it in ap_http_header_filter. But I wonder if there are any
other edge-cases that might arise from that? If so, we
could perhaps _only_ delete a bucket if it is an
AP_FILTER_ERROR.
Thoughts?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Sun, 30 Nov 2008 18:22:39 -0500
Eric Covener [EMAIL PROTECTED] wrote:
On Sun, Nov 30, 2008 at 5:20 PM, Nick Kew [EMAIL PROTECTED] wrote:
In practice, the proposed fix looks good, and I want to
vote +1. I'm just a little concerned over whether we're
in danger of an infinite loop if we
Not sure what happened to this yesterday ... reposting.
Begin forwarded message:
Date: Fri, 28 Nov 2008 17:32:50 +
From: Nick Kew [EMAIL PROTECTED]
To: dev@httpd.apache.org
Subject: Re: Intent to Roll 2.3.0-alpha
Paul Querna wrote:
Hi dev@,
FYI, I intend to roll 2.3.0-alpha, our first
for telling us about your work. It's certainly interesting
enough that I'll have to find the time for a detailed look, and
see if I can build it on a linux box!
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
/mod_privileges.c
http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_privileges.xml
--
Nick Kew
Title: mod_privileges - Apache HTTP Server
Modules | Directives | FAQ | Glossary | Sitemap
Apache HTTP Server Version 2.3
Apache HTTP Server Documentation Version 2.3 Modules
that
you think that a backport should NOT be attempted?
No reason at all ... see above.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
is just whatever doesn't
belong in mod_unixd.
--
Nick Kew
work alongside it (additional functions)
or replace it entirely (other platforms under simple MPM, or
alternative security models such as perchild).
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
deliberately avoided that, because I'm planning updates that
may not apply to mod_cgid.
But on further thought, I can work around that, and it's cleaner
to take it out of unixd.h as you've just done.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
with a new
conventional module under arch/unix instead.
At least, that's the general idea.
--
Nick Kew
MPMs. Hacking on it now, but breakage is
likely for a while longer.
--
Nick Kew
On Tue, 4 Nov 2008 00:27:24 +
Nick Kew [EMAIL PROTECTED] wrote:
On Mon, 03 Nov 2008 14:49:21 -0800
Chris Darroch [EMAIL PROTECTED] wrote:
Hi --
I've been trying to get trunk to compile and run today, and
if I compile it without mod_unixd (and with the worker MPM) it
Thanks
everything goes into
the module, or some stuff remains in the old unixd. Just about to look
at Paul's update to that.
Simple MPM was just a good cue to actually do something. When simple
told me the User directive in httpd.conf was unrecognised
--
Nick Kew
rebuilding configure
NONE:0: m4: ERROR: EOF in string
autom4te: m4 failed with exit status: 1
A bit of googling suggests the culprit may be unbalanced
brackets or quotes somewhere in the M4, but I'm struggling
to find out where to look.
Any clues for hunting down the cause of this?
--
Nick Kew
,
and if we adopt mpm-simple we´ll want comparable system modules
for non-unixlike platforms there too.
--
Nick Kew
the symbols you need.
For future reference, the modules-dev list would be more on-topic
for this kind of question.
You might also want to check whether mod_session and family could be
relevant to your needs.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
is the equivalent on other platforms.
But is there any reason we shouldn't replace *each of* the above
functions with a hook?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
, this looks like more than one patch. The proxy_http
patch looks straightforward, but does the event MPM fix do anything?
I mean, does the scoreboard allocate memory per-request within
a connection? And if so, how does this affect other MPMs?
--
Nick Kew
to be applied conditionally on an
expression evaluated at runtime. That's work-in-progress and needs
revisiting, but it can use env vars in its expression evaluation,
and templating with them should be a natural future direction.
(and of course, you can always use mod_rewrite).
--
Nick Kew
);
-if (ap_extended_status)
-ap_time_process_request(c-sbh, STOP_PREQUEST);
+return ap_process_request_after_handler(r);
}
This is a compile error in a void function.
What exactly was intended here?
--
Nick Kew
On Fri, 5 Sep 2008 11:07:25 +0100
Armando Oliveira [EMAIL PROTECTED] wrote:
Hello
In the context of CVE-2008-2364 what is the meaning of interim
responses ? How can this affect apache ?
Section 10.1 of RFC2616.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
makes sense in this instance. Evidently
not everyone agrees. Bottom line: if you're doing the work, then
you decide what approach you prefer.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
in mod_sed...
Anecdotal and benchmark data suggest that it's competitive
in performance terms. Now that it's in svn, we can further
improve it. Ruediger's comments look like a start on that.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
things?
--
Nick Kew
solution than a new directive.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Tue, 26 Aug 2008 23:31:25 +0200
Ruediger Pluem [EMAIL PROTECTED] wrote:
[chop]
Bah. Thanks for spotting that.
Just trying to clean up my repo here - going through differences
between /trunk/ and mine and either committing or abandoning
local variants.
--
Nick Kew
Application Development
it, but as of
now it would seem lonely there. I wonder if there's a case for
modules/misc/ ?
--
Nick Kew
(that's what processing hooks are for), and the sysop shouldn't
have to configure it.
Does something bad happen if you put the check in a post_read_request
hook instead?
--
Nick Kew
provides seems to be a strict subset of mod_sed ?
That's a decision that can wait for 2.4, by which time we should have
more user feedback to base it on.
--
Nick Kew
501 - 600 of 1431 matches
Mail list logo
