On Tue, Apr 1, 2014 at 8:00 PM, Yann Ylavic ylavic@gmail.com wrote:
+static int parse_mime_headers(request_rec *r,
+ apr_bucket_brigade *bb,
+ apr_read_type_e block,
+ ap_filter_t *f, apr_table_t *t
On Tue, Apr 1, 2014 at 8:36 PM, Eric Covener cove...@gmail.com wrote:
On Tue, Apr 1, 2014 at 2:00 PM, Yann Ylavic ylavic@gmail.com wrote:
Here is the corresponding patch.
I don't know if it's your mail client or mine (gmail), your patches always
come through as both an attachment
Hi Mike,
On Tue, Apr 1, 2014 at 9:21 PM, Mike Rumph mike.ru...@oracle.com wrote:
Comment included below.
On 4/1/2014 11:00 AM, Yann Ylavic wrote:
Index: modules/examples/mod_example_hooks.c
===
--- modules/examples
On Tue, Apr 1, 2014 at 8:00 PM, Yann Ylavic ylavic@gmail.com wrote:
Here is the corresponding patch.
+static int parse_mime_headers(request_rec *r,
+ apr_bucket_brigade *bb,
+ apr_read_type_e block
On Tue, Apr 1, 2014 at 11:35 PM, Yann Ylavic ylavic@gmail.com wrote:
On Tue, Apr 1, 2014 at 8:36 PM, Eric Covener cove...@gmail.com wrote:
Can you say roughly how much it has changed, I was largely through a review
of the previous patch.
Actually, aside from funcs/vars/params renaming
Done in r1584098.
On Wed, Apr 2, 2014 at 8:21 AM, Kaspar Brand httpd-dev.2...@velox.ch wrote:
On 30.03.2014 21:25, yla...@apache.org wrote:
Author: ylavic
Date: Sun Mar 30 19:25:20 2014
New Revision: 1583191
URL: http://svn.apache.org/r1583191
Log:
mod_ssl: send OCSP request's nonce
On Wed, Apr 2, 2014 at 7:21 PM, yla...@apache.org wrote:
Author: ylavic
Date: Wed Apr 2 17:21:28 2014
New Revision: 1584098
URL: http://svn.apache.org/r1584098
Log:
mod_ssl: follow up to r1583191.
New SSLOCSPUseRequestNonce directive's manual and CHANGES.
[snip]
Modified:
On Fri, Apr 4, 2014 at 9:21 AM, Ruediger Pluem rpl...@apache.org wrote:
Eric Covener wrote:
On Thu, Apr 3, 2014 at 7:06 PM, Yann Ylavic yla...@apache.org
mailto:yla...@apache.org wrote:
+compatibilityAvailable in httpd 2.4.10 and later, if using OpenSSL
0.9.7 or later/compatibility
On Fri, Apr 4, 2014 at 9:55 AM, Yann Ylavic ylavic@gmail.com wrote:
I can now remove this requirement from all...
And maybe the availability in httpd 2.3 and later too.
On Fri, Apr 4, 2014 at 9:57 AM, Yann Ylavic ylavic@gmail.com wrote:
On Fri, Apr 4, 2014 at 9:55 AM, Yann Ylavic ylavic@gmail.com wrote:
I can now remove this requirement from all...
And maybe the availability in httpd 2.3 and later too.
Done in r1584555.
On Fri, Apr 4, 2014 at 1:35 PM, Eric Covener cove...@gmail.com wrote:
FYI not necessary to propose docs-only changes in STATUS, they are CTR.
Oh, I see, thanks for the information.
Should I (or one) backport it if no one else screams for a while then?
On Fri, Apr 4, 2014 at 1:15 PM, Eric Covener cove...@gmail.com wrote:
However this is another part of the escaping here that is wrong half the
time. It you're not substituting into the query string, we want c2x.
Agreed, POST vars spaces (application/x-www-form-urlencoded) for
example should be
Helo,
I revive this thread since headers in modfied by mod_proxy seems wrong
to me, I have to take that into account when, say, analysing access
logs (received X-Forwarded-* or Via headers vs the ones added by
mod_proxy, see also PR 45387), or as said in the title, which is even
worse when
On Fri, Apr 4, 2014 at 6:14 PM, Miguel Villarreal
miguel_villarrea...@hotmail.com wrote:
Where can I get the C code of a specific module in Apache?
The sources archives of released versions are available from download
page: http://httpd.apache.org/download.cgi.
If you want the dev version
On Fri, Apr 4, 2014 at 6:22 PM, Jim Jagielski j...@jagunet.com wrote:
This seems to change some logic which appear only tangentially
associated w/ the save headers issue... why is that?
Do you mean, ...
On Apr 4, 2014, at 11:43 AM, Yann Ylavic ylavic@gmail.com wrote:
Index: modules
Here is the patch not polluted by working collisions or gotos :
Index: modules/proxy/mod_proxy_wstunnel.c
===
--- modules/proxy/mod_proxy_wstunnel.c(revision 1584652)
+++ modules/proxy/mod_proxy_wstunnel.c(working copy)
@@
Hi,
this is the day of resurrections :p
I think I've got a simpler way to address this issue, that is, don't
send unexpected 100-continue to clients due to proxy ping feature.
Here is the patch.
Once again, please object if you don't want me to commit this stuff.
Reagrds,
Yann.
Index:
On Fri, Apr 4, 2014 at 8:38 PM, Ruediger Pluem rpl...@apache.org wrote:
Why can't we fix that directly in ap_proxy_create_hdrbrgd?
Actually we can, and that's indeed a much simpler patch.
I was worried about modifications of Content-Length and/or
Transfer-Encoding outside
On Fri, Apr 4, 2014 at 7:52 PM, Jim Jagielski j...@jagunet.com wrote:
Is there any way to accomplish w/o using notes? It's not that
they are especially slow, it's just that they aren't that fast
and, iirc, this could be a tight path.
There surely is, but we can't use the proxy_conn_rec for
On Fri, Apr 4, 2014 at 9:35 PM, Marion Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
Just in case, removal of compatibility notes against 2.3.x has been
discussed a few months ago.
See http://marc.info/?t=13861912831r=1w=2
No real concensus about it.
Ouch, I already backported
Thanks, promoted in r1586125.
On Wed, Apr 9, 2014 at 7:15 PM, Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
Hi,
this is already in the proposal list, first one at the top, just waiting for
a last vote to be accepted.
CJ
Le 07/04/2014 11:24, yla...@apache.org a écrit :
Author:
Hi,
I want to use :
ap_mpm_query(AP_MPMQ_MAX_DAEMON_USED, num_children)
at runtime (in a module) to take some maintenance actions accordingly.
Unfortunately, this (retained) data are updated by the parent process
without any visibility from the children.
So I wrote the attached patch to put
I usually force it with ./configure LDFLAGS=-Wl,-rpath
-Wl,/path/to/my/openssl.
+1 to have this automagically done according to --with-ssl.
On Mon, Apr 14, 2014 at 1:08 PM, Jeff Trawick traw...@gmail.com wrote:
(not to say there aren't complications, like trying to keep system
directories out
On Wed, Apr 16, 2014 at 1:59 AM, Yann Ylavic ylavic@gmail.com wrote:
Oh, didn't mean to vote -1, just wanted to add a note on the stuff
being worked that could be integrated in the backport.
I am (re)working on this currently.
Oh, didn't mean to vote -1, just wanted to add a note on the stuff
being worked that could be integrated in the backport.
I can make another proposal anyway, sorry for the noise.
Corrected in r1587758.
On Tue, Apr 15, 2014 at 9:21 PM, Jim Jagielski j...@jagunet.com wrote:
On Apr 15, 2014, at
On Sat, Apr 5, 2014 at 2:57 PM, kbr...@apache.org wrote:
Author: kbrand
Date: Sat Apr 5 12:57:43 2014
New Revision: 1585090
URL: http://svn.apache.org/r1585090
Log:
Bring SNI behavior into better conformance with RFC 6066:
- no longer send a warning-level unrecognized_name(112) alert
On Wed, Apr 16, 2014 at 2:41 PM, Plüm, Rüdiger, Vodafone Group
ruediger.pl...@vodafone.com wrote:
-Original Message-
From: Yann Ylavic [mailto:ylavic@gmail.com]
This base_server directive would help prevent vhost misuse at the
source, whatever the vhosts' configs are, and however
On Wed, Apr 16, 2014 at 3:11 PM, Plüm, Rüdiger, Vodafone Group
ruediger.pl...@vodafone.com wrote:
-Original Message-
From: Yann Ylavic [mailto:ylavic@gmail.com]
Sent: Mittwoch, 16. April 2014 15:00
To: httpd
Subject: Re: svn commit: r1585090 - in /httpd/httpd/trunk: CHANGES
On Wed, Apr 16, 2014 at 4:00 PM, Yann Ylavic ylavic@gmail.com wrote:
will pass through (unless this vhost has a ServerName and
UseCanonicalName is on, which would result in a 400).
UseCanonicalName isn't relevant here, r-hostname (and not
ap_get_server_name()) is used for the check, so SNI
On Tue, Apr 15, 2014 at 9:15 PM, j...@apache.org wrote:
Author: jim
Date: Tue Apr 15 19:15:02 2014
New Revision: 1587695
URL: http://svn.apache.org/r1587695
Log:
Merge r1546759, r1546760 from trunk:
Add suspend_connection and resume_connection hooks to notify modules
when the
On Thu, Apr 17, 2014 at 4:06 PM, Jeff Trawick traw...@gmail.com wrote:
Ahh, 2.4.x needs the cleanup in trunk to avoid that mess:
Yes, exactly, DEFAULT_HOOK_STRUCT is duplicated in 2.4.x, not in trunk...
Works now, thanks.
On Thu, Apr 17, 2014 at 4:06 PM, Jeff Trawick traw...@gmail.com wrote:
On Thu, Apr 17, 2014 at 10:02 AM, Jeff Trawick traw...@gmail.com wrote:
On Thu, Apr 17, 2014 at 9:47 AM, Yann Ylavic ylavic@gmail.com wrote:
On Tue, Apr 15, 2014 at 9:15 PM, j...@apache.org wrote
On Fri, Apr 18, 2014 at 10:34 AM, Kaspar Brand httpd-dev.2...@velox.ch wrote:
On 16.04.2014 16:00, Yann Ylavic wrote:
Before this commit, the client knew it was not reaching any vhost by
receiving an SSL alert (warning), and could stop.
In practice, most SNI-capable clients have ignored
On Tue, Feb 25, 2014 at 6:18 PM, Yann Ylavic ylavic@gmail.com wrote:
On Tue, Feb 25, 2014 at 4:21 PM, Jim Jagielski j...@jagunet.com wrote:
Of course, this doesn't mean that Yann should wait for
me... you seem to have a good grasp.
I'm coming back here...
After spending some time
Patch inline.
Index: modules/proxy/mod_proxy.h
===
--- modules/proxy/mod_proxy.h(revision 1588466)
+++ modules/proxy/mod_proxy.h(working copy)
@@ -605,23 +605,60 @@ typedef __declspec(dllimport) const char *
/* Connection
Helo,
shouldn't mod_proxy_connect's transfer loop be modified like
mod_proxy_wstunnel's one, since the latter has new fixes in 2.4.10 and
the former still uses the old code?
Also, it could benefit from socket_callback improvements (and current
coverner's work) that are already in wstunnel, to
On Fri, Apr 18, 2014 at 5:57 PM, Yann Ylavic ylavic@gmail.com wrote:
Patch inline.
Index: modules/proxy/proxy_util.c
===
--- modules/proxy/proxy_util.c(revision 1588466)
+++ modules/proxy/proxy_util.c(working copy
On Fri, Apr 4, 2014 at 7:52 PM, Jim Jagielski j...@jagunet.com wrote:
Is there any way to accomplish w/o using notes? It's not that
they are especially slow, it's just that they aren't that fast
and, iirc, this could be a tight path.
Simpler solution commited in r1588519.
We don't have to
Thanks for your comments.
Commited in r1588527.
On Fri, Apr 4, 2014 at 11:39 PM, Yann Ylavic ylavic@gmail.com wrote:
On Fri, Apr 4, 2014 at 8:38 PM, Ruediger Pluem rpl...@apache.org wrote:
Why can't we fix that directly in ap_proxy_create_hdrbrgd?
Actually we can, and that's indeed
On Tue, Apr 22, 2014 at 9:47 AM, Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
The first part of the comment, against 'ap_os_escape_path', is, IMO, wrong.
We are not guaranteed that, if partial is *not* set, that there will be one
byte of additional space after the NUL.
If partial
On Mon, Apr 21, 2014 at 8:39 AM, kbr...@apache.org wrote:
Author: kbrand
Date: Mon Apr 21 06:39:24 2014
New Revision: 1588851
URL: http://svn.apache.org/r1588851
Log:
ssl_callback_TmpDH: for OpenSSL 1.0.2 and later, set the current cert to the
one actually used for the connection before
Hello,
with the following (chained) configuration :
VirtualHost 127.0.0.1:80
ServerName reverse-proxy
ProxyPass / https://backend:443/
ProxyRemote * http://proxy:8080
#ProxyRequests off
/VirtualHost
VirtualHost 127.0.0.1:8080
ServerName forward-proxy
ProxyRequests on
On Thu, Apr 24, 2014 at 3:29 PM, Plüm, Rüdiger, Vodafone Group
ruediger.pl...@vodafone.com wrote:
IMHO this is a flaw of the backend as IMHO full URL's are allowed also in non
proxy cases by the RFC.
I agree, but I can't do anything on the (broken) backend side, proxy only...
I can live with
On Thu, Apr 24, 2014 at 3:37 PM, Yann Ylavic ylavic@gmail.com wrote:
On Thu, Apr 24, 2014 at 3:29 PM, Plüm, Rüdiger, Vodafone Group
ruediger.pl...@vodafone.com wrote:
IMHO this is a flaw of the backend as IMHO full URL's are allowed also in
non proxy cases by the RFC.
I agree, but I
Hi Jan,
sorry for the late.
On Tue, Apr 22, 2014 at 3:39 PM, Jan Kaluža jkal...@redhat.com wrote:
Hi again,
the patch has been here for some time already. I hesitate to commit it to
trunk without any review, because it changes the core code in mod_proxy and
I'm afraid that there could exist
Hi Chriss,
you should create new bug(zilla) entries for these two (even if the
second was fixed for you, there are other cases where retrying the
request may not do the right thing).
On Sun, Apr 27, 2014 at 10:59 AM, d...@bcs-frankfurt.de wrote:
[cache:debug] [...] cache_storage.c(664): ...
On Tue, Apr 29, 2014 at 3:51 PM, Jim Jagielski j...@jagunet.com wrote:
On Apr 29, 2014, at 8:41 AM, Jan Kaluža jkal...@redhat.com wrote:
Because later we have to match the URL of request with some proxy_worker.
If you configure ProxyPassMatch like this:
ProxyPassMatch ^/test/(\d+)/foo.jpg
On Tue, Apr 29, 2014 at 10:54 PM, Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
Hi,
doc does not build because of SITENAME below:
CJ
Le 25/04/2014 13:14, minf...@apache.org a écrit :
+highlight language=config
+lt;LocationMatch ^/dav/(?SITENAME[^/]+)/gt;
On Mon, Apr 28, 2014 at 4:57 PM, Graham Leggett minf...@sharp.fm wrote:
Oddly enough I encountered the same bug this week while trying to trace an
unrelated uncacheable 304. +1 to the patch.
Thanks for testing/reviewing.
Commited in r1591143.
On Wed, Apr 30, 2014 at 12:53 AM, Yann Ylavic ylavic@gmail.com wrote:
Still another solution for these workers would be to reuse the
ap_regmatch_t vector from proxy_trans() to exact match the worker's
name (with its zero or more $N replaced with strings offsets from
vector[N], like
-- Forwarded message --
From: Yann Ylavic ylavic@gmail.com
Date: Wed, Apr 30, 2014 at 11:59 AM
Subject: Re: apr_socket_opt_set always sets TCP_DEFER_ACCEPT to 1
To: APR Developer List d...@apr.apache.org
On Tue, Apr 29, 2014 at 5:41 PM, Jim Jagielski j...@jagunet.com wrote
On Wed, Apr 30, 2014 at 12:54 PM, Yann Ylavic ylavic@gmail.com wrote:
One second is too low imo (cf. PR above).
Backport proposed in 2.2.x/STATUS (r1591248).
On Wed, Apr 30, 2014 at 3:16 PM, Brian J. France br...@brianfrance.com wrote:
On Apr 30, 2014, at 6:54 AM, Yann Ylavic ylavic@gmail.com wrote:
One second is too low imo (cf. PR above).
Yes, 1 is way to low, even 60 doesn't help us with the RHEL 6 kernel bug.
I am trying to get time
Yes, thanks, reverted.
I'll try to commit the good files now ;)
On Wed, Apr 30, 2014 at 4:20 PM, Eric Covener cove...@gmail.com wrote:
On Wed, Apr 30, 2014 at 10:19 AM, Eric Covener cove...@gmail.com wrote:
On Wed, Apr 30, 2014 at 10:14 AM, yla...@apache.org wrote:
---
On Tue, May 6, 2014 at 1:41 PM, Eric Covener cove...@gmail.com wrote:
I'd really like to start chucking trailers, but the scale of these
patches really frightens me for 2.4 and 2.2 and accompanying what will
likely be a security roll-up.
Understood.
Is anyone sitting on a more tactical
On Mon, May 5, 2014 at 3:27 PM, Eric Covener cove...@gmail.com wrote:
Trying to get my 2.4.x reviews in.
Maybe I'm misunderstanding the change, but wasn't the previous
behavior more desirable?
If the entry were within its expiry, those same headers wouldn't have
been sent to the client
On Fri, May 9, 2014 at 5:01 PM, Edward Lu chaos...@gmail.com wrote:
Here's a 2.2.x backport of Yann's patch with a directive, MergeTrailers,
added in to opt-in to the old behavior. By default, it doesn't merge the
trailers. I'm working on adding the capability to mod_log_config to log the
On Sun, May 11, 2014 at 6:35 PM, Yann Ylavic ylavic@gmail.com wrote:
Restoring the status and notes (set before the body is read) seems
unconditional to me.
Well, actually I'm not really sure whether we should preserve or
overwritte the error-notes here.
In most cases
On Tue, May 13, 2014 at 9:20 AM, Ruediger Pluem rpl...@apache.org wrote:
Daniel Ruggeri wrote:
On 5/12/2014 7:31 AM, Ruediger Pluem wrote:
While trying to use the failonstatus option of a balancer for the first
time I noticed that it only works on status
codes provided by the backend not on
On Mon, May 12, 2014 at 7:03 PM, Edward Lu chaos...@gmail.com wrote:
Both the things you caught were probably just errors I made in manually
merging the patch into 2.2.x; here's a revised version, just in case.
Looks good, but you did not address Eric's comment about parsing the
trailers
I did not realize your mail is 8 days old, I just received it -- gmail
is having fun these days :(
Sorry for this misunderstanding and the reply that goes along...
Regards,
Yann.
On Wed, May 7, 2014 at 11:47 AM, Joe Orton jor...@redhat.com wrote:
I hacked the attached up yesterday, before seeing Yann's mail, untested.
The patch looks good (against 2.4.x), but as I said to Edward, I think
r-status should be restored (at least, error-notes probably too)
when r-proxyreq ==
Proposed for backport into 2.4.x.
On Sun, May 18, 2014 at 10:49 PM, ryo takatsuki ryotakats...@gmail.com wrote:
+1 to that :).
Juanjo.
2014-05-16 20:14 GMT+02:00 David Zuelke d...@heroku.com:
Hi all,
is there any chance to get
http://svn.apache.org/viewvc?view=revisionrevision=1573626
Hello,
while working on
https://issues.apache.org/bugzilla/show_bug.cgi?id=56226 for a
possible way to use vhost's KeepAliveTimeout with mpm_event (by using
a skiplist instead of the actual keepalive queue), I realized that
apr_skiplists do not accept multiple values per key (unlike apr_table
for
On Tue, May 27, 2014 at 10:33 PM, Ruediger Pluem rpl...@apache.org wrote:
#define make_get_dh(rfc,size,gen) \
static DH *get_dh##size(void) \
@@ -1339,7 +1344,7 @@
DH_free(dh_tmp); \
return NULL; \
} \
-dh = dh_tmp; \
+apr_atomic_xchgptr((volatile void
On Wed, May 28, 2014 at 9:18 AM, Plüm, Rüdiger, Vodafone Group
ruediger.pl...@vodafone.com wrote:
-Original Message-
From: Yann Ylavic [mailto:ylavic@gmail.com]
Sent: Mittwoch, 28. Mai 2014 01:25
To: httpd
Subject: Re: Memory leak in mod_ssl ssl_callback_TmpDH
On Tue, May 27
On Thu, May 29, 2014 at 7:14 PM, Graham Leggett minf...@sharp.fm wrote:
Ring any bells?
I noticed in [1] that no mod_ssl log callback was set on the write
side of the SSL connection (wbio).
That probably only concerns network events/errors, but maybe the patch
proposed there can help.
The
Argh, it seems that module/proxy/scgi.h is missing in 2.4.x (added in
trunk by r1592615), hence :
proxy_util.c:25:18: error: scgi.h: No such file or directory
proxy_util.c:3491: error: ‘SCGI_DEF_PORT’ undeclared here (not in a function)
On Tue, Jun 3, 2014 at 2:14 PM, j...@apache.org wrote:
This has been revert by r1601290 for lack of discussion/agreement on dev@.
Is there any reason why event and eventopt use the same APLOGNOs (eg.
eventopt will be become event some day) or should I recommit this?
What I did was just :
$ for n in `make update-log-tags 21 |grep Duplicate
Salut(ations),
On Tue, Jun 10, 2014 at 7:05 AM, Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
the same kind of code can also be found in:
proxy/mod_proxy_ftp.c
echo/mod_echo.c
Indeed thanks, done in r1601624, with some others.
On Tue, Jun 10, 2014 at 2:46 PM, Takashi Sato taka...@tks.st wrote:
r1601291 causes SEGV.
# Failed test 2 in t/ssl/proxy.t at line 56
# Failed test 115 in t/ssl/proxy.t at line 56 fail #3
[ error] oh gosh, server dumped core
[ error] for stacktrace, run: gdb
On Tue, Jun 10, 2014 at 3:02 PM, Plüm, Rüdiger, Vodafone Group
ruediger.pl...@vodafone.com wrote:
-Original Message-
From: Takashi Sato [mailto:taka...@tks.st]
Sent: Dienstag, 10. Juni 2014 14:47
To: dev@httpd.apache.org
Subject: Re: svn commit: r1601291 - in /httpd/httpd/trunk:
Fixed in r1601630.
On Tue, Jun 10, 2014 at 3:06 PM, Yann Ylavic ylavic@gmail.com wrote:
On Tue, Jun 10, 2014 at 3:02 PM, Plüm, Rüdiger, Vodafone Group
ruediger.pl...@vodafone.com wrote:
-Original Message-
From: Takashi Sato [mailto:taka...@tks.st]
Sent: Dienstag, 10. Juni 2014
On Sun, Jun 1, 2014 at 8:54 AM, jaillet...@apache.org wrote:
Author: jailletc36
Date: Sun Jun 1 06:54:15 2014
New Revision: 1598946
URL: http://svn.apache.org/r1598946
Log:
Fix computation of the size of 'struct sockaddr_un' when passed to 'connec()'.
s/connec()/connect()/
Use the same
On Wed, Jun 11, 2014 at 2:51 PM, Jim Jagielski j...@jagunet.com wrote:
So how about 'passthru' as the special scheme? Or
maybe just 'pass', 'scheme' or even 'glob' ??
Simply 'proxy'? Which would not be filenamed to proxy:proxy: but to
proxy:${ap_http_scheme(r)}:?
Otherwise, +1 for 'passthru'.
Oh yes, good point!
I prefer 'passthru' then.
On Wed, Jun 11, 2014 at 3:22 PM, Jim Jagielski j...@jagunet.com wrote:
The reason I didn't use proxy is that we use 'proxy' internally
and we now expose that via allowing its use as a handler...
On Jun 11, 2014, at 9:09 AM, Yann Ylavic ylavic
On Wed, Jun 11, 2014 at 3:37 PM, Eric Covener cove...@gmail.com wrote:
auto? Then e.g. proxy_ws can check for auto Upgrade header.
I'm fine with auto too ( since I definitively like C++11 :p ).
Thanks for the review.
On Thu, Jun 12, 2014 at 9:13 AM, Ruediger Pluem rpl...@apache.org wrote:
yla...@apache.org wrote:
Author: ylavic
Date: Wed Jun 11 12:50:29 2014
New Revision: 1601877
URL: http://svn.apache.org/r1601877
Log:
mod_sed: Reuse ctx-bb in sed_response_filter() and be
On Thu, Jun 12, 2014 at 10:30 PM, Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
Le 10/06/2014 18:19, Yann Ylavic a écrit :
On Sun, Jun 1, 2014 at 8:54 AM, jaillet...@apache.org wrote:
/* TODO: In APR 2.x: Extend apr_sockaddr_t to possibly be a path !!! */
+/* XXX: The same
On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic ylavic@gmail.com wrote:
The most important imho is to not truncate the length at sizeof(struct
sockaddr_un) when the real sun_path is beyond sizeof(sun_path).
The libc calls are probably bullet proof regarding NUL termination
(eg. force ((char
On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic ylavic@gmail.com wrote:
On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic ylavic@gmail.com wrote:
The most important imho is to not truncate the length at sizeof(struct
sockaddr_un) when the real sun_path is beyond sizeof(sun_path).
The libc
On Fri, Jun 13, 2014 at 1:20 AM, Yann Ylavic ylavic@gmail.com wrote:
On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic ylavic@gmail.com wrote:
On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic ylavic@gmail.com wrote:
The most important imho is to not truncate the length at sizeof(struct
+1
On Fri, Jun 13, 2014 at 4:05 PM, Jim Jagielski j...@jagunet.com wrote:
Does it make sense to setup a CI for the 2.4 branch and
trunk builds of httpd such that after each commit, the system
makes sure that it at least builds?
I know I am guilty of making and committing simple changes
w/o
On Fri, Jun 13, 2014 at 5:19 PM, Eric Covener cove...@gmail.com wrote:
On Fri, Jun 13, 2014 at 11:03 AM, Plüm, Rüdiger, Vodafone Group
ruediger.pl...@vodafone.com wrote:
I would prefer to keep SSLSessionCacheTimeout the only directive and use
that also for the default timeout of any created
Applied in r1602989.
On Fri, Jun 13, 2014 at 1:45 AM, Yann Ylavic ylavic@gmail.com wrote:
On Fri, Jun 13, 2014 at 1:20 AM, Yann Ylavic ylavic@gmail.com wrote:
On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic ylavic@gmail.com wrote:
On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic ylavic
Dumpleton grahamd apache org, Christophe Jaillet,
+ Yann Ylavic]
trunk patch: http://svn.apache.org/r1598946
- 2.4.x patch: trunk works (modulo CHANGES)
- +1: jailletc36
+ http://svn.apache.org/r1602989
+ 2.4.x patch:
http://people.apache.org
thanks, done in r1603115.
On Tue, Jun 17, 2014 at 11:31 AM, Marion et Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
Hi,
obviously, no problem for me for merging the 2 in the same proposal.
I'll have a look at it tonight.
CJ
Message du 17/06/14 10:02
De : Yann Ylavic
On Tue, Jun 17, 2014 at 11:19 AM, Daniel Gruno rum...@cord.dk wrote:
I have tried to incorporate your suggestions into my own proposal, and
the result can be seen at http://httpd.apache.pw/index2
I really like this version, +1 for me.
However, as André, I'd also like the ability to download
On Thu, Jun 19, 2014 at 2:59 PM, Jim Jagielski j...@jagunet.com wrote:
On Jun 19, 2014, at 8:43 AM, yla...@apache.org wrote:
Author: ylavic
Date: Thu Jun 19 12:43:05 2014
New Revision: 1603863
URL: http://svn.apache.org/r1603863
Log:
Use unsigned bit flags (otherwise the non-zero value
On Thu, Jun 19, 2014 at 6:36 PM, Jeff Trawick traw...@gmail.com wrote:
On Mon, Jun 16, 2014 at 4:26 PM, yla...@apache.org wrote:
Author: ylavic
Date: Mon Jun 16 20:26:24 2014
New Revision: 1602989
URL: http://svn.apache.org/r1602989
Log:
mod_proxy: Don't limit the size of the connectable
Thanks for your patch (and patience).
Commited in http://svn.apache.org/r1604123.
On Fri, Jun 20, 2014 at 11:40 AM, Mario Brandt jbl...@gmail.com wrote:
Hi,
I had filed a bug[1] about mod fcgid polluting my apache error log.
So far no commiter had reviewed my patch.
Can someone please take
? You either check if it's
true/false or you use the expected bit operations.
On Jun 19, 2014, at 9:29 AM, Yann Ylavic ylavic@gmail.com wrote:
On Thu, Jun 19, 2014 at 2:59 PM, Jim Jagielski j...@jagunet.com wrote:
On Jun 19, 2014, at 8:43 AM, yla...@apache.org wrote:
Author: ylavic
Date
On Sat, Jun 21, 2014 at 3:18 PM, Eric Covener cove...@gmail.com wrote:
was the proxy_util.c change intended?
Yes, this is to avoid another (useless) socket_cleanup() + close = 0 below.
On Sat, Jun 21, 2014 at 11:24 PM, Jeff Trawick traw...@gmail.com wrote:
On Sat, Jun 21, 2014 at 4:49 PM, Marion Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
Hi,
doc should also be updated accordingly + compatibility note should be
added to state in which version this -m option
On Tue, Jun 24, 2014 at 8:40 PM, Jim Jagielski j...@jagunet.com wrote:
I'm hoping to encourage us to push out the next 2.4 release within
the next coupla weeks, maybe after the July 4th US-based
holiday.
Comments?
+1, thanks!
On Thu, Jun 26, 2014 at 9:22 AM, Ruediger Pluem rpl...@apache.org wrote:
But I just realize that a simple search and replace function is missing in
the expression parser.
So maybe hack that up an then go the way above?
+1, really nice to have.
On Tue, Jul 8, 2014 at 11:42 AM, jkal...@apache.org wrote:
@@ -279,8 +279,35 @@ static apr_status_t close_listeners_on_e
#ifdef HAVE_SYSTEMD
+static int find_systemd_socket(process_rec * process, apr_port_t port) {
+int fdcount, fd;
+int sdc = sd_listen_fds(0);
+
+if (sdc
On Wed, Jul 9, 2014 at 7:35 AM, Marion Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
Just a few details :
1) Shouldn't we use 100-continue (lowercase c) instead, to more closely
match http://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html, § 8.2.3 ?
This would also be
On Wed, Jul 9, 2014 at 12:56 PM, Yann Ylavic ylavic@gmail.com wrote:
On Wed, Jul 9, 2014 at 7:35 AM, Marion Christophe JAILLET
3) // fast path, should be /* fast path */
Thanks, will fix it.
Done in r1609100 (2.4.x) and r1609101 (trunk).
On Wed, Jul 9, 2014 at 2:12 PM, Graham Leggett minf...@sharp.fm wrote:
On 9 Jul 2014, at 11:56, Yann Ylavic ylavic@gmail.com wrote:
On Wed, Jul 9, 2014 at 7:35 AM, Marion Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
Just a few details :
1) Shouldn't we use 100-continue
201 - 300 of 2661 matches
Mail list logo
