Re: Internal classes are exposed in public API

2020-01-17 Thread Andrey Gura
t; Exporters expose metrics if they are disabled. > > We don’t have an ability to disable metrics. > And that done, intentionally. > You are working on this issue, aren’t you? > I can fix this issue, by myself. > > > Metrics of type lists are not metric at all. > > The

Re: Internal classes are exposed in public API

2020-01-17 Thread Andrey Gura
ly, it’s a responsibility of the exporter to decide. > JMX exporter can exports ObjectMetric while OpenCensus exporter can’t. > > [1] > https://github.com/apache/ignite/pull/7269/files#diff-0ae5657231fc4c1f650493b02190b81bR25 > > > 17 янв. 2020 г., в 16:57, Andrey Gura на

Re: Internal classes are exposed in public API

2020-01-17 Thread Andrey Gura
l haunt us till next major release. I'll create tickets. On Fri, Jan 17, 2020 at 7:03 PM Andrey Gura wrote: > > >> Because it is brand new API and it requires rewrite client code. > > We doesn’t break backward compatibility. > > The message is - this interface wo

Re: Internal classes are exposed in public API

2020-01-17 Thread Andrey Gura
osal for the API change and discuss them. > > > Because IGNITE-11927 doesn't solve all problems > > What is *ALL* problems? > Seems, we never be able to solve *ALL* problems. > But, we should move the product forward. > > As for your steps [1-6]. > I’m always followin

Re: [DISCUSSION] API to KILL any user started computation

2020-01-17 Thread Andrey Gura
It would be grate. Only one comment: we can't cancel service or service's method execution because service grid API doesn't imply any requirement to service implementation. So if user do something like infinite cycle or blocking but non-interruptible operation it's impossible to interrupt it. Also

Re: Internal classes are exposed in public API

2020-01-20 Thread Andrey Gura
cs. > 2. This is not public API issue. > > > > Ignoring of statisticsEnabled flag. > > I don’t ignore this flag. > It just doesn’t exists in new framework(because of scope). > I don’t think it’s an issue. > > > JmxExporterSpi creates beans that doesn't satisfy

Re: Internal classes are exposed in public API

2020-01-20 Thread Andrey Gura
ance problem). > > > > 1. We(You and I) did this choice together to simplify creation of the new > > metrics. > > 2. This is not public API issue. > > > > > > > Ignoring of statisticsEnabled flag. > > > > I don’t ignore this flag. > > It

Re: Internal classes are exposed in public API

2020-01-20 Thread Andrey Gura
gt; > > > Why this is issue? > > > > > > > > > Inconsistent MetricRegistry API. > > > > > > > > It’s consistent. > > > > > > > > > Metrics lookups from map instead of using direct reference > > > >

Re: Internal classes are exposed in public API

2020-01-20 Thread Andrey Gura
//issues.apache.org/jira/browse/IGNITE-12553 > > > > 20 янв. 2020 г., в 13:08, Andrey Gura написал(а): > > > > It solves problem. > > > > On Mon, Jan 20, 2020 at 12:09 PM Alexey Goncharuk > > wrote: > >> > >> After giving it some thought, I

Re: Internal classes are exposed in public API

2020-01-23 Thread Andrey Gura
to fix only the > >>>>> first one and add the experimental marker so that we do not delay 2.8 > >>>>> release. > >>>>> > >>>>> пн, 20 янв. 2020 г. в 13:32, Николай Ижиков : > >>>>> > >>>>>>

Re: Internal classes are exposed in public API

2020-01-23 Thread Andrey Gura
desired usages. > > This will help to the community and me personally better understand your idea > and share feedback. > > Thanks. > > > 23 янв. 2020 г., в 17:15, Andrey Gura написал(а): > > > > Nikolay, > > > > as I wrote early in this thread API si

Re: Internal classes are exposed in public API

2020-01-24 Thread Andrey Gura
; argument to postpone creation of the API in the current release. > > > > 23 янв. 2020 г., в 18:11, Andrey Gura написал(а): > > > >> We don’t discuss your changes and your proposals for the Metric API. > > > > You want say didn't discuss? Actually we di

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-27 Thread Andrey Gura
Igniters, I want to add one more issue to the Apache Ignite 2.8 release scope [1]. The problem is impossibility of using communication metrics gathered for nodes in the cluster because node ID will changed in case of restart. Obvious solution is using consistent ID instead of node ID. PR is alre

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-27 Thread Andrey Gura
there is no performance drop. > Note, that these metrics updated on each communication message. > > > 27 янв. 2020 г., в 18:19, Andrey Gura написал(а): > > > > Igniters, > > > > I want to add one more issue to the Apache Ignite 2.8 release scope [1]. > > &

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-27 Thread Andrey Gura
n > current master so we should change this code carefully > > https://github.com/apache/ignite/blob/ignite-2.7.6/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java#L1178 > > > 27 янв. 2020 г., в 20:40, Andrey Gura написал(а): > > &g

Re: Internal classes are exposed in public API

2020-01-27 Thread Andrey Gura
come back to the discussion of the changes itself? > >>> I think API changes should be discussed in the other thread. > >>> > >>>> Why do you think this is a wrong usage pattern? From the top of my > >> head, here is a few cases of direct met

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-27 Thread Andrey Gura
ave free servers to do > it. > > > > 27 янв. 2020 г., в 21:47, Andrey Gura написал(а): > > > >>> "If it doesn’t work, it doesn’t matter how fast it doesn’t work." (c) > >> Please, clarify, what do you mean by «doesn’t work»? > >> Are there

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-29 Thread Andrey Gura
ults > > > > > > I perform benchmarking for initial refactoring of > > TcpCommunicationMetricsListener. > > > Initial refactoring of TcpCommunicationMetricsListener doesn’t bring any > > performance drop according to the results of the tests I performed. >

Re: New channel about integration with Spring Framework

2020-01-29 Thread Andrey Gura
for Slack ) On Wed, Jan 29, 2020 at 8:17 PM Andrey Gura wrote: > > +1 > > > On Wed, Jan 29, 2020 at 7:59 PM Denis Magda wrote: > > > > Folks, why don't you name the channel "ignite-spring-framework_russian" in > > Slack ;) > > > > - &

Re: New channel about integration with Spring Framework

2020-01-29 Thread Andrey Gura
+1 On Wed, Jan 29, 2020 at 7:59 PM Denis Magda wrote: > > Folks, why don't you name the channel "ignite-spring-framework_russian" in > Slack ;) > > - > Denis > > > On Wed, Jan 29, 2020 at 12:50 AM Maksim Stepachev < > maksim.stepac...@gmail.com> wrote: > > > Yes, I do. > > > > ср, 29 янв. 2020 г

Re: Internal classes are exposed in public API

2020-01-30 Thread Andrey Gura
>From my point of view we still don't have consensus. I think we should do at least the following: 1. Remove @Deprecated from old API (because it strange to have one deprecated API and second experimental API) 2. Add @IgniteExperimetnal to new API (because... see item. 1) 3. Do not merge IGNITE-1

Re: Internal classes are exposed in public API

2020-01-30 Thread Andrey Gura
.dataregion.pageCount» > > Andrey. > > We doesn’t come to an agreement that API should be changed. > We should discuss the design of the Metric API and your proposals for it in > another thread. > > Please, avoid arguments like «this API will be 100% changed» in this >

Re: Internal classes are exposed in public API

2020-01-30 Thread Andrey Gura
I'll just repeat one thought with some changes. There are at least two groups of people in this discussion. One group sure that new API is complete and production ready while other group disagree with it. Obviously we can't reach consensus about it right now. But we can do it in the future. At pre

Re: Internal classes are exposed in public API

2020-02-03 Thread Andrey Gura
e deprecation for now and unblock the release. > > On Thu, Jan 30, 2020 at 10:23 PM Andrey Gura wrote: > > > I'll just repeat one thought with some changes. > > > > There are at least two groups of people in this discussion. One group > > sure that new API is c

Re: Contribution

2020-02-04 Thread Andrey Gura
Hi, Lev! I think you understand task correctly. A couple of comments: - Existing annotations and related functionality must not be deleted because it is part of public API and we committed to have stable API between major releases. - I would suggest introduce @MXBeanParameter annotation instead

Re: Contribution

2020-02-04 Thread Andrey Gura
ionality. > So, I can't change implementation of *getDescription / getParameterName > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from* > IgniteStandardMXBean* class, > and replace current annotations with new one. > > вт, 4 февр. 2020 г. в 14:28, Andrey Gura :

Re: Contribution

2020-02-04 Thread Andrey Gura
MXBeanParametersNames and MXBeanParametersDescriptions could be marked as deprecated if MXBeanParameter will be added. On Tue, Feb 4, 2020 at 5:12 PM Ivan Pavlukhin wrote: > > Should we mark old annotations deprecated? > > вт, 4 февр. 2020 г. в 16:57, Andrey Gura : > > >

Re: Contribution

2020-02-04 Thread Andrey Gura
d should I also replace usage of old annotations or leave it as it is? > > вт, 4 февр. 2020 г. в 16:57, Andrey Gura : > > > Lev, > > > > > I'm confused about your first comment. Does it mean, that the only thing > > I > > can do is to create new annotation? &g

Re: Contribution

2020-02-05 Thread Andrey Gura
rs. So, my question was the order of searching > annotations (first - old, after - new). > > вт, 4 февр. 2020 г. в 21:10, Andrey Gura : > > > > Andrey, then I suggest firstly check if old annotations are present, and > > if > > > not - are there any new annotat

Explicit plugin providers configuration issue

2020-02-05 Thread Andrey Gura
Anton, Mikhail, I stumbled upon impossibility to configure plugin with out adding appropriate class names to org.apache.ignite.plugin.PluginProvider file and found change where this possibility was added [1]. Thanks a lot for this change. I noticed also that IgniteConfiguration.setPluginProviders

Re: [DISCUSS] Public API deprecation rules

2020-02-06 Thread Andrey Gura
One comment about first choice. The formulation has one issue from my point of view: Never deprecate the old APIs unless the new APIs are stable *and released* without @IgniteExperimental. Actually we can introduce new stable API and deprecate old API at the same time without releasing of new API

Re: Explicit plugin providers configuration issue

2020-02-06 Thread Andrey Gura
re there any reasons to continue support > of the ServiceLoader approach, given the fact that configurations needed > for a plugin, in this case, are also specified via IgniteConfiguration? > Moreover, why someone should mix those approaches? > > On 05.02.2020 17:35, Andrey Gura wrote: > &g

Re: Mark MVCC with @IgniteExperimental

2020-02-06 Thread Andrey Gura
+1 By the way, is there any reason to have this code in the master branch? It seems feature is in unsupportable state and just wastes TC time and our effort to support MVCC related tests. On Thu, Feb 6, 2020 at 2:44 PM Alexey Goncharuk wrote: > > Agree, let's mark MVCC experimental. > > Stephen,

Re: Mark MVCC with @IgniteExperimental

2020-02-07 Thread Andrey Gura
> > > > If it does too much strain on the TC, let's discuss that, but I don't > > > > remember problems with TC load lately, so maybe this is a moot point. > > > > > > > > Regards, > > > > -- > > > > Ilya Kasnacheev > > > > > > >

Re: Mark MVCC with @IgniteExperimental

2020-02-07 Thread Andrey Gura
don't > > remember problems with TC load lately, so maybe this is a moot point. > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > чт, 6 февр. 2020 г. в 15:27, Nikolay Izhikov : > > > > > > By the way, is there any reason

Re: [VOTE] Allow or prohibit a joint use of @deprecated and @IgniteExperimental

2020-02-11 Thread Andrey Gura
-1 Prohibit On Mon, Feb 10, 2020 at 11:02 AM Alexey Goncharuk wrote: > > Dear Apache Ignite community, > > We would like to conduct a formal vote on the subject of whether to allow > or prohibit a joint existence of @deprecated annotation for an old API > and @IgniteExperimental [1] for a new (re

Re: IGNITE-10698 Task

2020-02-14 Thread Andrey Gura
Lev, it's enough to comment corresponding JIRA ticket. It already contains all needed info (links to PR, TC bot, etc) and also all changes to the ticket will be sent to the dev list. On Fri, Feb 14, 2020 at 1:31 PM Лев Киселев wrote: > > Hello everyone, > I've fixed codestyle issues in my branch

Re: [DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

2020-02-14 Thread Andrey Gura
I couldn't find any usages too. But value if this property is serialized in some places and we can't remove this due to a backward compatibility. I think we can safely remove it on 3.0. But for now it is better to mark it as deprecated. On Thu, Feb 13, 2020 at 5:42 PM Alexey Goncharuk wrote: >

Re: [DISCUSS] Relevance of pessimistic tx log properties in TransactionConfiguration

2020-02-14 Thread Andrey Gura
No ) The reasons is serialization of this field. We can mark it as deprecated and remove in 3.0. On Thu, Feb 13, 2020 at 6:08 PM Alexei Scherbakov wrote: > > I think yes. > > чт, 13 февр. 2020 г. в 16:52, Ivan Pavlukhin : > > > Hi, > > > > It seems I found some more unused configuration properti

Re: [jira] [Created] (IGNITE-6530) Deadlock in checkpointReadLock method in GridCacheDatabaseSharedManager

2020-02-25 Thread Andrey Gura
Agree with Andrey and Slava. Your change could lead to exception in case when current thread does not own read lock. > Checking for a writе lock holding through method isHeldByCurrentThread is not > atomic, so there is no certainty that this thread still owns a write lock. What do you mean when

Re: Reference of local service.

2020-03-05 Thread Andrey Gura
Hi there, what if we will generate proxy that collects service's metrics only if service will implement some special interface? In such case: - we won't affect existing services at all. - we can impose additional requirement for services that want use metrics out of box (i.e. service that impleme

Re: [DISCUSS] Targeting issues to 2.8.1

2020-03-10 Thread Andrey Gura
Ivan, targeting to specific version means that this change should be included in release with target fix version. No more, no less. On Wed, Mar 11, 2020 at 2:42 AM Ivan Pavlukhin wrote: > > Igniters, > > Initially I wanted to delay the discussion about everything related to > 2.8.1 until all 2.8

Re: Cache metrics on server nodes does not update correctly

2020-03-11 Thread Andrey Gura
r some bug with metrics aggregation during discovery metrics message round trip. On Wed, Mar 11, 2020 at 12:05 AM Denis Magda wrote: > > @Nikolay Izhikov , @Andrey Gura , > could you folks check out this thread? > > I have a feeling that what Dominik is describing was talked out

Re: [DISCUSS] Targeting issues to 2.8.1

2020-03-11 Thread Andrey Gura
nvalid for me. And I expect problems from such issues in the future. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12756 > > > > Best regards, > > Ivan Pavlukhin > > > > ср, 11 мар. 2020 г. в 03:23, Andrey Gura : > > > > > > Ivan, &

Re: Apache Ignite 2.8.1 RELEASE [Time, Scope, Manager]

2020-03-12 Thread Andrey Gura
Aleksey, > My propose: > ~ June 01 - 2.8.1 > ~ September 01 - 2.8.2 > ~ November 01 - 2.9.0 What is your motivation for such release schedule? I believe release should be features/fixes driven not by time/deadline driven. We can release 2.8.x versions every week yet (as maintenance releases). Bu

Re: Cache metrics on server nodes does not update correctly

2020-03-13 Thread Andrey Gura
never used it :) >> >> Also it would be great to know what version of Apache Ignite used in >> described case. I remember some bug with metrics aggregation during >> discovery metrics message round trip. >> >> On Wed, Mar 11, 2020 at 12:05 AM Denis Magda wrote:

Re: [DISCUSSION] Changes in Ignite release process related to documentation

2020-03-16 Thread Andrey Gura
Denis, I agree with you. Also I think that we should move to process which will require documentation updates during work on issue/feature and will part of code review process. Such approach has some useful benefits: - Documentation readiness at the same time when fix/implementation is ready (re

Re: Reference of local service.

2020-03-16 Thread Andrey Gura
ce#service() > > > - Make service metrics enabled by default for all services. > > > - Bring system param which disables metrics by default for all services. > > > - Bring parameter/method in MetricsMxBean which allows disabling/enabling > metrics for all servic

Re: Reference of local service.

2020-03-17 Thread Andrey Gura
not break backward compatibility and will always return proxy. > > Why not using IgniteServices.serviceProxy() for that? Since it requires an > interface, It could return proxy for local service too and > keep backward compatibility at the same time. > > 16.03.2020 20:21, Andrey Gura пишет: > &g

Commit message format

2020-03-19 Thread Andrey Gura
Igniters, please, notice that right commit message format the following: IGNITE- my message There is no colon (:) after . There is no hyphen (-) between and message. There is only one space. How to contribute doc [1] doesn't state this as requirement and just contains some examples

Re: Commit message format

2020-03-19 Thread Andrey Gura
/kafka/commits/trunk > [2] https://github.com/apache/hive/commits/trunk > [3] https://github.com/openjdk/jdk/commits/master > > Best regards, > Ivan Pavlukhin > > чт, 19 мар. 2020 г. в 23:15, Alexey Zinoviev : > > > > Ok, lets keep in mind and remind du

Re: Commit message format

2020-03-20 Thread Andrey Gura
all. > > > > And please answer the question from my previous message: > > > Is there any any harm from a "colon" in a commit message? > > > > In my opinion current state with commit messages prefixes is totally > > fine and there is no need to change any

Re: Apache Ignite 2.8.1 RELEASE [Time, Scope, Manager]

2020-04-21 Thread Andrey Gura
TcpCommunication SPI metrics > >> improvement" - it depends > >> on https://issues.apache.org/jira/browse/IGNITE-12735 and > >> https://issues.apache.org/jira/browse/IGNITE-12568, > >> both were targeted to 2.9, but this has to be changed probably. >

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Andrey Gura
Definitely agree with Alexey Goncharuk. Mentioned FH implementations don't terminate JVM. I think returning KILL_EXIT_CODE is bad idea because actually process wasn't terminated using SIGINT. So it contradicts to motivation described in proposal. Also how could it help to administrators. For exam

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Andrey Gura
Sergey, Anton, Kirill, I think we have to do not change anything in FH. At least without enough motivation. Now I see only assumption that it "could be helpful for administration purposes". It isn't enough, I believe. On Tue, Jun 2, 2020 at 4:59 PM ткаленко кирилл wrote: > > Hello, Alexey! > >

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Andrey Gura
t implementation StopNodeOrHaltFH uses Runtime#halt(). This method > doesn't cause shutdown hooks. Why we don't try to stop the node by > System#exit() before Runtime#halt()? > > > вт, 2 июн. 2020 г. в 17:18, Andrey Gura : > > > Sergey, Anton, Kirill, > >

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Andrey Gura
nvocation before Runtime#halt(). > > вт, 2 июн. 2020 г. в 17:51, Andrey Gura : > > > > Current implementation StopNodeOrHaltFH uses Runtime#halt(). This method > > > doesn't cause shutdown hooks. Why we don't try to stop the node by > > > System#exit()

Re: Incorrect example in Pull Request checklist: comma after ticket name in commit message

2020-06-03 Thread Andrey Gura
I've prepared PR [1] I already tried to discuss commit message format [2] but stumbled upon some criticism. I still believe that we have to follow only one standard. It is unrelated with any annoying. It is just normal practice which also allows avoid of precedents with references to any concessio

Re: Incorrect example in Pull Request checklist: comma after ticket name in commit message

2020-06-03 Thread Andrey Gura
t ok to continue like this, or do you think we should remove ":" here > as well? > > On Wed, Jun 3, 2020 at 4:38 PM Andrey Gura wrote: > > > I've prepared PR [1] > > > > I already tried to discuss commit message format [2] but stumbled upon > > some cr

Re: Incorrect example in Pull Request checklist: comma after ticket name in commit message

2020-06-05 Thread Andrey Gura
; > > > Can you merge it? > > > > Thanks, > > -- > > Ilya Kasnacheev > > > > > > ср, 3 июн. 2020 г. в 16:38, Andrey Gura : > > > > > I've prepared PR [1] > > > > > > I already tried to discuss commit message for

Re: [DISCUSS] Fix confusing "Used by" on GitHub

2020-06-10 Thread Andrey Gura
+1 I don't see any badges. On Wed, Jun 10, 2020 at 10:27 PM Ilya Kasnacheev wrote: > > Hello! > > I don't see such a badge. Instead I see "Watch" "Star" "Fork". > > Regards, > -- > Ilya Kasnacheev > > > ср, 10 июн. 2020 г. в 20:58, Ivan Pavlukhin : > > > Hi Igniters, > > > > I noticed that we ha

Re: Apache Ignite 2.9.0 RELEASE [Time, Scope, Manager]

2020-09-16 Thread Andrey Gura
display/IGNITE/How+to+Document >>> >>> On Thu, Sep 10, 2020 at 2:45 PM Alexey Goncharuk >>> wrote: >>>> >>>> Alexey, >>>> >>>> I've tried to play with message factories locally, but unfortunately, I >>>> cann

Re: Escaping dots in cache metric names

2020-09-18 Thread Andrey Gura
Alex, It seems that the described problem is not a problem at all. The mentioned reason (is not obvious what is a cache name and what is next hierarchical element) will exist forever. If we will replace dots by underscores (or escaped dots, or something else) still will exist the possibility of na

Re: [DISCUSSION] IEP-59: CDC - Capture Data Change

2020-10-15 Thread Andrey Gura
Hi, I definitely agree with Pavel and Evgenii ideas and comments. >From my point of view the proposal is not about Apache Ignite features. Described functionality could be implemented outside of the Apache Ignite project. Perhaps, Debezium connector or WAL-G module are the best candidates for the

Re: [VOTE] Release Apache Ignite 2.9.0 RC4

2020-10-15 Thread Andrey Gura
+1 (binding) On Thu, Oct 15, 2020 at 9:55 PM Denis Magda wrote: > > +1 (binding) > > - > Denis > > > On Thu, Oct 15, 2020 at 5:04 AM Alex Plehanov > wrote: > > > Dear Community, > > > > > > I have uploaded a release candidate to: > > https://dist.apache.org/repos/dist/dev/ignite/2.9.0-rc4/ > > h

Re: IEP-58: Statistics

2020-10-15 Thread Andrey Gura
Follow up Igniters, is there any comment to this IEP? JFYI, IEP is renamed and placed here [1] [1] https://cwiki.apache.org/confluence/display/IGNITE/IEP-58%3A+Statistics+for+SQL+query+optimization On Thu, Sep 24, 2020 at 2:30 PM Sasha Belyak wrote: > > Igniters, > I'e prepared an IEP [1], p

Re: ApacheCon talk available

2020-10-15 Thread Andrey Gura
Saikat, thanks a lot! *applause* On Fri, Oct 16, 2020 at 12:11 AM Saikat Maitra wrote: > > Hi, > > My talk about Data Streaming using Apache Flink and Apache Ignite in > ApacheCon is available now > > https://www.youtube.com/watch?v=n74HMmTz5i0 > > Regards, > Saikat

Re: [DISCUSS] Best way to re-encrypt existing data (TDE cache key rotation).

2020-10-28 Thread Andrey Gura
Hi there, I accidentally stumbled upon a potential performance problem in this commit. CacheGroupMetricImpls.getPagesLeftForReencryption method contains at least two problems: - Relatively major: In order to calculate a value for one metric the method has O(N) complexity (N is number of partiti

Re: [DISCUSS] Best way to re-encrypt existing data (TDE cache key rotation).

2020-10-28 Thread Andrey Gura
continue of previous mail... The same method rethrows an exception which will lead to failure of an metrics exporter. The method should return some numeric value which indicates the failure. On Wed, Oct 28, 2020 at 3:09 PM Andrey Gura wrote: > > Hi there, > > I accidentally stu

Re: 2.9.1 release proposal

2020-10-29 Thread Andrey Gura
Hi, I agree with Alexey. We should release 2.9.1 and start preparing for the 2.10 release. 2.x releases usually take a lot of time. So we can release 2.9.1, and even 2.9.2 before 2.10. On Thu, Oct 29, 2020 at 12:02 PM Alexey Goncharuk wrote: > > Hello folks, > > I think we should start both 2.9

Re: Add lastCheckpointStarted metric

2020-10-29 Thread Andrey Gura
Hi, Ilya. I've left a comment to the JIRA issue. Please, look at it. On Tue, Oct 20, 2020 at 8:39 AM Ilya Kazakov wrote: > > Hello, the community! > > Sometimes one needs to understand how long ago did the last checkpoint > start or end, how long was it, etc. There is lastCheckpointDuration alre

Re: [VOTE][EXTENSION] Release Apache Ignite Streaming extensions 1.0.0 RC1

2020-11-30 Thread Andrey Gura
+1 On Tue, Nov 24, 2020 at 3:24 AM Saikat Maitra wrote: > > +1 > > Denis, Alex > > I have raised PR for the docs for Maven artifactIds and versions on the > documentation pages of the integrations. > > PR : https://github.com/apache/ignite/pull/8488 > > Jira : https://issues.apache.org/jira/brow

[DISCUSSION] Java 11 for Ignite 3.0 development

2020-12-08 Thread Andrey Gura
Igniters, We already had some discussion about using modern Java versions for Ignite 3.0 development [1] but we still don't have consensus. As I see from this discussion the strongest argument for Java 11 is the fact that Java 11 is the latest LTS release which will have premier support until Sept

Re: [DISCUSSION] Modules organization in Ignite 3

2020-12-08 Thread Andrey Gura
Definitely agree with Alexey. Separating API declaration from implementation could really improve system design and avoid coupling. About extending @IgniteExperimental annotation. It doesn't look good to me. We should consider any API either experimental or stable. Third option is deprecated API.

Re: Removing MVCC public API

2020-12-08 Thread Andrey Gura
+1 On Tue, Dec 8, 2020 at 10:02 PM Nikolay Izhikov wrote: > > +1 > > > 8 дек. 2020 г., в 21:54, Valentin Kulichenko > > написал(а): > > > > +1 > > > > On Tue, Dec 8, 2020 at 8:31 AM Вячеслав Коптилин > > wrote: > > > >> Hello Igniters, > >> > >> I want to start voting on removing the public AP

Re: Move WAL archive cleanup from checkpoint to rollover

2020-12-09 Thread Andrey Gura
Kiriill, Issue description contains the following: > At the moment, WAL archive is cleared at the end of the checkpoint, which > does not seem correct and needs to be moved Could you please explain why existing behavior is not correct. It seems that it is not enough motivation for change. On W

[ANNOUNCE] Java 11 is target version for Ignite 3.0 development

2020-12-15 Thread Andrey Gura
Igniters, JFYI According to discussion [1] there are no any objections to usage of Java 11 for Ignite 3 development as target Java language and platform version. So pom.xml for Ignite 3 is already updated. 1. http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSSION-Java-11-for-Ignite-3-0

Re: Move WAL archive cleanup from checkpoint to rollover

2020-12-15 Thread Andrey Gura
Kirill, thanks for adding motivation to the issue description. On Wed, Dec 9, 2020 at 5:24 PM Andrey Gura wrote: > > Kiriill, > > Issue description contains the following: > > > At the moment, WAL archive is cleared at the end of the checkpoint, which > > does not s

Re: [VOTE] Release Apache Ignite 3.0.0-alpha1 RC3

2021-01-10 Thread Andrey Gura
+1 (binding) On Thu, Jan 7, 2021 at 10:42 PM Vladimir Pligin wrote: > > +1 (non-binding) > > > > -- > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

[ANNOUNCE] Welcome Ivan Bessonov as a new committer

2021-01-12 Thread Andrey Gura
Being a committer enables easier contribution to the project since there is no need to go via the patch submission process. This should enable better productivity. Please join me in welcoming Ivan, and congratulating him on the new role in the Apache Ignite Community. Best Regards, Andrey Gura

Re: [ANNOUNCE] Welcome Ivan Bessonov as a new committer

2021-01-12 Thread Andrey Gura
t; > > > > > Thanks, > > > S. > > > > > > вт, 12 янв. 2021 г. в 14:27, Ivan Pavlukhin : > > > > > >> Ivan, congratulations! > > >> > > >> 2021-01-12 13:36 GMT+03:00, Kseniya Romanova < > > romanova.ks...

Re: System Worker Failure Handler on local laptop

2019-01-14 Thread Andrey Gura
Guys, there is no problem in blocking thread monitroing. Please, look at the error message: "failureCtx=FailureContext [type=SYSTEM_WORKER_TERMINATION, err=class o.a.i.IgniteCheckedException: Node is stopping: grid-2]]". Some critical worker was terminated unexpectedly. So the problem isn't relate

Re: Welcome Email

2019-01-23 Thread Andrey Gura
HI, Maksim Welcome to the Apache Ignite contributors! I've assign contributor role to you. Fell free to assign tickets. On Wed, Jan 23, 2019 at 4:16 PM Максим Степачёв wrote: > > Hello Ignite Community! > > My name is Maksim. I want to contribute to Apache Ignite and want to start > with this is

Re: GridDhtInvalidPartitionException takes the cluster down

2019-03-25 Thread Andrey Gura
Failure handlers were introduced in order to avoid cluster hanging and they kill nodes instead. If critical worker was terminated by GridDhtInvalidPartitionException then your node is unable to work anymore. Unexpected cluster shutdown with reasons in logs that failure handlers provide is better

Re: GridDhtInvalidPartitionException takes the cluster down

2019-03-26 Thread Andrey Gura
> > > > > could > > > > > > > be ignored for a while when rebalancing <- I might be wrong > > here). > > > > > > > > > > > > > > -- Roman > > > > > > > > > > > > > > > &

Re: GridDhtInvalidPartitionException takes the cluster down

2019-03-26 Thread Andrey Gura
> > > > > > > > > > > > > > > > > >On Tuesday, March 26, 2019, 2:52:14 p.m. GMT+9, Denis Magda < > > > > > > > dma...@apache.org> wrote: > > > > > > > > &

Re: GridDhtInvalidPartitionException takes the cluster down

2019-03-27 Thread Andrey Gura
651.html > > > - > Denis > > > On Tue, Mar 26, 2019 at 9:04 AM Andrey Gura wrote: > > > CleanupWorker termination can lead to the following effects: > > > > - Queries can retrieve data that have to expired so application will > > behave incorr

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Andrey Gura
It seems that SharedSecrets is moved to jdk.internal.access package. See PR for OpenJ9 [1]. I believe we should just add export of jdk.internal.access package to our scripts and TC configurations. [1] https://github.com/eclipse/openj9/pull/3824 On Wed, Mar 27, 2019 at 8:33 PM Dmitriy Pavlov wro

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Andrey Gura
>> Just a thought regarding a particular error, we can borrow some ideas from netty. We are going in the similar way: https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/util/GridUnsafe.java#L1467 On Wed, Mar 27, 2019 at 9:38 PM Павлухин Иван wrote:

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Andrey Gura
>>> I believe we should just add export of jdk.internal.access package to our scripts and TC configurations. Unfortunately it isn't enough! We have to modify GridUnsafe#javaNioAccessObject method. On Wed, Mar 27, 2019 at 10:08 PM Andrey Gura wrote: > > It seems that Share

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Andrey Gura
e similar way: > > Our way is similar, but it does not work in java 12. > > I think it is for separate thread. Let's stop live coding =) > > ср, 27 мар. 2019 г. в 22:15, Andrey Gura : > > > > >>> I believe we should just add export of jdk.internal.access p

Re: JVM tuning parameters

2019-04-01 Thread Andrey Gura
Hi, I don't see any mentions of OOM. Provided log message reports blocking of db-checkpoint-thread. I think worker tries to acquire checkpoint read lock. Stack trace corresponds to the thread that detected blocking. Failure handler prints out threads dump to the log. This thread dump can help in p

Re: Consistency check and fix (review request)

2019-04-15 Thread Andrey Gura
Anton, what does expression "withConsistency" mean? From user's standpoint it means that all operations performed without this proxy are not consistent. It means also that at least method name is bad. Are there any guarantees that withConsistency proxy will not contain bugs that will lead to inco

Re: Consistency check and fix (review request)

2019-04-15 Thread Andrey Gura
ount of "inconsistency caused > war/strikes/devastation" situations, which is important for financial > systems. > > On Mon, Apr 15, 2019 at 3:58 PM Andrey Gura wrote: > > > Anton, > > > > what does expression "withConsistency" mean? From user

Re: Consistency check and fix (review request)

2019-04-15 Thread Andrey Gura
ess implementation > Not sure it's possible. Once you have software it contains bugs. > This proxy will tell you whether these bugs lead to inconsistency. > > On Mon, Apr 15, 2019 at 5:19 PM Andrey Gura wrote: > > > Method name is minor problem. I still believe that there

Re: [VOTE] Accept Apache Ignite 2.7.5-rc3

2019-05-21 Thread Andrey Gura
Ilya, do you have any estimation for fix Java 12 with SSL issue? On Tue, May 21, 2019 at 10:26 PM Denis Magda wrote: > > Ignite PMC and committers, please cast your vote. It's time to roll the > release out. > > -- > Denis Magda > > > -- Forwarded message - > From: Denis A. Magda

Re: [VOTE] Accept Apache Ignite 2.7.5-rc3

2019-05-22 Thread Andrey Gura
gt; > Do you agree? > > Denis > > On Tuesday, May 21, 2019, Andrey Gura wrote: > > > Ilya, do you have any estimation for fix Java 12 with SSL issue? > > > > On Tue, May 21, 2019 at 10:26 PM Denis Magda wrote: > > > > > > Ignite PMC and committers

Re: [VOTE] Release Apache Ignite 2.7.5-rc4

2019-06-05 Thread Andrey Gura
+1 (binding) On Wed, Jun 5, 2019 at 4:39 PM Ilya Kasnacheev wrote: > > +1 > > Built C++ and .Net successfully, started .Net <-> Java <-> C++ SSL Cluster > on Java 11 and Java 8 without tuning any flags. > -- > Ilya Kasnacheev > > > ср, 5 июн. 2019 г. в 09:44, Nikolay Izhikov : > > > +1 (binding)

Re: Code styles issues in IGNITE-11750

2019-06-07 Thread Andrey Gura
Big +1 from me. Make code base clean and clear. On Fri, Jun 7, 2019 at 3:26 PM Nikolay Izhikov wrote: > > Hello, Igniters. > > Please, pay attention to commits quality. > > 1. Please, writer Javadocs. > 2. Please, make the new lines according to code style. > > Issues like [1] has to be fixed *BE

Re: [VOTE] Complete Discontinuation of IGFS and Hadoop Accelerator

2019-06-19 Thread Andrey Gura
+1 On Thu, Jun 20, 2019 at 12:58 AM Denis Magda wrote: > > Igniters, > > Based on our earlier discussion [1], let's formalize our decision and vote > for the following: > >- IGFS and In-Memory Hadoop Accelerator components are to be >discontinued and no longer supported by the community >

<    1   2   3   4   5   6   >