Re: Logging and Debugging Impala C++ UDF

Hi Manish, I believe the only supported way is to call AddWarning() on the FunctionContext object. Cheers, Tim On Mon, Aug 15, 2016 at 2:48 PM, Manish Nema wrote: > Hi Folks, > I am using CDH 5.7 , I am porting existing DB2 implementation of UDF to > Impala, I was

[Impala-ASF-CR] IMPALA-3954: Add unique database to scanner test

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3954: Add unique_database to scanner test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4045 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3938 To unsubscribe

[Impala-ASF-CR] Fix stress test runner bug introduced by IMPALA-3969

Tim Armstrong has posted comments on this change. Change subject: Fix stress test runner bug introduced by IMPALA-3969 .. Patch Set 2: I think I need a +2 from a committer to merge - added taras. -- To view, visit http

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/3938/3/be/src/runtime/tmp-file

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 4: Unfortunately I wasn't really able to address many of the comments. Maybe we should

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/3993/4/be/src/bufferpool

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/3938/2/be/src/runtime/buffered

[Impala-ASF-CR] IMPALA-3992: bad shell error message when running nonexistent file

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4022 Change subject: IMPALA-3992: bad shell error message when running nonexistent file .. IMPALA-3992: bad shell error message when running

[Impala-ASF-CR] Fix stress test runner bug introduced by IMPALA-3969

Tim Armstrong has posted comments on this change. Change subject: Fix stress test runner bug introduced by IMPALA-3969 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4019/1/tests/stress/concurrent_select.py

[Impala-ASF-CR] Fix stress test runner bug introduced by IMPALA-3969

Tim Armstrong has uploaded a new patch set (#2). Change subject: Fix stress test runner bug introduced by IMPALA-3969 .. Fix stress test runner bug introduced by IMPALA-3969 In some cases if common_query_options

[Impala-ASF-CR] Fix stress test runner bug introduced by IMPALA-3969

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4019 Change subject: Fix stress test runner bug introduced by IMPALA-3969 .. Fix stress test runner bug introduced by IMPALA-3969 In some

Re: Error encounted when doing 'bin/load_data.py -w all'

I think testdata/bin/load-hive-builtins.sh also expects some lzo files to be present. Alex, is Twitter's hadoop-lzo the same as Cloudera's? It looks like it has a bunch of patches on top of it. On Tue, Aug 16, 2016 at 2:26 AM, Amos Bird wrote: > > Hmm, building hadoop-lzo

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3774/9/be/src/exec/hdfs

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3774

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 4: I put together a spreadsheet of results for memory usage before and after this patch

[Impala-ASF-CR] IMPALA-3918: remove Cloudera copyright from the shell welcome message

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3918: remove Cloudera copyright from the shell welcome message .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4005

[Impala-ASF-CR] IMPALA-3981: Fixed the bug of "Crash when access statestore/catalog memz webpage"

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3981: Fixed the bug of "Crash when access statestore/catalog memz webpage" .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/3993/3/be/src/bufferpool

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 3: I cut back this patch so that it doesn't actually include the bulk of the buffer

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/2569/23/be/src/bufferpool

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has abandoned this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Abandoned Moved to https://gerrit.cloudera.org/#/c/3993/ -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Patch Set 1: See https://gerrit.cloudera.org/#/c/2569/ for history. This isn't ready

[Impala-ASF-CR] IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3993 Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. IMPALA-3201: headers and reservation logic for new

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has uploaded a new patch set (#24). Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. IMPALA-3201: headers and reservation logic for new buffer pool This patch implements the core

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Patch Set 23: (8 comments) Addressed the comments. I will now move to Impala-ASF

[Impala-ASF-CR] IMPALA-3201: buffer pool header only

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 1: I'm planning to address them once we get to the implementation. There was a lot of churn in the interface

[Impala-ASF-CR] IMPALA-3201: buffer pool header only

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 1: Code-Review+2 Carry +2 from cdh5-trunk -- To view, visit http://gerrit.cloudera.org:8080/3992

[Impala-CR](cdh5-trunk) IMPALA-3201: buffer pool header only

Tim Armstrong has abandoned this change. Change subject: IMPALA-3201: buffer pool header only .. Abandoned move to http://gerrit.cloudera.org:8080/3992 -- To view, visit http://gerrit.cloudera.org:8080/3688 To unsubscribe

[Impala-ASF-CR] IMPALA-3201: buffer pool header only

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3992 Change subject: IMPALA-3201: buffer pool header only .. IMPALA-3201: buffer pool header only Implementation will follow in a subsequent

[Impala-CR](cdh5-trunk) IMPALA-3201: buffer pool header only

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/3688/7/be/src/bufferpool/buffer-pool.h File be/src

[Impala-CR](cdh5-trunk) IMPALA-3201: buffer pool header only

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 8: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/3688 To unsubscribe, visit http

[Impala-CR](cdh5-trunk) IMPALA-3201: buffer pool header only

-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-ASF-CR] Remove dead and untested code

Tim Armstrong has posted comments on this change. Change subject: Remove dead and untested code .. Patch Set 1: I did manually verify that the functions didn't have any callsites, so I'm convinced it's actually dead

[Impala-ASF-CR] Remove dead and untested code

Tim Armstrong has posted comments on this change. Change subject: Remove dead and untested code .. Patch Set 1: It builds on ASAN, debug and release. Did you have any other compilation modes in mind? -- To view, visit http

[Impala-ASF-CR] IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3832/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. .. Patch Set 4: Code-Review+2 rebase, carry +2 -- To view, visit http

[Impala-ASF-CR] Remove dead and untested code

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3989 Change subject: Remove dead and untested code .. Remove dead and untested code Remove some code that the code coverage build revealed

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 4: Fixed a bug where I wasn't setting the ht_ctx level when building a hash table

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder The main outcome of this patch is to split out

[Impala-ASF-CR] IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs

Tim Armstrong has posted comments on this change. Change subject: IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3470: DecompressorTest is flaky.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3470: DecompressorTest is flaky. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3954/1/be/src/util/decompress-test.cc File be/src/util

[Impala-ASF-CR] IMPALA-3881: Add DataTables 1.10.12 to www/

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3881: Add DataTables 1.10.12 to www/ .. Patch Set 1: Code-Review+2 Sounds good -- To view, visit http://gerrit.cloudera.org:8080/3947 To unsubscribe

[Impala-ASF-CR] IMPALA-3953: Fixes for KuduScanNode BE test failure

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3953: Fixes for KuduScanNode BE test failure .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3888 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3201: buffer pool header only

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 6: (24 comments) http://gerrit.cloudera.org:8080/#/c/3688/6/be/src/bufferpool/buffer-pool.h File be/src

[Impala-ASF-CR] IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/3832/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3969: stress test: add option to set common query options

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3969: stress test: add option to set common query options .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3887

[Impala-CR](cdh5-trunk) IMPALA-3201: buffer pool header only

Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3201: buffer pool header only .. IMPALA-3201: buffer pool header only Implementation will follow in a subsequent commit. The BufferPool interface

[Impala-ASF-CR] IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. .. IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. Fix multiple bugs

[Impala-ASF-CR] draft version -- not completed yet

Tim Armstrong has posted comments on this change. Change subject: draft version -- not completed yet .. Patch Set 4: (2 comments) Looks like we're making progress. Let's focus on the frontend part and getting "ex

[Impala-ASF-CR] IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 7: It's a valid point. I think it's pretty unlikely to happen

[Impala-ASF-CR] IMPALA-3969: stress test: add option to set common query options

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3969: stress test: add option to set common query options .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3887

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3774

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: Thanks for the comment Alex - I totally missed the case of LIMIT + conjuncts. I

[Impala-ASF-CR] IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found .. Patch Set 8: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: -Code-Review I'm seeing some odd behaviour playing around with this. It looks

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3822

[Impala-ASF-CR] IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found .. Patch Set 7: Waiting for https://gerrit.cloudera.org/#/c/3838/ to go in first

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3838/5/be/src/runtime/mem-pool.h

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/3822/3/be/src/exec

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 1: (22 comments) Looking pretty good, I think we can simplify the design a bit and fix

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3774/6

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3838/4/be/src/runtime/mem-pool.cc

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Ger

[Impala-ASF-CR] IMPALA-3857: Add missing synchronization in KuduScanNode

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3857: Add missing synchronization in KuduScanNode .. Patch Set 1: Code-Review+1 I don't think that this fixes IMPALA-3953, but it seems like it's worth

[Impala-ASF-CR] IMPALA-3969: stress test: add option to set common query options

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3969: stress test: add option to set common query options .. Patch Set 3: Code-Review+1 Will wait for david's comments to be addressed -- To view

[Impala-ASF-CR] IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found

://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I50cf43195a7c582caa02c85ae400ea2256fa3a3b Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.co

[Impala-ASF-CR] IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3833/6/be/src/exec/hdfs

[Impala-ASF-CR] IMPALA-3969: stress test: add option to set common query options

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3969: stress test: add option to set common query options .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3887

[Impala-ASF-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

: Iabb977014d855d6edb035bf2e9519ac8b3234767 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Revie

[Impala-ASF-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3923: fix overflow in BufferedTupleStream::GetRows() .. Patch Set 3: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/3878

[Impala-ASF-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3923: fix overflow in BufferedTupleStream::GetRows() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3878/2/be/src/runtime/buffered

[Impala-ASF-CR] IMPALA-3857: Add missing synchronization in KuduScanNode

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3857: Add missing synchronization in KuduScanNode .. Patch Set 1: I'm not sure that I understand the scenario. I think this is worth fixing

[Impala-ASF-CR] IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found .. Patch Set 6: You can look at the 5->6 delta to see the changes. Logically the chan

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() hdfs-parquet-scanner

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() hdfs-parquet-scanner .. Patch Set 5: (5 comments) I think we're nearly there, looking good. http

[Impala-ASF-CR] IMPALA-3969: stress test: add option to (en|dis)able codegen

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3969: stress test: add option to (en|dis)able codegen .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3887/1/tests/stress

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks .. Patch Set 4: Code-Review+1 Carry +1 (assuming lack of comment is ok). -- To view, visit http

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3838/2/be/src/runtime/mem-pool.cc

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@clo

[Impala-ASF-CR] IMPALA-3969: stress test: add option to (en|dis)able codegen

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3969: stress test: add option to (en|dis)able codegen .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3887/1/tests/stress

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Tim Armstrong has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 1: There's a git-clang-format utility that only reformats changed lines. That might avoid some

[Impala-ASF-CR] IMPALA-3843: Update warning for non-SSSE3 CPUs

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3843: Update warning for non-SSSE3 CPUs .. Patch Set 1: Code-Review+2 Move from https://gerrit.cloudera.org/#/c/3837/ carry +2 -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-3843: Update warning for non-SSSE3 CPUs

Tim Armstrong has abandoned this change. Change subject: IMPALA-3843: Update warning for non-SSSE3 CPUs .. Abandoned Moved to https://gerrit.cloudera.org/#/c/3884/1 -- To view, visit http://gerrit.cloudera.org:8080/3837

[Impala-ASF-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3923: fix overflow in BufferedTupleStream::GetRows() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3878/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

: Iabb977014d855d6edb035bf2e9519ac8b3234767 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/3838/1/be/src/runtime/mem-pool

[Impala-CR](cdh5-trunk) IMPALA-3843: Update warning for non-SSSE3 CPUs

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3843: Update warning for non-SSSE3 CPUs .. Patch Set 2: Code-Review+1 No problems - thank you for the contribution! -- To view, visit http

[Impala-ASF-CR] IMPALA-2923: fix overflow in BufferedTupleStream::GetRows()

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3878 Change subject: IMPALA-2923: fix overflow in BufferedTupleStream::GetRows() .. IMPALA-2923: fix overflow in BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2700: ASCII NUL characters are doubled on insert into text tables

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2700: ASCII NUL characters are doubled on insert into text tables .. Patch Set 1: Code-Review+2 Carry +2 from https://gerrit.cloudera.org/#/c/3703

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 3: Fixed a typo in the previous patch. -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder The main outcome of this patch is to split out

[Impala-ASF-CR] IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found

://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I50cf43195a7c582caa02c85ae400ea2256fa3a3b Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewe

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 2: This depends on https://gerrit.cloudera.org/#/c/3832/ before merging (I saw some stress

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder The main outcome of this patch is to split out

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3822/1/be/src/exec

[Impala-CR](cdh5-trunk) IMPALA-3201: buffer pool header only

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/3688/5/be/src/bufferpool/buffer-pool.h File be/src

<    1   2   3   4   5   6   7   8   9   10   >