Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 12:
> Hi Zoltan, this didn't get merged because you didn't have +2 and
> verified on the same
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 12:
Hi Zoltan, this didn't get merged because you didn't have +2 and verified on
the same
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
IMPALA-4006: dangerous rm -rf statements in scripts
Quoted variable substitutions in rm -rf
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4078
To unsubscribe, visit
Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 11:
Sorry for the flood of patchsets. The last one finally makes the tests pass, so
I don't
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4078
To unsubscribe, visit
Hello Michael Ho, Internal Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4078
to look at the new patch set (#11).
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
Hello Michael Ho, Internal Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4078
to look at the new patch set (#10).
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
Hello Michael Ho, Internal Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4078
to look at the new patch set (#9).
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 8: Verified-1
Build failed:
Hello Michael Ho, Internal Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4078
to look at the new patch set (#8).
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 7: Verified-1
Build failed:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 6: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4078/6/bin/run-all-tests.sh
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 6:
We already have set -euo pipefail at the top of all of the scripts in the repo,
which turns
Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 5:
> Thanks for fixing this. Would "set -u" help in those cases, too?
There are some settings
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4078
to look at the new patch set (#6).
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4078/5/bin/clean.sh
File bin/clean.sh:
Lars Volker has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 5:
Thanks for fixing this. Would "set -u" help in those cases, too?
>From
Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4078/3/bin/impala-config.sh
File
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4078
to look at the new patch set (#5).
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4078/3/bin/impala-config.sh
File
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4078
to look at the new patch set (#4).
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4078/1/bin/clean.sh
File bin/clean.sh:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4078/1/bin/clean.sh
File bin/clean.sh:
PS1,
Michael Ho has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 3:
(5 comments)
It appears that you are already fixing some of the places which are considered
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
Patch Set 3: Code-Review+1
Will wait for Michael's +1 too.
--
To view, visit
Zoltan Ivanfi has uploaded a new patch set (#3).
Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
..
IMPALA-4006: dangerous rm -rf statements in scripts
Quoted variable substitutions in rm -rf commands and in
27 matches
Mail list logo
