[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#6). Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. This changes the code to use the lddqu

[Impala-CR](cdh5-trunk) IMPALA-2761: OS X: Misc Fixes

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2761: OS X: Misc Fixes .. Patch Set 4: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) Add testing utility to convert nested data to flat data

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add testing utility to convert nested data to flat data .. Patch Set 5: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) IMPALA-3382: Long warnings cause impala-shell to stall

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3382: Long warnings cause impala-shell to stall .. Patch Set 1: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables .. Patch Set 1: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) IMPALA-1661: Netezza compatibility functions: strings

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1661: Netezza compatibility functions: strings .. Patch Set 4: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) IMPALA-3613: Do not update unregistered subscribers

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3613: Do not update unregistered subscribers .. Patch Set 3: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 12: Hi Zoltan, this didn't get merged because you didn't have +2 and verified on the same

[Impala-ASF-CR] IMPALA-3808: Add incubating DISCLAIMER from the Incubator Branding Guide

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3808: Add incubating DISCLAIMER from the Incubator Branding Guide .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4160

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 6: Code-Review+1 Carry my own +1 -- To view, visit

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. IMPALA-4006: dangerous rm -rf statements in scripts Quoted variable substitutions in rm -rf

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-09-01 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 12: > Hi Zoltan, this didn't get merged because you didn't have +2 and > verified on the same

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-09-01 Thread Alex Behm (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4155 to look at the new patch set (#5). Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. ..

[Impala-CR](cdh5-trunk) IMPALA-3766: Applying LZ4 compression on buffers before spilling

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3766: Applying LZ4 compression on buffers before spilling .. Patch Set 2: Please update to using the new gerrit project, "Impala-ASF". Instructions are

[Impala-CR](cdh5-trunk) IMPALA-2626: In-flight queries fail when statestore comes back online.

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2626: In-flight queries fail when statestore comes back online. .. Patch Set 2: Please update to using the new gerrit project, "Impala-ASF". Instructions

[Impala-CR](cdh5-trunk) IMPALA-2717: impala-shell breaks on non-ascii chars in resultset

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2717: impala-shell breaks on non-ascii chars in resultset .. Patch Set 3: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) IMPALA-2328 Parquet scan should use min/max stats

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2328 Parquet scan should use min/max stats .. Patch Set 1: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) Add a synthetic query to stress the number of open hdfs connections.

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a synthetic query to stress the number of open hdfs connections. .. Patch Set 1: Please update to using the new gerrit project, "Impala-ASF". Instructions are

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 6: See https://gerrit.cloudera.org/#/c/4290/ for the benchmark -- To view, visit

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4205 To unsubscribe,

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4290/1/be/src/benchmarks/bswap-benchmark.cc

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. IMPALA-4058: benchmark byteswap on misaligned memory Extend the benchmark to measure performance when

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

2016-09-01 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 2: I am not able to reproduce the test failure with this test locally and on a rhel machine. But I tried

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 5: We don't support parquet decimals wider than 16 bytes so I don't think the AVX2

[Impala-CR] IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4209 To unsubscribe, visit

[Impala-CR] IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4212 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 5: Code-Review+1 (1 comment) I also extended the microbenchmark to test perf when

[Impala-CR](cdh5-trunk) PREVIEW: IMPALA-2550 Introduce query-wide execution context.

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 3: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) Kimpala (Preview)

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Kimpala (Preview) .. Patch Set 4: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-ASF-CR] IMPALA-4054: Remove serial test workarounds for IMPALA-2479.

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4054: Remove serial test workarounds for IMPALA-2479. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4291 To

Re: Sorry for the spam

2016-09-01 Thread Jim Apple
Messages sent. On Thu, Sep 1, 2016 at 1:58 PM, Henry Robinson wrote: > Sounds good to me. Pushes should be enabled now. > > On 1 September 2016 at 13:54, Jim Apple wrote: > >> What if >> >> 1. (a) You re-open pushes (b) I post the following message to

[Impala-ASF-CR] IMPALA-3808: Add incubating DISCLAIMER from the Incubator Branding Guide

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3808: Add incubating DISCLAIMER from the Incubator Branding Guide .. Patch Set 2: Code-Review+2 Carry Tim's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4054: Remove serial test workarounds for IMPALA-2479.

2016-09-01 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4291 Change subject: IMPALA-4054: Remove serial test workarounds for IMPALA-2479. .. IMPALA-4054: Remove serial test workarounds for IMPALA-2479.

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. Patch Set 3: Code-Review+2 (2 comments) Just some nits; feel free to skip

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

2016-09-01 Thread Alex Behm (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4113 to look at the new patch set (#6). Change subject: IMPALA-3905: Add single-threaded scan node. .. IMPALA-3905:

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate corr(). .. Patch Set 2: Please update to using the new gerrit project, "Impala-ASF". Instructions

[Impala-CR](cdh5-trunk) Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY .. Patch Set 9: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables .. Patch Set 3: (1 comment) Please update to using the new gerrit project,

[Impala-CR](cdh5-trunk) Query gen: Add INSERT statements

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Query gen: Add INSERT statements .. Patch Set 2: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) Kudu: Remove TODO about checking for unsupported types in table loading

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Kudu: Remove TODO about checking for unsupported types in table loading .. Patch Set 1: Please update to using the new gerrit project, "Impala-ASF". Instructions

[Impala-CR](cdh5-trunk) IMPALA-2848: Simplify creation of a new Kudu table

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2848: Simplify creation of a new Kudu table .. Patch Set 6: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-ASF-CR] IMPALA-3873: Add QueryStateAccessor

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3873: Add QueryStateAccessor .. Patch Set 2: Code-Review+1 (6 comments) Renewed +1, did another pass and noticed a few minor things.

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. IMPALA-4058: benchmark byteswap on misaligned memory Extend the benchmark to measure performance when

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-09-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4155 To unsubscribe,

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4205 To

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 10: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) IMPALA-2033: Netezza compatibility functions quote ident

2016-09-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident .. Patch Set 4: Please update to using the new gerrit project, "Impala-ASF". Instructions are here:

[Impala-CR](cdh5-trunk) IMPALA-3776: fix 'describe formatted' for Avro tables

2016-09-01 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables .. Abandoned Moved and already merged -- To view, visit http://gerrit.cloudera.org:8080/3474 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-09-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/4/tests/metadata/test_ddl.py File

[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected.

2016-09-01 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has uploaded a new change for review. http://gerrit.cloudera.org:8080/4195 Change subject: IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected. .. IMPALA-4056: Fix toSql() of DistributeParam

[Impala-ASF-CR] IMPALA-1654: Partition expr in DDL operations.

2016-09-01 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new patch set (#4). Change subject: IMPALA-1654: Partition expr in DDL operations. .. IMPALA-1654: Partition expr in DDL operations. This commit handles partition related DDL in a more general way. We

[Impala-CR](cdh5-trunk) Impala-4058: unaligned memory access issue in SIMDed byteswap.

2016-09-01 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/4198 Change subject: Impala-4058: unaligned memory access issue in SIMDed byteswap. .. Impala-4058: unaligned memory access issue in SIMDed

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-01 Thread hewenting (Code Review)
hewenting has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Patch Set 1: > (3 comments) > > Thanks for the patch! > > Could you add a test to

[Impala-CR] IMPALA-3470: DecompressorTest is flaky.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-3470: DecompressorTest is flaky. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4234 To unsubscribe, visit

[Impala-CR] IMPALA-3952: Clear scratch batch mem pool if Open() failed.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-3952: Clear scratch batch mem pool if Open() failed. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4236 To unsubscribe, visit

[Impala-CR] IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4235 To

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 8: (16 comments) Only partially made it through the rest of the change, still going. But

[Impala-CR] IMPALA-3090: always log memory limit errors

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-3090: always log memory limit errors .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4245 To unsubscribe, visit

[Impala-CR] IMPALA-3376: Extra definition level when writing Parquet files

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-3376: Extra definition level when writing Parquet files .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4207 To unsubscribe, visit

Re: Sorry for the spam

2016-09-01 Thread Michael Brown
My hunch is you pushed to the Cloudera Impala Gerrit. There's an old master branch lying there. Maybe use "git remote rename" or "git remote remove" ? (I muscle-memory-typo'd this same thing the other day but got lucky and the push was rejected.) On Thu, Sep 1, 2016 at 12:49 PM, Thomas

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 5: Clearly we were missing some basic test coverage. Do we have any other test gaps

[Impala-CR] IMPALA-3924: Ubuntu16 support

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4216 to review the following change. Change subject: IMPALA-3924: Ubuntu16 support .. IMPALA-3924:

[Impala-CR] IMPALA-3952: Clear scratch batch mem pool if Open() failed.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4236 to review the following change. Change subject: IMPALA-3952: Clear scratch batch mem pool if Open() failed.

[Impala-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4220 to review the following change. Change subject: IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()

[Impala-CR] IMPALA-3918: Remove Cloudera copyrights and add ASF license header

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Dan Hecht, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4211 to review the following change. Change subject: IMPALA-3918: Remove Cloudera copyrights and add ASF license header

[Impala-CR] IMPALA-3953: Fixes for KuduScanNode BE test failure

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Dan Hecht, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4231 to review the following change. Change subject: IMPALA-3953: Fixes for KuduScanNode BE test failure

[Impala-CR] IMPALA-3376: Extra definition level when writing Parquet files

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4207 to review the following change. Change subject: IMPALA-3376: Extra definition level when writing Parquet files

[Impala-CR] IMPALA-3918: remove Cloudera copyright from the shell welcome message

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4238 to review the following change. Change subject: IMPALA-3918: remove Cloudera copyright from the shell welcome message

[Impala-CR] IMPALA-3828: Enable inversion for inner joins.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4246 to review the following change. Change subject: IMPALA-3828: Enable inversion for inner joins. ..

[Impala-CR] IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Dan Hecht, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4235 to review the following change. Change subject: IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs

[Impala-CR] IMPALA-3881: Add DataTables 1.10.12 to www/

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4227 to review the following change. Change subject: IMPALA-3881: Add DataTables 1.10.12 to www/ ..

[Impala-CR] IMPALA-1112: Remove some unncessary code from cross-compilation

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4217 to review the following change. Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation

[Impala-CR] IMPALA-3969: stress test: add option to set common query options

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello David Knupp, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4225 to review the following change. Change subject: IMPALA-3969: stress test: add option to set common query options

[Impala-CR] IMPALA-2700: ASCII NUL characters are doubled on insert into text tables

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4215 to review the following change. Change subject: IMPALA-2700: ASCII NUL characters are doubled on insert into text tables

[Impala-CR] IMPALA-3918: Remove Cloudera copyrights and add ASF license header

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Dan Hecht, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4213 to review the following change. Change subject: IMPALA-3918: Remove Cloudera copyrights and add ASF license header

[Impala-CR] IMPALA-2347: Reuse metastore client connections in Catalog

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Bharath Vissapragada, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4229 to review the following change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog

[Impala-CR] IMPALA-3063: Separate join inversion from join ordering.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4239 to review the following change. Change subject: IMPALA-3063: Separate join inversion from join ordering.

[Impala-CR] IMPALA-3856,IMPALA-3871: Fix BinaryPredicate normalization for Kudu

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4241 to review the following change. Change subject: IMPALA-3856,IMPALA-3871: Fix BinaryPredicate normalization for Kudu

[Impala-CR] IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4212 to review the following change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks

[Impala-CR] IMPALA-3996: Migrate to updated Kudu insert string API

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4252 to review the following change. Change subject: IMPALA-3996: Migrate to updated Kudu insert string API

[Impala-CR] IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4244 to review the following change. Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables

[Impala-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4251 to review the following change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

[Impala-CR] IMPALA-3972: Improve display of /varz page

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Henry Robinson, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4228 to review the following change. Change subject: IMPALA-3972: Improve display of /varz page ..

[Impala-CR] Fix stress test runner bug introduced by IMPALA-3969

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Brown, Internal Jenkins, Dan Hecht, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4243 to review the following change. Change subject: Fix stress test runner bug introduced by IMPALA-3969

[Impala-CR] IMPALA-3992: bad shell error message when running nonexistent file

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Henry Robinson, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4240 to review the following change. Change subject: IMPALA-3992: bad shell error message when running nonexistent file

[Impala-CR] IMPALA-3988: Only use first 96 bits of query id

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4254 to review the following change. Change subject: IMPALA-3988: Only use first 96 bits of query id .. IMPALA-3988:

[Impala-CR] IMPALA-3940: Fix getting column stats through views.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4223 to review the following change. Change subject: IMPALA-3940: Fix getting column stats through views.

[Impala-CR] IMPALA-3470: DecompressorTest is flaky.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Juan Yu, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4234 to review the following change. Change subject: IMPALA-3470: DecompressorTest is flaky. .. IMPALA-3470:

[Impala-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4250 to review the following change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

[Impala-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Dan Hecht, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4249 to review the following change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

[Impala-CR] IMPALA-3957: Test failure in S3 build: TestLoadData.test load

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Sailesh Mukil, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4221 to review the following change. Change subject: IMPALA-3957: Test failure in S3 build: TestLoadData.test_load

[Impala-CR] IMPALA-3843: Update warning for non-SSSE3 CPUs

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4218 to review the following change. Change subject: IMPALA-3843: Update warning for non-SSSE3 CPUs ..

[Impala-CR] Remove dead and untested code

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Dan Hecht, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4232 to review the following change. Change subject: Remove dead and untested code .. Remove dead and

[Impala-CR] IMPALA-4004: Don't access nested types in test failpoints.py

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4253 to review the following change. Change subject: IMPALA-4004: Don't access nested types in test_failpoints.py

[Impala-CR] IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Internal Jenkins, Dan Hecht, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4237 to review the following change. Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.

[Impala-CR] Add functional and targeted perf tests for joins with empty builds

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4247 to review the following change. Change subject: Add functional and targeted perf tests for joins with empty builds

[Impala-CR] IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4230 to review the following change. Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

[Impala-CR] IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found

2016-09-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4224 to review the following change. Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found

  1   2   3   >