[GitHub] jena pull request #179: Reorganise control of a test Fuseki server for HTTP ...

2016-10-17 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/179#discussion_r83655593 --- Diff: jena-fuseki1/src/test/java/org/apache/jena/fuseki/ServerCtl.java --- @@ -18,39 +18,113 @@ package org.apache.jena.fuseki; +import

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I'm fine if you would merge this and f you'd like to close 576 for the release. I will work on the docs separately. --- If your project is set up for it, you can reply to this email and have

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 That `http_op_3` commit https://github.com/apache/jena/commit/944e5208ff0fbb4e87fcab7417b760252d9aabfc did come over into this PR as commit https://github.com/apache/jena/pull/151/commits

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 The state is that it builds and passes all tests. The dependency is upgraded and the use of the deprecated API from HTTP Commons is removed (at least all that I could find). I now see that I didn't

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 For my money, we can merge this. I think we might want to keep JENA-576 open until @rvesse is happy with the new documentation. --- If your project is set up for it, you can reply to this email and

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 _O frabjous day! Callooh! Callay!_ Full green light build. Thanks enormously for this help, @afs. I'm still very much a beginner with the various form of test machinery in the codebase.

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I cherry-picked that last cleanup commit (which did touch several of the exact files in `fuseki1` that are giving me a pain, but I'm still getting: ``` org.apache.jena.fuseki.TestSPARQLPro

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 The errors I get in `TS_Fuseki` are always in `TestSPARQLProtocol` or `TestQuery`, which use `resetServer()` and load up sample data over which to work. They are `Connection reset` exceptions, oddly

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 There is a strange pattern for me using the code as pushed here: without `static { allocServer() ; }` various tests fail in `fuseki1`'s `TS_Fuseki`, but only ever those that use `resetServer()`. Wi

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 That's a weird error, now that I look at it. It suggests that a server hasn't spun up, but `TestQuery` has ``` // DRY - test protocol? @BeforeClass public static void b

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 RIght, but when I remove `static { allocServer() ; }` the tests for `jena-fuseki1` no longer pass with ``` org.apache.jena.fuseki.TestQuery Time elapsed: 0.125 sec <<&

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-13 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I will bang on this more this weekend and try going back down the road you outlined, @afs . Maybe I missed something in the way I brought your commit over. If I don't find something, I'

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-13 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 @afs I'm still getting the errors: ``` Failed tests: TestRemoteEndpointConnectionWithResultSetTypes>AbstractJenaConnectionTests.connection_statement_query_select_max_rows_01:531

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-13 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Hang on, I didn't realize that that was just a simple cherry-pick, doing it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-13 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 @afs Are you saying to take https://github.com/apache/jena/commit/36b678933ecf2b5553f9345ef84e683cf0f181f0 and add it to this PR, and then we can look at finally merging this into master? Yes, I can

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-13 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I've opened https://issues.apache.org/jira/browse/JENA-1243 to track the other clear-up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-13 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 1. Let's port the changes here, where the discussion has been. 2. Absolutely fine with me (to do the other changes elsewhere). I'll make a ticket for those things now so that we don&

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-13 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r83219299 --- Diff: jena-fuseki1/src/test/java/org/apache/jena/fuseki/ServerTest.java --- @@ -20,7 +20,7 @@ import java.io.IOException ; import

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-13 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Holy moly, @afs , thanks for the huge assist! I was out yesterday (Yom Kippur) and am now catching up. I will leave comments specific to the HTTP question on the new PR, but I will try to speak to the

[GitHub] jena pull request #175: Added .travis.yml

2016-10-11 Thread ajs6f
Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jena issue #175: Added .travis.yml

2016-10-11 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/175 Fixed in Apache Git with f659ca8c16f030dcf4e1a1f547f2dfaefb092fdf --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] jena issue #175: Added .travis.yml

2016-10-11 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/175 If it don't work, it don't work. I'll pull that line out, along with the IRC stanza. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-11 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Hm. This is really quite squirrely. If there is something subtle wrong with `ServerTest::resetServer`, I wonder what I did in my PR to make it show up? Anyway, I will start tracing it. Thanks for the

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-11 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 That stuff in `AbstractRemoteEndpointResultSetTests` is cruft-- client swapping is taken care of in `TS_JdbcDriverRemote` itself. But it doesn't seem to have any effect on the mysterious failures.

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-10 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 It's as though some kind of static state is being impacted. But where?!?! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-10 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Yes, I can get it to fail with ``` @RunWith(Suite.class) @Suite.SuiteClasses({ TestRemoteEndpointConnection.class, TestRemoteEndpointConnection.class }) public class TestSpecial

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 > Unless there is a good reason to make the 2 permissions methods static I would prefer to leave them alone. I had some reason (explained above) but since seems less clear to you, I will rem

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511823 --- Diff: jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java --- @@ -299,7 +299,7 @@ public String toString() throws

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511824 --- Diff: jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java --- @@ -312,7 +312,7 @@ private Boolean cacheGet(final CacheKey

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 The bulk of changes to `jena-permissions` are using `<>` instead of writing out type parameters, but there are also a few more substantive syntax and other changes there. --- If your project is

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511008 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/validation/DataValidator.java --- @@ -101,33 +95,6 @@ protected JsonObject execute

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511001 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java --- @@ -162,10 +162,6

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511004 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java --- @@ -371,19 +367,6 @@ else if ( ! dir.isDirectory

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510986 --- Diff: jena-base/src/test/java/org/apache/jena/atlas/lib/TestHex.java --- @@ -85,7 +85,7 @@ private static void testStr2Val(String str, int expected

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82511000 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java --- @@ -371,19 +367,6 @@ else if ( ! dir.isDirectory

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510977 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIterTopN.java --- @@ -74,7 +74,7 @@ public QueryIterTopN(QueryIterator qIter

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510973 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java --- @@ -227,11 +220,6 @@ else if ( ch <= 0x7FFF ) } //

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r82510971 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java --- @@ -154,11 +152,6 @@ else if ( (x & 0xF8) ==

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 I will try to fix these things sometime tomorrow in another commit, especially if I can fix #151. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I am utterly at a loss with this. I can reliably cause the fault using @afs 's advice, but I cannot see any interaction path between those test classes. `Statement::setMaxRows` seems to be oper

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I can't get the deadlocking to occur, but by running tests in the order you give, I can see the three failures in `TestRemoteEndpointConnectionWithResultSetTypes`. I don't see anything spec

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Wow, this is getting quite weird. I don't get any of that stuff. I will get on this and find out why. Deadlock is really unexpected! --- If your project is set up for it, you can reply to this

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 Absolutely. Would you rather I just left it here and we can pick it up at the right moment, or close this PR and reopen it post-release? --- If your project is set up for it, you can reply to this

[GitHub] jena issue #176: Minor cleanup

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 A few more commits to come this afternoon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] jena pull request #176: Minor cleanup

2016-10-08 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/176 Minor cleanup Just removing dead code and variables that don't get used, adding `static` here or there to clarify tests a bit, that sort of thing. Pruning. You can merge this pull request into

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82506306 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82505814 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82505751 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Just as an example, I could imagine supporting fluent methods that would let people use Jena's language selection machinery (i.e. `Lang`) instead of using HTTP `Accept` directly. --- If your pr

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Like I said, I'm fine with making a new fluent API. Can you describe some of the things you see as common in particular to a semweb app? `HttpOp` as it stands doesn't appear to do anything par

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82505343 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82504994 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/151#discussion_r82504973 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 And as a point of info, I didn't actually end up changing the `HttpOp` API all that much, just `HttpAuthenticator` => `HttpClient`. The additional parameters for `HttpContext` turned out to al

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I'm totally fine with a "high-level" rethink, but at some point, aren't we just duplicating this: https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fluent.html ?

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 As for the fix, specifically I went to `HttpOp` and made sure that any HTTP clients built there get closed properly. HTTP clients that get passed in don't get closed because that's the job of

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-08 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Sorry, @afs , I'm working on this now but not keeping this conversation up to date. In fact, my most recent comment I now believe to have been wrong. See [here](https://hc.apache.org/httpcompo

[GitHub] jena pull request #175: Added .travis.yml

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/175#discussion_r82504509 --- Diff: .travis.yml --- @@ -0,0 +1,18 @@ +language: java +sudo: false +script: mvn -Pdev verify +jdk: + - oraclejdk8 + - openjdk8

[GitHub] jena pull request #175: Added .travis.yml

2016-10-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/175#discussion_r82504407 --- Diff: .travis.yml --- @@ -0,0 +1,18 @@ +language: java +sudo: false +script: mvn -Pdev verify +jdk: + - oraclejdk8 + - openjdk8

[GitHub] jena pull request #175: Added .travis.yml

2016-10-08 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/175 Added .travis.yml https://issues.apache.org/jira/browse/JENA-1241 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena TravisCI Alternatively

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-07 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Erm, good/bad news. 1. I can fix the problem @afs found. 2. I don't want to, because I realize now that I did this whole PR wrong. If you read up this page, you'll see

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Got a fix, but I still need to make sure that I didn't break anything else and that I'm not wasting resources and I'm hitting EOB for the day. I will send a commit tomorrow morning (EST).

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 I've been able to reproduce. Investigating... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Weird. Maybe something changed out from under me. This is a pretty old PR. I'll get on it (thanks for the diagnostic info). --- If your project is set up for it, you can reply to this email and

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 @afs ^^^ should have fixed the merge problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Ooh, just noticed that. I will take a look at it today and fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 It would be great if you could use this stuff in RDFConnector to trial it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Yes, as I understand it, we can merge. I haven't merged it because I try never to merge my own stuff unless it's pretty trivial. --- If your project is set up for it, you can reply to this

[GitHub] jena issue #171: Using library code in a few classes

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/171 Made changes in response to your review, @afs . If you have no further objections, I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] jena issue #171: Using library code in a few classes

2016-10-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/171 Now that we have #139 in, I'll add a further commit addressing your points. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] jena issue #139: JSON-LD output

2016-10-03 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/139 @fpservant, No, using that button, you can send a patch for the page now, but it will not be applied until the trigger is pulled to republish the docs pages. That will happen for the release. --- If

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-03 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 @rvesse That is _exactly_ what has slowed this down! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-02 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Code-wise, not that I know of. But I promised @rvesse examples of doing form-based authN for query endpoints. If we're okay with those appearing in docs (instead of the test suite) then I think we

[GitHub] jena issue #170: JENA-1223: Txn promotion for TIM (includes patch for JENA-1...

2016-09-27 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/170 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] jena issue #170: JENA-1223: Txn promotion for TIM (includes patch for JENA-1...

2016-09-27 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/170 Sorry @afs -- I am not used to Github's new "review" mode. I made some comments a while ago, but apparently, I didn't press "Finish review" so you never saw them! --- If

[GitHub] jena pull request #170: JENA-1223: Txn promotion for TIM (includes patch for...

2016-09-27 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/170#discussion_r79304304 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/transaction/AbstractTestTransactionIsolation.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the

[GitHub] jena pull request #170: JENA-1223: Txn promotion for TIM (includes patch for...

2016-09-27 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/170#discussion_r80697618 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/transaction/AbstractTestTransPromote.java --- @@ -270,15 +281,30 @@ private void run_08(boolean b

[GitHub] jena issue #171: Using library code in a few classes

2016-09-27 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/171 Yes, certainly I'll hold off-- I have no idea how I missed that, especially given that I just pointed out that JSON-LD PR to a colleague in a downstream project yesterday! --- If your project i

[GitHub] jena pull request #171: Using library code in a few classes

2016-09-27 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/171#discussion_r80686831 --- Diff: jena-arq/src/main/java/org/apache/jena/atlas/test/Gen.java --- @@ -32,52 +38,35 @@ return rand(numRand, low, high, false

[GitHub] jena pull request #171: Using library code in a few classes

2016-09-27 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/171#discussion_r80686815 --- Diff: jena-arq/src/main/java/org/apache/jena/atlas/test/Gen.java --- @@ -95,19 +84,13 @@ } if ( !found

[GitHub] jena pull request #171: Using library code in a few classes

2016-09-25 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/171 Using library code in a few classes Just a couple of orthogonal commits that use library code in `Collections`, switch to using `default` methods where it seems appropriate, remove assignments with no

[GitHub] jena pull request #:

2016-09-20 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/2610908744464e1247b2896f7b26e78cadf56d84#commitcomment-19102402 In jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java: In jena-arq/src/main/java/org/apache/jena

[GitHub] jena pull request #:

2016-09-20 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/2610908744464e1247b2896f7b26e78cadf56d84#commitcomment-19102347 In jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java: In jena-arq/src/main/java/org/apache/jena

[GitHub] jena pull request #168: JENA-1231: Modernize executeInTransaction

2016-09-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/168#discussion_r78070911 --- Diff: jena-core/src/main/java/org/apache/jena/graph/impl/TransactionHandlerBase.java --- @@ -36,21 +40,45 @@ public TransactionHandlerBase

[GitHub] jena pull request #165: JENA-1228: Expose each optimization transform step i...

2016-08-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/165#discussion_r76616848 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/algebra/optimize/Optimize.java --- @@ -18,82 +18,58 @@ package

[GitHub] jena pull request #165: JENA-1228: Expose each optimization transform step i...

2016-08-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/165#discussion_r76602821 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/algebra/optimize/Optimize.java --- @@ -18,82 +18,58 @@ package

[GitHub] jena pull request #164: JENA-1222 and JENA-1224: Flush queue when large by b...

2016-08-21 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/164#discussion_r75602598 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/transaction/TransactionManager.java --- @@ -613,21 +652,43 @@ public void flush

[GitHub] jena pull request #163: JENA-1225: Remove prefix map when graph is deleted i...

2016-08-19 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/163 JENA-1225: Remove prefix map when graph is deleted in TIM JENA-1225: Remove prefix map when graph is deleted in TIM You can merge this pull request into a Git repository by running: $ git pull

[GitHub] jena issue #161: Plain begin - read transactions promoting to write transact...

2016-08-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/161 Okay, I'll hang tight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] jena issue #161: Plain begin - read transactions promoting to write transact...

2016-08-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/161 Oh, okay, I get it now. And even if you could block, as you wrote above, that could be a really long time in some cases. Do you want me to write something for TIM to bring a version number to the

[GitHub] jena issue #161: Plain begin - read transactions promoting to write transact...

2016-08-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/161 I guess I'm confused as to why one can't determine (from the version numbers) whether another transaction has committed? If you know a transaction's version number and you know the transa

[GitHub] jena issue #161: Plain begin - read transactions promoting to write transact...

2016-08-14 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/161 So ideally, it would be another writer _committing_ that would throw a switch to refuse promotion to extant transactions? Instead of another writer simple existing? --- If your project is set up for

[GitHub] jena issue #160: JENA-1189: Resolve problems with jena-jdbc-driver-tdb tests...

2016-08-10 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/160 Fixed out-of-Github via https://git-wip-us.apache.org/repos/asf?p=jena.git;a=commit;h=e385a0dec7d04c582283d21fdf1923bf937a52db --- If your project is set up for it, you can reply to this email and have

[GitHub] jena pull request #160: JENA-1189: Resolve problems with jena-jdbc-driver-td...

2016-08-10 Thread ajs6f
Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jena issue #161: Plain begin - read transactions promoting to write transact...

2016-08-09 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/161 I like the proposal, basically, although I suspect it might be a little tricky to do the original suggestion of "limited read committed" in current TIM. Adding `readCurrent` would make seem to

[GitHub] jena issue #161: Plain begin - read transactions promoting to write transact...

2016-08-04 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/161 Sorry, I let this go without replying. No, the `DatasetGraphTransaction.promotion` isn't really my concern. It's the fact that you start a read transaction on a dataset, then try to write, a

[GitHub] jena issue #161: Plain begin - read transactions promoting to write transact...

2016-07-28 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/161 At first look, I would prefer the second option for dealing with intervening writes. It's blunter, but it seems a good deal easier for application writers to reason about. But maybe I'm

[GitHub] jena issue #161: Plain begin - read transactions promoting to write transact...

2016-07-28 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/161 Hm, just a first gut reaction about that example API: I would not want to initiate a promotion just by signalling system-wide and then writing. I'd much rather some positive step be taken _on

[GitHub] jena pull request #160: JENA-1189: Resolve problems with jena-jdbc-driver-td...

2016-07-27 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/160 JENA-1189: Resolve problems with jena-jdbc-driver-tdb tests on Macs You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1189-2

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-07-27 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Okay. sounds like I owe the following work for this: - Enriching `HttpOp` to include methods that accept `HttpContext` - A nice suite of examples that @rvesse approves as a path forward --- If

<    2   3   4   5   6   7   8   9   10   11   >