[
https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635215#comment-14635215
]
Ismael Juma commented on KAFKA-251:
---
[~eribeiro], I don't know if it's still relevant as
[
https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-2260:
---
Comment: was deleted
(was: [~dasch] The KIP is:
Hello,
I'm interested in being added to the contributor list for Apache Kafka so
that I may assign myself to newbie JIRA tickets, please.
My JIRA handle is eribeiro.
Cheers,
Eddie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35734/#review92416
---
Ship it!
Ship It!
- Grant Henke
On June 22, 2015, 5:35 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36341/#review92417
---
Ship it!
Ship It!
- Grant Henke
On July 9, 2015, 1:04 a.m., Tim
Kostya Golikov created KAFKA-2352:
-
Summary: Possible memory leak in MirrorMaker and/or new Producer
Key: KAFKA-2352
URL: https://issues.apache.org/jira/browse/KAFKA-2352
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated KAFKA-2338:
--
Attachment: KAFKA-2338_2015-07-21_13:21:19.patch
Warn users if they change max.message.bytes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36578/
---
(Updated July 21, 2015, 4:21 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36565/#review92422
---
Ship it!
Ship It!
- Grant Henke
On July 17, 2015, 5:21 p.m.,
+1 . I think phasing out a good idea but rather than x months we should move
to github PRs for any new JIRAs that are not already in review board.
For the JIRA’s that are in review board we can continue to use that until they
merged in.
-Harsha
On July 21, 2015 at 8:11:17 AM, Ashish Singh
[
https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635281#comment-14635281
]
Daniel Schierbeck commented on KAFKA-2260:
--
Where is the KIP being discussed? I
[
https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635283#comment-14635283
]
Flavio Junqueira commented on KAFKA-2188:
-
hey tim, I had a look at the proposal,
[
https://issues.apache.org/jira/browse/KAFKA-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-388:
--
Resolution: Duplicate
Status: Resolved (was: Patch Available)
This is now handled in KAFKA-1326.
Add
+1 (binding)
Agree with Ismael. We may not want to rush to push the PR right away.
Having said that, if it works well with say, 10 patches, I'd consider that
enough to require the new JIRAs to submit patches using the PRs instead.
Thanks,
Neha
On Tue, Jul 21, 2015 at 8:19 AM, Sriharsha
[
https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635208#comment-14635208
]
Edward Ribeiro commented on KAFKA-251:
--
[~ijuma] Hi, if it is still relevant and no
[
https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635224#comment-14635224
]
Edward Ribeiro commented on KAFKA-251:
--
I cannot. Afaik, it depends on the project,
+1 non-binding.
A suggestion, we should try to phase out old system of reviews gradually,
instead of forcing it over a night. Maybe a time bound switch? We can say
like in x months from now we will completely move to PRs?
On Tuesday, July 21, 2015, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
[
https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635305#comment-14635305
]
Jun Rao commented on KAFKA-2188:
Another thing that's worth mentioning is that currently
[
https://issues.apache.org/jira/browse/KAFKA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostya Golikov updated KAFKA-2352:
--
Description:
I've been playing around with Mirror Maker (version from trunk, dated July 7th)
[
https://issues.apache.org/jira/browse/KAFKA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostya Golikov updated KAFKA-2352:
--
Attachment: producer.conf
consumer.conf
output.log
Possible
GitHub user sslavic opened a pull request:
https://github.com/apache/kafka/pull/91
auto.offset.reset docs not in sync with validation
In this commit
https://github.com/apache/kafka/commit/0699ff2ce60abb466cab5315977a224f1a70a4da#diff-5533ddc72176acd1c32f5abbe94aa672
among other
On July 21, 2015, 2:43 p.m., Ismael Juma wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 454
https://reviews.apache.org/r/36548/diff/2/?file=1013441#file1013441line454
Is `topicData` guaranteed to have a key for `topic`? If not, it's
better to do
[
https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635216#comment-14635216
]
Edward Ribeiro commented on KAFKA-2338:
---
Oh, ignore the previous message,
On Tue, Jul 21, 2015 at 4:11 PM, Ashish Singh asi...@cloudera.com wrote:
+1 non-binding.
A suggestion, we should try to phase out old system of reviews gradually,
instead of forcing it over a night.
I agree.
Maybe a time bound switch? We can say
like in x months from now we will
For 1, yes, when there is a transient leader change, it's guaranteed that a
prefix of the messages in a request will be committed. However, it seems
that the client needs to know what subset of messages are committed in
order to resume the sending. Then the question is how.
As Flavio indicated,
[
https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635330#comment-14635330
]
Edward Ribeiro commented on KAFKA-2338:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636098#comment-14636098
]
Jay Kreps commented on KAFKA-2350:
--
+1 on resume instead of unpause though it doesn't
Edward Ribeiro created KAFKA-2355:
-
Summary: Creating a unit test to validate the deletion of a
partition marked as deleted
Key: KAFKA-2355
URL: https://issues.apache.org/jira/browse/KAFKA-2355
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636105#comment-14636105
]
Jason Gustafson commented on KAFKA-2350:
Hey [~becket_qin], thanks for the
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated KAFKA-2355:
--
Summary: Add an unit test to validate the deletion of a partition marked as
deleted (was:
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated KAFKA-2355:
--
Issue Type: Test (was: Sub-task)
Parent: (was: KAFKA-2345)
Add an unit test to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670/#review92551
---
Ship it!
Thanks for the patch Edward.
- Ashish Singh
On July
+1 (non binding)
On Tue, Jul 21, 2015 at 7:36 PM, Jay Kreps j...@confluent.io wrote:
+1
-Jay
On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
I would like to start a vote on switching to GitHub pull requests for new
contributions. To be precise, the
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636116#comment-14636116
]
Edward Ribeiro commented on KAFKA-2355:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated KAFKA-2355:
--
Attachment: KAFKA-2355.patch
Add an unit test to validate the deletion of a partition marked
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670/
---
Review request for kafka.
Bugs: KAFKA-2355
On July 21, 2015, 11:15 p.m., Gwen Shapira wrote:
Thanks for looking into that. Exception handling was the most challenging
part of rewriting SocketServer, so I'm glad to see more eyes on this
implementation.
I have a concern regarding the right way to handle an unexpected
[
https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635231#comment-14635231
]
Ismael Juma commented on KAFKA-251:
---
[~eribeiro], I am not a committer and I can. :) Ask
[
https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635289#comment-14635289
]
Ismael Juma commented on KAFKA-2260:
[~dasch] The KIP is:
+1 non-binding
On Tue, Jul 21, 2015 at 11:19 AM, Neha Narkhede n...@confluent.io wrote:
+1 (binding)
Agree with Ismael. We may not want to rush to push the PR right away.
Having said that, if it works well with say, 10 patches, I'd consider that
enough to require the new JIRAs to submit
+1
On Tue, Jul 21, 2015 at 9:31 AM, Grant Henke ghe...@cloudera.com wrote:
+1 non-binding
On Tue, Jul 21, 2015 at 11:19 AM, Neha Narkhede n...@confluent.io wrote:
+1 (binding)
Agree with Ismael. We may not want to rush to push the PR right away.
Having said that, if it works well
In KV store usage, all instances are writers, aren't they? There is no
leader or master, thus there is no fail over. The offset based CAS ensures
an update is based on the latest value and doesn't care who is writing the
new value.
I think the idea of the offset based CAS is great. I think it
+1 (binding) on using PRs.
It sounds like we need additional discussion on how the transition
will happen. Maybe move that to a separate thread, to keep the vote
easy to follow.
On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
I would like to start a vote on
Any ideas?
On Mon, Jul 20, 2015 at 2:34 PM, Pranay Agarwal agarwalpran...@gmail.com
wrote:
Hi all,
Is there any way I can force Zookeeper/Kafka to rebalance new consumers
only for subset of total number of partitions. I have a situation where out
of 120 partitions 60 have been already
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-2342:
---
Summary: KafkaConsumer rebalance with in-flight fetch can cause invalid
position (was:
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-2342:
---
Description:
If a rebalance occurs with an in-flight fetch, the new KafkaConsumer can end up
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636074#comment-14636074
]
Jiangjie Qin edited comment on KAFKA-2350 at 7/22/15 12:44 AM:
[
https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636235#comment-14636235
]
Jiangjie Qin commented on KAFKA-2353:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36664/
---
(Updated July 22, 2015, 5:02 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated KAFKA-2355:
--
Affects Version/s: 0.8.2.1
Status: Patch Available (was: Open)
Add an unit
On July 21, 2015, 11:15 p.m., Gwen Shapira wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 465
https://reviews.apache.org/r/36664/diff/1/?file=1018238#file1018238line465
Turns out that catching Throwable is a really bad idea:
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636319#comment-14636319
]
Jiangjie Qin commented on KAFKA-2350:
-
[~jkreps][~hachikuji], I actually was not
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636119#comment-14636119
]
Edward Ribeiro commented on KAFKA-2355:
---
Hi [~singhashish] and [~gwenshap]. I hope
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36578/#review92526
---
core/src/main/scala/kafka/server/AbstractFetcherThread.scala (line
Thanks Mayuresh,
Can I at least control the rebalance of consumers? Currently consumes die
after specific partition has no more messages, and there is rebalance of
consumes triggered, which causes more consumers to die who get assigned to
empty partition(because zookeeper treat empty partition no
[
https://issues.apache.org/jira/browse/KAFKA-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava resolved KAFKA-863.
-
Resolution: Won't Fix
Assignee: Ewen Cheslack-Postava
Fix
Hi,
I had to clean up existing kafka repo on my linux box and start with a
fresh one.
I followed the instructions here :
https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review
I am trying to upload a patch and I am getting these errors :
Configuring reviewboard url to
Jiangjie Qin created KAFKA-2353:
---
Summary: SocketServer.Processor should catch exception and close
the socket properly in configureNewConnections.
Key: KAFKA-2353
URL:
Did you setup your jira.ini?
On Tue, Jul 21, 2015 at 11:52 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
Hi,
I had to clean up existing kafka repo on my linux box and start with a
fresh one.
I followed the instructions here :
Yes.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Did you setup your jira.ini?
On Tue, Jul 21, 2015 at 11:52 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
Hi,
I had to clean up existing kafka repo on my linux box
Not sure if you can do that with High level consumer.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 10:53 AM, Pranay Agarwal agarwalpran...@gmail.com
wrote:
Any ideas?
On Mon, Jul 20, 2015 at 2:34 PM, Pranay Agarwal agarwalpran...@gmail.com
wrote:
Hi all,
Is there any way I can force
[
https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2299:
--
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
Moving to Github PRs, so
[
https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh closed KAFKA-2299.
-
kafka-patch-review tool does not correctly capture testing done
+1 (non-binding)
Thanks
Parth
On 7/21/15, 10:24 AM, Gwen Shapira gshap...@cloudera.com wrote:
+1 (binding) on using PRs.
It sounds like we need additional discussion on how the transition
will happen. Maybe move that to a separate thread, to keep the vote
easy to follow.
On Tue, Jul 21, 2015
[
https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635915#comment-14635915
]
Michael Graff commented on KAFKA-2354:
--
Closing as this now appears to be a local
[
https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Graff resolved KAFKA-2354.
--
Resolution: Not A Problem
setting log.dirs property makes tools fail if there is a comma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36652/#review92488
---
Ship it!
Latest patch looks good to me.
- Jiangjie Qin
On July
On July 21, 2015, 8:18 p.m., Mayuresh Gharat wrote:
T
Yes. Got it, I thought that we should be catching all exceptions and exit. But
doing the above will catch the exception and exit when its shutting down and
thats the only thing that this ticket considers.
- Mayuresh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36652/#review92470
---
core/src/main/scala/kafka/network/SocketServer.scala (line 266)
Michael Graff created KAFKA-2354:
Summary: setting log.dirs property makes tools fail if there is a
comma
Key: KAFKA-2354
URL: https://issues.apache.org/jira/browse/KAFKA-2354
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635864#comment-14635864
]
Edward Ribeiro commented on KAFKA-2354:
---
Hi [~Skandragon], unfortunately, I was
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36652/
---
(Updated July 21, 2015, 9:58 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2351:
---
Attachment: KAFKA-2351_2015-07-21_14:58:13.patch
Brokers are having a problem shutting down
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635885#comment-14635885
]
Mayuresh Gharat commented on KAFKA-2351:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2351:
---
Status: Patch Available (was: Open)
Brokers are having a problem shutting down correctly
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2351:
---
Attachment: KAFKA-2351.patch
Brokers are having a problem shutting down correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36652/
---
Review request for kafka.
Bugs: KAFKA-2351
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36652/#review92465
---
Thanks for the patch, some comments.
On July 21, 2015, 8:26 p.m., Grant Henke wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 266
https://reviews.apache.org/r/36652/diff/1/?file=1018073#file1018073line266
What errors were seen that should be caught here? Can we catch a more
specific exception and
Resolved this.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 12:59 PM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
Yes.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Did you setup your jira.ini?
On Tue, Jul 21, 2015 at
On July 21, 2015, 8:26 p.m., Grant Henke wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 266
https://reviews.apache.org/r/36652/diff/1/?file=1018073#file1018073line266
What errors were seen that should be caught here? Can we catch a more
specific exception and
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635734#comment-14635734
]
Mayuresh Gharat commented on KAFKA-2351:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Graff updated KAFKA-2354:
-
Description:
If one sets log.dirs=/u1/kafka,/u2/kafka, the tools fail to run:
kafka-topics
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636074#comment-14636074
]
Jiangjie Qin commented on KAFKA-2350:
-
I am thinking that currently we keep two
+1
-Jay
On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
I would like to start a vote on switching to GitHub pull requests for new
contributions. To be precise, the vote is on whether we should:
* Update the documentation to tell users to use pull requests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36664/
---
Review request for kafka.
Bugs: KAFKA-2353
[
https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635987#comment-14635987
]
Jiangjie Qin commented on KAFKA-2353:
-
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36664/#review92496
---
Thanks for looking into that. Exception handling was the most
[
https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-2353:
Attachment: KAFKA-2353.patch
SocketServer.Processor should catch exception and close the socket
[
https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-2353:
Status: Patch Available (was: Open)
SocketServer.Processor should catch exception and close the
[
https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636020#comment-14636020
]
Jiangjie Qin commented on KAFKA-2353:
-
[~gwenshap] Can you help take a look at this
[
https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636040#comment-14636040
]
Gwen Shapira commented on KAFKA-2353:
-
I left comments in RB :)
[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt updated KAFKA-2210:
Attachment: KAFKA-2210_2015-07-21_17:08:21.patch
KafkaAuthorizer: Add all public entities,
On June 1, 2015, 1:11 a.m., Jun Rao wrote:
Thanks for that patch. A few comments below.
Also, two common types of users are consumers and publishers. Currently, if
you want to allow a user to consume from topic t in consumer group g, you
have to grant (1) read permission on topic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/
---
(Updated July 22, 2015, 12:08 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636051#comment-14636051
]
Parth Brahmbhatt commented on KAFKA-2210:
-
Updated reviewboard
On July 21, 2015, 1:57 a.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/server/KafkaApis.scala, line 151
https://reviews.apache.org/r/34492/diff/8/?file=1017303#file1017303line151
Please, put a space between ``if`` and ``(`` here.
Fixed.
- Parth
On July 21, 2015, 1:43 a.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/server/KafkaApis.scala, line 624
https://reviews.apache.org/r/34492/diff/8/?file=1017303#file1017303line624
Lines L#620 and L#621 could be merged (with a ) into a single
if-condition. No need for nested
On July 21, 2015, 1:55 a.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/security/auth/Operation.scala, line 43
https://reviews.apache.org/r/34492/diff/8/?file=1017299#file1017299line43
The ``return`` here is redundant.
Fixed.
- Parth
On July 21, 2015, 1:50 a.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/security/auth/KafkaPrincipal.scala, line 28
https://reviews.apache.org/r/34492/diff/8/?file=1017298#file1017298line28
Please, put a space between ``if`` and ``(``.
fixed.
- Parth
1 - 100 of 133 matches
Mail list logo
