[jira] [Resolved] (LENS-1541) Documentation changes required for code merge changes
[ https://issues.apache.org/jira/browse/LENS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu resolved LENS-1541. --- Resolution: Fixed Fix Version/s: 2.8 > Documentation changes required for code merge changes > - > > Key: LENS-1541 > URL: https://issues.apache.org/jira/browse/LENS-1541 > Project: Apache Lens > Issue Type: Task > Components: docs >Reporter: Rajitha R >Assignee: Rajitha R >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Based on following voting, > [https://lists.apache.org/thread.html/73d86d2f1f73732c7ade60773956d0052458d1433b1f7688bba8caea@%3Cdev.lens.apache.org%3E] > the documentation needs minor changes. The ticket captures the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LENS-1541) Documentation changes required for code merge changes
[ https://issues.apache.org/jira/browse/LENS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825106#comment-16825106 ] Amareshwari Sriramadasu commented on LENS-1541: --- Merged [https://github.com/apache/lens/pull/32]. Thanks [~rajitha.r] for the contribution > Documentation changes required for code merge changes > - > > Key: LENS-1541 > URL: https://issues.apache.org/jira/browse/LENS-1541 > Project: Apache Lens > Issue Type: Task > Components: docs >Reporter: Rajitha R >Assignee: Rajitha R >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Based on following voting, > [https://lists.apache.org/thread.html/73d86d2f1f73732c7ade60773956d0052458d1433b1f7688bba8caea@%3Cdev.lens.apache.org%3E] > the documentation needs minor changes. The ticket captures the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (LENS-1538) Lens HA changes
[ https://issues.apache.org/jira/browse/LENS-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1538: -- Resolution: Fixed Fix Version/s: 2.8 Status: Resolved (was: Patch Available) Attached patch from review board here and committed the same. Thanks [~ankitkailaswar] for the contribution ! > Lens HA changes > --- > > Key: LENS-1538 > URL: https://issues.apache.org/jira/browse/LENS-1538 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar >Priority: Major > Fix For: 2.8 > > Attachments: Lens-1538_8.diff, Lens-1538_9.diff > > > # > h1. Implementation > # > h2. Session > # We need to persist all client session in database. > # This involve persisting client session’s id and configuration in mysql > server. persisting entire session object is not required. We need to do this > as first thing while creating user session. > # For each request from client lens server should not validate session id > from its in memory map. It should rather validate it from persisted session > in mysql server. > if > session is present in mysql and not present in lens server’s in memory > map(session manager) then it should create a lens session with same session > id and add it to in memory map > else If > session is not present in mysql and present in server’s in memory map then it > signifies that user have initiated close session from other host and we will > need to remove this session from current host’s in memory map as well > else if > session is not present in mysql and in server’s in memory map then return > “invalid session”. > # Whenever session expired/closed then we need to remove this session from > lens server’s in memory map and mysql. > > # > h2. *Query* > # For sync queries lens server will close connection as soon as it is > stopped or failed with appropriate failure message. Client will be retrying > the query. > # For async-light queries and async-heavy queries lens server takes care of > rescheduling all queries which were in running or queued state at the time of > restart. we can use this to make query ids available with both servers. > # For async queries we need to persist all non finished async user queries > in mysql server in new table current_query. > # If user executes query on host1 and it goes down and nginx points to host2 > then user should be able to poll on query status. Lens server will first > check query id in its inmemory maps if it is not present then it will check > in “finished_query” table in mysql else in “current_query” table in mysql. In > this case we will continue showing old status of query since it is scheduled > by host1. As soon as host1 comes up it will reschedule these queries and will > change the status. Optionally we can have host2 to move these queries in > “allqueries” map of its query service which will take care of recovering, in > this case we don't need to wait for host1 to come up and reschedule. > # While moving query from ”finished_quey” map to “finished_query” table in > mysql we will need to remove it from “current_query” tables as well. > # This flow will remain same for request ids/query ids generated for query > plan/estimate. > > # > h1. Issue addressed > # Lens downtime will be zero in case of deployment and if primary fail. > # User will not have to create a new session whenever switch happens > # User will be able to get status of all async queries seamlessly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (LENS-1538) Lens HA changes
[ https://issues.apache.org/jira/browse/LENS-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1538: -- Attachment: Lens-1538_9.diff > Lens HA changes > --- > > Key: LENS-1538 > URL: https://issues.apache.org/jira/browse/LENS-1538 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar >Priority: Major > Attachments: Lens-1538_8.diff, Lens-1538_9.diff > > > # > h1. Implementation > # > h2. Session > # We need to persist all client session in database. > # This involve persisting client session’s id and configuration in mysql > server. persisting entire session object is not required. We need to do this > as first thing while creating user session. > # For each request from client lens server should not validate session id > from its in memory map. It should rather validate it from persisted session > in mysql server. > if > session is present in mysql and not present in lens server’s in memory > map(session manager) then it should create a lens session with same session > id and add it to in memory map > else If > session is not present in mysql and present in server’s in memory map then it > signifies that user have initiated close session from other host and we will > need to remove this session from current host’s in memory map as well > else if > session is not present in mysql and in server’s in memory map then return > “invalid session”. > # Whenever session expired/closed then we need to remove this session from > lens server’s in memory map and mysql. > > # > h2. *Query* > # For sync queries lens server will close connection as soon as it is > stopped or failed with appropriate failure message. Client will be retrying > the query. > # For async-light queries and async-heavy queries lens server takes care of > rescheduling all queries which were in running or queued state at the time of > restart. we can use this to make query ids available with both servers. > # For async queries we need to persist all non finished async user queries > in mysql server in new table current_query. > # If user executes query on host1 and it goes down and nginx points to host2 > then user should be able to poll on query status. Lens server will first > check query id in its inmemory maps if it is not present then it will check > in “finished_query” table in mysql else in “current_query” table in mysql. In > this case we will continue showing old status of query since it is scheduled > by host1. As soon as host1 comes up it will reschedule these queries and will > change the status. Optionally we can have host2 to move these queries in > “allqueries” map of its query service which will take care of recovering, in > this case we don't need to wait for host1 to come up and reschedule. > # While moving query from ”finished_quey” map to “finished_query” table in > mysql we will need to remove it from “current_query” tables as well. > # This flow will remain same for request ids/query ids generated for query > plan/estimate. > > # > h1. Issue addressed > # Lens downtime will be zero in case of deployment and if primary fail. > # User will not have to create a new session whenever switch happens > # User will be able to get status of all async queries seamlessly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LENS-1538) Lens HA changes
[ https://issues.apache.org/jira/browse/LENS-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753691#comment-16753691 ] Amareshwari Sriramadasu commented on LENS-1538: --- [~ankitkailaswar] Was waiting for jenkins run for the patch. But did not happen. Can you check if there is any issue? Thanks > Lens HA changes > --- > > Key: LENS-1538 > URL: https://issues.apache.org/jira/browse/LENS-1538 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar >Priority: Major > Attachments: Lens-1538_8.diff > > > # > h1. Implementation > # > h2. Session > # We need to persist all client session in database. > # This involve persisting client session’s id and configuration in mysql > server. persisting entire session object is not required. We need to do this > as first thing while creating user session. > # For each request from client lens server should not validate session id > from its in memory map. It should rather validate it from persisted session > in mysql server. > if > session is present in mysql and not present in lens server’s in memory > map(session manager) then it should create a lens session with same session > id and add it to in memory map > else If > session is not present in mysql and present in server’s in memory map then it > signifies that user have initiated close session from other host and we will > need to remove this session from current host’s in memory map as well > else if > session is not present in mysql and in server’s in memory map then return > “invalid session”. > # Whenever session expired/closed then we need to remove this session from > lens server’s in memory map and mysql. > > # > h2. *Query* > # For sync queries lens server will close connection as soon as it is > stopped or failed with appropriate failure message. Client will be retrying > the query. > # For async-light queries and async-heavy queries lens server takes care of > rescheduling all queries which were in running or queued state at the time of > restart. we can use this to make query ids available with both servers. > # For async queries we need to persist all non finished async user queries > in mysql server in new table current_query. > # If user executes query on host1 and it goes down and nginx points to host2 > then user should be able to poll on query status. Lens server will first > check query id in its inmemory maps if it is not present then it will check > in “finished_query” table in mysql else in “current_query” table in mysql. In > this case we will continue showing old status of query since it is scheduled > by host1. As soon as host1 comes up it will reschedule these queries and will > change the status. Optionally we can have host2 to move these queries in > “allqueries” map of its query service which will take care of recovering, in > this case we don't need to wait for host1 to come up and reschedule. > # While moving query from ”finished_quey” map to “finished_query” table in > mysql we will need to remove it from “current_query” tables as well. > # This flow will remain same for request ids/query ids generated for query > plan/estimate. > > # > h1. Issue addressed > # Lens downtime will be zero in case of deployment and if primary fail. > # User will not have to create a new session whenever switch happens > # User will be able to get status of all async queries seamlessly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LENS-1541) Documentation changes required for code merge changes
[
https://issues.apache.org/jira/browse/LENS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753690#comment-16753690
]
Amareshwari Sriramadasu commented on LENS-1541:
---
{quote}Do we still need the patch to be uploaded separately in the Jira or that
can be skipped? Also trying to understand the impact of that on the automatic
jenkins setup.
{quote}
Not seeing automated jenkins job running. Was waiting for jenkins run of
LENS-1538. But did not happen. On github movement, we can explore ways to
integrate github with jenkins build. We can avoid patch being uploaded.
> Documentation changes required for code merge changes
> -
>
> Key: LENS-1541
> URL: https://issues.apache.org/jira/browse/LENS-1541
> Project: Apache Lens
> Issue Type: Task
> Components: docs
>Reporter: Rajitha R
>Assignee: Rajitha R
>Priority: Major
>
> Based on following voting,
> [https://lists.apache.org/thread.html/73d86d2f1f73732c7ade60773956d0052458d1433b1f7688bba8caea@%3Cdev.lens.apache.org%3E]
> the documentation needs minor changes. The ticket captures the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Review Request 69554: Lens HA changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review212304 --- Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 24, 2019, 11:32 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69554/ > --- > > (Updated Jan. 24, 2019, 11:32 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajitha R. > > > Bugs: LENS-1538 > https://issues.apache.org/jira/browse/LENS-1538 > > > Repository: lens > > > Description > --- > > Implementation > > Session > > We need to persist all client session in database. > This involve persisting client session’s id and configuration in mysql > server. persisting entire session object is not required. We need to do this > as first thing while creating user session. > For each request from client lens server should not validate session id > from its in memory map. It should rather validate it from persisted session > in mysql server. > > if > > session is present in mysql and not present in lens server’s in memory > map(session manager) then it should create a lens session with same session > id and add it to in memory map > > else If > > session is not present in mysql and present in server’s in memory map then it > signifies that user have initiated close session from other host and we will > need to remove this session from current host’s in memory map as well > > else if > > session is not present in mysql and in server’s in memory map then return > “invalid session”. > > Whenever session expired/closed then we need to remove this session from > lens server’s in memory map and mysql. > > > > Query > > For sync queries lens server will close connection as soon as it is > stopped or failed with appropriate failure message. Client will be retrying > the query. > For async-light queries and async-heavy queries lens server takes care of > rescheduling all queries which were in running or queued state at the time of > restart. we can use this to make query ids available with both servers. > For async queries we need to persist all non finished async user queries > in mysql server in new table current_query. > If user executes query on host1 and it goes down and nginx points to > host2 then user should be able to poll on query status. Lens server will > first check query id in its inmemory maps if it is not present then it will > check in “finished_query” table in mysql else in “current_query” table in > mysql. In this case we will continue showing old status of query since it is > scheduled by host1. As soon as host1 comes up it will reschedule these > queries and will change the status. Optionally we can have host2 to move > these queries in “allqueries” map of its query service which will take care > of recovering, in this case we don't need to wait for host1 to come up and > reschedule. > While moving query from ”finished_quey” map to “finished_query” table in > mysql we will need to remove it from “current_query” tables as well. > This flow will remain same for request ids/query ids generated for query > plan/estimate. > > > > Issue addressed > > Lens downtime will be zero in case of deployment and if primary fail. > User will not have to create a new session whenever switch happens > User will be able to get status of all async queries seamlessly. > > > Build Log : > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [2.740s] > [INFO] Lens .. SUCCESS [5.788s] > [INFO] Lens API .. SUCCESS [48.711s] > [INFO] Lens API for server and extensions SUCCESS [33.537s] > [INFO] Lens Cube . SUCCESS [7:43.672s] > [INFO] Lens DB storage ... SUCCESS [29.279s] > [INFO] Lens Query Library SUCCESS [22.507s] > [INFO] Lens Hive Driver .. SUCCESS [1:27.344s] > [INFO] Lens Driver for JDBC .. SUCCESS [1:24.416s] > [INFO] Lens Elastic Search Driver SUCCESS [44.067s]
Re: Review Request 69554: Lens HA changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review212235 --- lens-client/src/test/java/org/apache/lens/client/TestLensClient.java Line 292 (original) <https://reviews.apache.org/r/69554/#comment297958> Why is fail assert removed? No more socket exception expected? If so, whats up with catch block below? lens-server/src/main/java/org/apache/lens/server/BaseLensService.java Line 571 (original), 577 (patched) <https://reviews.apache.org/r/69554/#comment297959> why is method renamed to get, which is not returning any session here? lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 112 (patched) <https://reviews.apache.org/r/69554/#comment297960> remove commented code? - Amareshwari Sriramadasu On Jan. 22, 2019, 11:08 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69554/ > --- > > (Updated Jan. 22, 2019, 11:08 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajitha R. > > > Bugs: LENS-1538 > https://issues.apache.org/jira/browse/LENS-1538 > > > Repository: lens > > > Description > --- > > Implementation > > Session > > We need to persist all client session in database. > This involve persisting client session’s id and configuration in mysql > server. persisting entire session object is not required. We need to do this > as first thing while creating user session. > For each request from client lens server should not validate session id > from its in memory map. It should rather validate it from persisted session > in mysql server. > > if > > session is present in mysql and not present in lens server’s in memory > map(session manager) then it should create a lens session with same session > id and add it to in memory map > > else If > > session is not present in mysql and present in server’s in memory map then it > signifies that user have initiated close session from other host and we will > need to remove this session from current host’s in memory map as well > > else if > > session is not present in mysql and in server’s in memory map then return > “invalid session”. > > Whenever session expired/closed then we need to remove this session from > lens server’s in memory map and mysql. > > > > Query > > For sync queries lens server will close connection as soon as it is > stopped or failed with appropriate failure message. Client will be retrying > the query. > For async-light queries and async-heavy queries lens server takes care of > rescheduling all queries which were in running or queued state at the time of > restart. we can use this to make query ids available with both servers. > For async queries we need to persist all non finished async user queries > in mysql server in new table current_query. > If user executes query on host1 and it goes down and nginx points to > host2 then user should be able to poll on query status. Lens server will > first check query id in its inmemory maps if it is not present then it will > check in “finished_query” table in mysql else in “current_query” table in > mysql. In this case we will continue showing old status of query since it is > scheduled by host1. As soon as host1 comes up it will reschedule these > queries and will change the status. Optionally we can have host2 to move > these queries in “allqueries” map of its query service which will take care > of recovering, in this case we don't need to wait for host1 to come up and > reschedule. > While moving query from ”finished_quey” map to “finished_query” table in > mysql we will need to remove it from “current_query” tables as well. > This flow will remain same for request ids/query ids generated for query > plan/estimate. > > > > Issue addressed > > Lens downtime will be zero in case of deployment and if primary fail. > User will not have to create a new session whenever switch happens > User will be able to get status of all async queries seamlessly. > > > Build Log : > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [2.740s] > [INFO] Lens ..
Re: Review Request 69748: Update git-wip-us by gitbox in Lens doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69748/#review212046 --- Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 15, 2019, 9:54 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69748/ > --- > > (Updated Jan. 15, 2019, 9:54 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-1540 > https://issues.apache.org/jira/browse/LENS-1540 > > > Repository: lens > > > Description > --- > > Update git-wip-us by gitbox in Lens doc > > > Diffs > - > > lens-server/enunciate.xml 36b68d1 > lens-ui/package.json b35d300 > pom.xml 562e06e > src/site/apt/developer/commit.apt a99b6b8 > src/site/apt/developer/contribute.apt 3358052 > > > Diff: https://reviews.apache.org/r/69748/diff/1/ > > > Testing > --- > > N/A > > > Thanks, > > Rajitha R > >
Re: Review Request 69554: Lens HA changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review211711 --- No unit tests added for the change introduced. Can you add unit tests? - Amareshwari Sriramadasu On Dec. 24, 2018, 10:50 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69554/ > --- > > (Updated Dec. 24, 2018, 10:50 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajitha R. > > > Bugs: LENS-1538 > https://issues.apache.org/jira/browse/LENS-1538 > > > Repository: lens > > > Description > --- > > Implementation > > Session > > We need to persist all client session in database. > This involve persisting client session’s id and configuration in mysql > server. persisting entire session object is not required. We need to do this > as first thing while creating user session. > For each request from client lens server should not validate session id > from its in memory map. It should rather validate it from persisted session > in mysql server. > > if > > session is present in mysql and not present in lens server’s in memory > map(session manager) then it should create a lens session with same session > id and add it to in memory map > > else If > > session is not present in mysql and present in server’s in memory map then it > signifies that user have initiated close session from other host and we will > need to remove this session from current host’s in memory map as well > > else if > > session is not present in mysql and in server’s in memory map then return > “invalid session”. > > Whenever session expired/closed then we need to remove this session from > lens server’s in memory map and mysql. > > > > Query > > For sync queries lens server will close connection as soon as it is > stopped or failed with appropriate failure message. Client will be retrying > the query. > For async-light queries and async-heavy queries lens server takes care of > rescheduling all queries which were in running or queued state at the time of > restart. we can use this to make query ids available with both servers. > For async queries we need to persist all non finished async user queries > in mysql server in new table current_query. > If user executes query on host1 and it goes down and nginx points to > host2 then user should be able to poll on query status. Lens server will > first check query id in its inmemory maps if it is not present then it will > check in “finished_query” table in mysql else in “current_query” table in > mysql. In this case we will continue showing old status of query since it is > scheduled by host1. As soon as host1 comes up it will reschedule these > queries and will change the status. Optionally we can have host2 to move > these queries in “allqueries” map of its query service which will take care > of recovering, in this case we don't need to wait for host1 to come up and > reschedule. > While moving query from ”finished_quey” map to “finished_query” table in > mysql we will need to remove it from “current_query” tables as well. > This flow will remain same for request ids/query ids generated for query > plan/estimate. > > > > Issue addressed > > Lens downtime will be zero in case of deployment and if primary fail. > User will not have to create a new session whenever switch happens > User will be able to get status of all async queries seamlessly. > > > Diffs > - > > > lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java > 65403191 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java > 94734658 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 9364872d > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > ef43371a > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > cc6ca7d4 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 07a2107a > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > f6d43d70 > > > Diff: https://reviews.apache.org/r/69554/diff/6/ > > > Testing > --- > > Unit testing > > > Thanks, > > Ankit Kailaswar > >
Re: Review Request 69554: Lens HA changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review211710 --- lens-server/src/main/java/org/apache/lens/server/BaseLensService.java Lines 133 (patched) <https://reviews.apache.org/r/69554/#comment297232> Why is DAO created for every lens service? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java Lines 1176 (patched) <https://reviews.apache.org/r/69554/#comment297233> no counter for failures? lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 91 (patched) <https://reviews.apache.org/r/69554/#comment297234> declaration required here? Can you mark with required scope - private or protected? lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 397 (patched) <https://reviews.apache.org/r/69554/#comment297235> Is initialized in BaseLensService as well. - Amareshwari Sriramadasu On Dec. 24, 2018, 10:50 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69554/ > --- > > (Updated Dec. 24, 2018, 10:50 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajitha R. > > > Bugs: LENS-1538 > https://issues.apache.org/jira/browse/LENS-1538 > > > Repository: lens > > > Description > --- > > Implementation > > Session > > We need to persist all client session in database. > This involve persisting client session’s id and configuration in mysql > server. persisting entire session object is not required. We need to do this > as first thing while creating user session. > For each request from client lens server should not validate session id > from its in memory map. It should rather validate it from persisted session > in mysql server. > > if > > session is present in mysql and not present in lens server’s in memory > map(session manager) then it should create a lens session with same session > id and add it to in memory map > > else If > > session is not present in mysql and present in server’s in memory map then it > signifies that user have initiated close session from other host and we will > need to remove this session from current host’s in memory map as well > > else if > > session is not present in mysql and in server’s in memory map then return > “invalid session”. > > Whenever session expired/closed then we need to remove this session from > lens server’s in memory map and mysql. > > > > Query > > For sync queries lens server will close connection as soon as it is > stopped or failed with appropriate failure message. Client will be retrying > the query. > For async-light queries and async-heavy queries lens server takes care of > rescheduling all queries which were in running or queued state at the time of > restart. we can use this to make query ids available with both servers. > For async queries we need to persist all non finished async user queries > in mysql server in new table current_query. > If user executes query on host1 and it goes down and nginx points to > host2 then user should be able to poll on query status. Lens server will > first check query id in its inmemory maps if it is not present then it will > check in “finished_query” table in mysql else in “current_query” table in > mysql. In this case we will continue showing old status of query since it is > scheduled by host1. As soon as host1 comes up it will reschedule these > queries and will change the status. Optionally we can have host2 to move > these queries in “allqueries” map of its query service which will take care > of recovering, in this case we don't need to wait for host1 to come up and > reschedule. > While moving query from ”finished_quey” map to “finished_query” table in > mysql we will need to remove it from “current_query” tables as well. > This flow will remain same for request ids/query ids generated for query > plan/estimate. > > > > Issue addressed > > Lens downtime will be zero in case of deployment and if primary fail. > User will not have to create a new session whenever switch happens > User will be able to get status of all async queries seamlessly. > > > Diffs > - > > > lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java > 65403191 > >
[jira] [Resolved] (LENS-1531) Lens driver not picking hadoop conf
[ https://issues.apache.org/jira/browse/LENS-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu resolved LENS-1531. --- Resolution: Won't Fix > Lens driver not picking hadoop conf > --- > > Key: LENS-1531 > URL: https://issues.apache.org/jira/browse/LENS-1531 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Rajashekhar >Priority: Major > > Lens driver not picking hadoop conf > > The PR is here: [https://github.com/apache/lens/pull/26] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LENS-1533) Adding support for Partition Columns to queried without giving additional xml tag valid.columns
[ https://issues.apache.org/jira/browse/LENS-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623022#comment-16623022 ] Amareshwari Sriramadasu commented on LENS-1533: --- Thanks for the contribution [~rajashekha...@inmobi.com]. Added you to contributors list and assigned the issue to you. Seems example testcase failed with this patch, Can you update an incremental patch for fixing the same? Thanks > Adding support for Partition Columns to queried without giving additional xml > tag valid.columns > --- > > Key: LENS-1533 > URL: https://issues.apache.org/jira/browse/LENS-1533 > Project: Apache Lens > Issue Type: Improvement > Components: server >Affects Versions: 2.8 >Reporter: Rajashekhar >Assignee: Rajashekhar >Priority: Major > Fix For: 2.8 > > Attachments: LENS-1533.1.patch, LENS-1533.patch > > > Adding support for Partition Columns to queried without giving additional xml > tag valid.columns > PR: > https://reviews.apache.org/r/68520/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (LENS-1533) Adding support for Partition Columns to queried without giving additional xml tag valid.columns
[ https://issues.apache.org/jira/browse/LENS-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1533: -- Status: Reopened (was: Closed) > Adding support for Partition Columns to queried without giving additional xml > tag valid.columns > --- > > Key: LENS-1533 > URL: https://issues.apache.org/jira/browse/LENS-1533 > Project: Apache Lens > Issue Type: Improvement > Components: server >Affects Versions: 2.8 >Reporter: Rajashekhar >Assignee: Rajashekhar >Priority: Major > Fix For: 2.8 > > Attachments: LENS-1533.1.patch, LENS-1533.patch > > > Adding support for Partition Columns to queried without giving additional xml > tag valid.columns > PR: > https://reviews.apache.org/r/68520/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (LENS-1533) Adding support for Partition Columns to queried without giving additional xml tag valid.columns
[ https://issues.apache.org/jira/browse/LENS-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu reassigned LENS-1533: - Assignee: Rajashekhar > Adding support for Partition Columns to queried without giving additional xml > tag valid.columns > --- > > Key: LENS-1533 > URL: https://issues.apache.org/jira/browse/LENS-1533 > Project: Apache Lens > Issue Type: Improvement > Components: server >Affects Versions: 2.8 >Reporter: Rajashekhar >Assignee: Rajashekhar >Priority: Major > Fix For: 2.8 > > Attachments: LENS-1533.1.patch, LENS-1533.patch > > > Adding support for Partition Columns to queried without giving additional xml > tag valid.columns > PR: > https://reviews.apache.org/r/68520/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 68520: LENS-1533: Adding support for Partition Columns to queried without giving additional xml tag valid.columns
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68520/#review208764 --- Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 19, 2018, 5:56 a.m., Rajashekhar Choukimath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68520/ > --- > > (Updated Sept. 19, 2018, 5:56 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Ankit Kailaswar, and > Rajitha R. > > > Bugs: LENS-1533 > https://issues.apache.org/jira/browse/LENS-1533 > > > Repository: lens > > > Description > --- > > LENS-1533: Adding support for Partition Columns to queried without giving > additional xml tag valid.columns > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 8f3f4aa9 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e6afcff9 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > 96948ccb > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > e351d7fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > 7dfb1668 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 44411f20 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 193ce6b3 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 6f054c45 > > lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java > 7c8fd2cc > lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java > 1aa993b6 > lens-examples/src/main/resources/cube-queries.sql 01691758 > lens-examples/src/main/resources/fact3-local-part.xml PRE-CREATION > lens-examples/src/main/resources/fact3-local1.data PRE-CREATION > lens-examples/src/main/resources/fact3-local2.data PRE-CREATION > lens-examples/src/main/resources/fact3.xml PRE-CREATION > lens-examples/src/main/resources/sample-cube.xml 6b17da53 > > > Diff: https://reviews.apache.org/r/68520/diff/2/ > > > Testing > --- > > Done on Local Test VM. > > > Thanks, > > Rajashekhar Choukimath > >
Re: Review Request 68670: Authorizer Instance to be made singleton for resource optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68670/#review208475 --- Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 10, 2018, 4:28 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68670/ > --- > > (Updated Sept. 10, 2018, 4:28 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Ankit Kailaswar. > > > Bugs: LENS-1534 > https://issues.apache.org/jira/browse/LENS-1534 > > > Repository: lens > > > Description > --- > > The current authorizer instantiation is separated in cubemetastore and > queryrewrite. There is a need to merge this by creating only a single > instance of authorizer for resource optimization. > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java > 5ae2cfd > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b1c1ae4 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 5bdfea4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java > f1376ca > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 9499f0c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryAuthorizationResolver.java > 13b345f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > efaf5d2 > > lens-server-api/src/main/java/org/apache/lens/server/api/authorization/LensAuthorizer.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensServer.java 701ebbe > lens-server/src/main/resources/lensserver-default.xml 2ea73a3 > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 7cccf30 > src/site/apt/admin/config.apt e900f98 > > > Diff: https://reviews.apache.org/r/68670/diff/2/ > > > Testing > --- > > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [1.399s] > [INFO] Lens .. SUCCESS [2.545s] > [INFO] Lens API .. SUCCESS [17.979s] > [INFO] Lens API for server and extensions SUCCESS [15.777s] > [INFO] Lens Cube . SUCCESS [3:15.811s] > [INFO] Lens DB storage ... SUCCESS [12.376s] > [INFO] Lens Query Library SUCCESS [9.909s] > [INFO] Lens Hive Driver .. SUCCESS [1:04.683s] > [INFO] Lens Driver for JDBC .. SUCCESS [39.626s] > [INFO] Lens Elastic Search Driver SUCCESS [17.802s] > [INFO] Lens Server ... SUCCESS > [10:15.769s] > [INFO] Lens client ... SUCCESS [1:19.107s] > [INFO] Lens CLI .. SUCCESS [1:09.361s] > [INFO] Lens Examples . SUCCESS [5.984s] > [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.616s] > [INFO] Lens Distribution . SUCCESS [10.112s] > [INFO] Lens ML Lib ... SUCCESS [57.461s] > [INFO] Lens ML Ext Distribution .. SUCCESS [2.303s] > [INFO] Lens Regression ... SUCCESS [9.392s] > [INFO] Lens UI ... SUCCESS [24.584s] > [INFO] Lens Contrib .. SUCCESS [0.255s] > [INFO] Lens Contributed Clients .. SUCCESS [0.234s] > [INFO] Lens Python Client SUCCESS [0.235s] > [INFO] - > > > Thanks, > > Rajitha R > >
Re: Review Request 68670: Authorizer Instance to be made singleton for resource optimization
> On Sept. 10, 2018, 3:23 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > > Lines 38 (patched) > > <https://reviews.apache.org/r/68670/diff/1/?file=2086613#file2086613line38> > > > > Can the conf be named with prefix similar to other configs? Also, document the config in lens-server-default.xml and update .apt files. - Amareshwari --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68670/#review208471 --- On Sept. 7, 2018, 4:57 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68670/ > --- > > (Updated Sept. 7, 2018, 4:57 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Ankit Kailaswar. > > > Bugs: LENS-1534 > https://issues.apache.org/jira/browse/LENS-1534 > > > Repository: lens > > > Description > --- > > The current authorizer instantiation is separated in cubemetastore and > queryrewrite. There is a need to merge this by creating only a single > instance of authorizer for resource optimization. > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java > 5ae2cfd > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b1c1ae4 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 5bdfea4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java > f1376ca > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 9499f0c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryAuthorizationResolver.java > 13b345f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > efaf5d2 > > lens-server-api/src/main/java/org/apache/lens/server/api/authorization/LensAuthorizer.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensServer.java 701ebbe > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 7cccf30 > > > Diff: https://reviews.apache.org/r/68670/diff/1/ > > > Testing > --- > > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [1.399s] > [INFO] Lens .. SUCCESS [2.545s] > [INFO] Lens API .. SUCCESS [17.979s] > [INFO] Lens API for server and extensions SUCCESS [15.777s] > [INFO] Lens Cube . SUCCESS [3:15.811s] > [INFO] Lens DB storage ... SUCCESS [12.376s] > [INFO] Lens Query Library SUCCESS [9.909s] > [INFO] Lens Hive Driver .. SUCCESS [1:04.683s] > [INFO] Lens Driver for JDBC .. SUCCESS [39.626s] > [INFO] Lens Elastic Search Driver SUCCESS [17.802s] > [INFO] Lens Server ... SUCCESS > [10:15.769s] > [INFO] Lens client ... SUCCESS [1:19.107s] > [INFO] Lens CLI .. SUCCESS [1:09.361s] > [INFO] Lens Examples . SUCCESS [5.984s] > [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.616s] > [INFO] Lens Distribution . SUCCESS [10.112s] > [INFO] Lens ML Lib ... SUCCESS [57.461s] > [INFO] Lens ML Ext Distribution .. SUCCESS [2.303s] > [INFO] Lens Regression ... SUCCESS [9.392s] > [INFO] Lens UI ... SUCCESS [24.584s] > [INFO] Lens Contrib .. SUCCESS [0.255s] > [INFO] Lens Contributed Clients .. SUCCESS [0.234s] > [INFO] Lens Python Client SUCCESS [0.235s] > [INFO] - > > > Thanks, > > Rajitha R > >
Re: Review Request 68670: Authorizer Instance to be made singleton for resource optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68670/#review208471 --- lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java Lines 38 (patched) <https://reviews.apache.org/r/68670/#comment292401> Can the conf be named with prefix similar to other configs? lens-server/src/main/java/org/apache/lens/server/LensServer.java Lines 141 (patched) <https://reviews.apache.org/r/68670/#comment292398> Shouldn't init be before start? lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java Lines 174 (patched) <https://reviews.apache.org/r/68670/#comment292400> Same as above. init should be before start - Amareshwari Sriramadasu On Sept. 7, 2018, 4:57 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68670/ > --- > > (Updated Sept. 7, 2018, 4:57 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Ankit Kailaswar. > > > Bugs: LENS-1534 > https://issues.apache.org/jira/browse/LENS-1534 > > > Repository: lens > > > Description > --- > > The current authorizer instantiation is separated in cubemetastore and > queryrewrite. There is a need to merge this by creating only a single > instance of authorizer for resource optimization. > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java > 5ae2cfd > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b1c1ae4 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 5bdfea4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java > f1376ca > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 9499f0c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryAuthorizationResolver.java > 13b345f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > efaf5d2 > > lens-server-api/src/main/java/org/apache/lens/server/api/authorization/LensAuthorizer.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensServer.java 701ebbe > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 7cccf30 > > > Diff: https://reviews.apache.org/r/68670/diff/1/ > > > Testing > --- > > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [1.399s] > [INFO] Lens .. SUCCESS [2.545s] > [INFO] Lens API .. SUCCESS [17.979s] > [INFO] Lens API for server and extensions SUCCESS [15.777s] > [INFO] Lens Cube . SUCCESS [3:15.811s] > [INFO] Lens DB storage ... SUCCESS [12.376s] > [INFO] Lens Query Library SUCCESS [9.909s] > [INFO] Lens Hive Driver .. SUCCESS [1:04.683s] > [INFO] Lens Driver for JDBC .. SUCCESS [39.626s] > [INFO] Lens Elastic Search Driver SUCCESS [17.802s] > [INFO] Lens Server ... SUCCESS > [10:15.769s] > [INFO] Lens client ... SUCCESS [1:19.107s] > [INFO] Lens CLI .. SUCCESS [1:09.361s] > [INFO] Lens Examples . SUCCESS [5.984s] > [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.616s] > [INFO] Lens Distribution . SUCCESS [10.112s] > [INFO] Lens ML Lib ... SUCCESS [57.461s] > [INFO] Lens ML Ext Distribution .. SUCCESS [2.303s] > [INFO] Lens Regression ... SUCCESS [9.392s] > [INFO] Lens UI ... SUCCESS [24.584s] > [INFO] Lens Contrib .. SUCCESS [0.255s] > [INFO] Lens Contributed Clients .. SUCCESS [0.234s] > [INFO] Lens Python Client SUCCESS [0.235s] > [INFO] - > > > Thanks, > > Rajitha R > >
Re: Review Request 68471: Authorization check to accept session conf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68471/#review208395 --- Ship it! Ship It! - Amareshwari Sriramadasu On Aug. 22, 2018, 10:27 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68471/ > --- > > (Updated Aug. 22, 2018, 10:27 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Puneet Gupta. > > > Repository: lens > > > Description > --- > > The current isAuthorized call in AuthorizationUtil is checking for session > related configuration from service conf which should rather be session conf. > This leads to incorrect session params being read for different sessions > causing authorization failures > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java > ccd46a3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e6afcff > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java > 78dd642 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 6f054c4 > lens-cube/src/test/java/org/apache/lens/cube/parse/MockAuthorizer.java > PRE-CREATION > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryAuthorizationResolver.java > PRE-CREATION > lens-cube/src/test/resources/schema/cubes/base/basecube.xml 6cc3201 > > > Diff: https://reviews.apache.org/r/68471/diff/4/ > > > Testing > --- > > [INFO] > [INFO] Lens Checkstyle Rules .. SUCCESS [ 2.734 > s] > [INFO] Lens ... SUCCESS [ 5.553 > s] > [INFO] Lens API ... SUCCESS [ 28.035 > s] > [INFO] Lens API for server and extensions . SUCCESS [ 25.289 > s] > [INFO] Lens Cube .. SUCCESS [08:06 > min] > [INFO] Lens DB storage SUCCESS [ 33.949 > s] > [INFO] Lens Query Library . SUCCESS [ 16.945 > s] > [INFO] Lens Hive Driver ... SUCCESS [01:57 > min] > [INFO] Lens Driver for JDBC ... SUCCESS [01:11 > min] > [INFO] Lens Elastic Search Driver . SUCCESS [ 40.179 > s] > [INFO] Lens Server SUCCESS [13:02 > min] > [INFO] Lens client SUCCESS [02:09 > min] > [INFO] Lens CLI ... SUCCESS [02:14 > min] > [INFO] Lens Examples .. SUCCESS [ 12.243 > s] > [INFO] Lens Ship Jars to Distributed Cache SUCCESS [ 2.325 > s] > [INFO] Lens Distribution .. SUCCESS [ 22.174 > s] > [INFO] Lens ML Lib SUCCESS [01:52 > min] > [INFO] Lens ML Ext Distribution ... SUCCESS [ 4.972 > s] > [INFO] Lens Regression SUCCESS [ 14.733 > s] > [INFO] Lens UI SUCCESS [ 6.186 > s] > [INFO] Lens Contrib ... SUCCESS [ 0.438 > s] > [INFO] Lens Contributed Clients ... SUCCESS [ 0.347 > s] > [INFO] Lens Python Client . SUCCESS [ 0.543 > s] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 34:11 min > [INFO] Finished at: 2018-08-22T16:46:43+05:30 > [INFO] Final Memory: 269M/1572M > > > Thanks, > > Rajitha R > >
Re: Review Request 68520: LENS-1533: Adding support for Partition Columns to queried without giving additional xml tag valid.columns
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68520/#review208339 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java Lines 98 (patched) <https://reviews.apache.org/r/68520/#comment292195> Can these be derived from existing non-time partition columns instead of new property being added? - Amareshwari Sriramadasu On Sept. 5, 2018, 2:55 a.m., Rajashekhar Choukimath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68520/ > --- > > (Updated Sept. 5, 2018, 2:55 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Ankit Kailaswar, and > Rajitha R. > > > Bugs: LENS-1533 > https://issues.apache.org/jira/browse/LENS-1533 > > > Repository: lens > > > Description > --- > > LENS-1533: Adding support for Partition Columns to queried without giving > additional xml tag valid.columns > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 8f3f4aa > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e6afcff > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > 96948cc > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > e351d7f > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > 7dfb166 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 44411f2 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 193ce6b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 6f054c4 > > > Diff: https://reviews.apache.org/r/68520/diff/1/ > > > Testing > --- > > Done on Local Test VM. > > > Thanks, > > Rajashekhar Choukimath > >
[jira] [Commented] (LENS-1531) Lens driver not picking hadoop conf
[ https://issues.apache.org/jira/browse/LENS-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583302#comment-16583302 ] Amareshwari Sriramadasu commented on LENS-1531: --- -1 It is disabled by design. If configuration defaults are set to true, the hadoop configuration will pass all default values to cluster config and hadoop site from cluster itself is ignored. > Lens driver not picking hadoop conf > --- > > Key: LENS-1531 > URL: https://issues.apache.org/jira/browse/LENS-1531 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Rajashekhar >Priority: Major > > Lens driver not picking hadoop conf > > The PR is here: [https://github.com/apache/lens/pull/26] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 68380: Lens driver not picking hadoop conf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68380/#review207466 --- lens-server/src/main/java/org/apache/lens/server/LensServerConf.java Line 45 (original), 45 (patched) <https://reviews.apache.org/r/68380/#comment290864> It is disabled to override by design. If configuration defaults are set to true, the hadoop configuration will pass all default values to cluster config and hadoop site from cluster itself is ignored. - Amareshwari Sriramadasu On Aug. 16, 2018, 12:52 p.m., Rajashekhar Choukimath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68380/ > --- > > (Updated Aug. 16, 2018, 12:52 p.m.) > > > Review request for lens, Ankit Kailaswar and Rajitha R. > > > Bugs: LENS-1531 > https://issues.apache.org/jira/browse/LENS-1531 > > > Repository: lens > > > Description > --- > > LENS-1531: Lens driver not picking hadoop conf > > > Diffs > - > > lens-server/src/main/java/org/apache/lens/server/LensServerConf.java > 8d2a3fc > > > Diff: https://reviews.apache.org/r/68380/diff/1/ > > > Testing > --- > > Verified in my test VM setup. > > > Thanks, > > Rajashekhar Choukimath > >
Re: Review Request 68315: Start and end time for Cubes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68315/#review207390 --- Ship it! Ship It! - Amareshwari Sriramadasu On Aug. 14, 2018, 2:50 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68315/ > --- > > (Updated Aug. 14, 2018, 2:50 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-1525 > https://issues.apache.org/jira/browse/LENS-1525 > > > Repository: lens > > > Description > --- > > Introducing start and end time feature in cube properties to restrict user > queries from including past and future date ranges. > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 4d10d24 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > ed076e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 7c3da2c > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java > 6477a6b > lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java > 4c73785 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 945fe26 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 8e77a82 > lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java > c4404f1 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeStartAndEndTimes.java > PRE-CREATION > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java > 181608f > lens-cube/src/test/resources/schema/cubes/base/testcube.xml 4cafd31 > > > Diff: https://reviews.apache.org/r/68315/diff/3/ > > > Testing > --- > > [INFO] > [INFO] Lens Checkstyle Rules .. SUCCESS [ 5.814 > s] > [INFO] Lens ... SUCCESS [ 9.893 > s] > [INFO] Lens API ... SUCCESS [01:05 > min] > [INFO] Lens API for server and extensions . SUCCESS [ 52.959 > s] > [INFO] Lens Cube .. SUCCESS [10:16 > min] > [INFO] Lens DB storage SUCCESS [01:11 > min] > [INFO] Lens Query Library . SUCCESS [ 44.173 > s] > [INFO] Lens Hive Driver ... SUCCESS [02:41 > min] > [INFO] Lens Driver for JDBC ... SUCCESS [02:44 > min] > [INFO] Lens Elastic Search Driver . SUCCESS [ 53.534 > s] > [INFO] Lens Server SUCCESS [15:06 > min] > [INFO] Lens client SUCCESS [02:35 > min] > [INFO] Lens CLI ... SUCCESS [02:42 > min] > [INFO] Lens Examples .. SUCCESS [ 14.654 > s] > [INFO] Lens Ship Jars to Distributed Cache SUCCESS [ 1.738 > s] > [INFO] Lens Distribution .. SUCCESS [ 21.231 > s] > [INFO] Lens ML Lib SUCCESS [02:24 > min] > [INFO] Lens ML Ext Distribution ... SUCCESS [ 9.879 > s] > [INFO] Lens Regression SUCCESS [ 24.848 > s] > [INFO] Lens UI SUCCESS [ 8.120 > s] > [INFO] Lens Contrib ... SUCCESS [ 1.567 > s] > [INFO] Lens Contributed Clients ... SUCCESS [ 0.327 > s] > [INFO] Lens Python Client . SUCCESS [ 0.502 > s] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 45:00 min > [INFO] Finished at: 2018-08-13T13:12:18+05:30 > [INFO] Final Memory: 261M/1420M > [INFO] > > > > Thanks, > > Rajitha R > >
[jira] [Commented] (LENS-1517) Python3 compatibility issues with python client
[
https://issues.apache.org/jira/browse/LENS-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498866#comment-16498866
]
Amareshwari Sriramadasu commented on LENS-1517:
---
[~Michael.McCarthy], Thanks for reporting the issue and providing a fix. I went
ahead and assigned the issue to you. Can you attach patch to the Jira instead
of pull request? Document at
[http://lens.apache.org/developer/contribute.html#How_do_I_suggest_my_code_changes_to_the_community]
can help you to generate a patch.
> Python3 compatibility issues with python client
> ---
>
> Key: LENS-1517
> URL: https://issues.apache.org/jira/browse/LENS-1517
> Project: Apache Lens
> Issue Type: Bug
> Components: python-client
>Affects Versions: 3.0, 2.8
> Environment: Python 3.5.2
> Commit: c6423ae01a4776383f0edcd8591124ac643b9e3e
>Reporter: Michael McCarthy
>Assignee: Michael McCarthy
>Priority: Major
>
> Using the python client in Python3 fails on import:
> {noformat}
> from lens.client import LensClient
> ---
> ImportError Traceback (most recent call last)
> in ()
> > 1 from lens.client import LensClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/__init__.py
> in ()
> 15 # limitations under the License.
> 16 #
> ---> 17 from .main import LensClient
> 18
> 19 __all__ = ['LensClient']
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/main.py
> in ()
> 18
> 19 from six import string_types
> ---> 20 from .log import LensLogClient
> 21 from .session import LensSessionClient
> 22 from .query import LensQueryClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/log.py
> in ()
> 15 # limitations under the License.
> 16 #
> ---> 17 from .auth import SpnegoAuth
> 18 import requests
> 19
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/auth.py
> in ()
> 19 import subprocess
> 20 import threading
> ---> 21 from urlparse import urlparse
> 22
> 23
> ImportError: No module named 'urlparse'
> {noformat}
> This appears to be due to the fact that in Python3, {{urlparse}} is
> {{urllib.parse}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (LENS-1517) Python3 compatibility issues with python client
[
https://issues.apache.org/jira/browse/LENS-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amareshwari Sriramadasu reassigned LENS-1517:
-
Assignee: Michael McCarthy
> Python3 compatibility issues with python client
> ---
>
> Key: LENS-1517
> URL: https://issues.apache.org/jira/browse/LENS-1517
> Project: Apache Lens
> Issue Type: Bug
> Components: python-client
>Affects Versions: 3.0, 2.8
> Environment: Python 3.5.2
> Commit: c6423ae01a4776383f0edcd8591124ac643b9e3e
>Reporter: Michael McCarthy
>Assignee: Michael McCarthy
>Priority: Major
>
> Using the python client in Python3 fails on import:
> {noformat}
> from lens.client import LensClient
> ---
> ImportError Traceback (most recent call last)
> in ()
> > 1 from lens.client import LensClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/__init__.py
> in ()
> 15 # limitations under the License.
> 16 #
> ---> 17 from .main import LensClient
> 18
> 19 __all__ = ['LensClient']
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/main.py
> in ()
> 18
> 19 from six import string_types
> ---> 20 from .log import LensLogClient
> 21 from .session import LensSessionClient
> 22 from .query import LensQueryClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/log.py
> in ()
> 15 # limitations under the License.
> 16 #
> ---> 17 from .auth import SpnegoAuth
> 18 import requests
> 19
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/auth.py
> in ()
> 19 import subprocess
> 20 import threading
> ---> 21 from urlparse import urlparse
> 22
> 23
> ImportError: No module named 'urlparse'
> {noformat}
> This appears to be due to the fact that in Python3, {{urlparse}} is
> {{urllib.parse}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Review Request 66730: hive's server princiapl in lens's hive driver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66730/#review201621 --- Ship it! Ship It! - Amareshwari Sriramadasu On April 20, 2018, 9:26 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66730/ > --- > > (Updated April 20, 2018, 9:26 a.m.) > > > Review request for lens and Rajitha R. > > > Bugs: Lens-1510 > https://issues.apache.org/jira/browse/Lens-1510 > > > Repository: lens > > > Description > --- > > since the property name for lens and hive's principal name are conflicting we > need explicitly need to mention hive's principal while creating hive driver > for lens. (https://issues.apache.org/jira/browse/LENS-1510) > > > Diffs > - > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 3fd5d2c6 > lens-driver-hive/src/main/resources/hivedriver-default.xml 2b2dc0bf > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0e05d28e > src/site/apt/admin/hivedriver-config.apt b1a84317 > tools/conf/server/drivers/hive/hive1/hivedriver-site.xml 2e8e7fa8 > > > Diff: https://reviews.apache.org/r/66730/diff/4/ > > > Testing > --- > > build logs... > [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-check) @ > lens-python-client --- > [INFO] Starting audit... > Audit done. > [INFO] > [INFO] >>> findbugs-maven-plugin:3.0.1:check (findbugs-check) > :findbugs @ > lens-python-client >>> > [INFO] > [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ > lens-python-client --- > [INFO] > [INFO] <<< findbugs-maven-plugin:3.0.1:check (findbugs-check) < :findbugs @ > lens-python-client <<< > [INFO] > [INFO] > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ > lens-python-client --- > [INFO] > [INFO] --- maven-source-plugin:3.0.1:jar-no-fork (attach-sources) @ > lens-python-client --- > [INFO] > [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ > lens-python-client --- > [INFO] Installing > /Users/ankit.kailaswar/inmobi/apache/lens/contrib/clients/python/pom.xml to > /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .. SUCCESS [ 1.438 > s] > [INFO] Lens ... SUCCESS [ 3.405 > s] > [INFO] Lens API ... SUCCESS [ 24.673 > s] > [INFO] Lens API for server and extensions . SUCCESS [ 15.839 > s] > [INFO] Lens Cube .. SUCCESS [ 40.093 > s] > [INFO] Lens DB storage SUCCESS [ 10.662 > s] > [INFO] Lens Query Library . SUCCESS [ 14.807 > s] > [INFO] Lens Hive Driver ... SUCCESS [ 11.680 > s] > [INFO] Lens Driver for JDBC ... SUCCESS [ 26.981 > s] > [INFO] Lens Elastic Search Driver . SUCCESS [ 11.728 > s] > [INFO] Lens Server SUCCESS [01:05 > min] > [INFO] Lens client SUCCESS [ 18.802 > s] > [INFO] Lens CLI ... SUCCESS [ 15.882 > s] > [INFO] Lens Examples .. SUCCESS [ 9.430 > s] > [INFO] Lens Ship Jars to Distributed Cache SUCCESS [ 1.919 > s] > [INFO] Lens Distribution .. SUCCESS [ 21.463 > s] > [INFO] Lens ML Lib SUCCESS [ 15.604 > s] > [INFO] Lens ML Ext Distribution ... SUCCESS [ 4.224 > s] > [INFO] Lens Regression SUCCESS [ 12.101 > s] > [INFO] Lens UI SUCCESS [ 8.237 > s] > [INFO] Lens Contrib ... SUCCESS [ 0.439 > s] > [INFO] Lens Contributed Clients ... SUCCESS [ 0.416 &
Re: Review Request 66730: hive's server princiapl in lens's hive driver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66730/#review201618 --- lens-driver-hive/src/main/resources/hivedriver-default.xml Lines 28 (patched) <https://reviews.apache.org/r/66730/#comment282943> Can you follow the convention for hive driver properties and lens.driver.hive. ? Also add description for property ? Can you check-in hivedriver-config.apt as well ? http://lens.apache.org/developer/contribute.html#How_to_update_the_config_docs - will help you. lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java Lines 742 (patched) <https://reviews.apache.org/r/66730/#comment282944> Can you use DRIVER_PFX instead of SERVER_PFX? - Amareshwari Sriramadasu On April 20, 2018, 8:41 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66730/ > --- > > (Updated April 20, 2018, 8:41 a.m.) > > > Review request for lens and Rajitha R. > > > Bugs: Lens-1510 > https://issues.apache.org/jira/browse/Lens-1510 > > > Repository: lens > > > Description > --- > > since the property name for lens and hive's principal name are conflicting we > need explicitly need to mention hive's principal while creating hive driver > for lens. (https://issues.apache.org/jira/browse/LENS-1510) > > > Diffs > - > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 3fd5d2c6 > lens-driver-hive/src/main/resources/hivedriver-default.xml 2b2dc0bf > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0e05d28e > tools/conf/server/drivers/hive/hive1/hivedriver-site.xml 2e8e7fa8 > > > Diff: https://reviews.apache.org/r/66730/diff/3/ > > > Testing > --- > > build logs... > [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-check) @ > lens-python-client --- > [INFO] Starting audit... > Audit done. > [INFO] > [INFO] >>> findbugs-maven-plugin:3.0.1:check (findbugs-check) > :findbugs @ > lens-python-client >>> > [INFO] > [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ > lens-python-client --- > [INFO] > [INFO] <<< findbugs-maven-plugin:3.0.1:check (findbugs-check) < :findbugs @ > lens-python-client <<< > [INFO] > [INFO] > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ > lens-python-client --- > [INFO] > [INFO] --- maven-source-plugin:3.0.1:jar-no-fork (attach-sources) @ > lens-python-client --- > [INFO] > [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ > lens-python-client --- > [INFO] Installing > /Users/ankit.kailaswar/inmobi/apache/lens/contrib/clients/python/pom.xml to > /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .. SUCCESS [ 1.438 > s] > [INFO] Lens ... SUCCESS [ 3.405 > s] > [INFO] Lens API ... SUCCESS [ 24.673 > s] > [INFO] Lens API for server and extensions . SUCCESS [ 15.839 > s] > [INFO] Lens Cube .. SUCCESS [ 40.093 > s] > [INFO] Lens DB storage SUCCESS [ 10.662 > s] > [INFO] Lens Query Library . SUCCESS [ 14.807 > s] > [INFO] Lens Hive Driver ... SUCCESS [ 11.680 > s] > [INFO] Lens Driver for JDBC ... SUCCESS [ 26.981 > s] > [INFO] Lens Elastic Search Driver . SUCCESS [ 11.728 > s] > [INFO] Lens Server SUCCESS [01:05 > min] > [INFO] Lens client SUCCESS [ 18.802 > s] > [INFO] Lens CLI ... SUCCESS [ 15.882 > s] > [INFO] Lens Examples .. SUCCESS [ 9.430 > s] > [INFO] Lens Ship Jars to Distributed Cache SUCCESS [ 1.919 > s] > [INFO] Lens Distribution .. SUCCESS [ 21.463 > s] > [INFO] Lens ML Lib
Re: Review Request 66730: hive's server princiapl in lens's hive driver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66730/#review201616 --- lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java Lines 742 (patched) <https://reviews.apache.org/r/66730/#comment282940> Add this to hivedriver's configuration. Also in hivedriver-default.xml - Amareshwari Sriramadasu On April 20, 2018, 6:03 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66730/ > --- > > (Updated April 20, 2018, 6:03 a.m.) > > > Review request for lens and Rajitha R. > > > Repository: lens > > > Description > --- > > since the property name for lens and hive's principal name are conflicting we > need explicitly need to mention hive's principal while creating hive driver > for lens. (https://issues.apache.org/jira/browse/LENS-1510) > > > Diffs > - > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 3fd5d2c6 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0e05d28e > > > Diff: https://reviews.apache.org/r/66730/diff/1/ > > > Testing > --- > > > Thanks, > > Ankit Kailaswar > >
[jira] [Commented] (LENS-1507) Lens build failing
[
https://issues.apache.org/jira/browse/LENS-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418609#comment-16418609
]
Amareshwari Sriramadasu commented on LENS-1507:
---
+1
> Lens build failing
> --
>
> Key: LENS-1507
> URL: https://issues.apache.org/jira/browse/LENS-1507
> Project: Apache Lens
> Issue Type: Bug
> Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1507.patch
>
>
> This seems to happen due to following test case repeating twice in
> TestCubeRewriter class file.
> {code}
> @Test
> public void testTimeRangeIn() throws Exception {
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Review Request 65430: Virtual fact start and end time property fix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65430/#review199519 --- Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 31, 2018, 7:58 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65430/ > --- > > (Updated Jan. 31, 2018, 7:58 a.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1502 > https://issues.apache.org/jira/browse/LENS-1502 > > > Repository: lens > > > Description > --- > > Virtual fact start and end time property fix > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > b48be7f > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java > fe6b20d > lens-cube/src/test/resources/schema/cubes/base/testcube2.xml 237e85a > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 187ac29 > lens-cube/src/test/resources/schema/facts/testfact9_base.xml 9c94fe2 > lens-cube/src/test/resources/schema/facts/virtual/virtualfact2.xml > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65430/diff/2/ > > > Testing > --- > > > Thanks, > > Rajitha R > >
[jira] [Commented] (LENS-1485) Fix javadocs errors and warnings
[ https://issues.apache.org/jira/browse/LENS-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270197#comment-16270197 ] Amareshwari Sriramadasu commented on LENS-1485: --- is the build failure intermittent a jenkins issue? or anything else? > Fix javadocs errors and warnings > - > > Key: LENS-1485 > URL: https://issues.apache.org/jira/browse/LENS-1485 > Project: Apache Lens > Issue Type: Bug > Components: build >Reporter: Raju Bairishetti >Assignee: Raju Bairishetti > Fix For: 2.7 > > Attachments: LENS-1485.patch > > > Right now, we are building and running Lens on only on java8 and higher > versions. We are not able to generate javadocs with java8 due to some new > rules/constraints on javadocs. > Creating this jira for fixing the javadoc errors and warnings. We should fail > the build( ) in case of any errors while generating javadocs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1485) Fix javadocs errors and warnings
[ https://issues.apache.org/jira/browse/LENS-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270108#comment-16270108 ] Amareshwari Sriramadasu commented on LENS-1485: --- +1 for the patch > Fix javadocs errors and warnings > - > > Key: LENS-1485 > URL: https://issues.apache.org/jira/browse/LENS-1485 > Project: Apache Lens > Issue Type: Bug > Components: build >Reporter: Raju Bairishetti >Assignee: Raju Bairishetti > Fix For: 2.7 > > Attachments: LENS-1485.patch > > > Right now, we are building and running Lens on only on java8 and higher > versions. We are not able to generate javadocs with java8 due to some new > rules/constraints on javadocs. > Creating this jira for fixing the javadoc errors and warnings. We should fail > the build( ) in case of any errors while generating javadocs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1485) Fix javadocs errors and warnings
[ https://issues.apache.org/jira/browse/LENS-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268108#comment-16268108 ] Amareshwari Sriramadasu commented on LENS-1485: --- +1 for the proposal for unblocking 2.7 release. > Fix javadocs errors and warnings > - > > Key: LENS-1485 > URL: https://issues.apache.org/jira/browse/LENS-1485 > Project: Apache Lens > Issue Type: Bug > Components: build >Reporter: Raju Bairishetti > > Right now, we are building and running Lens on only on java8 and higher > versions. We are not able to generate javadocs with java8 due to some new > rules/constraints on javadocs. > Creating this jira for fixing the javadoc errors and warnings. We should fail > the build( ) in case of any errors while generating javadocs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1425) Update 2.7 release documentation
[ https://issues.apache.org/jira/browse/LENS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249154#comment-16249154 ] Amareshwari Sriramadasu commented on LENS-1425: --- +1 for the latest patch > Update 2.7 release documentation > > > Key: LENS-1425 > URL: https://issues.apache.org/jira/browse/LENS-1425 > Project: Apache Lens > Issue Type: Sub-task > Components: build >Reporter: Raju Bairishetti >Assignee: Raju Bairishetti > Fix For: 2.7 > > Attachments: LENS-1425.patch, LENS-1425_1.patch > > > Update the release documentation with 2.7 features -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1425) Update 2.7 release documentation
[ https://issues.apache.org/jira/browse/LENS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235180#comment-16235180 ] Amareshwari Sriramadasu commented on LENS-1425: --- [~puneet884] Can you check the incompatability section? Other changes look good to me. > Update 2.7 release documentation > > > Key: LENS-1425 > URL: https://issues.apache.org/jira/browse/LENS-1425 > Project: Apache Lens > Issue Type: Sub-task > Components: build >Reporter: Raju Bairishetti >Assignee: Raju Bairishetti >Priority: Major > Fix For: 2.7 > > Attachments: LENS-1425.patch > > > Update the release documentation with 2.7 features -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1474) Null pointer exception in expression resolver for Segmentation candidate
[ https://issues.apache.org/jira/browse/LENS-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1474: -- Resolution: Fixed Fix Version/s: 2.8 Status: Resolved (was: Patch Available) Committed. Thanks [~rajitha.r] > Null pointer exception in expression resolver for Segmentation candidate > > > Key: LENS-1474 > URL: https://issues.apache.org/jira/browse/LENS-1474 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.8 > > Attachments: LENS-1474.patch > > > This happens when there are two expressions . Say expr1 answered from fact > and expr2 answered from Segmentation. > Segmentation specific inner rewrite is passed expr1 as 0.0 and later in the > flow expr1 is looked up which throws up NullPointerException. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 62201: LENS-1474 : Null pointer in Segmentation rewrite
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62201/#review185046 --- Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 9, 2017, 3:23 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62201/ > --- > > (Updated Sept. 9, 2017, 3:23 a.m.) > > > Review request for lens and Puneet Gupta. > > > Repository: lens > > > Description > --- > > Null pointer in Segmentation rewrite > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 1268ef7 > > > Diff: https://reviews.apache.org/r/62201/diff/1/ > > > Testing > --- > > > Thanks, > > Rajitha R > >
[jira] [Updated] (LENS-1466) Rewritten queries not resolving time_range_in clause
[ https://issues.apache.org/jira/browse/LENS-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1466: -- Resolution: Fixed Fix Version/s: 2.7 Status: Resolved (was: Patch Available) Committed. Thanks [~rajitha.r] > Rewritten queries not resolving time_range_in clause > > > Key: LENS-1466 > URL: https://issues.apache.org/jira/browse/LENS-1466 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.7 > > Attachments: LENS-1466.patch > > > Few Queries with look ahead are not resolving time_range_in clause. This is > causing queries to fail on jdbc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61938/#review184022 --- Can you add a testcase? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java Line 936 (original), 936 (patched) <https://reviews.apache.org/r/61938/#comment260037> Line above is truncating partitions, isnt get Partitions here empty always? - Amareshwari Sriramadasu On Aug. 28, 2017, 11:38 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61938/ > --- > > (Updated Aug. 28, 2017, 11:38 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Repository: lens > > > Description > --- > > Fix for time_range_in clause not resolving in rewrite > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 2b1add3 > > > Diff: https://reviews.apache.org/r/61938/diff/1/ > > > Testing > --- > > > Thanks, > > Rajitha R > >
[jira] [Updated] (LENS-1463) Valid Columns addition in Virtual Fact
[ https://issues.apache.org/jira/browse/LENS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1463: -- Resolution: Fixed Fix Version/s: 2.8 Status: Resolved (was: Patch Available) Committed. Thanks [~rajitha.r] > Valid Columns addition in Virtual Fact > --- > > Key: LENS-1463 > URL: https://issues.apache.org/jira/browse/LENS-1463 > Project: Apache Lens > Issue Type: Task > Components: server >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.8 > > Attachments: LENS-1463.patch > > > This feature would allow virtual fact to override valid columns of its > base/source fact. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 61683: LENS-1439: Having clause getting skipped if query goes to a segmentation containing single segment
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61683/#review183913
---
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 21, 2017, 8:23 a.m., Rajat Khandelwal wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61683/
> ---
>
> (Updated Aug. 21, 2017, 8:23 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1439
> https://issues.apache.org/jira/browse/LENS-1439
>
>
> Repository: lens
>
>
> Description
> ---
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
>
>
> Diffs
> -
>
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
> 494b08e3b04bcdfea3de449f3740589cc481ba38
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java
> 7e1714bc301a748bf2c49dc9a707c1072c36f66b
> lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml
> c23a029b80ab4342e130d4778eb84559c6806b7e
>
>
> Diff: https://reviews.apache.org/r/61683/diff/2/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61881/#review183912 --- lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 428 (patched) <https://reviews.apache.org/r/61881/#comment259975> ClientError path should not come in server path. Can we avoid this? - Amareshwari Sriramadasu On Aug. 24, 2017, 8:11 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61881/ > --- > > (Updated Aug. 24, 2017, 8:11 a.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1461 > https://issues.apache.org/jira/browse/LENS-1461 > > > Repository: lens > > > Description > --- > > Persist process for Session service should not fail if any session in > invalid. Persist service should ignore these session and continue persisting > state of other session instead of failing. > > > Diffs > - > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > b480d14 > > > Diff: https://reviews.apache.org/r/61881/diff/1/ > > > Testing > --- > > > Thanks, > > Ankit Kailaswar > >
Re: Review Request 61812: Valid columns addition in virtual fact [LENS-1463]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61812/#review183707 --- Ship it! Ship It! - Amareshwari Sriramadasu On Aug. 22, 2017, 12:56 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61812/ > --- > > (Updated Aug. 22, 2017, 12:56 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Repository: lens > > > Description > --- > > Valid columns addition in virtual fact > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > 1fc74b0 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java > 4bcb376 > lens-cube/src/test/resources/schema/cubes/base/testcube2.xml 9740e00 > lens-cube/src/test/resources/schema/facts/testfact9_base.xml 56e5746 > lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 13f6773 > > > Diff: https://reviews.apache.org/r/61812/diff/2/ > > > Testing > --- > > > Thanks, > > Rajitha R > >
[jira] [Commented] (LENS-1459) Time union candidate creation phase is creating a combination with redundant candidates
[
https://issues.apache.org/jira/browse/LENS-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128641#comment-16128641
]
Amareshwari Sriramadasu commented on LENS-1459:
---
+1
> Time union candidate creation phase is creating a combination with redundant
> candidates
> ---
>
> Key: LENS-1459
> URL: https://issues.apache.org/jira/browse/LENS-1459
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1459.2017-08-16_16:28:29.patch
>
>
> After the optimization in LENS-1452, Combinations as mentioned in the jira
> summary can get created. Say the time range queried is {{\[f, t)}}, Candidate
> {{a}} and {{b}} can cover {{\[f, m)}} and candidate {{c}} can cover {{\[m,
> t)}}. Say a Union candidate is represented as {{U(cand1, cand2,...)}}. Then
> the code creates {{U(a,b,c), U(a,c) and U(b,c)}}. If {{U(a,b,c)}} is picked
> as final candidate, then one of {{a}} or {{b}} doesn't resolve partitions and
> {{time_range_in}} clause is left as it is for that.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128569#comment-16128569
]
Amareshwari Sriramadasu commented on LENS-1439:
---
[~prongs] Can we add unit test?
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1439.01.patch, LENS-1439.01.patch
>
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1450) filters are getting replicated in jdbc driver query
[ https://issues.apache.org/jira/browse/LENS-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1450: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks [~rajitha.r] > filters are getting replicated in jdbc driver query > --- > > Key: LENS-1450 > URL: https://issues.apache.org/jira/browse/LENS-1450 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Attachments: LENS-1450-2.patch > > > The where filters are getting repeated in some queries for jdbc. This needs > to be fixed -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 61450: Fix for filters getting repeated in jdbc query - LENS-1450
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61450/#review182266 --- Ship it! Ship It! - Amareshwari Sriramadasu On Aug. 7, 2017, 7:53 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61450/ > --- > > (Updated Aug. 7, 2017, 7:53 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > --- > > Fix for filters getting repeated in Jdbc query > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > b5330a7 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 1c75e6c > > > Diff: https://reviews.apache.org/r/61450/diff/1/ > > > Testing > --- > > [INFO] Lens Checkstyle Rules . SUCCESS [2.212s] > [INFO] Lens .. SUCCESS [4.546s] > [INFO] Lens API .. SUCCESS [32.009s] > [INFO] Lens API for server and extensions SUCCESS [24.382s] > [INFO] Lens Cube . SUCCESS [4:21.313s] > [INFO] Lens DB storage ... SUCCESS [17.702s] > [INFO] Lens Query Library SUCCESS [14.776s] > [INFO] Lens Hive Driver .. SUCCESS [1:20.509s] > [INFO] Lens Driver for JDBC .. SUCCESS [48.890s] > [INFO] Lens Elastic Search Driver SUCCESS [20.872s] > [INFO] Lens Server ... SUCCESS > [16:50.287s] > [INFO] Lens client ... SUCCESS [1:25.173s] > [INFO] Lens CLI .. SUCCESS [1:18.177s] > [INFO] Lens Examples . SUCCESS [7.998s] > [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.680s] > [INFO] Lens Distribution . SUCCESS [9.202s] > [INFO] Lens ML Lib ... SUCCESS [1:04.167s] > [INFO] Lens ML Ext Distribution .. SUCCESS [2.129s] > [INFO] Lens Regression ... SUCCESS [12.173s] > [INFO] Lens UI ... SUCCESS [30.945s] > [INFO] Lens Contrib .. SUCCESS [0.365s] > [INFO] Lens Contributed Clients .. SUCCESS [0.352s] > [INFO] Lens Python Client SUCCESS [0.575s] > > > Thanks, > > Rajitha R > >
[jira] [Commented] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart
[ https://issues.apache.org/jira/browse/LENS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116127#comment-16116127 ] Amareshwari Sriramadasu commented on LENS-1458: --- Can we update unit test? > RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued > queries after server restart > - > > Key: LENS-1458 > URL: https://issues.apache.org/jira/browse/LENS-1458 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Sushil Mohanty >Assignee: Sushil Mohanty > Attachments: LENS-1458_1.patch > > > This is happening when queries are getting restored after server restart and > driver specific conf is overwritten with server conf. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1450) filters are getting replicated in jdbc driver query
[ https://issues.apache.org/jira/browse/LENS-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112192#comment-16112192 ] Amareshwari Sriramadasu commented on LENS-1450: --- Reopened as the commit is reverted now. > filters are getting replicated in jdbc driver query > --- > > Key: LENS-1450 > URL: https://issues.apache.org/jira/browse/LENS-1450 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Attachments: LENS-1450.patch > > > The where filters are getting repeated in some queries for jdbc. This needs > to be fixed -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (LENS-1450) filters are getting replicated in jdbc driver query
[ https://issues.apache.org/jira/browse/LENS-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu reopened LENS-1450: --- > filters are getting replicated in jdbc driver query > --- > > Key: LENS-1450 > URL: https://issues.apache.org/jira/browse/LENS-1450 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Attachments: LENS-1450.patch > > > The where filters are getting repeated in some queries for jdbc. This needs > to be fixed -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (LENS-1456) Deadlock in jdbcdriver
Amareshwari Sriramadasu created LENS-1456:
-
Summary: Deadlock in jdbcdriver
Key: LENS-1456
URL: https://issues.apache.org/jira/browse/LENS-1456
Project: Apache Lens
Issue Type: Bug
Components: driver-jdbc
Reporter: Amareshwari Sriramadasu
Here are the details :
{noformat}
Found one Java-level deadlock:
=
"lens-driver-jdbc-795":
waiting to lock monitor 0x7f98200140a8 (object 0x000319a3dc88, a
org.apache.lens.server.api.query.QueryContext),
which is held by "query-cancellation-pool-Thread-3"
"query-cancellation-pool-Thread-3":
waiting to lock monitor 0x7f97ec002d08 (object 0x000319a8c6e0, a
java.util.ArrayList),
which is held by "lens-driver-jdbc-795"
Java stack information for the threads listed above:
===
"lens-driver-jdbc-795":
at
org.apache.lens.server.query.QueryExecutionServiceImpl.updateStatus(QueryExecutionServiceImpl.java:1049)
- waiting to lock <0x000319a3dc88> (a
org.apache.lens.server.api.query.QueryContext)
at
org.apache.lens.server.query.QueryExecutionServiceImpl.access$1900(QueryExecutionServiceImpl.java:110)
at
org.apache.lens.server.query.QueryExecutionServiceImpl$AsyncStatusUpdater.onDriverStatusUpdated(QueryExecutionServiceImpl.java:853)
at
org.apache.lens.server.api.query.QueryContext.setDriverStatus(QueryContext.java:577)
- locked <0x000319a8c6e0> (a java.util.ArrayList)
at
org.apache.lens.driver.jdbc.JDBCDriver$QueryCallable.call(JDBCDriver.java:299)
at
org.apache.lens.driver.jdbc.JDBCDriver$QueryCallable.call(JDBCDriver.java:237)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
"query-cancellation-pool-Thread-3":
at
org.apache.lens.server.api.query.QueryContext.setDriverStatus(QueryContext.java:575)
- waiting to lock <0x000319a8c6e0> (a java.util.ArrayList)
at
org.apache.lens.server.api.query.QueryContext.setDriverStatus(QueryContext.java:587)
at
org.apache.lens.driver.jdbc.JDBCDriver.cancelQuery(JDBCDriver.java:962)
at
org.apache.lens.server.query.QueryExecutionServiceImpl.cancelQuery(QueryExecutionServiceImpl.java:2720)
- locked <0x000319a3dc88> (a
org.apache.lens.server.api.query.QueryContext)
at
org.apache.lens.server.query.QueryExecutionServiceImpl.access$3500(QueryExecutionServiceImpl.java:110)
at
org.apache.lens.server.query.QueryExecutionServiceImpl$CancelQueryTask.run(QueryExecutionServiceImpl.java:1667)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Found 1 deadlock.
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Re: Review Request 60739: LENS-1452: Optimize Time Union candidate Algorithm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60739/#review180024
---
Ship it!
Ship It!
- Amareshwari Sriramadasu
On July 10, 2017, 10:37 a.m., Rajat Khandelwal wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60739/
> ---
>
> (Updated July 10, 2017, 10:37 a.m.)
>
>
> Review request for lens and Sushil Mohanty.
>
>
> Bugs: LENS-1452
> https://issues.apache.org/jira/browse/LENS-1452
>
>
> Repository: lens
>
>
> Description
> ---
>
> Current algorithm:
>
> * Create bitmap (equivalent to powerset)
> * from the powerset, add sets which can complete all time ranges as candidates
> * Prune sets which are contained in other sets
>
> Proposed change:
>
> The following recursion implemented iteratively:
> {code}
> (ignoring cubeql for clarity)
> getCombinations(candidates) = getCombinationsRecursive(emptyList(),
> candidates)
> getCombinationsRecursive(incompleteCombinations: List<List>,
> candidates: List) =
> head, tail = head and tail of linked List candidates
> add head to all elements of incompleteCombinations.
> add {{ [head] }} as one incompleteCombination.
> complete = remove now complete combinations from incompleteCombinations
> return {{complete ++
> getCombinationsTailRecursive(incompleteCombinations+[head], tail)}}
> {code}
> The improvement is, that redundant union candidates like {a,b,c} won't be
> generated if {a,b} is already covering time ranges. This will only generate
> minimal sets that cover time ranges. So the memory footprint isn't O( 2^n )
> anymore.
>
>
> Diffs
> -
>
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
> 8e071621ec15f90094d346e2b6e109b82ea68348
>
>
> Diff: https://reviews.apache.org/r/60739/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
[jira] [Commented] (LENS-1412) CRUD operation support for Virtual fact and Unit test cases
[ https://issues.apache.org/jira/browse/LENS-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038370#comment-16038370 ] Amareshwari Sriramadasu commented on LENS-1412: --- Thanks [~rajitha.r] for the contribution ! > CRUD operation support for Virtual fact and Unit test cases > --- > > Key: LENS-1412 > URL: https://issues.apache.org/jira/browse/LENS-1412 > Project: Apache Lens > Issue Type: Sub-task > Components: cube, server >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.7 > > Attachments: Lens-1412.patch > > > Changes for CRUD operations in Virtual fact -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1412) CRUD operation support for Virtual fact and Unit test cases
[ https://issues.apache.org/jira/browse/LENS-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1412: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to both master and current-release-line > CRUD operation support for Virtual fact and Unit test cases > --- > > Key: LENS-1412 > URL: https://issues.apache.org/jira/browse/LENS-1412 > Project: Apache Lens > Issue Type: Sub-task > Components: cube, server >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.7 > > Attachments: Lens-1412.patch > > > Changes for CRUD operations in Virtual fact -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review176761 --- Ship it! Ship It! - Amareshwari Sriramadasu On June 2, 2017, 9:41 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated June 2, 2017, 9:41 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java > 9564443 > lens-api/src/main/resources/cube-0.1.xsd 8158e6d > lens-api/src/main/resources/lens-errors.conf 43de1e9 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > a01d6c0 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > 20f313a > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > d31e25c > lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java > ca6db2c > lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION > lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > f077c9c > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 32b9db3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 88bc1fc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 40f766b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a8d6fbd > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > 730b802 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 291712b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 42e32cb > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > a76ef13 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 2f300d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 7d1f80d > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java > fe52600 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > 7ec3324 > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION > lens-driver-es/pom.xml 925020e > lens-examples/pom.xml af467ee > lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527 > lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11 > lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55 > lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml > f95f91b > lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff > lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36 > lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > lens-server/pom.xml 60ed1ae > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/jav
Re: Review Request 59713: LENS-1427: ExpressionResolver is removing expressions if they are not answerable by *any* candidates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59713/#review176756 --- Ship it! Ship It! - Amareshwari Sriramadasu On June 2, 2017, 9:41 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59713/ > --- > > (Updated June 2, 2017, 9:41 a.m.) > > > Review request for lens. > > > Bugs: LENS-1427 > https://issues.apache.org/jira/browse/LENS-1427 > > > Repository: lens > > > Description > --- > > Should be at least one and *all* > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 7cad400bb12464c05b370a0aad5e7baec0248c1d > lens-cube/src/test/resources/schema/cubes/base/b1cube.xml > e3e99098f4a8dbee06e29b2a7af265b14b702aab > lens-cube/src/test/resources/schema/cubes/base/b2cube.xml > e5cf2c08959ffd1525b677e638f04944630e36dc > lens-cube/src/test/resources/schema/cubes/base/testcube.xml > f123341f5ecb2c2124e2a14c5768f6d04f5766fa > > > Diff: https://reviews.apache.org/r/59713/diff/2/ > > > Testing > --- > > > Thanks, > > Rajat Khandelwal > >
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review176749 --- lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java Lines 359 (patched) <https://reviews.apache.org/r/58796/#comment250219> Why are these changes required? Seems there are many unrelated code changes like this included in this review request. Might have to revert. - Amareshwari Sriramadasu On June 2, 2017, 9:41 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated June 2, 2017, 9:41 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > checkstyle/pom.xml 2902c6b > contrib/clients/python/pom.xml ac842bd > lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java > 9564443 > lens-api/src/main/resources/cube-0.1.xsd 8158e6d > lens-api/src/main/resources/lens-errors.conf 43de1e9 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > a01d6c0 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > 20f313a > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > d31e25c > lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java > ca6db2c > lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION > lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > f077c9c > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 32b9db3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 88bc1fc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 40f766b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a8d6fbd > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 6ba46d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 47bce65 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 43510dd > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java > 038d689 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > 730b802 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 291712b > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 6c0d91a > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 42e32cb > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > a76ef13 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 2f300d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 7d1f80d > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java > fe52600 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > 7ec3324 > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION > lens-dist/src/deb/control/postinst PRE-CREATION > lens-driver-es/pom.xml 925020e > len
Re: Review Request 59714: LENS-1428 : Common measures are getting repeated in UnionQuery for JoinCandidate
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59714/#review176728 --- Please include unit tests - Amareshwari Sriramadasu On June 1, 2017, 12:51 p.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59714/ > --- > > (Updated June 1, 2017, 12:51 p.m.) > > > Review request for lens. > > > Bugs: LENS-1428 > https://issues.apache.org/jira/browse/LENS-1428 > > > Repository: lens > > > Description > --- > > For JoinCandidate if a measure is answerable by its children, getting > projected in both. Instead the measure should be projected in one of the > children and default measure i.e 0.0 for the other. > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 47bce65 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java > 038d689 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 6c0d91a > > > Diff: https://reviews.apache.org/r/59714/diff/1/ > > > Testing > --- > > > Thanks, > > Sushil Mohanty > >
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review176051 --- lens-api/src/main/resources/cube-0.1.xsd Lines 1226 (patched) <https://reviews.apache.org/r/58796/#comment249382> should we say columns and storages lens-api/src/main/resources/cube-0.1.xsd Lines 1256 (patched) <https://reviews.apache.org/r/58796/#comment249384> Shall we move properties to x_fact ? lens-api/src/main/resources/cube-0.1.xsd Lines 1290 (patched) <https://reviews.apache.org/r/58796/#comment249383> Should we move weight to x_fact ? - Amareshwari Sriramadasu On May 22, 2017, 10:59 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated May 22, 2017, 10:59 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 8158e6d > lens-api/src/main/resources/lens-errors.conf 43de1e9 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > a01d6c0 > lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > f077c9c > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 32b9db3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 88bc1fc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 40f766b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a8d6fbd > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 6ba46d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 43510dd > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > 730b802 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 291712b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 42e32cb > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > a76ef13 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 2f300d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 7d1f80d > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION > lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527 > lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11 > lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55 > lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml > f95f91b > lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff > lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36 > lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java > 9a1d79d > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > df4e07a > > le
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review175246 --- lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java Line 597 (original), 596 (patched) <https://reviews.apache.org/r/58796/#comment248699> I'm not sure if handling can be skipped for virtual fact. - Amareshwari Sriramadasu On May 17, 2017, 11:54 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated May 17, 2017, 11:54 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 8158e6d > lens-api/src/main/resources/lens-errors.conf 43de1e9 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 32b9db3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 88bc1fc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 40f766b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a8d6fbd > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 6ba46d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 43510dd > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > 730b802 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 291712b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 42e32cb > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > a76ef13 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 2f300d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 7d1f80d > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6d32d23 > > > Diff: https://reviews.apache.org/r/58796/diff/7/ > > > Testing > --- > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [1.467s] > [INFO] Lens .. SUCCESS [3.449s] > [INFO] Lens API .. SUCCESS [23.572s] > [INFO] Lens API for server and extensions SUCCESS [20.051s] > [INFO] Lens Cube . SUCCESS [5:41.995s] > [INFO] Lens DB storage ... SUCCESS [17.013s] > [INFO] Lens Query Library SUCCESS [13.632s] > [INFO] Lens Hive Driver .. SUCCESS [1:16.131s] > [INFO] Lens Driver for JDBC .. SUCCESS [48.127s] > [INFO] Lens Elastic Search Driver SUCCESS [21.542s] > [INFO] Lens Server ... SUCCESS > [16:38.220s]
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review175244 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Line 2459 (original), 2600 (patched) <https://reviews.apache.org/r/58796/#comment248698> need to call getCubeFactTable() ? - Amareshwari Sriramadasu On May 17, 2017, 11:54 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated May 17, 2017, 11:54 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 8158e6d > lens-api/src/main/resources/lens-errors.conf 43de1e9 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 32b9db3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 88bc1fc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 40f766b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a8d6fbd > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 6ba46d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 43510dd > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > 730b802 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 291712b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 42e32cb > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > a76ef13 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 2f300d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 7d1f80d > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6d32d23 > > > Diff: https://reviews.apache.org/r/58796/diff/7/ > > > Testing > --- > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [1.467s] > [INFO] Lens .. SUCCESS [3.449s] > [INFO] Lens API .. SUCCESS [23.572s] > [INFO] Lens API for server and extensions SUCCESS [20.051s] > [INFO] Lens Cube . SUCCESS [5:41.995s] > [INFO] Lens DB storage ... SUCCESS [17.013s] > [INFO] Lens Query Library SUCCESS [13.632s] > [INFO] Lens Hive Driver .. SUCCESS [1:16.131s] > [INFO] Lens Driver for JDBC .. SUCCESS [48.127s] > [INFO] Lens Elastic Search Driver SUCCESS [21.542s] > [INFO] Lens Server ... SUCCESS > [16:38.220s]
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review175209 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Lines 95 (patched) <https://reviews.apache.org/r/58796/#comment248618> Why would we need this mapping? Can you add a comment on why this mapping is required? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Line 194 (original), 188 (patched) <https://reviews.apache.org/r/58796/#comment248617> Should caller make sure not pass virtualFact name for this method? Or even we can do a check here and throw proper error. If not check done from call and here, it can result 500 errors on api. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Lines 2550 (patched) <https://reviews.apache.org/r/58796/#comment248619> It is dropping tables not just from cache, but persisted tables as well, might need rename. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Line 2459 (original), 2599 (patched) <https://reviews.apache.org/r/58796/#comment248620> Can we make sure all callers for the methods where getCubeFact() is getting casted to (CubeFactTable), virtual fact table will never be passed? lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java Lines 416 (patched) <https://reviews.apache.org/r/58796/#comment248623> can we put back the error? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java Line 607 (original), 597 (patched) <https://reviews.apache.org/r/58796/#comment248624> Seems getFact() can be virtual fact as well. Casting would result in error lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java Lines 1264 (patched) <https://reviews.apache.org/r/58796/#comment248625> Can we make virtual fact table to belong to a different cube? lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java Lines 469 (patched) <https://reviews.apache.org/r/58796/#comment248626> remove commented code lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java Lines 490 (patched) <https://reviews.apache.org/r/58796/#comment248627> remove commented code lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java Lines 186 (patched) <https://reviews.apache.org/r/58796/#comment248628> returning all facts? Instead should we say not implemented - Amareshwari Sriramadasu On May 16, 2017, 12:21 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated May 16, 2017, 12:21 p.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 8158e6d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 88bc1fc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 40f766b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a8d6fbd > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 6ba46d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 43510dd > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > 730b802 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 291712b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/Cu
Re: Review Request 59223: LENS-1420 : Bug fixes in cube segmentation final rewritten query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59223/#review174767 --- Please add unit tests for all three cases mentioned in description. - Amareshwari Sriramadasu On May 12, 2017, 8:53 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59223/ > --- > > (Updated May 12, 2017, 8:53 a.m.) > > > Review request for lens. > > > Bugs: LENS-1420 > https://issues.apache.org/jira/browse/LENS-1420 > > > Repository: lens > > > Description > --- > > Below bugs are addressed in final rewritten query. > 1. Expressions used in having clause are not resolved in the final rewritten > query incase of picked candidate is a segmentation. > 2. Alias is not being replaced in order by clause for segmentation queries. > 3. Query with two dim attributes referring to same join chain ending with > wrong alias replacement. > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > f86a84a > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > bd7134b > > > Diff: https://reviews.apache.org/r/59223/diff/1/ > > > Testing > --- > > lens-cube test cases are running fine. > > --- > T E S T S > --- > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; > support was removed in 8.0 > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Running TestSuite > > Tests run: 440, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 493.856 sec > - in TestSuite > > Results : > > Tests run: 440, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 9:37.126s > [INFO] Finished at: Fri May 12 12:44:16 IST 2017 > [INFO] Final Memory: 65M/1499M > [INFO] > > > > Thanks, > > Sushil Mohanty > >
[jira] [Updated] (LENS-52) TestQueryService.testPrepareQuery failing intermittently
[
https://issues.apache.org/jira/browse/LENS-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amareshwari Sriramadasu updated LENS-52:
Fix Version/s: (was: 2.7)
> TestQueryService.testPrepareQuery failing intermittently
>
>
> Key: LENS-52
> URL: https://issues.apache.org/jira/browse/LENS-52
> Project: Apache Lens
> Issue Type: Bug
> Components: test
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
>Priority: Minor
>
> {noframe}
> Tests run: 68, Failures: 1, Errors: 0, Skipped: 7, Time elapsed: 372.112 sec
> <<< FAILURE! - in TestSuite
> testPrepareQuery(org.apache.lens.server.query.TestQueryService) Time
> elapsed: 116.385 sec <<< FAILURE!
> java.lang.AssertionError: expected [SUCCESSFUL] but found [FAILED]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:165)
> at
> org.apache.lens.server.query.TestQueryService.testPrepareQuery(TestQueryService.java:565)
> {noframe}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (LENS-911) move throws HiveException clauses to throws LensException
[ https://issues.apache.org/jira/browse/LENS-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-911: - Fix Version/s: (was: 2.7) > move throws HiveException clauses to throws LensException > - > > Key: LENS-911 > URL: https://issues.apache.org/jira/browse/LENS-911 > Project: Apache Lens > Issue Type: Improvement > Components: cube > Reporter: Amareshwari Sriramadasu > > We should move throws HiveException clauses to throws LensException with > appropriate error codes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1225) Metastore requests should show more information on APIResult
[ https://issues.apache.org/jira/browse/LENS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1225: -- Fix Version/s: (was: 2.7) > Metastore requests should show more information on APIResult > > > Key: LENS-1225 > URL: https://issues.apache.org/jira/browse/LENS-1225 > Project: Apache Lens > Issue Type: Improvement > Components: client, server > Reporter: Amareshwari Sriramadasu > > Metastore requests give only SUCCESS as the response upon creation or update > of metastore entities. It should also give entity name and operation > (create/update) performed in APIResult back. > This will be useful when a batch of requests are completed, and which are > entities succeeded and which are failed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1021) Reduce test time on org.apache.lens.server.query tests
[ https://issues.apache.org/jira/browse/LENS-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1021: -- Fix Version/s: (was: 2.7) > Reduce test time on org.apache.lens.server.query tests > -- > > Key: LENS-1021 > URL: https://issues.apache.org/jira/browse/LENS-1021 > Project: Apache Lens > Issue Type: Improvement > Components: server, test > Reporter: Amareshwari Sriramadasu > > We are seeing following times right now : > > TestQueryConstraints 4 min 30 sec0 0 2 > 2 > TestQueryEndEmailNotifier 1 min 27 sec0 0 > 14 14 > TestQueryService 4 min 38 sec0 0 53 > 53 > TestResultFormatting 1 min 31 sec0 0 8 > 8 > > They should be reduced to few seconds. > All test times available at > https://builds.apache.org/job/PreCommit-Lens-Build/372/testReport/org.apache.lens.server.query/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-930) .TestBetweenTimeRangeWriter.testConsecutiveDayParts fails sometimes
[ https://issues.apache.org/jira/browse/LENS-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-930: - Fix Version/s: (was: 2.7) > .TestBetweenTimeRangeWriter.testConsecutiveDayParts fails sometimes > --- > > Key: LENS-930 > URL: https://issues.apache.org/jira/browse/LENS-930 > Project: Apache Lens > Issue Type: Bug > Components: cube > Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal > > Test failed here - > https://builds.apache.org/job/Lens-Commit/org.apache.lens$lens-cube/1172/testReport/junit/org.apache.lens.cube.parse/TestBetweenTimeRangeWriter/testConsecutiveDayParts/ > org.apache.lens.cube.parse.TestBetweenTimeRangeWriter.testConsecutiveDayParts > (from TestSuite) > Failing for the past 1 build (Since Unstable#1172 ) > Took 5 ms. > Error Message > expected [ (test.dt BETWEEN '2016-01-19 12:22:16' AND '2016-01-21 12:22:16') > ] but found [ (test.dt BETWEEN '2016-01-19 12:22:16' AND '2016-01-21 > 12:22:15') ] > Stacktrace > java.lang.AssertionError: expected [ (test.dt BETWEEN '2016-01-19 12:22:16' > AND '2016-01-21 12:22:16') ] but found [ (test.dt BETWEEN '2016-01-19 > 12:22:16' AND '2016-01-21 12:22:15') ] > at org.testng.Assert.fail(Assert.java:94) > at org.testng.Assert.failNotEquals(Assert.java:494) > at org.testng.Assert.assertEquals(Assert.java:123) > at org.testng.Assert.assertEquals(Assert.java:176) > at org.testng.Assert.assertEquals(Assert.java:186) > at > org.apache.lens.cube.parse.TestBetweenTimeRangeWriter.validateConsecutive(TestBetweenTimeRangeWriter.java:57) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1024) org.apache.lens.driver.hive.TestRemoteHiveDriver.testHiveDriverPersistence failed on one of the jenkins build
[ https://issues.apache.org/jira/browse/LENS-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1024: -- Fix Version/s: (was: 2.7) Not seeing the failure in latest builds > org.apache.lens.driver.hive.TestRemoteHiveDriver.testHiveDriverPersistence > failed on one of the jenkins build > - > > Key: LENS-1024 > URL: https://issues.apache.org/jira/browse/LENS-1024 > Project: Apache Lens > Issue Type: Bug > Components: driver-hive, test > Reporter: Amareshwari Sriramadasu > Attachments: test-hive-driver.log > > > org.apache.lens.driver.hive.TestRemoteHiveDriver.testHiveDriverPersistence > (from TestSuite) > Failing for the past 1 build (Since Unstable#391 ) > Took 0.36 sec. > add description > Error Message > DRIVER_ERROR[Error while processing statement: FAILED: Execution Error, > return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. Database does not > exist: testremotehivedriver] > Stacktrace > org.apache.lens.server.api.error.LensException: DRIVER_ERROR[Error while > processing statement: FAILED: Execution Error, return code 1 from > org.apache.hadoop.hive.ql.exec.DDLTask. Database does not exist: > testremotehivedriver] > at > org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.checkStatus(ThriftCLIServiceClient.java:52) > at > org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.executeStatementInternal(ThriftCLIServiceClient.java:151) > at > org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.executeStatement(ThriftCLIServiceClient.java:129) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:483) > at > org.apache.hive.service.cli.thrift.RetryingThriftCLIServiceClient.invokeInternal(RetryingThriftCLIServiceClient.java:301) > at > org.apache.hive.service.cli.thrift.RetryingThriftCLIServiceClient.invoke(RetryingThriftCLIServiceClient.java:329) > at com.sun.proxy.$Proxy31.executeStatement(Unknown Source) > at > org.apache.hive.service.cli.thrift.RetryingThriftCLIServiceClient$CLIServiceClientWrapper.executeStatement(RetryingThriftCLIServiceClient.java:111) > at org.apache.lens.driver.hive.HiveDriver.execute(HiveDriver.java:518) > at > org.apache.lens.driver.hive.TestRemoteHiveDriver.testHiveDriverPersistence(TestRemoteHiveDriver.java:248) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-956) Seeing intermittent failure TestRemoteHiveDriver.testMultiThreadClient
[ https://issues.apache.org/jira/browse/LENS-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-956: - Fix Version/s: (was: 2.7) > Seeing intermittent failure TestRemoteHiveDriver.testMultiThreadClient > -- > > Key: LENS-956 > URL: https://issues.apache.org/jira/browse/LENS-956 > Project: Apache Lens > Issue Type: Bug > Components: test > Reporter: Amareshwari Sriramadasu > > One such failure at https://builds.apache.org/job/PreCommit-Lens-Build/277/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-660) TestMLRunner.trainAndEvalFromDir fails some times
[
https://issues.apache.org/jira/browse/LENS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amareshwari Sriramadasu updated LENS-660:
-
Fix Version/s: (was: 2.7)
> TestMLRunner.trainAndEvalFromDir fails some times
> -
>
> Key: LENS-660
> URL: https://issues.apache.org/jira/browse/LENS-660
> Project: Apache Lens
> Issue Type: Bug
> Components: ml
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: test-failure.log
>
>
> Here is the failure :
> {noformat}
> Error Message
> expected [SUCCESSFUL] but found [FAILED]
> Stacktrace
> java.lang.AssertionError: expected [SUCCESSFUL] but found [FAILED]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:165)
> at
> org.apache.lens.ml.TestMLRunner.trainAndEvalFromDir(TestMLRunner.java:132)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (LENS-1165) Separate client for query submission from other thrift operations
[ https://issues.apache.org/jira/browse/LENS-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1165: -- Fix Version/s: (was: 2.7) > Separate client for query submission from other thrift operations > - > > Key: LENS-1165 > URL: https://issues.apache.org/jira/browse/LENS-1165 > Project: Apache Lens > Issue Type: Improvement > Components: driver-hive > Reporter: Amareshwari Sriramadasu > Assignee: Amareshwari Sriramadasu > > Proposing to add separate thrift client for query submissions in HiveDriver > with ability to give different thrift read timeouts and number of retries. > This would help in the following cases : > We have seen instances of query submission which can take more time. For ex : > > 2016-06-02T20:20:21,436 INFO [ef431743-b9f8-4fe0-8e3d-2bab154438eb > HiveServer2-Handler-Pool: Thread-66837]: ql.Driver (Driver.java:compile(372)) > - Compiling > command(queryId=hive_20160602195701_2a3bd795-0919-4e2e-ad22-812881b084fd): > 2016-06-02T21:02:43,380 INFO [ef431743-b9f8-4fe0-8e3d-2bab154438eb > HiveServer2-Handler-Pool: Thread-66255]: ql.Driver (Driver.java:compile(524)) > - Completed compiling > command(queryId=hive_2016060222_e58e07f9-61d0-423d-86ef-a626eb250114); > Time taken: 1830.214 seconds > --- > In such cases lens submission will timeout with default client and resubmit, > which would take more time again. > And eventually, there will be number of submissions equal to the number of > retries configured and lens would have marked the query as failed. But > submission would actually launch multiple queries. > If we have separate client, it can be configured with different timeout value > and number retries to be different. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1259) Add ability to re-submit a query
[ https://issues.apache.org/jira/browse/LENS-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1259: -- Fix Version/s: (was: 2.7) > Add ability to re-submit a query > > > Key: LENS-1259 > URL: https://issues.apache.org/jira/browse/LENS-1259 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Amareshwari Sriramadasu > Assignee: Amareshwari Sriramadasu > > This requirement is to re-submit a query given a query handle. It should be > resubmitted with same query name, query configuration. Relaunch to be done as > same submitted user. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1330) Remove protobuf dependency from lens
[
https://issues.apache.org/jira/browse/LENS-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amareshwari Sriramadasu updated LENS-1330:
--
Fix Version/s: (was: 2.7)
2.6
> Remove protobuf dependency from lens
>
>
> Key: LENS-1330
> URL: https://issues.apache.org/jira/browse/LENS-1330
> Project: Apache Lens
> Issue Type: Bug
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.6
>
>
> protobuf is not required to be bundled
> {noformat}
>
> com.google.protobuf
> protobuf-java
> ${protobuf.version}
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (LENS-1347) Examples failing on 2.6 build and master
[ https://issues.apache.org/jira/browse/LENS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1347: -- Fix Version/s: (was: 2.7) 2.6 > Examples failing on 2.6 build and master > > > Key: LENS-1347 > URL: https://issues.apache.org/jira/browse/LENS-1347 > Project: Apache Lens > Issue Type: Bug > Components: examples >Affects Versions: 2.6 > Reporter: Amareshwari Sriramadasu > Fix For: 2.6 > > > When run examples : > > Successful queries 14 out of 151queries > Seeing all cube queries are failing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review174282 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java Lines 84 (patched) <https://reviews.apache.org/r/58796/#comment247410> We need to persist sourceFactName as well. - Amareshwari Sriramadasu On May 8, 2017, 6:08 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated May 8, 2017, 6:08 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 68ccc13 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > e00122d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > 6dd35b3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027f > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1f > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0ef > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0 > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java > 310a655 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 95e3c95 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 10c3bbe > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 3a17499 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 033264c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > bab1080 > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6d32d23 > > > Diff: https://reviews.apache.org/r/58796/diff/3/ > > > Testing > --- > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [1.467s] > [INFO] Lens .. SUCCESS [3.449s] > [INFO] Lens API .. SUCCESS [23.572s] > [INFO] Lens API for server and extensions SUCCESS [20.051s] > [INFO] Lens Cube . SUCCESS [5:41.995s] > [INFO] Lens DB storage ... SUCCESS [17.013s] > [INFO] Lens Query Library SUCCESS [13.632s] > [INFO] Lens Hive Driver .. SUCCESS [1:16.131s] > [INFO] Lens Driver for JDBC .. SUCCESS [48.127s] > [INFO] Lens Elastic Search Driver SUCCESS [21.542s] > [INFO] Lens Server ... SUCCESS > [16:38.220s] > [INFO] Lens client ... SUCCESS [1:25.658s] > [INFO] Lens CLI .. SUCCESS [1:16.332s] > [INFO] Lens Examples ..
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review174275 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java Lines 229-234 (patched) <https://reviews.apache.org/r/58796/#comment247400> Can we move this method to MetastoreUtil or even remove it and use the onliner 'props.get(MetastoreUtil.getFactCubeNameKey(factName));' from the caller itself? lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java Lines 233 (patched) <https://reviews.apache.org/r/58796/#comment247401> Same as above. Also seems method name is misleading. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Lines 98 (patched) <https://reviews.apache.org/r/58796/#comment247402> Why is this mapping required? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Line 136 (original), 134 (patched) <https://reviews.apache.org/r/58796/#comment247403> Does extractStorageName has to work on FactTable interface as well? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Line 2195 (original), 2326 (patched) <https://reviews.apache.org/r/58796/#comment247404> Shall we return all facts here both direct facts and virtual facts? We can have one more method which takes a boolean to include virtual facts or not? lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java Lines 29 (patched) <https://reviews.apache.org/r/58796/#comment247405> remvoe author tags. lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java Lines 31 (patched) <https://reviews.apache.org/r/58796/#comment247407> Can we add javadoc for all the methods in interface? lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java Lines 55 (patched) <https://reviews.apache.org/r/58796/#comment247406> This looks more a util method and shouldnt sit in interface. lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java Lines 725 (patched) <https://reviews.apache.org/r/58796/#comment247408> Why are we doing this copy of properties? - Amareshwari Sriramadasu On May 8, 2017, 6:08 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated May 8, 2017, 6:08 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 68ccc13 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > e00122d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > 6dd35b3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027f > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1f > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0ef > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0 > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java > 310a655 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 95e3c95 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 10c3bbe > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 3a17499 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 033264c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > bab1080 > lens-cube/src/test/resources/schema/cubes/base/virtualcube.x
Re: Review Request 58948: LENS-1416 : Union query order by should work on column alias
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58948/#review173711 --- Ship it! Ship It! - Amareshwari Sriramadasu On May 3, 2017, 9:12 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58948/ > --- > > (Updated May 3, 2017, 9:12 a.m.) > > > Review request for lens. > > > Bugs: LENS-1416 > https://issues.apache.org/jira/browse/LENS-1416 > > > Repository: lens > > > Description > --- > > In union queries order by clause should have column alias instead of column. > > > Diffs > - > > lens-api/src/main/resources/lens-errors.conf e5536bb > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > babe3de > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 467ca0a > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > f5f468f > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 1b4cc10 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > 8e65139 > > > Diff: https://reviews.apache.org/r/58948/diff/1/ > > > Testing > --- > > > Thanks, > > Sushil Mohanty > >
[jira] [Commented] (LENS-1416) Union query order by should work on column alias
[ https://issues.apache.org/jira/browse/LENS-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994462#comment-15994462 ] Amareshwari Sriramadasu commented on LENS-1416: --- [~sushilmohanty] Can you raise a review request with changes? Couple of comments: * Let us use error code for the new error getting thrown. * Add a testcase validating the union scenario. Not sure if one already exists. * Add a testcase validating the error scenario. > Union query order by should work on column alias > > > Key: LENS-1416 > URL: https://issues.apache.org/jira/browse/LENS-1416 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Sushil Mohanty >Assignee: Sushil Mohanty > Attachments: LENS-1416_1.patch, LENS-1416.patch > > > In union queries order by clause should have column alias instead of column. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review173578 --- lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java Lines 1280 (patched) <https://reviews.apache.org/r/58796/#comment246572> Instead of doing creation of the fact here, can we do getVirtualFactTable(vFactName) and validate? - Amareshwari Sriramadasu On April 28, 2017, 10:23 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated April 28, 2017, 10:23 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 68ccc13 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > 6dd35b3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 3a17499 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6d32d23 > > > Diff: https://reviews.apache.org/r/58796/diff/2/ > > > Testing > --- > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [1.467s] > [INFO] Lens .. SUCCESS [3.449s] > [INFO] Lens API .. SUCCESS [23.572s] > [INFO] Lens API for server and extensions SUCCESS [20.051s] > [INFO] Lens Cube . SUCCESS [5:41.995s] > [INFO] Lens DB storage ... SUCCESS [17.013s] > [INFO] Lens Query Library SUCCESS [13.632s] > [INFO] Lens Hive Driver .. SUCCESS [1:16.131s] > [INFO] Lens Driver for JDBC .. SUCCESS [48.127s] > [INFO] Lens Elastic Search Driver SUCCESS [21.542s] > [INFO] Lens Server ... SUCCESS > [16:38.220s] > [INFO] Lens client ... SUCCESS [1:25.658s] > [INFO] Lens CLI .. SUCCESS [1:16.332s] > [INFO] Lens Examples . SUCCESS [8.432s] > [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.766s] > [INFO] Lens Distribution . SUCCESS [9.499s] > [INFO] Lens ML Lib ... SUCCESS [1:02.656s] > [INFO] Lens ML Ext Distribution .. SUCCESS [2.552s] > [INFO] Lens Regression ... SUCCESS [12.136s] > [INFO] Lens UI ... SUCCESS [32.999s] > [INFO] Lens Contrib .. SUCCESS [0.358s] > [INFO] Lens Contributed Clients .. SUCCESS [0.360s] > [INFO] Lens Python Client SUCCESS [0.366s] > [INFO] > > > > Thanks, > > Rajitha R > >
Re: Review Request 58844: LENS-1415: Make ResultRow implement Serializable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58844/#review173560 --- Ship it! Ship It! - Amareshwari Sriramadasu On April 28, 2017, 2:32 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58844/ > --- > > (Updated April 28, 2017, 2:32 p.m.) > > > Review request for lens. > > > Bugs: LENS-1415 > https://issues.apache.org/jira/browse/LENS-1415 > > > Repository: lens > > > Description > --- > > This will help in people analyzing InMemoryResult. Analyzing the result can > be done via spark and spark expects its dataset objects to be Serializable. > > > Diffs > - > > lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java > db91e41fbe70f03da92e92b41c21318e12b2b05e > > lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java > dbdc677edd90c91cace81958b735dcafea9a0101 > lens-api/src/main/java/org/apache/lens/api/query/ResultColumn.java > ecf4713bcb1bf7044503bf56097df781c505b8a1 > lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java > c71d02e3ba1c2f9f3b7ca30d6be81f341c34e466 > lens-api/src/main/java/org/apache/lens/api/query/ResultRow.java > b8bad60b365731633623c6ae3d8a94bd1bd137da > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > f66249056079ce0452a7a377a47732269cd9f759 > > > Diff: https://reviews.apache.org/r/58844/diff/1/ > > > Testing > --- > > > Thanks, > > Rajat Khandelwal > >
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review173559 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Lines 386 (patched) <https://reviews.apache.org/r/58796/#comment246550> Why are all source fact properties getting copied for virtual fact? I feel, we shouldn't be doing this. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java Lines 27 (patched) <https://reviews.apache.org/r/58796/#comment246552> Can we avoid extends of the CubeFactTable, as the class is already composing sourceFactTable ? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java Lines 32 (patched) <https://reviews.apache.org/r/58796/#comment246554> Not sure how are we passing sourceHiveTable for the constructor here? We need to actually store the source fact table as a property name underlying Hive table. lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java Lines 1268 (patched) <https://reviews.apache.org/r/58796/#comment246555> Can we create virtual fact belonging to a different cube than source fact? lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java Lines 432 (patched) <https://reviews.apache.org/r/58796/#comment246556> Can we name the param vFact ? Applies to all methods. - Amareshwari Sriramadasu On April 28, 2017, 10:23 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > --- > > (Updated April 28, 2017, 10:23 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > --- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd 68ccc13 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > 6dd35b3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 3a17499 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6d32d23 > > > Diff: https://reviews.apache.org/r/58796/diff/2/ > > > Testing > --- > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules . SUCCESS [1.467s] > [INFO] Lens .. SUCCESS [3.449s] > [INFO] Lens API .. SUCCESS [23.572s] > [INFO] Lens API for server and extensions SUCCESS [20.051s] > [INFO] Lens Cube . SUCCESS [5:41.995s] > [INFO] Lens DB storage ... SUCCESS [17.013s] > [INFO] Lens Query Library SUCCESS [13.632s] > [INFO] Lens Hive Driver .. SUCCESS [1:16.131s] > [INFO] Lens Driver for JDBC .. SUCCESS [48.127s] > [INFO] Lens Elastic Search Driver SUCCESS [21.542s] > [INFO] Lens Server ... SUCCESS > [16:38.220s] > [INFO] Lens client ... SUCCESS [1:25.658s] > [INFO] Lens CLI .. SUCCESS [1:16.332s] > [INFO] Lens Examples . SUCCESS [8.432s] > [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.766s] > [INFO] Lens Distribution . SUCCESS [9.499s] > [INFO] Lens ML Lib ... SUCCESS [1:02.656s] > [INFO] Lens ML Ext Distribution .. SUCCESS [2.552s] > [INFO] Lens Regression ...
[jira] [Commented] (LENS-1412) CRUD operation support for Virtual fact and Unit test cases
[ https://issues.apache.org/jira/browse/LENS-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988604#comment-15988604 ] Amareshwari Sriramadasu commented on LENS-1412: --- bq. Please let me know if there is anything missing here. [~rajitha.r] Need to set Reviewer groups as lens, to be tracked in lens and to receive an email on dev@lens. Otherwise, it cannot be tracked. Have updated the request for now. > CRUD operation support for Virtual fact and Unit test cases > --- > > Key: LENS-1412 > URL: https://issues.apache.org/jira/browse/LENS-1412 > Project: Apache Lens > Issue Type: Sub-task > Components: cube, server >Reporter: Rajitha R >Assignee: Rajitha R > Attachments: Lens-1412.patch > > > Changes for CRUD operations in Virtual fact -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review173297 --- Ship it! Overall changes look good. Would need merge with master - Amareshwari Sriramadasu On April 27, 2017, 11:58 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > --- > > (Updated April 27, 2017, 11:58 a.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > --- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd > 1d8a6241a85066f111b8490e8e03516e4848cf41 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > befe4e6617ff4149136bd4bc2d2a8196414cba41 > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > e00122db06a4afcb8f227419669ee6e544888f2e > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0eff271c62020800b9309a223f4f0db8d296 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 300d798f9dd5760853d86d106ec2b9fc1e91afb5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0f2204591521f44584239fc9e275a60649 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 30fa873c255df408563f3c20062a6ccfca0f3811 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 926a4d0e0eaead3
Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review173294 --- lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java Lines 66 (patched) <https://reviews.apache.org/r/57947/#comment246326> Make sure fact valid columns are used for this wherever required. - Amareshwari Sriramadasu On April 27, 2017, 11:58 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > --- > > (Updated April 27, 2017, 11:58 a.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > --- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd > 1d8a6241a85066f111b8490e8e03516e4848cf41 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > befe4e6617ff4149136bd4bc2d2a8196414cba41 > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > e00122db06a4afcb8f227419669ee6e544888f2e > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0eff271c62020800b9309a223f4f0db8d296 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 300d798f9dd5760853d86d106ec2b9fc1e91afb5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0f2204591521f44584239fc9e275a60649 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 30fa873c255df408563f3c20062a6ccfca0f3811 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 6f6572ea
[jira] [Commented] (LENS-1412) CRUD operation support for Virtual fact and Unit test cases
[ https://issues.apache.org/jira/browse/LENS-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988228#comment-15988228 ] Amareshwari Sriramadasu commented on LENS-1412: --- [~rajitha.r] Please create a review board request. > CRUD operation support for Virtual fact and Unit test cases > --- > > Key: LENS-1412 > URL: https://issues.apache.org/jira/browse/LENS-1412 > Project: Apache Lens > Issue Type: Sub-task > Components: cube, server >Reporter: Rajitha R >Assignee: Rajitha R > Attachments: Lens-1412.patch > > > Changes for CRUD operations in Virtual fact -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review173168 --- Needs clarity on how CandidateExploder is propagating to SegmentationCandidates - Amareshwari Sriramadasu On April 25, 2017, 2:18 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > --- > > (Updated April 25, 2017, 2:18 p.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > --- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd > 1d8a6241a85066f111b8490e8e03516e4848cf41 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > befe4e6617ff4149136bd4bc2d2a8196414cba41 > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > e00122db06a4afcb8f227419669ee6e544888f2e > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0eff271c62020800b9309a223f4f0db8d296 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 300d798f9dd5760853d86d106ec2b9fc1e91afb5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0f2204591521f44584239fc9e275a60649 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 30fa873c255df408563f3c20062a6ccfca0f3811 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 926a4d0e0eaead3
Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review173030 --- lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java Line 264 (original), 265 (patched) <https://reviews.apache.org/r/57947/#comment246116> New variable to be defined for holding storageTableName ? - Amareshwari Sriramadasu On April 25, 2017, 2:18 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > --- > > (Updated April 25, 2017, 2:18 p.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > --- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd > 1d8a6241a85066f111b8490e8e03516e4848cf41 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > befe4e6617ff4149136bd4bc2d2a8196414cba41 > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > e00122db06a4afcb8f227419669ee6e544888f2e > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0eff271c62020800b9309a223f4f0db8d296 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 300d798f9dd5760853d86d106ec2b9fc1e91afb5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0f2204591521f44584239fc9e275a60649 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 30fa873c255df408563f3c20062a6ccfca0f3811 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.ja
Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review173027 --- lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java Lines 912 (patched) <https://reviews.apache.org/r/57947/#comment246112> commented code? lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java Lines 96 (patched) <https://reviews.apache.org/r/57947/#comment246113> Getter called without any consumption? - Amareshwari Sriramadasu On April 25, 2017, 2:18 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > --- > > (Updated April 25, 2017, 2:18 p.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > --- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd > 1d8a6241a85066f111b8490e8e03516e4848cf41 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > befe4e6617ff4149136bd4bc2d2a8196414cba41 > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > e00122db06a4afcb8f227419669ee6e544888f2e > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0eff271c62020800b9309a223f4f0db8d296 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 300d798f9dd5760853d86d106ec2b9fc1e91afb5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0f2204591521f44584239fc9e275a60649 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 30fa873c255df408563f3c20062a6ccfca0f3811 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLCon
Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review173023 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java Line 38 (original) <https://reviews.apache.org/r/57947/#comment246100> comment was describing what was stored in map, would be helpful. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java Lines 78 (patched) <https://reviews.apache.org/r/57947/#comment246099> getColumns have to be overridden here, to return from validcolumns if validacolumns property is set. lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java Lines 37 (patched) <https://reviews.apache.org/r/57947/#comment246103> Why is clear requried? lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java Lines 39 (patched) <https://reviews.apache.org/r/57947/#comment246106> Can we add comments on what is happening here? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java Line 865 (original), 850 (patched) <https://reviews.apache.org/r/57947/#comment246110> Is the above logic for writing error still requried, which this log here? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java Line 136 (original), 143 (patched) <https://reviews.apache.org/r/57947/#comment246111> Can we add comments around new resovlers added? - Amareshwari Sriramadasu On April 25, 2017, 2:18 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > --- > > (Updated April 25, 2017, 2:18 p.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > --- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd > 1d8a6241a85066f111b8490e8e03516e4848cf41 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > befe4e6617ff4149136bd4bc2d2a8196414cba41 > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > e00122db06a4afcb8f227419669ee6e544888f2e > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb >
Re: Review Request 58604: Handle Estimates failing with task rejection errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/#review172774 --- Ship it! Ship It! - Amareshwari Sriramadasu On April 24, 2017, 11:43 a.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58604/ > --- > > (Updated April 24, 2017, 11:43 a.m.) > > > Review request for lens. > > > Bugs: LENS-1413 > https://issues.apache.org/jira/browse/LENS-1413 > > > Repository: lens > > > Description > --- > > 1. Cancel estimates for other drivers when the estimate pool queue is full. > 2. Return the appropriate error message > > > Diffs > - > > lens-api/src/main/resources/lens-errors.conf 236d678 > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > 14a31e2 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c6fbeda > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 7e9133e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7d8c977 > lens-server/src/test/resources/lens-site.xml 334a9c4 > > > Diff: https://reviews.apache.org/r/58604/diff/4/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 58604: Handle Estimates failing with task rejection errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/#review172628 --- lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java Lines 68 (patched) <https://reviews.apache.org/r/58604/#comment245707> Should not be going into Cube errors, should be moved to LensServerErrorCode. And accordingly change error code and position in lens-errors lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java Lines 1988 (patched) <https://reviews.apache.org/r/58604/#comment245709> why is it only 10, when 20 threads are launched? lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java Lines 1989 (patched) <https://reviews.apache.org/r/58604/#comment245710> Should we be joining for all vs interrupt them and join? Interrupting would reduce test time. lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java Lines 1991 (patched) <https://reviews.apache.org/r/58604/#comment245708> Add assert for howmany failed as well. - Amareshwari Sriramadasu On April 21, 2017, 11:40 a.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58604/ > --- > > (Updated April 21, 2017, 11:40 a.m.) > > > Review request for lens. > > > Bugs: LENS-1413 > https://issues.apache.org/jira/browse/LENS-1413 > > > Repository: lens > > > Description > --- > > 1. Cancel estimates for other drivers when the estimate pool queue is full. > 2. Return the appropriate error message > > > Diffs > - > > lens-api/src/main/resources/lens-errors.conf 236d678 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > babe3de > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c6fbeda > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 7e9133e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7d8c977 > lens-server/src/test/resources/lens-site.xml 334a9c4 > > > Diff: https://reviews.apache.org/r/58604/diff/2/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 58604: Handle Estimates failing with task rejection errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/#review172607 --- lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java Lines 1727 (patched) <https://reviews.apache.org/r/58604/#comment245692> Should have a proper error code associated and message should go to lens-errors.conf lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java Lines 2044-2046 (patched) <https://reviews.apache.org/r/58604/#comment245695> We can use FailingQueryDriver instead of changing server state like this. lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java Lines 2051-2054 (patched) <https://reviews.apache.org/r/58604/#comment245696> Can we call estimate api instead of this and validate the error response from api? lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java Lines 2065 (patched) <https://reviews.apache.org/r/58604/#comment245697> Calling sleeping estimates in for loop will do than running them as Runnables. - Amareshwari Sriramadasu On April 21, 2017, 7:25 a.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58604/ > --- > > (Updated April 21, 2017, 7:25 a.m.) > > > Review request for lens. > > > Bugs: LENS-1413 > https://issues.apache.org/jira/browse/LENS-1413 > > > Repository: lens > > > Description > --- > > 1. Cancel estimates for other drivers when the estimate pool queue is full. > 2. Return the appropriate error message > > > Diffs > - > > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 92724c6 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c6fbeda > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7d8c977 > lens-server/src/test/resources/lens-site.xml 334a9c4 > > > Diff: https://reviews.apache.org/r/58604/diff/1/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review172464 --- lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java Line 271 (original), 271 (patched) <https://reviews.apache.org/r/57947/#comment245588> This looks a wrong assignment of storageTable to storageName. - Amareshwari Sriramadasu On April 19, 2017, 1:36 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > --- > > (Updated April 19, 2017, 1:36 p.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > --- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > - > > lens-api/src/main/java/org/apache/lens/api/ds/Tuple2.java PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateSegmentResolver.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0eff271c62020800b9309a223f4f0db8d296 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 300d798f9dd5760853d86d106ec2b9fc1e91afb5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0f2204591521f44584239fc9e275a60649 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 30fa873c255df408563f3c20062a6ccfca0f3811 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 926a4d0e0eaead3
Re: Review Request 58338: LENS-1410
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58338/#review172322 --- Ship it! - Amareshwari Sriramadasu On April 19, 2017, 6:57 a.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58338/ > --- > > (Updated April 19, 2017, 6:57 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-1410 > https://issues.apache.org/jira/browse/LENS-1410 > > > Repository: lens > > > Description > --- > > A string filer for getting for partition api must tbe provided > > > Diffs > - > > lens-api/src/main/resources/lens-errors.conf 94505ef > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 9ea887a > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > befe4e6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > f176078 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > d98c4c5 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 9ba1eb1 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > f6f6e77 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 064da01 > > > Diff: https://reviews.apache.org/r/58338/diff/4/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
[jira] [Updated] (LENS-1405) Xsd for virtual fact
[ https://issues.apache.org/jira/browse/LENS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1405: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed. Thanks [~rajitha.r] > Xsd for virtual fact > > > Key: LENS-1405 > URL: https://issues.apache.org/jira/browse/LENS-1405 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.7 > > Attachments: lens_latest.patch, Lens-patch > > > To define a xsd for virtual fact. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1381) Support Fact to Fact Union
[ https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1381: -- Resolution: Fixed Status: Resolved (was: Patch Available) Changes are committed as part of LENS-1391 > Support Fact to Fact Union > -- > > Key: LENS-1381 > URL: https://issues.apache.org/jira/browse/LENS-1381 > Project: Apache Lens > Issue Type: New Feature >Reporter: Puneet Gupta >Assignee: Sushil Mohanty > Fix For: 2.7 > > Attachments: LENS-1381_4.patch, LENS-1381_checkstyle_fix_1.patch, > LENS-1381_checkstyle_fix.patch > > > Currently Lens supports Union-ing data across different storages in a single > Fact. With this JIRA Lens server will be able to Union Data Across Facts too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1391: -- Resolution: Fixed Fix Version/s: 2.7 Status: Resolved (was: Patch Available) Committed. Thanks [~lavkesh] ! > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.7 > > Attachments: LENS-1391.1.patch, LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review172173 --- lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java Line 36 (original), 37 (patched) <https://reviews.apache.org/r/57947/#comment245287> Lets avoid this. Whats the purpose of keeping CubeQueryContext in exception class? lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java Lines 59 (patched) <https://reviews.apache.org/r/57947/#comment245292> Can we add javadoc for all default methods added? lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java Lines 233 (patched) <https://reviews.apache.org/r/57947/#comment245291> Needs better exception message. also these errors will result in 500 errors, need to be handled well. lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java Lines 38 (patched) <https://reviews.apache.org/r/57947/#comment245293> How is prune cause getting populated? - Amareshwari Sriramadasu On April 13, 2017, 9:55 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > --- > > (Updated April 13, 2017, 9:55 a.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > --- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > - > > lens-api/src/main/java/org/apache/lens/api/ds/Tuple2.java PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateSegmentResolver.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0eff271c62020800b9309a223f4f0db8d296 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 300d798f9dd5760853d86d106ec2b9fc1e91afb5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0f2204591521f44584239fc9e275a60649 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryR
