[jira] [Commented] (LUCENE-5885) MergeScheduler should not implement Closeable

2014-08-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096936#comment-14096936 ] Shai Erera commented on LUCENE-5885: I had a chat w/ Mike about this - we think that

[jira] [Updated] (LUCENE-5885) MergeScheduler should not implement Closeable

2014-08-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5885: --- Attachment: LUCENE-5885.patch Patch removes CMS.sync() and Closeable from MergeScheduler. Note that

[jira] [Commented] (LUCENE-5885) MergeScheduler should not implement Closeable

2014-08-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097149#comment-14097149 ] Shai Erera commented on LUCENE-5885: I ran tests after the fix on LUCENE-5871, but I

[jira] [Updated] (LUCENE-5885) MergeScheduler should not implement Closeable

2014-08-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5885: --- Attachment: LUCENE-5885.patch Patch fixes the bug - finishMerges(false) is more robust now, and

[jira] [Updated] (LUCENE-5883) Move MergePolicy to LiveIndexWriterConfig

2014-08-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5883: --- Attachment: LUCENE-5883.patch Thanks Mike, I improved the jdocs. This patch also removes Closeable

[jira] [Commented] (LUCENE-5883) Move MergePolicy to LiveIndexWriterConfig

2014-08-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096603#comment-14096603 ] Shai Erera commented on LUCENE-5883: BTW, the way I implemented it is that top-level

[jira] [Created] (LUCENE-5883) Move MergePolicy to LiveIndexWriterConfig

2014-08-13 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5883: -- Summary: Move MergePolicy to LiveIndexWriterConfig Key: LUCENE-5883 URL: https://issues.apache.org/jira/browse/LUCENE-5883 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-5883) Move MergePolicy to LiveIndexWriterConfig

2014-08-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5883: --- Attachment: LUCENE-5883.patch Patch moves MergePolicy to LiveIndexWriterConfig. Note though that at

[jira] [Commented] (SOLR-6315) Remove SimpleOrderedMap

2014-08-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14088894#comment-14088894 ] Shai Erera commented on SOLR-6315: -- {quote} One option for the stated purpose of this

[jira] [Commented] (SOLR-912) org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList

2014-08-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087307#comment-14087307 ] Shai Erera commented on SOLR-912: - Hi Shawn. See SOLR-6315 which I opened to do exactly that

[jira] [Commented] (LUCENE-5871) Simplify or remove use of Version in IndexWriterConfig

2014-08-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087317#comment-14087317 ] Shai Erera commented on LUCENE-5871: I don't think this patch is correct. IndexWriter

[jira] [Commented] (LUCENE-5871) Simplify or remove use of Version in IndexWriterConfig

2014-08-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087778#comment-14087778 ] Shai Erera commented on LUCENE-5871: We could change the semantics, but I pointed out

[jira] [Commented] (LUCENE-5871) Simplify or remove use of Version in IndexWriterConfig

2014-08-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087780#comment-14087780 ] Shai Erera commented on LUCENE-5871: I guess what I'm trying to say is, if we make

[jira] [Commented] (LUCENE-5859) Remove Version from Analyzer constructors

2014-08-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086079#comment-14086079 ] Shai Erera commented on LUCENE-5859: I think we can apply the same approach here to

[jira] [Commented] (LUCENE-5871) Simplify or remove use of Version in IndexWriterConfig

2014-08-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086435#comment-14086435 ] Shai Erera commented on LUCENE-5871: Version is currently used to decide whether to

[jira] [Commented] (SOLR-6315) Remove SimpleOrderedMap

2014-08-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084374#comment-14084374 ] Shai Erera commented on SOLR-6315: -- OK, so I think if the jdocs said exactly (and only)

[jira] [Commented] (SOLR-912) org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083884#comment-14083884 ] Shai Erera commented on SOLR-912: - Resurrecting that issue, I reviewed NamedList and I don't

[jira] [Comment Edited] (SOLR-912) org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083884#comment-14083884 ] Shai Erera edited comment on SOLR-912 at 8/3/14 6:21 AM: -

[jira] [Comment Edited] (SOLR-912) org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083884#comment-14083884 ] Shai Erera edited comment on SOLR-912 at 8/3/14 6:22 AM: -

[jira] [Commented] (SOLR-912) org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083888#comment-14083888 ] Shai Erera commented on SOLR-912: - One other thing, how important is it to be able to store

[jira] [Created] (SOLR-6315) Remove SimpleOrderedMap

2014-08-03 Thread Shai Erera (JIRA)
Shai Erera created SOLR-6315: Summary: Remove SimpleOrderedMap Key: SOLR-6315 URL: https://issues.apache.org/jira/browse/SOLR-6315 Project: Solr Issue Type: Improvement Components:

[jira] [Updated] (SOLR-6315) Remove SimpleOrderedMap

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-6315: - Attachment: SOLR-6315.patch Simple patch. It's huge because it's a rote search-and-replace, but nothing

[jira] [Comment Edited] (SOLR-6315) Remove SimpleOrderedMap

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083936#comment-14083936 ] Shai Erera edited comment on SOLR-6315 at 8/3/14 10:34 AM: ---

[jira] [Commented] (SOLR-6315) Remove SimpleOrderedMap

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083954#comment-14083954 ] Shai Erera commented on SOLR-6315: -- I thought about it, I think it's odd that whoever

[jira] [Commented] (SOLR-6315) Remove SimpleOrderedMap

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083970#comment-14083970 ] Shai Erera commented on SOLR-6315: -- First, this class is entirely bogus the way I see it.

[jira] [Commented] (SOLR-6315) Remove SimpleOrderedMap

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084077#comment-14084077 ] Shai Erera commented on SOLR-6315: -- [~yo...@apache.org], please excuse me if I used the

[jira] [Commented] (SOLR-6315) Remove SimpleOrderedMap

2014-08-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084111#comment-14084111 ] Shai Erera commented on SOLR-6315: -- Thanks Yonik for explaining this. I realized as I

[jira] [Commented] (LUCENE-5850) Constants#LUCENE_MAIN_VERSION can have broken values

2014-08-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083636#comment-14083636 ] Shai Erera commented on LUCENE-5850: Thanks Uwe for adding the docs, they are crystal

[jira] [Commented] (LUCENE-5859) Remove Version.java completely

2014-07-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080762#comment-14080762 ] Shai Erera commented on LUCENE-5859: I don't think that we need to add any

[jira] [Commented] (LUCENE-5859) Remove Version.java completely

2014-07-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080799#comment-14080799 ] Shai Erera commented on LUCENE-5859: You don't build an index for a specific version.

[jira] [Commented] (LUCENE-5850) Constants#LUCENE_MAIN_VERSION can have broken values

2014-07-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081294#comment-14081294 ] Shai Erera commented on LUCENE-5850: Thanks for fixing this bug Rob ... sorry is

[jira] [Commented] (LUCENE-5859) add no-Version parameter to Analyzers/QueryParser

2014-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079237#comment-14079237 ] Shai Erera commented on LUCENE-5859: What about the proposal that at some point

[jira] [Commented] (LUCENE-5859) add no-Version parameter to Analyzers/QueryParser

2014-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079265#comment-14079265 ] Shai Erera commented on LUCENE-5859: The thing that worries me is that if you upgrade

[jira] [Commented] (LUCENE-5859) Remove Version.java completely

2014-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079282#comment-14079282 ] Shai Erera commented on LUCENE-5859: bq. I tried to be reasonable here and open an

[jira] [Commented] (LUCENE-5859) Remove Version.java completely

2014-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080517#comment-14080517 ] Shai Erera commented on LUCENE-5859: The way I see it, Rob's commit is exactly what

[jira] [Resolved] (LUCENE-5852) Log state in IndexReplicatorHandler exception handler

2014-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5852. Resolution: Fixed Fix Version/s: 4.10 5.0 Assignee: Shai Erera

[jira] [Commented] (LUCENE-5843) IndexWriter should refuse to create an index with more than INT_MAX docs

2014-07-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074546#comment-14074546 ] Shai Erera commented on LUCENE-5843: {quote} I added public static final int

[jira] [Commented] (LUCENE-5843) IndexWriter should refuse to create an index with more than INT_MAX docs

2014-07-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074554#comment-14074554 ] Shai Erera commented on LUCENE-5843: Yes, I think we shouldn't try to be too smart

[jira] [Commented] (LUCENE-5843) IndexWriter should refuse to create an index with more than INT_MAX docs

2014-07-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074575#comment-14074575 ] Shai Erera commented on LUCENE-5843: oh good, I didn't read the patch before, but I

[jira] [Commented] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068279#comment-14068279 ] Shai Erera commented on LUCENE-5801: Committed the fix. Resurrect

[jira] [Updated] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5801: --- Attachment: LUCENE-5801.patch Patch fixes the problem. We need to take the source FacetsConfig in

[jira] [Commented] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067905#comment-14067905 ] Shai Erera commented on LUCENE-5801: Committed this fix. Please report if you still

[jira] [Commented] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067946#comment-14067946 ] Shai Erera commented on LUCENE-5801: Actually, this isn't the correct fix. I modified

[jira] [Updated] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5801: --- Attachment: LUCENE-5801.patch Patch fixes the problem, but I still want to review the test, make

[jira] [Assigned] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera reassigned LUCENE-5801: -- Assignee: Shai Erera Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

[jira] [Updated] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5801: --- Attachment: LUCENE-5801.patch Thanks Nicola. I updated the patch with a CHANGES entry. Also, I

[jira] [Resolved] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5801. Resolution: Fixed Fix Version/s: 4.10 5.0 Lucene Fields: New,Patch

[jira] [Commented] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049928#comment-14049928 ] Shai Erera commented on LUCENE-5801: I will review the patch later, but a static

[jira] [Comment Edited] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049928#comment-14049928 ] Shai Erera edited comment on LUCENE-5801 at 7/2/14 1:54 PM: I

[jira] [Commented] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049952#comment-14049952 ] Shai Erera commented on LUCENE-5801: FacetsConfig.dedupAndEncode is the encode

[jira] [Commented] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050529#comment-14050529 ] Shai Erera commented on LUCENE-5801: Hmm, I thought about it, maybe we don't need the

[jira] [Updated] (LUCENE-4258) Incremental Field Updates through Stacked Segments

2014-07-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-4258: --- Fix Version/s: (was: 4.9) (was: 5.0) Incremental Field Updates through

[jira] [Commented] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader

2014-07-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048831#comment-14048831 ] Shai Erera commented on LUCENE-5801: Thanks for opening this, we definitely need to

[jira] [Resolved] (LUCENE-5772) SortingAtomicReader should implement getSortedNumericDocValues

2014-06-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5772. Resolution: Fixed Fix Version/s: 5.0 4.9 Assignee: Shai Erera

[jira] [Updated] (LUCENE-5772) SortingAtomicReader should implement getSortedNumericDocValues

2014-06-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5772: --- Fix Version/s: 4.10 SortingAtomicReader should implement getSortedNumericDocValues

[jira] [Created] (LUCENE-5772) SortingAtomicReader should implement getSortedNumericDocValues

2014-06-17 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5772: -- Summary: SortingAtomicReader should implement getSortedNumericDocValues Key: LUCENE-5772 URL: https://issues.apache.org/jira/browse/LUCENE-5772 Project: Lucene - Core

[jira] [Updated] (LUCENE-5772) SortingAtomicReader should implement getSortedNumericDocValues

2014-06-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5772: --- Attachment: LUCENE-5772.patch Fixed SortingAtomicReader and added relevant test.

[jira] [Commented] (LUCENE-5772) SortingAtomicReader should implement getSortedNumericDocValues

2014-06-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034131#comment-14034131 ] Shai Erera commented on LUCENE-5772: Thanks Rob. I know you're working on 4.9 release

[jira] [Updated] (LUCENE-5772) SortingAtomicReader should implement getSortedNumericDocValues

2014-06-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5772: --- Attachment: LUCENE-5772.patch Fixed silly test bug. SortingAtomicReader should implement

[jira] [Commented] (LUCENE-5102) move DocIdBitSet from lucene-core to lucene-test-framework

2014-06-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032260#comment-14032260 ] Shai Erera commented on LUCENE-5102: I think we should remove it, but deprecate in

[jira] [Commented] (LUCENE-5762) Disable old codecs as much as possible

2014-06-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032264#comment-14032264 ] Shai Erera commented on LUCENE-5762: +1 Disable old codecs as much as possible

[jira] [Commented] (LUCENE-5748) SORTED_NUMERIC dv type

2014-06-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028884#comment-14028884 ] Shai Erera commented on LUCENE-5748: Reviewed the patch, looks good. Maybe add a

[jira] [Commented] (LUCENE-5748) SORTED_NUMERIC dv type

2014-06-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029011#comment-14029011 ] Shai Erera commented on LUCENE-5748: As I said, +1 to commit anyway. I like

[jira] [Commented] (LUCENE-5688) NumericDocValues fields with sparse data can be compressed better

2014-06-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014922#comment-14014922 ] Shai Erera commented on LUCENE-5688: Ahh, I see now that you only wrote a DVFormat,

[jira] [Commented] (LUCENE-5688) NumericDocValues fields with sparse data can be compressed better

2014-05-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012177#comment-14012177 ] Shai Erera commented on LUCENE-5688: bq. It does a binary search on the position data

[jira] [Resolved] (LUCENE-5680) Allow updating multiple DocValues fields atomically

2014-05-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5680. Resolution: Fixed Fix Version/s: 5.0 4.9 Committed to trunk and 4x.

[jira] [Updated] (LUCENE-5680) Allow updating multiple DocValues fields atomically

2014-05-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5680: --- Attachment: LUCENE-5680.patch Patch ports all tests to use the atomic updates. This removed the

[jira] [Commented] (LUCENE-5711) Pass IW to MergePolicy

2014-05-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14011098#comment-14011098 ] Shai Erera commented on LUCENE-5711: Note that this was changed in LUCENE-1763. At

[jira] [Commented] (LUCENE-5680) Allow updating multiple DocValues fields atomically

2014-05-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012065#comment-14012065 ] Shai Erera commented on LUCENE-5680: I think it's ready so if there are no objections

[jira] [Commented] (LUCENE-5708) Remove IndexWriterConfig.clone

2014-05-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009722#comment-14009722 ] Shai Erera commented on LUCENE-5708: I think the way you fixed some tests that used

[jira] [Commented] (LUCENE-5708) Remove IndexWriterConfig.clone

2014-05-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009988#comment-14009988 ] Shai Erera commented on LUCENE-5708: bq. Hmm which tests rely on using the same IWC?

[jira] [Comment Edited] (LUCENE-5708) Remove IndexWriterConfig.clone

2014-05-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009988#comment-14009988 ] Shai Erera edited comment on LUCENE-5708 at 5/27/14 5:56 PM: -

[jira] [Resolved] (LUCENE-5706) Don't allow unsetting values through DocValues updates

2014-05-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5706. Resolution: Fixed Fix Version/s: 5.0 4.9 Committed to trunk and 4x.

[jira] [Comment Edited] (LUCENE-5705) ConcurrentMergeScheduler/maxMergeCount default is too low

2014-05-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008282#comment-14008282 ] Shai Erera edited comment on LUCENE-5705 at 5/25/14 6:07 AM: -

[jira] [Created] (LUCENE-5706) Don't allow unsetting values through DocValues updates

2014-05-25 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5706: -- Summary: Don't allow unsetting values through DocValues updates Key: LUCENE-5706 URL: https://issues.apache.org/jira/browse/LUCENE-5706 Project: Lucene - Core

[jira] [Commented] (LUCENE-5680) Allow updating multiple DocValues fields atomically

2014-05-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008386#comment-14008386 ] Shai Erera commented on LUCENE-5680: Opened LUCENE-5706 to disallow unsetting values.

[jira] [Commented] (LUCENE-5705) ConcurrentMergeScheduler/maxMergeCount default is too low

2014-05-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008387#comment-14008387 ] Shai Erera commented on LUCENE-5705: Orthogonal to this issue, but it sounds like

[jira] [Commented] (LUCENE-5706) Don't allow unsetting values through DocValues updates

2014-05-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008391#comment-14008391 ] Shai Erera commented on LUCENE-5706: Why is that impossible? Solr can still update

[jira] [Commented] (LUCENE-5706) Don't allow unsetting values through DocValues updates

2014-05-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008394#comment-14008394 ] Shai Erera commented on LUCENE-5706: I checked the patch on SOLR-5944 and I only see

[jira] [Commented] (LUCENE-5705) ConcurrentMergeScheduler/maxMergeCount default is too low

2014-05-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008396#comment-14008396 ] Shai Erera commented on LUCENE-5705: It depends what would you like to achieve. If

[jira] [Updated] (LUCENE-5706) Don't allow unsetting values through DocValues updates

2014-05-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5706: --- Attachment: LUCENE-5706.patch Patch removes this capability. It simplified a lot of the internal

[jira] [Commented] (LUCENE-5705) ConcurrentMergeScheduler/maxMergeCount default is too low

2014-05-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008282#comment-14008282 ] Shai Erera commented on LUCENE-5705: +1 to not change the default in CMS, and commit

[jira] [Commented] (LUCENE-5683) Improve SegmentReader.getXXXDocValues

2014-05-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007040#comment-14007040 ] Shai Erera commented on LUCENE-5683: It's not ridiculous :). But +1 to commit.

[jira] [Commented] (LUCENE-5680) Allow updating multiple DocValues fields atomically

2014-05-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007150#comment-14007150 ] Shai Erera commented on LUCENE-5680: bq. why do we have both MISSING and

[jira] [Commented] (LUCENE-5683) Improve SegmentReader.getXXXDocValues

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005729#comment-14005729 ] Shai Erera commented on LUCENE-5683: I've thought about it more ... I really don't

[jira] [Resolved] (LUCENE-5683) Improve SegmentReader.getXXXDocValues

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5683. Resolution: Won't Fix Improve SegmentReader.getXXXDocValues

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005735#comment-14005735 ] Shai Erera commented on LUCENE-5693: So the question is, if we think the common case

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005754#comment-14005754 ] Shai Erera commented on LUCENE-5693: I don't see what's wrong w/ not sending the

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005795#comment-14005795 ] Shai Erera commented on LUCENE-5693: Hmm, I reviewed SortedDVWriter and I understand

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005837#comment-14005837 ] Shai Erera commented on LUCENE-5693: bq. But I'll resolve this as WONTFIX ... looks

[jira] [Commented] (LUCENE-5683) Improve SegmentReader.getXXXDocValues

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006759#comment-14006759 ] Shai Erera commented on LUCENE-5683: You replaced a hash lookup by an instanceof

[jira] [Commented] (LUCENE-5689) FieldInfo.setDocValuesGen should not be public.

2014-05-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004557#comment-14004557 ] Shai Erera commented on LUCENE-5689: ReaderAndUpdates already clones all FIs and then

[jira] [Commented] (LUCENE-5679) Consolidate IndexWriter.deleteDocuments()

2014-05-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004560#comment-14004560 ] Shai Erera commented on LUCENE-5679: I'm not sure how critical it is Uwe. Yes, it

[jira] [Resolved] (LUCENE-5618) DocValues updates send wrong fieldinfos to codec producers

2014-05-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5618. Resolution: Fixed Lucene Fields: New,Patch Available (was: New) Committed to trunk and

[jira] [Resolved] (LUCENE-5636) SegmentCommitInfo continues to list unneeded gen'd files

2014-05-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5636. Resolution: Fixed Fix Version/s: 5.0 4.9 Fixed in LUCENE-5618

[jira] [Commented] (LUCENE-5683) Improve SegmentReader.getXXXDocValues

2014-05-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004742#comment-14004742 ] Shai Erera commented on LUCENE-5683: I implemented it, many tests fail in CheckIndex

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004835#comment-14004835 ] Shai Erera commented on LUCENE-5693: Today we apply the deletes (update the bitset)

[jira] [Commented] (LUCENE-5680) Allow updating multiple DocValues fields atomically

2014-05-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002928#comment-14002928 ] Shai Erera commented on LUCENE-5680: Well, first updateNumeric/BinaryDV() allows you

[jira] [Comment Edited] (LUCENE-5680) Allow updating multiple DocValues fields atomically

2014-05-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002928#comment-14002928 ] Shai Erera edited comment on LUCENE-5680 at 5/20/14 8:32 AM: -

[jira] [Updated] (LUCENE-5679) Consolidate IndexWriter.deleteDocuments()

2014-05-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5679: --- Attachment: LUCENE-5679.patch Patch removes the single-arg delDocs Term/Query variants. Everything

<    1   2   3   4   5   6   7   8   9   10   >