Re: Apache SOLR Issue

Is the query to Neo4j correct? Do you have all attributes in the Solr schema defined? I think it would be useful if you can share more information. How is the import done? Does it work with simple queries ? How do you transform the data for the target schem? > Am 15.12.2019 um 19:32 schrieb

Apache SOLR Issue

Hi Team, As part of SOLR implementation we have started encountering below issue and would request any guidelines/ideas which could help us resolve the issue. * Current implementation Version 7.5.0 Steps Performed * Imported data from Neo4j to SOLR. Error Message

Re: Writing Unit test for SOLR Issue

Absolutely; there are plenty of PR based contributions. Just reference the exact issue in the PR title, e.g. SOLR-13331 ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Fri, May 3, 2019 at 4:18 AM Thomas Wöckinger wrote: > Now that all apache

Re: Writing Unit test for SOLR Issue

Now that all apache repos are moved to github, is it possible to do a pull request? I dont wan't to crunch all changes into one commit. Best, Tom On Thu, May 2, 2019 at 3:48 PM Thomas Wöckinger wrote: > In the middle of writing a test base, i realized that the > SolrJettyTestBase is using an

Re: Writing Unit test for SOLR Issue

In the middle of writing a test base, i realized that the SolrJettyTestBase is using an EmbeddedSolrServer as its fallback. So two questions: 1.: Should i introduce a new EmbeddedSolrServerTestBase to clarify which implementations is used behind the scenes? 2.: I think it is a good idea two

Re: Writing Unit test for SOLR Issue

Ok, thx for your fast response, i will start now, hope to be finished in two days. Best, Tom On Thu, May 2, 2019 at 12:59 PM Jason Gerlowski wrote: > Hi Thomas, > > No need to open a new issue. I added a few tests when I committed a > fix on SOLR-13331 a few weeks back. I backported this

Re: Writing Unit test for SOLR Issue

Hi Thomas, No need to open a new issue. I added a few tests when I committed a fix on SOLR-13331 a few weeks back. I backported this change and it should be fixed in 7.7.2 when that is released. The project could always use additional tests though, so if you want to add an EmbeddedSolrServer

Re: Writing Unit test for SOLR Issue

As i already commented on the issue SOLR-13331 , i am starting writing test on this issue using EmbbededSolrServer, i didn't had time the last few weeks, should i open a new issue for this? I think backporting this to 7.x is also a good idea! On

Re: Writing Unit test for SOLR Issue

I'm only passingly familiar with EmbeddedSolrServer. But if you can reproduce the problem using EmbeddedSolrServer, then that'd be a great place to start for a test. If you aren't able to reproduce the problem with EmbeddedSolrServer though, you'll probably need to use HttpSolrClient and one of

Re: Writing Unit test for SOLR Issue

I know SolrJ pretty well, so should i write the against EmbeddedSolrServer, or is there a different base class for such tests? On Tue, Mar 26, 2019 at 2:55 PM Jason Gerlowski wrote: > Hi Thomas, > > I see what you mean; the utilities used by that test as-is rely on > XML. If you want to send

Re: Writing Unit test for SOLR Issue

Hi Thomas, I see what you mean; the utilities used by that test as-is rely on XML. If you want to send the atomic-update via Javabin, the best option is probably to write a small testcase using SolrJ. Javabin is the default wire format in SolrJ, so it should do what you want. If you haven't

Re: Writing Unit test for SOLR Issue

Following problem: TestHarness is using XMLLoader to test the whole test case, so it is not possible to test with ByteArrayUtf8CharSequence because it will be converted to String before. Can you guide me to create a TestHarness for which is using JavaBinCodec. Thx Tom On Mon, Mar 25, 2019 at

Re: Writing Unit test for SOLR Issue

I think the class is the right one, but i am not sure if it is enough to test the issue just by using ByteArrayUtf8CharSequence as value for the updates. On Mon, Mar 25, 2019 at 8:42 PM Erick Erickson wrote: > Take a look at >

Re: Writing Unit test for SOLR Issue

Ok, thx! How is the review done? Currently nobody is assigned to the issue. On Mon, Mar 25, 2019 at 8:42 PM Erick Erickson wrote: > Take a look at > …/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesTest.java > > If you don’t want to add tests to that class, that’ll be

Re: Writing Unit test for SOLR Issue

Take a look at …/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesTest.java If you don’t want to add tests to that class, that’ll be (roughly) the place you’d add a new test class. Best, Erick > On Mar 25, 2019, at 9:54 AM, Thomas Wöckinger > wrote: > > Hi! > > I submitted

Writing Unit test for SOLR Issue

Hi! I submitted a patch for a solr bug https://issues.apache.org/jira/browse/SOLR-13331, i also want to add unit test for that issue. May someone can give me an advice where to add these unit test, because a simple test can be made easy but i think there should be also some integration tests,

[GitHub] lucene-solr issue #531: SOLR-12768

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/531 Code changes seem good; I'll look closer and run tests. PathHierarchyTokenizerFactory _might_ eventually be used at query time if we had a syntax to say "get me all my ancestors". But

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/528 > postProcessDeleteByQuery can be renamed to doDistribDeleteByQuery, and postProcessDeleteById can be renamed doDistribDeleteById. I pushed a commit with these requested changes.

[GitHub] lucene-solr issue #531: SOLR-12768

Github user moshebla commented on the issue: https://github.com/apache/lucene-solr/pull/531 Alright? I'm confused since I thought PathHierarchyTokenizerFactory is the agreed upon method of querying paths. Perhaps it might not cut it for this feature though? In any case,

[GitHub] lucene-solr issue #531: SOLR-12768

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/531 Nonetheless we could stop trying to solve this ambiguous case further _for now_ (thus commit what you have here) since (a) this syntax is very experimental (b) it's documented nowhere (c) and

[GitHub] lucene-solr issue #531: SOLR-12768

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/531 > Perhaps we could test whether "foo" is a defined field in the current collection? Eh; that sounds too much like a "guess what the user might mean" kind of solution. Even if "foo" is

[GitHub] lucene-solr issue #531: SOLR-12768

Github user moshebla commented on the issue: https://github.com/apache/lucene-solr/pull/531 Perhaps we could test whether "foo" is a defined field in the current collection? I'll try and test this on Sunday as I have got to go. I personally prefer keeping the API as simple as

[GitHub] lucene-solr issue #531: SOLR-12768

Github user moshebla commented on the issue: https://github.com/apache/lucene-solr/pull/531 > I wonder... hmmm... maybe the nest path should always start with a '/'? It would seem more correct since paths in general usually start with one, and it would also make implementing this

[GitHub] lucene-solr issue #305: SOLR-11853: Make check for used tool "service" compa...

Github user Mandalka commented on the issue: https://github.com/apache/lucene-solr/pull/305 This PR was solved by https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a1c6e64 so rest like missing group solr and rights of /etc/default/$SOLR_SERVICE.in.sh and setting Solr users

[GitHub] lucene-solr issue #305: SOLR-11853: Make check for used tool "service" compa...

Github user Mandalka commented on the issue: https://github.com/apache/lucene-solr/pull/305 For future OpenSuSE releases the main issue / need of patch (rest of failing steps can be done after installation by adding group and rights) is solved by

[GitHub] lucene-solr issue #531: SOLR-12768

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/531 The way this field is indexed has been experimental and will remain so for a bit. 8.0 will be it's more public debut, after which changing it will be more effort than today. Nonetheless I

[GitHub] lucene-solr issue #531: SOLR-12768

Github user moshebla commented on the issue: https://github.com/apache/lucene-solr/pull/531 I'll add another test-case then. > I wonder... hmmm... maybe the nest path should always start with a '/'? It would seem more correct since paths in general usually start with one, and

[GitHub] lucene-solr issue #531: SOLR-12768

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/531 Looks good. I thought you were going to test with something to show we don't screw it up? You could search for 'redients' which would have returned something before but now should not.

[GitHub] lucene-solr issue #531: SOLR-12768

Github user moshebla commented on the issue: https://github.com/apache/lucene-solr/pull/531 > I think a solution is to build an OR query where one clause has a */ prepended to it, and the other has nothing modified and so matches the term exactly. WDYT? Yes that seems

[GitHub] lucene-solr issue #531: SOLR-12768

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/531 Thanks for helping out! It's insufficient to simply prepend a `*` since it would match other labels that share the same suffix. For example: `childFilter='ingredients/name\_s:cocoa'` would

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/528 Man this is a tangled mess we are trying to unravel! I wish someone undertook this years ago. Lets not rename DUP#processDelete as it is an URP defined method we override, and I doubt

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/528 > It'd be excellent if we could get some consistency of calling setupRequest -- all processXXX methods should first call setupRequest and if needed an overloaded variant. Perhaps

[GitHub] lucene-solr issue #530: Branch 7 4 : IndexOutOfBoundsException randomly appe...

Github user IntraCherche commented on the issue: https://github.com/apache/lucene-solr/pull/530 Closed the PR since it looks more appropriate to post this on the user mailing list. --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/528 I like that the zk version of processCommit completely overrides the superclass since the logic is much more complicated. But it's a little unfortunate to call super.processCommit which will

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/528 * DUP.next can be removed as it's redundant with the same in the superclass * DUP.MAX_RETRIES_TO_FOLLOWERS_DEFAULT you accidentally added an 'R' to the ** of the javadoc. * DUP.isLeader

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/528 * DUP.postProcessAdd's javadoc is confusing; maybe drop it. It says "This method can be overridden to tamper with the cmd" but I'm looking at where we override it and I don't see any tampering

[GitHub] lucene-solr issue #525: LUCENE-8585: Index-time jump-tables for DocValues

Github user jpountz commented on the issue: https://github.com/apache/lucene-solr/pull/525 I forgot to mention: precommit complains about unused imports. --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #458: SOLR-12799: Allow Authentication Plugins to intercep...

Github user bbl232 commented on the issue: https://github.com/apache/lucene-solr/pull/458 @janhoy yeah we're planning on using the BasicAuthPlugin... this seems like a fairly large flaw unless we're just misconfiguring solr cloud somehow? IDK if there is a way to make the node

[jira] [Resolved] (SOLR-13084) SOLR Issue - No registered leader was found after waiting for 4000ms

, and that issue was resolved as Invalid since this question really needs to be brought up in the solr-user mailing list to determine if there is a bug. Please review that prior issue, it has the information for how to subscribe to the mailing list. > SOLR Issue - No registered leader was found af

[jira] [Created] (SOLR-13084) SOLR Issue - No registered leader was found after waiting for 4000ms

EL ABDELLAOUI created SOLR-13084: Summary: SOLR Issue - No registered leader was found after waiting for 4000ms Key: SOLR-13084 URL: https://issues.apache.org/jira/browse/SOLR-13084 Project: Solr

[GitHub] lucene-solr issue #458: SOLR-12799: Allow Authentication Plugins to intercep...

Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/458 @bbl232 If you're using BasicAuthPlugin then, yes, this feature may help you. Feel free to build 8.0.0-SNAPSHOT and test. Backporting should be easy. ---

[GitHub] lucene-solr issue #458: SOLR-12799: Allow Authentication Plugins to intercep...

Github user bbl232 commented on the issue: https://github.com/apache/lucene-solr/pull/458 It would be fantastic to have this backported to 7.6... We've got an issue trying to spin up a multitenant solr instance where if your request hits a solr instance without a shard (or replica)

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/528 Oh yes, I still have a few Todo's I added that I'd like to tackle. I won't have time for more today, Hopefully I'll be able to get these done by the end of the week. ---

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/528 Looks good. More to do? --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/528 addressed comments about previous PR and re-based on latest master --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #528: SOLR-12955 2

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/528 Tackling this again, according to @dsmiley's input: > I'm not sure if the "base" functionality needed to be in a new class... I could imagine simply adding subclasses and

[GitHub] lucene-solr issue #519: WIP: SOLR-12955: rebase and split changes to smaller...

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/519 created a [new PR](https://github.com/apache/lucene-solr/pull/528) --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #527: LUCENE-8609: Allow getting consistent docstats from ...

Github user mikemccand commented on the issue: https://github.com/apache/lucene-solr/pull/527 LGTM --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #526: LUCENE-8608: Extract utility class to iterate over t...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/526 @mikemccand I pushed changes. I think it's ready --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For

[GitHub] lucene-solr issue #519: WIP: SOLR-12955: rebase and split changes to smaller...

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/519 I've continued hacking on this issue last night, and have been facing some issues concerning the base class. I agree, I'll stash the changes and try tackling this again. I also

[GitHub] lucene-solr issue #519: WIP: SOLR-12955: rebase and split changes to smaller...

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/519 I'm not sure if the "base" functionality needed to be in a new class... I could imagine simply adding subclasses and leave DUP named as it is with it's base functionality. WDYT? It may help

[GitHub] lucene-solr issue #522: LUCENE-8599: Use sparse bitset to store docs in Sing...

Github user jpountz commented on the issue: https://github.com/apache/lucene-solr/pull/522 Sure! --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #522: LUCENE-8599: Use sparse bitset to store docs in Sing...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/522 @jpountz I will get this in as is and then explore what we can do as a followup with DocIdSetBuilder. We do need additional stats to make efficient use of it IMO and this already yields a

[GitHub] lucene-solr issue #522: LUCENE-8599: Use sparse bitset to store docs in Sing...

Github user jpountz commented on the issue: https://github.com/apache/lucene-solr/pull/522 For the record, DocIdSetBuilder needs to sort as well if the number of collected docs is low, but it does it with a pretty fast radix sort. ---

[GitHub] lucene-solr issue #521: LUCENE-8598: Improve field updates packed values

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/521 > t's interesting that you found out that most of the time is spent with packed ints when sorting, likely because of swaps: the sorting impl that is being used (InPlaceMergeSorter) is the impl

[GitHub] lucene-solr issue #519: WIP: SOLR-12955: rebase and split changes to smaller...

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/519 good start --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #489: SOLR-12955: separate DistribUpdateProcessor to Zk an...

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/489 There is no "development" branch, so I don't know what you mean by that. You don't _have_ to run the full test suite after each commit, but _ideally_ it ought to pass on each commit if it were

[GitHub] lucene-solr issue #489: SOLR-12955: separate DistribUpdateProcessor to Zk an...

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/489 @dsmiley, would you want this to be separated to different commits on the development branch, so you can view each one and review them separately, or would you like to commit each one to

[GitHub] lucene-solr issue #489: SOLR-12955: separate DistribUpdateProcessor to Zk an...

Github user barrotsteindev commented on the issue: https://github.com/apache/lucene-solr/pull/489 I will rebase this PR on the latest master. It is going to be quite hard to separate this into smaller changes, since I tried not to change the core logic where possible, and instead

[GitHub] lucene-solr issue #514: LUCENE-8591: add LegacyBM25Similarity#getDiscountOve...

Github user javanna commented on the issue: https://github.com/apache/lucene-solr/pull/514 This has been merged. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #482: LUCENE-8539: fix some typos and improve style in Tes...

Github user mikemccand commented on the issue: https://github.com/apache/lucene-solr/pull/482 Great, thanks @diegoceccarelli -- I will merge soon! --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For

[GitHub] lucene-solr issue #516: LUCENE-8594: DV update are broken for updates on new...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/516 @jpountz I pushed changes --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #516: LUCENE-8594: DV update are broken for updates on new...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/516 this was found in https://github.com/elastic/elasticsearch/pull/36286 --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #513: LUCENE-8590: Optimize DocValues update datastructure...

Github user shaie commented on the issue: https://github.com/apache/lucene-solr/pull/513 > Wow, that's a massive reduction! Indeed! Well done @s1monw! --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #513: LUCENE-8590: Optimize DocValues update datastructure...

Github user mikemccand commented on the issue: https://github.com/apache/lucene-solr/pull/513 Wow, that's a massive reduction! --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands,

[GitHub] lucene-solr issue #513: LUCENE-8590: Optimize DocValues update datastructure...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/513 > Any sense of how much of RAM reduction this is over current impl? I ran a very simple measurement on top of `BufferedUpdates` adding 10k random updates with a constant seed. Here are the

[GitHub] lucene-solr issue #513: LUCENE-8590: Optimize DocValues update datastructure...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/513 @mikemccand can you take a look? --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands,

[GitHub] lucene-solr issue #509: [SOLR-13019] Fix typo in MailEntityProcessor.java

Github user gerlowskija commented on the issue: https://github.com/apache/lucene-solr/pull/509 Thanks Tommy; merged to master. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands,

[GitHub] lucene-solr issue #505: LUCENE-8548: Reevaluate scripts boundary break in No...

Github user cbismuth commented on the issue: https://github.com/apache/lucene-solr/pull/505 Obsolete, see [643ffc6](https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=643ffc6). --- - To unsubscribe,

[GitHub] lucene-solr issue #511: LUCENE-8563: Remove k1+1 from the numerator of BM25S...

Github user javanna commented on the issue: https://github.com/apache/lucene-solr/pull/511 Merged. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #455: SOLR-12638

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/455 What does "so _root_ is not hard-coded into childless documents" mean? If you think SOLR-5211 is missing something, can you please post a patch file to the issue and explain what you're

[GitHub] lucene-solr issue #455: SOLR-12638

Github user moshebla commented on the issue: https://github.com/apache/lucene-solr/pull/455 I rebased using the latest master. I also changed the tests so _root_ is not hard-coded into childless documents, since SOLR-5211 was committed to master and ensures this behaviour. ---

[GitHub] lucene-solr issue #510: LUCENE-8573: Use FutureArrays#mismatch in BKDWriter

Github user uschindler commented on the issue: https://github.com/apache/lucene-solr/pull/510 Perfect. So it's even more performant with Java 9+. Thanks, Christian --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #510: LUCENE-8573: Use FutureArrays#mismatch in BKDWriter

Github user jpountz commented on the issue: https://github.com/apache/lucene-solr/pull/510 Thanks @cbuescher, the change looks good. I'll merge it provided tests pass. --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #482: LUCENE-8539: fix some typos and improve style in Tes...

Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/482 Thanks @mikemccand, now precommit seems happy, I squashed and rebased to the latest master. --- - To unsubscribe,

[GitHub] lucene-solr issue #504: SOLR-13008 First cut of indenting JSON formatted fie...

Github user epugh commented on the issue: https://github.com/apache/lucene-solr/pull/504 I added some nicer indenting. For a JSON block like: ```json { "am I a teapot":true, "lyrics":[ "I'm a little teapot","Short and stout","Here is my handle","Here is my spout"

[GitHub] lucene-solr issue #482: LUCENE-8539: fix some typos and improve style in Tes...

Github user mikemccand commented on the issue: https://github.com/apache/lucene-solr/pull/482 Hmm `and precommit` is a little angry: ``` [forbidden-apis] Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale]

[GitHub] lucene-solr issue #482: LUCENE-8539: fix some typos and improve style in Tes...

Github user mikemccand commented on the issue: https://github.com/apache/lucene-solr/pull/482 @diegoceccarelli this looks great -- I'll merge soon. Thanks! --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #503: LUCENE-8571: Don't block on FrozenBufferedUpdates#ap...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/503 @msokolov I measures a pretty signficant lock contention on this lock without my change. with the change it went down significantly. Refreshes got 30% faster for that benchmark (small docs with

[GitHub] lucene-solr issue #500: LUCENE-8517: do not wrap FixedShingleFilter with con...

Github user msokolov commented on the issue: https://github.com/apache/lucene-solr/pull/500 BTW - I built w/Java 8 and precommit / test are passing for me now. @romseygeek if you are planning to address the apparent graph-handling bug in FixedShingleFilter, I can remove the

[GitHub] lucene-solr issue #503: LUCENE-8571: Don't block on FrozenBufferedUpdates#ap...

Github user msokolov commented on the issue: https://github.com/apache/lucene-solr/pull/503 I'm curious if you were able to measure a good improvement from this? I guess a large delete concurrent with indexing lots of docs would stress it? ---

[GitHub] lucene-solr issue #482: LUCENE-8539: fix some typos and improve style in Tes...

Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/482 Thanks @mikemccand, I added a new test case by splitting one that was testing two different things :) I rebased to the latest master, Is anything else I can do to get this merged?

[GitHub] lucene-solr issue #504: SOLR-13008 First cut of indenting JSON formatted fie...

Github user epugh commented on the issue: https://github.com/apache/lucene-solr/pull/504 I've run "ant test" and while there are some failures, they don't appear to be related to this feature. I'm testing it now compiling and running Solr. ---

[GitHub] lucene-solr issue #494: ant compile error

Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/494 Sorry @cqvip-jq my comment was misleading, I think you are right and your patch should be merged.. --- - To

[GitHub] lucene-solr issue #494: ant compile error

Github user cqvip-jq commented on the issue: https://github.com/apache/lucene-solr/pull/494 > `maven.restlet.org` gets redirected to `maven.restlet.com`, LGTM Maybe it's my problem only, I use proxy in my network because of GFW. ---

[GitHub] lucene-solr issue #494: ant compile error

Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/494 `maven.restlet.org` gets redirected to `maven.restlet.com`, LGTM --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #503: LUCENE-8571: Don't block on FrozenBufferedUpdates#ap...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/503 pushed --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #494: ant compile error

Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/494 @cqvip-jq this looks like a problem on your side. Try to remove the `ivy2` cache by removing the `.ivy2/cache` folder in your home and then run `ant ivy-bootstrap` and `ant dist` from

[GitHub] lucene-solr issue #503: LUCENE-8571: Don't block on FrozenBufferedUpdates#ap...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/503 I recommend to look at the diff with `?w=1` -> https://github.com/apache/lucene-solr/pull/503/files?w=1 --- - To

[GitHub] lucene-solr issue #503: LUCENE-8571: Don't block on FrozenBufferedUpdates#ap...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/503 @mikemccand can you take a look --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands,

[GitHub] lucene-solr issue #502: LUCENE-8569: Never count soft-deletes if reader has ...

Github user s1monw commented on the issue: https://github.com/apache/lucene-solr/pull/502 @mikemccand can you take a look at this? --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional

[GitHub] lucene-solr issue #496: LUCENE-8463: Early-terminate queries sorted by SortF...

Github user cbismuth commented on the issue: https://github.com/apache/lucene-solr/pull/496 Great, thanks @jimczi :+1: --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail:

[GitHub] lucene-solr issue #496: LUCENE-8463: Early-terminate queries sorted by SortF...

Github user jimczi commented on the issue: https://github.com/apache/lucene-solr/pull/496 > should I close this PR Sure, the status is tracked in the jira [issue](https://issues.apache.org/jira/browse/LUCENE-8463) which is marked as resolved for 7.7 and 8.0 (master). ---

[GitHub] lucene-solr issue #496: LUCENE-8463: Early-terminate queries sorted by SortF...

Github user cbismuth commented on the issue: https://github.com/apache/lucene-solr/pull/496 I'm unsure how the contribution process should end here, should I close this PR? Thanks. --- - To unsubscribe, e-mail:

[GitHub] lucene-solr issue #501: SOLR-5211

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/501 Nice. Do we even need the test config / schema at all? If they don't add anything, we shouldn't have them. Also I see there is still some "Block" terminology added here we can avoid to

[GitHub] lucene-solr issue #501: SOLR-5211

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/501 Also please rename "block" terminology to "nested" where possible. --- - To unsubscribe, e-mail:

Re: [GitHub] lucene-solr issue #500: LUCENE-8517: do not wrap FixedShingleFilter with con...

Oh! got it - We run our tests and other release machinery etc against a single JDK, and it is currently Java 8. I will precommit with Java 8 then. Presumably at some future date JDK11 becomes the system of record? Historically how long have we waited after a new Java release before shifting over?

[GitHub] lucene-solr issue #500: LUCENE-8517: do not wrap FixedShingleFilter with con...

Github user uschindler commented on the issue: https://github.com/apache/lucene-solr/pull/500 Hi, Currently a Lucene release should be done with Java 8. Therefore all checks like precommit have to be done with Java 8, otherwise we can’t be sure that it really works with

[GitHub] lucene-solr issue #500: LUCENE-8517: do not wrap FixedShingleFilter with con...

Github user msokolov commented on the issue: https://github.com/apache/lucene-solr/pull/500 Ah, I see. I wonder if it would be a huge effort to support building with JDK11 at least? IMO one could skip 9 and 10 since even openjdk is not "supporting" them with bug fixes, right?

[GitHub] lucene-solr issue #500: LUCENE-8517: do not wrap FixedShingleFilter with con...

Github user uschindler commented on the issue: https://github.com/apache/lucene-solr/pull/500 It's only supported with Java 8, because that's our intended release version. --- - To unsubscribe, e-mail:

  1   2   3   4   5   6   >