Re: Code Reviews

+1 I'm comfortable with that. And I don't think this rule should apply to Solr alone; it should apply to Lucene as well, even though a greater percentage of issues there get reviews. I think we all appreciate the value of code reviews -- no convincing of that needed. The challenge this will

[JENKINS] Lucene-Solr-SmokeRelease-master - Build # 966 - Still Failing

Build: https://builds.apache.org/job/Lucene-Solr-SmokeRelease-master/966/ No tests ran. Build Log: [...truncated 28738 lines...] prepare-release-no-sign: [mkdir] Created dir: /x1/jenkins/jenkins-slave/workspace/Lucene-Solr-SmokeRelease-master/lucene/build/smokeTestRelease/dist [copy]

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380775#comment-16380775 ] Allen Wittenauer commented on SOLR-10912: - Github PR support is sort of there. test-patch does.

Re: BinaryDocValues prefix bytes

This is how Elasticsearch encodes binary values. The first value a vint containing the number of values for the field. In Lucene, binary doc values do not have a concept of "multi valued"; the data is opaque. On Wed, Feb 28, 2018 at 8:25 AM Dominik Safaric wrote: > No

[JENKINS] Lucene-Solr-master-Windows (64bit/jdk1.8.0_144) - Build # 7198 - Still Unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Windows/7198/ Java: 64bit/jdk1.8.0_144 -XX:+UseCompressedOops -XX:+UseParallelGC 10 tests failed. FAILED: junit.framework.TestSuite.org.apache.lucene.index.TestIndexWriterOutOfFileDescriptors Error Message: Could not remove the

[JENKINS] Lucene-Solr-7.x-Linux (64bit/jdk-9.0.4) - Build # 1448 - Still Failing!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Linux/1448/ Java: 64bit/jdk-9.0.4 -XX:+UseCompressedOops -XX:+UseParallelGC No tests ran. Build Log: [...truncated 56022 lines...] [repro] Jenkins log URL: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Linux/1448/consoleText [repro]

Re: Code Reviews

On 2/28/2018 10:59 AM, Tomas Fernandez Lobbe wrote: > In an effort to improve code quality, I’d like to suggest that we > start requiring code review to non-trivial patches. Not sure if/how > other open source projects are doing code reviews, but I’ve been using > it in internal projects for many

[jira] [Commented] (SOLR-11407) AutoscalingHistoryHandlerTest fails frequently

[ https://issues.apache.org/jira/browse/SOLR-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381003#comment-16381003 ] ASF subversion and git services commented on SOLR-11407: Commit

Re: Code Reviews

I agree that code reviews would be a good idea. But to require code reviews before committing would be a big change in practice for the Solr committers. I'm not sure how the commit, then review policy was put in place or what it would mean to change that. Also I would probably personally vote

Re: Code Reviews

> To add to it, I think we should also wait before merging things to the stable branch and commit only to master in case of non-trivial patches. Maybe sometimes; a judgement call. It can draw out how long it takes for issues to get to completion; making it easier to forget that an issue isn't

[GitHub] lucene-solr issue #302: LUCENE-8126: Spatial prefix tree based on S2 geometr...

Github user dsmiley commented on the issue: https://github.com/apache/lucene-solr/pull/302 BTW when you're finally ready to merge into master & 7.3 please add just one commit with all these changes; don't rebase or merge all these commits onto the ASF git repo. This will keep the

Re: Code Reviews

> I’d like to suggest that we start requiring code review to non-trivial > patches. Don't know if it has to be a strict, corporate-like rule... Most folks over here do get the gut feeling on what's non-trivial and requires a second pair of eyes. JIRA and patch reviews have been serving this

[jira] [Commented] (SOLR-12043) Add mlt.maxdfpct to Solr's documentation

[ https://issues.apache.org/jira/browse/SOLR-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380967#comment-16380967 ] Dawid Weiss commented on SOLR-12043: Thanks Cassandra! > Add mlt.maxdfpct to Solr's documentation >

[jira] [Commented] (SOLR-12043) Add mlt.maxdfpct to Solr's documentation

[ https://issues.apache.org/jira/browse/SOLR-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380964#comment-16380964 ] ASF subversion and git services commented on SOLR-12043: Commit

[jira] [Commented] (SOLR-12043) Add mlt.maxdfpct to Solr's documentation

[ https://issues.apache.org/jira/browse/SOLR-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380966#comment-16380966 ] ASF subversion and git services commented on SOLR-12043: Commit

Re: Code Reviews

I’m not sure how CTR was put in place either, but it was done 10+ years ago, when Solr had less than 1/10 of the committers it has now and who knows how many less production deployments/users. Now Solr is a completely different project than back then, and what was the correct process then may

Re: Code Reviews

Ok, so it's clear what you're proposing then. You want to change the CTR policy. That is indeed quite a big proposal. As I mentioned I'm personally for CTR, but it would be good to hear other peoples thoughts on this. Joel Bernstein http://joelsolr.blogspot.com/ On Wed, Feb 28, 2018 at 1:30 PM,

Re: Code Reviews

+1 to the idea of code review before committing non-trivial patches. I do however worry about the cases when someone asks for feedback but doesn’t hear from anyone for reasonably long durations. In such situations perhaps a week should be good enough time to ask for feedback and wait before

Re: Code Reviews

On Wed, Feb 28, 2018 at 1:58 PM, Shawn Heisey wrote: > > I notice in ZK issues that projects associated with Hadoop have an > *automatic* machine-generated QA check whenever a patch is submitted on > those projects. This obviously is not the same as a real review by a >

[JENKINS] Lucene-Solr-7.x-Solaris (64bit/jdk1.8.0) - Build # 466 - Still unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Solaris/466/ Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseSerialGC 2 tests failed. FAILED: junit.framework.TestSuite.org.apache.solr.cloud.TestSolrCloudWithSecureImpersonation Error Message: 2 threads leaked from SUITE scope at

[jira] [Updated] (SOLR-12043) Add mlt.maxdfpct to Solr's documentation

[ https://issues.apache.org/jira/browse/SOLR-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-12043: --- Fix Version/s: (was: master (8.0)) 7.3 > Add mlt.maxdfpct to Solr's

[jira] [Commented] (SOLR-11407) AutoscalingHistoryHandlerTest fails frequently

[ https://issues.apache.org/jira/browse/SOLR-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381001#comment-16381001 ] ASF subversion and git services commented on SOLR-11407: Commit

Release 6.6.3

I’d like to make a 6.6.3 release, primarily to backport SOLR-11503, which fixes a problem present in 6.6.1 and 6.6.2. I volunteer to manage the release. I’ll evaluate other Lucene and Solr bugfixes for inclusion, but if there’s an issue you’d particularly like to be included, please let me

[JENKINS-EA] Lucene-Solr-master-Linux (64bit/jdk-10-ea+43) - Build # 21555 - Still Unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/21555/ Java: 64bit/jdk-10-ea+43 -XX:+UseCompressedOops -XX:+UseG1GC 4 tests failed. FAILED: org.apache.solr.cloud.autoscaling.TriggerIntegrationTest.testNodeMarkersRegistration Error Message: Path

[JENKINS] Lucene-Solr-repro - Build # 164 - Unstable

Build: https://builds.apache.org/job/Lucene-Solr-repro/164/ [...truncated 28 lines...] [repro] Jenkins log URL: https://builds.apache.org/job/Lucene-Solr-BadApples-Tests-7.x/1/consoleText [repro] Revision: f48fc470f665d2eda1b959ec3472cd5f711afaa0 [repro] Repro line: ant test

[jira] [Created] (SOLR-12046) TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory fails on every windows build on jenkins.thetaphi.de ?

Hoss Man created SOLR-12046: --- Summary: TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory fails on every windows build on jenkins.thetaphi.de ? Key: SOLR-12046 URL: https://issues.apache.org/jira/browse/SOLR-12046

[jira] [Commented] (SOLR-12046) TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory fails on every windows build on jenkins.thetaphi.de ?

[ https://issues.apache.org/jira/browse/SOLR-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381322#comment-16381322 ] Hoss Man commented on SOLR-12046: - [~thetaphi]: if you get a chance, can you try out the patch in

[jira] [Commented] (SOLR-11960) Add collection level properties

[ https://issues.apache.org/jira/browse/SOLR-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381323#comment-16381323 ] Peter Rusko commented on SOLR-11960: {quote}BTW for this issue I personally would have chosen to store

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381062#comment-16381062 ] Shawn Heisey commented on SOLR-10912: - Some thoughts: If there's not an entry in CHANGES.txt that

[jira] [Updated] (SOLR-11960) Add collection level properties

[ https://issues.apache.org/jira/browse/SOLR-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Rusko updated SOLR-11960: --- Attachment: SOLR-11960.patch > Add collection level properties > --- > >

[jira] [Commented] (SOLR-11646) Ref Guide: Update API examples to include v2 style examples

[ https://issues.apache.org/jira/browse/SOLR-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381052#comment-16381052 ] ASF subversion and git services commented on SOLR-11646: Commit

[JENKINS] Lucene-Solr-BadApples-Tests-master - Build # 1 - Unstable

Build: https://builds.apache.org/job/Lucene-Solr-BadApples-Tests-master/1/ 8 tests failed. FAILED: org.apache.solr.ltr.TestLTRReRankingPipeline.testDifferentTopN Error Message: expected:<1.0> but was:<0.0> Stack Trace: java.lang.AssertionError: expected:<1.0> but was:<0.0> at

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381324#comment-16381324 ] Steve Rowe commented on SOLR-10912: --- bq. If there's not an entry in CHANGES.txt that mentions the issue

[jira] [Commented] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

[ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381341#comment-16381341 ] ASF subversion and git services commented on LUCENE-8188: - Commit

[jira] [Commented] (SOLR-11646) Ref Guide: Update API examples to include v2 style examples

[ https://issues.apache.org/jira/browse/SOLR-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381055#comment-16381055 ] ASF subversion and git services commented on SOLR-11646: Commit

[JENKINS] Lucene-Solr-Tests-7.x - Build # 472 - Unstable

Build: https://builds.apache.org/job/Lucene-Solr-Tests-7.x/472/ 1 tests failed. FAILED: org.apache.solr.cloud.MoveReplicaHDFSTest.testFailedMove Error Message: No live SolrServers available to handle this request:[http://127.0.0.1:38652/solr/MoveReplicaHDFSTest_failed_coll_true,

[jira] [Commented] (SOLR-12046) TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory fails on every windows build on jenkins.thetaphi.de ?

[ https://issues.apache.org/jira/browse/SOLR-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381318#comment-16381318 ] Hoss Man commented on SOLR-12046: - pretty sure LUCENE-8188 is the root cause here. >

[jira] [Commented] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

[ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381316#comment-16381316 ] Hoss Man commented on LUCENE-8188: -- I've attached a patch which seems like the correct fix to me – it

[jira] [Created] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

Hoss Man created LUCENE-8188: Summary: OpenNLPOpsFactory leaks filehandles of models Key: LUCENE-8188 URL: https://issues.apache.org/jira/browse/LUCENE-8188 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

[ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated LUCENE-8188: - Attachment: LUCENE-8188.patch > OpenNLPOpsFactory leaks filehandles of models >

[JENKINS] Lucene-Solr-master-Linux (64bit/jdk-9.0.4) - Build # 21554 - Still Unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/21554/ Java: 64bit/jdk-9.0.4 -XX:+UseCompressedOops -XX:+UseConcMarkSweepGC 2 tests failed. FAILED: org.apache.solr.cloud.MoveReplicaHDFSTest.testFailedMove Error Message: No live SolrServers available to handle this

[jira] [Commented] (SOLR-12046) TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory fails on every windows build on jenkins.thetaphi.de ?

[ https://issues.apache.org/jira/browse/SOLR-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381311#comment-16381311 ] Uwe Schindler commented on SOLR-12046: -- Good analysis! It looks like OpenNLP has a file leak and

[jira] [Commented] (SOLR-12046) TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory fails on every windows build on jenkins.thetaphi.de ?

[ https://issues.apache.org/jira/browse/SOLR-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381238#comment-16381238 ] Hoss Man commented on SOLR-12046: - FWIW... If you look at a recent failure on either the master or 7x

[jira] [Commented] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

[ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381340#comment-16381340 ] Steve Rowe commented on LUCENE-8188: +1 > OpenNLPOpsFactory leaks filehandles of models >

More tests to BaApple?

Here's three Uwe sent me: - org.apache.solr.cloud.autoscaling.TriggerIntegrationTest.testNodeMarkersRegistration - org.apache.solr.cloud.autoscaling.TriggerIntegrationTest.testSearchRate - org.apache.solr.cloud.hdfs.HdfsRecoveryZkTest I started to collect a bunch more, but then lost them

[jira] [Commented] (SOLR-12046) TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory fails on every windows build on jenkins.thetaphi.de ?

[ https://issues.apache.org/jira/browse/SOLR-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381263#comment-16381263 ] Hoss Man commented on SOLR-12046: - bq. A quick glance at a single recent failure (i haven't dug in depth

[jira] [Commented] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

[ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381329#comment-16381329 ] Uwe Schindler commented on LUCENE-8188: --- Those bugs should be found by resource checks in our

[jira] [Commented] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

[ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381331#comment-16381331 ] Uwe Schindler commented on LUCENE-8188: --- Hoss: looks fine. Commit that. Was not able to test

[jira] [Commented] (LUCENE-8182) BoostingQuery applies the wrong boost to the query score

[ https://issues.apache.org/jira/browse/LUCENE-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381350#comment-16381350 ] Hoss Man commented on LUCENE-8182: -- FYI: [~jim.ferenczi] - it appears you commited this fix & CHANGES

[JENKINS] Lucene-Solr-7.x-Windows (64bit/jdk1.8.0_144) - Build # 482 - Still unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Windows/482/ Java: 64bit/jdk1.8.0_144 -XX:-UseCompressedOops -XX:+UseG1GC 11 tests failed. FAILED: junit.framework.TestSuite.org.apache.lucene.analysis.pattern.TestSimplePatternSplitTokenizer Error Message: Could not remove the following

[jira] [Updated] (SOLR-12012) Replicas should skip doing recovery on startup if possible

[ https://issues.apache.org/jira/browse/SOLR-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao Manh Dat updated SOLR-12012: Summary: Replicas should skip doing recovery on startup if possible (was: Replicas should skip

[JENKINS] Lucene-Solr-SmokeRelease-7.x - Build # 161 - Still Failing

Build: https://builds.apache.org/job/Lucene-Solr-SmokeRelease-7.x/161/ No tests ran. Build Log: [...truncated 28782 lines...] prepare-release-no-sign: [mkdir] Created dir: /x1/jenkins/jenkins-slave/workspace/Lucene-Solr-SmokeRelease-7.x/lucene/build/smokeTestRelease/dist [copy] Copying

[JENKINS] Lucene-Solr-BadApples-7.x-Linux (64bit/jdk-9.0.4) - Build # 1 - Unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-BadApples-7.x-Linux/1/ Java: 64bit/jdk-9.0.4 -XX:+UseCompressedOops -XX:+UseG1GC 35 tests failed. FAILED: org.apache.solr.cloud.ZkControllerTest.testPublishAndWaitForDownStates Error Message: The ZkController.publishAndWaitForDownStates should

Re: Code Reviews

> Like Dawid I hope we won't add strict requirements to get changes reviewed > before merging but I do agree with the general sentiment that reviews are > helpful and improve code quality. This seems to be what the majority thinks and I see the point, I’m concerned of this myself. I’m just not

[jira] [Created] (SOLR-12047) Solr 7.x restart can fail to load some cores

Varun Thacker created SOLR-12047: Summary: Solr 7.x restart can fail to load some cores Key: SOLR-12047 URL: https://issues.apache.org/jira/browse/SOLR-12047 Project: Solr Issue Type: Bug

[jira] [Assigned] (SOLR-12046) TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory fails on every windows build on jenkins.thetaphi.de ?

[ https://issues.apache.org/jira/browse/SOLR-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man reassigned SOLR-12046: --- Assignee: Hoss Man I committed LUCENE-8188 -- i'll keep an eye on the jenkins failures to see if

[jira] [Resolved] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

[ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man resolved LUCENE-8188. -- Resolution: Fixed Assignee: Hoss Man Fix Version/s: 7.3 master (8.0)

[jira] [Commented] (SOLR-12011) Consistence problem when in-sync replicas are DOWN

[ https://issues.apache.org/jira/browse/SOLR-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381510#comment-16381510 ] Cao Manh Dat commented on SOLR-12011: - Found a bug in the previous patch. DUP should also skip replica

[jira] [Updated] (SOLR-11379) Config API to switch on/off lucene's logging infoStream

[ https://issues.apache.org/jira/browse/SOLR-11379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amrit Sarkar updated SOLR-11379: Attachment: SOLR-11379.patch > Config API to switch on/off lucene's logging infoStream >

[jira] [Commented] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

[ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381343#comment-16381343 ] ASF subversion and git services commented on LUCENE-8188: - Commit

[JENKINS] Lucene-Solr-repro - Build # 166 - Unstable

Build: https://builds.apache.org/job/Lucene-Solr-repro/166/ [...truncated 28 lines...] [repro] Jenkins log URL: https://builds.apache.org/job/Lucene-Solr-BadApples-Tests-master/1/consoleText [repro] Revision: ef989124f345af46a905d1196bc589ef37b221c9 [repro] Repro line: ant test

[JENKINS] Lucene-Solr-master-Windows (64bit/jdk1.8.0_144) - Build # 7199 - Still Unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Windows/7199/ Java: 64bit/jdk1.8.0_144 -XX:+UseCompressedOops -XX:+UseConcMarkSweepGC 15 tests failed. FAILED: junit.framework.TestSuite.org.apache.lucene.index.TestBackwardsCompatibility Error Message: Could not remove the following

[JENKINS] Lucene-Solr-BadApples-master-Linux (32bit/jdk1.8.0_162) - Build # 1 - Unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-BadApples-master-Linux/1/ Java: 32bit/jdk1.8.0_162 -client -XX:+UseConcMarkSweepGC 29 tests failed. FAILED: org.apache.solr.cloud.TestUtilizeNode.test Error Message: no replica should be present in 127.0.0.1:37847_solr Stack Trace:

[jira] [Commented] (SOLR-7821) example films data doesn't work consistently with data-driven schema (schemaless)

[ https://issues.apache.org/jira/browse/SOLR-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381574#comment-16381574 ] Swapnil M Mane commented on SOLR-7821: -- Nice, thanks [~ctargett] :) > example films data doesn't work

Re: Code Reviews

Like Dawid I hope we won't add strict requirements to get changes reviewed before merging but I do agree with the general sentiment that reviews are helpful and improve code quality. I really appreciate getting feedback on patches that I upload, including negative feedback and I don't mind being

[jira] [Updated] (SOLR-12011) Consistence problem when in-sync replicas are DOWN

[ https://issues.apache.org/jira/browse/SOLR-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao Manh Dat updated SOLR-12011: Attachment: SOLR-12011.patch > Consistence problem when in-sync replicas are DOWN >

[jira] [Commented] (SOLR-11379) Config API to switch on/off lucene's logging infoStream

[ https://issues.apache.org/jira/browse/SOLR-11379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381649#comment-16381649 ] Amrit Sarkar commented on SOLR-11379: - This patch works when infoStream is at least mentioned in the

[JENKINS] Lucene-Solr-NightlyTests-master - Build # 1490 - Still Unstable

Build: https://builds.apache.org/job/Lucene-Solr-NightlyTests-master/1490/ 3 tests failed. FAILED: org.apache.solr.cloud.hdfs.HdfsRestartWhileUpdatingTest.test Error Message: There are still nodes recoverying - waited for 320 seconds Stack Trace: java.lang.AssertionError: There are still nodes

[jira] [Commented] (SOLR-12011) Consistence problem when in-sync replicas are DOWN

[ https://issues.apache.org/jira/browse/SOLR-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379927#comment-16379927 ] Shalin Shekhar Mangar commented on SOLR-12011: -- Thanks Dat. A few comments: # The line

[jira] [Updated] (SOLR-12011) Consistence problem when in-sync replicas are DOWN

[ https://issues.apache.org/jira/browse/SOLR-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao Manh Dat updated SOLR-12011: Description: Currently, we will meet consistency problem when in-sync replicas are DOWN. For

[jira] [Commented] (SOLR-12011) Consistence problem when in-sync replicas are DOWN

[ https://issues.apache.org/jira/browse/SOLR-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379928#comment-16379928 ] Shalin Shekhar Mangar commented on SOLR-12011: -- Also, it'd be nice to describe in this issue

[jira] [Comment Edited] (SOLR-12011) Consistence problem when in-sync replicas are DOWN

[ https://issues.apache.org/jira/browse/SOLR-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379927#comment-16379927 ] Shalin Shekhar Mangar edited comment on SOLR-12011 at 2/28/18 8:19 AM:

[jira] [Updated] (SOLR-12011) Consistence problem when in-sync replicas are DOWN

[ https://issues.apache.org/jira/browse/SOLR-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao Manh Dat updated SOLR-12011: Description: Currently, we will meet consistency problem when in-sync replicas are DOWN. For

Re:Parsing exception when passed defType complexphrase vs. local parameters?

Hi Dawid, The symptoms you mention sound similar to the SOLR-11809 symptoms and the SOLR-11501 changes are probably the 'mysterious' change you might have been looking for? Christine - Original Message - From: dev@lucene.apache.org To: dev@lucene.apache.org Cc: m...@apache.org At:

Parsing exception when passed defType complexphrase vs. local parameters?

I am in the process of upgrading from Solr 6.x to 7.2.1 and one of the tests does query for: {!complexphrase inOrder=false}"(foo1 foo2) ba*" This works just fine. Another test specifies the query parser using defType=complexphrase and this query no longer parses: {!inOrder=false}"(foo1 foo2)

[jira] [Commented] (LUCENE-8159) Add a copy constructor in AutomatonQuery to copy directly the compiled automaton

[ https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380260#comment-16380260 ] Robert Muir commented on LUCENE-8159: - -1 to a copy constructor. This is java! > Add a copy

[JENKINS] Lucene-Solr-master-MacOSX (64bit/jdk-9) - Build # 4467 - Still unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-MacOSX/4467/ Java: 64bit/jdk-9 -XX:-UseCompressedOops -XX:+UseSerialGC 1 tests failed. FAILED: org.apache.solr.cloud.ForceLeaderTest.testReplicasInLowerTerms Error Message: Doc with id=5 not found in

[JENKINS] Lucene-Solr-repro - Build # 162 - Still Unstable

Build: https://builds.apache.org/job/Lucene-Solr-repro/162/ [...truncated 28 lines...] [repro] Jenkins log URL: https://builds.apache.org/job/Lucene-Solr-NightlyTests-master/1490/consoleText [repro] Revision: 7dba350c7a02fe603faec49227ff2672e4d8e6ae [repro] Ant options: -Dtests.multiplier=2

[jira] [Resolved] (SOLR-6615) Refactor code to use String constants

[ https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-6615. -- Resolution: Fixed Fix Version/s: 7.0 A lot of these are fixed . if required , we can open a new

[jira] [Commented] (LUCENE-8159) Add a copy constructor in AutomatonQuery to copy directly the compiled automaton

[ https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380407#comment-16380407 ] Bruno Roustant commented on LUCENE-8159: [~rcmuir] could you be a little more explicit? Without

BinaryDocValues prefix bytes

Hi, I'm having an index where I'm storing a binary doc value being equal to a serialized 8 byte value. The values are consumed by a custom Query implementation, using LeafReader.getBinaryDocValues(). However, what I found is the following. To each binary doc value returned by

[JENKINS] Lucene-Solr-master-Linux (32bit/jdk1.8.0_162) - Build # 21552 - Still unstable!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/21552/ Java: 32bit/jdk1.8.0_162 -client -XX:+UseParallelGC 1 tests failed. FAILED: org.apache.solr.handler.admin.SegmentsInfoRequestHandlerTest.testSegmentInfosVersion Error Message: Exception during query Stack Trace:

Re: Parsing exception when passed defType complexphrase vs. local parameters?

Yeah this is almost certainly SOLR-11501. I bet you have defType=edismax or something. Essentially, the reason being is if you set defType=whatever then your query should be using that query parser and not something embedded into 'q' (i.e. the user shouldn't be able to change it). So either

[jira] [Commented] (SOLR-12043) Add mlt.maxdfpct to Solr's documentation

[ https://issues.apache.org/jira/browse/SOLR-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380438#comment-16380438 ] Cassandra Targett commented on SOLR-12043: -- +1 Dawid, doc addition looks good. > Add

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380458#comment-16380458 ] David Smiley commented on SOLR-10912: - I'm confused what the state is right now. In JIRA I see these

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380464#comment-16380464 ] Steve Rowe commented on SOLR-10912: --- bq. I'm confused what the state is right now. In JIRA I see these

[JENKINS] Lucene-Solr-7.x-MacOSX (64bit/jdk-9) - Build # 479 - Still Failing!

Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-MacOSX/479/ Java: 64bit/jdk-9 -XX:-UseCompressedOops -XX:+UseG1GC No tests ran. Build Log: [...truncated 55971 lines...] [repro] Jenkins log URL: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-MacOSX/479/consoleText [repro] Revision:

[jira] [Updated] (SOLR-10894) Streaming expressions handling of escaped special characters bug

[ https://issues.apache.org/jira/browse/SOLR-10894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-10894: -- Component/s: streaming expressions > Streaming expressions handling of escaped special

[jira] [Commented] (SOLR-12045) Move Analytics Component from contrib to core

[ https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380497#comment-16380497 ] Houston Putman commented on SOLR-12045: --- I ran into some confusion when adding the `/analytics`

[jira] [Commented] (SOLR-10028) SegmentsInfoRequestHandlerTest.testSegmentInfosVersion fails in master

[ https://issues.apache.org/jira/browse/SOLR-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380529#comment-16380529 ] Steve Rowe commented on SOLR-10028: --- Another reproducing master seed from

[jira] [Comment Edited] (LUCENE-8159) Add a copy constructor in AutomatonQuery to copy directly the compiled automaton

[ https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380407#comment-16380407 ] Bruno Roustant edited comment on LUCENE-8159 at 2/28/18 2:58 PM: -

Re: BinaryDocValues prefix bytes

This can't be; it must be a bug. Perhaps you are saving away the BytesRef by reference across multiple invocations? That won't work; you may have to clone/copy it. On Wed, Feb 28, 2018 at 9:53 AM Dominik Safaric wrote: > Hi, > > I'm having an index where I'm storing

[jira] [Commented] (SOLR-7821) example films data doesn't work consistently with data-driven schema (schemaless)

[ https://issues.apache.org/jira/browse/SOLR-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380434#comment-16380434 ] Cassandra Targett commented on SOLR-7821: - [~swapnilmmane] - the screenshot was fixed for

Re: Parsing exception when passed defType complexphrase vs. local parameters?

Yeah, this is SOLR-11501 -- I missed this change somehow. I will update the tests; they assume people could tweak local parameters for a query parser. Thanks for pointing me at the right issue! D. On Wed, Feb 28, 2018 at 3:56 PM, David Smiley wrote: > Yeah this is

[jira] [Created] (SOLR-12044) Optimize MatchAllDocsQuery for DocSets more

David Smiley created SOLR-12044: --- Summary: Optimize MatchAllDocsQuery for DocSets more Key: SOLR-12044 URL: https://issues.apache.org/jira/browse/SOLR-12044 Project: Solr Issue Type: Bug

[jira] [Created] (SOLR-12045) Move Analytics Component from contrib to core

Houston Putman created SOLR-12045: - Summary: Move Analytics Component from contrib to core Key: SOLR-12045 URL: https://issues.apache.org/jira/browse/SOLR-12045 Project: Solr Issue Type:

[jira] [Comment Edited] (SOLR-12045) Move Analytics Component from contrib to core

[ https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380497#comment-16380497 ] Houston Putman edited comment on SOLR-12045 at 2/28/18 3:49 PM: I ran into

[GitHub] lucene-solr pull request #330: SOLR-12045: Moving the Analytics Component fr...

GitHub user HoustonPutman opened a pull request: https://github.com/apache/lucene-solr/pull/330 SOLR-12045: Moving the Analytics Component from contrib to core. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (SOLR-12011) Consistence problem when in-sync replicas are DOWN

[ https://issues.apache.org/jira/browse/SOLR-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao Manh Dat updated SOLR-12011: Description: Currently, we will meet consistency problem when in-sync replicas are DOWN. For

[jira] [Updated] (SOLR-7821) example films data doesn't work consistently with data-driven schema (schemaless)

[ https://issues.apache.org/jira/browse/SOLR-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated SOLR-7821: - Attachment: tutorial-add-field.png > example films data doesn't work consistently with data-driven

  1   2   >