[jira] [Updated] (SOLR-8359) Restrict child classes from using parent logger's state

[ https://issues.apache.org/jira/browse/SOLR-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8359: -- Attachment: SOLR-8359-nonfinal-values.patch I've attached a version of the patch (SOLR-8359-nonfi

[jira] [Commented] (SOLR-8266) Remove Java Serialization from the Streaming API

[ https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043915#comment-15043915 ] Jason Gerlowski commented on SOLR-8266: --- After having some time to read up on the Str

[jira] [Updated] (SOLR-8266) Remove Java Serialization from the Streaming API

[ https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8266: -- Attachment: SOLR-8266.patch Making the first two changes Joel laid out (StreamHandler and Paralle

[jira] [Commented] (SOLR-8266) Remove Java Serialization from the Streaming API

[ https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044882#comment-15044882 ] Jason Gerlowski commented on SOLR-8266: --- Yeah, I'd keyed in to that part of the error

[jira] [Updated] (SOLR-8266) Remove Java Serialization from the Streaming API

[ https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8266: -- Attachment: SOLR-8266-comment-out-testParallelEOF.patch Thanks for the early look/help guys. I'v

[jira] [Comment Edited] (SOLR-8266) Remove Java Serialization from the Streaming API

[ https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045641#comment-15045641 ] Jason Gerlowski edited comment on SOLR-8266 at 12/7/15 8:21 PM: -

[jira] [Commented] (SOLR-8266) Remove Java Serialization from the Streaming API

[ https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046221#comment-15046221 ] Jason Gerlowski commented on SOLR-8266: --- No problem; hopefully you're still as thankf

[jira] [Created] (SOLR-8385) Narrow StreamFactory.withFunctionName clazz parameter to prevent misconfiguration.

Jason Gerlowski created SOLR-8385: - Summary: Narrow StreamFactory.withFunctionName clazz parameter to prevent misconfiguration. Key: SOLR-8385 URL: https://issues.apache.org/jira/browse/SOLR-8385 Proj

[jira] [Updated] (SOLR-8385) Narrow StreamFactory.withFunctionName clazz parameter to prevent misconfiguration.

[ https://issues.apache.org/jira/browse/SOLR-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8385: -- Description: Currently, {{StreamFactory}} has several overloaded {{withFunctionName}} methods.

[jira] [Updated] (SOLR-8385) Narrow StreamFactory.withFunctionName clazz parameter to prevent misconfiguration.

[ https://issues.apache.org/jira/browse/SOLR-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8385: -- Attachment: SOLR-8385.patch Patch. Changes the Type for functionName values from {{Class}} to {{

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch Updates patch on top of recent changes in master. Tests pass locally.

[jira] [Commented] (SOLR-8765) Enforce required parameters in SolrJ Collection APIs

[ https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188416#comment-15188416 ] Jason Gerlowski commented on SOLR-8765: --- IMO, Id rather have {{SolrIdentifierValidato

[jira] [Comment Edited] (SOLR-8765) Enforce required parameters in SolrJ Collection APIs

[ https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188416#comment-15188416 ] Jason Gerlowski edited comment on SOLR-8765 at 3/10/16 12:57 AM:

[jira] [Comment Edited] (SOLR-8765) Enforce required parameters in SolrJ Collection APIs

[ https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188416#comment-15188416 ] Jason Gerlowski edited comment on SOLR-8765 at 3/10/16 1:15 AM: -

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch Thanks for the review Anshum. Made all the changes you suggested wit

[jira] [Created] (SOLR-8836) /update should return BAD REQUEST when invalid JSON provided

Jason Gerlowski created SOLR-8836: - Summary: /update should return BAD REQUEST when invalid JSON provided Key: SOLR-8836 URL: https://issues.apache.org/jira/browse/SOLR-8836 Project: Solr Is

[jira] [Updated] (SOLR-8836) /update should return BAD REQUEST when invalid JSON provided

[ https://issues.apache.org/jira/browse/SOLR-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8836: -- Attachment: SOLR-8836.patch A simple patch demonstrating a fix for the issue. With this fix, /up

[jira] [Commented] (SOLR-8801) /bin/solr create script always returns exit code 0

[ https://issues.apache.org/jira/browse/SOLR-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192483#comment-15192483 ] Jason Gerlowski commented on SOLR-8801: --- +1. Patch looks good to me. Seems like a s

[jira] [Commented] (SOLR-8808) SolrJ deleteById causes missing content stream exception

[ https://issues.apache.org/jira/browse/SOLR-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192487#comment-15192487 ] Jason Gerlowski commented on SOLR-8808: --- +1 for this JIRA. SolrJ code tends to take

[jira] [Updated] (SOLR-8836) /update should return BAD REQUEST when invalid JSON provided

[ https://issues.apache.org/jira/browse/SOLR-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8836: -- Attachment: SOLR-8836.patch Looking into Solr's error messages more, I think the error-message is

[jira] [Updated] (SOLR-8808) SolrJ deleteById causes missing content stream exception

[ https://issues.apache.org/jira/browse/SOLR-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8808: -- Attachment: SOLR-8808.patch Uploaded patch contains changes to SolrClient.java. It also adds a s

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch Ok, so after a bit of a delay, I've got an updated patch which attemp

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146604#comment-15146604 ] Jason Gerlowski commented on SOLR-8677: --- Thanks for the review Shai. Do you want to

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146701#comment-15146701 ] Jason Gerlowski commented on SOLR-8677: --- I'll just roll it into this patch. Just wan

[jira] [Updated] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8677: -- Attachment: SOLR-8677.patch Updated the patch with the changes to SolrJ that Shai suggested. A f

[jira] [Commented] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148692#comment-15148692 ] Jason Gerlowski commented on SOLR-8110: --- Anyone object to my starting on this? Think

[jira] [Commented] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148954#comment-15148954 ] Jason Gerlowski commented on SOLR-8110: --- Personally, I'd be fine with allowing field

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149540#comment-15149540 ] Jason Gerlowski commented on SOLR-8677: --- Good changes. I'd thought about having Solr

[jira] [Commented] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156250#comment-15156250 ] Jason Gerlowski commented on SOLR-8110: --- 1.) Sounds like (aside from a few comments a

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156251#comment-15156251 ] Jason Gerlowski commented on SOLR-8097: --- Just wanted to give this issue a little 'bum

[jira] [Updated] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8110: -- Attachment: SOLR-8110.patch Not ready for review yet. Just putting it up here as backup (or in c

[jira] [Commented] (SOLR-8462) Improve error reporting for /stream handler

[ https://issues.apache.org/jira/browse/SOLR-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282645#comment-15282645 ] Jason Gerlowski commented on SOLR-8462: --- Sure; I'll take a look at it this weekend.

[jira] [Commented] (SOLR-8830) client error messages should be consistent even when updates are internally routed to other nodes

[ https://issues.apache.org/jira/browse/SOLR-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221754#comment-15221754 ] Jason Gerlowski commented on SOLR-8830: --- Can anyone give me a little guidance on wher

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227040#comment-15227040 ] Jason Gerlowski commented on SOLR-8097: --- Yep, working on updating the patch now. It

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228430#comment-15228430 ] Jason Gerlowski commented on SOLR-8097: --- So, I've got an updated patch that does ever

[jira] [Comment Edited] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228430#comment-15228430 ] Jason Gerlowski edited comment on SOLR-8097 at 4/6/16 3:10 PM: --

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch Uploading a patch that has everything except the renames. (See my co

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237634#comment-15237634 ] Jason Gerlowski commented on SOLR-8097: --- I thought about doing that as a part of my p

[jira] [Created] (SOLR-8975) SolrClient setters should be deprecated in favor of SolrClientBuilder methods

Jason Gerlowski created SOLR-8975: - Summary: SolrClient setters should be deprecated in favor of SolrClientBuilder methods Key: SOLR-8975 URL: https://issues.apache.org/jira/browse/SOLR-8975 Project:

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237870#comment-15237870 ] Jason Gerlowski commented on SOLR-8097: --- I created SOLR-8975 for this work, with a sh

[jira] [Commented] (SOLR-8975) SolrClient setters should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283920#comment-15283920 ] Jason Gerlowski commented on SOLR-8975: --- Sitting down to start working on this now.

[jira] [Commented] (SOLR-8774) Store the latest available version of a blob so that some components can access it w/o version

[ https://issues.apache.org/jira/browse/SOLR-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286621#comment-15286621 ] Jason Gerlowski commented on SOLR-8774: --- Af first glance, this seems like a feature t

[jira] [Commented] (SOLR-8830) client error messages should be consistent even when updates are internally routed to other nodes

[ https://issues.apache.org/jira/browse/SOLR-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197679#comment-15197679 ] Jason Gerlowski commented on SOLR-8830: --- Is this problem only limited to updates, or

[jira] [Commented] (SOLR-8830) client error messages should be consistent even when updates are internally routed to other nodes

[ https://issues.apache.org/jira/browse/SOLR-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204077#comment-15204077 ] Jason Gerlowski commented on SOLR-8830: --- Short non-update here: Spent a little time

[jira] [Updated] (SOLR-8830) client error messages should be consistent even when updates are internally routed to other nodes

[ https://issues.apache.org/jira/browse/SOLR-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8830: -- Attachment: SOLR-8830.patch Might've been going down the wrong path before. I realized that it's

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207360#comment-15207360 ] Jason Gerlowski commented on SOLR-8097: --- I didn't forget, but I was unsure whether th

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch Ok, this removes all* uses of the now-deprecated constructors. The a

[jira] [Commented] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214974#comment-15214974 ] Jason Gerlowski commented on SOLR-8110: --- Maybe I'm missing something, but how would a

[jira] [Commented] (SOLR-8642) SOLR allows creation of collections with invalid names

[ https://issues.apache.org/jira/browse/SOLR-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214997#comment-15214997 ] Jason Gerlowski commented on SOLR-8642: --- Sorry to hear that this is causing so much t

[jira] [Commented] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166397#comment-15166397 ] Jason Gerlowski commented on SOLR-8110: --- Noticed something a little odd (to me) while

[jira] [Comment Edited] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166397#comment-15166397 ] Jason Gerlowski edited comment on SOLR-8110 at 2/25/16 12:18 AM:

[jira] [Updated] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8110: -- Attachment: SOLR-8110.patch Slightly updated patch. Few notes - still no tests. I can test cor

[jira] [Comment Edited] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166571#comment-15166571 ] Jason Gerlowski edited comment on SOLR-8110 at 2/25/16 2:09 AM: -

[jira] [Commented] (SOLR-8725) Invalid name error with core names with hyphens

[ https://issues.apache.org/jira/browse/SOLR-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168994#comment-15168994 ] Jason Gerlowski commented on SOLR-8725: --- For context, this was initially changed in S

[jira] [Commented] (SOLR-8725) Cores, collections, and shards should accept hyphens in identifier name

[ https://issues.apache.org/jira/browse/SOLR-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170622#comment-15170622 ] Jason Gerlowski commented on SOLR-8725: --- Hey [~anshumg], were you planning on changin

[jira] [Commented] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170637#comment-15170637 ] Jason Gerlowski commented on SOLR-8110: --- bq. If we expand the set to include what peo

[jira] [Comment Edited] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170637#comment-15170637 ] Jason Gerlowski edited comment on SOLR-8110 at 2/27/16 5:21 PM: -

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170676#comment-15170676 ] Jason Gerlowski commented on SOLR-8097: --- Gonna revert my different name (updateLeader

[jira] [Comment Edited] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170695#comment-15170695 ] Jason Gerlowski edited comment on SOLR-8097 at 2/27/16 6:40 PM: -

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170695#comment-15170695 ] Jason Gerlowski commented on SOLR-8097: --- Thanks for the review Anshum. Sorry it took

[jira] [Comment Edited] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170695#comment-15170695 ] Jason Gerlowski edited comment on SOLR-8097 at 2/27/16 9:40 PM: -

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170749#comment-15170749 ] Jason Gerlowski commented on SOLR-8097: --- So, looking close at these builder classes,

[jira] [Comment Edited] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170749#comment-15170749 ] Jason Gerlowski edited comment on SOLR-8097 at 2/27/16 10:45 PM:

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch Puts patch on top of latest trunk/master. Fixes some of Anshum's con

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch Adds tests for each builder. Removes abstract-class approach. Still

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch bq. Let's carry on with adding tests, javadocs, deprecation, and also

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch Oops, the carelessness of {{git add -A}} (and the user who ran it) st

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176410#comment-15176410 ] Jason Gerlowski commented on SOLR-8097: --- bq. we need to continue testing the current

[jira] [Commented] (SOLR-8765) Enforce required parameters in SolrJ Collection APIs

[ https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176577#comment-15176577 ] Jason Gerlowski commented on SOLR-8765: --- I've been poking around in that code a bit r

[jira] [Updated] (SOLR-8398) Remove deprecated support in solrconfig

[ https://issues.apache.org/jira/browse/SOLR-8398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8398: -- Attachment: SOLR-8398.patch Updates patch to apply-cleanly on top of latest master. > Remove dep

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179287#comment-15179287 ] Jason Gerlowski commented on SOLR-8097: --- Hmm, still seeing some test failures with th

[jira] [Updated] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8097: -- Attachment: SOLR-8097.patch > Implement a builder pattern for constructing a Solrj client > -

[jira] [Updated] (SOLR-8766) remove the deprecated tag from solrconfig.xml

[ https://issues.apache.org/jira/browse/SOLR-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8766: -- Attachment: SOLR-8766.patch This patch scrubs any/all tags from solrconfig.xml. > remove the de

[jira] [Updated] (SOLR-10915) Make SolrClient classes extendable without code duplication

[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-10915: --- Attachment: SOLR-10915.patch.with-deprecations SOLR-10915.patch.without-depreca

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055713#comment-16055713 ] Jason Gerlowski commented on SOLR-10915: (Both patches contain the CloudSolrClient

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056053#comment-16056053 ] Jason Gerlowski commented on SOLR-10915: A few responses: bq. Where a Builder cla

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056201#comment-16056201 ] Jason Gerlowski commented on SOLR-10915: I think I'm reading you wrong. bq. we sh

[jira] [Updated] (SOLR-10915) Make SolrClient classes extendable without code duplication

[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-10915: --- Attachment: SOLR-10915.patch Updated patch. The only constructor I was able to remove outrigh

[jira] [Commented] (SOLR-10931) Resolve conflicting package names o.a.s.cloud.autoscaling

[ https://issues.apache.org/jira/browse/SOLR-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057562#comment-16057562 ] Jason Gerlowski commented on SOLR-10931: A majority of SolrJ packages start with {

[jira] [Updated] (SOLR-10931) Resolve conflicting package names o.a.s.cloud.autoscaling

[ https://issues.apache.org/jira/browse/SOLR-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-10931: --- Attachment: SOLR-10931.patch Uploaded a patch with the package rename. There were a few packa

[jira] [Commented] (SOLR-10768) Solrj wraps RemoteSolrException in SolrServerException for V2Request but not for v1 API requests

[ https://issues.apache.org/jira/browse/SOLR-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063044#comment-16063044 ] Jason Gerlowski commented on SOLR-10768: Hey Shalin, are there any particular step

[jira] [Created] (SOLR-10956) Document SolrClient use of RemoteSolrException

Jason Gerlowski created SOLR-10956: -- Summary: Document SolrClient use of RemoteSolrException Key: SOLR-10956 URL: https://issues.apache.org/jira/browse/SOLR-10956 Project: Solr Issue Type: B

[jira] [Commented] (SOLR-10768) Solrj wraps RemoteSolrException in SolrServerException for V2Request but not for v1 API requests

[ https://issues.apache.org/jira/browse/SOLR-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063796#comment-16063796 ] Jason Gerlowski commented on SOLR-10768: Ah I should have been more clear. That's

[jira] [Commented] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064093#comment-16064093 ] Jason Gerlowski commented on LUCENE-5822: - Does anyone have any bandwidth to take

[jira] [Commented] (SOLR-10956) Document SolrClient use of RemoteSolrException

[ https://issues.apache.org/jira/browse/SOLR-10956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064145#comment-16064145 ] Jason Gerlowski commented on SOLR-10956: Currently, most {{SolrClient}} Javadocs s

[jira] [Commented] (SOLR-10956) Document SolrClient use of RemoteSolrException

[ https://issues.apache.org/jira/browse/SOLR-10956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064144#comment-16064144 ] Jason Gerlowski commented on SOLR-10956: Based on some quick digging, it looks lik

[jira] [Updated] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated LUCENE-5822: Attachment: LUCENE-5822.patch Thanks for the feedback Mike. Made all the changes you reque

[jira] [Updated] (SOLR-10956) Document SolrClient use of RemoteSolrException

[ https://issues.apache.org/jira/browse/SOLR-10956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-10956: --- Description: Currently, {{SolrClient}} s Javadocs specify that it throws IOException, and Sol

[jira] [Commented] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071267#comment-16071267 ] Jason Gerlowski commented on LUCENE-5822: - Sorry for the trouble Mike! Is there

[jira] [Updated] (SOLR-10456) timeout-related setters should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-10456: --- Description: Now that builders are in place for {{SolrClients}}, the setters used in each {{S

[jira] [Updated] (SOLR-10456) timeout-related setters should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-10456: --- Attachment: SOLR-10456.patch Updates the patch on this issue to apply cleanly on top of master

[jira] [Updated] (SOLR-10456) timeout-related setters should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-10456: --- Attachment: SOLR-10456.patch > timeout-related setters should be deprecated in favor of SolrCl

[jira] [Commented] (SOLR-10967) Cleanup the default configset

[ https://issues.apache.org/jira/browse/SOLR-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072611#comment-16072611 ] Jason Gerlowski commented on SOLR-10967: {code} + For more information, on how t

[jira] [Comment Edited] (SOLR-10967) Cleanup the default configset

[ https://issues.apache.org/jira/browse/SOLR-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072611#comment-16072611 ] Jason Gerlowski edited comment on SOLR-10967 at 7/3/17 3:15 PM:

[jira] [Comment Edited] (SOLR-10456) timeout-related setters should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072975#comment-16072975 ] Jason Gerlowski edited comment on SOLR-10456 at 7/3/17 11:40 PM: ---

[jira] [Comment Edited] (SOLR-10456) timeout-related setters should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072975#comment-16072975 ] Jason Gerlowski edited comment on SOLR-10456 at 7/3/17 11:40 PM: ---

[jira] [Commented] (SOLR-10456) timeout-related setters should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072975#comment-16072975 ] Jason Gerlowski commented on SOLR-10456: > In the following code, guess we should

[jira] [Created] (SOLR-11004) Consolidate SolrClient Builder code in abstract parent class

Jason Gerlowski created SOLR-11004: -- Summary: Consolidate SolrClient Builder code in abstract parent class Key: SOLR-11004 URL: https://issues.apache.org/jira/browse/SOLR-11004 Project: Solr

[jira] [Updated] (SOLR-11004) Consolidate SolrClient Builder code in abstract parent class

[ https://issues.apache.org/jira/browse/SOLR-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-11004: --- Attachment: SOLR-11004.patch Patch attached; a few notes: - all SolrClient Builders now exten

[jira] [Comment Edited] (SOLR-11004) Consolidate SolrClient Builder code in abstract parent class

[ https://issues.apache.org/jira/browse/SOLR-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074140#comment-16074140 ] Jason Gerlowski edited comment on SOLR-11004 at 7/5/17 12:57 AM: ---

<    1   2   3   4   5   6   7   8   9   >